[Mesa-dev] [PATCH] mesa: Add a _mesa_problem to document a piglit failure on i965.

2013-06-05 Thread Eric Anholt
Having figured out what was going on with piglit fbo-depth copypixels GL_DEPTH_COMPONENT32F (falling all the way back to swrast on CopyPixels to a float depth buffer), I'm not inclined to fix the problem currently but it seems worth saving someone else the debug time. --- src/mesa/swrast/s_depth.c

[Mesa-dev] [PATCH] mesa: Prevent possible out-of-bounds read by save_SamplerParameteriv.

2013-06-05 Thread Vinson Lee
Fixes "Out-of-bounds access" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/main/dlist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index abc8665..8900c89 100644 --- a/src/mesa/main/dlist.c +++ b/src/

Re: [Mesa-dev] [PATCH 1/2] i965/clip: Add support for gl_ClipVertex

2013-06-05 Thread Kenneth Graunke
On 06/05/2013 03:50 PM, Chris Forbes wrote: When clipping against a user clip plane, and gl_ClipVertex is provided in the vertex, use it instead of hpos. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip.h | 1 + src/mesa/drivers/dri/i965/brw_clip_tri.c | 44 +++

Re: [Mesa-dev] [PATCH 2/7] intel: Move BCS_SWCTRL setup to a helper function.

2013-06-05 Thread Kenneth Graunke
On 06/05/2013 10:14 AM, Eric Anholt wrote: This will get reused shortly. --- src/mesa/drivers/dri/intel/intel_blit.c | 70 + 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_blit.c b/src/mesa/drivers/dri/intel/int

Re: [Mesa-dev] [PATCH 5/7] intel: Directly implement blit glBlitFramebuffer instead of awkward reuse.

2013-06-05 Thread Kenneth Graunke
On 06/05/2013 10:14 AM, Eric Anholt wrote: This gets us support for blitting to attachment types other than textures. --- src/mesa/drivers/dri/intel/intel_fbo.c | 129 +++- src/mesa/drivers/dri/intel/intel_tex.h | 7 -- src/mesa/drivers/dri/intel/intel_tex_

Re: [Mesa-dev] [PATCH 4/7] intel: Move XRGB->ARGB blit logic into intel_miptree_blit().

2013-06-05 Thread Kenneth Graunke
On 06/05/2013 10:14 AM, Eric Anholt wrote: Now any caller (such as glCopyPixels()) can benefit from it, and it only changes the correct subset of the destination instead of a whole teximage. --- src/mesa/drivers/dri/intel/intel_blit.c | 114 ++ src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] build: Use PACKAGE_VERSION from autoconf

2013-06-05 Thread Kenneth Graunke
On 06/05/2013 02:42 AM, Andreas Boll wrote: Both variables had the same value. Signed-off-by: Andreas Boll --- Makefile.am |1 - docs/devinfo.html |1 - 2 files changed, 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 92b792d..29405a0 100644 --- a/Makefile.am +++

Re: [Mesa-dev] [PATCH] glsl linker: Initialize member variable interface_namespace.

2013-06-05 Thread Kenneth Graunke
On 05/23/2013 11:54 PM, Vinson Lee wrote: Fixes "Uninitialized pointer field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/glsl/lower_named_interface_blocks.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/lower_named_interface_blocks.cpp

[Mesa-dev] [Bug 64084] Requesting git commit access to mesa

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64084 --- Comment #2 from Eric Anholt --- You already had access to the mesa repo :P I have added you to piglit though. Any chance we could get some tests for these fine new extensions? :) -- You are receiving this mail because: You are the assigne

Re: [Mesa-dev] [PATCH v3] Rename the _mesa_lookup_enum_by_nr() function Renamed function _mesa_lookup_prim_by_nr() to _mesa_prim_string() _mesa_lookup_enum_by_nr() to _mesa_enum_string() _mesa_lookup_

2013-06-05 Thread Arnas Milaševičius
And how should I deal with the files, which has all the 3 functions in them? Should I add them in one of the 3 patches or should I add them in all the 3 patches? On Thu, Jun 6, 2013 at 12:24 AM, Kenneth Graunke wrote: > This patch is really doing three related, but independent things: > 1. Renam

Re: [Mesa-dev] [PATCH v2] Renamed functions for file enums.c

2013-06-05 Thread Arnas Milaševičius
_mesa_lookup_enum_by_nr() -> _mesa_enum_string() _mesa_lookup_prim_by_nr() -> _mesa_prim_string() _mesa_lookup_enum_by_name() -> _mesa_enum_value() On Wed, Jun 5, 2013 at 8:20 PM, Eric Anholt wrote: > Arnas Milasevicius writes: > > > _mesa_prim_nr changed in: > > > > src/mesa/main/api_validate

Re: [Mesa-dev] [PATCH 1/3] gallium/tgsi: add missing string for layer semantic

2013-06-05 Thread Roland Scheidegger
Am 06.06.2013 04:16, schrieb Roland Scheidegger: > Am 06.06.2013 02:52, schrieb Brian Paul: >> On 06/05/2013 05:44 PM, srol...@vmware.com wrote: >>> From: Roland Scheidegger >>> >>> Also report if a shader writes the layer semantic >>> --- >>> src/gallium/auxiliary/draw/draw_context.c |2 +-

Re: [Mesa-dev] EGL_BAD_CONTEXT error when creating shared context

2013-06-05 Thread Divick Kishore
On Wed, Jun 5, 2013 at 10:33 PM, Chad Versace wrote: > Divick, you created two EGLDisplays. Did you obtain each EGLDisplay by > passing the same > native display to eglGetDisplay? If so, then EGL should have returned the > same EGLDisplay > pointer. The EGL spec requires that, and Mesa's libEGL h

Re: [Mesa-dev] [PATCH] intel: flush fake front buffer if server is about to destroy it.

2013-06-05 Thread Anuj Phogat
On Fri, May 31, 2013 at 1:55 PM, Paul Berry wrote: > Fixes piglit test "spec/!OpenGL 1.0/gl-1.0-front-invalidate-back" > --- > This patch depends on "[PATCH 2/2] intel: flush fake front buffer more > robustly.", which was sent to mesa-dev yesterday and is still awaiting > review. > > src/mesa/dri

[Mesa-dev] [Bug 64084] Requesting git commit access to mesa

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64084 --- Comment #1 from Kenneth Graunke --- Fine by me. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.free

Re: [Mesa-dev] [PATCH 1/2] intel: make intel_flush_front safe to call during initial MakeCurrent

2013-06-05 Thread Anuj Phogat
On Thu, May 30, 2013 at 7:44 AM, Paul Berry wrote: > The patch that follows will fix a bug that prevents > intel_flush_front() from being called often enough. In doing so, it > will create a situation where intel_flush_front() during the initial > call to glXMakeCurrent(). In this circumstance,

Re: [Mesa-dev] [PATCH 1/3] gallium/tgsi: add missing string for layer semantic

2013-06-05 Thread Roland Scheidegger
Am 06.06.2013 02:52, schrieb Brian Paul: > On 06/05/2013 05:44 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Also report if a shader writes the layer semantic >> --- >> src/gallium/auxiliary/draw/draw_context.c |2 +- >> src/gallium/auxiliary/tgsi/tgsi_scan.c|5 +++

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: add support for layered rendering

2013-06-05 Thread Roland Scheidegger
Am 06.06.2013 03:15, schrieb Brian Paul: > Reviewed-by: Brian Paul > > Just two minor nits below. > > > On 06/05/2013 05:44 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Mostly just make sure the layer parameter gets passed through to the >> right >> places (and get clamped,

Re: [Mesa-dev] [PATCH] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-05 Thread Brian Paul
On 06/05/2013 01:57 PM, Arnas Milasevicius wrote: Because these 2 functions are only used in state_tracker's st_draw_feedback.c file, I moved them there from draw_pt.c and made them static. --- src/gallium/auxiliary/draw/draw_context.h | 10 src/gallium/auxiliary/draw/draw_pt.c

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: add support for layered rendering

2013-06-05 Thread Brian Paul
Reviewed-by: Brian Paul Just two minor nits below. On 06/05/2013 05:44 PM, srol...@vmware.com wrote: From: Roland Scheidegger Mostly just make sure the layer parameter gets passed through to the right places (and get clamped, can do this at setup time), fix up clears to clear all layers and

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: bump 3d and cube map limits to 2048 and 8192 respectively

2013-06-05 Thread Brian Paul
On 06/05/2013 05:44 PM, srol...@vmware.com wrote: From: Roland Scheidegger These should just work (?), required by d3d10. Too large resources will get thrown out separately anyway. Yeah, that was the point of my pipe_screen::can_create_resource() change a while back. While the 3D texture si

Re: [Mesa-dev] [PATCH 1/3] gallium/tgsi: add missing string for layer semantic

2013-06-05 Thread Brian Paul
On 06/05/2013 05:44 PM, srol...@vmware.com wrote: From: Roland Scheidegger Also report if a shader writes the layer semantic --- src/gallium/auxiliary/draw/draw_context.c |2 +- src/gallium/auxiliary/tgsi/tgsi_scan.c|5 + src/gallium/auxiliary/tgsi/tgsi_scan.h|1 +

[Mesa-dev] [PATCH 3/3] llvmpipe: bump 3d and cube map limits to 2048 and 8192 respectively

2013-06-05 Thread sroland
From: Roland Scheidegger These should just work (?), required by d3d10. Too large resources will get thrown out separately anyway. --- src/gallium/drivers/llvmpipe/lp_limits.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_limits.h b/s

[Mesa-dev] [PATCH 2/3] llvmpipe: add support for layered rendering

2013-06-05 Thread sroland
From: Roland Scheidegger Mostly just make sure the layer parameter gets passed through to the right places (and get clamped, can do this at setup time), fix up clears to clear all layers and disable opaque optimization. Luckily don't need to touch the jitted code. (Clears invoked via pipe's clear

[Mesa-dev] [PATCH 1/3] gallium/tgsi: add missing string for layer semantic

2013-06-05 Thread sroland
From: Roland Scheidegger Also report if a shader writes the layer semantic --- src/gallium/auxiliary/draw/draw_context.c |2 +- src/gallium/auxiliary/tgsi/tgsi_scan.c|5 + src/gallium/auxiliary/tgsi/tgsi_scan.h|1 + src/gallium/auxiliary/tgsi/tgsi_strings.c |1 + 4 fi

Re: [Mesa-dev] [PATCH] Rename api_validate.[ch] to draw_validate.[ch]

2013-06-05 Thread Brian Paul
On 06/05/2013 03:25 PM, Kenneth Graunke wrote: On 06/05/2013 12:09 PM, Arnas Milasevicius wrote: --- src/mesa/Makefile.sources | 2 +- src/mesa/SConscript | 2 +- src/mesa/main/draw_validate.c | 745 ++ 3 files changed, 747 insertion

[Mesa-dev] [PATCH] clover: Don't segfault when compiling a program with no kernel

2013-06-05 Thread Tom Stellard
From: Tom Stellard --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index 2d115ed..8ec089d 100644 --- a/src/gallium/s

[Mesa-dev] [PATCH] gallium: Document format name conventions

2013-06-05 Thread Adam Jackson
v2: - Fix a channel name thinko (Michel Dänzer) - Elaborate on SCALED versus INT - Add links to DirectX and FOURCC docs Signed-off-by: Adam Jackson --- src/gallium/docs/format.rst | 54 + 1 file changed, 54 insertions(+) create mode 100644 src/gallium

Re: [Mesa-dev] [PATCH] Rename api_validate.[ch] to draw_validate.[ch]

2013-06-05 Thread Kenneth Graunke
On 06/05/2013 12:09 PM, Arnas Milasevicius wrote: --- src/mesa/Makefile.sources | 2 +- src/mesa/SConscript | 2 +- src/mesa/main/draw_validate.c | 745 ++ 3 files changed, 747 insertions(+), 2 deletions(-) create mode 100644 src/me

Re: [Mesa-dev] [PATCH v3] Rename the _mesa_lookup_enum_by_nr() function Renamed function _mesa_lookup_prim_by_nr() to _mesa_prim_string() _mesa_lookup_enum_by_nr() to _mesa_enum_string() _mesa_lookup_

2013-06-05 Thread Kenneth Graunke
On 06/05/2013 03:02 PM, Arnas Milaševičius wrote: And how should I deal with the files, which has all the 3 functions in them? Should I add them in one of the 3 patches or should I add them in all the 3 patches? Each of the three patches should change whatever files are necessary. i.e. search

Re: [Mesa-dev] [PATCH v3] Rename the _mesa_lookup_enum_by_nr() function Renamed function _mesa_lookup_prim_by_nr() to _mesa_prim_string() _mesa_lookup_enum_by_nr() to _mesa_enum_string() _mesa_lookup_

2013-06-05 Thread Kenneth Graunke
This patch is really doing three related, but independent things: 1. Renaming _mesa_lookup_prim_by_nr() to _mesa_prim_string() 2. Renaming _mesa_lookup_enum_by_nr() to _mesa_enum_string() 3. Renaming _mesa_lookup_enum_by_name() to _mesa_enum_value() Generally, a patch should only do one thing at

[Mesa-dev] [PATCH 2/2 v2] intel: Use the CHIPSET macro in the PCI ID tables for the device name.

2013-06-05 Thread Kenneth Graunke
Putting the human readable device names directly in the PCI ID list consolidates things in one place. It also makes it easy to customize the name on a per-PCI ID basis without a huge code explosion. Based on a patch by Kristian Høgsberg. v2: Fix 830M/845G names and #undef CHIPSET (caught by Emit

[Mesa-dev] [PATCH] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-05 Thread Arnas Milasevicius
Because these 2 functions are only used in state_tracker's st_draw_feedback.c file, I moved them there from draw_pt.c and made them static. --- src/gallium/auxiliary/draw/draw_context.h | 10 src/gallium/auxiliary/draw/draw_pt.c | 40 -- src/mesa/state_t

Re: [Mesa-dev] [PATCH 1/2] i965/clip: Add support for gl_ClipVertex

2013-06-05 Thread Paul Berry
On 5 June 2013 13:49, Chris Forbes wrote: > Hi Paul > > You're right, it needs some more comments :) > > Would you be happy with me landing the triangle case first, and then > following up with a fix for lines at some point in the near future? As > is, it fixes some pretty awful misrendering. > >

Re: [Mesa-dev] [PATCH 1/2] i965/clip: Add support for gl_ClipVertex

2013-06-05 Thread Chris Forbes
Hi Paul You're right, it needs some more comments :) Would you be happy with me landing the triangle case first, and then following up with a fix for lines at some point in the near future? As is, it fixes some pretty awful misrendering. -- Chris On Thu, Jun 6, 2013 at 3:29 AM, Paul Berry wrot

[Mesa-dev] Fwd: [PATCH 1/2] i965/clip: Add support for gl_ClipVertex

2013-06-05 Thread Paul Berry
Whops, accidentally sent this reply just to Chris. -- Forwarded message -- From: Paul Berry Date: 5 June 2013 08:29 Subject: Re: [Mesa-dev] [PATCH 1/2] i965/clip: Add support for gl_ClipVertex To: Chris Forbes On 5 June 2013 15:50, Chris Forbes wrote: > When clipping against

[Mesa-dev] [Bug 65420] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65420 --- Comment #4 from Arnas Milaševičius --- Wow, I was so confused that it's not there and only now I realized that I accidently deleted it together with draw_arrays() and draw_arrays_instanced() from that .h file... -- You are receiving this ma

Re: [Mesa-dev] [PATCH] r600g: fix mega_fetch_count

2013-06-05 Thread Tom Stellard
On Tue, Jun 04, 2013 at 12:46:02AM +0200, Grigori Goronzy wrote: > According to ISA docs, the range is 1..64, so effectively > bytes_to_fetch-1. As far as I can tell this patch is correct, though I'm not sure what impact this really has on the shader. Reviewed-by: Tom Stellard > --- > src/gall

Re: [Mesa-dev] [PATCH 1/2] intel: Remove 'misc' parameter from CHIPSET macro in PCI ID tables.

2013-06-05 Thread Eric Anholt
Kenneth Graunke writes: > This has never actually been used for anything. With the fixes by Emil, these patches are: Reviewed-by: Eric Anholt pgpAGzVQmFSZj.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

[Mesa-dev] [Bug 65420] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65420 --- Comment #3 from Brian Paul --- draw_vbo() should not be touched. It's called by a number of gallium drivers. See also src/gallium/auxiliary/draw/draw_context.h:241:void draw_vbo(struct draw_context *draw, ... -- You are receiving this mai

[Mesa-dev] [Bug 65420] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65420 --- Comment #2 from Arnas --- And what should we do with void draw_vbo(struct draw_context *draw, const struct pipe_draw_info *info); function in that file? Because I couldn't find it declared in any *.h file. If we'd move this function to st_dra

Re: [Mesa-dev] [PATCH 2/2] intel: Use the CHIPSET macro in the PCI ID tables for the device name.

2013-06-05 Thread Emil Velikov
On 05/06/13 20:05, Kenneth Graunke wrote: > Putting the human readable device names directly in the PCI ID list > consolidates things in one place. It also makes it easy to customize > the name on a per-PCI ID basis without a huge code explosion. > Based on a patch by Kristian Høgsberg. > Hi Kenn

Re: [Mesa-dev] [PATCH v2] Renamed functions for file enums.c

2013-06-05 Thread Ian Romanick
On 06/05/2013 10:55 AM, Alex Deucher wrote: On Wed, Jun 5, 2013 at 1:50 PM, Arnas Milaševičius wrote: Will it be approved or I need to resend this patch with a better commit massage? Please resend a version 3 with an improved commit message. It's also good to include a small list of changes

Re: [Mesa-dev] [PATCH] mesa: fix OES_EGL_image_external being partially allowed in the core profile

2013-06-05 Thread Chad Versace
On 06/01/2013 06:23 AM, Marek Olšák wrote: --- src/glsl/glcpp/glcpp-parse.y | 14 +++--- src/mesa/drivers/common/meta.c |3 ++- src/mesa/main/ff_fragment_shader.cpp |3 ++- src/mesa/main/teximage.c |2 +- src/mesa/state_tracker/st_exte

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix uniform buffer object counting.

2013-06-05 Thread Ian Romanick
On 05/31/2013 12:37 PM, Eric Anholt wrote: We were counting uniforms located in UBOs against the default uniform block limit, while not doing any counting against the specific combined limit. Note that I couldn't quite find justification for the way I did this, but I think it's the only sensible

Re: [Mesa-dev] [PATCH 1/2] glsl: Make a local variable to avoid restating this array lookup.

2013-06-05 Thread Ian Romanick
With the change suggested by Tapani, Reviewed-by: Ian Romanick On 05/31/2013 12:37 PM, Eric Anholt wrote: --- src/glsl/link_uniforms.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index ad63668..5

[Mesa-dev] [PATCH 3/3] freedreno: gmem bypass

2013-06-05 Thread Rob Clark
From: Rob Clark The GPU (at least a3xx, but I think also a2xx) can render directly to memory, bypassing tiling. Although it can't do this if blend, depth, and a few other features of the pipeline are enabled. This direct memory mode can be faster for some sorts of operations, such as simple bli

[Mesa-dev] [PATCH 0/3] freedreno: adreno a3xx support

2013-06-05 Thread Rob Clark
From: Rob Clark Currently, es2gears, ioquake, xonotic, compiz, gnome-shell, all work. The shader compiler is quite sub-optimal, but despite that most things seem to be ~2-3x faster compared (and at higher resolution) with the a320 on my nexus4 compared to a220 on my HP touchpad. Since the patch

[Mesa-dev] [PATCH] Rename api_validate.[ch] to draw_validate.[ch]

2013-06-05 Thread Arnas Milasevicius
--- src/mesa/Makefile.sources | 2 +- src/mesa/SConscript | 2 +- src/mesa/main/draw_validate.c | 745 ++ 3 files changed, 747 insertions(+), 2 deletions(-) create mode 100644 src/mesa/main/draw_validate.c diff --git a/src/mesa/Makefile.s

Re: [Mesa-dev] [PATCH 2/2] i965: Enable ext_framebuffer_multisample_blit_scaled on intel h/w

2013-06-05 Thread Paul Berry
On 4 June 2013 18:20, Anuj Phogat wrote: > This patch enables ext_framebuffer_multisample_blit_scaled extension > on intel h/w >= gen6. > > Note: Patches for piglit tests to verify this functionality are out > for review on piglit mailing list. Tests pass for all of the scaling > factors from 0.1

[Mesa-dev] [PATCH 1/2] intel: Remove 'misc' parameter from CHIPSET macro in PCI ID tables.

2013-06-05 Thread Kenneth Graunke
This has never actually been used for anything. Cc: Rodrigo Vivi Signed-off-by: Kenneth Graunke --- include/pci_ids/i915_pci_ids.h | 30 +++--- include/pci_ids/i965_pci_ids.h | 186 ++-- include/pci_ids/pci_id_driver_map.h | 4 +- 3 files changed, 11

[Mesa-dev] [PATCH 2/2] intel: Use the CHIPSET macro in the PCI ID tables for the device name.

2013-06-05 Thread Kenneth Graunke
Putting the human readable device names directly in the PCI ID list consolidates things in one place. It also makes it easy to customize the name on a per-PCI ID basis without a huge code explosion. Based on a patch by Kristian Høgsberg. Cc: Rodrigo Vivi Signed-off-by: Kenneth Graunke --- inc

Re: [Mesa-dev] [PATCH 1/2] i965/blorp: Add bilinear filtering of samples for multisample scaled blits

2013-06-05 Thread Paul Berry
On 4 June 2013 18:20, Anuj Phogat wrote: > Current implementation of ext_framebuffer_multisample_blit_scaled in > i965/blorp uses nearest filtering for multisample scaled blits. Using > nearest filtering produces blocky artifacts and negates the benefits > of MSAA. That is the reason why extensio

Re: [Mesa-dev] [PATCH] Renamed functions for file enums.c

2013-06-05 Thread Brian Paul
On Wed, Jun 5, 2013 at 10:13 AM, Eric Anholt wrote: > Brian Paul writes: > > > On 06/05/2013 03:53 AM, Arnas Milasevicius wrote: > >> > >> diff --git a/src/mapi/glapi/gen/gl_enums.py > b/src/mapi/glapi/gen/gl_enums.py > >> index 806d384..ba19196 100644 > >> --- a/src/mapi/glapi/gen/gl_enums.py >

Re: [Mesa-dev] [PATCH v2] Renamed functions for file enums.c

2013-06-05 Thread Alex Deucher
On Wed, Jun 5, 2013 at 1:50 PM, Arnas Milaševičius wrote: > Will it be approved or I need to resend this patch with a better commit > massage? Please resend a version 3 with an improved commit message. It's also good to include a small list of changes between versions if you resend the patch mul

Re: [Mesa-dev] [PATCH 1/2] intel: make intel_flush_front safe to call during initial MakeCurrent

2013-06-05 Thread Chad Versace
On 06/05/2013 10:40 AM, Paul Berry wrote: On 5 June 2013 10:37, Chad Versace wrote: On 05/30/2013 07:44 AM, Paul Berry wrote: The sentence that begins with "In doing so" seems incomplete and I don't understand its intent. Sorry about that. I appear to have experienced some packet loss

Re: [Mesa-dev] [PATCH v2] Renamed functions for file enums.c

2013-06-05 Thread Arnas Milaševičius
Will it be approved or I need to resend this patch with a better commit massage? On Wed, Jun 5, 2013 at 8:47 PM, Arnas Milaševičius wrote: > _mesa_lookup_enum_by_nr() -> _mesa_enum_string() > _mesa_lookup_prim_by_nr() -> _mesa_prim_string() > _mesa_lookup_enum_by_name() -> _mesa_enum_value() >

Re: [Mesa-dev] [PATCH 2/2] i965: Enable ext_framebuffer_multisample_blit_scaled on intel h/w

2013-06-05 Thread Matt Turner
On Tue, Jun 4, 2013 at 6:20 PM, Anuj Phogat wrote: > This patch enables ext_framebuffer_multisample_blit_scaled extension > on intel h/w >= gen6. > > Note: Patches for piglit tests to verify this functionality are out > for review on piglit mailing list. Tests pass for all of the scaling > factors

Re: [Mesa-dev] [PATCH 1/2] intel: make intel_flush_front safe to call during initial MakeCurrent

2013-06-05 Thread Paul Berry
On 5 June 2013 10:37, Chad Versace wrote: > On 05/30/2013 07:44 AM, Paul Berry wrote: > >> The patch that follows will fix a bug that prevents >> intel_flush_front() from being called often enough. In doing so, it >> will create a situation where intel_flush_front() during the initial >> call to

Re: [Mesa-dev] [PATCH 1/2] intel: make intel_flush_front safe to call during initial MakeCurrent

2013-06-05 Thread Chad Versace
On 05/30/2013 07:44 AM, Paul Berry wrote: The patch that follows will fix a bug that prevents intel_flush_front() from being called often enough. In doing so, it will create a situation where intel_flush_front() during the initial call to glXMakeCurrent().In this circumstance, ctx->DrawBuffer ha

Re: [Mesa-dev] [PATCH v2] Renamed functions for file enums.c

2013-06-05 Thread Eric Anholt
Arnas Milasevicius writes: > _mesa_prim_nr changed in: > > src/mesa/main/api_validate.c > src/mesa/main/api_validate.c > src/mesa/main/enums.h > src/mesa/vbo/vbo_exec_draw.c > src/mesa/vbo/vbo_save_api.c > src/mesa/vbo/vbo_save_loopback.c > > _mesa_enum_name changed in: > > src/mesa/main/enums.h

[Mesa-dev] [Bug 65427] Gallium EGL on Wayland blocks in eglInitialize (no display thread bound)

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65427 --- Comment #1 from Jay Cornwall --- Created attachment 80362 --> https://bugs.freedesktop.org/attachment.cgi?id=80362&action=edit Trivial test case for Gallium EGL Wayland backend -- You are receiving this mail because: You are the assignee

[Mesa-dev] [PATCH 7/7] intel: Allow blorp CopyTexSubImage to nonzero destination slices.

2013-06-05 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 12 src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/intel/intel_tex_copy.c | 10 -- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src

[Mesa-dev] [Bug 65427] New: Gallium EGL on Wayland blocks in eglInitialize (no display thread bound)

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65427 Priority: medium Bug ID: 65427 Assignee: mesa-dev@lists.freedesktop.org Summary: Gallium EGL on Wayland blocks in eglInitialize (no display thread bound) Severity: normal

[Mesa-dev] [PATCH 6/7] intel: Allow blit CopyTexSubImage to nonzero destination slices.

2013-06-05 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_tex_copy.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_copy.c b/src/mesa/drivers/dri/intel/intel_tex_copy.c index f9e03fa..9413b14 100644 --- a/src/mesa/drivers/dri/intel/int

[Mesa-dev] [PATCH 5/7] intel: Directly implement blit glBlitFramebuffer instead of awkward reuse.

2013-06-05 Thread Eric Anholt
This gets us support for blitting to attachment types other than textures. --- src/mesa/drivers/dri/intel/intel_fbo.c | 129 +++- src/mesa/drivers/dri/intel/intel_tex.h | 7 -- src/mesa/drivers/dri/intel/intel_tex_copy.c | 2 +- 3 files changed, 69 insertions(

[Mesa-dev] [PATCH 2/7] intel: Move BCS_SWCTRL setup to a helper function.

2013-06-05 Thread Eric Anholt
This will get reused shortly. --- src/mesa/drivers/dri/intel/intel_blit.c | 70 + 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_blit.c b/src/mesa/drivers/dri/intel/intel_blit.c index 1f6ad09..70d6dcc 100644 --- a/s

[Mesa-dev] [PATCH 4/7] intel: Move XRGB->ARGB blit logic into intel_miptree_blit().

2013-06-05 Thread Eric Anholt
Now any caller (such as glCopyPixels()) can benefit from it, and it only changes the correct subset of the destination instead of a whole teximage. --- src/mesa/drivers/dri/intel/intel_blit.c | 114 ++ src/mesa/drivers/dri/intel/intel_blit.h | 2 - src/mesa/dr

[Mesa-dev] [PATCH 3/7] intel: Fix Y tiling support for glCopyTexSubImage's alpha override.

2013-06-05 Thread Eric Anholt
Apparently we don't have any piglit tests for this, because it would have assertion failed in a debug build, or just rendered wrong in a non-debug build if the destination wasn't covering whole tiles. --- src/mesa/drivers/dri/intel/intel_blit.c | 12 +--- 1 file changed, 9 insertions(+), 3

[Mesa-dev] [PATCH 1/7] mesa: Hide weirdness of 1D_ARRAY textures from Driver.CopyTexSubImage().

2013-06-05 Thread Eric Anholt
Intel had brokenness here, and I'd like to continue moving Mesa toward hiding 1D_ARRAY's ridiculousness inside of the core, like we did with MapTextureImage. Fixes copyteximage 1D_ARRAY on intel. There's still an impedance mismatch in meta when falling back to read and texsubimage, since texsubim

Re: [Mesa-dev] [PATCH] Renamed functions for file enums.c

2013-06-05 Thread Eric Anholt
Brian Paul writes: > On 06/05/2013 03:53 AM, Arnas Milasevicius wrote: >> >> diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py >> index 806d384..ba19196 100644 >> --- a/src/mapi/glapi/gen/gl_enums.py >> +++ b/src/mapi/glapi/gen/gl_enums.py >> @@ -91,7 +91,7 @@ static in

Re: [Mesa-dev] EGL_BAD_CONTEXT error when creating shared context

2013-06-05 Thread Chad Versace
On 05/29/2013 07:17 AM, Brian Paul wrote: On 05/29/2013 12:56 AM, Divick Kishore wrote: Hi Brian, thanks for your reply. On Tue, May 28, 2013 at 9:33 PM, Brian Paul wrote: I took at look at eglCreateContext(). It's basically: EGLContext eglCreateContext(EGLDisplay dpy, EGLConfi

[Mesa-dev] [PATCH] r600g/sb: improve math optimizations v2

2013-06-05 Thread Vadim Girlin
This patch adds support for some math optimizations that are generally considered unsafe, that's why they are currently disabled for compute shaders. GL requirements are less strict, so they are enabled for for GL shaders by default. In case of any issues with applications that rely on higher prec

[Mesa-dev] [Bug 64959] Cannot build against EGL without X11

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64959 Chad Versace changed: What|Removed |Added CC||chad.vers...@linux.intel.co

[Mesa-dev] [Bug 65422] Rename api_validate.[ch] to draw_validate.[ch]

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65422 --- Comment #1 from Arnas --- I'll take this task. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freed

[Mesa-dev] [Bug 65421] Rename draw_vs_varient.c file

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65421 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 65421] Rename draw_vs_varient.c file

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65421 --- Comment #1 from Arnas --- In the git repo it's already draw_vs_variant.c -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesk

[Mesa-dev] [Bug 65425] New: Fine grained --enable-debug configure options

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65425 Priority: low Bug ID: 65425 Assignee: mesa-dev@lists.freedesktop.org Summary: Fine grained --enable-debug configure options Severity: trivial Classification: Unclassified OS:

[Mesa-dev] [Bug 65420] Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65420 --- Comment #1 from Arnas --- I'll take this task. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freed

Re: [Mesa-dev] [PATCH 0/2] Fix gl_ClipVertex support on pre-Gen6 i965

2013-06-05 Thread Paul Berry
On 5 June 2013 15:50, Chris Forbes wrote: > Adds proper support for gl_ClipVertex when clipping against user > clip planes. > > Fixes broken rendering in Source games on at least ILK [Water in > CS:S video stress test is an easy example]. > > Also all clip-vertex piglits pass now. > > This is a b

Re: [Mesa-dev] [PATCH 2/2] i965/vs: add support for emitting gl_ClipVertex

2013-06-05 Thread Paul Berry
On 5 June 2013 15:50, Chris Forbes wrote: > Removes the special-case suppression of gl_ClipVertex in the VUE map. > > Also calculate vertex outcodes for user clip planes based on > gl_ClipVertex if written; otherwise gl_Position. > > Signed-off-by: Chris Forbes > Reviewed-by: Paul Berry > --

[Mesa-dev] [Bug 65422] New: Rename api_validate.[ch] to draw_validate.[ch]

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65422 Priority: medium Bug ID: 65422 Assignee: mesa-dev@lists.freedesktop.org Summary: Rename api_validate.[ch] to draw_validate.[ch] Severity: trivial Classification: Unclassified

[Mesa-dev] [Bug 65423] New: Remove gl_config::haveDepthBuffer, haveAccumBuffer, haveStencilBuffer fields

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65423 Priority: medium Bug ID: 65423 Assignee: mesa-dev@lists.freedesktop.org Summary: Remove gl_config::haveDepthBuffer, haveAccumBuffer, haveStencilBuffer fields Severity: trivia

[Mesa-dev] [Bug 65421] New: Rename draw_vs_varient.c file

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65421 Priority: medium Bug ID: 65421 Assignee: mesa-dev@lists.freedesktop.org Summary: Rename draw_vs_varient.c file Severity: trivial Classification: Unclassified OS: All

[Mesa-dev] [Bug 65420] New: Remove gallium draw_arrays() and draw_arrays_instanced() functions

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65420 Priority: medium Bug ID: 65420 Assignee: mesa-dev@lists.freedesktop.org Summary: Remove gallium draw_arrays() and draw_arrays_instanced() functions Severity: minor Classi

Re: [Mesa-dev] How do I start contributing to Mesa?

2013-06-05 Thread Brian Paul
On 06/05/2013 04:09 AM, Arnas Milaševičius wrote: On Wed, Jun 5, 2013 at 12:44 AM, Arnas Milaševičius mailto:giant...@gmail.com>> wrote: I've fixed the first "bug" but I wonder what would be the right way to submit this patch, because I needed to change like 100 or more files? On T

[Mesa-dev] [Bug 65374] Remove outdated version comments throughout Mesa

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65374 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] Renamed functions for file enums.c

2013-06-05 Thread Brian Paul
On 06/05/2013 03:53 AM, Arnas Milasevicius wrote: --- src/mapi/glapi/gen/gl_enums.py | 6 +- src/mesa/drivers/common/meta.c | 2 +- src/mesa/drivers/dri/i915/i830_state.c | 20 +++ src/mesa/drivers/dri/i915/intel_render.c | 2 +-

[Mesa-dev] [PATCH] Use sizeof(void *) rather than 0 as the fallback cache line size.

2013-06-05 Thread Richard Sandiford
Without this, llvmpipe ends up giving a zero size to all uncompressed textures on non-x86 systems, since align() cannot handle a 0 alignment. Signed-off-by: Richard Sandiford --- src/gallium/auxiliary/util/u_cpu_detect.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/auxili

Re: [Mesa-dev] [PATCH] Port gallium to System z

2013-06-05 Thread Brian Paul
On Wed, Jun 5, 2013 at 2:26 AM, Richard Sandiford < rsand...@linux.vnet.ibm.com> wrote: > The main change is to use MCJIT rather than the old JIT, which will never > be supported for System z. The endianness part is by example since the > patch was tested on a glibc system. > > Signed-off-by: Ric

Re: [Mesa-dev] [PATCH] Use 1 rather than 0 as the fallback cache line size.

2013-06-05 Thread Richard Sandiford
Jose Fonseca writes: > - Original Message - >> Without this, llvmpipe ends up giving a zero size to all uncompressed >> textures >> on non-x86 systems, since align() cannot handle a 0 alignment. Making the >> default 1 seemed preferable to adding checks for 0. >> >> Signed-off-by: Richar

Re: [Mesa-dev] [PATCH] r600g/sb: improve math optimizations

2013-06-05 Thread Vadim Girlin
On 06/05/2013 12:01 AM, Grigori Goronzy wrote: On 31.05.2013 14:37, Vadim Girlin wrote: There are no regressions on evergreen with piglit tests or any other apps that I tested, with and without llvm backend. (Issue with Unigine Heaven that I mentioned on #dri-devel yesterday was in fact caused b

Re: [Mesa-dev] [PATCH] Use 1 rather than 0 as the fallback cache line size.

2013-06-05 Thread Jose Fonseca
- Original Message - > Without this, llvmpipe ends up giving a zero size to all uncompressed > textures > on non-x86 systems, since align() cannot handle a 0 alignment. Making the > default 1 seemed preferable to adding checks for 0. > > Signed-off-by: Richard Sandiford > --- > src/ga

Re: [Mesa-dev] How do I start contributing to Mesa?

2013-06-05 Thread Arnas Milaševičius
Okay, I've sent the patch to the mailing list, I hope it will be accepted. By the way, could someone add some a little bit harder bugs or something to bugzilla for beginners? Not just renaming functions. On Wed, Jun 5, 2013 at 12:44 AM, Arnas Milaševičius wrote: > I've fixed the first "bug" but

[Mesa-dev] [PATCH 1/2] i965/clip: Add support for gl_ClipVertex

2013-06-05 Thread Chris Forbes
When clipping against a user clip plane, and gl_ClipVertex is provided in the vertex, use it instead of hpos. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip.h | 1 + src/mesa/drivers/dri/i965/brw_clip_tri.c | 44 +--- 2 files changed, 41 inser

[Mesa-dev] [PATCH 2/2] i965/vs: add support for emitting gl_ClipVertex

2013-06-05 Thread Chris Forbes
Removes the special-case suppression of gl_ClipVertex in the VUE map. Also calculate vertex outcodes for user clip planes based on gl_ClipVertex if written; otherwise gl_Position. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 +++- src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 0/2] Fix gl_ClipVertex support on pre-Gen6 i965

2013-06-05 Thread Chris Forbes
Adds proper support for gl_ClipVertex when clipping against user clip planes. Fixes broken rendering in Source games on at least ILK [Water in CS:S video stress test is an easy example]. Also all clip-vertex piglits pass now. This is a bit of a stopgap thing since I really want to add GLSL-1.30

[Mesa-dev] [Bug 65374] Remove outdated version comments throughout Mesa

2013-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65374 --- Comment #1 from gurket...@googlemail.com --- Created attachment 80337 --> https://bugs.freedesktop.org/attachment.cgi?id=80337&action=edit remove "Version:" comment Attached is a patch, which removes the "Version:" comment in .c, .S, .h, .p

[Mesa-dev] [PATCH] Use 1 rather than 0 as the fallback cache line size.

2013-06-05 Thread Richard Sandiford
Without this, llvmpipe ends up giving a zero size to all uncompressed textures on non-x86 systems, since align() cannot handle a 0 alignment. Making the default 1 seemed preferable to adding checks for 0. Signed-off-by: Richard Sandiford --- src/gallium/auxiliary/util/u_cpu_detect.c | 5 +

Re: [Mesa-dev] [PATCH] build: Unify PACKAGE_VERSION on autotools, scons and Android

2013-06-05 Thread Andreas Boll
2013/6/4 Emil Velikov > On 04/06/13 21:42, Andreas Boll wrote: > > 2013/6/4 Brian Paul > > > >> On 06/04/2013 11:40 AM, Andreas Boll wrote: > >> > >>> This patch unifies mesa's PACKAGE_VERSION on autotools, scons and > >>> Android build systems. > >>> > >>> Current behaviour is: > >>> - Autoto

  1   2   >