Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

On Sat, Jun 22, 2013 at 12:22 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > BTW, SMX is a write cache, to maybe it shouldn't be part of this patch. I made a little experiment where i ran "ext_framebuffer_multisample-unaligned-blit 4 color downsample -auto" 1 times and found that with

Re: [Mesa-dev] Build warnings cleanup

On 22/06/13 16:43, Emil Velikov wrote: > Cleanup series addressing a few warnings spotted by gcc > > Note: the first patch is a recent from previously, which despite s/recent/resend English is hard :) Emil > it's evasive looks is quite trivial > > Feel free to commit, as I do not h

[Mesa-dev] [PATCH 4/4] glsl opt_flip_matrices: Silence unused variable warning in the release build

Resolves the following gcc warning opt_flip_matrices.cpp:84:32: warning: unused variable 'deref' Signed-off-by: Emil Velikov --- src/glsl/opt_flip_matrices.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/opt_flip_matrices.cpp b/src/glsl/opt_flip_matrices.cp

[Mesa-dev] [PATCH 3/4] glsl ast_to_hir: Silence uninitialized variable warnings in the release build

Resolves the following gcc warnings warning: 'iface_type_name' may be used uninitialized in this function warning: 'var_mode' may be used uninitialized in this function Note: The variables are initialised to UNKNOWN and ir_var_auto Signed-off-by: Emil Velikov --- src/glsl/ast_to_hir.cpp | 2

[Mesa-dev] [PATCH 2/4] nvc0: Silence uninitialized variable warning in the release build

Resolves the following gcc warning warning: 'ptr' may be used uninitialized in this function xy[0] = ptr[sample_index][0] * 0.0625f; ^ Signed-off-by: Emil Velikov --- src/gallium/drivers/nvc0/nvc0_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/driv

[Mesa-dev] [PATCH 1/4] gallium-egl: Use native types rather than EGL ones

Change egl_g3d_wl_drm_common_query_buffer() to use boolean/int rather than EGLBoolean/EGLint, based on the interface in native_wayland_bufmgr.h, Resolves type conversion warnings spotted by gcc x11/native_dri2.c:892:1: warning: initialization from incompatible pointer type[enabled by default] };

[Mesa-dev] Build warnings cleanup

Cleanup series addressing a few warnings spotted by gcc Note: the first patch is a recent from previously, which despite it's evasive looks is quite trivial Feel free to commit, as I do not have access [PATCH 1/4] gallium-egl: Use native types rather than EGL ones [PATCH 2/4] nvc0:

Re: [Mesa-dev] RFC: more changes to render_condition

On 22.06.2013 16:36, Roland Scheidegger wrote: > We decided to drop predicated transfers already. State tracker can > emulate this by using another resource and doing a (predicated) > resource_copy_region, might be slightly suboptimal but predicated > transfers really sound strange. > As for resour

Re: [Mesa-dev] RFC: more changes to render_condition

We decided to drop predicated transfers already. State tracker can emulate this by using another resource and doing a (predicated) resource_copy_region, might be slightly suboptimal but predicated transfers really sound strange. As for resource_copy_region, I'm fine with a flag indicating if it hon

Re: [Mesa-dev] RFC: more changes to render_condition

I have mixed feelings about this. Some transfers are implemented with pipe_context::blit instead of resource_copy_region, because MSAA resources should be downsampled in transfer_map and upsampled in transfer_unmap, so that ReadPixels and various fallbacks (CopyPixels, CopyTexSubImage, ...) work.

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

Reviewed-by: Marek Olšák BTW, SMX is a write cache, to maybe it shouldn't be part of this patch. Marek On Sun, Jun 16, 2013 at 1:27 PM, Martin Andersson wrote: > Not including the SH and SMX caches when invalidating read caches causes > random failures on some piglit tests when VA is enabled.