https://bugs.freedesktop.org/show_bug.cgi?id=67811
Priority: medium
Bug ID: 67811
Keywords: regression
CC: za...@vmware.com
Assignee: mesa-dev@lists.freedesktop.org
Summary: [softpipe] piglit gl-1.0-edgeflag regression
Looks good to me. A small comment above the disabled version noting that it's
disabled because it's a bit slower might be useful for the next person who
reads the code.
Reviewed-by: Zack Rusin
- Original Message -
> From: Roland Scheidegger
>
> Should be much faster, seems to work in
On Mon, Aug 05, 2013 at 09:46:58AM -0700, Chad Versace wrote:
> On 08/01/2013 03:52 PM, Jonathan Gray wrote:
> >On Thu, Aug 01, 2013 at 11:21:57AM -0700, Ian Romanick wrote:
> >>On 08/01/2013 09:54 AM, Chad Versace wrote:
> >>>On 08/01/2013 09:48 AM, Chad Versace wrote:
> On 08/01/2013 12:27 AM
From: Roland Scheidegger
Should be much faster, seems to work in softpipe.
While here (also it's now disabled) fix up the pow factor - the former value
is what is in GL core it is however not actually accurate to fp32 standard
(as it is 1.0/2.4), and if someone would do all the accurate math ther
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #13 from Roland Scheidegger ---
(In reply to comment #12)
> Oh. I had assumed -g was a debug build.
Some debug features depend on explicitly defined DEBUG var.
>
> Fails to build:
> Run 'make' to build Mesa
> GEN ../.
CMP instructions use BRW_ARF_NULL as a destination. Prior to this
patch, dump_instruction() decoded the destination as "???".
Now it decodes BRW_ARF_NULL as "(null)" and other ARFs numerically.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++
1 file changed,
This resulted in printouts like:
246: cmp.cmod.f0.0
???, vgrf152, 0.00f, (null),
With this patch, CMP is properly printed on one line.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa
Many GLSL shaders contain code of the form:
x = condition ? foo : bar
The compiler emits an ir_if tree for this, since each subexpression
might be a complex tree that could have side-effects and short-circuit
logic operations.
However, the common case is to simply pick one of two constants or
The instruction
(+f0.0) SEL dst, src0, src1
will write either src0 or src1 to dst, depending on the predicate.
Unlike most predicated instructions, it always writes to dst.
fs_inst::is_partial_write() is supposed to return true if the whole
register is guaranteed to be written. The !inst->pr
The existing inst->is_partial_write() already disallows predicated
instructions, so this has no functional change. However, it's worth
doing explicitly since the CSE pass does not consider the flag register.
This means it could blindly factor out operations that use the same
sources, but which hav
Usually, the driver creates both 8-wide and 16-wide variants of every
fragment shader. When 16-wide compilation fails, it logs a performance
warning explaining why only an 8-wide program exists.
However, when there are pull parameters, the driver won't even bother
trying the 16-wide compile (sinc
Le lundi 5 août 2013 14:58:44 Tom Stellard a écrit :
> From: Tom Stellard
>
> The TGSI->LLVM pass for radeonsi preloads constants and relies on LLVM's
> sinking pass to reduce SGPR usage by lowering constant reads to an
> optimal place in the code. However, LLVM's machine sink pass will not
> lo
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #12 from ken moffat ---
(In reply to comment #11)
> (In reply to comment #10)
> > sorry, nothing. Maybe something in the way I configured it ?
>
> Yes as said this will only work with a debug build. --enable-debug should do
> it (th
Currently single sample scaled blits with GL_LINEAR filter falls
back to meta path. Patch removes this limitation in BLORP engine
and implements single sample scaled blit with bilinear filter.
No piglit, gles3 regressions are obeserved with this patch. Piglit
test case patches to verify this implem
New function clamp_tex_coords() clamps the texture coordinates
to texture boundaries. This function will also be utilized later
for the BLORP implementation of single-sample scaled blit with
bilinear filter.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 63 ++
When we talk about both multi-sample and single-sample scaled blits,
rect_grid_{x1, y1} are more appropriate variable names as compared
to sample_grid_{x1, y1}. There are no functional changes in this patch.
It just prepares for the BLORP implementation of single-sample scaled
blit with bilinear fi
Anuj Phogat (3):
i965/blorp: Use more appropriate variable names
i965/blorp: Define a function to clamp texture coordinates
i965/blorp: Add support for single sample scaled blit with bilinear
filter
src/mesa/drivers/dri/i965/brw_blorp.h | 15 +-
src/mesa/drivers/dri/i965/brw_b
In my current code most of this has gone away -- I just force
VARYING_SLOT_CLIP_DIST* to be valid if we're doing user clipping, and
they fall wherever they naturally would in the VUE map.
On Tue, Aug 6, 2013 at 9:19 AM, Paul Berry wrote:
> On 3 August 2013 19:59, Chris Forbes wrote:
>>
>> Also a
This patch fixes a case of framebuffer blitting with renderbuffer
as color attachment and GL_LINEAR filter. Meta implementation of
glBlitFrambuffer() converts source color buffer to a texture and
uses it to do the scaled blitting in to destination buffer. Using
the exact source rectangle to create
Actually, that justification sounds like nonsense after thinking about
it a bit more -- we're in SPF mode.
On Tue, Aug 6, 2013 at 9:47 AM, Chris Forbes wrote:
> This is what I started with, but brw_ENDIF destroys the flags.
>
> On Tue, Aug 6, 2013 at 9:40 AM, Paul Berry wrote:
>> On 3 August 201
This is what I started with, but brw_ENDIF destroys the flags.
On Tue, Aug 6, 2013 at 9:40 AM, Paul Berry wrote:
> On 3 August 2013 19:59, Chris Forbes wrote:
>>
>> Signed-off-by: Chris Forbes
>> ---
>> src/mesa/drivers/dri/i965/brw_clip_tri.c | 7 +--
>> 1 file changed, 5 insertions(+), 2
On 3 August 2013 19:59, Chris Forbes wrote:
> This series adds support for GLSL-1.30-style clipping using
> gl_ClipDistance on Gen4/5.
> All of the interpolation piglits now pass, but there are still a couple of
> things I need to do:
>
> * Get rid of clip plane compaction
> * Add similar support
On 3 August 2013 19:59, Chris Forbes wrote:
> Signed-off-by: Chris Forbes
> ---
> src/mesa/drivers/dri/i965/brw_clip_tri.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c
> b/src/mesa/drivers/dri/i965/brw_clip_tri.c
> inde
On 3 August 2013 19:59, Chris Forbes wrote:
> Soon the dp4 is only going to be used for fixed clip planes.
>
> Signed-off-by: Chris Forbes
> ---
> src/mesa/drivers/dri/i965/brw_clip_tri.c | 26 ++
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/src/m
On 3 August 2013 19:59, Chris Forbes wrote:
> Also adjust the SF URB read offset to account for there being two
> additional slots of stuff it doesn't care about.
>
> Signed-off-by: Chris Forbes
> ---
> src/mesa/drivers/dri/i965/brw_sf.h | 2 +-
> src/mesa/drivers/dri/i965/brw_vs.c | 2 ++
> 2
You're right, that's completely bogus, and I meant to read the flags instead.
Thanks :)
On Tue, Aug 6, 2013 at 9:09 AM, Paul Berry wrote:
> On 3 August 2013 19:59, Chris Forbes wrote:
>>
>> Signed-off-by: Chris Forbes
>> ---
>> src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 25
>> ++
On 3 August 2013 19:59, Chris Forbes wrote:
> Signed-off-by: Chris Forbes
> ---
> src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 25
> ++---
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> b/src/mesa/dri
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #11 from Roland Scheidegger ---
(In reply to comment #10)
> sorry, nothing. Maybe something in the way I configured it ?
Yes as said this will only work with a debug build. --enable-debug should do it
(though I only tried with scons
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #10 from ken moffat ---
sorry, nothing. Maybe something in the way I configured it ?
PATH=$PATH:/opt/llvm-33/bin/ ./configure --prefix=/usr --sysconfdir=/etc
--enable-texture-float --enable-gles1 --enable-gles2 --enable-openvg
--ena
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #9 from Roland Scheidegger ---
(In reply to comment #8)
> (In reply to comment #7)
>
> > What does it print out if you set GALLIUM_DUMP_CPU=1 env var (with a debug
> > build)?
>
> How do I get output ?
Just place it in the environm
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #8 from ken moffat ---
(In reply to comment #7)
> What does it print out if you set GALLIUM_DUMP_CPU=1 env var (with a debug
> build)?
How do I get output ? I've got the following in .xinitrc:
export GALLIUM_LOG_FILE=/home/ken/galli
From: Tom Stellard
---
src/gallium/drivers/radeonsi/radeonsi_shader.c | 29 ++
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c
b/src/gallium/drivers/radeonsi/radeonsi_shader.c
index fee6262..4d8a479 100644
---
From: Tom Stellard
The TGSI->LLVM pass for radeonsi preloads constants and relies on LLVM's
sinking pass to reduce SGPR usage by lowering constant reads to an
optimal place in the code. However, LLVM's machine sink pass will not
lower instructions that have been selected from llvm.SI.load.const
https://bugs.freedesktop.org/show_bug.cgi?id=67676
Chad Versace changed:
What|Removed |Added
CC||chad.vers...@linux.intel.co
On 08/01/2013 03:52 PM, Jonathan Gray wrote:
On Thu, Aug 01, 2013 at 11:21:57AM -0700, Ian Romanick wrote:
On 08/01/2013 09:54 AM, Chad Versace wrote:
On 08/01/2013 09:48 AM, Chad Versace wrote:
On 08/01/2013 12:27 AM, Jonathan Gray wrote:
Signed-off-by: Jonathan Gray
---
src/mesa/main/imp
Replace "fulldecl->Semantic.Name/Index" with semName/semIndex.
Simplify if/else logic for TGSI_FILE_OUTPUT code.
Remove old comment.
Fix indentation.
---
src/gallium/auxiliary/tgsi/tgsi_scan.c | 83
1 file changed, 42 insertions(+), 41 deletions(-)
diff --git a/
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #7 from Roland Scheidegger ---
(In reply to comment #6)
> (In reply to comment #5)
> > FWIW I've sent out a patch which should address this
> > http://lists.freedesktop.org/archives/mesa-dev/2013-August/042729.html) but
> > honestly I
On 08/04/2013 02:25 AM, Vinson Lee wrote:
If gs is null, then freeing state->shader.tokens would result in a null
dereference.
Fixes "Dereference after null check" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/gallium/drivers/llvmpipe/lp_state_gs.c | 7 +--
1 file chang
On 08/04/2013 01:51 AM, Vinson Lee wrote:
Fixes "Uninitialized pointer read" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/gallium/drivers/nvc0/nvc0_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/nvc0/nvc0_context.c
b/src/gallium/drivers/n
On 08/04/2013 12:49 AM, Vinson Lee wrote:
unfilled_stage::face_slot is of type int.
Fixes "Unsigned compared against 0" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/gallium/auxiliary/draw/draw_pipe_unfilled.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
On 08/03/2013 12:45 AM, Vinson Lee wrote:
pp_free_bos dereferences ppq without a null check.
Fixes "Dereference before null check" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/gallium/auxiliary/postprocess/pp_init.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
https://bugs.freedesktop.org/show_bug.cgi?id=67672
--- Comment #6 from ken moffat ---
(In reply to comment #5)
> FWIW I've sent out a patch which should address this
> http://lists.freedesktop.org/archives/mesa-dev/2013-August/042729.html) but
> honestly I don't think it's 9.2 worthy.
Didn't see
42 matches
Mail list logo
