Re: [Mesa-dev] [PATCH 1/2] R600/SI: Add FMA pattern

2013-08-09 Thread Tom Stellard
On Fri, Aug 09, 2013 at 02:59:07PM +0200, Niels Ole Salscheider wrote: > --- This series is: Reviewed-by: Tom Stellard Your implementation of SITargetLowering::isFMAFasterThanFMulAndFAdd() is correct for SI, not sure about Sea Islands, but we can always fix it later. Feel free to commit these

[Mesa-dev] [Bug 67969] New: [softpipe] piglit gl-1.0-edgeflag-quads regression

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67969 Priority: medium Bug ID: 67969 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit gl-1.0-edgeflag-quads regression

[Mesa-dev] [Bug 67968] New: [softpipe] piglit polygon-mode regression

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67968 Priority: medium Bug ID: 67968 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit polygon-mode regression Sev

[Mesa-dev] [Bug 67967] New: [softpipe] piglit clipflat regression

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67967 Priority: medium Bug ID: 67967 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit clipflat regression Severit

[Mesa-dev] [PATCH V2 3/3] i965/blorp: Add support for single sample scaled blit with bilinear filter

2013-08-09 Thread Anuj Phogat
Currently single sample scaled blits with GL_LINEAR filter falls back to meta path. Patch removes this limitation in BLORP engine and implements single sample scaled blit with bilinear filter. No piglit, gles3 regressions are obeserved with this patch. Piglit test case patches to verify this implem

[Mesa-dev] [Bug 67966] New: [softpipe] piglit glean pointSprite regression

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67966 Priority: medium Bug ID: 67966 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit glean pointSprite regression

[Mesa-dev] [Bug 67965] New: [llvmpipe] piglit point-line-no-cull regression

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67965 Priority: medium Bug ID: 67965 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit point-line-no-cull regression

[Mesa-dev] [Bug 67963] New: [llvmpipe] piglit glean pointAtten regression

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67963 Priority: medium Bug ID: 67963 Keywords: regression CC: za...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit glean pointAtten regression

Re: [Mesa-dev] Direct3D 9 state tracker

2013-08-09 Thread Mike Lothian
Hi Chris Just a quick note for any Gentoo users - I've added these alternative sources into the FireBurn overlay You just need to set the nine use flag and you'll get Chris's versions Cheers Mike On 16 July 2013 19:43, Christoph Bumiller wrote: > So, about two months ago I had the insane ide

[Mesa-dev] [PATCH V2 12/12] i965: allow 8 user clip planes on CTG+

2013-08-09 Thread Chris Forbes
There's no need to use a clip flag for NEGW on these gens, so no reason we can't just enable 8 planes. V2: - Bump (and document!) MAX_VERTS in the clip code. - Fix clip flag masks in the clip unit state and in the shader prolog - Move this to the end of the series for less breakage.

[Mesa-dev] [PATCH V2 11/12] i965: get rid of clip plane compaction

2013-08-09 Thread Chris Forbes
--- src/mesa/drivers/dri/i965/brw_clip.c | 3 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 40 +- src/mesa/drivers/dri/i965/brw_vs.c | 14 ++--- src/mesa/drivers/dri/i965/brw_vs.h | 9 -- 4 files changed, 11 insertions(+),

[Mesa-dev] [PATCH V2 10/12] i965/clip: Support clip distances for line clipping

2013-08-09 Thread Chris Forbes
This does the same thing as we do for triangle clipping -- select the appropriate source (either dot(hpos,fixed plane) or a clipdistance slot). Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_clip_line.c | 66 ++- 1 file changed, 47 insertions(+), 19 del

[Mesa-dev] [PATCH V2 09/12] i965/clip: remove spurious clipvertex param

2013-08-09 Thread Chris Forbes
Nothing in the clipper uses gl_ClipVertex any more, so we don't care where it is. V2: Don't bother fishing out the clipvertex offset either. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 15 --- 1 file changed, 4 insertions(+), 1

[Mesa-dev] [PATCH V2 08/12] i965/clip: Use clip distances for all user clipping

2013-08-09 Thread Chris Forbes
V2: Adjust explanation of load_clip_distance() Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c b/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH V2 07/12] i956/clip: push dp4 into load_clip_distance

2013-08-09 Thread Chris Forbes
Soon the dp4 is only going to be used for fixed clip planes. V2: Remove old inaccurate comment about the behavior of this function; add a better explanation above. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 39 ++--

[Mesa-dev] [PATCH V2 06/12] i965/clip: Track offset into the vertex for clipdistance

2013-08-09 Thread Chris Forbes
Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_clip.h | 3 +++ src/mesa/drivers/dri/i965/brw_clip_tri.c | 9 + 2 files changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_clip.h b/src/mesa/drivers/dri/i965/brw_clip.h index 2b0

[Mesa-dev] [PATCH V2 05/12] i965/Gen4-5: Set clip flags from clip distances

2013-08-09 Thread Chris Forbes
V2: - Use the new VS_OPCODE_UNPACK_FLAGS_SIMD4X2 to correctly split the flags for the two vertices being processed together. - Don't apply bogus masking of clip flags. The set of plane enables aren't included in the shader key, and we wouldn't want the recompiles anyway. Sign

[Mesa-dev] [PATCH V2 04/12] i965: add new VS_OPCODE_UNPACK_FLAGS_SIMD4X2

2013-08-09 Thread Chris Forbes
Splits the bottom 8 bits of f0.0 for further wrangling in a SIMD4x2 program. The 4 bits corresponding to the channels in each program flow are copied to the LSBs of dst.x visible to each flow. This is useful for working with clipping flags in the VS. Signed-off-by: Chris Forbes --- src/mesa/dri

[Mesa-dev] [PATCH V2 03/12] i965/clip: Enable interpolation of clip distances

2013-08-09 Thread Chris Forbes
Previously we had disabled interpolation of the clip distances as a special case, since they were unused. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_clip_util.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/dri

[Mesa-dev] [PATCH V2 02/12] i965/vs: Do legacy clip lowering earlier

2013-08-09 Thread Chris Forbes
We need to produce clip flags for the vertex header on Gen4/5, so clip plane lowering has to be done before we try to emit the flags/psiz attribute. Signed-off-by: Chris Forbes Reviewed-by: Paul Berry --- src/mesa/drivers/dri/i965/brw_vec4.h | 2 +- src/mesa/drivers/dri/i965/brw_vec4

[Mesa-dev] [PATCH V2 01/12] i965/Gen4-5: ensure VUE slots for clipdistance are valid if user clipping is enabled.

2013-08-09 Thread Chris Forbes
V2: We don't particularly care where they fall in the VUE map, as long as they are allocated somewhere, and occupy two contiguous slots. Don't fiddle with the SF layout at all -- there's no need. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vs.c | 5 + 1 file changed, 5 inse

[Mesa-dev] [PATCH V2 00/12] i965: gl_ClipDistance support for Gen4/5.

2013-08-09 Thread Chris Forbes
This series adds support for GLSL-1.30 clip distances on Gen4/5, and extends max clip planes to match the 1.30 requirement on Cantiga and later. Passes 2000/2004 glsl-1.30 piglits on Ironlake. The missing 4 tests here are bugs in handling unusual `switch` control flow, and affect all gens. Passes

[Mesa-dev] [PATCH 9/9] glsl: Track existence of default float precision in GLSL ES fragment shaders

2013-08-09 Thread Ian Romanick
From: Ian Romanick This is required by the spec, and it's a bit tricky because the default precision is scoped. As a result, I'm slightly abusing the symbol table. Fixes piglit no-default-float-precision.frag tests and the piglit default-precision-nested-scope-0[1234].frag tests that are curren

[Mesa-dev] [PATCH 8/9] glsl: Merge precision qualifiers too

2013-08-09 Thread Ian Romanick
From: Ian Romanick We never noticed this before because we previously didn't enfoce GLSL ES fragement shader requirements that precision be defined. There may also have been some interaction here with the addition of GL_ARB_shading_language_420pack, but it doesn't appear to me that it added any

[Mesa-dev] [PATCH 7/9] glsl: Pass type to is_valid_default_precision_type instead of name

2013-08-09 Thread Ian Romanick
From: Ian Romanick This is used by the next patch. Signed-off-by: Ian Romanick Cc: "9.2" --- src/glsl/ast_to_hir.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 9d69e49..091e0e6 100644 --- a/src/glsl/ast_

[Mesa-dev] [PATCH 5/9] glsl: Add default precision qualifiers for ES builtins

2013-08-09 Thread Ian Romanick
From: Ian Romanick Once the compiler proplerly checks for default precision qualifiers, these shaders will cease to compile. Signed-off-by: Ian Romanick Cc: "9.2" --- src/glsl/builtins/profiles/100es.frag| 2 ++ src/glsl/builtins/profiles/300es.frag| 1

[Mesa-dev] [PATCH 6/9] meta: Add default precision qualifier to all fragement shaders

2013-08-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: "9.2" --- src/mesa/drivers/common/meta.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 69b06ed..609ef80 100644 --- a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 3/9] glsl: Emit errors for things that look like default precision statements

2013-08-09 Thread Ian Romanick
From: Ian Romanick Previously we would emit a warning for empty declarations like float; We would also emit the same warning for things like highp float; However, this second case is most likely the application trying to set the default precision. We should instead generate an error. Fixes

[Mesa-dev] [PATCH 4/9] glsl: Remove extra "types" from error message

2013-08-09 Thread Ian Romanick
From: Ian Romanick Send it straight to the Department of Redundancy Department. Signed-off-by: Ian Romanick --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 9d2..9d69e49 100644 --- a/src/

[Mesa-dev] [PATCH 1/9] glsl: Move and refine test for unsized arrays in GLSL ES

2013-08-09 Thread Ian Romanick
From: Ian Romanick GLSL ES does not allow unsized arrays, and GLSL ES 1.00 does not allow array initializers. However, GLSL ES 3.00 allows array initializers, and the initializer can explicitly size the array. The specification even includes some examples of this: float x[] = float[2] (1.0

[Mesa-dev] [PATCH 2/9] glsl: Require function return type arrays be explicitly sized

2013-08-09 Thread Ian Romanick
From: Ian Romanick Fixes piglit array-function-return-unsized.vert. Signed-off-by: Ian Romanick Cc: "9.2" --- src/glsl/ast_to_hir.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 325cb06..49804b7 100644 --- a/src/gls

[Mesa-dev] [PATCH 0/9] Fix a bunch of little GLSL compiler problems

2013-08-09 Thread Ian Romanick
This series fixes a bunch of little things that we were doing incorrectly in the compiler front end. These were mostly related to the handling of unsized arrays and precision qualifiers. With these changes, all of the tests in the piglit groups glslparsertest (+1), glsl-es-1.00 (+4, counting new

[Mesa-dev] [PATCH] glx: Generate GLXBadDrawable when drawable is zero

2013-08-09 Thread Ian Romanick
From: Ian Romanick Fixes piglit glx-query-drawable-GLXBadDrawable. Signed-off-by: Ian Romanick Cc: "9.2" --- src/glx/glx_pbuffer.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index f11305a..183fbaa 100644 --

[Mesa-dev] [PATCH 2/2] radeonsi: don't make scanout resources linear except for cursors

2013-08-09 Thread Marek Olšák
The surface allocator understands the scanout flag just fine. This seems to improve performance for Ubuntu Unity on top of st/xorg and it fixes the cursor. --- src/gallium/drivers/radeonsi/r600_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeo

[Mesa-dev] [PATCH 1/2] st/xorg: set the SCANOUT flag for all pixmaps

2013-08-09 Thread Marek Olšák
Any pixmap can potentially end up as a scanout buffer, right? This fixes a whole-screen corruption with radeonsi, which needs a different texture layout for scanout textures. --- src/gallium/state_trackers/xorg/xorg_exa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gal

Re: [Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Roland Scheidegger
Am 09.08.2013 21:31, schrieb Roland Scheidegger: > Am 09.08.2013 21:00, schrieb Christoph Bumiller: >> On 09.08.2013 20:42, Roland Scheidegger wrote: >>> This is a proposal for new comparison instructions, as the old ones >>> don't really fit modern (graphic or opencl I guess for that matter) >>> l

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Don't leave gaps between position exports from vertex shader

2013-08-09 Thread Laurent Carlier
Le vendredi 9 août 2013 18:50:20 Michel Dänzer a écrit : > From: Michel Dänzer > > Exporting position 2/3 (clip distances) but not position 1 (point size) > causes geometry corruption for some reason. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66974 > > Cc: mesa-sta...@lists.fre

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-09 Thread Marek Olšák
On Thu, Aug 8, 2013 at 5:02 PM, Tom Stellard wrote: > On Thu, Aug 08, 2013 at 01:51:39PM +0200, Marek Olšák wrote: >> Interleaving might not be a good idea, but they could be in the same >> array, like this: >> >> 0..15: textures >> 16..31: FMASK textures >> >> I'll test LLVM master, but we should

Re: [Mesa-dev] [PATCH 2/2] R600/SI: FMA is faster than fmul and fadd for f64

2013-08-09 Thread Matt Arsenault
On 08/09/2013 05:59 AM, Niels Ole Salscheider wrote: +bool SITargetLowering::isFMAFasterThanFMulAndFAdd(EVT VT) const { + VT = VT.getScalarType(); + + if (!VT.isSimple()) +return false; + + switch (VT.getSimpleVT().SimpleTy) { + case MVT::f32: +return false; /* There is V_MAD_F32 for

Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-09 Thread Martin Andersson
On Fri, Aug 9, 2013 at 8:28 PM, Ian Romanick wrote: > On 08/09/2013 04:22 AM, Martin Andersson wrote: >> >> I think I have found an issue in the piglit test. >> >> Marek, could you take a look at the attached patch and see if it looks >> correct. If so I will send it to the piglit list. > > > Wow.

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-09 Thread Marek Olšák
On Fri, Aug 9, 2013 at 6:00 PM, Michel Dänzer wrote: > On Fre, 2013-08-09 at 08:30 -0700, Tom Stellard wrote: >> On Fri, Aug 09, 2013 at 07:35:02AM -0700, Tom Stellard wrote: >> > On Fri, Aug 09, 2013 at 07:54:11AM +0200, Michel Dänzer wrote: >> > > On Don, 2013-08-08 at 11:32 -0700, Tom Stellard

[Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-09 Thread Marek Olšák
Tested by examining generated TGSI shaders from piglit/glsl-routing. Cc: mesa-sta...@lists.freedesktop.org --- src/glsl/ir_optimization.h | 2 +- src/glsl/linker.cpp| 6 +++--- src/glsl/opt_dead_builtin_varyings.cpp | 27 +++ 3 files chang

[Mesa-dev] [PATCH] gallium/dri-targets: hide all symbols except for __driDriverExtensions

2013-08-09 Thread Marek Olšák
Most importantly, this hides all LLVM symbols. They shouldn't clash with a different LLVM version used by apps (at least in theory). $ nm -g --defined-only radeonsi_dri.so 01148f30 D __driDriverExtensions We could do something similar for the other targets. v2: add the EXTRA_ prefix so as not to

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-09 Thread Kevin H. Hobbs
On 08/09/2013 01:59 PM, Brian Paul wrote: > > That's probably not it, given the above. Can you try setting a > breakpoint on pstip_destroy() and see if that's getting called before > the segfault? If so, things are getting freed in the wrong order. > No, it is not called before the segfault.

Re: [Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Roland Scheidegger
Am 09.08.2013 21:00, schrieb Christoph Bumiller: > On 09.08.2013 20:42, Roland Scheidegger wrote: >> This is a proposal for new comparison instructions, as the old ones >> don't really fit modern (graphic or opencl I guess for that matter) >> languages well. >> If you've got objections, think the n

Re: [Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Brian Paul
Tying this to PIPE_SHADER_CAP_INTEGERS sounds good to me. And yeah, st_glsl_to_tgsi.cpp will need some work one of these days... -Brian On 08/09/2013 01:17 PM, Roland Scheidegger wrote: I was thinking it should just be part of the native_integer support (glsl 1.30 basically) so it must be supp

Re: [Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Roland Scheidegger
I was thinking it should just be part of the native_integer support (glsl 1.30 basically) so it must be supported if you support that, and it is always preferred in that case. Though I won't implement it for other drivers (just llvmpipe/softpipe), and just hope everybody will implement it so glsl c

Re: [Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Zack Rusin
- Original Message - > This is a proposal for new comparison instructions, as the old ones > don't really fit modern (graphic or opencl I guess for that matter) > languages well. > If you've got objections, think the naming is crazy or whatnot I'm open > for suggestions :-). I would think t

Re: [Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Brian Paul
Looks good to me. Will you be a adding a new PIPE_SHADER_CAP_ flag so the driver can tell the state tracker which kind of comparison instructions it wants? -Brian On 08/09/2013 12:42 PM, Roland Scheidegger wrote: This is a proposal for new comparison instructions, as the old ones don't reall

Re: [Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Christoph Bumiller
On 09.08.2013 20:42, Roland Scheidegger wrote: > This is a proposal for new comparison instructions, as the old ones > don't really fit modern (graphic or opencl I guess for that matter) > languages well. > If you've got objections, think the naming is crazy or whatnot I'm open > for suggestions :-

[Mesa-dev] [PATCH] gallium/dri-targets: hide all symbols except for __driDriverExtensions

2013-08-09 Thread Marek Olšák
Most importantly, this hides all LLVM symbols. They shouldn't clash with a different LLVM version used by apps (at least in theory). $ nm -g --defined-only radeonsi_dri.so 01148f30 D __driDriverExtensions We could do something similar for the other targets. --- src/gallium/targets/dri-freedreno/

[Mesa-dev] [RFC]: gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread Roland Scheidegger
This is a proposal for new comparison instructions, as the old ones don't really fit modern (graphic or opencl I guess for that matter) languages well. If you've got objections, think the naming is crazy or whatnot I'm open for suggestions :-). I would think this is not just a much better fit for d

[Mesa-dev] [PATCH] gallium: add new float comparison opcodes returning integer booleans

2013-08-09 Thread sroland
From: Roland Scheidegger The old float comparison opcodes always return floats 0.0 and 1.0 (clarified in docs these were really floats, was always the case) for legacy graphics. But everybody else (opengl,opencl,d3d10) just has to work around their return results (converting the returned float ba

[Mesa-dev] [Bug 41700] Gallium won't build with --enable-32-bit on a 64-bit system

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41700 Bug 41700 depends on bug 50754, which changed state. Bug 50754 Summary: Building 32 bit mesa on 64 bit OS fails since change for automake https://bugs.freedesktop.org/show_bug.cgi?id=50754 What|Removed |Added

[Mesa-dev] [Bug 45466] Updated configure.ac check for llvm-config to use 32 version when appropriate

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45466 Bug 45466 depends on bug 50754, which changed state. Bug 50754 Summary: Building 32 bit mesa on 64 bit OS fails since change for automake https://bugs.freedesktop.org/show_bug.cgi?id=50754 What|Removed |Added

[Mesa-dev] [Bug 50754] Building 32 bit mesa on 64 bit OS fails since change for automake

2013-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50754 Alexandre Demers changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-09 Thread Ian Romanick
On 08/09/2013 04:22 AM, Martin Andersson wrote: I think I have found an issue in the piglit test. Marek, could you take a look at the attached patch and see if it looks correct. If so I will send it to the piglit list. Wow. That test is confusing. It would be a lot more obvious (and less er

Re: [Mesa-dev] [i965][V2] i965/draw: Move constant formation outside of for loop and use an enum.

2013-08-09 Thread Ian Romanick
On 08/09/2013 12:33 AM, Eric Anholt wrote: Mark Mueller writes: On Thu, Aug 8, 2013 at 2:19 PM, Eric Anholt wrote: Mark Mueller writes: Signed-off-by: Mark Mueller --- src/mesa/drivers/dri/i965/brw_draw.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --gi

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Marek Olšák
On Fri, Aug 9, 2013 at 3:48 PM, Christian König wrote: > Am 09.08.2013 15:29, schrieb Marek Olšák: >> >> On Fri, Aug 9, 2013 at 10:34 AM, Christian König >> wrote: >>> >>> Am 08.08.2013 21:38, schrieb Alex Deucher: >>> On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: > > On Thu, A

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-09 Thread Brian Paul
On 08/09/2013 11:53 AM, Kevin H. Hobbs wrote: On 08/09/2013 09:16 AM, Brian Paul wrote: On 08/07/2013 12:17 PM, Kevin H. Hobbs wrote: #0 pstip_bind_sampler_states (pipe=, num=0, sampler=0x0) at draw/draw_pipe_pstipple.c:713 Hmm, I'd expect memcpy() of length zero to be fine even if src/dst

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-09 Thread Kevin H. Hobbs
On 08/09/2013 09:16 AM, Brian Paul wrote: > On 08/07/2013 12:17 PM, Kevin H. Hobbs wrote: >> >> #0 pstip_bind_sampler_states (pipe=, num=0, sampler=0x0) >> at draw/draw_pipe_pstipple.c:713 >> > Hmm, I'd expect memcpy() of length zero to be fine even if src/dst were > null. > memcpy is fine, t

Re: [Mesa-dev] [PATCH mesa 3/3] egl: Update to Wayland 1.2 server API

2013-08-09 Thread Mike Lothian
Hi I seem to have a missing symbol wayland_drm_buffer_get in libgbm.so.1 I'm pretty sure its related Regards Mike On 18 Jul 2013 13:15, "Ander Conselvan de Oliveira" < ander.conselvan.de.olive...@intel.com> wrote: > Since Wayland 1.2, struct wl_buffer and a few functions are deprecated. > > Re

[Mesa-dev] [PATCH 1/2] glsl: Fix incorrect pattern matching in ir_set_program_inouts

2013-08-09 Thread Paul Berry
In commit 8fc41df (glsl: Modify ir_set_program_inouts to handle geometry shaders), when attempting to pattern match the "foo" part of expressions such as: foo[i][j] foo[i] I incorrectly called as_dereference_variable() on the subexpression foo[i] instead of foo. As a result, the pattern ne

[Mesa-dev] [PATCH 2/2] i965/fs: Re-use output 0 for outputs without a static write.

2013-08-09 Thread Paul Berry
According to section 15.2.3 (Shader Outputs) of the GL 4.4 spec (and similar text in older GL specs), failing to write to gl_FragData[n] results in undefined data being sent to color buffer attachment n: "Writing to gl_FragColor specifies the fragment color (color number zero) that will be

[Mesa-dev] [PATCH 1/2] radeonsi: Don't leave gaps between position exports from vertex shader

2013-08-09 Thread Michel Dänzer
From: Michel Dänzer Exporting position 2/3 (clip distances) but not position 1 (point size) causes geometry corruption for some reason. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66974 Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeo

[Mesa-dev] [PATCH 2/2] radeonsi: Don't export unused clip distance vectors from vertex shader

2013-08-09 Thread Michel Dänzer
From: Michel Dänzer E.g. the Source engine seems to always write to gl_ClipVertex, but normally doesn't enable any GL_CLIP_DISTANCEn states. This change removes some irrelevant parts from the generated vertex shader code in such cases. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeo

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-09 Thread Michel Dänzer
On Fre, 2013-08-09 at 08:30 -0700, Tom Stellard wrote: > On Fri, Aug 09, 2013 at 07:35:02AM -0700, Tom Stellard wrote: > > On Fri, Aug 09, 2013 at 07:54:11AM +0200, Michel Dänzer wrote: > > > On Don, 2013-08-08 at 11:32 -0700, Tom Stellard wrote: > > > > On Thu, Aug 08, 2013 at 05:36:09PM +0200, Mi

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-09 Thread Tom Stellard
On Fri, Aug 09, 2013 at 07:35:02AM -0700, Tom Stellard wrote: > On Fri, Aug 09, 2013 at 07:54:11AM +0200, Michel Dänzer wrote: > > On Don, 2013-08-08 at 11:32 -0700, Tom Stellard wrote: > > > On Thu, Aug 08, 2013 at 05:36:09PM +0200, Michel Dänzer wrote: > > > > On Don, 2013-08-08 at 08:00 -0700, T

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-09 Thread Tom Stellard
On Fri, Aug 09, 2013 at 07:54:11AM +0200, Michel Dänzer wrote: > On Don, 2013-08-08 at 11:32 -0700, Tom Stellard wrote: > > On Thu, Aug 08, 2013 at 05:36:09PM +0200, Michel Dänzer wrote: > > > On Don, 2013-08-08 at 08:00 -0700, Tom Stellard wrote: > > > > On Thu, Aug 08, 2013 at 02:20:54AM +0200, M

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Christian König
Am 09.08.2013 15:29, schrieb Marek Olšák: On Fri, Aug 9, 2013 at 10:34 AM, Christian König wrote: Am 08.08.2013 21:38, schrieb Alex Deucher: On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: On Thu, Aug 8, 2013 at 6:57 PM, Christian König wrote: Am 08.08.2013 16:33, schrieb Marek Olšák:

Re: [Mesa-dev] Enable GLX TLS by default in Mesa?

2013-08-09 Thread Marek Olšák
If we enable glx-tls in Mesa by default, we should also do so in Glamor. Marek On Fri, Aug 9, 2013 at 9:26 AM, Vedran Rodic wrote: > Hi, > > I've been burned with the issue of GLX TLS not being enabled by > default in Mesa (Dota 2 seems to rely on it). > > What's the rationale of not enabling it

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Marek Olšák
On Fri, Aug 9, 2013 at 10:34 AM, Christian König wrote: > Am 08.08.2013 21:38, schrieb Alex Deucher: > >> On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: >>> >>> On Thu, Aug 8, 2013 at 6:57 PM, Christian König >>> wrote: Am 08.08.2013 16:33, schrieb Marek Olšák: > > On Thu,

Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-09 Thread Marek Olšák
If I understand the code correctly, value[3] should be 1. If it were 0, the bias would be 1, therefore adding 1 and clamping the alpha (because of the RGBA8 colorbuffer) would always return 1 no matter what the texture fetch returned. Anyway, if the texture fetch returned 0x, the test wou

Re: [Mesa-dev] segfault in pstip_bind_sampler_states

2013-08-09 Thread Brian Paul
On 08/07/2013 12:17 PM, Kevin H. Hobbs wrote: One of the VTK tests (vtkFiltersHybridPython-largeImageOffset) makes OSMesa segfault. This is the top of the gdb backtrace : #0 pstip_bind_sampler_states (pipe=, num=0, sampler=0x0) at draw/draw_pipe_pstipple.c:713 #1 0x7fffdf7580fc in cso_rel

[Mesa-dev] [PATCH 2/2] R600/SI: FMA is faster than fmul and fadd for f64

2013-08-09 Thread Niels Ole Salscheider
--- lib/Target/R600/SIISelLowering.cpp | 18 ++ lib/Target/R600/SIISelLowering.h | 1 + test/CodeGen/R600/fmuladd.ll | 31 +++ 3 Dateien geändert, 50 Zeilen hinzugefügt(+) create mode 100644 test/CodeGen/R600/fmuladd.ll diff --git a/lib/Target

[Mesa-dev] [PATCH 1/2] R600/SI: Add FMA pattern

2013-08-09 Thread Niels Ole Salscheider
--- lib/Target/R600/SIInstructions.td | 8 ++-- test/CodeGen/R600/fma.ll | 31 +++ 2 Dateien geändert, 37 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) create mode 100644 test/CodeGen/R600/fma.ll diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target

Re: [Mesa-dev] spec/!OpenGL 3.0/gl-3.0-texture-integer fails on r600g

2013-08-09 Thread Martin Andersson
I think I have found an issue in the piglit test. Marek, could you take a look at the attached patch and see if it looks correct. If so I will send it to the piglit list. //Martin On Tue, Aug 6, 2013 at 11:20 PM, Marek Olšák wrote: > Sorry, I have no idea. You can try to remove support for RGBX

[Mesa-dev] [PATCH 1/6] st/clover: Profiling support

2013-08-09 Thread Niels Ole Salscheider
Signed-off-by: Niels Ole Salscheider --- src/gallium/state_trackers/clover/api/event.cpp | 26 - src/gallium/state_trackers/clover/core/event.cpp | 116 --- src/gallium/state_trackers/clover/core/event.hpp | 18 +++- 3 Dateien geändert, 142 Zeilen hinzugefügt(+), 18 Zei

[Mesa-dev] [PATCH 6/6] radeonsi: Handle additional PIPE_COMPUTE_CAP_*

2013-08-09 Thread Niels Ole Salscheider
This patch adds support for: PIPE_COMPUTE_CAP_MAX_INPUT_SIZE PIPE_COMPUTE_CAP_MAX_LOCAL_SIZE Return the values reported by the closed source driver for now. Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/radeonsi/radeonsi_pipe.c | 15 ++- 1 Datei geändert, 14 Zeilen hi

[Mesa-dev] [PATCH 2/6] st/clover: Add event to deps even if it has been triggered

2013-08-09 Thread Niels Ole Salscheider
The command is submitted once the event has been triggered, but it might not have completed yet. Therefore, we have to add it to deps in order to wait on it. Signed-off-by: Niels Ole Salscheider --- src/gallium/state_trackers/clover/core/event.cpp | 2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+)

[Mesa-dev] [PATCH 4/6] radeonsi: Implement PIPE_QUERY_TIMESTAMP

2013-08-09 Thread Niels Ole Salscheider
Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/radeonsi/r600.h| 1 + src/gallium/drivers/radeonsi/r600_hw_context.c | 31 ++ src/gallium/drivers/radeonsi/r600_query.c | 14 +++- src/gallium/drivers/radeonsi/radeonsi_pipe.c | 2 +-

[Mesa-dev] [PATCH 5/6] radeonsi: copy r600_get_timestamp

2013-08-09 Thread Niels Ole Salscheider
Signed-off-by: Niels Ole Salscheider --- src/gallium/drivers/radeonsi/radeonsi_pipe.c | 9 + 1 Datei geändert, 9 Zeilen hinzugefügt(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c b/src/gallium/drivers/radeonsi/radeonsi_pipe.c index 3ba8232..7ae5598 100644 --- a/src/gallium

[Mesa-dev] [PATCH 3/6] st/clover: Unreference fences as early as possible

2013-08-09 Thread Niels Ole Salscheider
This makes sure that there are not too many concurrent fences. Also, simplify status handling by keeping track of the current state. Signed-off-by: Niels Ole Salscheider --- src/gallium/state_trackers/clover/core/event.cpp | 29 +++- src/gallium/state_trackers/clover/core/ev

Re: [Mesa-dev] Enable GLX TLS by default in Mesa?

2013-08-09 Thread Dave Airlie
> > I've been burned with the issue of GLX TLS not being enabled by > default in Mesa (Dota 2 seems to rely on it). > > What's the rationale of not enabling it by default? > not sure we have really any major reason for not doing so, it really depends on what your distro does with its Xorg and glam

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-09 Thread Christian König
Am 08.08.2013 21:38, schrieb Alex Deucher: On Thu, Aug 8, 2013 at 1:34 PM, Marek Olšák wrote: On Thu, Aug 8, 2013 at 6:57 PM, Christian König wrote: Am 08.08.2013 16:33, schrieb Marek Olšák: On Thu, Aug 8, 2013 at 3:09 PM, Christian König wrote: Am 08.08.2013 14:38, schrieb Marek Olšák:

Re: [Mesa-dev] [i965][V2] i965/draw: Move constant formation outside of for loop and use an enum.

2013-08-09 Thread Eric Anholt
Mark Mueller writes: > On Thu, Aug 8, 2013 at 2:19 PM, Eric Anholt wrote: > >> Mark Mueller writes: >> > Signed-off-by: Mark Mueller >> > --- >> > src/mesa/drivers/dri/i965/brw_draw.c | 16 ++-- >> > 1 file changed, 6 insertions(+), 10 deletions(-) >> > >> > diff --git a/src/mesa/

[Mesa-dev] Enable GLX TLS by default in Mesa?

2013-08-09 Thread Vedran Rodic
Hi, I've been burned with the issue of GLX TLS not being enabled by default in Mesa (Dota 2 seems to rely on it). What's the rationale of not enabling it by default? Thanks, Vedran Rodic ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://

Re: [Mesa-dev] [PATCH] r600g: disable GPUVM by default

2013-08-09 Thread Christian König
Am 09.08.2013 03:15, schrieb Alex Deucher: Cayman and trinity systems still seem to suffer from stability problems with GPUVM. This also fixes compute on these asics. It can still be enabled for testing by setting env var RADEON_VA=true. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=6595

Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-09 Thread Michel Dänzer
On Don, 2013-08-08 at 11:32 -0700, Tom Stellard wrote: > On Thu, Aug 08, 2013 at 05:36:09PM +0200, Michel Dänzer wrote: > > On Don, 2013-08-08 at 08:00 -0700, Tom Stellard wrote: > > > On Thu, Aug 08, 2013 at 02:20:54AM +0200, Marek Olšák wrote: > > > > > > > > diff --git a/src/gallium/drivers/rad