Re: [Mesa-dev] [PATCH] build: Install libwayland-egl.so.* symlinks in lib/

Going behind the back of libtool like this will break on any system that does not use linux style library versioning. No one wants to comment on any patches to avoid this. But if nothing else the comment about providing compatibility to the old build system is wrong as several people objected to

[Mesa-dev] [PATCH] i965/fs: Add code to print out global copy propagation sets.

This was invaluable when debugging the global copy propagation algorithm. We may as well commit it in case someone needs to print out the sets in the future. Signed-off-by: Kenneth Graunke --- .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 30 ++ 1 file changed, 30 ins

[Mesa-dev] [PATCH] build: Install libwayland-egl.so.* symlinks in lib/

Like we do for all the other libraries. Signed-off-by: Kenneth Graunke --- src/egl/wayland/wayland-egl/Makefile.am | 8 1 file changed, 8 insertions(+) diff --git a/src/egl/wayland/wayland-egl/Makefile.am b/src/egl/wayland/wayland-egl/Makefile.am index 138c170..174d305 100644 --- a/sr

Re: [Mesa-dev] [PATCH 09/10] i965: Shorten sampler loops in precompile key setup.

On 08/15/2013 10:52 PM, Paul Berry wrote: On 14 August 2013 18:55, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: Now that we have the number of samplers available, we don't need to iterate over all 16. This should be particularly helpful for vertex shaders. Signed-off-b

Re: [Mesa-dev] [PATCH 01/10] i965: Split sampler count variable to be per-stage.

On 08/16/2013 09:57 PM, Ian Romanick wrote: On 08/14/2013 06:55 PM, Kenneth Graunke wrote: Currently, we only have a single sampler state table shared among all stages, so we just copy wm.sampler_count into vs.sampler_count. In the future, each shader stage will have its own SAMPLER_STATE table

Re: [Mesa-dev] [PATCH 02/15] i965/fs: Don't kill ACP entries due to their generating instruction.

On 18 August 2013 17:06, Kenneth Graunke wrote: > On 08/15/2013 10:06 AM, Paul Berry wrote: > >> On 12 August 2013 13:11, Kenneth Graunke > **> wrote: >> >> fs_copy_prop_dataflow::setup_**kills() walks through each basic >> block's >> instructions, looking fo

Re: [Mesa-dev] [PATCH 07/15] i965/fs: Create the COPY() set for use in copy propagation dataflow.

On 08/15/2013 02:28 PM, Paul Berry wrote: On 12 August 2013 13:11, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: This is the "COPY" set from Muchnick's textbook, which is necessary to do the dataflow algorithm correctly. I believe this can be done more easily. The only ACP ent

Re: [Mesa-dev] [PATCH 02/15] i965/fs: Don't kill ACP entries due to their generating instruction.

On 08/15/2013 10:06 AM, Paul Berry wrote: On 12 August 2013 13:11, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: fs_copy_prop_dataflow::setup_kills() walks through each basic block's instructions, looking for instructions which overwrite registers used in ACP entries. Th

Re: [Mesa-dev] [PATCH] glsl: Disallow embedded structure definitions

On Saturday, August 17, 2013 01:00:51 AM Ian Romanick wrote: > From: Ian Romanick > > Continue to allow them in GLSL 1.10 because the spec allows it. > Generate an error in all other versions because the specs specifically > disallow it. > > Signed-off-by: Ian Romanick > Cc: "9.2" Reviewed-by

[Mesa-dev] [PATCH] r600g/sb: Initialize cf_node::bc.

Fixes "Uninitialized pointer field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/sb/sb_ir.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/sb/sb_ir.h b/src/gallium/drivers/r600/sb/sb_ir.h index c838f62..b69

[Mesa-dev] [PATCH] nvc0/ir: Initialize NVC0LegalizePostRA member variables.

Fixes "Uninitialized pointer field" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/nvc0/codegen/nv50_ir_lowering_nvc0.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nvc0/codegen/nv50_ir_lowering_nvc0.cpp b/src/gall

Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

On Sunday, August 18, 2013 09:34:37 AM Paul Berry wrote: > We are getting close to the maximum number of BRW_NEW_* bits that can > be stored in brw->state.dirty.brw without overflowing 32 bits, and > geometry shaders are going to add more. Add a STATIC_ASSERT so that > we will be alerted when we n

Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

On 18 August 2013 10:30, Mark Mueller wrote: > When the time comes, are there any concerns with using a 64 bit type, like > portability? 64 bits for flags would be useful for something that I'm > looking into and I'm curious how much pain that could cause. > We already use 64-bit bitfields in se

Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

When the time comes, are there any concerns with using a 64 bit type, like portability? 64 bits for flags would be useful for something that I'm looking into and I'm curious how much pain that could cause. On Sun, Aug 18, 2013 at 10:58 AM, Ian Romanick wrote: > On 08/18/2013 09:34 AM, Paul Berr

Re: [Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

On 08/18/2013 09:34 AM, Paul Berry wrote: We are getting close to the maximum number of BRW_NEW_* bits that can be stored in brw->state.dirty.brw without overflowing 32 bits, and geometry shaders are going to add more. Add a STATIC_ASSERT so that we will be alerted when we need to switch to 64 b

[Mesa-dev] [PATCH] i965: STATIC_ASSERT that there aren't too many BRW_NEW_* flags.

We are getting close to the maximum number of BRW_NEW_* bits that can be stored in brw->state.dirty.brw without overflowing 32 bits, and geometry shaders are going to add more. Add a STATIC_ASSERT so that we will be alerted when we need to switch to 64 bits. --- src/mesa/drivers/dri/i965/brw_cont

Re: [Mesa-dev] [PATCH 2/7] st/vdpau: exit gracefully if we fail to create video buffer

On 18/08/13 12:31, Christian König wrote: > Am 17.08.2013 23:51, schrieb Emil Velikov: >> Otherwise we risk causing memory corruption. >> >> v2: forgot the mutex_unlock() >> >> Signed-off-by: Emil Velikov > > NAK. Failing is actually not correct here, cause we can still make it > work by allocati

Re: [Mesa-dev] [PATCH 7/7] vl/buffers: consistent use on VL_MAX_SURFACES

Am 17.08.2013 23:51, schrieb Emil Velikov: Signed-off-by: Emil Velikov Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_video_buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_video_buffer.c b/src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 5/7] vl/idct: cleanup all idct buffers

Am 17.08.2013 23:51, schrieb Emil Velikov: Code should loop through and cleanup the three (VL_NUM_COMPONENTS) idct buffers, rather than doing the first one three times. Signed-off-by: Emil Velikov Thanks, I was already wondering for quite a while where that memory leak actually is. Reviewe

Re: [Mesa-dev] [PATCH 4/7] vl/buffer: add sanity check after CALLOC_STRUCT

Am 17.08.2013 23:51, schrieb Emil Velikov: Check if we have successfully allocated memory. Signed-off-by: Emil Velikov Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_video_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_video_buff

Re: [Mesa-dev] [PATCH 3/7] st/xvmc: exit gracefully if we fail to create video buffer

Am 17.08.2013 23:51, schrieb Emil Velikov: Free any allocated memory and return BadAlloc if create_video_buffer() has failed to create a buffer. Signed-off-by: Emil Velikov Reviewed-by: Christian König --- src/gallium/state_trackers/xvmc/surface.c | 4 1 file changed, 4 insertions(

Re: [Mesa-dev] [PATCH 2/7] st/vdpau: exit gracefully if we fail to create video buffer

Am 17.08.2013 23:51, schrieb Emil Velikov: Otherwise we risk causing memory corruption. v2: forgot the mutex_unlock() Signed-off-by: Emil Velikov NAK. Failing is actually not correct here, cause we can still make it work by allocating the video buffer later on decoding or uploading of imag

Re: [Mesa-dev] [PATCH 1/7] vdpau/vl 422 chroma width/height mix up

Am 17.08.2013 23:51, schrieb Emil Velikov: From: Andy Furniss I was looking into some minor 422 issues/discrepencies I noticed long ago using vdpau on my rv790. I noticed that there is code that is halving height rather than width - 422 is full height AFAIK. Making the changes below doesn't a

Re: [Mesa-dev] [PATCH] radeonsi: Ensure fmask_format is initialized in release builds.

Reviewed-by: Marek Olšák Marek On Sun, Aug 18, 2013 at 12:51 AM, Vinson Lee wrote: > Fixes "Uninitialized scalar variable" defect reported by Coverity. > > Signed-off-by: Vinson Lee > --- > src/gallium/drivers/radeonsi/si_state.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/ga

Re: [Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

On 18 August 2013 05:23, Ian Romanick wrote: > Since this also fixes an application, do you have any idea what could be > done to make a piglit test to reproduce the failure? We have some folks > writing piglit tests for us this summer, and this sounds like a good one for > them. :) > The basic s