Re: [Mesa-dev] [PATCH] i965: Implement ARB_texture_mirror_clamp.

2013-10-21 Thread Matt Turner
Patch title should be ARB_texture_mirror_clamp_to_edge. With that, Reviewed-by: Matt Turner matts...@gmail.com Also update GL3.txt? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Implement ARB_texture_mirror_clamp.

2013-10-21 Thread Rico Schüller
I have one minor nitpick (see below). But either way, with the subject fixed (as mentioned by Matt), this is: Reviewed-by: Rico Schüller kgbric...@web.de On 21.10.2013 07:24, Kenneth Graunke wrote: This passes Piglit's texwrap tests (after applying Rico's patch to make them use this extension).

Re: [Mesa-dev] [PATCH] gallium: new, unified pipe_context::set_sampler_views() function

2013-10-21 Thread Emil Velikov
On 16/10/13 03:23, Emil Velikov wrote: On 08/10/13 01:23, Brian Paul wrote: [...] This change touches quite a few files. I've probably missed something in drivers or state trackers that I can't test. Please test if you're able. Thanks. --- Will run a quick piglit with and w/o on my nv50

[Mesa-dev] [PATCH] docs: Update docs for ARB_texture_mirror_clamp_to_edge.

2013-10-21 Thread Rico Schüller
Signed-off-by: Rico Schüller kgbric...@web.de --- docs/GL3.txt| 2 +- docs/relnotes/10.0.html | 1 + 2 Dateien geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index a56e7fe..e8e797a 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -173,7

Re: [Mesa-dev] [PATCH 1/2] gallivm: implement seamless cube filtering

2013-10-21 Thread Jose Fonseca
Looks great AFAICT. Jose - Original Message - From: Roland Scheidegger srol...@vmware.com For seamless cube filtering it is necessary to determine new faces and new coords per sample. The logic for this is _seriously_ complex (what needs to happen is very asymmetric wrt face, x/y

Re: [Mesa-dev] [PATCH] gallium: new, unified pipe_context::set_sampler_views() function

2013-10-21 Thread Brian Paul
On 10/21/2013 02:09 AM, Emil Velikov wrote: On 16/10/13 03:23, Emil Velikov wrote: On 08/10/13 01:23, Brian Paul wrote: [...] This change touches quite a few files. I've probably missed something in drivers or state trackers that I can't test. Please test if you're able. Thanks. --- Will

[Mesa-dev] libGL without X

2013-10-21 Thread Chris Healy
I have a headless platform I need OpenGL to work on that does not have X. It is x86 with Intel HD 4000 graphics. Ultimately, I'm just wanting to use OpenGL to render to memory for encoding to H.264 and streaming. I'm trying to build Mesa for this platform without X and cannot get it to build

Re: [Mesa-dev] [PATCH 1/2] mesa: remove remnants of GL_MESA_shader_debug

2013-10-21 Thread Ian Romanick
With the one comment below taken care of, the series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 10/19/2013 07:34 AM, Brian Paul wrote: This extension never saw any real use so remove it. --- include/GL/gl.h | 20

Re: [Mesa-dev] [PATCH] docs: Mark GLSL 1.50, 3.30, and geometry shaders done for i965.

2013-10-21 Thread Ian Romanick
With the issue that Kaelyn pointed out resolved, Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 10/18/2013 03:12 PM, Matt Turner wrote: --- docs/GL3.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index c269f19..a7c7ae6

Re: [Mesa-dev] Ivybridge support for ARB_transform_feedback2

2013-10-21 Thread Ian Romanick
On 10/17/2013 11:09 PM, Kenneth Graunke wrote: Here's my implementation of ARB_transform_feedback2. I believe it's complete; it passes all of our Piglit tests and a lot of Intel's oglconform tests. This should work out of the box on Ivybridge and Baytrail. It won't work on Haswell at the

Re: [Mesa-dev] [PATCH 3/8] mesa: Pass number of samples as a program state variable

2013-10-21 Thread Anuj Phogat
On Fri, Oct 18, 2013 at 2:44 PM, Paul Berry stereotype...@gmail.com wrote: On 14 October 2013 10:12, Anuj Phogat anuj.pho...@gmail.com wrote: Number of samples will be required in fragment shader program by new GLSL builtin uniform gl_NumSamples. Signed-off-by: Anuj Phogat

[Mesa-dev] [PATCH] i965/vec4: Reduce working set size of live variables computation.

2013-10-21 Thread Eric Anholt
Orbital Explorer was generating a 4000 instruction geometry shader, which was taking 275 trips through dead code elimination and register coalescing, each of which updated live variables to get its work done, and invalidated those live variables afterwards. By using bitfields instead of bools

Re: [Mesa-dev] [PATCH] i965: Implement ARB_texture_mirror_clamp.

2013-10-21 Thread Kenneth Graunke
On 10/21/2013 12:58 AM, Rico Schüller wrote: I have one minor nitpick (see below). But either way, with the subject fixed (as mentioned by Matt), this is: Reviewed-by: Rico Schüller kgbric...@web.de On 21.10.2013 07:24, Kenneth Graunke wrote: This passes Piglit's texwrap tests (after

Re: [Mesa-dev] [PATCH] i965/fs: In the pre-regalloc schedule, try harder at reducing reg pressure.

2013-10-21 Thread Eric Anholt
Chia-I Wu olva...@gmail.com writes: On Thu, Oct 17, 2013 at 3:24 AM, Matt Turner matts...@gmail.com wrote: On Mon, Oct 14, 2013 at 4:14 PM, Eric Anholt e...@anholt.net wrote: Previously, the best thing we had was to schedule the things unblocked by the current instruction, on the hope that it

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Chris Healy
Ken, I assume the new ABI for libOpenGL.so is not far enough along to be usable in production, correct? Our application is quite big and already written against OpenGL so moving to GLESv2 or 3.0 would be a considerable effort so this is not an option. Do you know the minimal amount of X libs

Re: [Mesa-dev] Ivybridge support for ARB_transform_feedback2

2013-10-21 Thread Kenneth Graunke
On 10/21/2013 08:40 AM, Ian Romanick wrote: On 10/17/2013 11:09 PM, Kenneth Graunke wrote: Here's my implementation of ARB_transform_feedback2. I believe it's complete; it passes all of our Piglit tests and a lot of Intel's oglconform tests. This should work out of the box on Ivybridge and

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Kenneth Graunke
On 10/21/2013 07:05 AM, Chris Healy wrote: I have a headless platform I need OpenGL to work on that does not have X. It is x86 with Intel HD 4000 graphics. Ultimately, I'm just wanting to use OpenGL to render to memory for encoding to H.264 and streaming. I'm trying to build Mesa for

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Chris Healy
Actually, I think I found the answer to the minimal amount of X libs necessary. I got rid of --disable-glx from my build config and ran into the following when running configure: checking for XF86VIDMODE... no checking for DRIGL... no configure: error: Package requirements (x11 xext xdamage

[Mesa-dev] [PATCH 1/2] r600/llvm: Fix texbuf for pre EG gen

2013-10-21 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_llvm.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index 34dd3ad..d7fa5f8 100644 --- a/src/gallium/drivers/r600/r600_llvm.c +++

[Mesa-dev] [PATCH 2/2] r600/llvm: Fix isampleBuffer on preEG

2013-10-21 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_llvm.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index d7fa5f8..5afe3cb 100644 --- a/src/gallium/drivers/r600/r600_llvm.c +++

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Erik Faye-Lund
On Mon, Oct 21, 2013 at 4:05 PM, Chris Healy cphe...@gmail.com wrote: I have a headless platform I need OpenGL to work on that does not have X. It is x86 with Intel HD 4000 graphics. Ultimately, I'm just wanting to use OpenGL to render to memory for encoding to H.264 and streaming. I'm

Re: [Mesa-dev] [PATCH] i965/fs: In the pre-regalloc schedule, try harder at reducing reg pressure.

2013-10-21 Thread Eric Anholt
Matt Turner matts...@gmail.com writes: On Mon, Oct 14, 2013 at 4:14 PM, Eric Anholt e...@anholt.net wrote: Previously, the best thing we had was to schedule the things unblocked by the current instruction, on the hope that it would be consuming two values at the end of their live intervals

Re: [Mesa-dev] glBufferSubData() GPU stall reduction (DOTA2 optimization).

2013-10-21 Thread Jordan Justen
The only feedback would be that it would be nice if patch 8 were broken down somewhat. But, the only suggestions I could think of for possible items to split out were: * intel_bufferobj_buffer: remove flag parameter * set gpu_active_start/end in a lead-up patch Another question for patch 8. Would

Re: [Mesa-dev] [PATCH] i965: Only emit interpolation setup if there are actual FS inputs.

2013-10-21 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: Dead code elimination would get rid of the extra instructions, but skipping this saves iterations through the optimization loop. From shader-db: N Min MaxMedian AvgStddev x 14672 3 16

[Mesa-dev] [PATCH 1/2] i965: Fix glTexImage when packing alignment != cpp

2013-10-21 Thread Chad Versace
Fixes texture corruption of Weston clients on cairo-glesv2 backend. Commit 49ed599 introduced the bug. Corruption occured when glTexSubImage called intel_texsubimage_tiled_memcpy() with: x,y=10,9 w,h=7,7 format=GL_ALPHA(0x1906) type=GL_UNSIGNED_BYTE(0x1401)

[Mesa-dev] [PATCH 2/2] i965: Print more debuginfo in intel_texsubimage_memcpy()

2013-10-21 Thread Chad Versace
Print info about packing, format, type, and tiling. This will help debug future issues with this fastpath. CC: Frank Henigman fjhenig...@google.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 -- 1 file changed, 8

Re: [Mesa-dev] [PATCH 1/3] glsl: Use saved values instead of recomputing them.

2013-10-21 Thread Paul Berry
On 16 October 2013 16:56, Matt Turner matts...@gmail.com wrote: --- src/glsl/opt_algebraic.cpp | 12 1 file changed, 4 insertions(+), 8 deletions(-) Series is: Reviewed-by: Paul Berry stereotype...@gmail.com diff --git a/src/glsl/opt_algebraic.cpp

[Mesa-dev] [PATCH] nv50: implement multisample textures

2013-10-21 Thread Bryan Cain
This is a port of 4da54c91d24da (nvc0: implement multisample textures) to nv50. When coupled with the patch to only report 16 texture samplers (to fix crashes), all of the Piglit tests in spec/arb_texture_multisample pass. --- .../nouveau/codegen/nv50_ir_lowering_nv50.cpp |5 ++-

[Mesa-dev] Bug with glBlitFramebufferEXT(), and a piglit test for it

2013-10-21 Thread Federico Mena Quintero
Hello, everyone, Attached is a new test for piglit which exposes a bug in Mesa's software rendering (and another bug in hardware rendering, but that's not its main purpose). The bug is as follows. With software rendering, after doing a buffer swap, glBlitFrameBufferEXT() appears to to copy the

Re: [Mesa-dev] [PATCH 1/2] r600/llvm: Fix texbuf for pre EG gen

2013-10-21 Thread Tom Stellard
On Mon, Oct 21, 2013 at 10:02:12PM +0200, Vincent Lejeune wrote: Can you add an explanation to the commit messages for both patches about what was wrong with the old code? Thanks, Tom --- src/gallium/drivers/r600/r600_llvm.c | 29 + 1 file changed, 29

[Mesa-dev] [PATCH] egl: Enable EGL_EXT_client_extensions

2013-10-21 Thread Chad Versace
Insert two fields into _egl_global to hold the client extensions and statically initialize them: ClientExtensions // a struct of bools ClientExtensionString Post-patch, Mesa supports exactly one client extension, EGL_EXT_client_extensions. Signed-off-by: Chad Versace

[Mesa-dev] [Bug 70743] New: Compilation on VS2013

2013-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70743 Priority: medium Bug ID: 70743 Assignee: mesa-dev@lists.freedesktop.org Summary: Compilation on VS2013 Severity: normal Classification: Unclassified OS: All

[Mesa-dev] [Bug 70743] Compilation on VS2013

2013-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70743 --- Comment #1 from Scott Graham scott.freedesk...@h4ck3r.net --- Doesn't compile due to changes in VS2013's standard library. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 70743] Compilation on VS2013

2013-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70743 --- Comment #2 from Scott Graham scott.freedesk...@h4ck3r.net --- Created attachment 87961 -- https://bugs.freedesktop.org/attachment.cgi?id=87961action=edit compile fix for vs2013 -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 70743] Compilation on VS2013

2013-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70743 --- Comment #3 from Scott Graham scott.freedesk...@h4ck3r.net --- Comment on attachment 87961 -- https://bugs.freedesktop.org/attachment.cgi?id=87961 compile fix for vs2013 Index: include/c99/stdbool.h

[Mesa-dev] [Bug 70743] Compilation on VS2013

2013-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70743 Scott Graham scott.freedesk...@h4ck3r.net changed: What|Removed |Added Attachment #87961|0 |1 is

[Mesa-dev] [PATCH] R600/SI: fix MIMG writemask adjustement

2013-10-21 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This fixes piglit: - shaders/glsl-fs-texture2d-masked - shaders/glsl-fs-texture2d-masked-4 Signed-off-by: Marek Olšák marek.ol...@amd.com Reviewed-by: Tom Stellard thomas.stell...@amd.com --- lib/Target/R600/SIISelLowering.cpp | 27 +++--

Re: [Mesa-dev] [PATCH] i965/fs: In the pre-regalloc schedule, try harder at reducing reg pressure.

2013-10-21 Thread Chia-I Wu
On Tue, Oct 22, 2013 at 3:05 AM, Eric Anholt e...@anholt.net wrote: Chia-I Wu olva...@gmail.com writes: On Thu, Oct 17, 2013 at 3:24 AM, Matt Turner matts...@gmail.com wrote: On Mon, Oct 14, 2013 at 4:14 PM, Eric Anholt e...@anholt.net wrote: Previously, the best thing we had was to schedule

[Mesa-dev] [Bug 70743] Compilation on VS2013

2013-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70743 Stephane Marchesin marche...@icps.u-strasbg.fr changed: What|Removed |Added CC|

[Mesa-dev] i965: Improving FS register spilling performance.

2013-10-21 Thread Eric Anholt
In the process of trying to work around the spilling in the huge unigine soft shadowing shaders, I got to wondering if we couldn't just reduce the cost of spilling to the point of I don't care. Notably, there is this nice message for doing unspills on gen7 where you don't need to set up the

[Mesa-dev] [PATCH 1/5] i965/fs: Fix broken register spilling debug code.

2013-10-21 Thread Eric Anholt
Now that reg spilling generates new vgrfs, we were looping forever if you ever turned it on. Instead, move the debug code into the register allocator right near where we'd be doing spilling anyway, which should more accurately reflect how register spilling occurs in the wild. ---

[Mesa-dev] [PATCH 3/5] i965/fs: Fix register unspills from a reg_offset.

2013-10-21 Thread Eric Anholt
We were clearing the reg_offset before trying to use it. Oops. Fixes glsl-fs-texture2drect with the reg spilling debug enabled. --- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] i965/fs: Fix register spilling for 16-wide.

2013-10-21 Thread Eric Anholt
Things blew up when I enabled the debug register spill code without disabling 16-wide, so I decided to just fix 16-wide spilling. We still don't generate 16-wide when register spilling happens as part of allocation (since we expect it to be slower), but now we can experiment with allowing it in

[Mesa-dev] [PATCH 4/5] i965: Merge together opcodes for SHADER_OPCODE_GEN4_SCRATCH_READ/WRITE

2013-10-21 Thread Eric Anholt
I'm going to be introducing gen7 variants, and the previous naming was going to get confusing. --- src/mesa/drivers/dri/i965/brw_defines.h | 7 +++ src/mesa/drivers/dri/i965/brw_fs.cpp| 4 ++-- src/mesa/drivers/dri/i965/brw_fs.h | 4 ++--

[Mesa-dev] [PATCH 5/5] i965/fs: Use the gen7 scratch read opcode when possible.

2013-10-21 Thread Eric Anholt
This avoids a lot of message setup we had to do otherwise. Improves GLB2.7 performance with register spilling force enabled by 1.6442% +/- 0.553218% (n=4). --- src/mesa/drivers/dri/i965/brw_defines.h| 7 src/mesa/drivers/dri/i965/brw_eu.h | 5 +++

Re: [Mesa-dev] [PATCH 6/9] mesa: Add a new GetTransformFeedbackVertexCount() driver hook.

2013-10-21 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: DrawTransformFeedback() needs to obtain the number of vertices written to a particular stream during the last Begin/EndTransformFeedback block. The new driver hook returns exactly that information. Gallium drivers already implement this

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Chris Healy
I would still need to build Mesa with X so that libGL is built though, correct? On Mon, Oct 21, 2013 at 2:03 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, Oct 21, 2013 at 4:05 PM, Chris Healy cphe...@gmail.com wrote: I have a headless platform I need OpenGL to work on that does not

Re: [Mesa-dev] [PATCH 9/9] i965: Enable the ARB_transform_feedback2 extension on Gen7+.

2013-10-21 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: All the necessary pieces are now in place. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/intel_extensions.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 8/9] i965: Implement glDrawTransformFeedback().

2013-10-21 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: Implementing the GetTransformFeedbackVertexCount() driver hook allows the VBO module to call us with the right number of vertices. The hardware doesn't directly count the number of vertices written by SOL, so we instead use the

Re: [Mesa-dev] [PATCH 1/3] glsl: Use saved values instead of recomputing them.

2013-10-21 Thread Eric Anholt
Matt Turner matts...@gmail.com writes: --- src/glsl/opt_algebraic.cpp | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 3e5802e..b915f3c 100644 --- a/src/glsl/opt_algebraic.cpp +++

Re: [Mesa-dev] [PATCH 5/8] i965/gs: Fix up gl_PointSize input swizzling for DUAL_INSTANCED gs.

2013-10-21 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: On 18 October 2013 17:04, Eric Anholt e...@anholt.net wrote: Putting these fixups for a couple of weird cases in just MOV and ADD feels wrong to me, but maybe when I understand better what's going on it'll seem more natural. Another possibility

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Erik Faye-Lund
On Tue, Oct 22, 2013 at 2:58 AM, Chris Healy cphe...@gmail.com wrote: On Mon, Oct 21, 2013 at 2:03 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, Oct 21, 2013 at 4:05 PM, Chris Healy cphe...@gmail.com wrote: I have a headless platform I need OpenGL to work on that does not have X.

[Mesa-dev] [PATCH] gallivm: implement fully accurate corner filtering for seamless cube maps

2013-10-21 Thread sroland
From: Roland Scheidegger srol...@vmware.com d3d10 requires that cube corners are filtered with accurate weights (that is, the weight of the non-existing corner texel should be evenly distributed to the other 3 texels). OpenGL does not require this (but recommends it). This requires us to use

[Mesa-dev] [PATCH] clover: Refuse to create context with invalid properties

2013-10-21 Thread Jan Vesely
the specs say that clCreateContext reutrns error if platform value specified in properties is not a valid platform The orignal approach fials if invalid valu other than NULL pointer is provided. Fixes piglit cl-api-create-context. Signed-off-by: Jan Vesely jan.ves...@rutgers.edu ---

[Mesa-dev] [PATCH 1/2] glsl: mark variables produced by lower_named_interface_blocks.

2013-10-21 Thread Paul Berry
These variables will need to be treated specially by program_resource_visitor, so that they can be addressed through the API using their interface block name (and array index, for interface block arrays). --- src/glsl/ir.h | 12

[Mesa-dev] [PATCH 2/2] glsl: Account for interface block lowering in program_resource_visitor.

2013-10-21 Thread Paul Berry
When program_resource_visitor visits variables that were created by lower_named_interface_blocks, it needs to do extra work to un-do the effects of lower_named_interface_blocks and construct the proper API names. Fixes piglit test spec/glsl-1.50/execution/interface-blocks-api-access-members. ---

Re: [Mesa-dev] [PATCH] clover: Refuse to create context with invalid properties

2013-10-21 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: the specs say that clCreateContext reutrns error if platform value specified in properties is not a valid platform The orignal approach fials if invalid valu other than NULL pointer is provided. Fixes piglit cl-api-create-context. Honestly, I