[Mesa-dev] [Bug 72655] [llvmpipe] piglit arb_color_buffer_float-render GL_RGBA16F sanity regression

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72655 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 72657] [llvmpipe] piglit copyteximage CUBE regression

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72657 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 72656] [llvmpipe] piglit arb_color_buffer_float-render GL_RGBA16F sanity fog regression

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72656 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 72658] [llvmpipe] piglit copyteximage RECT regression

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72658 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 72659] [llvmpipe] piglit getteximage-formats init-by-rendering regression

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72659 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 72619] [llvmpipe] piglit copyteximage 2D regression

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72619 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 06/25] i965: Hook up image state upload.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:39, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 + > src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 24 > src/mesa/drivers/dri/i965/brw_state.h| 3 ++ > src/mesa/drivers/dri/i965/brw_state_upload.c |

Re: [Mesa-dev] [PATCH 05/25] i965: Define and initialize image meta-data structure.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:39, Francisco Jerez wrote: > This will be used to pass image information to the shader when we > cannot use typed surface reads and writes. All entries except > surface_idx and size are otherwise unused and will get eliminated by > the uniform packing pass. size will be us

[Mesa-dev] [Bug 70591] glxext.h:275: error: redefinition of typedef ‘GLXContextID’

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70591 --- Comment #4 from Vinson Lee --- mesa: 5a51c1b01a16d3256f9769a76d8293fea5853b1f (master) The build error appears to be compiler dependent. I can reproduce the build error with gcc 4.4 or clang 2.8 on CentOS 6. I can also reproduce the build er

Re: [Mesa-dev] [PATCH 0/2 v3] i965: Extend fast texture upload

2013-12-30 Thread Courtney Goeltzenleuchter
Awesome! Thanks Chad. Courtney On Mon, Dec 30, 2013 at 4:02 PM, Chad Versace wrote: > The patches look good to me, and I verified that this caused no Piglit > regressions on Ivybridge when applied to master-8ab47b4. > > Reviewed-by: Chad Versace > > I committed them to master. > -- Courtne

[Mesa-dev] [Bug 73174] Account request

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73174 --- Comment #1 from Jon Ashburn --- Jon Ashburn j...@lunarg.com Preferred account name: jashburn -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mes

[Mesa-dev] [Bug 73174] New: Account request

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73174 Priority: medium Bug ID: 73174 Assignee: mesa-dev@lists.freedesktop.org Summary: Account request Severity: normal Classification: Unclassified OS: All Reporter: j..

Re: [Mesa-dev] [PATCH 0/2 v3] i965: Extend fast texture upload

2013-12-30 Thread Chad Versace
The patches look good to me, and I verified that this caused no Piglit regressions on Ivybridge when applied to master-8ab47b4. Reviewed-by: Chad Versace I committed them to master. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.

Re: [Mesa-dev] [PATCH 04/25] i965: Add helper functions to calculate the slice pitch of an array or 3D miptree.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:39, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_tex_layout.c| 51 > +-- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 10 ++ > 2 files changed, 50 insertions(+), 11 deletions(-) > Since "horizontal slice pitch" and "vert

Re: [Mesa-dev] [PATCH 03/25] i965/gen7: Implement surface state set-up for shader images.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:39, Francisco Jerez wrote: > +static uint32_t > +get_image_format(struct brw_context *brw, gl_format format) > +{ > It's not clear without additional context that this function is only used in the case where the surface is both written to and read from. Can we rename it to

Re: [Mesa-dev] [PATCH 02/25] i965/gen7: Factor out texture surface state set-up from gen7_update_texture_surface().

2013-12-30 Thread Chris Forbes
+gen7_emit_texture_surface_state(struct brw_context *brw, +struct gl_texture_object *obj, +unsigned min_array_element, +unsigned max_array_element, +unsigned min_level, +

Re: [Mesa-dev] [PATCH 02/25] i965/gen7: Factor out texture surface state set-up from gen7_update_texture_surface().

2013-12-30 Thread Paul Berry
On 2 December 2013 11:39, Francisco Jerez wrote: > This moves most of the surface state set-up logic that can be shared > between textures and shader images to a separate function. > Let's make a note in the commit message that this causes the "Render Target View Extent" field to be set on textu

[Mesa-dev] [PATCH 1/2] glsl: Fix null access on file read error

2013-12-30 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/main.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index aa188b1..ff69c9a 100644 --- a/src/glsl/main.cpp +++ b/src/glsl/main.cpp @@ -221,7 +221,7 @@ load_text_file(void *ctx, const ch

[Mesa-dev] [PATCH 0/2] two Klocwork related patches.

2013-12-30 Thread Juha-Pekka Heikkila
Some null checks into glx_pbuffer.c. Still wonder should these be made as asserts instead of regular "if"s because if __glXInitialize() return NULL here there is something very wrong. glsl patch is the same as I sent earlier today with one typo fixed. It somehow was missing one semicolon causing a

[Mesa-dev] [PATCH 2/2] glx: Add some missing null checks in glx_pbuffer.c

2013-12-30 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glx_pbuffer.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 183fbaa..411d6e5 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx/glx_pbuffer.c @@ -60,7 +60,7

Re: [Mesa-dev] [PATCH 23/23] i965: Add polymorphic backend_visitor method to extract the result of a visit.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:36, Francisco Jerez wrote: > This will be used by the generic implementation of the image and > atomic counter built-ins to extract the register location of its > arguments without having to be aware of the actual visitor type. > I have the same concerns about object slicin

Re: [Mesa-dev] [PATCH 21/23] i965: Add helper function to find out the signedness of a register type.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:36, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_reg.h | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_reg.h > b/src/mesa/drivers/dri/i965/brw_reg.h > index 37a2ca9..2591cbf 100644 > --- a/src/mes

Re: [Mesa-dev] [PATCH 17/23] i965/vec4: Trivial improvements to the with_writemask() function.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:31, Francisco Jerez wrote: > Add assertion that the register is not in the HW_REG or IMM file, > calculate the conjunction of the old and new mask instead of replacing > the old [consistent with the behavior of brw_writemask(), causes no > functional changes right now], make

Re: [Mesa-dev] [PATCH 13/23] i965/fs: Take into account reg_offset consistently for MRF regs.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:31, Francisco Jerez wrote: > Until now it was only being taken into account in the VEC4 back-end > but not in the FS back-end. Do it in both cases. > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 +- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 10 ++-

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #3 from Christian Zigotzky --- (In reply to comment #2) > This is probably due to commit 2151d893fbd4a4be092098170e2fbca8c35797a5 > ('gallium: Fix llvmpipe on big-endian machines'). The r600g driver needs to > be adapted for the chang

Re: [Mesa-dev] [PATCH 10/23] i965/fs: Remove fs_reg::sechalf.

2013-12-30 Thread Paul Berry
On 2 December 2013 11:31, Francisco Jerez wrote: > +/** > + * Get either of the 8-component halves of a 16-component register. > + */ > +static inline fs_reg > +half(const fs_reg ®, unsigned idx) > +{ > + assert(idx == 0 || (reg.file != HW_REG && reg.file != IMM)); > + return byte_offset(reg,

Re: [Mesa-dev] [PATCH 08/23] i965/fs: Add support for specifying register horizontal strides.

2013-12-30 Thread Paul Berry
On 19 December 2013 14:52, Francisco Jerez wrote: > Paul Berry writes: > > >[...] > > In v2 of this patch, you add the following code to > > fs_visitor::try_copy_propagate(): > > > > + /* Bail if the result of composing both strides cannot be expressed > > +* as another stride. > > +*/

[Mesa-dev] [Bug 72926] Memory corruption (crash) in draw/draw_pt_fetch_shade_pipeline_llvm.c:435

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72926 --- Comment #5 from Peter Wu --- Created attachment 91336 --> https://bugs.freedesktop.org/attachment.cgi?id=91336&action=edit Output for `LIBGL_ALWAYS_SOFTWARE=1 valgrind glretrace -v java.trace` Same config, but with `-v` added to `glretrace

[Mesa-dev] [PATCH] mesa: remove _mesa_symbol_table_iterator structure

2013-12-30 Thread Tapani Pälli
Nothing uses this structure, removal fixes Klocwork error about the possible oom condition in _mesa_symbol_table_iterator_ctor. Signed-off-by: Tapani Pälli --- src/mesa/program/symbol_table.c | 86 - src/mesa/program/symbol_table.h | 13 --- 2 files ch

[Mesa-dev] [PATCH] glsl: Fix null access on file read error

2013-12-30 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/main.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index aa188b1..755bc9a 100644 --- a/src/glsl/main.cpp +++ b/src/glsl/main.cpp @@ -221,7 +221,7 @@ load_text_file(void *ctx, const ch

[Mesa-dev] [Bug 73144] Queries on textures with borders give incorrect results

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73144 --- Comment #1 from Bruce Merry --- Created attachment 91328 --> https://bugs.freedesktop.org/attachment.cgi?id=91328&action=edit Patch to add test to piglit -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [Bug 73144] New: Queries on textures with borders give incorrect results

2013-12-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73144 Priority: medium Bug ID: 73144 Assignee: mesa-dev@lists.freedesktop.org Summary: Queries on textures with borders give incorrect results Severity: normal Classification:

[Mesa-dev] [PATCH 0/2] v4: Fix array overrun with too many uniforms

2013-12-30 Thread Petri Latvala
Fourth version of patch series. - Fixed vec4_register_coalesce unit test. That test passes NULL for prog_data, which Mesa proper doesn't do. - Renamed uniform_param_count to uniform_array_size. - Used ALIGN() to round up when dividing buffer size by 4. - Used MAX2() instead of taking maximum man

[Mesa-dev] [PATCH 2/2] i965: Assert array index on access to vec4_visitor's arrays.

2013-12-30 Thread Petri Latvala
Signed-off-by: Petri Latvala --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 ++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 ++ 2 files changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index fb57707..4dc0482

[Mesa-dev] [PATCH 1/2] i965: Allocate vec4_visitor's uniform_size and uniform_vector_size arrays dynamically.

2013-12-30 Thread Petri Latvala
v2: Don't add function parameters, pass the required size in prog_data->nr_params. v3: - Use the name uniform_array_size instead of uniform_param_count. - Round up when dividing param_count by 4. - Use MAX2() instead of taking the maximum by hand. - Don't crash if prog_data passed to vec4_visitor

Re: [Mesa-dev] [PATCH 1/2] i965: Allocate vec4_visitor's uniform_size and uniform_vector_size arrays dynamically.

2013-12-30 Thread Petri Latvala
On 12/20/2013 08:54 PM, Ian Romanick wrote: This patch breaks the test_vec4_register_coalesce unit test. Did you run 'make check'? I thought I did, but turns out I didn't. Just ran piglit tests. Fix coming up. -- Petri Latvala ___ mesa-dev mail

Re: [Mesa-dev] [PATCH 1/2] i965: Allocate vec4_visitor's uniform_size and uniform_vector_size arrays dynamically.

2013-12-30 Thread Petri Latvala
On 12/20/2013 09:26 PM, Kenneth Graunke wrote: On 11/27/2013 05:28 AM, Petri Latvala wrote: v2: Don't add function parameters, pass the required size in prog_data->nr_params. Signed-off-by: Petri Latvala --- src/mesa/drivers/dri/i965/brw_vec4.h | 5 +++-- src/mesa/drivers/dri/i965