Re: [Mesa-dev] [PATCH] mesa: Use get_local_param_pointer in glProgramLocalParameters4fvEXT().

2014-01-06 Thread Laurent Carlier
Le dimanche 5 janvier 2014, 20:10:17 Kenneth Graunke a écrit : Using the get_local_param_pointer helper ensures that the LocalParams arrays have actually been allocated before attempting to use them. glProgramLocalParameters4fvEXT needs to do a bit of extra checking, but it can be simplified

Re: [Mesa-dev] gallium endianness and hw drivers

2014-01-06 Thread Michel Dänzer
On Fre, 2013-12-27 at 19:41 +0100, Marek Olšák wrote: Okay. Using Axxx for transfers only is a good idea, just please make sure the formats are not advertised to the state tracker. Advertising the format to the state tracker is the whole point :), as it's the format that matches the X11

Re: [Mesa-dev] [PATCH 1/2] radeonsi: disable HTILE for 1D-tiled depth-stencil buffers

2014-01-06 Thread Michel Dänzer
This series is Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer ___ mesa-dev mailing list

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #4 from Michel Dänzer mic...@daenzer.net --- (In reply to comment #3) Is the bug fixed? Not yet. To fix it, the r600g driver needs to be adapted to changes in the way the Gallium3D infrastructure deals with big endian hosts. --

[Mesa-dev] [PATCH 1/4] winsys/radeon: Add a millisecond time function

2014-01-06 Thread Lauri Kasanen
v2: Move to a timing thread to minimize overhead. Signed-off-by: Lauri Kasanen c...@gmx.com --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 25 +++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.h | 12 +++ 2 files changed, 37 insertions(+) diff --git

[Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

2014-01-06 Thread Lauri Kasanen
No measurable overhead when off (glxgears within 0.5%). v2: Cosmetic changes. Signed-off-by: Lauri Kasanen c...@gmx.com --- src/gallium/drivers/radeon/r600_pipe_common.c | 32 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 1 +

[Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-06 Thread Lauri Kasanen
These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears). Signed-off-by: Lauri Kasanen c...@gmx.com --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 16

[Mesa-dev] [PATCH 4/4] radeon: Determine the bo priority (MSAA, depth, UVD are high)

2014-01-06 Thread Lauri Kasanen
Signed-off-by: Lauri Kasanen c...@gmx.com --- src/gallium/drivers/radeon/r600_buffer_common.c | 8 src/gallium/drivers/radeon/radeon_uvd.c | 4 ++-- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 4 src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 1 +

[Mesa-dev] [Bug 69101] prime: black window

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69101 --- Comment #11 from Alexander Mezin mezin.alexan...@gmail.com --- Even with UXA, I still have black window instead of fullscreen games -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #5 from Christian Zigotzky chzigot...@xenosoft.de --- (In reply to comment #4) (In reply to comment #3) Is the bug fixed? Not yet. To fix it, the r600g driver needs to be adapted to changes in the way the Gallium3D

Re: [Mesa-dev] [PATCH 5/6][RFC] Gallium/dri2: implement blitImage

2014-01-06 Thread Marek Olšák
On Sun, Jan 5, 2014 at 10:26 PM, Axel Davy axel.d...@ens.fr wrote: Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/dri/drm/dri2.c | 49 +-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-06 Thread Andreas Hartmetz
Hello, many of the files in radeonsi originally came from other places where they had different names and were never renamed. Most of them now have names that don't tell what the files are for (r600 is not actually the first hardware supported by them, they start at radeonsi), and even those with

Re: [Mesa-dev] Naming everything in src/gallium/drivers/radeonsi si_*

2014-01-06 Thread Marek Olšák
It sounds good, but I'd like the prefix to be si_ everywhere. Marek On Mon, Jan 6, 2014 at 2:47 PM, Andreas Hartmetz ahartm...@gmail.com wrote: Hello, many of the files in radeonsi originally came from other places where they had different names and were never renamed. Most of them now have

Re: [Mesa-dev] [PATCH] radeonsi: calculate NUM_BANKS for DB correctly on CIK

2014-01-06 Thread Alex Deucher
On Sun, Jan 5, 2014 at 6:53 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com NUM_BANKS is not constant on CIK. Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- src/gallium/drivers/radeonsi/si_state.c | 23 +++

[Mesa-dev] [PATCH 1/5] Fixing a typo and some indentation

2014-01-06 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index fd3a04c..7a7b057 100644 ---

Re: [Mesa-dev] [PATCH 3/9] util: add fma3 or fma4 capable cpu detection

2014-01-06 Thread Roland Scheidegger
Am 05.01.2014 00:42, schrieb Maxence Le Doré: From: Maxence Le Doré Maxence Le Doré --- src/gallium/auxiliary/util/u_cpu_detect.c | 5 + src/gallium/auxiliary/util/u_cpu_detect.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c

Re: [Mesa-dev] [PATCH 4/9] gallium-tgsi: add TGSI_OPCODE_{FMA-POPCNT-MSB-LSB} description

2014-01-06 Thread Roland Scheidegger
Am 05.01.2014 01:34, schrieb Maxence Le Doré: FMA(a,b,c) keeps extra precision (usually 1 more bit of mantissa, afaik) for the result a*b and add this to c, to finally produce a IEEE754 32bit float result. MAD(a,b,c) product a IEEE754 32bit float product a*b and add it to C. So, fma can

[Mesa-dev] [v2] Cleaning compute_memory_pool from gallium/drivers/r600

2014-01-06 Thread Bruno Jiménez
Hi, This is the second version of my previous patches. I have cleaned a bit compute_memory_pool.c, added some NULL checks to the code, corrected a typo and removed an unneeded decraration of a function. Patches 1 and 2 are the same. Patch 3 changes Returns to @returns so doxygen can parse it

[Mesa-dev] [PATCH 2/5] Adding checks for NULL after CALLOC

2014-01-06 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index 7a7b057..62d1a5c 100644 --- a/src/gallium/drivers/r600/compute_memory_pool.c +++

[Mesa-dev] [PATCH 4/5] Tidy a bit compute_memory_finalize_pending

2014-01-06 Thread Bruno Jiménez
Explanation of the changes, as requested by Tom Stellard: Let's take need after is calculated as item-size_in_dw+2048 - (pool-size_in_dw - allocated) BEFORE: If need is positive or 0: we calculate need += 1024 - (need % 1024), which is like cealing to the nearest multiple of 1024,

[Mesa-dev] [PATCH 5/5] Cleanup of compute_memory_pool.h

2014-01-06 Thread Bruno Jiménez
Removed compute_memory_defrag declaration because it seems to be unimplemented. I think that this function would have been the one that solves the problem with fragmentation that compute_memory_finalize_pending has. Also removed comments that are already at compute_memory_pool.c ---

Re: [Mesa-dev] [PATCH] docs: gratuitous spelling pass

2014-01-06 Thread Brian Paul
On 01/03/2014 04:44 PM, Nathan Kidd wrote: From: Nathan Kidd nk...@opentext.com Fixed what I noticed; no warranty for exhaustiveness. Signed-off-by: Nathan Kidd nk...@opentext.com --- docs/conform.html|2 +- docs/devinfo.html|2 +- docs/dispatch.html | 10 +-

Re: [Mesa-dev] [PATCH 5/9] tgsi: implement micro_fma() in tgsi exec machine

2014-01-06 Thread Erik Faye-Lund
On Sun, Jan 5, 2014 at 12:42 AM, Maxence Le Doré maxence.led...@gmail.com wrote: From: Maxence Le Doré Maxence Le Doré Huh, user.email not configured properly? static void +micro_fma(union tgsi_exec_channel *dst, + const union tgsi_exec_channel *src0, + const union

[Mesa-dev] [PATCH 3/5] Add more NULL checks

2014-01-06 Thread Bruno Jiménez
In this case, NULL checks are added to compute_memory_grow_pool, so it returns -1 when it fails. This makes necesary to handle such cases in compute_memory_finalize_pending when it is needed to grow the pool --- src/gallium/drivers/r600/compute_memory_pool.c | 30 --

Re: [Mesa-dev] [PATCH 1/7] mesa: implement glBindBuffersBase() and gl BindBuffersRange()

2014-01-06 Thread Brian Paul
On 01/03/2014 06:39 AM, servuswiege...@yahoo.de wrote: when you create the patches with git, you can add --cover-letter to the command line. then you get a PATCH 0/X file with an overview over all changes and a central place where you can describe what you've done in general/which extension etc.

Re: [Mesa-dev] [PATCH] mesa: Use get_local_param_pointer in glProgramLocalParameters4fvEXT().

2014-01-06 Thread Brian Paul
On 01/05/2014 09:10 PM, Kenneth Graunke wrote: Using the get_local_param_pointer helper ensures that the LocalParams arrays have actually been allocated before attempting to use them. glProgramLocalParameters4fvEXT needs to do a bit of extra checking, but it can be simplified since the helper

Re: [Mesa-dev] [v2] Cleaning compute_memory_pool from gallium/drivers/r600

2014-01-06 Thread Brian Paul
On 01/06/2014 08:15 AM, Bruno Jiménez wrote: Hi, This is the second version of my previous patches. I have cleaned a bit compute_memory_pool.c, added some NULL checks to the code, corrected a typo and removed an unneeded decraration of a function. Patches 1 and 2 are the same. Patch 3 changes

Re: [Mesa-dev] [PATCH 4/4] mesa/main: Free ctx-DrawIndirectBuffer during teardown

2014-01-06 Thread Brian Paul
On 01/02/2014 11:38 AM, Aaron Watry wrote: ctx-DrawIndirectBuffer wasn't being free'd in _mesa_free_buffer_objects With this patch, valgrind --leak-check=full glxgears on evergreen (CEDAR) now shows: LEAK SUMMARY: definitely lost: 0 bytes in 0 blocks indirectly lost: 0 bytes in 0

Re: [Mesa-dev] [PATCH 0/2] More null checks into glx

2014-01-06 Thread Brian Paul
On 01/03/2014 05:57 AM, Juha-Pekka Heikkila wrote: Still Klocwork related patches. Juha-Pekka Heikkila (2): glx: Add missing null check in __glXNewIndirectAPI() glx: check memory allocations in __glXInitVertexArrayState() src/glx/indirect_vertex_array.c | 27

Re: [Mesa-dev] [PATCH 2/7] mesa: add an index_to_target_enum() function

2014-01-06 Thread Brian Paul
On 01/02/2014 05:27 PM, Maxence Le Doré wrote: From: Maxence Le Doré Maxence Le Doré --- src/mesa/main/texobj.c | 40 1 file changed, 40 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index d6510fe..bddbc50 100644 ---

Re: [Mesa-dev] [PATCH 2/5] Adding checks for NULL after CALLOC

2014-01-06 Thread Alex Deucher
On Mon, Jan 6, 2014 at 10:15 AM, Bruno Jiménez brunoji...@gmail.com wrote: --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index

Re: [Mesa-dev] [PATCH 3/5] Add more NULL checks

2014-01-06 Thread Alex Deucher
On Mon, Jan 6, 2014 at 10:15 AM, Bruno Jiménez brunoji...@gmail.com wrote: In this case, NULL checks are added to compute_memory_grow_pool, so it returns -1 when it fails. This makes necesary to handle such cases in compute_memory_finalize_pending when it is needed to grow the pool Same

Re: [Mesa-dev] [PATCH] haiku libGL: Move from gallium target to src/hgl

2014-01-06 Thread Brian Paul
On 12/31/2013 09:03 PM, Alexander von Gluck IV wrote: * The Haiku renderers need to link to libGL to function properly in all usage contexts. As mesa drivers build before gallium targets, we couldn't properly link the mesa swrast driver to the gallium libGL target for Haiku. * This is

Re: [Mesa-dev] [PATCH 2/5] Adding checks for NULL after CALLOC

2014-01-06 Thread Bruno Jimenez
On Mon, 2014-01-06 at 12:51 -0500, Alex Deucher wrote: On Mon, Jan 6, 2014 at 10:15 AM, Bruno Jiménez brunoji...@gmail.com wrote: --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

2014-01-06 Thread Anuj Phogat
On Sun, Jan 5, 2014 at 2:28 PM, Eric Anholt e...@anholt.net wrote: Anuj Phogat anuj.pho...@gmail.com writes: On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt e...@anholt.net wrote: Noticed by tex3d-maxsize on my next commit to check that our addresses don't overflow. ---

[Mesa-dev] [Bug 73174] Account request

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73174 Brian Paul bri...@vmware.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 73144] Queries on textures with borders give incorrect results

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73144 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/3] i965: Ensure that intel_bufferobj_map_range meets alignment guarantees

2014-01-06 Thread Kenneth Graunke
On 01/03/2014 04:51 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com No piglit regressions on IVB. With minor tweaks to the arb_map_buffer_alignment-map-invalidate-range test (disable the extension check, set alignment to 64 instead of querying), the i965 driver would

Re: [Mesa-dev] [PATCH 3/3] i915: Silence warning: unused parameter warning in intel_bufferobj_buffer

2014-01-06 Thread Kenneth Graunke
On 01/03/2014 04:51 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com intel_buffer_objects.c: In function 'old_intel_bufferobj_buffer': old_? :) intel_buffer_objects.c:471:17: warning: unused parameter 'flag' [-Wunused-parameter] The parameter hasn't been used since

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

2014-01-06 Thread Kenneth Graunke
On 01/05/2014 02:28 PM, Eric Anholt wrote: Anuj Phogat anuj.pho...@gmail.com writes: On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt e...@anholt.net wrote: Noticed by tex3d-maxsize on my next commit to check that our addresses don't overflow. --- src/mesa/drivers/dri/i965/intel_blit.c

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

2014-01-06 Thread Ian Romanick
On 12/23/2013 04:08 PM, Eric Anholt wrote: Noticed by tex3d-maxsize on my next commit to check that our addresses don't overflow. Should this also go to stable branches? --- src/mesa/drivers/dri/i965/intel_blit.c| 20

Re: [Mesa-dev] [PATCH 1/7] i965: Warning fix

2014-01-06 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 12/23/2013 04:08 PM, Eric Anholt wrote: --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c

Re: [Mesa-dev] [PATCH 3/3] i915: Silence warning: unused parameter warning in intel_bufferobj_buffer

2014-01-06 Thread Ian Romanick
On 01/06/2014 10:51 AM, Kenneth Graunke wrote: On 01/03/2014 04:51 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com intel_buffer_objects.c: In function 'old_intel_bufferobj_buffer': old_? :) There are #defines that wrap the names in i915 that are duplicates of names in

Re: [Mesa-dev] [PATCH 5/6][RFC] Gallium/dri2: implement blitImage

2014-01-06 Thread Axel Davy
On 06/01/2014, Marek Olšák wrote : On Sun, Jan 5, 2014 at 10:26 PM, Axel Davy axel.d...@ens.fr wrote: Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/dri/drm/dri2.c | 49 +-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 3/4] r200: Free glCtx in radeonDestroyContext

2014-01-06 Thread Ian Romanick
On 01/02/2014 10:38 AM, Aaron Watry wrote: Note: I don't have hardware to test this, but I believe it to be correct. Found while tracking down a related leak in evergreen context management. --- src/mesa/drivers/dri/radeon/radeon_common_context.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Mesa-dev] [PATCH 2/6][RFC] drirc: Add string support

2014-01-06 Thread Ian Romanick
On 01/05/2014 01:26 PM, Axel Davy wrote: This may require changes to the driconf gui. Signed-off-by: Axel Davy axel.d...@ens.fr --- src/mesa/drivers/dri/common/xmlconfig.c | 24 src/mesa/drivers/dri/common/xmlconfig.h | 7 ++- 2 files changed, 30

Re: [Mesa-dev] [PATCH 1/7] intel: support factors for min/max blending

2014-01-06 Thread Ian Romanick
On 01/02/2014 05:18 PM, Maxence Le Doré wrote: --- src/mesa/drivers/dri/i915/i830_state.c | 12 src/mesa/drivers/dri/i965/brw_util.c | 24 +--- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i830_state.c

Re: [Mesa-dev] [PATCH 3/4] r200: Free glCtx in radeonDestroyContext

2014-01-06 Thread Aaron Watry
On Mon, Jan 6, 2014 at 1:26 PM, Ian Romanick i...@freedesktop.org wrote: On 01/02/2014 10:38 AM, Aaron Watry wrote: Note: I don't have hardware to test this, but I believe it to be correct. Found while tracking down a related leak in evergreen context management. ---

[Mesa-dev] [Bug 73096] Query GL_RGBA_SIGNED_COMPONENTS_EXT missing

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73096 Brian Paul bri...@vmware.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |bri...@vmware.com

[Mesa-dev] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Brian Paul
This is part of the GL_EXT_packed_float extension. Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=73096 Cc: 10.0 mesa-sta...@lists.freedesktop.org --- src/mesa/main/formats.c | 19 +++ src/mesa/main/formats.h |3 +++ src/mesa/main/get.c

Re: [Mesa-dev] [PATCH 1/7] mesa: implement glBindBuffersBase() and gl BindBuffersRange()

2014-01-06 Thread Ian Romanick
On 01/02/2014 04:27 PM, Maxence Le Doré wrote: --- src/mesa/main/bufferobj.c | 158 ++ src/mesa/main/bufferobj.h | 9 ++- 2 files changed, 165 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Chris Forbes
On Tue, Jan 7, 2014 at 8:57 AM, Brian Paul bri...@vmware.com wrote: --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -611,6 +611,9 @@ descriptor=[ # GL_ARB_fragment_program [ FRAGMENT_PROGRAM_ARB, CONTEXT_BOOL(FragmentProgram.Enabled),

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Brian Paul
On 01/06/2014 01:01 PM, Chris Forbes wrote: On Tue, Jan 7, 2014 at 8:57 AM, Brian Paul bri...@vmware.com wrote: --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -611,6 +611,9 @@ descriptor=[ # GL_ARB_fragment_program [ FRAGMENT_PROGRAM_ARB,

[Mesa-dev] [PATCH] mesa: Remove GLXContextID typedef from glxext.h.

2014-01-06 Thread Vinson Lee
This patch fixes this build error with gcc = 4.5 and clang = 3.1. CC clientattrib.lo In file included from ../../include/GL/glx.h:333:0, from glxclient.h:45, from clientattrib.c:32: ../../include/GL/glxext.h:275:13: error: redefinition of typedef

Re: [Mesa-dev] [PATCH] mesa: Remove GLXContextID typedef from glxext.h.

2014-01-06 Thread Kenneth Graunke
On 01/06/2014 12:17 PM, Vinson Lee wrote: This patch fixes this build error with gcc = 4.5 and clang = 3.1. CC clientattrib.lo In file included from ../../include/GL/glx.h:333:0, from glxclient.h:45, from clientattrib.c:32:

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Chris Forbes
+ const GLboolean signd = +rb ? _mesa_is_format_signed(rb- Format) : GL_FALSE; + v-value_int_4[0] = + v-value_int_4[1] = + v-value_int_4[2] = + v-value_int_4[3] = signd; Might have gone with something like is_signed rather than dropping a letter

Re: [Mesa-dev] [PATCH 4/7] i965: Add an assert for when SET_FIELD's value exceeds the field size.

2014-01-06 Thread Kenneth Graunke
On 12/23/2013 04:08 PM, Eric Anholt wrote: This was one of the things we always wanted to do to this, to make it more useful than just (value FIELD_MASK). --- src/mesa/drivers/dri/i965/brw_defines.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Kenneth Graunke
On 01/06/2014 11:57 AM, Brian Paul wrote: This is part of the GL_EXT_packed_float extension. Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=73096 Cc: 10.0 mesa-sta...@lists.freedesktop.org Thanks, Brian! Reviewed-by: Kenneth Graunke kenn...@whitecape.org

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-06 Thread Brian Paul
On 01/06/2014 01:21 PM, Chris Forbes wrote: + const GLboolean signd = +rb ? _mesa_is_format_signed(rb- Format) : GL_FALSE; + v-value_int_4[0] = + v-value_int_4[1] = + v-value_int_4[2] = + v-value_int_4[3] = signd; Might have gone with

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #6 from Christian Zigotzky chzigot...@xenosoft.de --- Created attachment 91561 -- https://bugs.freedesktop.org/attachment.cgi?id=91561action=edit Lubuntu 13.10 PowerPC (Kernel 3.13-rc7) with the old Mesa 8.0.2 Lubuntu 13.10 PowerPC

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 Christian Zigotzky chzigot...@xenosoft.de changed: What|Removed |Added Attachment #91561|text/plain |image/jpeg

[Mesa-dev] [PATCH 1/5] [r600g] Fixing a typo and some indentation

2014-01-06 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index fd3a04c..7a7b057 100644 ---

[Mesa-dev] [v3][r600g] Cleaning compute_memory_pool from gallium/drivers/r600

2014-01-06 Thread Bruno Jiménez
Hi, Third version of the patches. Now with r600g in the commit messages. Patches 2 and 3 have spaces between 'if' and '('. Patches 1,4 and 5 are the same. Thanks! [PATCH 1/5] [r600g] Fixing a typo and some indentation [PATCH 2/5] [r600g] Adding checks for NULL after CALLOC [PATCH 3/5] [r600g]

[Mesa-dev] [PATCH 3/5] [r600g] Add more NULL checks

2014-01-06 Thread Bruno Jiménez
In this case, NULL checks are added to compute_memory_grow_pool, so it returns -1 when it fails. This makes necesary to handle such cases in compute_memory_finalize_pending when it is needed to grow the pool --- src/gallium/drivers/r600/compute_memory_pool.c | 30 --

[Mesa-dev] [PATCH 5/5] [r600g] Cleanup of compute_memory_pool.h

2014-01-06 Thread Bruno Jiménez
Removed compute_memory_defrag declaration because it seems to be unimplemented. I think that this function would have been the one that solves the problem with fragmentation that compute_memory_finalize_pending has. Also removed comments that are already at compute_memory_pool.c ---

[Mesa-dev] [PATCH 2/5] [r600g] Adding checks for NULL after CALLOC

2014-01-06 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index 7a7b057..da351d8 100644 --- a/src/gallium/drivers/r600/compute_memory_pool.c +++

[Mesa-dev] [PATCH 2/2] glsl: Optimize pow(2, x) -- exp2(x).

2014-01-06 Thread Kenneth Graunke
On Haswell, POW takes 24 cycles, while EXP2 only takes 14. Plus, using POW requires putting 2.0 in a register, while EXP2 doesn't. I believe that EXP2 will be faster than POW on basically all GPUs, so it makes sense to optimize it. Looking at the savage2 subset of shader-db: total instructions

[Mesa-dev] [PATCH 1/2] glsl: Refactor is_zero/one/negative_one into an is_value() method.

2014-01-06 Thread Kenneth Graunke
This patch creates a new generic is_value() method, which checks if an ir_constant has a particular value. (For vectors, it must have the single value repeated across all components.) It then rewrites the is_zero/is_one/is_negative_one methods to use this generic helper. All three were

Re: [Mesa-dev] AMD_shader_trinary_minmax V2 changes

2014-01-06 Thread Kenneth Graunke
On 01/02/2014 03:22 PM, Maxence Le Doré wrote: - Correct typo in predicate function - Split the patch that introduces ir_builder changes - Drop trivial min3_expr(), max3_expr(), mid3_expr() - Thanks to Roland Scheidegger and Mario Rugiero, catch all cases for evaluation of mid3 - Squash

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #7 from Christian Zigotzky chzigot...@xenosoft.de --- Created attachment 91566 -- https://bugs.freedesktop.org/attachment.cgi?id=91566action=edit glxgears has wrong colors with Mesa 10.0.1 -- You are receiving this mail because:

[Mesa-dev] [PATCH] glsl: Simplify built-in generator functions for min3/max3/mid3.

2014-01-06 Thread Kenneth Graunke
The type of all three parameters are identical, so we don't need to specify it three times. The predicate is always identical too, so we don't need to make it a parameter, either. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Maxence Le Doré maxence.led...@gmail.com ---

Re: [Mesa-dev] [PATCH] configure: Disable xvmc by default

2014-01-06 Thread Vinson Lee
On Sun, Jan 5, 2014 at 7:00 PM, Tom Stellard t...@stellard.net wrote: On Sun, Jan 05, 2014 at 09:49:53PM -0500, Ilia Mirkin wrote: On Sun, Jan 5, 2014 at 9:49 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com The xvmc unit tests are failing on r300g and

[Mesa-dev] [Bug 73337] New: ir_builder.h(187) : error C2226: syntax error : unexpected type 'ir_builder::operand'

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73337 Priority: medium Bug ID: 73337 Keywords: regression CC: kenn...@whitecape.org Assignee: mesa-dev@lists.freedesktop.org Summary: ir_builder.h(187) : error C2226: syntax error :

Re: [Mesa-dev] [v3][r600g] Cleaning compute_memory_pool from gallium/drivers/r600

2014-01-06 Thread Marek Olšák
The r600g prefix is wrong. Your commit messages should follow the same conventions the other Mesa developers use (see the git log for examples). Since you're changing compute, you should use the prefix r600g/compute: (r600g: is okay too), but never [r600g]. The subjects of your emails don't have

[Mesa-dev] [PATCH] glsl: rename min(), max() functions to fix MSVC build

2014-01-06 Thread Brian Paul
Evidently, there's some other definition of min and max that causes MSVC to choke on these function names. Renaming to min2() and max2() fixes things. --- src/glsl/builtin_functions.cpp |6 +++--- src/glsl/ir_builder.cpp|4 ++-- src/glsl/ir_builder.h |4 ++-- 3 files

Re: [Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

2014-01-06 Thread Marek Olšák
Is the logging really needed apart from initial debugging and validation of the code? I don't see a reason to have this in master. Also, pipe_screen functions must not change the contents of radeon_winsys. They are different objects. The two can only communicate using the functions declared in

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

2014-01-06 Thread Anuj Phogat
On Mon, Jan 6, 2014 at 11:00 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 01/05/2014 02:28 PM, Eric Anholt wrote: Anuj Phogat anuj.pho...@gmail.com writes: On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt e...@anholt.net wrote: Noticed by tex3d-maxsize on my next commit to check that our

Re: [Mesa-dev] [PATCH] glsl: rename min(), max() functions to fix MSVC build

2014-01-06 Thread Kenneth Graunke
On 01/06/2014 03:12 PM, Brian Paul wrote: Evidently, there's some other definition of min and max that causes MSVC to choke on these function names. Renaming to min2() and max2() fixes things. That's really strange...but I'm fine with renaming them. Sorry for the trouble. Reviewed-by:

[Mesa-dev] [Bug 73337] ir_builder.h(187) : error C2226: syntax error : unexpected type 'ir_builder::operand'

2014-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73337 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 4/4] radeon: Determine the bo priority (MSAA, depth, UVD are high)

2014-01-06 Thread Marek Olšák
On Mon, Jan 6, 2014 at 12:18 PM, Lauri Kasanen c...@gmx.com wrote: Signed-off-by: Lauri Kasanen c...@gmx.com --- src/gallium/drivers/radeon/r600_buffer_common.c | 8 src/gallium/drivers/radeon/radeon_uvd.c | 4 ++-- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 4

Re: [Mesa-dev] [PATCH] glsl: rename min(), max() functions to fix MSVC build

2014-01-06 Thread Erik Faye-Lund
On Tue, Jan 7, 2014 at 12:12 AM, Brian Paul bri...@vmware.com wrote: Evidently, there's some other definition of min and max that causes MSVC to choke on these function names. Renaming to min2() and max2() fixes things. Wouldn't it be easier to just make sure NOMINMAX is defined before

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-06 Thread Marek Olšák
On Mon, Jan 6, 2014 at 12:17 PM, Lauri Kasanen c...@gmx.com wrote: These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears). I recommend testing torcs (the Forza track) next time. glxgears is not useful here. Signed-off-by: Lauri Kasanen c...@gmx.com

Re: [Mesa-dev] [PATCH 5/6][RFC] Gallium/dri2: implement blitImage

2014-01-06 Thread Michel Dänzer
On Mon, 2014-01-06 at 12:50 +0100, Marek Olšák wrote: Fences might not be implemented by some drivers. I recommend setting the fence pointer to NULL, then calling flush and then checking if it's not NULL. That's not necessary, Gallium drivers have to implement the fence interfaces. --

[Mesa-dev] FOSDEM14: Graphics DevRoom: Deadline approaching fast.

2014-01-06 Thread Luc Verhaegen
Hi, There are still 5 slots open for the FOSDEM graphics DevRoom, and the deadline is this friday, the 10th. Get a move on. If you have requested an account reset with me before, but if you then haven't bothered filing a talk, you do NOT have a slot. Please file a talk ASAP to still secure a

Re: [Mesa-dev] [PATCH 1/7] mesa: implement glBindBuffersBase() and gl BindBuffersRange()

2014-01-06 Thread Fredrik Höglund
Maxence, while I think it's great that you're interested in working on this extension, I'm afraid I have another implementation in a branch in my mesa tree: http://cgit.freedesktop.org/~fredrik/mesa/log/?h=arb-multi-bind I've looked at your patches, and noticed you've implemented the functions