[Mesa-dev] exec_list question

2014-01-12 Thread Timothy Arceri
Hi Guys, I've been chasing my tail most of the afternoon using exec_list basically I was just trying to copy all but the first element from one list to another using the code bellow. exec_list *copy_dims = type-array_specifier-array_dimensions; int i = 0;

Re: [Mesa-dev] exec_list question

2014-01-12 Thread Timothy Arceri
I just tried the below code which is much cleaner but it to causes the original list to lose the last node. exec_node *node = type-array_specifier-array_dimensions.head-next; for (/* nothing */; !node-is_tail_sentinel(); node = node-next) { array_specifier-array_dimensions.push_tail(node); }

Re: [Mesa-dev] exec_list question

2014-01-12 Thread Timothy Arceri
Ok please ignore I understand how exec_list works now. What I was trying to do was silly I'll need to figure out a different solution sorry about the noise. On Sun, 2014-01-12 at 19:39 +1100, Timothy Arceri wrote: I just tried the below code which is much cleaner but it to causes the original

[Mesa-dev] [PATCH] nv50, nvc0: initialize ctx-sample_mask to ~0

2014-01-12 Thread Ilia Mirkin
Commit 95bf222603b (cso_context: Fix cso_context::sample_mask initial value.) fixed the cso sample mask to be initialized to ~0. The cso code is also careful not to needlessly call set_sample_mask, so we ended up with the ctx-sample_mask never being set. This broke a number of

[Mesa-dev] [PATCH] Mark debug_print with __attribute__ ((format(__printf__, 1, 0)))

2014-01-12 Thread Keith Packard
the drmServerInfo member, debug_print, takes a printf format string and varargs list. Tell the compiler about it. Signed-off-by: Keith Packard kei...@keithp.com --- xf86drm.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xf86drm.h b/xf86drm.h index 1e763a3..5e170f8

Re: [Mesa-dev] exec_list question

2014-01-12 Thread Ian Romanick
I think you should use move_nodes_to to move all the nodes from one to the other, pop_head to remove the head, then push_head to put it back on the original list. There's probably a more clever way, but it may not be worth the effort to figure it out. On 01/12/2014 12:08 AM, Timothy Arceri

[Mesa-dev] [PATCH] mesa: use signed temporary variable to store _ColorDrawBufferIndexes

2014-01-12 Thread Emil Velikov
_ColorDrawBufferIndexes is defined as GLint* and using a GLuint* will result in the first part of the conditional to be evaluated to true always. Unintentionally introduced by the following commit, this will result in a driver segfault if one is using an old version of the piglit test

Re: [Mesa-dev] [PATCH] mesa: use signed temporary variable to store _ColorDrawBufferIndexes

2014-01-12 Thread Emil Velikov
On 12/01/14 22:52, Emil Velikov wrote: _ColorDrawBufferIndexes is defined as GLint* and using a GLuint* will result in the first part of the conditional to be evaluated to true always. Unintentionally introduced by the following commit, this will result in a driver segfault if one is using

[Mesa-dev] [PATCH 01/10] loader: introduce the loader util lib

2014-01-12 Thread Emil Velikov
All the various window system integration layers duplicate roughly the same code for figuring out device and driver name, pci-id's, etc. Which is sad. So extract it out into a loader util lib. Signed-off-by: Rob Clark robcl...@freedesktop.org v2 (Emil) * Separate the introduction of libloader

[Mesa-dev] [PATCH 04/10] egl-static: use loader util lib

2014-01-12 Thread Emil Velikov
v2 * Drop the no longer used _EGL_NO_DRM from Android.mk. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/main/Android.mk| 1 + src/gallium/targets/egl-static/Android.mk | 6 +- src/gallium/targets/egl-static/Makefile.am | 1 +

Re: [Mesa-dev] code de-duplication and non-pci support v2

2014-01-12 Thread Emil Velikov
On 11/01/14 16:54, Emil Velikov wrote: This is an updated series of Rob's patches * The introduction of the util library is separated from the de-duplication. * Each commit targets individual part of mesa and it should build/work regardless of build system/options. * Handles a couple more

[Mesa-dev] [PATCH] automake: include the git sha in the opengl version string for oot builds

2014-01-12 Thread Emil Velikov
Because it's a great feature and we should not penalise people for doing out-of-tree builds. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/Makefile.am | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am

Re: [Mesa-dev] [PATCH] automake: include the git sha in the opengl version string for oot builds

2014-01-12 Thread Matt Turner
On Sun, Jan 12, 2014 at 6:02 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Because it's a great feature and we should not penalise people for doing out-of-tree builds. I don't think the commit message adds anything. With that removed, Reviewed-by: Matt Turner matts...@gmail.com