Re: [Mesa-dev] [PATCH 2/3] nv50: add more RGB10A2 formats

2014-01-16 Thread Ilia Mirkin
On Wed, Jan 15, 2014 at 6:37 AM, Ilia Mirkin wrote: > On Wed, Dec 25, 2013 at 11:53 AM, Christoph Bumiller > wrote: >> --- >> src/gallium/drivers/nouveau/nv50/nv50_formats.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_formats.c >> b/s

[Mesa-dev] [V3 PATCH 0/8] mesa: Naming MESA_FORMATs to a specification

2014-01-16 Thread Mark Mueller
This series introduces a specification for 3 types of MESA_FORMAT names - Type A (array formats), Type C (compressed formats), and Type P (packed formats), and then performs a series of substitutions grouped by type. Builds of all default gallium and DRI drivers were verified and no regressions wer

[Mesa-dev] [V3 PATCH 7/8] mesa: Remove/update related comments and rename MESA_FORMAT_XBGR A Type MESA_FORMATs to match naming spec as follows: s/\bMESA_FORMAT_XBGR8888_SNORM\b/MESA_FORMAT_RGBX_SNORM8

2014-01-16 Thread Mark Mueller
Signed-off-by: Mark Mueller --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 24 +++--- src/mesa/main/format_pack.c | 60 +++--- src/mesa/main/format_unpack.c | 36 - src/mesa/main/formats.c | 100 --

[Mesa-dev] [PATCH] st/vdpau: check that the format/bindings are valid

2014-01-16 Thread Ilia Mirkin
It's a bit unreasonable to rely on applications doing the queries and then obeying their results. Signed-off-by: Ilia Mirkin --- We're starting to see people complaining about flash with newer versions of nouveau on nv30 cards. These cards don't actually expose any hw caps via vdpau, but the API

[Mesa-dev] [PATCH 1/3] svga: fix clearing for null color buffers

2014-01-16 Thread Brian Paul
Fixes piglit "fbo-drawbuffers-none glClear" test. --- src/gallium/drivers/svga/svga_pipe_clear.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_clear.c b/src/gallium/drivers/svga/svga_pipe_clear.c index 5deebb2..21869e9 100644 --- a/sr

[Mesa-dev] [PATCH 3/3] svga: implement TGSI_PROPERTY_FS_COLOR0_WRITES_ALL_CBUFS

2014-01-16 Thread Brian Paul
Fixes several colorbuffer tests, including piglit "fbo-drawbuffers-none" for "gl_FragColor" and "glDrawPixels" cases. --- src/gallium/drivers/svga/svga_state_fs.c | 7 + src/gallium/drivers/svga/svga_tgsi.h | 2 ++ src/gallium/drivers/svga/svga_tgsi_decl_sm30.c | 37 +

[Mesa-dev] [PATCH 2/3] svga: rename color output variables

2014-01-16 Thread Brian Paul
Just to be bit more readable. --- src/gallium/drivers/svga/svga_tgsi_decl_sm30.c | 6 +++--- src/gallium/drivers/svga/svga_tgsi_emit.h | 5 +++-- src/gallium/drivers/svga/svga_tgsi_insn.c | 8 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/sv

[Mesa-dev] [PATCH] nv50, nvc0: only clear out the buffers that we were asked to clear

2014-01-16 Thread Ilia Mirkin
Fixes fbo-drawbuffers-none glClearBuffer piglit test. Signed-off-by: Ilia Mirkin --- Only tested on nv50, but implementations seem similar enough. src/gallium/drivers/nouveau/nv50/nv50_surface.c | 17 + src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 17 + 2 f

[Mesa-dev] [PATCH v2] nv50, nvc0: clear out RT on a null cbuf

2014-01-16 Thread Ilia Mirkin
This is needed since commit 9baa45f78b (st/mesa: bind NULL colorbuffers as specified by glDrawBuffers). This implementation is highly based on a larger commit by Christoph Bumiller in his gallium-nine branch. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_defs.xml.h |

[Mesa-dev] [Bug 73714] New account for Ilia Mirkin

2014-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73714 Ben Skeggs changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes

Re: [Mesa-dev] [PATCH v2 RFC 1/1] clover: Don't crash on NULL global buffer objects.

2014-01-16 Thread Jan Vesely
On Wed, 2014-01-15 at 18:41 +0100, Francisco Jerez wrote: > Jan Vesely writes: > > > Specs say "If the argument is a buffer object, the arg_value > > pointer can be NULL or point to a NULL value in which case a NULL > > value will be used as the value for the argument declared as a > > pointer to

[Mesa-dev] [PATCH v3 1/1] clover: Don't crash on NULL global buffer objects.

2014-01-16 Thread Jan Vesely
Specs say "If the argument is a buffer object, the arg_value pointer can be NULL or point to a NULL value in which case a NULL value will be used as the value for the argument declared as a pointer to __global or __constant memory in the kernel." So don't crash when somebody does that. v2: Insert

[Mesa-dev] [PATCH] llvmpipe: fix large point rasterization with point_quad_rasterization

2014-01-16 Thread sroland
From: Roland Scheidegger The whole round-pointsize-to-int stuff must only be done with GL legacy rules (no point_quad_rasterization) or all the wrong edges are lit up. This was previously in a private branch (d3d pointsprite test complains loudly otherwise) and got lost in a merge. However, it sh

Re: [Mesa-dev] [PATCH 6/9] glsl: Implement ARB_arrays_of_arrays support for constructors

2014-01-16 Thread Matt Turner
On Wed, Jan 15, 2014 at 10:27 PM, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast_function.cpp | 54 > --- > 1 file changed, 46 insertions(+), 8 deletions(-) > > diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function

Re: [Mesa-dev] [PATCH 4/9] glsl: Add array specifier to ast code

2014-01-16 Thread Matt Turner
On Wed, Jan 15, 2014 at 10:27 PM, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast.h | 45 +++ > src/glsl/ast_array_index.cpp| 13 +++ > src/glsl/ast_to_hir.cpp | 173 > +++- > src/glsl/ast_type

Re: [Mesa-dev] [PATCH 2/9] glsl: add dimension_count to glsl_types

2014-01-16 Thread Matt Turner
On Wed, Jan 15, 2014 at 10:27 PM, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/glsl_types.cpp | 15 +++ > src/glsl/glsl_types.h | 17 - > 2 files changed, 27 insertions(+), 5 deletions(-) > > diff --git a/src/glsl/glsl_types.cpp b/src/glsl/

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] mesa: fix GL_COLOR_SUM enum for drivers without ARB_vertex_program

2014-01-16 Thread Ian Romanick
On 01/16/2014 10:42 AM, Ilia Mirkin wrote: > On Thu, Jan 16, 2014 at 1:38 PM, Ilia Mirkin wrote: >> On Thu, Jan 16, 2014 at 1:34 PM, Ian Romanick wrote: >>> On 01/16/2014 10:13 AM, Ilia Mirkin wrote: Commit c13970808 (mesa: GL_EXT_secondary_color is not optional) changed CHECK_EXTE

Re: [Mesa-dev] [PATCH 1/9] Mesa: Add ARB_arrays_of_arrays

2014-01-16 Thread Matt Turner
> Mesa: Add ARB_arrays_of_arrays Nit picky, but "mesa" like the rest of the commit messages already in git? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 03/10] gbm: use the loader util lib

2014-01-16 Thread Emil Velikov
On 16/01/14 23:45, Emil Velikov wrote: >> > They were exported so that external gbm modules could call them. >> > Today we compile the gbm dri backend into libgbm, so it's not an >> > issue. Nothing outside mesa should use it. >> > > If that's the case I think you won't mind if I follow up with a

Re: [Mesa-dev] code de-duplication and non-pci support v2

2014-01-16 Thread Emil Velikov
On 16/01/14 23:29, Kristian Høgsberg wrote: > On Sat, Jan 11, 2014 at 04:51:42PM -0500, Rob Clark wrote: >> On Sat, Jan 11, 2014 at 11:54 AM, Emil Velikov >> wrote: >>> This is an updated series of Rob's patches >>> >>> * The introduction of the util library is separated from the >>> de-duplicati

Re: [Mesa-dev] [PATCH 03/10] gbm: use the loader util lib

2014-01-16 Thread Emil Velikov
On 16/01/14 23:03, Kristian Høgsberg wrote: > On Sat, Jan 11, 2014 at 04:54:44PM +, Emil Velikov wrote: >> Additionally this commit removes the following exported functions >> >>_gbm_udev_device_new_from_fd() >>_gbm_fd_get_device_name() >>_gbm_log() >> >> All three were erroneously

Re: [Mesa-dev] code de-duplication and non-pci support v2

2014-01-16 Thread Kristian Høgsberg
On Sat, Jan 11, 2014 at 04:51:42PM -0500, Rob Clark wrote: > On Sat, Jan 11, 2014 at 11:54 AM, Emil Velikov > wrote: > > This is an updated series of Rob's patches > > > > * The introduction of the util library is separated from the > > de-duplication. > > * Each commit targets individual part of

Re: [Mesa-dev] [PATCH 03/10] gbm: use the loader util lib

2014-01-16 Thread Kristian Høgsberg
On Sat, Jan 11, 2014 at 04:54:44PM +, Emil Velikov wrote: > Additionally this commit removes the following exported functions > >_gbm_udev_device_new_from_fd() >_gbm_fd_get_device_name() >_gbm_log() > > All three were erroneously marked as exported since their inception. > Neither

Re: [Mesa-dev] [PATCH 02/10] glx: use the loader util lib

2014-01-16 Thread Kristian Høgsberg
On Sat, Jan 11, 2014 at 04:54:43PM +, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/glx/Makefile.am | 5 +- > src/glx/SConscript| 2 +- > src/glx/dri3_common.c | 146 > -- > src/glx/dri3_glx.c| 3 +- > src/glx/dr

Re: [Mesa-dev] [PATCH 01/10] loader: introduce the loader util lib

2014-01-16 Thread Kristian Høgsberg
On Mon, Jan 13, 2014 at 12:01:03AM +, Emil Velikov wrote: > All the various window system integration layers duplicate roughly the > same code for figuring out device and driver name, pci-id's, etc. Which > is sad. So extract it out into a loader util lib. > > Signed-off-by: Rob Clark > >

[Mesa-dev] [PATCH 1/2] svga: replace an assertion with warning

2014-01-16 Thread Brian Paul
We trip on this in some environments but it's not a fatal error. Signed-off-by: Brian Paul --- src/gallium/drivers/svga/svga_resource_texture.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_resource_texture.c b/src/gallium/drivers/svga/svg

[Mesa-dev] [PATCH 2/2] svga: fix crash when clearing null color buffer

2014-01-16 Thread Brian Paul
Fixes regression since 9baa45f78b8ca7d66280e36009b6a685055d7cd6 but some of the piglit fbo-drawbuffers-none tests still don't pass. --- src/gallium/drivers/svga/svga_pipe_clear.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_clear

Re: [Mesa-dev] [PATCHv2] i965: Avoid extraneous fast depth clears

2014-01-16 Thread Chad Versace
On Fri, Jan 03, 2014 at 02:28:45PM +0800, Chia-I Wu wrote: > When the depth buffer is already cleared, skip GEN6_HIZ_OP_DEPTH_CLEAR. This > is made possible by tracking which slices have been cleared in > "struct intel_mipmap_level". The hiz_cleared flag is unset when the depth > buffer is render

Re: [Mesa-dev] mesa-dev Digest, Vol 46, Issue 190

2014-01-16 Thread Maxence Le Doré
Those of Fredrik of course, since his implementation is better, I no more work on multi bind. 2014/1/16 : > Send mesa-dev mailing list submissions to > mesa-dev@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.freedesktop.org/mailm

[Mesa-dev] [Bug 73714] New account for Ilia Mirkin

2014-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73714 Ilia Mirkin changed: What|Removed |Added Assignee|sitewranglers@lists.freedes |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] glsl: Assert buildin uniform variables

2014-01-16 Thread Matt Turner
On Thu, Jan 16, 2014 at 12:37 PM, Juha-Pekka Heikkilä wrote: > On Thu, Jan 16, 2014 at 8:48 PM, Matt Turner wrote: >> On Thu, Jan 16, 2014 at 2:59 AM, Juha-Pekka Heikkila >> wrote: >>> Signed-off-by: Juha-Pekka Heikkila >>> --- >>> src/glsl/builtin_variables.cpp | 24 >

Re: [Mesa-dev] [PATCH] glsl: Assert buildin uniform variables

2014-01-16 Thread Juha-Pekka Heikkilä
On Thu, Jan 16, 2014 at 8:48 PM, Matt Turner wrote: > On Thu, Jan 16, 2014 at 2:59 AM, Juha-Pekka Heikkila > wrote: >> Signed-off-by: Juha-Pekka Heikkila >> --- >> src/glsl/builtin_variables.cpp | 24 >> 1 file changed, 20 insertions(+), 4 deletions(-) >> >> diff --git

Re: [Mesa-dev] [PATCH 1/3] docs: Update GL3.txt due to recent work

2014-01-16 Thread Matt Turner
On Thu, Jan 16, 2014 at 10:44 AM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > docs/GL3.txt | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 0672ec7..be78652 100644 > --- a/docs/GL

Re: [Mesa-dev] [PATCH 00/10] nv50: out-of-bounds access of context specific attribs

2014-01-16 Thread Ilia Mirkin
On Thu, Jan 16, 2014 at 1:44 PM, Emil Velikov wrote: > Subject: [PATCH 00/10] nv50: out-of-bounds access of context specific attribs > In-Reply-To: > > So here it goes, a few serious patches and some not as much > > Patches 1, 2 correct the range to be within the defined boundaries > when invalida

Re: [Mesa-dev] [PATCH 05/10] nv50: assert before trying to out-of-bounds access vtxbuf

2014-01-16 Thread Ilia Mirkin
On Thu, Jan 16, 2014 at 1:44 PM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/gallium/drivers/nouveau/nv50/nv50_context.c | 2 ++ > src/gallium/drivers/nouveau/nv50/nv50_push.c| 1 + > src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 12 +++- > 3 files changed, 14

[Mesa-dev] [PATCH 05/10] nv50: assert before trying to out-of-bounds access vtxbuf

2014-01-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_push.c| 1 + src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 12 +++- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/no

Re: [Mesa-dev] [PATCH] glsl: Assert buildin uniform variables

2014-01-16 Thread Matt Turner
On Thu, Jan 16, 2014 at 2:59 AM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/builtin_variables.cpp | 24 > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.c

[Mesa-dev] [PATCH 08/10] nv50: assert before trying to out-of-bounds access samplers

2014-01-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_state.c | 3 +++ src/gallium/drivers/nouveau/nv50/nv50_tex.c | 1 + 2 files changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_state.c b/src/gallium/drivers/nouveau/nv50/nv50_state.c index b07856c..

[Mesa-dev] [PATCH 1/3] docs: Update GL3.txt due to recent work

2014-01-16 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- docs/GL3.txt | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 0672ec7..be78652 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -55,7 +55,7 @@ GL 3.1 --- all DONE: i965, nv5

[Mesa-dev] [PATCH 2/3] mesa: Fix extension dependency for half-float TexBOs

2014-01-16 Thread Ian Romanick
From: Ian Romanick Half-float TexBOs should require both GL_ARB_half_float_pixel and GL_ARB_texture_float. This doesn't matter much in practice. Every driver that supports GL_ARB_texture_buffer_object already supports GL_ARB_half_float_pixel. We only expose the TexBO extension in core profiles

[Mesa-dev] [PATCH 3/3] mesa: GL_ARB_half_float_pixel is not optional

2014-01-16 Thread Ian Romanick
From: Ian Romanick Almost every driver already supported it. All current and future Gallium drivers always support it, and most existing classic drivers support it. This only changes radeon and nouveau. This extension only adds data types that can be passed to, for example, glTexImage2D. It d

[Mesa-dev] [PATCH 00/10] nv50: out-of-bounds access of context specific attribs

2014-01-16 Thread Emil Velikov
Subject: [PATCH 00/10] nv50: out-of-bounds access of context specific attribs In-Reply-To: So here it goes, a few serious patches and some not as much Patches 1, 2 correct the range to be within the defined boundaries when invalidating the textures/constbufs. Most likely a copy/paste typo from th

[Mesa-dev] [PATCH 10/10] nv50: drop obsolete check from error path

2014-01-16 Thread Emil Velikov
At 'out_err' the nv50_context has been calloc-ated. Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_context.c b/src/gallium/drivers/nouveau/

[Mesa-dev] [PATCH 06/10] nv50: pass vtxbuf index as unsigned

2014-01-16 Thread Emil Velikov
The index passed to the function is already unsigned, and internally we threat it as unsigned. Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_vbo.c b/src/galliu

[Mesa-dev] [PATCH 02/10] nv50: access only the available amount of constbuf

2014-01-16 Thread Emil Velikov
The textures array is defined as a number of NV50_MAX_PIPE_CONSTBUFS per shader stage. Currently the nv50 driver handles only 3 shader stages, thus we wreck chaos when accessing array-out-of-bounds. Cc: 9.1 9.2 10.0 Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_context.c

[Mesa-dev] [PATCH 03/10] nv50: assert before trying to out-of-bounds access constbuf

2014-01-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 1 + src/gallium/drivers/nouveau/nv50/nv50_shader_state.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_state.c| 1 + 3 files changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50

[Mesa-dev] [PATCH 01/10] nv50: access only the available amount of textures

2014-01-16 Thread Emil Velikov
The textures array is defined as a number of PIPE_MAX_SAMPLERS per shader stage. Currently nv50 driver handles only 3 shader stages, thus we wreck chaos when accessing array-out-of-bounds. Fixes a segfault in piglit/bin/arb_texture_buffer_object-data-sync -fbo -auto Cc: 9.1 9.2 10.0 Signed-off-b

[Mesa-dev] [PATCH 09/10] nv50: assert before trying to out-of-bounds access framebuffer.cbufs

2014-01-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_context.c b/src/gallium/drivers/nouveau/nv50/nv50_context.c index 8183b01..24264d5 100644 --- a/src/gallium/drivers/nouveau/nv

[Mesa-dev] [PATCH 07/10] nv50: assert before trying to out-of-bounds access textures

2014-01-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_state.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_tex.c | 1 + 3 files changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_context.c b/

[Mesa-dev] [PATCH 04/10] nv50: typecast the result of ffs() to unsigned

2014-01-16 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nv50/nv50_shader_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_shader_state.c b/src/gallium/drivers/nouveau/nv50/nv50_shader_state.c index c44d208..c9d80ea 100644 --- a

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] mesa: fix GL_COLOR_SUM enum for drivers without ARB_vertex_program

2014-01-16 Thread Ilia Mirkin
On Thu, Jan 16, 2014 at 1:38 PM, Ilia Mirkin wrote: > On Thu, Jan 16, 2014 at 1:34 PM, Ian Romanick wrote: >> On 01/16/2014 10:13 AM, Ilia Mirkin wrote: >>> Commit c13970808 (mesa: GL_EXT_secondary_color is not optional) changed >>> >>> CHECK_EXTENSION2(EXT_secondary_color, ARB_vetex_program, cap

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] mesa: fix GL_COLOR_SUM enum for drivers without ARB_vertex_program

2014-01-16 Thread Ilia Mirkin
On Thu, Jan 16, 2014 at 1:34 PM, Ian Romanick wrote: > On 01/16/2014 10:13 AM, Ilia Mirkin wrote: >> Commit c13970808 (mesa: GL_EXT_secondary_color is not optional) changed >> >> CHECK_EXTENSION2(EXT_secondary_color, ARB_vetex_program, cap) >> >> to >> >> CHECK_EXTENSION(ARB_vertex_program, cap) >

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] mesa: fix GL_COLOR_SUM enum for drivers without ARB_vertex_program

2014-01-16 Thread Ian Romanick
On 01/16/2014 10:13 AM, Ilia Mirkin wrote: > Commit c13970808 (mesa: GL_EXT_secondary_color is not optional) changed > > CHECK_EXTENSION2(EXT_secondary_color, ARB_vetex_program, cap) > > to > > CHECK_EXTENSION(ARB_vertex_program, cap) > > However CHECK_EXTENSION2 checks that either extension is

Re: [Mesa-dev] [Mesa PATCH 2/3] i965: Use the new drm_intel_bo offset64 field.

2014-01-16 Thread Ian Romanick
On 01/13/2014 03:56 PM, Kenneth Graunke wrote: > libdrm 2.4.52 introduces a new 'uint64_t offset64' field, intended to > replace the old 'unsigned long offset' field. To preserve ABI, libdrm > continues to store the presumed offset in both locations. > > On Broadwell, a 64-bit kernel may place BO

[Mesa-dev] [PATCH v2] mesa: fix GL_COLOR_SUM enum for drivers without ARB_vertex_program

2014-01-16 Thread Ilia Mirkin
Commit c13970808 (mesa: GL_EXT_secondary_color is not optional) changed CHECK_EXTENSION2(EXT_secondary_color, ARB_vetex_program, cap) to CHECK_EXTENSION(ARB_vertex_program, cap) However CHECK_EXTENSION2 checks that either extension is available, not both. Remove the extension check entirely sin

Re: [Mesa-dev] [PATCH] llvmpipe: handle NULL color buffer pointers

2014-01-16 Thread Roland Scheidegger
Am 16.01.2014 17:20, schrieb Brian Paul: > Fixes regression from 9baa45f78b8ca7d66280e36009b6a685055d7cd6 > > v2: incorporate a few small changes suggested by Roland. > --- > src/gallium/drivers/llvmpipe/lp_rast.c | 62 --- > src/gallium/drivers/llvmpipe/lp_rast_priv.h | 11 +- >

Re: [Mesa-dev] [PATCH] mesa: fix GL_COLOR_SUM enum for drivers without ARB_vertex_program

2014-01-16 Thread Ian Romanick
You're right. I really botched that. :( The changes in enable.c look correct, but get_hash_params.py needs the same treatment. On 01/10/2014 11:57 AM, Ilia Mirkin wrote: > Commit c13970808 (mesa: GL_EXT_secondary_color is not optional) changed > > CHECK_EXTENSION2(EXT_secondary_color, ARB_vetex_

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: handle NULL color buffer pointers

2014-01-16 Thread Roland Scheidegger
Am 16.01.2014 17:19, schrieb Brian Paul: > On 01/15/2014 07:11 PM, Roland Scheidegger wrote: >> Looks good overall, just some minor quibbles inline. >> >> Roland >> >> Am 16.01.2014 03:15, schrieb Brian Paul: >>> Fixes regression from 9baa45f78b8ca7d66280e36009b6a685055d7cd6 >>> --- >>> src/galli

Re: [Mesa-dev] [PATCH] llvmpipe: fix possible constant buffer overflow

2014-01-16 Thread Roland Scheidegger
Am 16.01.2014 03:09, schrieb Zack Rusin: > It's possible to bind a smaller buffer as a constant buffer, than > what the shader actually uses/requires. This could cause nasty > crashes. This patch adds the architecture to pass the maximum > allowable constant buffer index to the jit to let it make >

[Mesa-dev] [Bug 69285] Enabling LLVM results in substantially different rendering

2014-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69285 Charles Huber changed: What|Removed |Added Version|9.2 |git --- Comment #5 from Charles Huber -

Re: [Mesa-dev] [Mesa PATCH 2/3] i965: Use the new drm_intel_bo offset64 field.

2014-01-16 Thread Eric Anholt
Kenneth Graunke writes: > On 01/15/2014 12:47 PM, Eric Anholt wrote: >> Kenneth Graunke writes: >> >>> libdrm 2.4.52 introduces a new 'uint64_t offset64' field, intended to >>> replace the old 'unsigned long offset' field. To preserve ABI, libdrm >>> continues to store the presumed offset in b

[Mesa-dev] [Bug 69285] Enabling LLVM results in substantially different rendering

2014-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69285 --- Comment #4 from Charles Huber --- Still broken in 10.0.2 with LLVM 3.4. Slightly different configure required for 3.4: ./configure \ --disable-assertions \ --enable-terminfo=no \ --enable-curses=no \ -- You are receiving this mail because

Re: [Mesa-dev] [PATCH] llvmpipe: fix possible constant buffer overflow

2014-01-16 Thread Brian Paul
On 01/15/2014 06:09 PM, Zack Rusin wrote: It's possible to bind a smaller buffer as a constant buffer, than what the shader actually uses/requires. This could cause nasty crashes. This patch adds the architecture to pass the maximum allowable constant buffer index to the jit to let it make sure t

Re: [Mesa-dev] [PATCH] llvmpipe: handle NULL color buffer pointers

2014-01-16 Thread Jose Fonseca
Looks good AFAICT. Thanks Brian. Jose - Original Message - > Fixes regression from 9baa45f78b8ca7d66280e36009b6a685055d7cd6 > > v2: incorporate a few small changes suggested by Roland. > --- > src/gallium/drivers/llvmpipe/lp_rast.c | 62 --- > src/gallium/drivers/llvmpipe

[Mesa-dev] [PATCH] llvmpipe: handle NULL color buffer pointers

2014-01-16 Thread Brian Paul
Fixes regression from 9baa45f78b8ca7d66280e36009b6a685055d7cd6 v2: incorporate a few small changes suggested by Roland. --- src/gallium/drivers/llvmpipe/lp_rast.c | 62 --- src/gallium/drivers/llvmpipe/lp_rast_priv.h | 11 +- src/gallium/drivers/llvmpipe/lp_scene.c | 23 ++-

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: handle NULL color buffer pointers

2014-01-16 Thread Brian Paul
On 01/15/2014 07:11 PM, Roland Scheidegger wrote: Looks good overall, just some minor quibbles inline. Roland Am 16.01.2014 03:15, schrieb Brian Paul: Fixes regression from 9baa45f78b8ca7d66280e36009b6a685055d7cd6 --- src/gallium/drivers/llvmpipe/lp_rast.c | 44 +--- src/gallium/

[Mesa-dev] [PATCH] glx: Add missing null check in glXCreateContextAttribsARB

2014-01-16 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/create_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/create_context.c b/src/glx/create_context.c index 38e949a..de54117 100644 --- a/src/glx/create_context.c +++ b/src/glx/create_context.c @@ -88,6 +88,9 @@ glXCreateContext

[Mesa-dev] [PATCH] v2 of glx: Add missing null check in glXCreateContextAttribsARB

2014-01-16 Thread Juha-Pekka Heikkila
Thanks Brian for the comment, you are right now the null check makes more sense. Juha-Pekka Heikkila (1): glx: Add missing null check in glXCreateContextAttribsARB src/glx/create_context.c | 3 +++ 1 file changed, 3 insertions(+) -- 1.8.1.2 ___ me

Re: [Mesa-dev] [wip 9/9] mesa: OES_get_program_binary extension functionality

2014-01-16 Thread Tapani Pälli
On 01/15/2014 06:13 PM, Paul Berry wrote: On 2 January 2014 03:58, Tapani Pälli > wrote: Signed-off-by: Tapani Pälli mailto:tapani.pa...@intel.com>> --- src/mesa/main/shaderapi.c | 44 ++-- 1 file changed

Re: [Mesa-dev] [RFC] freedreno: add tgsi lowering pass

2014-01-16 Thread Rob Clark
On Thu, Jan 16, 2014 at 4:51 AM, Marek Olšák wrote: > On Thu, Jan 16, 2014 at 6:41 AM, Matt Turner wrote: >> On Wed, Jan 15, 2014 at 5:40 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> So, as I found myself needing to lower a few more TGSI instructions, >>> and noticing yet again that I would

[Mesa-dev] [PATCH] glsl: Assert buildin uniform variables

2014-01-16 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/builtin_variables.cpp | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index f630923..9f4f7c7 100644 --- a/src/glsl/builtin_variables.cpp ++

Re: [Mesa-dev] [RFC] freedreno: add tgsi lowering pass

2014-01-16 Thread Marek Olšák
On Thu, Jan 16, 2014 at 6:41 AM, Matt Turner wrote: > On Wed, Jan 15, 2014 at 5:40 AM, Rob Clark wrote: >> From: Rob Clark >> >> So, as I found myself needing to lower a few more TGSI instructions, >> and noticing yet again that I would have to do the same lowering as >> various other gallium dr

[Mesa-dev] [PATCH V2 7/9] glsl: Aggregate initializer support for arrays of array

2014-01-16 Thread Timothy Arceri
V2 dont create a second process_array_type function Signed-off-by: Timothy Arceri --- src/glsl/ast.h | 19 +++- src/glsl/ast_function.cpp | 14 +++-- src/glsl/ast_to_hir.cpp | 29 - src/glsl/glsl_parser.yy | 36 ++

Re: [Mesa-dev] gallium endianness and hw drivers

2014-01-16 Thread Marek Olšák
On Thu, Jan 16, 2014 at 8:43 AM, Michel Dänzer wrote: > On Mit, 2014-01-15 at 14:27 +0100, Marek Olšák wrote: >> On Wed, Jan 15, 2014 at 7:07 AM, Michel Dänzer wrote: >> > On Die, 2014-01-14 at 00:22 +0100, Marek Olšák wrote: >> >> I think the format conversion functions should look like: >> >> >