[Mesa-dev] [V4 PATCH 0/7] mesa: Naming MESA_FORMATs to a specification

2014-01-21 Thread Mark Mueller
This series introduces a specification for 3 types of MESA_FORMAT names - Type A (array formats), Type C (compressed formats), and Type P (packed formats), and then performs a series of substitutions grouped by type. Builds of all default gallium and DRI drivers were verified and no regressions wer

Re: [Mesa-dev] [PATCH 1/2] i965/blorp: patch jump counters also for endif

2014-01-21 Thread Pohjolainen, Topi
On Wed, Jan 22, 2014 at 06:57:28AM +0200, Pohjolainen, Topi wrote: > On Tue, Jan 21, 2014 at 12:48:12PM -0800, Eric Anholt wrote: > > Topi Pohjolainen writes: > > > > > No known bugs fixed but this is now in line with fs-generator. > > > No regresssions on IVB. > > > > The endif jump, since it's

Re: [Mesa-dev] [PATCH 1/2] i965/blorp: patch jump counters also for endif

2014-01-21 Thread Pohjolainen, Topi
On Tue, Jan 21, 2014 at 12:48:12PM -0800, Eric Anholt wrote: > Topi Pohjolainen writes: > > > No known bugs fixed but this is now in line with fs-generator. > > No regresssions on IVB. > > The endif jump, since it's forward, is just an optimization to have set > right -- otherwise, the GPU will

Re: [Mesa-dev] [PATCH 13/23] i965/fs: Take into account reg_offset consistently for MRF regs.

2014-01-21 Thread Paul Berry
On 15 January 2014 14:01, Francisco Jerez wrote: > Paul Berry writes: > > > On 2 December 2013 11:31, Francisco Jerez wrote: > > > >> Until now it was only being taken into account in the VEC4 back-end > >> but not in the FS back-end. Do it in both cases. > >> --- > >> src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH 10/23] i965/fs: Remove fs_reg::sechalf.

2014-01-21 Thread Paul Berry
On 21 January 2014 19:21, Paul Berry wrote: > > not realize that is is safe to call it on a register with 32 bits per > component, because they might erroneously think "oh, this function only > works on 16-component registers; that is, registers that > Oops, sorry about the extraneous sentence f

Re: [Mesa-dev] [PATCH 10/23] i965/fs: Remove fs_reg::sechalf.

2014-01-21 Thread Paul Berry
On 15 January 2014 13:53, Francisco Jerez wrote: > Paul Berry writes: > > > On 2 December 2013 11:31, Francisco Jerez wrote: > > > >> +/** > >> + * Get either of the 8-component halves of a 16-component register. > >> + */ > >> +static inline fs_reg > >> +half(const fs_reg ®, unsigned idx) > >>

Re: [Mesa-dev] [PATCH] glsl: Add image type to the GLSL IR.

2014-01-21 Thread Paul Berry
On 15 January 2014 11:42, Francisco Jerez wrote: > v2: Reuse the glsl_sampler_dim enum for images. Reuse the > glsl_type::sampler_* fields instead of creating new ones specific > to image types. Reuse the same constructor as for samplers adding > a new 'base_type' argument. > --- >

Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

2014-01-21 Thread Paul Berry
On 21 January 2014 14:54, Timothy Arceri wrote: > Hi Paul > > Thanks for the thorough review and taking the time to explain how to make > improvements. I can already see a number of improvements that can be made > to patch 5 based on the suggestions you have already made so you could hold > off r

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Don't set header_present if texel offsets are all 0.

2014-01-21 Thread Matt Turner
On Sat, Jan 18, 2014 at 8:20 PM, Kenneth Graunke wrote: > In theory, a shader might use textureOffset() but set all the texel > offsets to zero. In that case, we don't actually need to set up the > message header - zero is the implicit default. > > By moving the texture_offset setup before the he

Re: [Mesa-dev] [PATCH V2 8/8] docs: Mark ARB_arrays_of_arrays as started

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Paul Berry ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://li

Re: [Mesa-dev] [PATCH V2 7/8] glsl: create type name for arrays of arrays

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > We need to insert outermost dimensions in the correct spot otherwise > the dimension order will be backwards > > Signed-off-by: Timothy Arceri > --- > src/glsl/glsl_types.cpp | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-

[Mesa-dev] [PATCH] rtasm: deal with size overflows by casting to ptrdiff_t

2014-01-21 Thread Ilia Mirkin
This was discovered as a result of the draw-elements-base-vertex-neg piglit test, which passes very negative offsets in, followed up by large indices. The nouveau code correctly adjusts the pointer, but the transfer code needs to do the proper inverse correction. Similarly fix up the SSE code to do

[Mesa-dev] [Bug 57372] x11-libs/libxcb media-libs/mesa segfault in __glXGetString

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57372 Ian Romanick changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 57372] x11-libs/libxcb media-libs/mesa segfault in __glXGetString

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57372 --- Comment #13 from Richard Freeman --- (In reply to comment #12) > Does this problem still occur? I haven't seen this in a long time, but it is just as likely because the software that was generating the errors made some substantial QT/OpenGL

Re: [Mesa-dev] [PATCH V2 6/8] glsl: Allow arrays of arrays as input to vertex shader

2014-01-21 Thread Paul Berry
On 21 January 2014 18:23, Paul Berry wrote: > On 21 January 2014 04:19, Timothy Arceri wrote: > >> Signed-off-by: Timothy Arceri >> --- >> src/glsl/ast_to_hir.cpp | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp >> index 226d128.

Re: [Mesa-dev] [PATCH V2 6/8] glsl: Allow arrays of arrays as input to vertex shader

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast_to_hir.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index 226d128..62b7ec2 100644 > --- a/src/glsl/ast_to_hir.cpp > +++ b/

Re: [Mesa-dev] [PATCH V2 5/8] glsl: Aggregate initializer support for arrays of array

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast.h | 19 +++- > src/glsl/ast_function.cpp | 14 +++-- > src/glsl/ast_to_hir.cpp | 29 +- > src/glsl/glsl_parser.yy | 36

[Mesa-dev] [Bug 57372] x11-libs/libxcb media-libs/mesa segfault in __glXGetString

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57372 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #12 from Ian Romanic

Re: [Mesa-dev] [PATCH] mesa: Increment the list pointer while freeing instruction data

2014-01-21 Thread Ian Romanick
On 01/21/2014 06:47 PM, Brian Paul wrote: > On 01/21/2014 05:30 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Since the list pointer was never incremented when a OPCODE_PIXEL_MAP >> opcode was encountered, the data for the instruction would get freed >> over and over and over... resulting in

Re: [Mesa-dev] [PATCH] mesa: Increment the list pointer while freeing instruction data

2014-01-21 Thread Brian Paul
On 01/21/2014 05:30 PM, Ian Romanick wrote: From: Ian Romanick Since the list pointer was never incremented when a OPCODE_PIXEL_MAP opcode was encountered, the data for the instruction would get freed over and over and over... resulting in a crash. Fixes gl-1.0-beginend-coverage. Signed-off-b

[Mesa-dev] [Bug 24232] Error occurs during install of Google Earth

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=24232 Ian Romanick changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] mesa: Increment the list pointer while freeing instruction data

2014-01-21 Thread Ian Romanick
From: Ian Romanick Since the list pointer was never incremented when a OPCODE_PIXEL_MAP opcode was encountered, the data for the instruction would get freed over and over and over... resulting in a crash. Fixes gl-1.0-beginend-coverage. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freede

[Mesa-dev] [Bug 73672] Half Life 2 in Wine is broken since 4e549ddb

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73672 --- Comment #20 from Alexandre Demers --- (In reply to comment #19) > I sent the fix to mesa-dev. It's called "gallium/util: util_format_srgb > should not return FORMAT_NONE for sRGB formats". It was tested correctly on TF2 MSAA 2X, 4X, 6X, 8X

[Mesa-dev] [RFC PATCH] translate: deal with size overflows by casting to ptrdiff_t

2014-01-21 Thread Ilia Mirkin
This was discovered as a result of the draw-elements-base-vertex-neg piglit test, which passes very negative offsets in, followed up by large indices. The nouveau code correctly adjusts the pointer, but the translate code needs to do the proper inverse correction. Signed-off-by: Ilia Mirkin ---

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 Emil Velikov changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE

Re: [Mesa-dev] [PATCH 01/10] loader: introduce the loader util lib

2014-01-21 Thread Jordan Justen
On Sat, Jan 11, 2014 at 8:54 AM, Emil Velikov wrote: > All the various window system integration layers duplicate roughly the > same code for figuring out device and driver name, pci-id's, etc. Which > is sad. So extract it out into a loader util lib. > > Signed-off-by: Rob Clark > > v2 (Emil)

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #18 from Emil Velikov --- Created attachment 92554 --> https://bugs.freedesktop.org/attachment.cgi?id=92554&action=edit glx: link loader when building with dri3 While Keith's patch does work on the overall issue with libudev, we sh

[Mesa-dev] [PATCH] glx: link loader util lib only when building with dri3

2014-01-21 Thread Emil Velikov
Otherwise we pull libudev as a dependency and crash games/programs that ship their own version of libudev. Either way we should link the loader lib only when needed. This fixes a regression caused by commit eac776cf779b705cbfb8d41812f1d171fb09c76f Author: Emil Velikov Date: Sat Jan 11 02:24:43

[Mesa-dev] [Bug 71543] [mesa] Source-based games segfault

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71543 --- Comment #14 from Kenneth Graunke --- Keith had a patch to drop the udev dependency from dri3, it's just sitting on the list waiting for review. Would need rebasing at this point. Not sure if Kristian's patch would impact this. -- You are

Re: [Mesa-dev] [PATCH] glsl: Simplify aggregate type inference to prepare for ARB_arrays_of_arrays.

2014-01-21 Thread Matt Turner
On Tue, Jan 21, 2014 at 4:14 PM, Paul Berry wrote: > Most of the time it is not necessary to perform type inference to > compile GLSL; the type of every expression can be inferred from the > contents of the expression itself (and previous type declarations). > The exception is aggregate initialize

[Mesa-dev] [Bug 73902] build: move ARCH_LIBS definition over the first usage

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73902 Paul Seidler changed: What|Removed |Added Status|NEEDINFO|NEW Assignee|mesa-dev@lists.fre

[Mesa-dev] [PATCH] glsl: Simplify aggregate type inference to prepare for ARB_arrays_of_arrays.

2014-01-21 Thread Paul Berry
Most of the time it is not necessary to perform type inference to compile GLSL; the type of every expression can be inferred from the contents of the expression itself (and previous type declarations). The exception is aggregate initializers: their type is determined by the LHS of the variable bein

[Mesa-dev] [Bug 73902] build: move ARCH_LIBS definition over the first usage

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73902 Paul Seidler changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Paul Seidler

[Mesa-dev] [Bug 73902] build: move ARCH_LIBS definition over the first usage

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73902 Paul Seidler changed: What|Removed |Added Attachment #92551|0 |1 is obsolete|

[Mesa-dev] [PATCH 06/18] mesa: Implement glBindSamplers()

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/samplerobj.c | 115 1 file changed, 115 insertions(+) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index 077ee9e..f34d95d 100644 --- a/src/mesa/main/samplerobj.c +++ b/src/mesa/main/samplerobj.c @@ -51,6 +51,2

[Mesa-dev] [PATCH 14/18] mesa: Implement glBindBuffersRange()

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/bufferobj.c | 374 + 1 file changed, 374 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index aafaad7..c110cc1 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -2605,6 +2605,3

[Mesa-dev] [PATCH 05/18] glapi: Add infrastructure for ARB_multi_bind

2014-01-21 Thread Fredrik Höglund
--- src/mapi/glapi/gen/ARB_multi_bind.xml | 53 +++ src/mapi/glapi/gen/Makefile.am |1 + src/mapi/glapi/gen/gl_API.xml |4 +++ src/mesa/main/bufferobj.c | 13 src/mesa/main/bufferobj.h |7 sr

[Mesa-dev] [PATCH 07/18] mesa: Add helper functions for looking up multiple textures

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/texobj.c | 21 + src/mesa/main/texobj.h |9 + 2 files changed, 30 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 8fdec5c..c9fe11d 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -61,6 +61,27

[Mesa-dev] [PATCH 18/18] docs: Mark ARB_multi_bind as done

2014-01-21 Thread Fredrik Höglund
...and update relnotes. --- docs/GL3.txt|2 +- docs/relnotes/10.1.html |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 3bded7d..2a6b313 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -173,7 +173,7 @@ GL 4.4: GL_ARB_buffe

[Mesa-dev] [PATCH 02/18] mesa: Add a _BoundTextures field in gl_texture_unit

2014-01-21 Thread Fredrik Höglund
This will be used by glBindTextures() when unbinding textures, to avoid having to loop over all the targets. --- src/mesa/main/mtypes.h |3 +++ src/mesa/main/texobj.c |6 ++ src/mesa/main/texstate.c |3 +++ 3 files changed, 12 insertions(+) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 17/18] mesa: Enable ARB_multi_bind

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/extensions.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index c2c9c09..3e183d9 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -111,6 +111,7 @@ static const struct extension extension_

[Mesa-dev] [PATCH 11/18] mesa: Refactor set_ubo_binding()

2014-01-21 Thread Fredrik Höglund
Make set_ubo_binding() just update the binding, and move the code that does validation, flushes the vertices etc. into a new bind_uniform_buffer() function. --- src/mesa/main/bufferobj.c | 50 - 1 file changed, 31 insertions(+), 19 deletions(-) diff -

[Mesa-dev] [PATCH 10/18] mesa: Add helper functions for looking up multiple buffers

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/bufferobj.c | 66 + src/mesa/main/bufferobj.h | 14 ++ 2 files changed, 80 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 4094e31..81344ac 100644 --- a/src/mesa/main/bufferobj.c +++ b

[Mesa-dev] [PATCH 12/18] mesa: Add _mesa_set_transform_feedback_binding()

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/transformfeedback.c | 10 +- src/mesa/main/transformfeedback.h | 14 ++ 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index 76d213b..d69e6c5 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 03/18] mesa: Optimize unbind_texobj_from_texunits()

2014-01-21 Thread Fredrik Höglund
The texture can only be bound to the index that corresponds to its target, so there is no need to loop over all possible indices for every unit and checking if the texture is bound to it. --- src/mesa/main/texobj.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) dif

[Mesa-dev] [PATCH 13/18] mesa: Implement glBindBuffersBase()

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/bufferobj.c | 373 + 1 file changed, 373 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9ef9dd0..aafaad7 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -2605,6 +2605,3

[Mesa-dev] [PATCH 09/18] mesa: Refactor set_atomic_buffer_binding()

2014-01-21 Thread Fredrik Höglund
Make set_atomic_buffer_binding() just update the binding, and move the code that does validation, flushes the vertices etc. into a new bind_atomic_buffer() function. --- src/mesa/main/bufferobj.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-)

[Mesa-dev] [PATCH 04/18] mesa: Add functions for doing unlocked hash table lookups

2014-01-21 Thread Fredrik Höglund
This patch adds functions for locking/unlocking the mutex, along with _mesa_HashLookupWithoutLocking() and _mesa_HashInsertWithoutLocking() that do lookups and insertions without locking the mutex. These functions will be used by the ARB_multi_bind entry points to avoid locking/unlocking the mutex

[Mesa-dev] [PATCH 01/18] mesa: Store the target index in gl_texture_object

2014-01-21 Thread Fredrik Höglund
This will be used by glBindTextures() so we don't have to look it up for each texture. --- src/mesa/main/mtypes.h |1 + src/mesa/main/texobj.c |2 ++ 2 files changed, 3 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index c396609..2fe47c4 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 15/18] mesa: Implement glBindVertexBuffers()

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/varray.c | 114 1 file changed, 114 insertions(+) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 386bfea..26cd190 100644 --- a/src/mesa/main/varray.c +++ b/src/mesa/main/varray.c @@ -1448,6 +1448,120 @@ void G

[Mesa-dev] [PATCH 08/18] mesa: Implement glBindTextures()

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/texobj.c | 121 1 file changed, 121 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index c9fe11d..2ff3f9d 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1140,6 +1140,28 @@ unbind_

[Mesa-dev] [PATCH 00/18] Implement GL_ARB_multi_bind

2014-01-21 Thread Fredrik Höglund
So here is my take on GL_ARB_multi_bind. I tried to come up with names for the new hash table functions that don't suggest that they should be used to do unlocked insertions/lookups. I'm not entirely happy with the ones I came up with though, so I'm hoping someone will have better suggestions. Wh

[Mesa-dev] [PATCH 16/18] mesa: Implement glBindImageTextures()

2014-01-21 Thread Fredrik Höglund
--- src/mesa/main/shaderimage.c | 164 +++ 1 file changed, 164 insertions(+) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index ce63bee..27695a3 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderimage.c @@ -33,6 +

Re: [Mesa-dev] [PATCH 1/5] glsl: Mark GLSL 4.40 as a known version.

2014-01-21 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick On 01/17/2014 09:09 PM, Matt Turner wrote: > --- > src/glsl/glsl_parser_extras.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp > index 21dc3ab..e67988f 100644 > --

Re: [Mesa-dev] [PATCH 5/5] glcpp: Define GL_EXT_shader_integer_mix in both GL and ES.

2014-01-21 Thread Ian Romanick
This is a good fix for now. I'd really like for this code to be table-driven. We have similar code in the compiler for the extensions that can be enabled. We ought to be able to unify those paths... an extension can be enabled iff it's #define is available. On 01/17/2014 09:09 PM, Matt Turner w

Re: [Mesa-dev] [PATCH] mesa: add missing TYPE_DOUBLEN_2 cases in get.c

2014-01-21 Thread Ian Romanick
On 01/21/2014 08:25 AM, Brian Paul wrote: > The new TYPE_DOUBLEN_2 type was added in 0e60d850 but the code to > return values of that type wasn't completed. > > Fixes conform's default state test. glGetFloatv(GL_DEPTH_RANGE) > wasn't returning anything. > > v2: remove stray 'break' statements.

Re: [Mesa-dev] [PATCH 2/2] st/mesa: add support for GL_ARB_viewport_array (v0.2)

2014-01-21 Thread Ian Romanick
On 01/20/2014 10:09 PM, Dave Airlie wrote: > From: Dave Airlie > > this just ties the mesa code to the pre-existing gallium interface, > I'm not sure what to do with the CSO stuff yet. > > 0.2: fix min/max bounds > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_atom_scissor.c

Re: [Mesa-dev] [PATCH 1/2] st/mesa: add support for viewport index semantic

2014-01-21 Thread Ian Romanick
On 01/20/2014 10:09 PM, Dave Airlie wrote: > From: Dave Airlie > > This adds GS output and FS input support, even though FS input > support isn't supported until GLSL 4.30 from what I can see. Or GL_ARB_fragment_layer_viewport. There's a bit of, IMO, a goof here. The FS input will have exactly

[Mesa-dev] [Bug 73902] build: move ARCH_LIBS definition over the first usage

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73902 --- Comment #1 from Paul Seidler --- Created attachment 92551 --> https://bugs.freedesktop.org/attachment.cgi?id=92551&action=edit patch to move ARCH_LIBS definition over the first usage -- You are receiving this mail because: You are the ass

Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

2014-01-21 Thread Timothy Arceri
Hi Paul Thanks for the thorough review and taking the time to explain how to make improvements. I can already see a number of improvements that can be made to patch 5 based on the suggestions you have already made so you could hold off reviewing that one if you havent started already and I've p

[Mesa-dev] [Bug 73902] New: build: move ARCH_LIBS definition over the first usage

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73902 Priority: medium Bug ID: 73902 Assignee: mesa-dev@lists.freedesktop.org Summary: build: move ARCH_LIBS definition over the first usage Severity: normal Classification: Unclassified

Re: [Mesa-dev] [PATCH] gallium/util: util_format_srgb should not return FORMAT_NONE for sRGB formats

2014-01-21 Thread Brian Paul
On 01/21/2014 02:21 PM, Marek Olšák wrote: From: Marek Olšák This fixes a serious regression introduced in 4e549ddb500cf677b6fa16d9ebdfa67cc23da097. Cc: 9.2 10.0 --- src/gallium/auxiliary/util/u_format.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/util/u_fo

[Mesa-dev] [PATCH] gallium/util: util_format_srgb should not return FORMAT_NONE for sRGB formats

2014-01-21 Thread Marek Olšák
From: Marek Olšák This fixes a serious regression introduced in 4e549ddb500cf677b6fa16d9ebdfa67cc23da097. Cc: 9.2 10.0 --- src/gallium/auxiliary/util/u_format.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format.h b/src/gallium/auxiliary/util/u_format.h

[Mesa-dev] [Bug 73672] Half Life 2 in Wine is broken since 4e549ddb

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73672 --- Comment #19 from Marek Olšák --- I sent the fix to mesa-dev. It's called "gallium/util: util_format_srgb should not return FORMAT_NONE for sRGB formats". -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 1/2] glsl: extract function for record comparisons

2014-01-21 Thread Matt Turner
On Tue, Nov 26, 2013 at 3:15 PM, Grigori Goronzy wrote: > --- > src/glsl/glsl_types.cpp | 61 > +++-- > src/glsl/glsl_types.h | 7 ++ > 2 files changed, 41 insertions(+), 27 deletions(-) > > diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_t

Re: [Mesa-dev] [PATCH V2 4/8] glsl: only call mark_max_array if we are assigning an array

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast_to_hir.cpp | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Can you say more in the commit message about why you're making this change? Is this fixing an existing bug? Is it pr

[Mesa-dev] [Bug 73900] mesa: Fix build to properly check for supported compiler flags

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73900 Matt Turner changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@lists

Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast.h | 44 +++ > src/glsl/ast_array_index.cpp| 13 > src/glsl/ast_to_hir.cpp | 160 > +++- > src/glsl/ast_type.cpp

Re: [Mesa-dev] [PATCH V2 2/8] glsl: Add arrays_of_arrays to yacc definition

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/glsl_parser.yy | 153 > +--- > 1 file changed, 66 insertions(+), 87 deletions(-) > > diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy > inde

Re: [Mesa-dev] [PATCH V2 1/8] mesa: Add ARB_arrays_of_arrays

2014-01-21 Thread Paul Berry
On 21 January 2014 04:19, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 2 files changed, 2 insertions(+) > Since this is a GLSL extension, you also need to update glcpp_parser_create() (in glcpp-parse.y) to

[Mesa-dev] [Bug 73900] New: mesa: Fix build to properly check for supported compiler flags

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73900 Priority: medium Bug ID: 73900 Assignee: mesa-dev@lists.freedesktop.org Summary: mesa: Fix build to properly check for supported compiler flags Severity: normal Classific

Re: [Mesa-dev] [PATCH 1/2] i965/blorp: patch jump counters also for endif

2014-01-21 Thread Eric Anholt
Topi Pohjolainen writes: > No known bugs fixed but this is now in line with fs-generator. > No regresssions on IVB. The endif jump, since it's forward, is just an optimization to have set right -- otherwise, the GPU will just step forward instruction by instruction until it hits something else t

[Mesa-dev] [PATCH] intel: Fix initial MakeCurrent for single-buffer drawables

2014-01-21 Thread Kristian Høgsberg
Commit 05da4a7a5e7d5bd988cb31f94ed8e1f053d9ee39 attempts to eliminate the call to intel_update_renderbuffer() in the case where we already have a drawbuffer for the drawable. Unfortunately this only checks the back left renderbuffer, which breaks in case of single buffer drawables. This means tha

[Mesa-dev] [Bug 71543] [mesa] Source-based games segfault

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71543 --- Comment #13 from Alexander Monakov --- Thanks for providing the new bisect result. Yeah, it seems that that commit series greatly increase the visibility of the problem, since now libudev is linked in always, not just with --enable-dri3 (I t

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #17 from Alexander Monakov --- Benjamin Bellec provided the bisect result in bug 71543. It's the same problem, but it got more visibility (not limited to --enable-dri3 now) due to a recent commit. Let's continue in that (still open)

Re: [Mesa-dev] [PATCH] loader: Get driver name from udev hwdb when available

2014-01-21 Thread Eric Anholt
Kristian Høgsberg writes: > The udev hwdb is a mechanism for applying udev properties to devices at > hotplug time. The hwdb text files are compiled into a binary database > that lets udev efficiently look up and apply properties to devices that > match a given modalias. > > This patch exports t

Re: [Mesa-dev] [PATCH] dri-vmwgfx: add __driDriverGetExtensions_vmwgfx() function

2014-01-21 Thread Eric Anholt
Brian Paul writes: > On 01/20/2014 06:19 PM, Matt Turner wrote: >> I can't see why this would be needed at all. The X.Org loader was >> modified to look for the new symbol names (i.e., the one added in this >> patch) but still looks for the regular ones too. >> >> And since Jordan's patch to mega

Re: [Mesa-dev] [PATCH 15/15] i965/blorp: Account for nonzero MinLayer in layered clears.

2014-01-21 Thread Chris Forbes
No, I didn't enable it -- there's still a few cases I'm not happy with. I did my testing with MESA_EXTENSION_OVERRIDE=GL_ARB_texture_view. On Wed, Jan 22, 2014 at 9:14 AM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > I don't see any patch that sets ctx->Extensions.ARB_texture_view =

[Mesa-dev] [Bug 71543] [mesa] Source-based games segfault

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71543 --- Comment #12 from mmstick...@gmail.com --- I can confirm that TF2 and L4D2 work fine, but I can add that none of the GoldSrc games work, and Day of Defeat: Source also doesn't work. -- You are receiving this mail because: You are the assignee

Re: [Mesa-dev] [PATCH 15/15] i965/blorp: Account for nonzero MinLayer in layered clears.

2014-01-21 Thread Courtney Goeltzenleuchter
I don't see any patch that sets ctx->Extensions.ARB_texture_view = true; Something like attached. Courtney On Tue, Jan 21, 2014 at 3:34 AM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 del

[Mesa-dev] [Bug 71543] [mesa] Source-based games segfault

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71543 Benjamin Bellec changed: What|Removed |Added CC||b.bel...@gmail.com --- Comment #11 fro

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #16 from Alexander Monakov --- (In reply to comment #15) > It's pretty obvious from the backtrace that it's the same issue. Note that > the bug is only exhibited in mesa with dri3 support enabled. It's possible > that your most rece

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #15 from Alex Deucher --- (In reply to comment #9) > (In reply to comment #8) > > The problem is simultaneous loading of multiple libudev.so's; see > > https://bugs.freedesktop.org/show_bug.cgi?id=71543 and > > http://lists.freedeskto

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #14 from mmstick...@gmail.com --- (In reply to comment #13) > Here is the changelist of the ppa build: > https://launchpadlibrarian.net/162987663/mesa_10.1~git1401210730. > ded567+curaga~gd~s_source.changes > > And here is the corresp

[Mesa-dev] [Bug 73875] Please update mesa3d.org to reflect 10.0.2 release

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73875 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 73875] Please update mesa3d.org to reflect 10.0.2 release

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73875 --- Comment #1 from Brian Paul --- Done. Thanks for the reminder. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #13 from Alexander Monakov --- Here is the changelist of the ppa build: https://launchpadlibrarian.net/162987663/mesa_10.1~git1401210730.ded567+curaga~gd~s_source.changes And here is the corresponding Mesa commit list: http://cgit.fr

Re: [Mesa-dev] [PATCH 2/2] i965/blorp: use BRW_COMPRESSION_2NDHALF for second half LPR

2014-01-21 Thread Kenneth Graunke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/21/2014 08:07 AM, Topi Pohjolainen wrote: > No known bugs fixed but this is now in line with fs-generator. No > regresssions on IVB. > > CC: Paul Berry Signed-off-by: Topi > Pohjolainen --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp

Re: [Mesa-dev] [PATCH demos] opengles2/es2tri: add precision qualifier to the fragment shader

2014-01-21 Thread Emil Velikov
On 20/01/14 15:16, Brian Paul wrote: > On 01/19/2014 08:34 AM, Emil Velikov wrote: >> The missing qualifier causes failure during the compilation stage. >> >> Bugzilla: >> https://urldefense.proofpoint.com/v1/url?u=https://bugs.freedesktop.org/show_bug.cgi?id%3D73631&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3

Re: [Mesa-dev] Two small blorp fixes found during refactoring

2014-01-21 Thread Paul Berry
On 21 January 2014 08:07, Topi Pohjolainen wrote: > These are not known to have caused any problems but they would get > fixed when switching into fs-generator. Both fixes need > corresponding patching of the unit tests and fixing them aforehand > makes the switch possible without any changes in t

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #12 from mmstick...@gmail.com --- I have no experience running git bisects, let alone compiling all of mesa and xorg drivers. I am just an Ubuntu user that uses the Oibaf PPA which keeps up to date with the latest git of mesa/xorg dail

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 Alexander Monakov changed: What|Removed |Added CC||amona...@gmail.com -- You are recei

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #11 from Alexander Monakov --- (In reply to comment #9) > (In reply to comment #8) > > The problem is simultaneous loading of multiple libudev.so's; see > > https://bugs.freedesktop.org/show_bug.cgi?id=71543 and > > http://lists.freed

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #10 from Tobias Droste --- (In reply to comment #7) > Do you have any AMD GPUs to test with your system? I've been hearing a lot > of people having the same issue I am, but they all seem to have AMD GPUs. cstrike 1.6 does work here w

[Mesa-dev] Two small blorp fixes found during refactoring

2014-01-21 Thread Topi Pohjolainen
These are not known to have caused any problems but they would get fixed when switching into fs-generator. Both fixes need corresponding patching of the unit tests and fixing them aforehand makes the switch possible without any changes in the tests. Topi Pohjolainen (2): i965/blorp: patch jump c

[Mesa-dev] [PATCH 2/2] i965/blorp: use BRW_COMPRESSION_2NDHALF for second half LPR

2014-01-21 Thread Topi Pohjolainen
No known bugs fixed but this is now in line with fs-generator. No regresssions on IVB. CC: Paul Berry Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 46 ++ .../drivers/dri/i965/test_blorp_blit_eu_gen.cpp| 24 +-- 2 files

[Mesa-dev] [PATCH 1/2] i965/blorp: patch jump counters also for endif

2014-01-21 Thread Topi Pohjolainen
No known bugs fixed but this is now in line with fs-generator. No regresssions on IVB. CC: Paul Berry Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 2 ++ src/mesa/drivers/dri/i965/test_blorp_blit_eu_gen.cpp | 6 +++--- 2 files changed, 5 insertions(+

Re: [Mesa-dev] [PATCH] mesa: add missing TYPE_DOUBLEN_2 cases in get.c

2014-01-21 Thread Jose Fonseca
- Original Message - > The new TYPE_DOUBLEN_2 type was added in 0e60d850 but the code to > return values of that type wasn't completed. > > Fixes conform's default state test. glGetFloatv(GL_DEPTH_RANGE) > wasn't returning anything. > > v2: remove stray 'break' statements. > --- > src

[Mesa-dev] [Bug 73854] GoldSrc and Source Games Segfault on Launch

2014-01-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73854 --- Comment #9 from mmstick...@gmail.com --- (In reply to comment #8) > The problem is simultaneous loading of multiple libudev.so's; see > https://bugs.freedesktop.org/show_bug.cgi?id=71543 and > http://lists.freedesktop.org/archives/mesa-dev/201

[Mesa-dev] [PATCH] mesa: add missing TYPE_DOUBLEN_2 cases in get.c

2014-01-21 Thread Brian Paul
The new TYPE_DOUBLEN_2 type was added in 0e60d850 but the code to return values of that type wasn't completed. Fixes conform's default state test. glGetFloatv(GL_DEPTH_RANGE) wasn't returning anything. v2: remove stray 'break' statements. --- src/mesa/main/get.c | 12 1 file chan

  1   2   >