[Mesa-dev] [Bug 73956] SIGSEGV when passing GL_NONE to glReadBuffer

https://bugs.freedesktop.org/show_bug.cgi?id=73956 --- Comment #1 from Tapani Pälli --- Can you post the backtrace? GL_NONE is a valid value for glReadBuffer() and there seems toe be plenty of Piglit tests using this so you might be hitting some corner case here. -- You are receiving this mail

[Mesa-dev] [Bug 73946] scanout broken on radeon SI (OLAND)

https://bugs.freedesktop.org/show_bug.cgi?id=73946 Michel Dänzer changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 73956] SIGSEGV when passing GL_NONE to glReadBuffer

https://bugs.freedesktop.org/show_bug.cgi?id=73956 ahmabd...@hotmail.com changed: What|Removed |Added CC||ahmabd...@hotmail.com -- You are

Re: [Mesa-dev] [PATCH V3 2/8] glsl: Add arrays_of_arrays to yacc definition

On Wed, Jan 22, 2014 at 10:33:01PM +1100, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/glsl_parser.yy | 128 > +--- > 1 file changed, 56 insertions(+), 72 deletions(-) > > diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_

[Mesa-dev] [Bug 73956] New: SIGSEGV when passing GL_NONE to glReadBuffer

https://bugs.freedesktop.org/show_bug.cgi?id=73956 Priority: medium Bug ID: 73956 Assignee: mesa-dev@lists.freedesktop.org Summary: SIGSEGV when passing GL_NONE to glReadBuffer Severity: major Classification: Unclassified OS:

Re: [Mesa-dev] [PATCH 00/30] mesa: Start implementing compute shaders.

On Thu, Jan 9, 2014 at 6:19 PM, Paul Berry wrote: > This is the first of several planned patch series to implement the > extension ARB_compute_shader in Mesa. This series allows the Mesa > front-end to parse and compile a "do-nothing" compute shader--that is, > one which contains nothing but a co

Re: [Mesa-dev] [PATCH 00/16] Enable GL_ARB_map_buffer_alignment in all drivers

On 01/22/2014 08:48 PM, Ian Romanick wrote: > This is mostly a re-send of Siavash's original patch series. A couple > patches (e.g., the one to i965) have been dropped, and a couple had > small changes applied. I also added patch 9 (freedreno) and patch 16 > (docs update). > > I'd like to land t

[Mesa-dev] [PATCH 11/16] mesa: Set gl_constants::MinMapBufferAlignment to 64 by default

From: Siavash Eliasi Reviewed-by: Ian Romanick --- src/mesa/main/context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 7c3b2d7..b818ab4 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@ -587,6 +587,7 @@ _mesa_in

[Mesa-dev] [PATCH 12/16] mesa: Use _mesa_align_malloc in _mesa_buffer_data

From: Siavash Eliasi v2: Fixed memory leak. Reviewed-by: Ian Romanick --- src/mesa/main/bufferobj.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9336759..4fb349e 100644 --- a/src/mesa/main/bufferobj.c +++

[Mesa-dev] [PATCH 13/16] radeon / r200: Use gl_constants::MinMapBufferAlignment as the alignment in radeon_bo_open

From: Siavash Eliasi These drivers do not support GL_ARB_map_buffer_range, so no special treatment is needed for unaligned offsets in the mapping. Reviewed-by: Ian Romanick --- src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 09/16] freedreno: Set PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT to 64

From: Ian Romanick Allocations actually have page alignment, but 64 is still a reasonable value. Signed-off-by: Ian Romanick Cc: Rob Clark --- src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/freedreno/freedreno_screen

[Mesa-dev] [PATCH 08/16] ilo: Set PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT to 64

From: Siavash Eliasi Ian manually ran the map_buffer_range* tests and the arb_map_buffer_alignment-* tests, but he did not do a full piglit run. v2 (idr): Use 64 instead of 4096 Tested-by: Ian Romanick Cc: Chia-I Wu --- src/gallium/drivers/ilo/ilo_screen.c | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH 14/16] nouveau: Use gl_constants::MinMapBufferAlignment as the alignment in nouveau_bo_new

From: Siavash Eliasi This driver does not support GL_ARB_map_buffer_range, so no special treatment is needed for unaligned offsets in the mapping. Reviewed-by: Ian Romanick --- src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 04/16] llvmpipe: Set PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT to 64

From: Siavash Eliasi v2: Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. Reviewed-by: Ian Romanick --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/s

[Mesa-dev] [PATCH 15/16] mesa: GL_ARB_map_buffer_alignment is not optional

From: Siavash Eliasi Every driver supports it. All current and future Gallium drivers always support it, and all existing classic drivers support it. v2: Making GL_ARB_map_buffer_alignment a desktop OpenGL extension only. v3: Squash two commits together. v4 (idr): MIN_MAP_BUFFER_ALIGNMENT que

[Mesa-dev] [PATCH 00/16] Enable GL_ARB_map_buffer_alignment in all drivers

This is mostly a re-send of Siavash's original patch series. A couple patches (e.g., the one to i965) have been dropped, and a couple had small changes applied. I also added patch 9 (freedreno) and patch 16 (docs update). I'd like to land the whole series this week.

[Mesa-dev] [PATCH 05/16] i915g: Use alignment of 64 instead of 16 for buffer allocation

From: Siavash Eliasi Reviewed-by: Ian Romanick --- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 1566dc0..9fb3855 100644

[Mesa-dev] [PATCH 07/16] svga: Set PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT to 64

From: Siavash Eliasi v2: Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. Reviewed-by: Ian Romanick --- src/gallium/drivers/svga/svga_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/g

[Mesa-dev] [PATCH 10/16] mesa/st: Unconditionally enable ARB_map_buffer_alignment.

From: Siavash Eliasi Reviewed-by: Ian Romanick --- src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index e7d5d74..c3f67b7 100644 --- a/src/mesa/state

[Mesa-dev] [PATCH 16/16] docs: Add GL_ARB_map_buffer_alignment status to GL3.txt and release notes

From: Ian Romanick Signed-off-by: Ian Romanick --- docs/GL3.txt| 2 +- docs/relnotes/10.1.html | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 3bded7d..644e1c6 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -136,7 +136,7 @@ GL

[Mesa-dev] [PATCH 03/16] llvmpipe: Use alignment of 64 instead of 16 for buffer allocation

From: Siavash Eliasi v2: Changed allocation alignment of llvmpipe_displaytarget_layout. Reviewed-by: Ian Romanick --- src/gallium/drivers/llvmpipe/lp_texture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c b/src/gallium/dri

[Mesa-dev] [PATCH 01/16] softpipe: Use alignment of 64 instead of 16 for buffer allocation

From: Siavash Eliasi v2: Changed allocation alignment in softpipe_displaytarget_layout. Reviewed-by: Ian Romanick --- src/gallium/drivers/softpipe/sp_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_texture.c b/src/gallium/drive

[Mesa-dev] [PATCH 06/16] i915g: Set PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT to 64

From: Siavash Eliasi v2: Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. --- src/gallium/drivers/i915/i915_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_scr

[Mesa-dev] [PATCH 02/16] softpipe: Set PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT to 64

From: Siavash Eliasi v2: Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. Reviewed-by: Ian Romanick --- src/gallium/drivers/softpipe/sp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/s

Re: [Mesa-dev] [PATCH 01/22] r600g: move queries to drivers/radeon

On Don, 2014-01-23 at 00:12 +0100, Marek Olšák wrote: > BTW, this is all the consolidation and cleanup for now. It doesn't > change the behavior except where noted. Apart from the separate minor comments, the series is Reviewed-by: Michel Dänzer Nice work! -- Earthling Michel Dänzer

Re: [Mesa-dev] [PATCH 19/22] radeonsi: remove si_resource.h

On Mit, 2014-01-22 at 21:13 +0100, Marek Olšák wrote: > > @@ -81,6 +80,10 @@ struct si_textures_info { > unsignedn_samplers; > }; > > +struct si_surface { > + struct pipe_surface base; > +}; AFAICT struct si_surface could just be nuked. -- Earth

Re: [Mesa-dev] [PATCH 20/22] radeonsi: move some inline functions from si_pipe.h to si_state.c

On Mit, 2014-01-22 at 21:13 +0100, Marek Olšák wrote: > > index 3eab4d9..fd4e26a 100644 > --- a/src/gallium/drivers/radeonsi/si_state.c > +++ b/src/gallium/drivers/radeonsi/si_state.c > @@ -166,6 +166,36 @@ static unsigned cik_db_pipe_config(struct si_screen > *sscreen, unsigned tile_mode >

Re: [Mesa-dev] [PATCH 13/22] r600g, radeonsi: consolidate get_compute_param

On Mit, 2014-01-22 at 21:13 +0100, Marek Olšák wrote: > > + case CHIP_TAHITI: return "tahiti"; > + case CHIP_PITCAIRN: return "pitcairn"; > + case CHIP_VERDE: return "verde"; > + case CHIP_OLAND: return "oland"; > +#if HAVE_LLVM <= 0x0303 > + default: return "SI"; It might be

Re: [Mesa-dev] [V4 PATCH 0/7] mesa: Naming MESA_FORMATs to a specification

Hi Merek, On Wed, Jan 22, 2014 at 2:49 PM, Marek Olšák wrote: > Hi Mark, > > Could you please mention or document somewhere in the code (e.g. in > main/formats.h) which _REV formats are incorrect according to you? > Sorry if you did so already, I haven't read your other patches yet. > > Ther

[Mesa-dev] [PATCHv2 2/2] util/u_vbuf: correct map offset calculation for crazy offsets

When the min_index is very large (or very negative), the multipliation can overflow 32 bits and result in an incorrect map pointer modification. Signed-off-by: Ilia Mirkin --- I tested this by setting PIPE_CAP_USER_*_BUFFERS to 0 on nv50, and hacking the logic to say that unroll_indices = true,

[Mesa-dev] [PATCHv2 1/2] translate: deal with size overflows by casting to ptrdiff_t

This was discovered as a result of the draw-elements-base-vertex-neg piglit test, which passes very negative offsets in, followed up by large indices. The nouveau code correctly adjusts the pointer, but the translate code needs to do the proper inverse correction. Similarly fix up the SSE code to d

[Mesa-dev] [PATCHv2 0/2] Fix some invalid pointer modifications

It looks like a lot of offsets in gallium are really not ready for >32-bit buffer sizes. For example, pipe_buffer->width0 is an unsigned int. However in these cases, there are some semi-legitimate use-cases where a 64-bit offset is still computed, as tested by the draw-elements-base-vertex-neg pigl

Re: [Mesa-dev] [PATCH] rtasm: deal with size overflows by casting to ptrdiff_t

Looks like nouveau works fine when setting PIPE_CAP_USER_*_BUFFERS to false. I'm not sure why, as the u_vbuf code seems similarly busted -- e.g. it does map -= vb->stride * min_index; But... perhaps I'm misreading/misunderstanding the code.When I fudge the code to force unroll_indices =

[Mesa-dev] [PATCH 4/5] glsl: silence a couple warnings in find_active_atomic_counters()

Silence unitialized variable 'id' warning. Silence unused 'found' warning. Only seen in release builds. --- src/glsl/link_atomics.cpp |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_atomics.cpp b/src/glsl/link_atomics.cpp index db9c539..d92cdb1 100644 --- a/

[Mesa-dev] [PATCH 2/5] mesa: fix/add some cases in _mesa_get_linear_internalformat()

In some cases we were converting generic formats to sized formats and vice versa. The point is to simply convert sRGB formats to corresponding linear formats. --- src/mesa/main/glformats.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/glformats.c b/sr

[Mesa-dev] [PATCH 5/5] mesa: rename unbind_texobj_from_imgunits()

... to unbind_texobj_from_image_units() and change a local var's type to silence an MSVC warning. --- src/mesa/main/texobj.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 3c64c437..5d516c5 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 1/5] mesa: add missing ETC2_SRGB cases in formats.c

In the _mesa_get_format_color_encoding() and _mesa_get_srgb_format_linear() functions. --- src/mesa/main/formats.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index 1246c4d..7bde1f1 100644 --- a/src/mesa/main/formats.c +++ b

[Mesa-dev] [PATCH 3/5] mesa: initialize "is_layered" variable to silence warning

--- src/mesa/main/fbobject.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index dc7184a..943f40b 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -880,7 +880,7 @@ _mesa_test_framebuffer_completenes

[Mesa-dev] [PATCH] haiku: change atomic int to non-volatile

* Our atomic calls changed recently and no longer want atomic int pointers to be volatile --- include/HaikuGL/GLRenderer.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/HaikuGL/GLRenderer.h b/include/HaikuGL/GLRenderer.h index 7ffcc34..a27ee81 100644 ---

[Mesa-dev] [PATCH] i965: Don't store qpitch / 4 as mt->qpitch for compressed surfaces.

Broadwell requires software to specify QPitch in a bunch of packets, so we decided to store it in the miptree. However, when I did that refactoring, I missed a subtlety: the hardware expects QPitch to be "in units of rows in the uncompressed surface". This is the value we originally compute. How

Re: [Mesa-dev] [PATCH] vdpau: flush the context before exporting the surface v2

Is there any news from the XBMC team? I think we should fix this sooner rather than later. Marek On Mon, Jan 13, 2014 at 3:29 PM, Christian König wrote: > Yeah, probably because XBMC still (incorrectly) calls the map function only > once. > > Putting the flush into vlVdpResolveDelayedRendering s

Re: [Mesa-dev] [V3 PATCH 1/8] mesa: 's/\bgl_format\b/mesa_format/g'. Use better name for Mesa Formats enum

On 01/22/2014 04:12 PM, Kenneth Graunke wrote: On 01/17/2014 08:58 AM, Brian Paul wrote: On 01/16/2014 10:13 PM, Mark Mueller wrote: This series encompases the much discussed specification and renaming of MESA_FORMATs, which now is packed into 8 patches Signed-off-by: Mark Mueller --- Well,

Re: [Mesa-dev] [PATCH 0/3] Update gles2/3 headers

On Wed, Jan 22, 2014 at 2:14 PM, Matt Turner wrote: > [PATCH 2/3] gles2: Update gl2ext.h to revision 24614. > > was caught by the size filter, so I canceled the posting. > > I grepped the headers for #include changes and found none and verified > that Mesa's GLES2 and 3 builds still work afterward

Re: [Mesa-dev] code de-duplication and non-pci support v2

On Sat, Jan 18, 2014 at 11:14 AM, Emil Velikov wrote: > On 16/01/14 23:29, Kristian Høgsberg wrote: >> On Sat, Jan 11, 2014 at 04:51:42PM -0500, Rob Clark wrote: >>> > On Sat, Jan 11, 2014 at 11:54 AM, Emil Velikov >>> > wrote: > > This is an updated series of Rob's patches > > >

[Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

I missed this change in commit f5cfb4a. It fixes the incorrect rendering caused in Dolphin Emulator. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73915 Cc: Markus wick Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_wm.c | 3 ++- 1 f

[Mesa-dev] [Bug 73934] Function roundf undeclared in textparam.c when building with MSVC11

https://bugs.freedesktop.org/show_bug.cgi?id=73934 --- Comment #3 from Matt Turner --- (In reply to comment #2) > The stable branches and hence the tarballs are missing commit > bba8f10598866776ae198b363b3752c2e3bbb126 from master at the moment which > fixes this. You can just manually replace >

Re: [Mesa-dev] [PATCH] i965: Replace *_generator::shader with is_glsl boolean.

On 01/22/2014 12:00 PM, Paul Berry wrote: > The "shader" field in fs_generator, vec4_generator, and gen8_generator > was only used for one purpose; to figure out if we were compiling an > assembly shader or a GLSL shader. And it wasn't being used properly: > in vec4 shaders we were always initiali

Re: [Mesa-dev] [PATCH 01/22] r600g: move queries to drivers/radeon

BTW, this is all the consolidation and cleanup for now. It doesn't change the behavior except where noted. I didn't consolidate the get_param and get_shader_param functions, the blitting code, and Cayman/SI/CIK MSAA, because it seemed it would get too messy. Marek On Wed, Jan 22, 2014 at 9:12 PM

Re: [Mesa-dev] [V3 PATCH 1/8] mesa: 's/\bgl_format\b/mesa_format/g'. Use better name for Mesa Formats enum

On 01/17/2014 08:58 AM, Brian Paul wrote: > On 01/16/2014 10:13 PM, Mark Mueller wrote: >> This series encompases the much discussed specification and renaming >> of MESA_FORMATs, >> which now is packed into 8 patches >> >> Signed-off-by: Mark Mueller >> --- > > Well, our other enum typedefs (and

Re: [Mesa-dev] [PATCH 1/1] glsl: support indexing of arrays of arrays in ir_set_program_inouts

Ok, please ignore I set this patch out a bit prematurely. I'm pretty sure I should be making the change in ir_set_program_inouts_visitor::visit_enter() rather than here.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.o

Re: [Mesa-dev] [V4 PATCH 0/7] mesa: Naming MESA_FORMATs to a specification

Hi Mark, Could you please mention or document somewhere in the code (e.g. in main/formats.h) which _REV formats are incorrect according to you? Sorry if you did so already, I haven't read your other patches yet. Also, I have a proposal for SRGB formats. MESA_FORMAT_SRGB_UNORM8 and MESA_FORMAT_SA8

Re: [Mesa-dev] [PATCH V3 7/8] glsl: remove remaining is_array variables

> I'm guessing you missed this because you are building in release mode, so > asserts didn't get compiled.  If that's the > case, I'd like to encourage you > to do a debug build and double-check that piglit tests still pass.  You can > do that by > adding the "--enable-debug" option when you run

[Mesa-dev] [PATCH 0/3] Update gles2/3 headers

[PATCH 2/3] gles2: Update gl2ext.h to revision 24614. was caught by the size filter, so I canceled the posting. I grepped the headers for #include changes and found none and verified that Mesa's GLES2 and 3 builds still work afterwards. ___ mesa-dev mai

[Mesa-dev] [PATCH 1/3] gles2: Update gl2.h to revision 24614.

--- include/GLES2/gl2.h | 581 ++-- 1 file changed, 243 insertions(+), 338 deletions(-) diff --git a/include/GLES2/gl2.h b/include/GLES2/gl2.h index c2d8357..665f6c3 100644 --- a/include/GLES2/gl2.h +++ b/include/GLES2/gl2.h @@ -1,56 +1,83 @@ #ifnd

Re: [Mesa-dev] [PATCH V3 1/8] mesa: Add ARB_arrays_of_arrays

>On Thursday, 23 January 2014 7:54 AM, Matt Turner wrote: >On Wed, Jan 22, 2014 at 3:33 AM, Timothy Arceri wrote: >> Reviewed-by: Paul Berry >Let's make this @gmail.com. Whoops, yes I'll fix those up before pushing. ___ mesa-dev mailing list mesa-

[Mesa-dev] [PATCH 1/1] glsl: support indexing of arrays of arrays in ir_set_program_inouts

Signed-off-by: Timothy Arceri --- src/glsl/ir_set_program_inouts.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index 5163eb2..11b14ce 100644 --- a/src/glsl/ir_set_program_inouts.cpp +++ b/src/glsl

[Mesa-dev] [PATCH 0/1] glsl: support indexing of arrays of arrays in ir_set_program_inouts

This assert was failing when built in debug mode I'm not 100% sure if this change is correct ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH V4 7/8] glsl: remove remaining is_array variables

Previously the reason we needed is_array was because we used array_size == NULL to represent both non-arrays and unsized arrays. Now that we use a non-NULL array_specifier to represent an unsized array, is_array is redundant. Signed-off-by: Timothy Arceri Reviewed-by: Paul Berry --- src/glsl

Re: [Mesa-dev] Can we commit the Spanish and Catalan translations?

2014/1/22 Eric Anholt : > Thanks for the reminder. I was about to commit it, then noticed that > there was a placeholder copyright message. Because there's no single > license to the project, the current one is ill-defined. If you approve > of the following diff to patch 3/3, I can get this push

Re: [Mesa-dev] Can we commit the Spanish and Catalan translations?

Alex Henrie writes: > Hi, > > It's been a week and no new concerns have been raised with the > proposed Spanish and Catalan translations: > > http://lists.freedesktop.org/archives/mesa-dev/2014-January/051610.html > http://lists.freedesktop.org/archives/mesa-dev/2014-January/051611.html > http://

Re: [Mesa-dev] [PATCH V3 1/8] mesa: Add ARB_arrays_of_arrays

On Wed, Jan 22, 2014 at 3:33 AM, Timothy Arceri wrote: > Reviewed-by: Paul Berry Let's make this @gmail.com. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] rtasm: deal with size overflows by casting to ptrdiff_t

Do you think that the 32-bit multiply overflow when adding to the pointer is the correct behaviour? If it causes radeon/whatever to fail, I'd argue that they're adjusting their pointer incorrectly as well. I'll see what's up by setting that cap to 0, and if that causes the test to break, I'll figur

Re: [Mesa-dev] [PATCH 10/10] i965: Support 32 texture image units on Haswell+.

On Sat, Jan 18, 2014 at 8:20 PM, Kenneth Graunke wrote: > The Intel closed source OpenGL driver recently began supporting 32 > texture image units on Haswell. This makes the open source driver > support 32 as well. > > Earlier generations don't have the message header field required to > support

Re: [Mesa-dev] [PATCH] rtasm: deal with size overflows by casting to ptrdiff_t

The draw-elements-base-vertex-neg test passes on Radeon, which uses the common util/u_vbuf for uploading vertices. I know Nouveau is probably the only driver which doesn't use it, not counting the swrast drivers. I'm afraid that your change from fail to pass for Nouveau will break the test for ever

Re: [Mesa-dev] [PATCH 1/2] gallium: remove PIPE_CAP_MAX_COMBINED_SAMPLERS

On Mon, Jan 20, 2014 at 3:35 PM, Brian Paul wrote: > I'm not sure about this. The concept of MAX_COMBINED_TEXTURE_IMAGE_UNITS > goes back to the first shader hardware where texture image units might be > shared between the VS and FS. > > The question is whether any of the hardware we care about h

Re: [Mesa-dev] [V3 PATCH 1/8] mesa: 's/\bgl_format\b/mesa_format/g'. Use better name for Mesa Formats enum

On Fri, Jan 17, 2014 at 8:58 AM, Brian Paul wrote: > On 01/16/2014 10:13 PM, Mark Mueller wrote: > >> This series encompases the much discussed specification and renaming of >> MESA_FORMATs, >> which now is packed into 8 patches >> >> Signed-off-by: Mark Mueller >> --- >> > > Well, our other enu

Re: [Mesa-dev] [PATCH] rtasm: deal with size overflows by casting to ptrdiff_t

On Wed, Jan 22, 2014 at 3:27 PM, Marek Olšák wrote: > Does Nouveau still work if you report PIPE_CAP_USER_VERTEX_BUFFERS = 0? I'm not in front of a machine with nouveau, so I can't tell you right now, but I'll test it out later tonight. Out of curiousity though, why do you ask? Is it related to t

Re: [Mesa-dev] [PATCH] rtasm: deal with size overflows by casting to ptrdiff_t

Does Nouveau still work if you report PIPE_CAP_USER_VERTEX_BUFFERS = 0? Marek On Wed, Jan 22, 2014 at 3:37 AM, Ilia Mirkin wrote: > This was discovered as a result of the draw-elements-base-vertex-neg > piglit test, which passes very negative offsets in, followed up by large > indices. The nouve

[Mesa-dev] [PATCH 16/22] radeonsi: inline si_translate_index_buffer

From: Marek Olšák --- src/gallium/drivers/radeonsi/Makefile.sources | 1 - src/gallium/drivers/radeonsi/si_pipe.h| 5 --- src/gallium/drivers/radeonsi/si_state_draw.c | 20 +- src/gallium/drivers/radeonsi/si_translate.c | 53 --- 4 files changed, 19 i

[Mesa-dev] [PATCH 09/22] r600g, radeonsi: consolidate get_name and get_vendor queries

From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 45 src/gallium/drivers/radeon/r600_pipe_common.c | 50 +++ src/gallium/drivers/radeonsi/si_pipe.c| 29 3 files changed, 50 insertions(+), 74 deletions(

[Mesa-dev] [PATCH 19/22] radeonsi: remove si_resource.h

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 1 - src/gallium/drivers/radeonsi/si_pipe.c| 1 - src/gallium/drivers/radeonsi/si_pipe.h| 14 +++- src/gallium/drivers/radeonsi/si_resource.h| 47 --- 4 files changed, 13 inser

[Mesa-dev] [PATCH 03/22] r600g: convert query emission code to radeon_emit

From: Marek Olšák --- src/gallium/drivers/radeon/r600_query.c | 100 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index 14e8427..bf73a14 100644 --- a/src/gallium

[Mesa-dev] [PATCH 22/22] radeonsi: cleanup includes, add missing license

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c| 5 ++--- src/gallium/drivers/radeonsi/si_commands.c| 1 - src/gallium/drivers/radeonsi/si_compute.c | 25 +++ src/gallium/drivers/radeonsi/si_descriptors.c | 1 + src/gallium/drivers/radeonsi/si_

[Mesa-dev] [PATCH 08/22] radeon: place context-related functions first in r600_pipe_common.c

From: Marek Olšák To follow the unwritten convention of r600g and radeonsi. --- src/gallium/drivers/radeon/r600_pipe_common.c | 166 ++ 1 file changed, 87 insertions(+), 79 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/rad

[Mesa-dev] [PATCH 11/22] r600g, radeonsi: consolidate variables for CS tracing

From: Marek Olšák --- src/gallium/drivers/r600/r600_hw_context.c| 6 +++--- src/gallium/drivers/r600/r600_pipe.c | 18 +- src/gallium/drivers/r600/r600_pipe.h | 5 + src/gallium/drivers/r600/r600_state_common.c | 8 src/gallium/drivers/radeo

[Mesa-dev] [PATCH 07/22] r600g, radeonsi: consolidate the contents of r600_resource.c

From: Marek Olšák --- src/gallium/drivers/r600/Makefile.sources | 1 - src/gallium/drivers/r600/r600_pipe.c | 13 - src/gallium/drivers/r600/r600_pipe.h | 3 -- src/gallium/drivers/r600/r600_resource.c | 76 --- src/gallium/drivers/r600/r6

[Mesa-dev] [PATCH 06/22] radeonsi: advertise the pipeline statistics query

From: Marek Olšák Implemented by the common code. You can now visualize the statistics with the HUD, see GALLIUM_HUD=help for all available queries. For example: GALLIUM_HUD=clipper-primitives-generated --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[Mesa-dev] [PATCH 17/22] radeonsi: move si_upload_const_buffer to a better place

From: Marek Olšák This gets rid of another file. --- src/gallium/drivers/radeonsi/Makefile.sources | 1 - src/gallium/drivers/radeonsi/si_buffer.c | 63 --- src/gallium/drivers/radeonsi/si_descriptors.c | 27 src/gallium/drivers/radeonsi/si_resource.h

[Mesa-dev] [PATCH 14/22] r600g, radeonsi: consolidate remaining obviously duplicated pipe_screen code

From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 35 ++- src/gallium/drivers/radeon/r600_pipe_common.c | 24 +++--- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeonsi/si_pipe.c| 26 +

[Mesa-dev] [PATCH 15/22] radeonsi: inline si_upload_index_buffer

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_buffer.c | 7 --- src/gallium/drivers/radeonsi/si_pipe.h | 5 - src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_buffer.c

[Mesa-dev] [PATCH 04/22] r600g: remove a no-op while loop

From: Marek Olšák for (;;) { } while (); I was surprised to see such a statement. --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index bf73a14..91

[Mesa-dev] [PATCH 20/22] radeonsi: move some inline functions from si_pipe.h to si_state.c

From: Marek Olšák And si_tex_aniso_filter is unused. --- src/gallium/drivers/radeonsi/si_pipe.h | 39 - src/gallium/drivers/radeonsi/si_state.c | 30 + 2 files changed, 30 insertions(+), 39 deletions(-) diff --git a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 21/22] radeonsi: remove open-coded PS_PARTIAL_FLUSH event

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_hw_context.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si_hw_context.c index bb3d080..2e1e9f2 100644 --- a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 05/22] radeonsi: use queries from r600g

From: Marek Olšák --- src/gallium/drivers/radeonsi/Makefile.sources | 1 - src/gallium/drivers/radeonsi/si.h | 45 --- src/gallium/drivers/radeonsi/si_blit.c| 22 +- src/gallium/drivers/radeonsi/si_hw_context.c | 525 +- src/gallium/drivers/radeon

[Mesa-dev] [PATCH 13/22] r600g, radeonsi: consolidate get_compute_param

From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 162 -- src/gallium/drivers/r600/r600_pipe.h | 3 - src/gallium/drivers/radeon/r600_pipe_common.c | 157 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/g

[Mesa-dev] [PATCH 18/22] radeonsi: remove si.h

From: Marek Olšák --- src/gallium/drivers/radeonsi/si.h | 43 -- src/gallium/drivers/radeonsi/si_pipe.c | 1 - src/gallium/drivers/radeonsi/si_pipe.h | 6 - 3 files changed, 5 insertions(+), 45 deletions(-) delete mode 100644 src/gallium/drivers/radeon

[Mesa-dev] [PATCH 10/22] r600g, radeonsi: consolidate get_timestamp, get_driver_query_info

From: Marek Olšák This enables more queries for the Gallium HUD with radeonsi. --- src/gallium/drivers/r600/r600_pipe.c | 32 -- src/gallium/drivers/radeon/r600_pipe_common.c | 33 +++ src/gallium/drivers/radeonsi/si_pipe.c| 9 ---

[Mesa-dev] [PATCH 12/22] r600g, radeonsi: consolidate get_paramf and get_video_param

From: Marek Olšák radeonsi now reports PIPE_VIDEO_CAP_SUPPORTS_PROGRESSIVE = true if UVD support isn't available. It's what all the other drivers do. Also, some #include directives were missing in radeon_uvd.h. --- src/gallium/drivers/r600/r600_pipe.c | 64 - sr

[Mesa-dev] [PATCH 02/22] r600g: only emit NOP relocations for queries if VM is disabled

From: Marek Olšák --- src/gallium/drivers/radeon/r600_cs.h| 14 ++ src/gallium/drivers/radeon/r600_query.c | 14 +- src/gallium/drivers/radeon/r600_streamout.c | 14 -- 3 files changed, 19 insertions(+), 23 deletions(-) diff --git a/src/gallium/dr

[Mesa-dev] [PATCH] i965: Replace *_generator::shader with is_glsl boolean.

The "shader" field in fs_generator, vec4_generator, and gen8_generator was only used for one purpose; to figure out if we were compiling an assembly shader or a GLSL shader. And it wasn't being used properly: in vec4 shaders we were always initializing it based on prog->_LinkedShaders[MESA_SHADER_

[Mesa-dev] Can we commit the Spanish and Catalan translations?

Hi, It's been a week and no new concerns have been raised with the proposed Spanish and Catalan translations: http://lists.freedesktop.org/archives/mesa-dev/2014-January/051610.html http://lists.freedesktop.org/archives/mesa-dev/2014-January/051611.html http://lists.freedesktop.org/archives/mesa-

Re: [Mesa-dev] [PATCH V3 7/8] glsl: remove remaining is_array variables

On 22 January 2014 03:33, Timothy Arceri wrote: > Previously the reason we needed is_array was because we used array_size == > NULL to > represent both non-arrays and unsized arrays. Now that we use a non-NULL > array_specifier to represent an unsized array, is_array is redundant. > > Signed-off

Re: [Mesa-dev] [PATCH 1/4] radeon / r200: Fix incompatible pointer type warning

On Mon, Jan 20, 2014 at 2:26 PM, Ian Romanick wrote: > From: Ian Romanick > > When parameters were removed from dd_function_table::Viewport (commit > 065bd6ff), radeon_viewport (in both radeon and r200) started generating > a warning. > > radeon_common.c: In function 'r200_radeon_viewport': > rad

Re: [Mesa-dev] [v2 23/23] i965/blorp: switch eu-emitter to use FS IR and fs_generator

On 22 January 2014 09:17, Topi Pohjolainen wrote: > No regressions on IVB (piglit quick + unit tests). > > v2 (Paul): > - no need to patch the unit tests anymore. Original logic > was altered and unit tests updated to match the > fs-generator > - lrp emission moves from the blorp compi

Re: [Mesa-dev] [PATCH 1/2] mesa: Ensure that transform feedback refers to the correct program.

On 22 January 2014 08:20, Kenneth Graunke wrote: > On 01/22/2014 06:07 AM, Paul Berry wrote: > > @@ -376,25 +376,48 @@ _mesa_compute_max_transform_feedback_vertices( > > **/ > > > > > > +/** > > + * Figure out which stage of the pipeline is the source of transform > feedback > > + * data given

[Mesa-dev] [PATCH RFC 03/11] glsl: add a foreach_list_reverse macro

--- src/glsl/list.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index 694b686..2de20c3 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -383,6 +383,11 @@ inline void exec_node::insert_before(exec_list *before) ; (__node)->next != NULL

[Mesa-dev] [PATCH RFC 11/11] glsl: convert to and from SSA form in the compiler

This patch is mainly for allowing me to test these changes with piglit. In the future, a do_ssa_optimizations() function will need to be created and used by this code, as well as all other users of do_common_optimizations(). --- src/glsl/glsl_parser_extras.cpp | 4 1 file changed, 4 insertion

[Mesa-dev] [PATCH RFC 08/11] glsl: add ssa_assign() to ir_builder

ssa_assign() creates an SSA variable and assignment at the same time. With this, simple sequences of SSA statements can be easily created. --- src/glsl/ir_builder.cpp | 14 ++ src/glsl/ir_builder.h | 1 + 2 files changed, 15 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/

[Mesa-dev] [PATCH RFC 02/11] glsl: add as_loop_jump() method to ir_instruction

This will let us dynamically downcast to ir_loop_jump, which will be needed later. --- src/glsl/ir.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index 19e8383..d1e790d 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -138,6 +138,7 @@ public: virtual

[Mesa-dev] [PATCH RFC 00/11] glsl: add Single Static Assignment (SSA)

This series enables GLSL IR support for SSA, including passes to convert to and from SSA form. SSA is a form of the intermediate representation of a compiler in which each variable is assigned exactly once. SSA form makes many optimizations faster and easier to write, and enables other more powerfu

  1   2   >