Re: [Mesa-dev] [PATCH] Gallium/dri2: Fix dri2_dup_image

2014-01-31 Thread Axel Davy
On 31/01/2014, Michel Dänzer wrote : On Don, 2014-01-30 at 16:10 +0100, Axel Davy wrote: dri2_dup_image was not copying the dri_format field. This was causing some bugs, for example: . we create an gbm_bo. . we get an EGLImage from the gbm_bo. . Bug: impossible to get again the gbm_bo from the

Re: [Mesa-dev] [PATCH 1/2] glcpp: Allow integer expression for #line directive.

2014-01-31 Thread Kenneth Graunke
On 01/29/2014 02:15 PM, Carl Worth wrote: Carl Worth cwo...@cworth.org writes: Matt Turner matts...@gmail.com writes: LINE_EXPANDED expression expression NEWLINE Yes. Thanks for the catch. I'll expand the testing and follow up with a new set of patches. Except that that's totally bogus.

Re: [Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

2014-01-31 Thread Kenneth Graunke
On 01/30/2014 02:24 PM, Carl Worth wrote: Matt Turner matts...@gmail.com writes: +if (parser-version_resolved) { +glcpp_error( @1, parser, #version after version is resolved); The phrasing after version is resolved makes a lot of sense from the point-of-view

[Mesa-dev] [PATCH] i965: Drop need_workaround_flush flag; always do post-sync workaround.

2014-01-31 Thread Kenneth Graunke
The need_workaround_flush flag was an attempt to avoid doing the post-sync non-zero workaround flush unless it was actually necessary. Getting the tracking right is tricky; we've messed it up several times. The cost of getting this wrong is high: almost certainly a GPU hang. The cost of always

Re: [Mesa-dev] [PATCH] st/dri: Fix tests for no draw/read buffers in dri_make_current()

2014-01-31 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Jan 31, 2014 at 4:15 AM, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com Fixes piglit glx/GLX_ARB_create_context/current with no framebuffer. Signed-off-by: Michel Dänzer michel.daen...@amd.com

Re: [Mesa-dev] [PATCH 1/3] dri: Require libudev-dev for building DRI on Linux.

2014-01-31 Thread Lauri Kasanen
On Thu, 30 Jan 2014 10:46:21 -0800 Eric Anholt e...@anholt.net wrote: The loader infrastructure for everything but DRI2 requires that udev be present, so we can figure out an appropriate driver from the fd. We don't have a portable solution yet, but presumably it will similar lookup based on

Re: [Mesa-dev] [PATCH 1/3] dri: Require libudev-dev for building DRI on Linux.

2014-01-31 Thread Lauri Kasanen
On Fri, 31 Jan 2014 12:16:05 +0200 Lauri Kasanen c...@gmx.com wrote: On Thu, 30 Jan 2014 10:46:21 -0800 Eric Anholt e...@anholt.net wrote: The loader infrastructure for everything but DRI2 requires that udev be present, so we can figure out an appropriate driver from the fd. We don't

[Mesa-dev] [PATCH] loader: Allow a non-udev linux fallback

2014-01-31 Thread Lauri Kasanen
It's important not to break existing uses. There is no need to require udev for 3d. This is an alternative to Stéphane Marchesin's patch loader: Make drmGetVersion logic conditional on non-pci devices. Signed-off-by: Lauri Kasanen c...@gmx.com --- src/egl/drivers/dri2/platform_android.c

[Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Colin Harrison
Hi, I can get a crash without this change (now _mesa_align_malloc is being used for buffer object data) --- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 + +++ ./src/mesa/main/bufferobj.c 2014-01-31 11:01:26.164078585 + @@ -407,7 +407,7 @@

Re: [Mesa-dev] [PATCH 09/13] r300g, r600g, radeonsi: add support for ARB_buffer_storage

2014-01-31 Thread Marek Olšák
I think we always flush the HDP cache after (before?) command submission. This patch adds nothing new to the drivers - we have always had persistent buffer mappings for all buffers and it has always worked. The only thing this does is that persistent mappings are now also supported by Gallium and

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Siavash Eliasi
Hello, I'm responsible for the caused inconvenience. I forgot to use _mesa_align_free to clean up the allocated memory blocked using _mesa_align_malloc. Good catch and thanks for the patch! :) On POSIX aligned allocated memory (using posix_memalign) should be freed using ordinary free() and I

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Siavash Eliasi
Hello, on which OS is this happening? On 01/31/2014 02:38 PM, Colin Harrison wrote: Hi, I can get a crash without this change (now _mesa_align_malloc is being used for buffer object data) --- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 + +++

Re: [Mesa-dev] [PATCH 10/13] gallium: the other drivers don't support ARB_buffer_storage

2014-01-31 Thread Marek Olšák
Hi Roland, The persistent and coherent flags are only for buffers. It's unfortunate that buffer and texture transfers share the same interface, because their implementation is vastly different in hardware drivers. For textures, we only need 3 modes of transfers: read, readwrite, and

Re: [Mesa-dev] Question about OSMesa

2014-01-31 Thread Brian Paul
On 01/28/2014 03:49 AM, Muhammad Al-Adly wrote: Does OSMesa support OpenGL versions higher than GL1? Yes. If it does, how can I make it work? You should get a GL 2.1 context without doing anything special. -Brian ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] loader: Allow a non-udev linux fallback

2014-01-31 Thread Kenneth Graunke
On 01/31/2014 03:14 AM, Lauri Kasanen wrote: It's important not to break existing uses. There is no need to require udev for 3d. This is an alternative to Stéphane Marchesin's patch loader: Make drmGetVersion logic conditional on non-pci devices. Signed-off-by: Lauri Kasanen c...@gmx.com

Re: [Mesa-dev] [PATCH RFC 10/11] glsl: add a pass to convert out of SSA form

2014-01-31 Thread Paul Berry
On 22 January 2014 09:16, Connor Abbott cwabbo...@gmail.com wrote: Right now we are being basically as naive as possible, and inserting more copies than necessary. It is possible to implement a more sophisticated algorithm later, although extending the current copy propagation pass to support

[Mesa-dev] [Bug 74166] piglit CorrectVersion1.V110 regression regression

2014-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74166 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Brian Paul
On 01/31/2014 04:08 AM, Colin Harrison wrote: Hi, I can get a crash without this change (now _mesa_align_malloc is being used for buffer object data) --- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 + +++ ./src/mesa/main/bufferobj.c 2014-01-31 11:01:26.164078585 +

Re: [Mesa-dev] [PATCH 09/13] r300g, r600g, radeonsi: add support for ARB_buffer_storage

2014-01-31 Thread Alex Deucher
On Fri, Jan 31, 2014 at 7:05 AM, Marek Olšák mar...@gmail.com wrote: I think we always flush the HDP cache after (before?) command submission. The kernel flushes the HDP cache in the fence command sequence. Alex This patch adds nothing new to the drivers - we have always had persistent

Re: [Mesa-dev] [PATCH RFC 00/11] glsl: add Single Static Assignment (SSA)

2014-01-31 Thread Paul Berry
On 22 January 2014 09:16, Connor Abbott cwabbo...@gmail.com wrote: This series enables GLSL IR support for SSA, including passes to convert to and from SSA form. SSA is a form of the intermediate representation of a compiler in which each variable is assigned exactly once. SSA form makes many

Re: [Mesa-dev] [PATCH 2/2] pipe-loader: Add support for render nodes v2

2014-01-31 Thread Tom Stellard
On Thu, Jan 30, 2014 at 10:16:41PM +, Emil Velikov wrote: On 27/01/14 16:13, Tom Stellard wrote: From: Tom Stellard thomas.stell...@amd.com v2: - Add missing call to pipe_loader_drm_release() - Fix render node macros - Drop render-node configure option --- For

[Mesa-dev] [PATCH 2/2] glsl: Fix continue statements in do-while loops.

2014-01-31 Thread Paul Berry
From the GLSL 4.40 spec, section 6.4 (Jumps): The continue jump is used only in loops. It skips the remainder of the body of the inner most loop of which it is inside. For while and do-while loops, this jump is to the next evaluation of the loop condition-expression from which the

[Mesa-dev] [PATCH 1/2] glsl: Make condition_to_hir() callable from outside ast_iteration_statement.

2014-01-31 Thread Paul Berry
In addition to making it public, we also need to change its first argument from an ir_loop * to an exec_list *, so that it can be used to insert the condition anywhere in the IR (rather than just in the body of the loop). This will be necessary in order to make continue statements work properly

Re: [Mesa-dev] [PATCH] configure: Enable large file support for the 32-bit platforms

2014-01-31 Thread Carl Worth
Lauri Kasanen c...@gmx.com writes: 32-bit use is on the increase due to Steam; avoid any surprises and make Mesa LFS-aware. ... AC_PROG_MKDIR_P +AC_SYS_LARGEFILE Hi Lauri, Can you describe a bit more what failure modes you encounter without AC_SYS_LARGEFILE in place? I just haven't dealt

Re: [Mesa-dev] [PATCH] glsl: Expand non-expr non-swizzle scalar rvalues in vectorizing.

2014-01-31 Thread Carl Worth
Matt Turner matts...@gmail.com writes: --- src/glsl/opt_vectorize.cpp | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) Hi Matt, I'm missing the rest of your commit message besides the one-line summary. I think the discipline of always typing _something_ there is

Re: [Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

2014-01-31 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: I missed this change in commit f5cfb4a. It fixes the incorrect rendering caused in Dolphin Emulator. It's too late for my review to change anything, but since I was recently adding this commit (and the previous one being touched-up here) to my ignore

Re: [Mesa-dev] [PATCH 3/3] i965: Use brw_bo_map[_gtt]() in intel_miptree_map_raw().

2014-01-31 Thread Carl Worth
Kenneth Graunke kenn...@whitecape.org writes: This code is strange anyway; the typical paradigm is to check whether the batch references the buffer, flush it if so, and then check whether it's busy. I really like the series. So, thanks! As far as your comment here, am I understanding that the

Re: [Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

2014-01-31 Thread Anuj Phogat
On Fri, Jan 31, 2014 at 12:55 PM, Carl Worth cwo...@cworth.org wrote: Anuj Phogat anuj.pho...@gmail.com writes: I missed this change in commit f5cfb4a. It fixes the incorrect rendering caused in Dolphin Emulator. It's too late for my review to change anything, but since I was recently adding

Re: [Mesa-dev] [PATCH v2 1/7] glsl: parse invocations layout qualifier for ARB_gpu_shader5

2014-01-31 Thread Paul Berry
On 28 January 2014 11:22, Jordan Justen jordan.l.jus...@intel.com wrote: _mesa_glsl_parse_state::gs_invocations will store the invocation count. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com This looks like it will work if the shader contains a line like this: layout(triangles,

Re: [Mesa-dev] [PATCH v2 2/7] glsl/linker: produce gl_shader_program Geom.Invocations

2014-01-31 Thread Paul Berry
On 28 January 2014 11:22, Jordan Justen jordan.l.jus...@intel.com wrote: Grab the parsed invocation count, check for consistency during linking, and finally save the result in gl_shader_program Geom.Invocations. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com ---

Re: [Mesa-dev] [PATCH 3/3] i965: Use brw_bo_map[_gtt]() in intel_miptree_map_raw().

2014-01-31 Thread Kenneth Graunke
On 01/31/2014 01:45 PM, Carl Worth wrote: Kenneth Graunke kenn...@whitecape.org writes: This code is strange anyway; the typical paradigm is to check whether the batch references the buffer, flush it if so, and then check whether it's busy. I really like the series. So, thanks! As far as

Re: [Mesa-dev] [PATCH v2 4/7] main/shaderapi: GL_GEOMETRY_SHADER_INVOCATIONS GetProgramiv support

2014-01-31 Thread Paul Berry
On 28 January 2014 11:22, Jordan Justen jordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/main/shaderapi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index

Re: [Mesa-dev] [PATCH v2 6/7] i965: support gl_InvocationID for gen7

2014-01-31 Thread Paul Berry
On 28 January 2014 11:22, Jordan Justen jordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_defines.h | 5 + src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 24 --- 2 files changed,

[Mesa-dev] [Bug 69101] prime: black window

2014-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69101 --- Comment #17 from Christoph Haag haagch.christ...@googlemail.com --- Well, some people here talk about PRIME not working with compositing, some people are talking about PRIME having some issues with OpenGL compositing. The second one is still

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl: Fix continue statements in do-while loops.

2014-01-31 Thread Carl Worth
Paul Berry stereotype...@gmail.com writes: This patch fixes the problem by replicating the loop condition when converting the continue statement to IR. (We already do a similar thing in for loops, to ensure that continue causes the loop expression to be executed). Nice fix, Paul. Thanks.

[Mesa-dev] [PATCH 4/6] st/mesa: use _mesa_get_current_tex_object() in st_context_teximage()

2014-01-31 Thread Brian Paul
--- src/mesa/state_tracker/st_manager.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index b7757e9..215b276 100644 --- a/src/mesa/state_tracker/st_manager.c +++

[Mesa-dev] [PATCH 2/6] radeon: use _mesa_get_current_tex_object() in radeonSetTexBuffer2()

2014-01-31 Thread Brian Paul
--- src/mesa/drivers/dri/radeon/radeon_texstate.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_texstate.c b/src/mesa/drivers/dri/radeon/radeon_texstate.c index 66daccf..dac8aed 100644 ---

[Mesa-dev] [PATCH 6/6] mesa: remove unused _mesa_select_tex_object() function

2014-01-31 Thread Brian Paul
The _mesa_get_current_tex_object() function is now used everywhere that _mesa_select_tex_object() was formerly used. --- src/mesa/main/teximage.c | 28 ++-- src/mesa/main/teximage.h |5 - 2 files changed, 6 insertions(+), 27 deletions(-) diff --git

[Mesa-dev] [PATCH 1/6] r200: use _mesa_get_current_tex_object() in r200SetTexBuffer2()

2014-01-31 Thread Brian Paul
--- src/mesa/drivers/dri/r200/r200_texstate.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/r200/r200_texstate.c b/src/mesa/drivers/dri/r200/r200_texstate.c index 5160c2c..c3c92cb 100644 --- a/src/mesa/drivers/dri/r200/r200_texstate.c +++

[Mesa-dev] [PATCH 3/6] mesa: use _mesa_get_current_tex_object() in GetTexLevelParameteriv()

2014-01-31 Thread Brian Paul
And update a related comment. --- src/mesa/main/texparam.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index e915ddd..9362cf84 100644 --- a/src/mesa/main/texparam.c +++ b/src/mesa/main/texparam.c @@ -118,8

[Mesa-dev] [PATCH 5/6] swrast: use _mesa_get_current_tex_object() in swrastSetTexBuffer2()

2014-01-31 Thread Brian Paul
--- src/mesa/drivers/dri/swrast/swrast.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/swrast/swrast.c b/src/mesa/drivers/dri/swrast/swrast.c index 48b07bd..071192c 100644 --- a/src/mesa/drivers/dri/swrast/swrast.c +++

[Mesa-dev] [PATCH] mesa: make _mesa_get_proxy_target() static

2014-01-31 Thread Brian Paul
Wasn't used in any other file. --- src/mesa/main/teximage.c | 10 +- src/mesa/main/teximage.h |3 --- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 508d546..6f84b38 100644 --- a/src/mesa/main/teximage.c +++

[Mesa-dev] [PATCH 1/2] svga: refactor some shader code

2014-01-31 Thread Brian Paul
Put common code in new svga_shader.c file. Considate separate vertex/ fragment shader ID generation. --- src/gallium/drivers/svga/Makefile.sources |1 + src/gallium/drivers/svga/svga_context.c | 19 ++ src/gallium/drivers/svga/svga_context.h |3 +-

[Mesa-dev] [PATCH 2/2] svga: check shader size against max command buffer size

2014-01-31 Thread Brian Paul
If the shader is too large, plug in a dummy shader. This patch also reworks the existing dummy shader code. --- src/gallium/drivers/svga/include/svga_reg.h |1 + src/gallium/drivers/svga/svga_state_fs.c| 60 +-- 2 files changed, 49 insertions(+), 12 deletions(-)

[Mesa-dev] [PATCH] gallium/auxiliary/indices: replace free() with FREE()

2014-01-31 Thread Brian Paul
To match the CALLOC_STRUCT() call. --- src/gallium/auxiliary/indices/u_primconvert.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/indices/u_primconvert.c b/src/gallium/auxiliary/indices/u_primconvert.c index 14da7a6..f2a77ce 100644 ---

[Mesa-dev] Stable 10.0 branch updated for imminent release

2014-01-31 Thread Carl Worth
I've just pushed out several updates to the 10.0 branch. This branch passes my testing, and unless I hear of some problem over the weekend, I'll plan to make a 10.0.3 release from this branch Monday morning. I believe that I've included all of the commits on the master branch since 10.0.2 that

[Mesa-dev] [PATCH] mesa: remove target param from ctx-Driver.TexParameter()

2014-01-31 Thread Brian Paul
Not really used anywhere. --- src/mesa/drivers/dri/nouveau/nouveau_state.c |2 +- src/mesa/drivers/dri/r200/r200_tex.c |5 ++--- src/mesa/drivers/dri/radeon/radeon_tex.c |2 +- src/mesa/main/dd.h |2 +- src/mesa/main/texobj.c

[Mesa-dev] [PATCH] mesa: don't signal _NEW_TEXTURE in TexSubImage() functions

2014-01-31 Thread Brian Paul
glTexSubImage(), glCopyTexSubImage() and glCompressedTexSubImage() only change the texel data, not other state like texture size or format. If a driver really needs do something special it can hook into the corresponding driver functions or Map/UnmapTextureImage(). This should avoid some needless

Re: [Mesa-dev] Stable 10.0 branch updated for imminent release

2014-01-31 Thread Matt Turner
We definitely want to apply glx: Update glxext.h to revision 24777. in time for the next 10.0 release. It fixes a really annoying problem with the GL headers that make distributions lives awful. I sent this to mesa-stable@ on the 25th. It's a slightly different than what's on master due to some

Re: [Mesa-dev] [PATCH 1/4] i965: Remove poorly implemented math hstride assertions.

2014-01-31 Thread Kenneth Graunke
On 01/23/2014 01:13 PM, Kenneth Graunke wrote: I added this assertion in the last revision of the gen8_fs_generator patch, and apparently didn't test it enough. Many Piglit tests fail this test. The destination hstride is 1, while the source hstride and vstride appear to be 0. This sounds

Re: [Mesa-dev] [PATCH v2 7/7] i965: support instanced GS on gen7

2014-01-31 Thread Paul Berry
On 28 January 2014 11:22, Jordan Justen jordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_vec4_gs.c

Re: [Mesa-dev] [PATCH 1/3] dri: Require libudev-dev for building DRI on Linux.

2014-01-31 Thread Keith Packard
Lauri Kasanen c...@gmx.com writes: Forgot to mention, this would appear to make 3d impossible without udev (ie, static devices, mdev, or other solutions). No, DRI2 continues to fall back to using the driver provided by the X server if it can't find one locally. -- keith.pack...@intel.com