[Mesa-dev] [PATCH] nv50: enable txg where supported

2014-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This applies on top of Dave Airlie's r600g-texture-gather branch. Ran piglit with -t gather, passed all 1057 tests. Can't say I fully understand what all the arguments to handleTEX in the Coverter are but... seems to work. Will probably require some care for nvc0 su

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Create a hardware context before initializing state module.

2014-02-19 Thread Kenneth Graunke
On 02/19/2014 06:05 PM, Ian Romanick wrote: > On 02/19/2014 05:40 PM, Kenneth Graunke wrote: >> brw_init_state() calls brw_upload_initial_gpu_state(). If hardware >> contexts are enabled (brw->hw_ctx != NULL), this will upload some >> initial invariant state for the GPU. Without hardware contexts

Re: [Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

2014-02-19 Thread Chia-I Wu
On Thu, Feb 20, 2014 at 7:03 AM, Kenneth Graunke wrote: > On 02/19/2014 02:27 PM, Ian Romanick wrote: >> On 02/19/2014 12:08 PM, Kenneth Graunke wrote: >>> On 02/18/2014 09:48 PM, Chia-I Wu wrote: Since 73bc6061f5c3b6a3bb7a8114bb2e1ab77d23cfdb, Z16 support is not advertised for OpenGL ES

[Mesa-dev] [Bug 71870] Metro: Last Light rendering issues

2014-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71870 Tapani Pälli changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #46 from Tapani Päll

Re: [Mesa-dev] [PATCH 11/13] i965: Enable smooth points when multisampling without point sprites.

2014-02-19 Thread Roland Scheidegger
Am 19.02.2014 11:04, schrieb Kenneth Graunke: > According to the "Point Multisample Rasterization" of the OpenGL > specification (3.0 or later), smooth points are supposed to be enabled > implicitly when multisampling, regardless of the GL_POINT_SMOOTH flag. > > However, if GL_POINT_SPRITE is enab

Re: [Mesa-dev] [PATCH 2/3] radeonsi: Use SI_BIG_ENDIAN now that it exists

2014-02-19 Thread Michel Dänzer
On Mit, 2014-02-19 at 15:09 -0800, Tom Stellard wrote: > --- > src/gallium/drivers/radeonsi/si_shader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/drivers/radeonsi/si_shader.c > index 54270cd..9fed751 100644 >

Re: [Mesa-dev] [PATCH 3/3] clover: Pass buffer offsets to the driver in set_global_binding() v2

2014-02-19 Thread Michel Dänzer
On Don, 2014-02-20 at 00:53 +0100, Francisco Jerez wrote: > Tom Stellard writes: > > > diff --git a/src/gallium/drivers/r600/evergreen_compute.c > > b/src/gallium/drivers/r600/evergreen_compute.c > > index 70efe5c..efd7143 100644 > > --- a/src/gallium/drivers/r600/evergreen_compute.c > > +++ b/s

Re: [Mesa-dev] [PATCH 1/3] util: Add util_bswap64()

2014-02-19 Thread Michel Dänzer
On Mit, 2014-02-19 at 15:09 -0800, Tom Stellard wrote: > --- > src/gallium/auxiliary/util/u_math.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_math.h > b/src/gallium/auxiliary/util/u_math.h > index b5e0663..49f8bda 100644 > --- a/src/gallium/

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Create a hardware context before initializing state module.

2014-02-19 Thread Ian Romanick
On 02/19/2014 05:40 PM, Kenneth Graunke wrote: > brw_init_state() calls brw_upload_initial_gpu_state(). If hardware > contexts are enabled (brw->hw_ctx != NULL), this will upload some > initial invariant state for the GPU. Without hardware contexts, we > rely on this state being uploaded via atom

Re: [Mesa-dev] [PATCH][RFC] dri3: Add support for the GLX_EXT_buffer_age extension

2014-02-19 Thread Ian Romanick
On 02/19/2014 02:49 PM, Adel Gadllah wrote: > Hi, > > The attached patch adds support for the GLX_EXT_buffer_age extension, > which is mostly used by compositors for efficient sub screen updates. > > The extension should not be reported as supported when running DRI2 but > it seems to show up whe

[Mesa-dev] [PATCH] i965: Create a hardware context before initializing state module.

2014-02-19 Thread Kenneth Graunke
brw_init_state() calls brw_upload_initial_gpu_state(). If hardware contexts are enabled (brw->hw_ctx != NULL), this will upload some initial invariant state for the GPU. Without hardware contexts, we rely on this state being uploaded via atoms that subscribe to the BRW_NEW_CONTEXT bit. Commit 46

[Mesa-dev] [PATCH 4/6] meta: Save and restore a bunch of MSAA state.

2014-02-19 Thread Eric Anholt
We're disabling GL_MULTISAMPLE, so we didn't need to worry about a lot of that state. But to do MSAA to MSAA blits, we need to start handling more state. v2: Fix pasteo caught by Kenneth. --- src/mesa/drivers/common/meta.c | 40 +--- src/mesa/drivers/common/me

[Mesa-dev] [PATCH 1/6] i965: Fix miptree matching for multisampled, non-interleaved miptrees.

2014-02-19 Thread Eric Anholt
We haven't been executing this code before the meta-blit case, because we've been flagging the miptree as validated at texstorage time, and never having to revalidate. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 ++ 2 f

[Mesa-dev] [PATCH 2/6] meta: Add support for doing multisample resolves.

2014-02-19 Thread Eric Anholt
Note that this doesn't handle GL_EXT_multisample_scaled_blit yet. The i965 code for that extension bakes in knowledge of the sample positions (well, knowledge of the sample positions aligned to a lower-resolution grid), which we would have to do at runtime somehow for meta. --- src/mesa/drivers/c

[Mesa-dev] [PATCH 3/6] meta: Try to do blending of sRGB values in linear colorspace.

2014-02-19 Thread Eric Anholt
Blending of values would occur when doing GL_LINEAR filtering with scaling, and in an upcoming commit when doing MSAA resolves. --- src/mesa/drivers/common/meta_blit.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/common/meta_b

[Mesa-dev] [PATCH 6/6] meta: Add support for integer blits.

2014-02-19 Thread Eric Anholt
Compared to i965, the code generated doesn't use the AVG instruction. But I'm not sure that multisampled integer resolves are really that important to worry about. --- src/mesa/drivers/common/meta.h | 10 ++ src/mesa/drivers/common/meta_blit.c | 68 +

[Mesa-dev] [PATCH 5/6] meta: Add support for doing MSAA to MSAA blits.

2014-02-19 Thread Eric Anholt
These are non-stretched, non-resolving blits, so it's just a matter of sampling once from our gl_SampleID and storing that to our color/depth. --- src/mesa/drivers/common/meta.h | 6 +- src/mesa/drivers/common/meta_blit.c | 147 2 files changed, 104 inse

Re: [Mesa-dev] [PATCH] i965: Implement a CS stall workaround on Broadwell.

2014-02-19 Thread Ian Romanick
Reviewed-by: Ian Romanick On 02/19/2014 04:28 PM, Kenneth Graunke wrote: > According to the latest documentation, any PIPE_CONTROL with the > "Command Streamer Stall" bit set must also have another bit set, > with five different options: > >- Render Target Cache Flush >- Depth Cache Flus

Re: [Mesa-dev] [PATCH][RFC] dri3: Add support for the GLX_EXT_buffer_age extension

2014-02-19 Thread Ilia Mirkin
On Wed, Feb 19, 2014 at 5:49 PM, Adel Gadllah wrote: > Hi, > > The attached patch adds support for the GLX_EXT_buffer_age extension, which > is mostly used by compositors for efficient sub screen updates. > > The extension should not be reported as supported when running DRI2 but it > seems to sho

[Mesa-dev] [PATCH] st/omx/enc: add multi scaling buffers for performance improvement

2014-02-19 Thread Leo Liu
From: Leo Liu Signed-off-by: Leo Liu --- src/gallium/state_trackers/omx/vid_enc.c | 39 src/gallium/state_trackers/omx/vid_enc.h | 7 -- 2 files changed, 29 insertions(+), 17 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_enc.c b/src/gallium

Re: [Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

2014-02-19 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/19/2014 12:08 PM, Kenneth Graunke wrote: > On 02/18/2014 09:48 PM, Chia-I Wu wrote: >> Since 73bc6061f5c3b6a3bb7a8114bb2e1ab77d23cfdb, Z16 support is >> not advertised for OpenGL ES contexts due to the terrible >> performance. It is still enable

[Mesa-dev] [PATCH][RFC] dri3: Add support for the GLX_EXT_buffer_age extension

2014-02-19 Thread Adel Gadllah
Hi, The attached patch adds support for the GLX_EXT_buffer_age extension, which is mostly used by compositors for efficient sub screen updates. The extension should not be reported as supported when running DRI2 but it seems to show up when I try to disable it with LIBGL_DRI3_DISABLE ... not

Re: [Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

2014-02-19 Thread Darius Spitznagel
Am 19.02.2014 20:09, schrieb Ian Romanick: I'm hoping that Tapani or Darius will verify that this patch actually fixes the problem. That's why people CC other people on patches. :) On 02/18/2014 10:19 AM, Ian Romanick wrote: From: Ian Romanick Section 3.3 (Preprocessor) of the GLSL 1.30 spec

[Mesa-dev] [PATCH] i965: Implement a CS stall workaround on Broadwell.

2014-02-19 Thread Kenneth Graunke
According to the latest documentation, any PIPE_CONTROL with the "Command Streamer Stall" bit set must also have another bit set, with five different options: - Render Target Cache Flush - Depth Cache Flush - Stall at Pixel Scoreboard - Post-Sync Operation - Depth Stall I chose "St

Re: [Mesa-dev] [PATCH 3/3] clover: Pass buffer offsets to the driver in set_global_binding() v2

2014-02-19 Thread Francisco Jerez
Tom Stellard writes: > The offsets will be stored in the handles parameter. This makes > it possible to use sub-buffers. > > v2: > - Style fixes > - Add support for constant sub-buffers > - Store handles in device byte order > --- > src/gallium/drivers/r600/evergreen_compute.c | 10 +

Re: [Mesa-dev] [PATCH 1/3] util: Add util_bswap64()

2014-02-19 Thread Francisco Jerez
Tom Stellard writes: > --- > src/gallium/auxiliary/util/u_math.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_math.h > b/src/gallium/auxiliary/util/u_math.h > index b5e0663..49f8bda 100644 > --- a/src/gallium/auxiliary/util/u_math.h > +++ b/s

Re: [Mesa-dev] [PATCH 1/3] util: Add util_bswap64()

2014-02-19 Thread Matt Turner
On Wed, Feb 19, 2014 at 3:32 PM, Ilia Mirkin wrote: > On Wed, Feb 19, 2014 at 6:09 PM, Tom Stellard wrote: >> +/** >> + * Reverse byte order of a 64bit word. >> + */ >> +static INLINE uint64_t >> +util_bswap64(uint64_t n) >> +{ >> + return ((uint64_t)util_bswap32(n & 0x) << 32) | >> +

Re: [Mesa-dev] [PATCH 1/3] util: Add util_bswap64()

2014-02-19 Thread Ilia Mirkin
On Wed, Feb 19, 2014 at 6:09 PM, Tom Stellard wrote: > --- > src/gallium/auxiliary/util/u_math.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_math.h > b/src/gallium/auxiliary/util/u_math.h > index b5e0663..49f8bda 100644 > --- a/src/gallium/au

Re: [Mesa-dev] [PATCH 1/3] util: Add util_bswap64()

2014-02-19 Thread Alex Deucher
On Wed, Feb 19, 2014 at 6:09 PM, Tom Stellard wrote: > --- > src/gallium/auxiliary/util/u_math.h | 10 ++ > 1 file changed, 10 insertions(+) For the series: Reviewed-by: Alex Deucher > > diff --git a/src/gallium/auxiliary/util/u_math.h > b/src/gallium/auxiliary/util/u_math.h > index

[Mesa-dev] [PATCH 2/3] radeonsi: Use SI_BIG_ENDIAN now that it exists

2014-02-19 Thread Tom Stellard
--- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 54270cd..9fed751 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/gallium/drive

Re: [Mesa-dev] [PATCH 14/15] mesa/sso: Implement _mesa_ActiveShaderProgram

2014-02-19 Thread Ian Romanick
On 02/19/2014 01:44 PM, Jordan Justen wrote: > On Fri, Feb 7, 2014 at 10:00 PM, Ian Romanick wrote: >> From: Gregory Hainaut >> >> This was originally included in another patch, but it was split out by >> Ian Romanick. >> >> Reviewed-by: Ian Romanick >> --- >> src/mesa/main/pipelineobj.c | 24 +

[Mesa-dev] [PATCH 1/3] util: Add util_bswap64()

2014-02-19 Thread Tom Stellard
--- src/gallium/auxiliary/util/u_math.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index b5e0663..49f8bda 100644 --- a/src/gallium/auxiliary/util/u_math.h +++ b/src/gallium/auxiliary/util/u_math.h @@ -7

[Mesa-dev] [PATCH 3/3] clover: Pass buffer offsets to the driver in set_global_binding() v2

2014-02-19 Thread Tom Stellard
The offsets will be stored in the handles parameter. This makes it possible to use sub-buffers. v2: - Style fixes - Add support for constant sub-buffers - Store handles in device byte order --- src/gallium/drivers/r600/evergreen_compute.c | 10 +- src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 11/12] geom-outlining-150: Use core geometry shaders.

2014-02-19 Thread Fabian Bieler
Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/geom-outlining-150.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 0bc20f0..3dffa16 1

[Mesa-dev] [PATCH 08/12] glsl/gsraytrace: Use core geometry shaders.

2014-02-19 Thread Fabian Bieler
v2: Don't remove ShaderSupported() test. It sets up some function pointers for the CompileShader framework. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-)

[Mesa-dev] [PATCH 06/12] glsl/gsraytrace: Use core GL3.0 transform feedback

2014-02-19 Thread Fabian Bieler
NV_transform_feedback is not supported by mesa. Use transform feedback from core OpenGL 3.0. This necessitates binding the transform feedback varyings before linking the shader. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 72 +++

[Mesa-dev] [PATCH 07/12] glsl/gsraytrace: Use GLSL 1.5 instead of 1.2.

2014-02-19 Thread Fabian Bieler
This commit prepares the transition from extension to core geometry shaders. (Core geometry shaders require GLSL version 1.5 or later.) This includes using generic vertex attributes instead of built-ins. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/gls

[Mesa-dev] [PATCH 09/12] glsl/gsraytrace: Switch to core profile.

2014-02-19 Thread Fabian Bieler
v2: Remove redundant 'core' in GLSL version statement. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/sr

[Mesa-dev] [PATCH 01/12] configure.ac: Check for freeglut.

2014-02-19 Thread Fabian Bieler
To get an OpenGL core profile context freeglut 2.6 or later is required. Note that in spite of it's name HAVE_FREEGLUT is only defined if freeglut 2.6 (released in 2009) or later ist found. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- configure.ac | 6 +++

[Mesa-dev] [PATCH 12/12] geom-outlining-150: Switch to core profile.

2014-02-19 Thread Fabian Bieler
Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/geom-outlining-150.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 3dffa16..2e2a54a 100644 --- a/src/glsl/geom-out

[Mesa-dev] [PATCH 05/12] glsl/gsraytrace: Bind transform feedback buffer.

2014-02-19 Thread Fabian Bieler
Bind the transform feedback buffer before drawing into it und unbind it afterwards. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/gsraytrace.cpp b/src/gls

[Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-02-19 Thread Fabian Bieler
The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ "constant" takes care of this automatically. v2: Don't set source-string-number to line number. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 00/12] DEMOS Use core profile in two GS demos (v3).

2014-02-19 Thread Fabian Bieler
Hello! As mesa only supports geometry shaders in core profile contexts this patchset adjusts the gsraytrace and the geom-outlining-150 demos to use the core profile. This is v3 with some comments by Ian Romanick adressed. The series is reviewed by Brian Paul and Ian Romanick. As I don't have gi

[Mesa-dev] [PATCH 02/12] glut_wrapper: Include freeglut.h if available.

2014-02-19 Thread Fabian Bieler
The freeglut header only defines the extensions to request an OpenGL core profile context if freeglut.h (rather than glut.h) is included. Note that the header is installed to include/GL/freeglut.h on OS X, too. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick ---

[Mesa-dev] [PATCH 10/12] geom-outlining-150: Use a vbo.

2014-02-19 Thread Fabian Bieler
Use a vbo for vertex data instead of client-side arrays. Also bind a vertex array object. This is necessary for the switch to a core profile context. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/geom-outlining-150.c | 25 ++---

[Mesa-dev] [PATCH 04/12] glsl/gsraytrace: Don't create new Buffer objects everytime the window is resized.

2014-02-19 Thread Fabian Bieler
Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index c21c667..f156fdc 100644 --- a/src/glsl/gsraytrace.cpp +++ b/

Re: [Mesa-dev] [PATCH 09/13] i965: Only use the SIMD16 program for per-sample shading on Broadwell.

2014-02-19 Thread Kenneth Graunke
On 02/19/2014 01:32 PM, Anuj Phogat wrote: > On Wed, Feb 19, 2014 at 2:04 AM, Kenneth Graunke > wrote: >> This is a straight port from gen7_wm_state.c; I haven't looked into >> whether we can do both. >> > Verified that restriction still holds true in BDW. > See 3D Pipeline Stages > Pixel > Pixel

Re: [Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

2014-02-19 Thread Ian Romanick
On 02/19/2014 03:03 PM, Kenneth Graunke wrote: > Currently, all platforms have Z16 performance issues. On Haswell and > later, we could potentially implement the PMA stall optimization, which > I believe would reduce(?) the problem. I'm not sure if it would > eliminate it though. > > I think the

[Mesa-dev] [Bug 71870] Metro: Last Light rendering issues

2014-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71870 Ian Romanick changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/3] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-19 Thread Anuj Phogat
On Tue, Feb 18, 2014 at 5:28 PM, Ian Romanick wrote: > On 02/18/2014 03:36 PM, Anuj Phogat wrote: >> On Tue, Feb 18, 2014 at 11:01 AM, Ian Romanick wrote: >>> On 02/10/2014 05:29 PM, Anuj Phogat wrote: GLSL 1.50 spec says: "If gl_FragCoord is redeclared in any fragment shader in a pr

Re: [Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

2014-02-19 Thread Kenneth Graunke
On 02/19/2014 02:27 PM, Ian Romanick wrote: > On 02/19/2014 12:08 PM, Kenneth Graunke wrote: >> On 02/18/2014 09:48 PM, Chia-I Wu wrote: >>> Since 73bc6061f5c3b6a3bb7a8114bb2e1ab77d23cfdb, Z16 support is >>> not advertised for OpenGL ES contexts due to the terrible >>> performance. It is still ena

Re: [Mesa-dev] [PATCH] clover: Don't call pipe_loader_release() when deleting a device

2014-02-19 Thread Tom Stellard
On Tue, Feb 18, 2014 at 05:50:19PM +0100, Francisco Jerez wrote: > Tom Stellard writes: > > > From: Tom Stellard > > > > After pipe_loader_release() is called, if any of the pipe_* objects > > try to call into the gallium API the application will segfault. > > > > The only time devices are delet

Re: [Mesa-dev] OpenCL Supported extensions for R600/SI ?

2014-02-19 Thread Tom Stellard
On Wed, Feb 19, 2014 at 09:20:22PM +, Dorrington, Albert wrote: > Currently clGetDeviceInfo() returns an empty string when queried for > CL_DEVICE_EXTENSIONS. > > Looking through both the Mesa and LLVM/Clang code I see references to the > following extensions: > cl_khr_fp64 > cl_khr_int64_ba

Re: [Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

2014-02-19 Thread Eric Anholt
Kenneth Graunke writes: > On 02/18/2014 09:48 PM, Chia-I Wu wrote: >> Since 73bc6061f5c3b6a3bb7a8114bb2e1ab77d23cfdb, Z16 support is not advertised >> for OpenGL ES contexts due to the terrible performance. It is still enabled >> for desktop GL because it was believed GL 3.0+ requires Z16. >> >

Re: [Mesa-dev] [PATCH 00/15] The first half of GL_ARB_separate_shader_objects

2014-02-19 Thread Jordan Justen
I replied to 7 & 14. Series: Reviewed-by: Jordan Justen On Fri, Feb 7, 2014 at 10:00 PM, Ian Romanick wrote: > I'm taking a patch from Paul's notebook, and I'm going to try land a > giant patch series in a small number of more manageable chunks. > GL_ARB_separate_shader_objects has been work-in-

Re: [Mesa-dev] [PATCH 14/15] mesa/sso: Implement _mesa_ActiveShaderProgram

2014-02-19 Thread Jordan Justen
On Fri, Feb 7, 2014 at 10:00 PM, Ian Romanick wrote: > From: Gregory Hainaut > > This was originally included in another patch, but it was split out by > Ian Romanick. > > Reviewed-by: Ian Romanick > --- > src/mesa/main/pipelineobj.c | 24 > 1 file changed, 24 insertion

Re: [Mesa-dev] [PATCH 09/13] i965: Only use the SIMD16 program for per-sample shading on Broadwell.

2014-02-19 Thread Anuj Phogat
On Wed, Feb 19, 2014 at 2:04 AM, Kenneth Graunke wrote: > This is a straight port from gen7_wm_state.c; I haven't looked into > whether we can do both. > Verified that restriction still holds true in BDW. See 3D Pipeline Stages > Pixel > Pixel Shader Thread Generation > Pixel Grouping (Dispatch Si

Re: [Mesa-dev] [PATCH 01/13] i965: Simplify Broadwell's 3DSTATE_MULTISAMPLE sample count handling.

2014-02-19 Thread Anuj Phogat
On Wed, Feb 19, 2014 at 2:04 AM, Kenneth Graunke wrote: > These enumerations are simply log2 of the number of multisamples shifted > by a bit, so we can calculate them using ffs() in a lot less code. > > Suggested by Eric Anholt. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i9

[Mesa-dev] OpenCL Supported extensions for R600/SI ?

2014-02-19 Thread Dorrington, Albert
Currently clGetDeviceInfo() returns an empty string when queried for CL_DEVICE_EXTENSIONS. Looking through both the Mesa and LLVM/Clang code I see references to the following extensions: cl_khr_fp16 cl_khr_fp64 cl_khr_int64_base_atomics cl_khr_int64_extended_atomics cl_khr_gl_sha

Re: [Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

2014-02-19 Thread Kenneth Graunke
On 02/19/2014 11:09 AM, Ian Romanick wrote: > I'm hoping that Tapani or Darius will verify that this patch actually > fixes the problem. That's why people CC other people on patches. :) I have the game, and I can confirm that the lighting is awfully broken with master, and looks correct after thi

Re: [Mesa-dev] [PATCH 6/8] i965: Implement HiZ resolves on Broadwell.

2014-02-19 Thread Kenneth Graunke
On 02/19/2014 11:12 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> On 02/18/2014 01:38 PM, Eric Anholt wrote: >>> Kenneth Graunke writes: >> [snip] diff --git a/src/mesa/drivers/dri/i965/gen8_depth_state.c b/src/mesa/drivers/dri/i965/gen8_depth_state.c index f30ff28..3fa20

Re: [Mesa-dev] [PATCH 07/15] mesa/sso: Add pipeline container/state

2014-02-19 Thread Jordan Justen
On Fri, Feb 7, 2014 at 10:00 PM, Ian Romanick wrote: > From: Gregory Hainaut > > V1: > * Extend gl_shader_state as pipeline object state > * Add a new container gl_pipeline_shader_state that contains >binding point of the previous object > * Update mesa init/free shader state due to the exten

Re: [Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

2014-02-19 Thread Kenneth Graunke
On 02/18/2014 09:48 PM, Chia-I Wu wrote: > Since 73bc6061f5c3b6a3bb7a8114bb2e1ab77d23cfdb, Z16 support is not advertised > for OpenGL ES contexts due to the terrible performance. It is still enabled > for desktop GL because it was believed GL 3.0+ requires Z16. > > It turns out only GL 3.0 requir

Re: [Mesa-dev] [PATCH 04/13] Hack: Disable MCS on Broadwell for now.

2014-02-19 Thread Eric Anholt
Kenneth Graunke writes: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 ++ > 1 file changed, 6 insertions(+) > > I'm mostly sending this out as a placeholder. Ultimately, we want to get > MCS working. I'm not sure whether it would be valuable to push this (with > a proper commit

Re: [Mesa-dev] [PATCH 09/13] i965: Only use the SIMD16 program for per-sample shading on Broadwell.

2014-02-19 Thread Eric Anholt
Kenneth Graunke writes: > This is a straight port from gen7_wm_state.c; I haven't looked into > whether we can do both. > > v2: Actually do it right. > > Signed-off-by: Kenneth Graunke > @@ -205,13 +201,39 @@ upload_ps_state(struct brw_context *brw) > else >dw6 |= GEN7_PS_POSOFFSET_

Re: [Mesa-dev] [PATCH 07/13] i965: Add missing sample shading bits to Gen8's 3DSTATE_PS_EXTRA.

2014-02-19 Thread Eric Anholt
Kenneth Graunke writes: > v2: Also set the "oMask Present to Render Target" bit, which is required > for shaders that write oMask. Otherwise the hardware won't expect > the extra data. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen8_ps_state.c | 16 +++

Re: [Mesa-dev] [PATCH] build: Fix FTBFS bug introduced by ee55500c22

2014-02-19 Thread Emil Velikov
On 19/02/14 18:12, Kai Wasserbäch wrote: > The referenced commit set the with_dri_drivers variable to "yes" in the > auto case, which is an unknown classic DRI driver and leads to a FTBFS. > Thanks for the patch Kai The issue has been reported already[1] and a slightly more appropriate patch has

Re: [Mesa-dev] [PATCH 13/23] i965/fs: Take into account reg_offset consistently for MRF regs.

2014-02-19 Thread Francisco Jerez
Paul Berry writes: > On 15 January 2014 14:01, Francisco Jerez wrote: > >> Paul Berry writes: >> >> > On 2 December 2013 11:31, Francisco Jerez wrote: >> > >> >> Until now it was only being taken into account in the VEC4 back-end >> >> but not in the FS back-end. Do it in both cases. >> >> --

Re: [Mesa-dev] [PATCH 6/8] i965: Implement HiZ resolves on Broadwell.

2014-02-19 Thread Eric Anholt
Kenneth Graunke writes: > On 02/18/2014 01:38 PM, Eric Anholt wrote: >> Kenneth Graunke writes: > [snip] >>> diff --git a/src/mesa/drivers/dri/i965/gen8_depth_state.c >>> b/src/mesa/drivers/dri/i965/gen8_depth_state.c >>> index f30ff28..3fa20c8 100644 >>> --- a/src/mesa/drivers/dri/i965/gen8_de

Re: [Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

2014-02-19 Thread Ian Romanick
I'm hoping that Tapani or Darius will verify that this patch actually fixes the problem. That's why people CC other people on patches. :) On 02/18/2014 10:19 AM, Ian Romanick wrote: > From: Ian Romanick > > Section 3.3 (Preprocessor) of the GLSL 1.30 spec (and later) and the > GLSL ES spec (all

Re: [Mesa-dev] [Mesa-stable] [PATCH 07/19] svga: update shader code for GBS

2014-02-19 Thread Ian Romanick
This patch didn't apply to the 10.1 branch. I've picked most things to the 10.1 branch except this series. Could you put a branch up somewhere and send me a pull request? I'm sure you'd like to have these in the release, and I don't want to mess them up. :) 2e0c90847f16a9cf2a40436beacb65c65535f

Re: [Mesa-dev] [PATCH-RFC] i965: do not advertise MESA_FORMAT_Z_UNORM16 support

2014-02-19 Thread Eric Anholt
Chia-I Wu writes: > Since 73bc6061f5c3b6a3bb7a8114bb2e1ab77d23cfdb, Z16 support is not advertised > for OpenGL ES contexts due to the terrible performance. It is still enabled > for desktop GL because it was believed GL 3.0+ requires Z16. > > It turns out only GL 3.0 requires Z16, and that is co

[Mesa-dev] [PATCH] build: Fix FTBFS bug introduced by ee55500c22

2014-02-19 Thread Kai Wasserbäch
The referenced commit set the with_dri_drivers variable to "yes" in the auto case, which is an unknown classic DRI driver and leads to a FTBFS. CC: Emil Velikov Signed-off-by: Kai Wasserbäch --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/conf

[Mesa-dev] [PATCH] st/omx: fix prevFrameNumOffset handling

2014-02-19 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/omx/vid_dec_h264.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/omx/vid_dec_h264.c b/src/gallium/state_trackers/omx/vid_dec_h264.c index 5f4a261..7f1c2fa 100644 --- a/src/g

[Mesa-dev] [PATCH] st/omx/enc: add multi scaling buffers for performance improvement

2014-02-19 Thread Leo Liu
From: Leo Liu Signed-off-by: Leo Liu --- src/gallium/state_trackers/omx/vid_enc.c | 38 src/gallium/state_trackers/omx/vid_enc.h | 7 -- 2 files changed, 29 insertions(+), 16 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_enc.c b/src/gallium

[Mesa-dev] [Bug 75098] OpenGL ES2 with fbdev - link error

2014-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75098 --- Comment #4 from Christian Prochaska --- (In reply to comment #3) > Created attachment 94319 [details] [review] > configure: use shared-glapi when more than one gl* API is used > > Hmm forcing shared-glapi whenever more than one gl* api is u

[Mesa-dev] [Bug 75212] Mesa selects wrong DRI driver

2014-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75212 --- Comment #1 from Emil Velikov --- There are a couple of solutions for this [1] [2]. I would prefer the latter as I've never been a fan of black/white listing. Eric are you leaning towards either solution ? Can we get an ack or your thoughts i

[Mesa-dev] [Bug 75212] New: Mesa selects wrong DRI driver

2014-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75212 Priority: medium Bug ID: 75212 CC: e...@anholt.net, lem...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: Mesa selects wrong DRI driver Severity: normal Classifi

[Mesa-dev] [PATCH] mesa: add missing DebugMessageControl types

2014-02-19 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- src/mesa/main/errors.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index 5f4eac6..c00c796 100644 --- a/src/mesa/main/errors.c +++ b/src/mesa/main/errors.c @@ -575,6 +575,11 @@ validate_params(struct gl_

[Mesa-dev] [PATCH] i965: Use MOV, not OR for setting URB write channel enables on Gen8+.

2014-02-19 Thread Kenneth Graunke
On Broadwell, g0.5 contains the "Scratch Space Pointer"; using OR puts some bits of that into "ignored" sections of our message header. While this doesn't hurt, it's also not terribly /useful/. Using MOV is sufficient to set the only interesting bits in this part of the message header. Signed-of

[Mesa-dev] [PATCH 12/13] i965: Update physical width/height munging for 2x IMS MSAA.

2014-02-19 Thread Kenneth Graunke
I can't find any documentation to explain what ought to be done here, so I simply guessed based on the pattern I observed in the 4x/8x cases. It appears to work, but it could be totally wrong. I was able to find the Sandybridge PRM quote from the comments in the latest documentation: Shared Functi

[Mesa-dev] [PATCH 02/13] i965: Use ffs() for sample counting in gen7_surface_msaa_bits().

2014-02-19 Thread Kenneth Graunke
The enumerations are just log2(num_samples) shifted by 3, which we can easily compute via ffs(). This also makes it reusable for Broadwell, which has 2x MSAA. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 10 -- 1 file changed, 4 insertions(+), 6

[Mesa-dev] [PATCH 13/13] i965: Actually claim to support MSAA on Broadwell.

2014-02-19 Thread Kenneth Graunke
We need to advertise 8x, 4x, and 2x multisamples. Previously, we only claimed to support 0/1 samples. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src/mesa/drivers/dri/i965/intel_screen.c | 5 - 2 files changed, 10 insertions(+), 1 deletion(-) Thi

[Mesa-dev] [PATCH 03/13] i965: Use gen7_surface_msaa_bits in Broadwell SURFACE_STATE code.

2014-02-19 Thread Kenneth Graunke
We already set the number of samples, but were missing the MSAA layout mode. Reusing gen7_surface_msaa_bits makes it easy to set both. This also lets us drop the Gen8 surface_num_multisamples function. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 16 ++---

[Mesa-dev] [PATCH 09/13] i965: Only use the SIMD16 program for per-sample shading on Broadwell.

2014-02-19 Thread Kenneth Graunke
This is a straight port from gen7_wm_state.c; I haven't looked into whether we can do both. v2: Actually do it right. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_ps_state.c | 38 --- 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a

[Mesa-dev] [PATCH 10/13] i965: Thwack multisample enable bit in 3DSTATE_RASTER.

2014-02-19 Thread Kenneth Graunke
The meaning and effects of this bit are surprisingly complicated. See Rasterization > Windower > Multisampling > Multisample ModesState. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/gen8_sf_state.c | 4 2 files changed, 5 ins

[Mesa-dev] [PATCH 11/13] i965: Enable smooth points when multisampling without point sprites.

2014-02-19 Thread Kenneth Graunke
According to the "Point Multisample Rasterization" of the OpenGL specification (3.0 or later), smooth points are supposed to be enabled implicitly when multisampling, regardless of the GL_POINT_SMOOTH flag. However, if GL_POINT_SPRITE is enabled, you get square points no matter what. Core context

[Mesa-dev] [PATCH 07/13] i965: Add missing sample shading bits to Gen8's 3DSTATE_PS_EXTRA.

2014-02-19 Thread Kenneth Graunke
v2: Also set the "oMask Present to Render Target" bit, which is required for shaders that write oMask. Otherwise the hardware won't expect the extra data. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_ps_state.c | 16 +++- 1 file changed, 15 insertions(+)

[Mesa-dev] [PATCH 06/13] i965/fs: Implement FS_OPCODE_SET_OMASK on Broadwell.

2014-02-19 Thread Kenneth Graunke
I made a few changes which I think simplify the code a bit compared to the Gen7 implementation, but which are largely pointless. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 36 +

[Mesa-dev] [PATCH 04/13] Hack: Disable MCS on Broadwell for now.

2014-02-19 Thread Kenneth Graunke
--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 ++ 1 file changed, 6 insertions(+) I'm mostly sending this out as a placeholder. Ultimately, we want to get MCS working. I'm not sure whether it would be valuable to push this (with a proper commit message) in the meantime. diff --git

[Mesa-dev] [PATCH 05/13] i965/fs: Implement FS_OPCODE_SET_SAMPLE_ID on Broadwell.

2014-02-19 Thread Kenneth Graunke
Largely cut and paste from Gen7; it works the same way. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.h | 4 src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 29 - 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/src

[Mesa-dev] [PATCH 08/13] i965: Set "Position XY Offset Select" bits in 3DSTATE_PS on Broadwell.

2014-02-19 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_ps_state.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen8_ps_state.c b/src/mesa/drivers/dri/i965/gen8_ps_state.c index e93668e..57bf053 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 01/13] i965: Simplify Broadwell's 3DSTATE_MULTISAMPLE sample count handling.

2014-02-19 Thread Kenneth Graunke
These enumerations are simply log2 of the number of multisamples shifted by a bit, so we can calculate them using ffs() in a lot less code. Suggested by Eric Anholt. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_multisample_state.c | 26 +++--- 1 file changed

Re: [Mesa-dev] [PATCH 6/8] i965: Implement HiZ resolves on Broadwell.

2014-02-19 Thread Kenneth Graunke
On 02/18/2014 01:38 PM, Eric Anholt wrote: > Kenneth Graunke writes: [snip] >> diff --git a/src/mesa/drivers/dri/i965/gen8_depth_state.c >> b/src/mesa/drivers/dri/i965/gen8_depth_state.c >> index f30ff28..3fa20c8 100644 >> --- a/src/mesa/drivers/dri/i965/gen8_depth_state.c >> +++ b/src/mesa/drive