[Mesa-dev] [PATCH] i965: increase the antialiased line width by 0.25

2014-03-27 Thread Samuel Iglesias Gonsalvez
The line antialiasing support in the HW doesn't compute properly the pixel coverage by the line when line width is equal to 1.0. This patch increases a little bit the line width making the piglit's line-aa-width pass and fix some related bugs in applications like 1 pixel lines in octave plot alias

[Mesa-dev] [PATCH] i965: disable blorp's linear filtering on SNB

2014-03-27 Thread Samuel Iglesias Gonsalvez
Commit 079bdba05f870807d3ed77fa3093cdb7727aa2fd enabled the use of BLORP engine for single sample scaled blit with bilinear filter. However piglit fails when running fbo-blit-stretch test on SandyBridge. This patch makes the code to fallback to other blit paths for SandyBridge. Bugzilla: https://

[Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-03-27 Thread Iago Toral Quiroga
Commit 11baad35088dfd4bdabc1710df650dbfb413e7a3 produces a regression when switching a single context between multiple drawables. The problem is that we check whether we have a viewport set to decide if we need to generate buffers for the drawble, but the viewport is initialized with the first cal

[Mesa-dev] [PATCH] i965: Make sure we always compute valid index bounds before drawing

2014-03-27 Thread Iago Toral Quiroga
There is crash in blender when rendering to the selection buffer and using VBO that is caused because we call _tnl_draw_prims() without proper min_index and max_index values. As far as I can see it looks like these bounds should be computed by calling vbo_get_minmax_indices() right before calling

[Mesa-dev] [PATCH] i965: Make sure we always compute valid index bounds before drawing.

2014-03-27 Thread Iago Toral Quiroga
Calling _tnl_draw_prims() with invalid index bounds can crash and in some cases where vbo_all_varyings_in_vbos() is TRUE but we don't have valid index bounds, this happens. This was producing a crash in Blender when rendering to the selection buffer. Bugzilla: https://bugs.freedesktop.org/show_bug

Re: [Mesa-dev] [PATCH 0/5] util: Rework endian handling in python code

2014-03-27 Thread Richard Sandiford
Ping (with fixed subject) Richard Sandiford writes: > This is a refresh of: > >http://lists.freedesktop.org/archives/mesa-dev/2013-June/040594.html > > At the moment the python code uses sys.byteorder to decide whether > u_format_table.c should be for big or little endian. With this series >

[Mesa-dev] [Bug 76489] Mesa git (011569b5b7) compilation issue: render2.c:49:4: error: implicit declaration of function '__glMap1d_size' [-Werror=implicit-function-declaration]

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76489 --- Comment #12 from Jonathan Gray --- There is no need to require GNU indent. Unless something has changed here in Mesa very recently the versions of indent in OpenBSD and FreeBSD support all of the flags Mesa uses. None of which are the getop

[Mesa-dev] [PATCH] st/wgl: Remove wgl*Gallium*MESA().

2014-03-27 Thread jfonseca
From: José Fonseca These were only used by the Python state tracker, which was removed, hence they have no practical use. --- src/gallium/state_trackers/wgl/Makefile.sources| 1 - src/gallium/state_trackers/wgl/stw_ext_gallium.c | 50 -- src/gallium/state_trackers/wgl/

[Mesa-dev] [Bug 76252] Dynamic loading/unloading of opengl32.dll results in a deadlock

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76252 José Fonseca changed: What|Removed |Added CC||bri...@vmware.com --- Comment #4 from Jos

[Mesa-dev] [Bug 76252] Dynamic loading/unloading of opengl32.dll results in a deadlock

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76252 --- Comment #5 from Patrick Baggett --- José, Can you explain the problem more? Thread 2's stack trace seems like it is waiting on ... something, but it isn't clear what or why. Is this the NT subsystem pausing it during thread unload? If so, wh

[Mesa-dev] [Bug 76694] New: Inconsistent behaviour of LIBGL_DEBUG

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76694 Priority: medium Bug ID: 76694 Assignee: mesa-dev@lists.freedesktop.org Summary: Inconsistent behaviour of LIBGL_DEBUG Severity: normal Classification: Unclassified OS: All

Re: [Mesa-dev] [PATCH] mesa: fix glMultiDrawArrays inside a display list

2014-03-27 Thread Jose Fonseca
LGTM. Jose - Original Message - > The underlying glDrawArrays() calls weren't getting compiled into > the display list. We simply need to use the current dispatch table > so the CALL_DrawArrays() is routed to the display list save function. > > This patch also fixes glMultiModeDrawArray

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-27 Thread Jose Fonseca
- Original Message - > On Wed, Mar 26, 2014 at 4:30 AM, Roland Scheidegger > wrote: > > Am 26.03.2014 03:29, schrieb Marek Olšák: > >> My reasoning was that it would be better to specify a raw clear value > >> and clear value size for buffers, which are always untyped, and > >> pipe_colo

Re: [Mesa-dev] [PATCH] st/wgl: Remove wgl*Gallium*MESA().

2014-03-27 Thread Brian Paul
Reviewed-by: Brian Paul On 03/27/2014 08:58 AM, jfons...@vmware.com wrote: From: José Fonseca These were only used by the Python state tracker, which was removed, hence they have no practical use. --- src/gallium/state_trackers/wgl/Makefile.sources| 1 - src/gallium/state_trackers/wg

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-27 Thread Ilia Mirkin
On Thu, Mar 27, 2014 at 11:35 AM, Jose Fonseca wrote: > > > - Original Message - >> On Wed, Mar 26, 2014 at 4:30 AM, Roland Scheidegger >> wrote: >> > Am 26.03.2014 03:29, schrieb Marek Olšák: >> >> My reasoning was that it would be better to specify a raw clear value >> >> and clear valu

Re: [Mesa-dev] [PATCH] mesa: fix glMultiDrawArrays inside a display list

2014-03-27 Thread Ian Romanick
On 03/26/2014 04:12 PM, Brian Paul wrote: > The underlying glDrawArrays() calls weren't getting compiled into > the display list. We simply need to use the current dispatch table > so the CALL_DrawArrays() is routed to the display list save function. > > This patch also fixes glMultiModeDrawArray

[Mesa-dev] [Bug 76698] New: DRI loader prints misleading error message

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76698 Priority: medium Bug ID: 76698 Assignee: mesa-dev@lists.freedesktop.org Summary: DRI loader prints misleading error message Severity: normal Classification: Unclassified OS:

[Mesa-dev] [Bug 76252] Dynamic loading/unloading of opengl32.dll results in a deadlock

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76252 --- Comment #6 from José Fonseca --- (In reply to comment #5) > Can you explain the problem more? Thread 2's stack trace seems like it is > waiting on ... something, but it isn't clear what or why. > Is this the NT > subsystem pausing it during

Re: [Mesa-dev] [PATCH] i965: Make sure we always compute valid index bounds before drawing.

2014-03-27 Thread Ian Romanick
On 03/27/2014 02:18 AM, Iago Toral Quiroga wrote: > Calling _tnl_draw_prims() with invalid index bounds can crash and > in some cases where vbo_all_varyings_in_vbos() is TRUE but we > don't have valid index bounds, this happens. This was producing > a crash in Blender when rendering to the selectio

[Mesa-dev] [PATCH] i965: Make sure we always compute valid index bounds before drawing.

2014-03-27 Thread Iago Toral Quiroga
The proposed change works fine. Here is the updated patch. Iago Toral Quiroga (1): i965: Make sure we always compute valid index bounds before drawing. src/mesa/drivers/dri/i965/brw_draw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.8.3.2 ___

[Mesa-dev] [PATCH] i965: Make sure we always compute valid index bounds before drawing.

2014-03-27 Thread Iago Toral Quiroga
When doing software rendering (i.e. rendering to the selection buffer) we need to make sure that we have valid index bounds before calling _tnl_draw_prims(), otherwise we can crash. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59455 --- src/mesa/drivers/dri/i965/brw_draw.c | 3 ++- 1 fi

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-27 Thread Roland Scheidegger
Am 27.03.2014 03:04, schrieb Marek Olšák: > On Wed, Mar 26, 2014 at 4:30 AM, Roland Scheidegger > wrote: >> Am 26.03.2014 03:29, schrieb Marek Olšák: >>> My reasoning was that it would be better to specify a raw clear value >>> and clear value size for buffers, which are always untyped, and >>> p

[Mesa-dev] [PATCH] llvmpipe: Use a LLVMContext for each llvmpipe OpenGL context.

2014-03-27 Thread Mathias Fröhlich
Hi, attached a change to llvmpipe fixing a long standing problem with multithreaded OpenGL applications. Please review! thanks! Mathias>From 7e85383c4a23e19e739eb3df574c8062c381beee Mon Sep 17 00:00:00 2001 Message-Id: <7e85383c4a23e19e739eb3df574c8062c381beee.1395945410.git.mathias.froehl...@

[Mesa-dev] [PATCH 06/24] dri/common: LIBDRM_LIBS is not a linker/libtool flag, add it to LIBADD

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/common/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/Makefile.am b/src/mesa/drivers/dri/common/Makefile.am index e500bdb..c98ccf7 100644 --- a/src/mesa/drivers/dri/common/Makefile.a

[Mesa-dev] [PATCH 07/24] targets/xa: drop libudev references from automake build

2014-03-27 Thread Emil Velikov
Mesa does _not_ against libudev. Additionally the only place that deals with it is the loader, thus we can drop the CFLAGS. Signed-off-by: Emil Velikov --- src/gallium/targets/xa/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/targets/xa/Makefile.am b/src/gallium/ta

[Mesa-dev] [PATCH 00/24] LDFLAG additions and misc automake cleanups

2014-03-27 Thread Emil Velikov
Hello list, Yet another small series from me, targeting the following - Revert "allow only shared builds". Static osmesa/libgl-xlib is still a used, so rever the commit for now. - Add -no-undefined, -Wl,--no-undefined and -Wl,--gc-sections. The former two deal with missing symbols, while the l

[Mesa-dev] [PATCH 01/24] Partially revert "automake: allow only shared builds"

2014-03-27 Thread Emil Velikov
Evidently at least static OSMesa is still used as shared one causes substantial increase in the load time for some programs that use it (from seconds up-to ~30min). Rather than forcing everyone to use shared mesa, revert commit a6efbac9fb502c4f0166e7a0680b6828e1f6926c and default to shared build w

[Mesa-dev] [PATCH 15/24] gallium/targets: move LLVM_LIBS handling inside Automake.inc

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/Automake.inc | 5 + src/gallium/targets/dri-freedreno/Makefile.am | 4 src/gallium/targets/dri-i915/Makefile.am | 2 +- src/gallium/targets/dri-ilo/Makefile.am| 4 src/gallium/targets/dri-nouveau/Makefi

[Mesa-dev] [PATCH 11/24] targets/pipe-loader: move LLVM_LIBS handling inside PIPE_LIBS

2014-03-27 Thread Emil Velikov
This lets us have only one if HAVE_MESA_LLVM block, rather than one for each driver. Signed-off-by: Emil Velikov --- src/gallium/targets/pipe-loader/Makefile.am | 34 ++--- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/src/gallium/targets/pipe-loader/Mak

[Mesa-dev] [PATCH 08/24] pipe-loader/swrast: add soft/llvmpipe defines

2014-03-27 Thread Emil Velikov
From: Joakim Sindholt Or it compiles them in, but pretends they don't exist v2: Rebase (Emil) Signed-off-by: Emil Velikov --- src/gallium/targets/pipe-loader/Makefile.am | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets

[Mesa-dev] [PATCH 12/24] targets/omx: introduce GALLIUM_OMX_LIB_DEPS

2014-03-27 Thread Emil Velikov
Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/Automake.inc | 6 ++ src/gallium/targets/r600/omx/Makefile.am | 5 + src/gallium/targets/radeonsi/omx/Makefile.am | 5 + 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH 18/24] targets/egl-static: move the common LDFLAGS into AM_LDFLAGS

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/targets/egl-static/Makefile.am | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/gallium/targets/egl-static/Makefile.am b/src/gallium/targets/egl-static/Makefile.am index 282fa66..b492496 100644 --- a/src/gall

[Mesa-dev] [PATCH 05/24] drivers/x11: GL_LIB_DEPS is not a linker/libtool flag, add it to LIBADD

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/Makefile.am | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/x11/Makefile.am b/src/mesa/drivers/x11/Makefile.am index b10e86f..27343d1 100644 --- a/src/mesa/drivers/x11/Makefile.am +++ b/src/mesa/drive

[Mesa-dev] [PATCH 21/24] pipe-loader: use PTHREAD_LIBS over -lpthread

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/targets/pipe-loader/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am index fae4fa3..6e78a75 100644 --- a/src/gallium/targets/

[Mesa-dev] [PATCH 20/24] dri/i965: use CLOCK_LIBS over -lrt

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index 24e226f..54a38bd 100644 --- a/src/mesa/drivers/dri/i965/Makefile.am +++ b/

[Mesa-dev] [PATCH 10/24] targets/pipe-loader: include dummy.cpp irrespective of HAVE_MESA_LLVM

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/targets/pipe-loader/Makefile.am | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am index 73e43e0..8e76d41 100644 --- a/src/gallium/targe

[Mesa-dev] [PATCH 09/24] targets/pipe-loader: compact duplicating LDFLAGS

2014-03-27 Thread Emil Velikov
Every library uses the same libtool/linker flags. Compact those into AM_LDFLAGS and append the version script to it. Signed-off-by: Emil Velikov --- src/gallium/targets/pipe-loader/Makefile.am | 35 ++--- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 16/24] gallium/targets: explicitly include a dummy.cpp and remove all the LINK mayhem

2014-03-27 Thread Emil Velikov
We've been copying and pasting this hunk for a while now, only to prevent build issues on very old and buggy build toolchains. At this point this should no longer be needed, so we can cleanup all the mess and simplify our makefiles. Signed-off-by: Emil Velikov --- src/gallium/targets/dri-i915/Ma

[Mesa-dev] [PATCH 03/24] configure: use grep in quiet mode, rather than piping stderr/stdout to /dev/null

2014-03-27 Thread Emil Velikov
grep -q is easier to read and consistent with the rest of configure.ac. Signed-off-by: Emil Velikov --- configure.ac | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 9213f8a..de05ab2 100644 --- a/configure.ac +++ b/configure.ac @@

[Mesa-dev] [PATCH 23/24] automake: add -Wl, --no-undefined to all libraries

2014-03-27 Thread Emil Velikov
... apart from the dri drivers. With this final change we can build mesa without fear that the resulting libraries will have unresolved symbols. Signed-off-by: Emil Velikov --- src/egl/main/Makefile.am| 6 +- src/egl/wayland/wayland-egl/Makefile.am | 3 ++- src/galliu

[Mesa-dev] [PATCH 19/24] automake: consistently use -no-undefined

2014-03-27 Thread Emil Velikov
Set the flag for all but the dri targets. They have missing glapi symbols which are required for the normal operation with the X server. Jon, I fear that you'll need to carry the "no-undefined" hunk locally when building the dri drivers under cygwin. Cc: Jon TURNEY Signed-off-by: Emil Velikov -

[Mesa-dev] [PATCH 17/24] targets/omx: define GALLIUM_TRACE when using the trace driver

2014-03-27 Thread Emil Velikov
Otherwise the omx drivers are explicitly linked but never wrapped in order to use it. Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/targets/r600/omx/Makefile.am | 3 ++- src/gallium/targets/radeonsi/omx/Makefile.am | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 13/24] targets/omx: use GALLIUM_OMX_LINKER_FLAGS

2014-03-27 Thread Emil Velikov
Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/Automake.inc | 6 ++ src/gallium/targets/r600/omx/Makefile.am | 10 +++--- src/gallium/targets/radeonsi/omx/Makefile.am | 10 +++--- 3 files changed, 12 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 02/24] configure: error out when building gallium-osmesa without softpipe

2014-03-27 Thread Emil Velikov
Gallium osmesa links against the softpipe driver, thus the build will fail if it's missing. Signed-off-by: Emil Velikov --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 39330cf..9213f8a 100644 --- a/configure.ac +++ b/conf

[Mesa-dev] [PATCH 04/24] configure: autodetect video state-trackers when non swrast driver is present

2014-03-27 Thread Emil Velikov
It makes little sense to enable the vdpau, xvmc and omx state-trackers as they do not make use of (don't work with) the software driver. Signed-off-by: Emil Velikov --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index de05ab2..d0a

[Mesa-dev] [PATCH 14/24] gallium/targets: fold LLVM_LDFLAGS inside Automake.inc

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/Automake.inc | 9 + src/gallium/targets/dri-freedreno/Makefile.am | 1 - src/gallium/targets/dri-ilo/Makefile.am| 1 - src/gallium/targets/dri-nouveau/Makefile.am| 1 - src/gallium/targets/dri-swrast/Makefile.a

[Mesa-dev] [PATCH 24/24] automake: ask the linker to do garbage collection

2014-03-27 Thread Emil Velikov
By doing GC the linker removes all the symbols that are not referenced and/or used by the final library. This results in a saving of ~100K up-to ~600K per (stripped) binary (classic vs gallium drivers). If interested one can ask the compiler to print the sections that are removed using -Wl,--print

[Mesa-dev] [PATCH 22/24] gallium/targets: add missing library dependencies

2014-03-27 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/targets/gbm/Makefile.am | 5 - src/gallium/targets/xa/Makefile.am | 7 ++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/targets/gbm/Makefile.am b/src/gallium/targets/gbm/Makefile.am index e36d317..bad581d 100644

[Mesa-dev] [PATCH v2 4/9] mesa: Handle QUERY_BUFFER_BINDING in GetIntegerv

2014-03-27 Thread Rafal Mielniczuk
v2: Expose query buffer binding location only when extension is enabled Signed-off-by: Rafal Mielniczuk --- src/mesa/main/get.c | 5 + src/mesa/main/get_hash_params.py | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 6d9

[Mesa-dev] [PATCH v2 3/9] mesa: Add QueryBuffer to context

2014-03-27 Thread Rafal Mielniczuk
Add QueryBuffer and initialise it to NullBufferObj on start Signed-off-by: Rafal Mielniczuk --- src/mesa/main/bufferobj.c | 5 + src/mesa/main/mtypes.h| 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2e9e059..8d6e1ee 10064

[Mesa-dev] [PATCH v2 5/9] mesa: Handle QUERY_RESULT_NO_WAIT in GetQueryObject{ui64}v

2014-03-27 Thread Rafal Mielniczuk
Just return and do nothing if query result is not yet available Signed-off-by: Rafal Mielniczuk --- src/mesa/main/queryobj.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 86e7c3a..d2d9fa7 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH v2 7/9] mesa: Implement software fallback for ARB_query_buffer_object

2014-03-27 Thread Rafal Mielniczuk
v2: In v1 &q->Ready was passed into query_store_result which could cause segfault in memcpy. (q->Ready is bool of size 1, while size parameter could be 4 or 8) Now store result in local variable and pass pointer to it instead. Signed-off-by: Rafal Mielniczuk --- src/mesa/main/queryob

[Mesa-dev] [PATCH v2 2/9] mesa: Add ARB_query_buffer_object extension flag

2014-03-27 Thread Rafal Mielniczuk
Signed-off-by: Rafal Mielniczuk --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 33cb888..3e3e6fd 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3516,6 +3516,7 @@ struct gl_extensions GLb

[Mesa-dev] [PATCH v2 8/9] mesa: Enable GL_ARB_query_buffer_object for software drivers

2014-03-27 Thread Rafal Mielniczuk
v2: Only enable extension for software driver Signed-off-by: Rafal Mielniczuk --- src/mesa/main/extensions.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index a72284c..3dbca41 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa

[Mesa-dev] [PATCH v2 9/9] doc: mark GL_ARB_query_buffer_object as done for swrast

2014-03-27 Thread Rafal Mielniczuk
Signed-off-by: Rafal Mielniczuk --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index b7e4c87..aff0445 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -174,7 +174,7 @@ GL 4.4: GL_ARB_clear_texture

[Mesa-dev] [PATCH v2 6/9] mesa: Fix typos in function names in queryobj

2014-03-27 Thread Rafal Mielniczuk
Signed-off-by: Rafal Mielniczuk --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index d2d9fa7..ba9c7f5 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryobj.c @@ -702,7 +702,7 @@

[Mesa-dev] [PATCH v2 0/9] Add ARB_query_buffer_object (swrast)

2014-03-27 Thread Rafal Mielniczuk
Hello, This is the second version of the series implementing ARB_query_buffer_object in mesa. Main changes to the first version are: - Enable extension only for software driver - Fix possible segfault in patch #7 - Fix typos and comment style issues Drivers, which are not able to implement

[Mesa-dev] [PATCH v2 1/9] glapi: Add xml infrastructure for ARB_query_buffer_object

2014-03-27 Thread Rafal Mielniczuk
v2: Fix copy-paste error and comment style Signed-off-by: Rafal Mielniczuk --- src/mapi/glapi/gen/ARB_query_buffer_object.xml | 18 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 4 3 files changed, 23 insertions(+

Re: [Mesa-dev] [PATCH] i965: Make sure we always compute valid index bounds before drawing.

2014-03-27 Thread Kenneth Graunke
On 03/27/2014 10:45 AM, Iago Toral Quiroga wrote: > When doing software rendering (i.e. rendering to the selection buffer) we need > to make sure that we have valid index bounds before calling _tnl_draw_prims(), > otherwise we can crash. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=5

[Mesa-dev] [PATCH 1/4] glsl: Move Doxygen block closing ot the correct place

2014-03-27 Thread Ian Romanick
From: Ian Romanick This is the closing for the "\defgroup IR Intermediate representation nodes" all the way at the top of the file. Signed-off-by: Ian Romanick --- src/glsl/ir.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index 8fa3b9e.

[Mesa-dev] [PATCH 2/4] mesa/program: Constify find_variable_storage

2014-03-27 Thread Ian Romanick
From: Ian Romanick Also clean up an old whitespace blooper. Signed-off-by: Ian Romanick --- src/mesa/program/ir_to_mesa.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 9598710..1ba9e43 100644 -

[Mesa-dev] [PATCH 3/4] mesa: Clean up "unused parameter" warnings

2014-03-27 Thread Ian Romanick
From: Ian Romanick program/ir_to_mesa.cpp:2008:1: warning: unused parameter 'ir' [-Wunused-parameter] program/ir_to_mesa.cpp:2272:1: warning: unused parameter 'ir' [-Wunused-parameter] program/ir_to_mesa.cpp:2278:1: warning: unused parameter 'ir' [-Wunused-parameter] Signed-off-by: Ian Romani

[Mesa-dev] [PATCH 4/4] glsl: Clean up "unused parameter" warnings

2014-03-27 Thread Ian Romanick
From: Ian Romanick ../../src/glsl/builtin_functions.cpp:72:1: warning: unused parameter 'state' [-Wunused-parameter] ../../src/glsl/ir_clone.cpp:31:1: warning: unused parameter 'ht' [-Wunused-parameter] ../../src/glsl/ir_equals.cpp:44:1: warning: unused parameter 'ir' [-Wunused-parameter] ..

[Mesa-dev] [PATCH 07/19] linker: Refactor code that gets an input matching an output

2014-03-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 51 - src/glsl/tests/varyings_test.cpp | 80 2 files changed, 114 insertions(+), 17 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/

[Mesa-dev] [PATCH 12/19] linker: Sort shader I/O variables into a canonical order

2014-03-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 78 +++--- 1 file changed, 74 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 065e234..3d9516c 100644 --- a/src/glsl/

[Mesa-dev] [PATCH 08/19] linker: Allow consumer stage or producer stage to be NULL

2014-03-27 Thread Ian Romanick
From: Ian Romanick When linking a separable program that contains only a fragment shader, the producer will be NULL. Similar cases will exist with geometry shaders and, eventually, tessellation shaders. Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 71 ++

[Mesa-dev] [PATCH 05/19] glsl/tests: Add first simple tests of populate_consumer_input_sets

2014-03-27 Thread Ian Romanick
From: Ian Romanick Four initial tests: * Create an IR list with a single input variable and verify that variable is the only thing in the hash tables. * Same as the previous test, but use a built-in variable (gl_ClipDistance) with an explicit location set. * Create an IR list with a single

[Mesa-dev] [PATCH 02/19] mesa/sso: Refactor new function _mesa_bind_pipeline

2014-03-27 Thread Ian Romanick
From: Ian Romanick Pull most of the guts out of _mesa_BindPipeline into a new utility function that can be use elsewhere (e.g., meta). Signed-off-by: Ian Romanick --- src/mesa/main/pipelineobj.c | 13 ++--- src/mesa/main/pipelineobj.h | 4 2 files changed, 14 insertions(+), 3 del

[Mesa-dev] [PATCH 19/19] mesa: Eliminate gl_shader_program::InternalSeparateShader

2014-03-27 Thread Ian Romanick
From: Ian Romanick This was a work-around to allow linking a program with only a fragment shader in a GLES context. Now that we have GL_EXT_separate_shader_objects in GLES contexts, we can just use that. Signed-off-by: Ian Romanick --- src/glsl/linker.cpp | 3 +-- src/mesa/m

[Mesa-dev] [PATCH 15/19] mesa/sso: Enable GL_ARB_separate_shader_objects by default

2014-03-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/glcpp/glcpp-parse.y | 4 +--- src/glsl/glsl_parser_extras.cpp | 2 +- src/mesa/drivers/common/meta.c | 19 --- src/mesa/main/extensions.c | 2 +- src/mesa/main/get.c | 1 - src/mesa/main/ge

[Mesa-dev] [PATCH 14/19] linker: Treat I/O within the pipeline differently than the end points

2014-03-27 Thread Ian Romanick
From: Ian Romanick Outputs that go from one shader stage to the next need slightly different treatment than outputs from the fragement shader. Likewise for inputs. If an output (or input) is intrastage and not a built-in, smash its location to 0, and set explicit_location to false. The locatio

[Mesa-dev] [PATCH 18/19] mesa: Enable GL_EXT_separate_shader_objects for OpenGL ES

2014-03-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/glcpp/glcpp-parse.y | 1 + src/glsl/glsl_parser_extras.cpp| 1 + src/glsl/glsl_parser_extras.h | 8 +- src/glsl/linker.cpp| 3 +- sr

[Mesa-dev] [PATCH 04/19] linker: Refactor code that builds hash tables of varyings during linking

2014-03-27 Thread Ian Romanick
From: Ian Romanick I want to make some changes to this code, but first I want to make some unit tests for it... so that I can capture the pre- and post-invariants. Pulling the code out into its own function in a non-anonymous namespace enables that. Signed-off-by: Ian Romanick --- src/glsl/li

[Mesa-dev] [PATCH 10/19] linker: Allow geometry shader without vertex shader for separable programs

2014-03-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/linker.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index ee07e89..e02ce87 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -2161,7 +2161,8 @@ link_sha

[Mesa-dev] [PATCH 17/19] glsl: Sort the list of extensions

2014-03-27 Thread Ian Romanick
From: Ian Romanick ARB, OES, then everything else. If there's ever a KHR shading language extension, it should go between ARB and OES. Signed-off-by: Ian Romanick --- src/glsl/glsl_parser_extras.cpp | 52 +- src/glsl/glsl_parser_extras.h | 95 +++-

[Mesa-dev] [PATCH 01/19] glsl: Constify parameter to a couple varying_matches methods

2014-03-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..a9b15f6 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_va

[Mesa-dev] [PATCH 16/19] mesa: Remove support for desktop OpenGL GL_EXT_separate_shader_objects

2014-03-27 Thread Ian Romanick
From: Ian Romanick I don't know of any applications that actually use it. Now that Mesa supports GL_ARB_separate_shader_objects in all drivers, this extension is just cruft. The entrypoints for the extension remain in the XML. This is done so that a new libGL will continue to provide dispatch

[Mesa-dev] [PATCH 00/19] Last of the GL_ARB_separate_shader_objects patches!

2014-03-27 Thread Ian Romanick
This final series finishes up GL_ARB_separate_shader_objects for desktop OpenGL, and it implements GL_EXT_separate_shader_objects for OpenGL ES. It also removes GL_EXT_separate_shader_objects from desktop OpenGL. Note that the two EXT extensions are completely different. Currently none of the pigl

[Mesa-dev] [PATCH 11/19] glsl: Track explicitly set location independent from the actual location

2014-03-27 Thread Ian Romanick
From: Ian Romanick Almost all of the time the location set by layout(location=...) is the location that will be used for the variable. Vertex shader inputs and fragment shader outputs, for example, are visible to the API. We just use those actual settings. Locations set for varyings, however,

[Mesa-dev] [PATCH 09/19] linker: Assign varying locations for separable programs

2014-03-27 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/link_varyings.cpp | 17 + src/glsl/linker.cpp| 16 +--- 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 1342899..065e234

[Mesa-dev] [PATCH 06/19] glsl: Exit when the shader IR contains an interface block instance

2014-03-27 Thread Ian Romanick
From: Ian Romanick While writing the link_varyings::single_interface_input test, I discovered that populate_consumer_input_sets assumes that all shader interface blocks have been lowered to discrete variables. Since there is a pass that does this, it is a reasonable assumption. It was, however,

[Mesa-dev] [PATCH 03/19] meta: Fix saving the program pipeline state

2014-03-27 Thread Ian Romanick
From: Ian Romanick This code was broken in some odd ways before. To much state was being saved, it was being restored in the wrong order, and in the wrong way. The biggest problem was that the pipeline object was restored before restoring the programs attached to the default pipeline. Fixes a r

[Mesa-dev] [PATCH 13/19] linker: Modify cross_validate_outputs_to_inputs to match using explicit locations

2014-03-27 Thread Ian Romanick
From: Ian Romanick This will be used for GL_ARB_separate_shader_objects. That extension not only allows separable shaders to rendezvous by location, but it also allows traditionally linked shaders to rendezvous by location. The spec says: 36. How does the behavior of input/output interface

Re: [Mesa-dev] [PATCH 0/6] Some glapi clean-up releated to GLES

2014-03-27 Thread Eric Anholt
Ian Romanick writes: > Tomorrow or Friday I'm going to send out the last of the > GL_ARB_separate_shader_objects patches. Shortly after that, I will send > out patches to enable GL_EXT_separate_shader_objects on GLES. This EXT > is the GLES subset of the ARB extension. > > In preparing for this

Re: [Mesa-dev] [PATCH 06/10] i965/fs: Fix dump_instructions() on uniforms.

2014-03-27 Thread Eric Anholt
Kenneth Graunke writes: > On 03/26/2014 02:23 PM, Eric Anholt wrote: >> All of a vec4 uniform was being printed as "u0" >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp >> b/src/m

[Mesa-dev] [Bug 76489] Mesa git (011569b5b7) compilation issue: render2.c:49:4: error: implicit declaration of function '__glMap1d_size' [-Werror=implicit-function-declaration]

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76489 --- Comment #13 from Matt Turner --- (In reply to comment #12) > There is no need to require GNU indent. Unless something has changed here > in Mesa very recently the versions of indent in OpenBSD and FreeBSD support > all of the flags Mesa uses

Re: [Mesa-dev] RFC: per-driver extension lists

2014-03-27 Thread Ilia Mirkin
On Wed, Mar 26, 2014 at 4:57 PM, Ilia Mirkin wrote: >> * core extensions divided into groups based on the GL version > > It should be easy to group things however we want. I'm not > sufficiently well-versed in what would be considered useful. If there > are fixed lists of extensions that make sens

Re: [Mesa-dev] [PATCH 5/6] mapi_abi: Make ES1 and ES2 static_dispatch=false functions hidden

2014-03-27 Thread Chia-I Wu
On Thu, Mar 27, 2014 at 8:12 AM, Ian Romanick wrote: > From: Ian Romanick > > This has been a long standing issue with the ES libraries. Functions > marked in the XML with 'static_dispatch=false' were still incorrectly > exported. ABI-check is supposed to detect this case, but we have to > pap

[Mesa-dev] [Bug 76489] Mesa git (011569b5b7) compilation issue: render2.c:49:4: error: implicit declaration of function '__glMap1d_size' [-Werror=implicit-function-declaration]

2014-03-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76489 --- Comment #14 from Jonathan Gray --- Mesa git does not use -bls on indent like that bug report mentions. It uses -i4 -nut -br -brs -npcs -ce -TGLubyte -TGLbyte -TBool. In the middle of last year I modified the OpenBSD indent to add changes fr

Re: [Mesa-dev] RFC: per-driver extension lists

2014-03-27 Thread Kenneth Graunke
On 03/27/2014 06:05 PM, Ilia Mirkin wrote: > On Wed, Mar 26, 2014 at 4:57 PM, Ilia Mirkin wrote: >>> * core extensions divided into groups based on the GL version >> >> It should be easy to group things however we want. I'm not >> sufficiently well-versed in what would be considered useful. If the

Re: [Mesa-dev] [PATCH v2 5/9] mesa: Handle QUERY_RESULT_NO_WAIT in GetQueryObject{ui64}v

2014-03-27 Thread Kenneth Graunke
On 03/27/2014 01:59 PM, Rafal Mielniczuk wrote: > Just return and do nothing if query result is not yet available > > Signed-off-by: Rafal Mielniczuk > --- > src/mesa/main/queryobj.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/src/mesa/main/queryobj.c b/src/mesa/m

Re: [Mesa-dev] [PATCH 13/19] linker: Modify cross_validate_outputs_to_inputs to match using explicit locations

2014-03-27 Thread Chia-I Wu
On Fri, Mar 28, 2014 at 5:40 AM, Ian Romanick wrote: > From: Ian Romanick > > This will be used for GL_ARB_separate_shader_objects. That extension > not only allows separable shaders to rendezvous by location, but it also > allows traditionally linked shaders to rendezvous by location. The spec

[Mesa-dev] [WIP 01/13] glapi: add GL_ARB_explicit_uniform_location

2014-03-27 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mapi/glapi/gen/gl_API.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 9129d57..255c8a0 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/src/mapi/glapi/gen/gl_API.xml @@ -8344,6 +8

[Mesa-dev] [WIP 08/13] glsl/linker: GL_ARB_explicit_uniform_location support

2014-03-27 Thread Tapani Pälli
Patch refactors the existing uniform processing so explicit locations are taken in to account during variable processing. These locations are temporarily stored in gl_uniform_storage before actual locations are set. The 'remap_location' variable in gl_uniform_storage is changed to be signed so tha

[Mesa-dev] [WIP 10/13] glsl: add enable bit for ARB_explicit_uniform_location

2014-03-27 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 4e35bc0..eca3dab 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b

[Mesa-dev] [WIP 02/13] mesa: add enable bit for ARB_explicit_uniform_location

2014-03-27 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index a72284c..8605189 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.

[Mesa-dev] [WIP 09/13] mesa: support inactive uniforms in glUniform* functions

2014-03-27 Thread Tapani Pälli
Support inactive uniforms that have explicit location set in glUniform* functions. Signed-off-by: Tapani Pälli --- src/mesa/main/uniform_query.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 5f1af08

[Mesa-dev] [WIP 11/13] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-03-27 Thread Tapani Pälli
Patch adds a preprocessor define for the extension and stores explicit location data for uniforms during AST->HIR conversion. It also sets layout token to be available when having the extension in place. Signed-off-by: Tapani Pälli --- src/glsl/ast_to_hir.cpp | 13 + src/glsl/gl

[Mesa-dev] [WIP 00/13] GL_ARB_explicit_uniform_location extension

2014-03-27 Thread Tapani Pälli
Hi; Patches implement the extension, no Piglit regressions and all the tests for the extension pass (I've planned some more tests which are not yet in though). Changes shortly: - opt_dead_code optimization is modifed to build a list of removed uniform locations (that had explicit locatio

[Mesa-dev] [WIP 13/13] docs: update ARB_explicit_uniform_location status

2014-03-27 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index b7e4c87..d1ff084 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -148,7 +148,7 @@ GL 4.3: GL_ARB_compute_shaderstar

  1   2   >