Re: [Mesa-dev] [PATCH 03/10] i965: Don't implicitly set predicate default state in brw_CMP.

2014-05-25 Thread Kenneth Graunke
On 05/25/2014 01:02 PM, Matt Turner wrote: > On Sun, May 25, 2014 at 1:08 AM, Kenneth Graunke > wrote: >> diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c >> b/src/mesa/drivers/dri/i965/brw_clip_tri.c >> index fdab260..5894b80 100644 >> --- a/src/mesa/drivers/dri/i965/brw_clip_tri.c >> +++

Re: [Mesa-dev] build failure: _mesa_BindAttribLocation vs _mesa_lookup_shader_program_err , GLuint vs GLhandleARB

2014-05-25 Thread Ian Romanick
On 05/24/2014 09:22 PM, Jeremy Huddleston Sequoia wrote: > On May 24, 2014, at 19:55, Emil Velikov wrote: > >> Hi Jeremy, >> >> IIRC there was another location where the above typedef gave us the finger. >> Not entirety sure what the conclusion on the topic was and I believe that >> some >> of t

Re: [Mesa-dev] [PATCH] gallium postprocess: Add brightness filter

2014-05-25 Thread Michel Dänzer
On 25.05.2014 19:30, Yaroslav Andrusyak wrote: > In many games open source video drivers can't adjust screen brightness.It > would be nice to have a way to change the brightness I think it would be better to fix the root problem: https://bugs.freedesktop.org/show_bug.cgi?id=27222 (See http://www.x

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Bug 79039 depends on bug 77707, which changed state. Bug 77707 Summary: [ILK Bisected]Ogles2conform GL_sin_sin_float_frag_xvary.test fails https://bugs.freedesktop.org/show_bug.cgi?id=77707 What|Removed |Added

[Mesa-dev] [Bug 79039] [TRACKER] Mesa 10.2 release tracker

2014-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79039 Bug 79039 depends on bug 77703, which changed state. Bug 77703 Summary: [ILK Bisected]Piglit glean_texCombine4 fails https://bugs.freedesktop.org/show_bug.cgi?id=77703 What|Removed |Added --

[Mesa-dev] [Bug 79230] New: After upgrade from 10.1.4 to 10.2-rc4 cross-compile fails

2014-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79230 Priority: medium Bug ID: 79230 Assignee: mesa-dev@lists.freedesktop.org Summary: After upgrade from 10.1.4 to 10.2-rc4 cross-compile fails Severity: normal Classification

Re: [Mesa-dev] [PATCH 05/12] gallivm: Use LLVM global context.

2014-05-25 Thread Mathias Fröhlich
Hi, On Thursday, May 22, 2014 03:38:12 Jose Fonseca wrote: > Sorry for the delay. Mostly the same here. So don't worry! I just want this to work somehow and I think the problem is already too long standing ... And the longer I think about that the longer I believe that we have already discussed

Re: [Mesa-dev] i965 brw_eu_emit and SF code generator cleanups

2014-05-25 Thread Matt Turner
On Sun, May 25, 2014 at 1:08 AM, Kenneth Graunke wrote: > Hello, > > Matt and I have some ideas for how we could share more code between the > Gen4-7 and Gen8+ compiler backends---hopefully removing the duplicate > generators. Before we get there, though, I'd like to change the Gen4-7 > brw_eu_em

Re: [Mesa-dev] [PATCH 10/10] i965/sf: Replace push/pop in brw_emit_anyprim_setup.

2014-05-25 Thread Matt Turner
On Sun, May 25, 2014 at 1:08 AM, Kenneth Graunke wrote: > Each of the subroutine emitters alter the predication state, but > otherwise don't change anything (or put it back when they do). > Resetting predication at the end makes these functions idempotent with > regard to the default instruction s

Re: [Mesa-dev] [PATCH 03/10] i965: Don't implicitly set predicate default state in brw_CMP.

2014-05-25 Thread Matt Turner
On Sun, May 25, 2014 at 1:08 AM, Kenneth Graunke wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c > b/src/mesa/drivers/dri/i965/brw_clip_tri.c > index fdab260..5894b80 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip_tri.c > +++ b/src/mesa/drivers/dri/i965/brw_clip_tri.c > @@ -433,

Re: [Mesa-dev] [PATCH 0/23] megadriver/pipe-loader-to-all

2014-05-25 Thread Emil Velikov
ping ? For people that feel that the email is a bit vague here is a summary of what the different terms mean and what the series means with regards to file size of the final libraries. Pipe-driver - gallium/drivers/$hw and its respective winsys built into a standalone loadable module. Installed

Re: [Mesa-dev] [PATCH] automake: correctly append the version-script

2014-05-25 Thread Jon TURNEY
On 25/05/2014 17:47, Emil Velikov wrote: Turns out that the AC conditional did not include the the version-scripts as expected. Rather it truncated the remaining linker flags. Oh dear, that doesn't work as intended at all :-( Thanks for fixing this. Reviewed-by: Jon TURNEY I was under the

[Mesa-dev] [PATCH] automake: correctly append the version-script

2014-05-25 Thread Emil Velikov
Turns out that the AC conditional did not include the the version-scripts as expected. Rather it truncated the remaining linker flags. Cc: Jon TURNEY Signed-off-by: Emil Velikov --- I was under the silly impression that the original approach is correct, and naively did not check the symbols in

[Mesa-dev] [PATCH rebased] opencl: use versioned .so in mesa.icd

2014-05-25 Thread Igor Gnatenko
We must have versioned library in mesa.icd, because ICD loader would fail if the mesa-devel package wasn't installed. Reported-by: Fabian Deutsch Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Signed-off-by: Igor Gnatenko --- configure.ac | 3 +++ src/ga

[Mesa-dev] [Bug 73512] [clover] mesa.icd. should contain full path

2014-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73512 Igor Gnatenko changed: What|Removed |Added Attachment #98450|0 |1 is obsolete|

[Mesa-dev] [PATCH] gallium postprocess: Add brightness filter

2014-05-25 Thread Yaroslav Andrusyak
In many games open source video drivers can't adjust screen brightness.It would be nice to have a way to change the brightness diff --git src/gallium/auxiliary/postprocess/filters.h src/gallium/auxiliary/postprocess/filters.h index 321f333..4423c2e 100644 --- src/gallium/auxiliary/postprocess/filt

[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2014-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 --- Comment #11 from Jeremy Huddleston --- (In reply to comment #7) > > Thanks, Apple! You should thank the lack of standards regarding what GLhandleARB should've been defined as back in 2005. It's no more Apple's fault than it is Mesa's. Furt

[Mesa-dev] [PATCH 03/10] i965: Don't implicitly set predicate default state in brw_CMP.

2014-05-25 Thread Kenneth Graunke
Previously, brw_CMP with a null destination implicitly set the default state to make future instructions predicated. This is messy and confusing - emitting a CMP that populates the flag register and later using it to predicate instructions are logically separate. With the main compiler, we may ev

[Mesa-dev] [PATCH 07/10] i965/sf: Move brw_compile::flag_value to brw_sf_compile.

2014-05-25 Thread Kenneth Graunke
This field is only used to track the current value of the flag register during the SF compile. It has no place in the common compiler code. While we're changing every call, drop the 'brw' prefix from the function since it's static. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 01/10] i965/sf: Reset flag_value to 0xff before emitting SF subroutines.

2014-05-25 Thread Kenneth Graunke
When compiling any of the SF program variants, flag_value starts off as 0xff and will be modified when generating code. brw_emit_anyprim_setup emits several subroutines, saving and restoring flag_value across each of them. Since it starts out as 0xff, this is equivalent to simply setting it to 0x

[Mesa-dev] [PATCH 09/10] i965/sf: Drop unnecessary push/pop in copy_z_inv_w.

2014-05-25 Thread Kenneth Graunke
brw_MOV doesn't alter the default instruction state, so this does nothing. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sf_emit.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sf_emit.c b/src/mesa/drivers/dri/i965/brw_sf_emit.c index 10

[Mesa-dev] [PATCH 02/10] i965: Drop unnecessary predication default state resets in clip code.

2014-05-25 Thread Kenneth Graunke
Presumably, this was to reset the default state of predication_control from brw_CMP. But brw_CMP only sets that if dst is ARF null, which it isn't here. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_clip_tri.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 05/10] i965/sf: Drop useless push/pop state from flag register mashing code.

2014-05-25 Thread Kenneth Graunke
There's no point in pushing and popping the default state; the code between the two stack operations doesn't alter anything. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_eu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/d

[Mesa-dev] [PATCH 04/10] i965/sf: Drop unnecessary push/pop in do_twoside_color.

2014-05-25 Thread Kenneth Graunke
None of the assembly emitters called between push and pop actually change the state. So, we can drop these. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sf_emit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sf_emit.c b/src/mesa/drivers

[Mesa-dev] [PATCH 10/10] i965/sf: Replace push/pop in brw_emit_anyprim_setup.

2014-05-25 Thread Kenneth Graunke
Each of the subroutine emitters alter the predication state, but otherwise don't change anything (or put it back when they do). Resetting predication at the end makes these functions idempotent with regard to the default instruction state - which is a nice property. With that in place, push/pop is

[Mesa-dev] [PATCH 08/10] i965/sf: Drop unnecessary push/pop in flatshading code.

2014-05-25 Thread Kenneth Graunke
brw_JMPI sets predicate_control to BRW_PREDICATE_NONE, but that's already the value coming in. Otherwise, nothing changes state. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_sf_emit.c | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sf

[Mesa-dev] [PATCH 06/10] i965/sf: Move brw_set_predicate_control_flag_value to brw_sf_emit.c.

2014-05-25 Thread Kenneth Graunke
Only the Gen4-5 SF program compiler actually uses this function; move it there. Soon the fields will be moved out of brw_compile. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_eu.c | 18 -- src/mesa/drivers/dri/i965/brw_eu.h | 1 - src/mesa/drivers/

[Mesa-dev] i965 brw_eu_emit and SF code generator cleanups

2014-05-25 Thread Kenneth Graunke
Hello, Matt and I have some ideas for how we could share more code between the Gen4-7 and Gen8+ compiler backends---hopefully removing the duplicate generators. Before we get there, though, I'd like to change the Gen4-7 brw_eu_emit layer to work more like the new Gen8 one. It has a lot of histor