Re: [Mesa-dev] [PATCH 0/6] Initial no-op implementation of `precise`

2014-06-03 Thread Jordan Justen
Based on the results of your piglit tests on NVidia, there might be some follow up tweaks to this. But, series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Sat, Apr 26, 2014 at 9:03 PM, Chris Forbes chr...@ijw.co.nz wrote: This series adds compiler support for the `precise` qualifier

Re: [Mesa-dev] Mesa IR as a list of instructions

2014-06-03 Thread Erik Faye-Lund
On Fri, May 30, 2014 at 9:22 PM, Eric Anholt e...@anholt.net wrote: However, talking yesterday about SSA and vector representations, we again failed to come up with anything that sounded compelling -- it appears that SSA is going to make obvious optimizations like dead code elimination in a

Re: [Mesa-dev] [PATCH 1/4] vl: add more avc profiles

2014-06-03 Thread Christian König
Reviewed and pushed. Thanks, Christian. Am 30.05.2014 21:57, schrieb Leo Liu: Signed-off-by: Leo Liu leo@amd.com --- src/gallium/auxiliary/util/u_video.h | 4 src/gallium/include/pipe/p_video_enums.h | 6 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] i965: Add runtime checks for line antialiasing in Gen 6.

2014-06-03 Thread Iago Toral
On Thu, 2014-05-29 at 08:31 -0700, Kenneth Graunke wrote: (...) + emit(IF(BRW_PREDICATE_NORMAL)); + { + /* Shift message header one register since we are not sending + * AA data stored in base_mrf+2 + */ + do_emit_fb_write(target, base_mrf +

[Mesa-dev] [PATCH] r600g, radeonsi: implement PIPE_QUERY_TIMESTAMP_DISJOINT

2014-06-03 Thread Marek Olšák
From: David Heidelberger david.heidelber...@ixit.cz v2 Marek: set the query result correctly Signed-off-by: David Heidelberger david.heidelber...@ixit.cz Signed-off-by: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/r600_query.c | 12 1 file changed, 12

Re: [Mesa-dev] [PATCH 2/3] radeon/compute: Implement PIPE_COMPUTE_CAP_MAX_COMPUTE_UNITS

2014-06-03 Thread Alex Deucher
On Mon, Jun 2, 2014 at 7:34 PM, Bruno Jimenez brunoji...@gmail.com wrote: On Mon, 2014-06-02 at 16:16 -0400, Alex Deucher wrote: On Sat, May 31, 2014 at 7:13 AM, Bruno Jimenez brunoji...@gmail.com wrote: On Fri, 2014-05-30 at 19:33 -0400, Alex Deucher wrote: On Fri, May 30, 2014 at 11:31 AM,

[Mesa-dev] [PATCH 0/2] Build a driswrast-using libGL on non-DRM targets

2014-06-03 Thread Jon TURNEY
As a follow-up to my Fix Apple-DRI GLX patchset, allow building of a libGL capable of using driswrast on targets without libdrm, and make that the default configuration. The --disable-driglx-direct option only appears to exist for the benefit of such targets, so it could probably be removed

[Mesa-dev] [PATCH 1/2] glx: Fix build in GLX_DIRECT_RENDERING !GLX_USE_APPLEGL !GLX_USE_DRM case

2014-06-03 Thread Jon TURNEY
Some untangling to fix building in the dri_platform=none, --enable-driglx-direct case, where only driswast can be used. Turn the test for including the glXGetScreenDriver()/glXGetScreenDriver() interface used by xdriinfo from !GLX_USE_APPLEGL into a positive form, as it is only useful when

[Mesa-dev] [PATCH 2/2] configure: Always default to --enable-driglx-direct

2014-06-03 Thread Jon TURNEY
Always default to --enable-driglx-direct, now that will build driswrast, but won't try to use dri[123] on platforms which don't have that. Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- configure.ac | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] glx: Fix build in GLX_DIRECT_RENDERING !GLX_USE_APPLEGL !GLX_USE_DRM case

2014-06-03 Thread Aaron Watry
On Tue, Jun 3, 2014 at 8:14 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Some untangling to fix building in the dri_platform=none, --enable-driglx-direct case, where only driswast can be used. Turn the test for including the glXGetScreenDriver()/glXGetScreenDriver() interface used by

Re: [Mesa-dev] [PATCH 1/2] glx: Fix build in GLX_DIRECT_RENDERING !GLX_USE_APPLEGL !GLX_USE_DRM case

2014-06-03 Thread Jon TURNEY
On 03/06/2014 15:19, Aaron Watry wrote: On Tue, Jun 3, 2014 at 8:14 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Some untangling to fix building in the dri_platform=none, --enable-driglx-direct case, where only driswast can be used. Turn the test for including the

Re: [Mesa-dev] [PATCH 0/2] Build a driswrast-using libGL on non-DRM targets

2014-06-03 Thread Emil Velikov
On 03/06/14 14:14, Jon TURNEY wrote: As a follow-up to my Fix Apple-DRI GLX patchset, allow building of a libGL capable of using driswrast on targets without libdrm, and make that the default configuration. The --disable-driglx-direct option only appears to exist for the benefit of

Re: [Mesa-dev] [PATCH 2/2] configure: Always default to --enable-driglx-direct

2014-06-03 Thread Matt Turner
On Tue, Jun 3, 2014 at 6:14 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Always default to --enable-driglx-direct, now that will build driswrast, but won't try to use dri[123] on platforms which don't have that. Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- configure.ac |

[Mesa-dev] [PATCH] wgl: Disable CRT message boxes when Windows system error messages boxes are disabled.

2014-06-03 Thread jfonseca
From: José Fonseca jfons...@vmware.com At least on MSVC we statically link against the CRT, so we must disable the CRT message boxes if we want to attended testing. The messages are convenient when running manually, so let them be if the system error message boxes are not disabled. ---

Re: [Mesa-dev] [PATCH] wgl: Disable CRT message boxes when Windows system error messages boxes are disabled.

2014-06-03 Thread Jose Fonseca
- Original Message - From: José Fonseca jfons...@vmware.com At least on MSVC we statically link against the CRT, so we must disable the CRT message boxes if we want to attended testing. oops: to attended - unattended Jose The messages are convenient when running manually, so let

Re: [Mesa-dev] [PATCH] wgl: Disable CRT message boxes when Windows system error messages boxes are disabled.

2014-06-03 Thread Brian Paul
I might replace boxes with dialogs but it's not a big deal. I guess the same comment would apply to the piglit patch. Reviewed-by: Brian Paul bri...@vmware.com On 06/03/2014 11:27 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com At least on MSVC we statically link

[Mesa-dev] [PATCH v2 0/4] Constant folding of new Instructions

2014-06-03 Thread Tobias Klausmann
And another try for constant folding of Instructions for nvc0. Please Review this! Thanks, Tobias Klausmann Tobias Klausmann (4): nvc0/ir: clear subop when folding constant expressions nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions nvc0/ir: Handle

[Mesa-dev] [PATCH v2 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH v2 3/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp

[Mesa-dev] [PATCH v2 4/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-06-03 Thread Tobias Klausmann
V2: Add support for a single-argument version of POPCNT for Maxwell (SM5) Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git

[Mesa-dev] [PATCH v2 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-06-03 Thread Tobias Klausmann
V2: Handle the instruction right (shift after reverse) Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 4/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-06-03 Thread Ilia Mirkin
On Tue, Jun 3, 2014 at 4:58 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: V2: Add support for a single-argument version of POPCNT for Maxwell (SM5) Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de ---

[Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Sinclair Yeh
v2: Incorporated feedback from idr - moved the check to a higher level function. v1: We have customers using NULL as a way to test the robustness of the API. Without this check, EGL will segfault trying to dereference dri2_surf-wl_win-private because wl_win is NULL. This fix adds a check and

Re: [Mesa-dev] [PATCH v2 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-06-03 Thread Ilia Mirkin
On Tue, Jun 3, 2014 at 4:58 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: V2: Handle the instruction right (shift after reverse) Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 16

Re: [Mesa-dev] [PATCH v2 3/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-06-03 Thread Ilia Mirkin
On Tue, Jun 3, 2014 at 4:58 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-03 Thread Ilia Mirkin
On Tue, Jun 3, 2014 at 4:58 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de Reviewed-by: Ilia

Re: [Mesa-dev] [PATCH 05/19] i965/fs: Loop from 0 to inst-sources, not 0 to 3.

2014-06-03 Thread Ian Romanick
On 06/02/2014 05:49 PM, Kenneth Graunke wrote: On Monday, June 02, 2014 03:48:23 PM Ian Romanick wrote: On 05/31/2014 10:11 PM, Kenneth Graunke wrote: On Tuesday, May 27, 2014 06:47:36 PM Matt Turner wrote: [snip] diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp

Re: [Mesa-dev] [PATCH:mesa] Use -z defs instead of --no-undefined on Solaris

2014-06-03 Thread Ian Romanick
On 06/02/2014 06:07 PM, Alan Coopersmith wrote: While recent versions of the Solaris linker support --no-undefined, older ones do not, and even current ones get confused if the Makefile passes one form and libtool sneaks in the other. Signed-off-by: Alan Coopersmith

Re: [Mesa-dev] [PATCH V2 7/9] glsl: Add support for comparing function parameter conversions

2014-06-03 Thread Jordan Justen
On Sun, May 4, 2014 at 1:24 AM, Chris Forbes chr...@ijw.co.nz wrote: The ARB_gpu_shader5 spec says: To determine whether the conversion for a single argument in one match is better than that for another match, the following rules are applied, in order: 1. An exact match is better than a

Re: [Mesa-dev] [PATCH V2 8/9] glsl: Implement overload resolution for ARB_gpu_shader5

2014-06-03 Thread Jordan Justen
On Sun, May 4, 2014 at 1:24 AM, Chris Forbes chr...@ijw.co.nz wrote: The ARB_gpu_shader5 spec says: A function definition A is considered a better match than function definition B if: * for at least one function argument, the conversion for that argument in A is better than the

[Mesa-dev] [PATCH v3 0/4] Constant folding of new Instructions

2014-06-03 Thread Tobias Klausmann
Yet another try for constant folding of Instructions for nvc0. Please Review this again! (Hopefully the last time ;-) ) Tobias Klausmann (4): nvc0/ir: clear subop when folding constant expressions nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions nvc0/ir:

[Mesa-dev] [PATCH v3 4/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: Add support for a single-argument version of POPCNT for Maxwell (SM5) V3: Clean up a bit more src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git

[Mesa-dev] [PATCH v3 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V2: Handle the instruction right (shift after reverse) V3: Reverse once, not independently for every TYPE src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 12 ++-- 1 file changed, 10 insertions(+), 2

[Mesa-dev] [PATCH v3 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 +

[Mesa-dev] [PATCH v3 3/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- V3: Use BuildUtil for the Immediate instead of a type conversion .../drivers/nouveau/codegen/nv50_ir_peephole.cpp| 17 + 1 file changed, 17 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Chad Versace
On Tue, Jun 03, 2014 at 02:00:13PM -0700, Sinclair Yeh wrote: v2: Incorporated feedback from idr - moved the check to a higher level function. v1: We have customers using NULL as a way to test the robustness of the API. Without this check, EGL will segfault trying to dereference

Re: [Mesa-dev] [PATCH v3 0/4] Constant folding of new Instructions

2014-06-03 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu There are a few minor formatting items that I'll take care of before pushing this out later tonight... take a look at the changes I made for the future :) On Tue, Jun 3, 2014 at 6:35 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de

Re: [Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Chad Versace
On Tue, Jun 03, 2014 at 03:42:32PM -0700, Chad Versace wrote: On Tue, Jun 03, 2014 at 02:00:13PM -0700, Sinclair Yeh wrote: v2: Incorporated feedback from idr - moved the check to a higher level function. v1: We have customers using NULL as a way to test the robustness of the API.

Re: [Mesa-dev] [PATCH V2 8/9] glsl: Implement overload resolution for ARB_gpu_shader5

2014-06-03 Thread Chris Forbes
OK, I'll move the various spec references into the code, cite GLSL 4.00 rather than the extension where possible, and throw in some more comments to clarify the stranger bits. Thanks for the review :) -- Chris On Wed, Jun 4, 2014 at 10:30 AM, Jordan Justen jljus...@gmail.com wrote: On Sun,

[Mesa-dev] Fix negation source modifer when used with logical instructions on Broadwell

2014-06-03 Thread Abdiel Janulgue
The negation source modifer for logical instructions changed its meaning on Broadwell that can cause the source bits to be inverted. This patch series addresses a current issue in our Broadwell driver where a shader could cause the negation source modifier to be set on logical operations and

[Mesa-dev] [PATCH 3/6] i965/fs: skip copy-propate for negated logical instructions and 'NOT' src registers

2014-06-03 Thread Abdiel Janulgue
The negation source modifier on src registers has changed meaning in Broadwell when used with logical operations. Make sure copy propagation occurs only for original statements that does not have negated source registers and destination instruction is not a logical op. In addition, since we

[Mesa-dev] [PATCH 4/6] i965/vec4: copy propagate 'NOT' instruction when used with logical operation

2014-06-03 Thread Abdiel Janulgue
On Broadwell, this reduces the instruction to 1 operation when 'NOT' is used with a logical instruction. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_vec4.h | 4 +- .../drivers/dri/i965/brw_vec4_copy_propagation.cpp | 62

[Mesa-dev] [PATCH 1/6] i965/fs: Refactor check for potential copy propagated instructions.

2014-06-03 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 27 ++ 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp

[Mesa-dev] [PATCH 5/6] i965/vec4: skip copy-propate for negated logical instructions and 'NOT' src registers

2014-06-03 Thread Abdiel Janulgue
The negation source modifier on src registers has changed meaning in Broadwell when used with logical operations. On the vec4 backend, make sure copy propagation occurs only for original statements that does not have negated source registers and destination instruction is not a logical op.

[Mesa-dev] [PATCH 6/6] i965/disasm: Properly debug negate source modifier for logical instructions

2014-06-03 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/gen8_disasm.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_disasm.c b/src/mesa/drivers/dri/i965/gen8_disasm.c index

[Mesa-dev] [PATCH 2/6] i965/fs: copy propagate 'NOT' instruction when used with logical operation

2014-06-03 Thread Abdiel Janulgue
On Broadwell, this reduces the instruction to 1 operation when NOT is used with a logical instruction Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH] configure.ac: Do not use Pthreads with MinGW.

2014-06-03 Thread Vinson Lee
Match the behavior of the SCons MinGW build. This patch also fixes these build errors. CC glapi_entrypoint.lo glapi_entrypoint.c: In function 'init_glapi_relocs_once': glapi_entrypoint.c:341:4: error: unknown type name 'pthread_once_t' static pthread_once_t once_control =

Re: [Mesa-dev] [PATCH] configure.ac: Do not use Pthreads with MinGW.

2014-06-03 Thread Matt Turner
On Tue, Jun 3, 2014 at 5:06 PM, Vinson Lee v...@freedesktop.org wrote: Match the behavior of the SCons MinGW build. This patch also fixes these build errors. CC glapi_entrypoint.lo glapi_entrypoint.c: In function 'init_glapi_relocs_once': glapi_entrypoint.c:341:4: error: unknown

Re: [Mesa-dev] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-03 Thread Ian Romanick
On 06/03/2014 03:47 PM, Chad Versace wrote: On Tue, Jun 03, 2014 at 03:42:32PM -0700, Chad Versace wrote: On Tue, Jun 03, 2014 at 02:00:13PM -0700, Sinclair Yeh wrote: v2: Incorporated feedback from idr - moved the check to a higher level function. v1: We have customers using NULL as a way

[Mesa-dev] [PATCH v2] configure.ac: Do not use Pthreads with MinGW.

2014-06-03 Thread Vinson Lee
Match the behavior of the SCons MinGW build. This patch also fixes these build errors. CC glapi_entrypoint.lo glapi_entrypoint.c: In function 'init_glapi_relocs_once': glapi_entrypoint.c:341:4: error: unknown type name 'pthread_once_t' static pthread_once_t once_control =

Re: [Mesa-dev] [PATCH v2] configure.ac: Do not use Pthreads with MinGW.

2014-06-03 Thread Matt Turner
Seems fine to me. Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 00/20] shader compiler cache

2014-06-03 Thread Tapani
On 06/02/2014 09:22 PM, Kenneth Graunke wrote: On Monday, June 02, 2014 07:44:15 PM Benjamin Bellec wrote: [snip] The canary error on Google points to a previously closed bug from glsl-compiler : https://bugs.freedesktop.org/show_bug.cgi?id=58039 It's probably unrelated - failing the canary