On Thu, 2014-06-19 at 15:18 -0700, Ian Romanick wrote:
On 06/19/2014 03:37 AM, Iago Toral wrote:
After having a quick look at ir_to_mesa.cpp and st_glsl_to_tgsi.cpp I
have some comments and questions about this:
On Wed, 2014-06-18 at 13:31 -0700, Ian Romanick wrote:
This patch should
I'll give it another whirl tonight, if I can find the time.
19. juni 2014 23:25 skrev Emil Velikov emil.l.veli...@gmail.com
følgende:
On 19/06/14 21:35, Thomas Helland wrote:
Hi,
I tried pulling down your git-branch, and test it out.
(I'm running Intel graphics on Ivy-Bridge, Arch
On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote:
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote:
(...)
+ /* From the ARB_gpu_shader5 spec:
+ *
+ * Multiple vertex streams are supported only if the output
primitive
+ *type is declared to be points.
---
Following Ian's comments on patch 9/23 of the multi-stream support series
about moving away from GL types in things that are not visible to the GL
API it makes sense to do the same for UsesEndPrimitive.
src/mesa/main/mtypes.h| 4 ++--
src/mesa/main/shaderobj.c | 2 +-
2 files changed, 3
---
src/glsl/builtin_functions.cpp | 60 +-
1 file changed, 59 insertions(+), 1 deletion(-)
diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
index eadc20c..5178eef 100644
--- a/src/glsl/builtin_functions.cpp
+++
This will be necessary to implement EndStreamPrimitive().
EndPrimitive() will produce an ir_end_primitive with the default stream 0.
---
src/glsl/builtin_functions.cpp | 3 ++-
src/glsl/ir.h| 17 +
src/glsl/ir_hierarchical_visitor.cpp | 25
This will be necessary to implement EmitStreamVertex().
EmitVertex() will produce an ir_emit_vertex with the default stream 0.
---
src/glsl/builtin_functions.cpp | 3 ++-
src/glsl/ir.h| 17 +
src/glsl/ir_hierarchical_visitor.cpp | 25
This splits the patch as requested, notice that I have not done anything to
ir_to_mesa.cpp or st_glsl_to_tgsi.cpp since as I explain in another reply I
think there is nothing to change in these files in the end.
Iago Toral Quiroga (3):
glsl: Modify ir_emit_vertex to have a stream.
glsl:
On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote:
Hi,
Hi Bruno,
I have added mesa list to CC as others might be interested. Hope you
don't mind.
I have built babl and gegl but I don't know how to run the OpenCL tests.
Inside the tests/opencl directory there's just .xml files and there
https://bugs.freedesktop.org/show_bug.cgi?id=79230
--- Comment #9 from war...@o2.pl ---
This ticket can be closed. 10.2.1 cross-compiles now OK without any patches.
Thx!
--
You are receiving this mail because:
You are the assignee for the bug.
___
On Fri, 2014-06-20 at 09:31 -0400, Jan Vesely wrote:
On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote:
Hi,
Hi Bruno,
I have added mesa list to CC as others might be interested. Hope you
don't mind.
Sure, no problem.
I have built babl and gegl but I don't know how to run the
On 06/18/2014 01:45 PM, Kenneth Graunke wrote:
On Wednesday, June 18, 2014 11:16:47 AM Ian Romanick wrote:
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
This implements parsing requirements for multi-stream support in
geometry shaders
On Wed, Jun 18, 2014 at 05:01:50PM +0200, Bruno Jiménez wrote:
Hi,
This is my second attempt to fix the mapping bug adding all the
suggestions that Tom Stellard sent, and, so far, it seems that
it is resolved.
This series changes completely how OpenCL buffers are handled
by the r600g
On Fri, 2014-06-20 at 13:50 -0400, Tom Stellard wrote:
On Wed, Jun 18, 2014 at 05:01:50PM +0200, Bruno Jiménez wrote:
Hi,
This is my second attempt to fix the mapping bug adding all the
suggestions that Tom Stellard sent, and, so far, it seems that
it is resolved.
This series
https://bugs.freedesktop.org/show_bug.cgi?id=54372
--- Comment #24 from Ian Romanick i...@freedesktop.org ---
I pushed the first patch to master, and it should end up in the next 10.2
release and probably in the final 10.1 release. Could you send your other
patches to the mesa-dev mailing list
On Fri, 2014-06-20 at 19:46 +0200, Bruno Jimenez wrote:
On Fri, 2014-06-20 at 09:31 -0400, Jan Vesely wrote:
On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote:
Hi,
Hi Bruno,
I have added mesa list to CC as others might be interested. Hope you
don't mind.
Sure, no problem.
On 06/19/2014 12:02 AM, Kenneth Graunke wrote:
When the last context in a share group is destroyed, the hash table
containing all of the shader programs (ctx-Shared-ShaderObjects) is
destroyed, throwing away all of the shader programs.
Using a static variable to store program IDs ends up
https://bugs.freedesktop.org/show_bug.cgi?id=80266
Ilia Mirkin imir...@alum.mit.edu changed:
What|Removed |Added
Assignee|nouveau@lists.freedesktop.o
https://bugs.freedesktop.org/show_bug.cgi?id=80266
--- Comment #10 from Patrick Baggett baggett.patr...@gmail.com ---
(In reply to comment #5)
Does gcc warn about this? Are you _sure_ that (signed int)1 31 is illegal
in C99?
And as tedious as this is to mention, C99 section 6.5.7.4 does state
https://bugs.freedesktop.org/show_bug.cgi?id=80266
--- Comment #11 from Vittorio zec...@gmail.com ---
Another one in nouveau_fence.c:170
#define NOUVEAU_FENCE_MAX_SPINS (1 31)
should be
#define NOUVEAU_FENCE_MAX_SPINS (1U 31)
--
You are receiving this mail because:
You are the assignee for the
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
Check calloc return value and report on error, also later skip
results handling if there was no memory to store results to.
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
Check intel_miptree_create() return value before using it as
a pointer.
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
src/mesa/drivers/dri/i965/intel_tex.c | 3 +++
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
check variable_storage() found the requested fs_reg.
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 ++
1 file
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
src/glsl/link_uniform_blocks.cpp | 6 ++
src/glsl/linker.cpp | 2 ++
2 files changed, 8 insertions(+)
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
Report memory error on realloc failure and don't leak any memory.
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
src/glsl/link_atomics.cpp | 13 +++--
1 file
Signed-off-by: Aaron Watry awa...@gmail.com
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
index df26883..413a0c2 100644
---
On Fri, Jun 20, 2014 at 07:14:43PM -0500, Aaron Watry wrote:
Signed-off-by: Aaron Watry awa...@gmail.com
Reviewed-by: Tom Stellard thomas.stell...@amd.com
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Hi again,
Autogen seems to work flawlessly with the updated branch.
Everything builds and compiles as normal on my Ivy Bridge setup.
When trying to do a make install though, something fails.
I'm not sure if it's related to your changes, but at least master gets
further into the process before
From: Ian Romanick ian.d.roman...@intel.com
In file included from ../../src/glsl/builtin_functions.cpp:61:0:
../../src/glsl/glsl_parser_extras.h:154:9: warning: unused parameter 'var'
[-Wunused-parameter]
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: Tapani Pälli
On Friday, June 20, 2014 10:01:40 AM Iago Toral Quiroga wrote:
---
Following Ian's comments on patch 9/23 of the multi-stream support series
about moving away from GL types in things that are not visible to the GL
API it makes sense to do the same for UsesEndPrimitive.
From: Ian Romanick ian.d.roman...@intel.com
Fixes the (new) piglit tests gles-3.0-drawarrays-vertexid,
gl-3.0-multidrawarrays-vertexid, and gl-3.2-basevertex-vertexid.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80247
Cc: 10.2
From: Ian Romanick ian.d.roman...@intel.com
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: 10.2 mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_vec4_vs_visitor.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_vs_visitor.cpp
From: Ian Romanick ian.d.roman...@intel.com
Converts gl_VertexID to (gl_VertexIDMESA + gl_BaseVertex). gl_VertexIDMESA
is backed by SYSTEM_VALUE_VERTEX_ID_ZERO_BASE, and gl_BaseVertex is backed
by a built-in uniform from {STATE_INTERNAL, STATE_BASE_VERTEX}.
NOTE: The enum has to be declared
From: Ian Romanick ian.d.roman...@intel.com
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: Ilia Mirkin imir...@alum.mit.edu
Cc: Marek Olšák marek.ol...@amd.com
Cc: Roland Scheidegger srol...@vmware.com
Cc: 10.2 mesa-sta...@lists.freedesktop.org
---
From: Ian Romanick ian.d.roman...@intel.com
This is a uniform that represents the basevertex value passed to
glDrawElementsBaseVertex and related functions. For hardware that does
not implement a hardware register for SYSTEM_VALUE_BASE_VERTEX, passing
the value via a uniform is the only way to
This patch series fixes bugs in the i965 w.r.t. several uses of
gl_VertexID. OpenGL (desktop and ES) have the following expectations of
gl_VertexID:
1. When used with BaseVertex drawing commands, gl_VertexID will include
the value of basevertex. This differens from the other API, but the
change
From: Ian Romanick ian.d.roman...@intel.com
Future patches will rearrange the values in gl_system_value, and I want
to catch errors. Designated initializers would make all of this
unnecessary.
v2: Don't use STATIC_ASSERT. Not only does it not work, but GCC doesn't
tell you that it's not going
From: Ian Romanick ian.d.roman...@intel.com
There exists hardware, such as i965, that does not implement the OpenGL
semantic for gl_VertexID. Instead, that hardware does not include the
value of basevertex in the gl_VertexID value.
SYSTEM_VALUE_VERTEX_ID_ZERO_BASE is the system value that
From: Ian Romanick ian.d.roman...@intel.com
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: 10.2 mesa-sta...@lists.freedesktop.org
---
src/mesa/main/mtypes.h | 48
1 file changed, 48 insertions(+)
diff --git a/src/mesa/main/mtypes.h
From: Ian Romanick ian.d.roman...@intel.com
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: 10.2 mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_draw.c | 37
1 file changed, 37 insertions(+)
diff --git
From: Ian Romanick ian.d.roman...@intel.com
Future patches will necessitate changes to the table, and I only want to
update one.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: Ilia Mirkin imir...@alum.mit.edu
Cc: Marek Olšák marek.ol...@amd.com
Cc: Roland Scheidegger srol...@vmware.com
From: Ian Romanick ian.d.roman...@intel.com
The next patch will use this function in a different file.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: 10.2 mesa-sta...@lists.freedesktop.org
---
src/glsl/linker.cpp | 9 +
src/glsl/linker.h | 3 +++
2 files changed, 8
From: Ian Romanick ian.d.roman...@intel.com
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: Ilia Mirkin imir...@alum.mit.edu
Cc: Marek Olšák marek.ol...@amd.com
Cc: Roland Scheidegger srol...@vmware.com
Cc: 10.2 mesa-sta...@lists.freedesktop.org
---
src/mesa/main/mtypes.h
From: Ian Romanick ian.d.roman...@intel.com
This system value represents the basevertex value passed to
glDrawElementsBaseVertex and related functions.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: 10.2 mesa-sta...@lists.freedesktop.org
---
src/mesa/main/mtypes.h
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
Check calloc return value while adding build-in functions.
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
src/glsl/linker.cpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/glsl/linker.cpp
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
src/mesa/main/vdpau.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/vdpau.c
This is
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
but we should probably have someone familiar with that code also review
it. Christian?
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
Verify _mesa_lookup_texture() returned valid pointer before using it.
Signed-off-by:
On 06/19/2014 05:24 AM, Juha-Pekka Heikkila wrote:
For GLX_BACK_BUFFER_AGE_EXT query added extra null check.
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com
---
src/glx/glx_pbuffer.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
On Fri, 2014-06-20 at 10:46 -0700, Ian Romanick wrote:
I care a lot less about what is often done than I do about what
should be done. If there is an argument to be made that stand-alone
comments (not on a line with other code) are better, that would be good
data to have.
Well I'm not sure
49 matches
Mail list logo
