Re: [Mesa-dev] [PATCH try 2 2/2] gallium/nouveau: move pushbuf and fences to context

2014-06-23 Thread Maarten Lankhorst
op 21-06-14 14:12, Ilia Mirkin schreef: On Tue, Jun 17, 2014 at 2:34 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: nv30 seems to not support dma objects with offset, so simply extend the query_heap to cover the entire notifier, and use a offset in nv30_context_kick_notify. It

Re: [Mesa-dev] [PATCH try 2 2/2] gallium/nouveau: move pushbuf and fences to context

2014-06-23 Thread Ben Skeggs
On Mon, Jun 23, 2014 at 5:17 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 21-06-14 14:12, Ilia Mirkin schreef: On Tue, Jun 17, 2014 at 2:34 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: nv30 seems to not support dma objects with offset, so simply extend the

Re: [Mesa-dev] [PATCH try 2 2/2] gallium/nouveau: move pushbuf and fences to context

2014-06-23 Thread Maarten Lankhorst
op 23-06-14 09:24, Ben Skeggs schreef: On Mon, Jun 23, 2014 at 5:17 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 21-06-14 14:12, Ilia Mirkin schreef: On Tue, Jun 17, 2014 at 2:34 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: nv30 seems to not support dma

Re: [Mesa-dev] [PATCH try 2 2/2] gallium/nouveau: move pushbuf and fences to context

2014-06-23 Thread Ben Skeggs
On Mon, Jun 23, 2014 at 5:39 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 23-06-14 09:24, Ben Skeggs schreef: On Mon, Jun 23, 2014 at 5:17 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 21-06-14 14:12, Ilia Mirkin schreef: On Tue, Jun 17, 2014 at 2:34 AM,

Re: [Mesa-dev] [PATCH 08/11] GLX/DRI3: Add GPU offloading support.

2014-06-23 Thread Michel Dänzer
On 19.06.2014 12:27, Axel Davy wrote: The differences with DRI2 GPU offloading are: . There's no logic for GPU offloading needed in the Xserver . for DRI2, the card would render to a back buffer, and the content would be copied to the front buffer (the same buffers everytime). Here we can

Re: [Mesa-dev] [PATCH] meta: Use AMD_vertex_shader_layer instead of a GS for layered clears.

2014-06-23 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz Have you got a case where this makes a noticeable difference to performance? On Mon, Jun 23, 2014 at 5:27 PM, Kenneth Graunke kenn...@whitecape.org wrote: On i965, enabling and disabling the GS is not free: you have to do a full pipeline stall,

Re: [Mesa-dev] [PATCH 4/4] nvc0: enable ARB_fragment_layer_viewport

2014-06-23 Thread Roland Scheidegger
Am 22.06.2014 17:10, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 2 ++

Re: [Mesa-dev] [PATCH 4/4] nvc0: enable ARB_fragment_layer_viewport

2014-06-23 Thread Roland Scheidegger
Am 23.06.2014 12:49, schrieb Roland Scheidegger: Am 22.06.2014 17:10, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 2 +-

Re: [Mesa-dev] [PATCH 4/4] nvc0: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 7:55 AM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 12:49, schrieb Roland Scheidegger: Am 22.06.2014 17:10, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- docs/GL3.txt| 2 +-

Re: [Mesa-dev] [PATCH] meta: Use AMD_vertex_shader_layer instead of a GS for layered clears.

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 1:27 AM, Kenneth Graunke kenn...@whitecape.org wrote: On i965, enabling and disabling the GS is not free: you have to do a full pipeline stall, reconfigure the URB and push constant space, and emit a bunch of state. Most clears aren't layered, so the GS isn't needed in

[Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
If multiple viewports are supported, that implies the presence of a GS and layered rendering, so we can enable ARB_fragment_layer_viewport as well. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Untested on r600, but nv50/nvc0/llvmpipe seem to pass basic testing. docs/GL3.txt

[Mesa-dev] [PATCH v2 1/3] mesa/st: handle gl_Layer input semantic

2014-06-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Reviewed-by: Marek Olšák marek.ol...@amd.com --- src/mesa/state_tracker/st_program.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 26eb978..1df411c 100644

[Mesa-dev] [PATCH v2 2/3] nvc0: allow VIEWPORT_INDEX and LAYER to be used as input semantics

2014-06-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_program.c b/src/gallium/drivers/nouveau/nvc0/nvc0_program.c index 667fbc8..ad8d1b0 100644 ---

Re: [Mesa-dev] patch: fix glxusexfont

2014-06-23 Thread Brian Paul
On 06/22/2014 10:57 AM, Daniel Manjarres wrote: Author: Daniel Manjarres danm...@gmail.com Date: Sun Jun 22 09:47:58 2014 -0700 glx: Fix glxUseXFont for glxWindow and glxPixmaps The current implementation of glxUseXFont requires creating a temporary pixmap and graphics

Re: [Mesa-dev] [PATCH 1/4] glxinfo: Print XFB, TBO, and UBO limits

2014-06-23 Thread Brian Paul
I happened to add some of this to glxinfo last week. I'll rebase Fredrik's patch on the latest (refactored) glxinfo... -Brian On 06/22/2014 09:55 AM, Ilia Mirkin wrote: Fredrik, What happened to this series? -ilia On Thu, Apr 10, 2014 at 10:09 AM, Brian Paul bri...@vmware.com wrote:

[Mesa-dev] [PATCH] glxinfo: Print XFB, TBO, and UBO limits

2014-06-23 Thread Brian Paul
From: Fredrik Höglund fred...@kde.org Updated patch for refactored glxinfo/wglinfo code by Brian Paul. Signed-off-by: Brian Paul bri...@vmware.com --- src/xdemos/glinfo_common.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/xdemos/glinfo_common.c

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 9:39 AM, Ilia Mirkin imir...@alum.mit.edu wrote: If multiple viewports are supported, that implies the presence of a GS and layered rendering, so we can enable ARB_fragment_layer_viewport as well. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Untested on r600,

[Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-23 Thread Jan Vesely
The dst pointer needs to be initialized after any calls to compute_memory_grow_pool, as the function might change the pool-vbo pointer. This fixes crashes and assertion failures in two gegl tests. Signed-off-by: Jan Vesely jan.ves...@rutgers.edu CC: Bruno Jimenez brunoji...@gmail.com CC: Tom

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 9:51 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jun 23, 2014 at 9:39 AM, Ilia Mirkin imir...@alum.mit.edu wrote: If multiple viewports are supported, that implies the presence of a GS and layered rendering, so we can enable ARB_fragment_layer_viewport as well.

Re: [Mesa-dev] [PATCH try 2 2/2] gallium/nouveau: move pushbuf and fences to context

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 3:17 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 21-06-14 14:12, Ilia Mirkin schreef: On Tue, Jun 17, 2014 at 2:34 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: nv30 seems to not support dma objects with offset, so simply extend the

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Andy Furniss
Emil Velikov wrote: Hi all, These patches add support for building (grouping) the various targets per API, meaning that only one library will be created for e.g. vdpau (libvdpau_gallium) with individual ones (libvdpau_r600) being a hardlink to it. How is this supposed to work from a users

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Roland Scheidegger
Am 23.06.2014 16:43, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 9:51 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jun 23, 2014 at 9:39 AM, Ilia Mirkin imir...@alum.mit.edu wrote: If multiple viewports are supported, that implies the presence of a GS and layered rendering, so we can

Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-23 Thread Bruno Jimenez
On Mon, 2014-06-23 at 10:39 -0400, Jan Vesely wrote: The dst pointer needs to be initialized after any calls to compute_memory_grow_pool, as the function might change the pool-vbo pointer. You are completely right. Good catch. Reviewed-by: Bruno Jiménez brunoji...@gmail.com Sorry for any

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 11:06 AM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 16:43, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 9:51 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jun 23, 2014 at 9:39 AM, Ilia Mirkin imir...@alum.mit.edu wrote: If multiple viewports are

[Mesa-dev] [PATCH] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 1 + .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 27 -- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 11:24 AM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: Please add a brief description of what your change does and how it achieves this. [Let me know if you're not comfortable writing that, and I can compose it for you.] Among other things, note that it

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Roland Scheidegger
Am 23.06.2014 17:18, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 11:06 AM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 16:43, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 9:51 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jun 23, 2014 at 9:39 AM, Ilia Mirkin

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Emil Velikov
On 23/06/14 16:10, Andy Furniss wrote: Emil Velikov wrote: Hi all, These patches add support for building (grouping) the various targets per API, meaning that only one library will be created for e.g. vdpau (libvdpau_gallium) with individual ones (libvdpau_r600) being a hardlink to it.

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Aaron Watry
On my machine, ${PREFIX}/lib/vdpau contains: libvdpau_gallium.so.1 - libvdpau_r600.so.1.0.0 libvdpau_r600.so* libvdpau_radeonsi.so* Note that libvdpau_gallium.so.1 is only created when I force an ldconfig on my system (until then, I just have libvdpau_[r600|radeonsi]*) For some reason, while the

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 1:07 PM, Aaron Watry awa...@gmail.com wrote: On my machine, ${PREFIX}/lib/vdpau contains: libvdpau_gallium.so.1 - libvdpau_r600.so.1.0.0 libvdpau_r600.so* libvdpau_radeonsi.so* Note that libvdpau_gallium.so.1 is only created when I force an ldconfig on my system

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Andy Furniss
Emil Velikov wrote: Yes I had a few copy/paste typos that were causing make install to fall short when generating the (sym|hard)links. Should be fixed with commit 11e46a32aed. Let me know if latest master work for you. No, it fails to install anything to do with libvdpau_gallium* which is

Re: [Mesa-dev] [PATCH] glxinfo: Print XFB, TBO, and UBO limits

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 9:48 AM, Brian Paul bri...@vmware.com wrote: From: Fredrik Höglund fred...@kde.org Updated patch for refactored glxinfo/wglinfo code by Brian Paul. There were more patches that added more things... http://patchwork.freedesktop.org/project/mesa/list/?q=glxinfo BTW, is

[Mesa-dev] [PATCH] targets/(vdpau|xvmc): hardlink against the installed library

2014-06-23 Thread Emil Velikov
Previous two commits, resolved the symlink generation required by the versioning of the library and incorrectly changed the way hardlinks are created by linking the ones from the build tree. If the device used for building differs from the one set as destination linking will fail. Reported-by:

Re: [Mesa-dev] [PATCH 10/13] glsl: Add a lowering pass for gl_VertexID

2014-06-23 Thread Ian Romanick
On 06/22/2014 04:32 AM, Marek Olšák wrote: If you define enums in a struct or class, it then works like a namespace. E.g. the proper form to use such an enum would be: ctx-Const.VertexID = gl_constants::gl_VertexID_native; I'd swear that I tried that... I know I tried a bunch of other

Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-06-23 Thread Ian Romanick
On 06/21/2014 08:36 AM, Roland Scheidegger wrote: Am 21.06.2014 03:00, schrieb Ian Romanick: This patch series fixes bugs in the i965 w.r.t. several uses of gl_VertexID. OpenGL (desktop and ES) have the following expectations of gl_VertexID: 1. When used with BaseVertex drawing commands,

[Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Neil Roberts
Previously the blorp blitter would only be used if the format is identical or there is only a difference between whether there is an alpha component or not. This patch makes it also allow the blorp blitter if the only difference is the ordering of the RGB components (ie, RGB or BGR). This is

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Emil Velikov
On 23/06/14 18:07, Aaron Watry wrote: On my machine, ${PREFIX}/lib/vdpau contains: libvdpau_gallium.so.1 - libvdpau_r600.so.1.0.0 libvdpau_r600.so* libvdpau_radeonsi.so* Note that libvdpau_gallium.so.1 is only created when I force an ldconfig on my system (until then, I just have

[Mesa-dev] [PATCH v2] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
previously, if we had something like: gl_ViewportIndex = idx; for(int i = 0; i gl_in.length(); i++) { gl_Position = gl_in[i].gl_Position; EmitVertex(); } EndPrimitive(); we failed to set the right ViewportIndex. To resolve this, save the ViewportIndex and store it to the right register on

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Aaron Watry
Using /usr/local as PREFIX and an empty /usr/local/lib/vdpau directory to start, after make install of mesa I end up with /usr/local/lib/vdpau/ containing: awatry@ws-awatry:/usr/local/lib/vdpau$ ls -l total 26944 lrwxrwxrwx 1 root root 22 Jun 23 13:25 libvdpau_r600.so -

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Matt Turner
On Mon, Jun 23, 2014 at 11:02 AM, Neil Roberts n...@linux.intel.com wrote: Previously the blorp blitter would only be used if the format is identical or there is only a difference between whether there is an alpha component or not. This patch makes it also allow the blorp blitter if the only

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Marek Olšák
On a different note, do we really need the suffixes .1.0.0 etc.? It's not like the version is going to change. Marek On Mon, Jun 23, 2014 at 8:31 PM, Aaron Watry awa...@gmail.com wrote: Using /usr/local as PREFIX and an empty /usr/local/lib/vdpau directory to start, after make install of mesa

Re: [Mesa-dev] [PATCH 2/5] clover: Fix not setting build log if the build succeeds.

2014-06-23 Thread Tom Stellard
On Sat, Jun 21, 2014 at 06:33:17PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: From: Matt Arsenault arse...@gmail.com If there were only warnings, they would not be added to the log. Also fixes valgrind use after free errors. ---

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Emil Velikov
On 23/06/14 19:31, Aaron Watry wrote: Using /usr/local as PREFIX and an empty /usr/local/lib/vdpau directory to start, after make install of mesa I end up with /usr/local/lib/vdpau/ containing: awatry@ws-awatry:/usr/local/lib/vdpau$ ls -l total 26944 lrwxrwxrwx 1 root root 22 Jun 23

Re: [Mesa-dev] [PATCH] targets/(vdpau|xvmc): hardlink against the installed library

2014-06-23 Thread Andy Furniss
Emil Velikov wrote: Previous two commits, resolved the symlink generation required by the versioning of the library and incorrectly changed the way hardlinks are created by linking the ones from the build tree. If the device used for building differs from the one set as destination linking will

Re: [Mesa-dev] [PATCH v2] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 2:15 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: previously, if we had something like: gl_ViewportIndex = idx; for(int i = 0; i gl_in.length(); i++) { gl_Position = gl_in[i].gl_Position; EmitVertex(); } EndPrimitive(); we failed to set

Re: [Mesa-dev] [PATCH] targets/(vdpau|xvmc): hardlink against the installed library

2014-06-23 Thread Emil Velikov
On 23/06/14 19:58, Andy Furniss wrote: Emil Velikov wrote: Previous two commits, resolved the symlink generation required by the versioning of the library and incorrectly changed the way hardlinks are created by linking the ones from the build tree. If the device used for building differs

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Neil Roberts
Matt Turner matts...@gmail.com writes: We typically write Bugzilla: https:/// Reviewed-by: Matt Turner matts...@gmail.com Do you have commit access? Thanks for the review. I do have commit access so I've pushed the patch with the suggested change to the commit message. I've also

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Emil Velikov
The vdpau loader requires only major, and falls back to an unversioned SO. Thus IMHO we should keep at least the major. In the future we might want to move to a versioning scheme similar to nvidia, which lacks the revision number, thus we'll be OK with the BSD guys :) libvdpau_nvidia.so -

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 12:01 PM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 17:18, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 11:06 AM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 16:43, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 9:51 AM, Ilia Mirkin

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Matt Turner
On Mon, Jun 23, 2014 at 12:06 PM, Neil Roberts n...@linux.intel.com wrote: Matt Turner matts...@gmail.com writes: We typically write Bugzilla: https:/// Reviewed-by: Matt Turner matts...@gmail.com Do you have commit access? Thanks for the review. I do have commit access so I've

Re: [Mesa-dev] [PATCH] targets/(vdpau|xvmc): hardlink against the installed library

2014-06-23 Thread Andy Furniss
Emil Velikov wrote: On 23/06/14 19:58, Andy Furniss wrote: I still don't get libvdpau_gallium installed. Not sure what made you believe that libvdpau_gallium should be installed, but that truly is not the case. Ahh, it was looking at the output of make install, which usually flies past

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Marek Olšák
If the version is always going to be 1.0.0, it's pointless. If it's going to be equal to the Mesa version, then it might find some use. Marek On Mon, Jun 23, 2014 at 9:12 PM, Emil Velikov emil.l.veli...@gmail.com wrote: The vdpau loader requires only major, and falls back to an unversioned SO.

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Emil Velikov
I'm afraid that I cannot predict the future (is always going to be..). IMHO we should keep the major, for when the loader gains different codepaths for v1.0 vs v2.0 etc. Adding the mesa version will easily allow us to check for broken/manged installs and possibly other issues. Don't plan on

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Roland Scheidegger
Am 23.06.2014 21:14, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 12:01 PM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 17:18, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 11:06 AM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 16:43, schrieb Ilia Mirkin: On

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 3:50 PM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 21:14, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 12:01 PM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 17:18, schrieb Ilia Mirkin: On Mon, Jun 23, 2014 at 11:06 AM, Roland

[Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread sroland
From: Roland Scheidegger srol...@vmware.com The old logic would let all negative values go through unclamped, with potentially disastrous results (probably trying to fetch viewport values from random memory locations). GL has undefined rendering for vp indices outside valid range but that's a bit

Re: [Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:08 PM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com The old logic would let all negative values go through unclamped, with potentially disastrous results (probably trying to fetch viewport values from random memory locations). GL has

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Aaron Watry
On Mon, Jun 23, 2014 at 1:54 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 23/06/14 19:31, Aaron Watry wrote: Using /usr/local as PREFIX and an empty /usr/local/lib/vdpau directory to start, after make install of mesa I end up with /usr/local/lib/vdpau/ containing:

[Mesa-dev] [PATCH 1/3] i965/vec4: Don't return void from a void function.

2014-06-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 7fd8c2b..f3316f8 100644 ---

[Mesa-dev] [PATCH 3/3] i965/fs: Don't fix_math_operand() on Gen = 8.

2014-06-23 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index d7b969e..185a1f6 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++

[Mesa-dev] [PATCH 2/3] i965/vec4: Don't fix_math_operand() on Gen = 8.

2014-06-23 Thread Matt Turner
The emit_math?_gen? functions serve to implement workarounds for the math instruction, none of which exist on Gen8+. --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp

Re: [Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

2014-06-23 Thread Tom Stellard
On Sun, Jun 22, 2014 at 04:05:49PM +0200, Francisco Jerez wrote: Bruno Jimenez brunoji...@gmail.com writes: On Sat, 2014-06-21 at 17:39 +0200, Francisco Jerez wrote: [...] The implementation of PIPE_TRANSFER_MAP_DIRECTLY introduced in PATCH 10 has somewhat worrying semantics: A mapping

Re: [Mesa-dev] [PATCH 4/4] nvc0: enable ARB_fragment_layer_viewport

2014-06-23 Thread Marek Olšák
The cap can be removed later if needed. Marek On Mon, Jun 23, 2014 at 2:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jun 23, 2014 at 7:55 AM, Roland Scheidegger srol...@vmware.com wrote: Am 23.06.2014 12:49, schrieb Roland Scheidegger: Am 22.06.2014 17:10, schrieb Ilia Mirkin:

Re: [Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread Jose Fonseca
LGTM. Jose From: srol...@vmware.com srol...@vmware.com Sent: 23 June 2014 21:08 To: Jose Fonseca; mesa-dev@lists.freedesktop.org; imir...@alum.mit.edu Cc: Roland Scheidegger; 10.1 10.2 Subject: [PATCH] draw: (trivial) fix clamping of viewport index From:

[Mesa-dev] [PATCH v3] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
previously, if we had something like: gl_ViewportIndex = idx; for(int i = 0; i gl_in.length(); i++) { gl_Position = gl_in[i].gl_Position; EmitVertex(); } EndPrimitive(); we failed to set the right ViewportIndex. To resolve this, save the ViewportIndex and store it to the right register on

Re: [Mesa-dev] [PATCH v3] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 5:01 PM, Tobias Klausmann tobias.johannes.klausm...@mni.thm.de wrote: previously, if we had something like: gl_ViewportIndex = idx; for(int i = 0; i gl_in.length(); i++) { gl_Position = gl_in[i].gl_Position; EmitVertex(); } EndPrimitive(); we failed to set

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-23 Thread Emil Velikov
On 23/06/14 21:21, Aaron Watry wrote: On Mon, Jun 23, 2014 at 1:54 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 23/06/14 19:31, Aaron Watry wrote: Using /usr/local as PREFIX and an empty /usr/local/lib/vdpau directory to start, after make install of mesa I end up with

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Don't return void from a void function.

2014-06-23 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/23/2014 01:30 PM, Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp

Re: [Mesa-dev] [PATCH] draw: (trivial) fix clamping of viewport index

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 4:13 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jun 23, 2014 at 4:08 PM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com The old logic would let all negative values go through unclamped, with potentially disastrous results (probably

Re: [Mesa-dev] [PATCH 4/4] nvc0: enable ARB_fragment_layer_viewport

2014-06-23 Thread Ilia Mirkin
Well, with Roland's fix to the draw module, llvmpipe works with my tests as well. Is it likely that r600 will work as-is, or do you think it'll require some fixes? I can try to find someone with the requisite hw... On Mon, Jun 23, 2014 at 4:57 PM, Marek Olšák mar...@gmail.com wrote: The cap can

Re: [Mesa-dev] [PATCH] mesa: Don't use derived vertex state in api_arrayelt.c

2014-06-23 Thread Carl Worth
Brian Paul brian.e.p...@gmail.com writes: On Friday 28 February 2014, Fredrik Höglund wrote: It's possible that this patch fixes a segfault in FlightGear (see bug 73504), so I think it's a candidate for the 10.1 branch, but maybe not for 10.1.0. Ping? I took a look. I guess we don't

Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-06-23 Thread Ian Romanick
On 06/21/2014 06:59 PM, Marek Olšák wrote: That's right. A uniform won't work with ARB_draw_indirect unless you lower it to direct draws, which would be very bad if it was applied to all drivers. Radeonsi indeed supports BaseVertex and BaseInstance as system values in the vertex shader.

Re: [Mesa-dev] [PATCH 02/15] glsl: Do not allow undefining the built-in macros

2014-06-23 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: Fixes piglit tests in spec/glsl-es-3.00/compile: ... Cc: mesa-sta...@lists.freedesktop.org For this change, (and other similar changes in the series, as well as subsequent pre-processor changes that I am writing), I'm deciding to generally not pick

Re: [Mesa-dev] [Mesa-stable] [PATCH] Fix zero-division in llvmpipe_texture_layout()

2014-06-23 Thread Carl Worth
Roland Scheidegger srol...@vmware.com writes: Am 07.06.2014 20:38, schrieb Johannes Obermayr: From: Takashi Iwai ti...@suse.de Fix the crash of gnome-control-center info invocation on QEMU where zero height is passed at init. ... Cc: 10.2 mesa-sta...@lists.freedesktop.org ... Reviewed-by:

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Don't emit SURFACE_STATEs for gather workarounds on Broadwell.

2014-06-23 Thread Kenneth Graunke
It did not. But, I just ran all of those tests with and without this patch, and there were no regressions. So, I think we're good. Pushed - thanks for the review! On Thursday, May 29, 2014 07:32:21 PM Chris Forbes wrote: Did this test run include forcing ARB_gpu_shader5 on? On Thu, May

Re: [Mesa-dev] [PATCH v3 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-23 Thread Carl Worth
Tobias Klausmann tobias.johannes.klausm...@mni.thm.de writes: Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Cc:

Re: [Mesa-dev] [PATCH 6/8] android, egl: typo dri2_fallback_pixmap_surface - dri2_fallback_create_pixmap_surface

2014-06-23 Thread Carl Worth
Adrian Negreanu gro...@gmail.com writes: I used commit bc8b07a6 as reference, and only the droid_display_vtbl had this issue. ... CC: 10.1 10.2 mesa-sta...@lists.freedesktop.org - .create_pixmap_surface = dri2_fallback_pixmap_surface, + .create_pixmap_surface =

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] radeon/uvd: disable VC-1 simple/main on UVD 2.x

2014-06-23 Thread pCarl Worth
Grigori Goronzy g...@chown.ath.cx writes: It's about as broken as on later UVD revisions. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66452 Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org This patch isn't picking over cleanly to 10.1. I didn't investigate what happened (a file

Re: [Mesa-dev] [PATCH v3 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-23 Thread Ilia Mirkin
On Mon, Jun 23, 2014 at 7:25 PM, Carl Worth cwo...@cworth.org wrote: Tobias Klausmann tobias.johannes.klausm...@mni.thm.de writes: Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann

[Mesa-dev] Candidate branches for 10.2.2 and 10.1.6

2014-06-23 Thread Carl Worth
Hi folks, I'm nearly done preparing the 10.1 and 10.2 branches for the next stable releases, (which will also be the final release on the 10.1 branch). The status of my 10.2 branch can be examined here: http://cworth.org/~cworth/mesa-stable-queue/ I'm pretty happy with what it looks

[Mesa-dev] Candidate branches for 10.2.2 and 10.1.6

2014-06-23 Thread Carl Worth
Hi folks, I'm nearly done preparing the 10.1 and 10.2 branches for the next stable releases, (which will also be the final release on the 10.1 branch). The status of my 10.2 branch can be examined here: http://cworth.org/~cworth/mesa-stable-queue/ I'm pretty happy with what it looks

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Kenneth Graunke
On Monday, June 23, 2014 07:02:59 PM Neil Roberts wrote: Previously the blorp blitter would only be used if the format is identical or there is only a difference between whether there is an alpha component or not. This patch makes it also allow the blorp blitter if the only difference is the

Re: [Mesa-dev] [PATCH 6/8] android, egl: typo dri2_fallback_pixmap_surface - dri2_fallback_create_pixmap_surface

2014-06-23 Thread Emil Velikov
On 24/06/14 00:31, Carl Worth wrote: Adrian Negreanu gro...@gmail.com writes: I used commit bc8b07a6 as reference, and only the droid_display_vtbl had this issue. ... CC: 10.1 10.2 mesa-sta...@lists.freedesktop.org Believe that I'm the one to blame for adding the stable tag on the series.

[Mesa-dev] how to enable the display on wayland

2014-06-23 Thread Jacky (ZhiJun) Ni
Hi all, Recently, I've tried to enable my opengles application run on tizen-ivi, tizen-ivi use wayland to display, how to enable the opengles part show on it? My latest patch crashed again, the following sequences describe what I do on for the opengles parts: 1.

Re: [Mesa-dev] [PATCH 2/3] i965/vec4: Don't fix_math_operand() on Gen = 8.

2014-06-23 Thread Ben Widawsky
On Mon, Jun 23, 2014 at 01:30:14PM -0700, Matt Turner wrote: The emit_math?_gen? functions serve to implement workarounds for the math instruction, none of which exist on Gen8+. There are still several restrictions with the math instruction on gen8. Looking at the existing code, I realize I do

[Mesa-dev] [PATCH 05/14] ir_to_mesa, glsl_to_tgsi: Add support for ir_unop_saturate

2014-06-23 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/program/ir_to_mesa.cpp| 6 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ 2 files changed, 12 insertions(+) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index

[Mesa-dev] [PATCH 09/14] i965/fs: Remove try_emit_saturate

2014-06-23 Thread Abdiel Janulgue
Now that sature is implemented natively as instruction, we can cut down on uneeded functionality. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_fs.h | 1 - src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 37

Re: [Mesa-dev] [PATCH] mesa: Don't use derived vertex state in api_arrayelt.c

2014-06-23 Thread Fredrik Höglund
On Tuesday 24 June 2014, Carl Worth wrote: Brian Paul brian.e.p...@gmail.com writes: On Friday 28 February 2014, Fredrik Höglund wrote: It's possible that this patch fixes a segfault in FlightGear (see bug 73504), so I think it's a candidate for the 10.1 branch, but maybe not for

[Mesa-dev] [PATCH 10/14] i965/vec4: Remove try_emit_saturate

2014-06-23 Thread Abdiel Janulgue
Now that sature is implemented natively as an instruction, we can cut down on uneeded functionality. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_vec4.h | 1 - src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 21 -

[Mesa-dev] [PATCH 07/14] i965/fs: Add support for ir_unop_saturate

2014-06-23 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 1 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 2 files changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH 06/14] ir_to_mesa, glsl_to_tgsi: Remove try_emit_saturate

2014-06-23 Thread Abdiel Janulgue
Now that sature is implemented natively as instruction, we can cut down on uneeded functionality Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/program/ir_to_mesa.cpp| 48 src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 51

[Mesa-dev] Add support for GLSL IR saturate()

2014-06-23 Thread Abdiel Janulgue
This patch series add the plumbing to support the GLSL IR instruction saturate(). Previously, saturate is implemented as min/max instructions. Most GPUs, however, can probably perform saturate for free. With these changes, we can allow saturate to be optimized as a single instruction. In

[Mesa-dev] [PATCH 11/14] glsl: Implement saturate as ir_binop_saturate

2014-06-23 Thread Abdiel Janulgue
Now that we have the ir_binop_saturate implemented as a single instruction, generate the correct simplified expression. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/glsl/ir_builder.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 02/14] glsl: Add constant evaluation of ir_unop_saturate

2014-06-23 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/glsl/ir_constant_expression.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index 8afe8f7..b885a2f 100644 ---

[Mesa-dev] [PATCH 08/14] i965/vec4: Add support for ir_unop_saturate

2014-06-23 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index ee52c07..2112edf 100644

[Mesa-dev] [PATCH 03/14] glsl: Add a pass to lower ir_unop_saturate to clamp(x, 0, 1)

2014-06-23 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/glsl/ir_optimization.h | 1 + src/glsl/lower_instructions.cpp | 29 + 2 files changed, 30 insertions(+) diff --git a/src/glsl/ir_optimization.h b/src/glsl/ir_optimization.h index

[Mesa-dev] [PATCH 01/14] glsl: Add ir_unop_saturate

2014-06-23 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/glsl/ir.cpp | 2 ++ src/glsl/ir.h| 1 + src/glsl/ir_validate.cpp | 1 + 3 files changed, 4 insertions(+) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 8fed768..7682e1e 100644 --- a/src/glsl/ir.cpp

[Mesa-dev] [PATCH 04/14] ir_to_mesa, glsl_to_tgsi: lower ir_unop_saturate

2014-06-23 Thread Abdiel Janulgue
Needed when vertex programs doesn't allow saturate Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/mesa/program/ir_to_mesa.cpp| 5 - src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/4] glxinfo: Print XFB, TBO, and UBO limits

2014-06-23 Thread Fredrik Höglund
On Sunday 22 June 2014, Ilia Mirkin wrote: Fredrik, What happened to this series? Ian suggested that we add a build-time dependency on current GL headers, but I haven't gotten around to that yet. It's not needed for patches 1-3 though, so those could be pushed. Fredrik

[Mesa-dev] [PATCH 3/3] glsl: Optimize clamp(x, b, 1.0), where b 0.0 as saturate(max(x, b))

2014-06-23 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com --- src/glsl/opt_algebraic.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 0d694b6..ee52de7 100644 --- a/src/glsl/opt_algebraic.cpp +++

  1   2   >