[Mesa-dev] [PATCH] tgsi: properly parse indirect dimension references (e.g. for UBOs)

2014-07-09 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/auxiliary/tgsi/tgsi_text.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c b/src/gallium/auxiliary/tgsi/tgsi_text.c index c6134c5..6403344 100644 ---

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 79948, which changed state. Bug 79948 Summary: [i965] Incorrect pixels when using discard and uniform loads https://bugs.freedesktop.org/show_bug.cgi?id=79948 What|Removed |Added

[Mesa-dev] [PATCHv2 00/13] multithread GLSL compiler

2014-07-09 Thread Chia-I Wu
Hi list, This is my second try to add multithread support for the GLSL compiler. Changes since v1 are - glLinkProgram can now be threaded - added ctx-Const.DeferCompileShader and ctx-Const.DeferLinkProgram to allow drivers to control what get threaded - minimal changes to i965 to enable

[Mesa-dev] [PATCHv2 07/13] glsl: add a singleton GLSL thread pool

2014-07-09 Thread Chia-I Wu
This thread pool will be used by contexts to queue compilation tasks. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/glsl_parser_extras.cpp | 4 +++ src/glsl/threadpool.c | 72 + src/glsl/threadpool.h | 9 ++ 3 files

[Mesa-dev] [PATCHv2 10/13] i965: refactor do_vs_prog

2014-07-09 Thread Chia-I Wu
Split do_vs_prog into brw_vs_init_compile brw_vs_do_compile brw_vs_upload_compile brw_vs_clear_complile Signed-off-by: Chia-I Wu o...@lunarg.com --- src/mesa/drivers/dri/i965/brw_vec4.h | 6 ++ src/mesa/drivers/dri/i965/brw_vs.c | 117 ++-

[Mesa-dev] [PATCHv2 06/13] glsl: add a generic thread pool data structure

2014-07-09 Thread Chia-I Wu
It can be used to implement, for example, threaded glCompileShader and glLinkProgram. v2: allow tasks to complete other tasks Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/Makefile.am | 12 +- src/glsl/Makefile.sources | 3 +- src/glsl/tests/threadpool_test.cpp

[Mesa-dev] [PATCHv2 02/13] glsl: rename strtod.c to strtod.cpp

2014-07-09 Thread Chia-I Wu
We want to add a static object to initialize locale_t in the following commit. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/Makefile.sources | 2 +- src/glsl/strtod.c | 79 --- src/glsl/strtod.cpp | 79

[Mesa-dev] [PATCHv2 03/13] glsl: initialize locale_t with a static object

2014-07-09 Thread Chia-I Wu
The compiler may be used by multiple contexts simultaneously and needs to be thread-safe. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/strtod.cpp | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/src/glsl/strtod.cpp b/src/glsl/strtod.cpp

[Mesa-dev] [PATCHv2 01/13] mesa: protect the debug state with a mutex

2014-07-09 Thread Chia-I Wu
We are about to change mesa to spawn threads for deferred glCompileShader and glLinkProgram, and we need to make sure those threads can send compiler warnings/errors to the debug output safely. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/mesa/main/errors.c | 172

[Mesa-dev] [PATCHv2 11/13] i965: refactor do_gs_prog

2014-07-09 Thread Chia-I Wu
Split do_gs_prog into brw_gs_init_compile brw_gs_do_compile brw_gs_upload_compile brw_gs_clear_complile Signed-off-by: Chia-I Wu o...@lunarg.com --- src/mesa/drivers/dri/i965/brw_vec4_gs.c | 153 1 file changed, 96 insertions(+), 57 deletions(-) diff

[Mesa-dev] [PATCHv2 08/13] mesa: add infrastructure for threaded shader compilation

2014-07-09 Thread Chia-I Wu
Add _mesa_enable_glsl_threadpool to enable the thread pool for a context, and add ctx-Const.DeferCompileShader and ctx-Const.DeferLinkProgram to fine-control what gets threaded. Setting DeferCompileShader to true will make _mesa_glsl_compile_shader be executed in a worker thread. The function is

[Mesa-dev] [PATCHv2 13/13] i965: enable threaded precompile

2014-07-09 Thread Chia-I Wu
Inherit gl_shader_program and add save/restore functions to save precompile results in the shader programs. When DeferLinkProgram is set, we will save the precompile results instead of uploading them immediately because we may be on a different thread. A few other modifications are also needed.

[Mesa-dev] [PATCHv2 09/13] i965: add drirc option multithread_glsl_compiler

2014-07-09 Thread Chia-I Wu
Setting it to a non-zero value N will cause shader compilation to be deferred to a thread pool. When N is greater than 1, it indicates the maximum number of threads in the pool. When N is 1, the number of threads is up to the driver (two for i965). Signed-off-by: Chia-I Wu o...@lunarg.com ---

[Mesa-dev] [PATCHv2 05/13] glsl: protect glsl_type with a mutex

2014-07-09 Thread Chia-I Wu
glsl_type has several static hash tables and a static ralloc context. They need to be protected by a mutex as they are not thread-safe. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/glsl_types.cpp | 57 +++-- src/glsl/glsl_types.h | 15

[Mesa-dev] [PATCHv2 12/13] i965: refactor do_wm_prog

2014-07-09 Thread Chia-I Wu
Split do_wm_prog into brw_wm_init_compile brw_wm_do_compile brw_wm_upload_compile brw_wm_clear_complile Add struct brw_wm_compile to be passed around them. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/mesa/drivers/dri/i965/brw_wm.c | 119 -

[Mesa-dev] [PATCHv2 04/13] glsl: protect anonymous struct id with a mutex

2014-07-09 Thread Chia-I Wu
There may be two contexts compiling shaders at the same time, and we want the anonymous struct id to be globally unique. Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/glsl_parser_extras.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 10/16] gallium: add is_percentage and is_float fields to pipe_driver_query_info

2014-07-09 Thread Samuel Pitoiset
On 07/08/2014 06:27 PM, Marek Olšák wrote: It would be nicer to define all the types as enums, e.g. enum pipe_driver_query_type { PIPE_DRIVER_QUERY_TYPE_BYTES, PIPE_DRIVER_QUERY_TYPE_PERCENTAGE, PIPE_DRIVER_QUERY_TYPE_FLOAT, PIPE_DRIVER_QUERY_TYPE_UINT }; That would be nicer than a bunch of

[Mesa-dev] GL_AMD_performance_monitor v3

2014-07-09 Thread Samuel Pitoiset
Hello, This is the third version of GL_AMD_performance_monitor. V2 (global changes): - Fix radeon as pinpointed by Marek - Implement pipe_driver_query_group_info for svga, radeon and freedreno V3 (global changes): - Re-organize the series according to hints of Ilia Mirkin - Document

[Mesa-dev] [PATCH 03/15] gallium: add new numeric types to pipe_query_result v2

2014-07-09 Thread Samuel Pitoiset
This will be used by GL_AMD_performance_monitor. V2: - add 'uint32_t u32' - rename 'float f32' to 'float f' - add some comments Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 8 1 file changed, 8 insertions(+) diff --git

[Mesa-dev] [PATCH 01/15] gallium: add pipe_screen::get_driver_query_group_info v2

2014-07-09 Thread Samuel Pitoiset
Driver queries are organized as a single hierarchy where queries are categorized into groups. Each goup has a list of queries and a maximum number of queries that can be sampled. This will be used by GL_AMD_performance monitor. V2: - add doc to src/gallium/docs/source/screen.rst -

[Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info v2

2014-07-09 Thread Samuel Pitoiset
According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order to categorize queries into groups. V2: - add pipe_driver_query_type enum Signed-off-by: Samuel

[Mesa-dev] [PATCH 05/15] gallium: make pipe_context::begin_query return a boolean

2014-07-09 Thread Samuel Pitoiset
This can be used to check if a query is unable to start. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno/freedreno_query_hw.c | 3

[Mesa-dev] [PATCH 14/15] nvc0: make begin_query return false when all MP counters are used v2

2014-07-09 Thread Samuel Pitoiset
V2: - do not return immediately after nvc0_mp_pm_query_end() in order to set the current state of the given query Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 06/15] mesa/st: implement GL_AMD_performance_monitor v4

2014-07-09 Thread Samuel Pitoiset
From: Christoph Bumiller e0425...@student.tuwien.ac.at This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) Drivers must implement get_driver_query_group_info and get_driver_query_info in order to enable this extension. V2:

[Mesa-dev] [PATCH 13/15] nvc0: expose driver queries with two groups

2014-07-09 Thread Samuel Pitoiset
This adds a new group for MP performance counters and requires to write our own implementation of get_driver_query_group_info. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 52 --

[Mesa-dev] [PATCH 04/15] gallium: replace pipe_driver_query_info::max_value by a union v2

2014-07-09 Thread Samuel Pitoiset
This will be used to return different numeric types for driver queries. V2: - use float instead of double - reorder pipe_numeric_type_union to avoid bad initializers - rename ui to u64 and i to u32 according to gl_perf_monitor_counter_value - use uint32_t instead of int64_t according to

[Mesa-dev] [PATCH 10/15] radeon: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Samuel Pitoiset
This enables GL_AMD_performance_monitor for radeon. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + 1 file changed, 9

[Mesa-dev] [PATCH 15/15] nvc0: init all default values of pipe_driver_query_info

2014-07-09 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2014-07-09 Thread Samuel Pitoiset
This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 46 ++ src/gallium/auxiliary/util/u_query.h | 44

[Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.3 release

2014-07-09 Thread Samuel Pitoiset
GL_AMD_performance_monitor is supported by nvc0, svga, freedreno and radeon. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- docs/relnotes/10.3.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.3.html b/docs/relnotes/10.3.html index 2e718fc..e73e078 100644

[Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Samuel Pitoiset
This enables GL_AMD_performance_monitor for svga. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/svga/svga_screen.c | 11 +++ 1 file changed, 11

[Mesa-dev] [PATCH 11/15] nvc0: implement pipe_screen::get_driver_query_group_info v2

2014-07-09 Thread Samuel Pitoiset
This enables GL_AMD_performance_monitor for nvc0. V2: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 +

[Mesa-dev] [PATCH 09/15] freedreno: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Samuel Pitoiset
This enables GL_AMD_performance_monitor for freedreno. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c | 9 + 1 file changed, 9

[Mesa-dev] [PATCH] radeonsi: fix order of r600_need_dma_space and r600_context_bo_reloc

2014-07-09 Thread Christian König
From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/drivers/radeonsi/si_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_dma.c b/src/gallium/drivers/radeonsi/si_dma.c

Re: [Mesa-dev] [PATCH 06/15] mesa/st: implement GL_AMD_performance_monitor v4

2014-07-09 Thread Brian Paul
In the subject, we usually use st/mesa:. On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: From: Christoph Bumiller e0425...@student.tuwien.ac.at This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) Drivers must implement

Re: [Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Brian Paul
On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This enables GL_AMD_performance_monitor for svga. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com ---

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2014-07-09 Thread Brian Paul
On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 46

Re: [Mesa-dev] [PATCH] radeonsi: fix order of r600_need_dma_space and r600_context_bo_reloc

2014-07-09 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jul 9, 2014 at 2:38 PM, Christian König deathsim...@vodafone.de wrote: From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- src/gallium/drivers/radeonsi/si_dma.c | 3 ++- 1

Re: [Mesa-dev] [PATCH 1/2] mesa/st: add support for dynamic ubo selection

2014-07-09 Thread Brian Paul
On 07/08/2014 08:40 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- With ChrisF's patches to add support for this in core mesa, this generates code like: FRAG DCL OUT[0], COLOR DCL CONST[0] DCL CONST[1][0] DCL CONST[2][0] DCL CONST[3][0] DCL CONST[4][0] DCL TEMP[0],

Re: [Mesa-dev] [PATCH] radeonsi: fix order of r600_need_dma_space and r600_context_bo_reloc

2014-07-09 Thread Alex Deucher
On Wed, Jul 9, 2014 at 8:38 AM, Christian König deathsim...@vodafone.de wrote: From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com CC stable? Alex --- src/gallium/drivers/radeonsi/si_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.3 release

2014-07-09 Thread Marek Olšák
Also radeonsi, because the query code shared between both drivers. Marek On Wed, Jul 9, 2014 at 4:34 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: GL_AMD_performance_monitor is supported by nvc0, svga, freedreno and radeon. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com ---

Re: [Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.3 release

2014-07-09 Thread Samuel Pitoiset
On 07/09/2014 03:10 PM, Marek Olšák wrote: Also radeonsi, because the query code shared between both drivers. Added, thanks. Marek On Wed, Jul 9, 2014 at 4:34 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: GL_AMD_performance_monitor is supported by nvc0, svga, freedreno and radeon.

Re: [Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Samuel Pitoiset
On 07/09/2014 03:00 PM, Brian Paul wrote: On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This enables GL_AMD_performance_monitor for svga. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2014-07-09 Thread Samuel Pitoiset
On 07/09/2014 03:00 PM, Brian Paul wrote: On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/Makefile.sources | 1 +

Re: [Mesa-dev] [PATCH 06/15] mesa/st: implement GL_AMD_performance_monitor v4

2014-07-09 Thread Samuel Pitoiset
On 07/09/2014 03:00 PM, Brian Paul wrote: In the subject, we usually use st/mesa:. Okay. On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: From: Christoph Bumiller e0425...@student.tuwien.ac.at This is based on the original patch of Christoph Bumiller. (source:

Re: [Mesa-dev] [PATCHv2 06/13] glsl: add a generic thread pool data structure

2014-07-09 Thread Brian Paul
On 07/09/2014 01:47 AM, Chia-I Wu wrote: It can be used to implement, for example, threaded glCompileShader and glLinkProgram. v2: allow tasks to complete other tasks Signed-off-by: Chia-I Wu o...@lunarg.com --- src/glsl/Makefile.am | 12 +- src/glsl/Makefile.sources

Re: [Mesa-dev] [PATCHv2 08/13] mesa: add infrastructure for threaded shader compilation

2014-07-09 Thread Brian Paul
On 07/09/2014 01:47 AM, Chia-I Wu wrote: Add _mesa_enable_glsl_threadpool to enable the thread pool for a context, and add ctx-Const.DeferCompileShader and ctx-Const.DeferLinkProgram to fine-control what gets threaded. Setting DeferCompileShader to true will make _mesa_glsl_compile_shader be

Re: [Mesa-dev] [PATCHv2 00/13] multithread GLSL compiler

2014-07-09 Thread Brian Paul
On 07/09/2014 01:47 AM, Chia-I Wu wrote: Hi list, This is my second try to add multithread support for the GLSL compiler. Changes since v1 are - glLinkProgram can now be threaded - added ctx-Const.DeferCompileShader and ctx-Const.DeferLinkProgram to allow drivers to control what get

Re: [Mesa-dev] [PATCH] tgsi: properly parse indirect dimension references (e.g. for UBOs)

2014-07-09 Thread Brian Paul
On Wed, Jul 9, 2014 at 12:29 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/auxiliary/tgsi/tgsi_text.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c

Re: [Mesa-dev] i965: overwriting parts of a register and optimization passes

2014-07-09 Thread Kenneth Graunke
On Tuesday, July 08, 2014 11:19:38 AM Iago Toral wrote: Hi, I have some code that first initializes a register and then overwrites a specific subregister. However, after the optimization passes in brw_vec4.cpp the initialization instruction goes away. I see that live intervals are computed

[Mesa-dev] [PATCH] gallium/u_blitter: fix some shader memory leaks

2014-07-09 Thread Brian Paul
The _msaa shaders weren't getting freed. Cc: 10.2 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/util/u_blitter.c |9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index db0d1b8..20fbd80

Re: [Mesa-dev] i965: overwriting parts of a register and optimization passes

2014-07-09 Thread Kristian Høgsberg
On Wed, Jul 9, 2014 at 8:19 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Tuesday, July 08, 2014 11:19:38 AM Iago Toral wrote: Hi, I have some code that first initializes a register and then overwrites a specific subregister. However, after the optimization passes in brw_vec4.cpp

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 Bryan Cain bryancain3+...@gmail.com changed: What|Removed |Added Hardware|x86-64 (AMD64) |All

Re: [Mesa-dev] [PATCH] gallium/u_blitter: fix some shader memory leaks

2014-07-09 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jul 9, 2014 at 5:42 PM, Brian Paul bri...@vmware.com wrote: The _msaa shaders weren't getting freed. Cc: 10.2 mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/util/u_blitter.c |9 + 1 file changed, 9

[Mesa-dev] [Bug 80933] Fullscreen OpenGL programs (e.g. games) crash if focus lost then regained, something to do with automatic compositing suspension

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80933 --- Comment #3 from Benjamin Bellec b.bel...@gmail.com --- (In reply to comment #0) See also: https://github.com/ValveSoftware/Dota-2/issues/886 In this thread, all the bugs reports have been done with a proprietary driver (NVIDIA mostly, and

[Mesa-dev] [PATCH 1/2] st/mesa: add some missing MESA/PIPE_FORMAT_R10G10B10A2_UNORM switch cases

2014-07-09 Thread Brian Paul
--- src/mesa/state_tracker/st_format.c |4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 38d4ccf..a821180 100644 --- a/src/mesa/state_tracker/st_format.c +++ b/src/mesa/state_tracker/st_format.c @@ -83,6 +83,8

[Mesa-dev] [PATCH 2/2] st/mesa: add PIPE_FORMAT_R10G10B10A2_UNORM to format_map table

2014-07-09 Thread Brian Paul
as a candidate for the GL_RGB10_A2 internal texture format. --- src/mesa/state_tracker/st_format.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index a821180..409079b 100644 ---

[Mesa-dev] [PATCH] i965: Initialize new chunks of realloc'd memory.

2014-07-09 Thread Matt Turner
Otherwise we'd compare uninitialized pointers with NULL and dereference, leading to crashes. --- src/mesa/drivers/dri/i965/intel_asm_annotation.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_asm_annotation.c

[Mesa-dev] [PATCH] i965/fs: Relax interference check in register coalescing.

2014-07-09 Thread Matt Turner
A similar attempt was made in commit 5ff1e446 and was reverted in commit a39428cf after causing a regression in an ES 3 conformance test. The test still passes after this commit. total instructions in shared programs: 1994827 - 1992858 (-0.10%) instructions in affected programs: 128247 -

Re: [Mesa-dev] [PATCH 1/2] st/mesa: add some missing MESA/PIPE_FORMAT_R10G10B10A2_UNORM switch cases

2014-07-09 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jul 9, 2014 at 8:51 PM, Brian Paul bri...@vmware.com wrote: --- src/mesa/state_tracker/st_format.c |4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_format.c

Re: [Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Marek Olšák
If the driver queries are defined as an array, you can also use the Elements macro on the array. Marek On Wed, Jul 9, 2014 at 3:41 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: On 07/09/2014 03:00 PM, Brian Paul wrote: On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This enables

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 Emil Velikov emil.l.veli...@gmail.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |kei...@keithp.com

Re: [Mesa-dev] [PATCH] i915: Fix up intelInitScreen2 for DRI3

2014-07-09 Thread Julien Cristau
On Thu, Jul 3, 2014 at 22:13:53 +0200, Adel Gadllah wrote: Commit 442442026eb updated both i915 and i965 for DRI3 support, but one check in intelInitScreen2 was missed for i915 causing crashes when trying to use i915 with DRI3. So fix that up. Reported-by: Igor Gnatenko

Re: [Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Samuel Pitoiset
On 07/09/2014 09:49 PM, Marek Olšák wrote: If the driver queries are defined as an array, you can also use the Elements macro on the array. For sure, but we can't do that here since the array is local to the get_driver_query_info() callback. Marek On Wed, Jul 9, 2014 at 3:41 PM, Samuel

Re: [Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

2014-07-09 Thread Marek Olšák
Well, the array can always be moved outside of the function and be declared as static. Marek On Thu, Jul 10, 2014 at 12:27 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: On 07/09/2014 09:49 PM, Marek Olšák wrote: If the driver queries are defined as an array, you can also use the

Re: [Mesa-dev] [PATCH 2/3] exec_list: add a function to count the size of a list

2014-07-09 Thread Ian Romanick
On 07/08/2014 12:20 PM, Connor Abbott wrote: Signed-off-by: Connor Abbott connor.abb...@intel.com --- src/glsl/list.h | 20 1 file changed, 20 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index ca6ee9d..68ab3fd 100644 --- a/src/glsl/list.h +++

Re: [Mesa-dev] [PATCH 1/3] exec_list: add a prepend function

2014-07-09 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 07/08/2014 12:20 PM, Connor Abbott wrote: This complements the existing append function. It's implemented in a rather simple way right now; it could be changed if performance is a concern. Signed-off-by: Connor Abbott

Re: [Mesa-dev] [PATCH 3/3] exec_list: make various places use the new get_size() method

2014-07-09 Thread Ian Romanick
Wow. It's surprising how many places that shows up! Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 07/08/2014 12:21 PM, Connor Abbott wrote: Instead of hand-rolling it. Signed-off-by: Connor Abbott connor.abb...@intel.com --- src/glsl/ast_to_hir.cpp |

Re: [Mesa-dev] [PATCH 2/3] exec_list: add a function to count the size of a list

2014-07-09 Thread Matt Turner
On Tue, Jul 8, 2014 at 12:20 PM, Connor Abbott cwabbo...@gmail.com wrote: Signed-off-by: Connor Abbott connor.abb...@intel.com --- src/glsl/list.h | 20 1 file changed, 20 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index ca6ee9d..68ab3fd 100644 ---

[Mesa-dev] [PATCH] glsl/glcpp: move macro declaration before code to fix MSVC build

2014-07-09 Thread Brian Paul
--- src/glsl/glcpp/glcpp-parse.y |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 21c85b4..084078e 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@ -265,13 +265,14 @@

Re: [Mesa-dev] [PATCH 2/3] exec_list: add a function to count the size of a list

2014-07-09 Thread Connor Abbott
On Wednesday, July 09, 2014 03:56:41 PM Ian Romanick wrote: On 07/08/2014 12:20 PM, Connor Abbott wrote: Signed-off-by: Connor Abbott connor.abb...@intel.com --- src/glsl/list.h | 20 1 file changed, 20 insertions(+) diff --git a/src/glsl/list.h

Re: [Mesa-dev] [PATCH v2] glsl: Fix aggregates with dynamic initializers.

2014-07-09 Thread Timothy Arceri
On Wed, 2014-07-02 at 22:16 +1000, Timothy Arceri wrote: On Tue, 2014-07-01 at 14:45 -0700, Kenneth Graunke wrote: From: Cody Northrop c...@lunarg.com Vectors are falling in to the ir_dereference_array() path. Without this change, the following glsl aborts the debug driver, or gets

Re: [Mesa-dev] [PATCH] glsl/glcpp: move macro declaration before code to fix MSVC build

2014-07-09 Thread Carl Worth
Brian Paul bri...@vmware.com writes: Thanks for the fix, Brian. Reviewed-by: Carl Worth cwo...@cworth.org -Carl pgpRbh_5gMWxy.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/3] exec_list: add a function to count the size of a list

2014-07-09 Thread Matt Turner
On Wed, Jul 9, 2014 at 4:00 PM, Connor Abbott connor.abb...@intel.com wrote: On Wednesday, July 09, 2014 03:56:41 PM Ian Romanick wrote: On 07/08/2014 12:20 PM, Connor Abbott wrote: Signed-off-by: Connor Abbott connor.abb...@intel.com --- src/glsl/list.h | 20 1

Re: [Mesa-dev] [PATCH v2] glsl: handle a switch where default is in the middle of cases

2014-07-09 Thread Anuj Phogat
On Thu, Jun 19, 2014 at 6:11 AM, Tapani Pälli tapani.pa...@intel.com wrote: This fixes following tests in es3conform: shaders.switch.default_not_last_dynamic_vertex shaders.switch.default_not_last_dynamic_fragment and makes following tests in Piglit pass:

[Mesa-dev] [PATCH 1/2] i965: forward-declare struct brw_context in brw_reg.h

2014-07-09 Thread Ilia Mirkin
Commit 54e91e7420 introduced a function declaration that uses brw_context. While brw_context tends to get included in most files, it is not when compiling intel_asm_annotation.c resulting in the following warning: In file included from brw_shader.h:25:0, from brw_cfg.h:32,

[Mesa-dev] [PATCH 2/2] r600g: remove unused base_vector_chan variable

2014-07-09 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Happened to notice the warning when compiling r600. Perhaps the use got removed in some LLVM version cleanup? I didn't think it was important to go digging though. src/gallium/drivers/r600/r600_llvm.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 2/2] r600g: remove unused base_vector_chan variable

2014-07-09 Thread Michel Dänzer
On 10.07.2014 10:26, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Happened to notice the warning when compiling r600. Perhaps the use got removed in some LLVM version cleanup? I didn't think it was important to go digging though.

Re: [Mesa-dev] [PATCHv2 06/13] glsl: add a generic thread pool data structure

2014-07-09 Thread Chia-I Wu
On Wed, Jul 9, 2014 at 10:42 PM, Brian Paul bri...@vmware.com wrote: On 07/09/2014 01:47 AM, Chia-I Wu wrote: It can be used to implement, for example, threaded glCompileShader and glLinkProgram. v2: allow tasks to complete other tasks Signed-off-by: Chia-I Wu o...@lunarg.com ---

Re: [Mesa-dev] [PATCHv2 08/13] mesa: add infrastructure for threaded shader compilation

2014-07-09 Thread Chia-I Wu
On Wed, Jul 9, 2014 at 10:42 PM, Brian Paul bri...@vmware.com wrote: On 07/09/2014 01:47 AM, Chia-I Wu wrote: Add _mesa_enable_glsl_threadpool to enable the thread pool for a context, and add ctx-Const.DeferCompileShader and ctx-Const.DeferLinkProgram to fine-control what gets threaded.

Re: [Mesa-dev] [PATCH 1/2] i965: forward-declare struct brw_context in brw_reg.h

2014-07-09 Thread Kenneth Graunke
On Wednesday, July 09, 2014 09:26:49 PM Ilia Mirkin wrote: Commit 54e91e7420 introduced a function declaration that uses brw_context. While brw_context tends to get included in most files, it is not when compiling intel_asm_annotation.c resulting in the following warning: In file included

[Mesa-dev] [Bug 81139] New: Rendering sometimes halts in waiting for back buffers with dri3 xwayland

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81139 Priority: medium Bug ID: 81139 Assignee: mesa-dev@lists.freedesktop.org Summary: Rendering sometimes halts in waiting for back buffers with dri3 xwayland Severity: normal

[Mesa-dev] [Bug 81139] Rendering sometimes halts in waiting for back buffers with dri3 xwayland

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81139 --- Comment #1 from Axel Davy veb...@hotmail.fr --- Could you tell which distribution you are using ? My guess it that it is a libxcb bug. Debian packages have the fix (which is

[Mesa-dev] [Bug 81139] Rendering sometimes halts in waiting for back buffers with dri3 xwayland

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81139 --- Comment #2 from Boyan Ding stu_...@126.com --- (In reply to comment #1) Could you tell which distribution you are using ? I'm using Arch Linux, in which almost everything is vanilla. My guess it that it is a libxcb bug. Debian packages

[Mesa-dev] [Bug 81139] Rendering sometimes halts in waiting for back buffers with dri3 xwayland

2014-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81139 --- Comment #3 from Boyan Ding stu_...@126.com --- Created attachment 102515 -- https://bugs.freedesktop.org/attachment.cgi?id=102515action=edit A simple program that can effectively trigger the halt on my machine The problem persists with

[Mesa-dev] [PATCH 2/3] nvc0: add support for indirect drawing

2014-07-09 Thread Ilia Mirkin
From: Christoph Bumiller e0425...@student.tuwien.ac.at Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- docs/GL3.txt | 5 +- docs/relnotes/10.3.html| 1 + src/gallium/drivers/nouveau/nouveau_screen.c | 6 +-

[Mesa-dev] [PATCH 3/3] nvc0: fix translate path for PRIM_RESTART_WITH_DRAW_ARRAYS

2014-07-09 Thread Ilia Mirkin
From: Christoph Bumiller e0425...@student.tuwien.ac.at Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- .../drivers/nouveau/nvc0/nvc0_vbo_translate.c | 41 +++--- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 0/3] nvc0: ARB_(multi_)draw_indirect support

2014-07-09 Thread Ilia Mirkin
The main patches are from Christoph. Unfortunately they're a little beyond my understanding of all the vertex-related details, but they generally seemed fine. I'm just going to push these unless someone steps up to review them. Christoph Bumiller (2): nvc0: add support for indirect drawing

[Mesa-dev] [PATCH 1/3] nouveau: check if a fence has already been signalled

2014-07-09 Thread Ilia Mirkin
nouveau_fence_update does real work unconditionally. Avoid doing that if the fence we're checking on has already been signalled. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_fence.c | 3 +++ 1 file changed, 3 insertions(+) diff --git