Re: [Mesa-dev] [PATCH 1/6] radeonsi: move sampler descriptors from IB to memory

2014-07-16 Thread Michel Dänzer
On 16.07.2014 00:07, Marek Olšák wrote: On Tue, Jul 15, 2014 at 11:53 AM, Michel Dänzer mic...@daenzer.net wrote: On 13.07.2014 01:35, Marek Olšák wrote: Border colors have been broken if texturing from multiple shader stages is used. This patch doesn't change that. [...] +/* Upload

Re: [Mesa-dev] [PATCH 4/6] radeonsi: move vertex buffer descriptors from IB to memory

2014-07-16 Thread Michel Dänzer
On 13.07.2014 01:35, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com This removes the intermediate storage (pm4 state) and generates descriptors directly in a staging buffer. It also reduces the number of flushes, because the descriptors no longer take CS space. Cool. diff

Re: [Mesa-dev] A proposal for new testing requirements for stable releases

2014-07-16 Thread Michel Dänzer
On 16.07.2014 06:16, Carl Worth wrote: Michel Dänzer mic...@daenzer.net writes: Quite frankly, my real concern with all of this is not that the driver maintainers will propose something bad, but that I will inadvertently botch something while cherry-picking or merging a conflict, etc. that I

[Mesa-dev] [Bug 80266] Many instances of 131, which is undefined in C99

2014-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80266 --- Comment #15 from Michel Dänzer mic...@daenzer.net --- Please submit patches fixing these issues to the mesa-dev mailing list, instead of waiting here for anyone else to do it. -- You are receiving this mail because: You are the assignee for

Re: [Mesa-dev] [PATCH 1/6] radeonsi: move sampler descriptors from IB to memory

2014-07-16 Thread Marek Olšák
On Wed, Jul 16, 2014 at 10:17 AM, Michel Dänzer mic...@daenzer.net wrote: On 16.07.2014 00:07, Marek Olšák wrote: On Tue, Jul 15, 2014 at 11:53 AM, Michel Dänzer mic...@daenzer.net wrote: On 13.07.2014 01:35, Marek Olšák wrote: Border colors have been broken if texturing from multiple shader

Re: [Mesa-dev] Release-candidate branch for upcoming 10.2.4

2014-07-16 Thread Ilia Mirkin
On Tue, Jul 15, 2014 at 12:49 AM, Carl Worth cwo...@cworth.org wrote: Hi folks, I've pushed out an update to the 10.2 branch and I need some specific testing in the next three days. I've tested the branch on Intel (Haswell) as well as both swrast and Gallium softpipe and found no piglit

Re: [Mesa-dev] [PATCH 1/5] wglinfo: query and report multisample information

2014-07-16 Thread Jose Fonseca
On 15/07/14 15:39, Brian Paul wrote: Before, we always reported zeros in the multisample columns of the format list. Since PIXELFORMATDESCRIPTOR doesn't have fields for multisample, we use a new format_info structure to extend that type. We can only query this info with the

[Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-16 Thread Glenn Kennard
Only supported on evergreen and later. Currently limited to single component textures as the hardware GATHER4 instruction ignores texture swizzles. Piglit quick run passes on radeon 6670 with all applicable textureGather tests, no regressions. Signed-off-by: Glenn Kennard glenn.kenn...@gmail.com

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_gather

2014-07-16 Thread Ilia Mirkin
On Wed, Jul 16, 2014 at 9:53 AM, Glenn Kennard glenn.kenn...@gmail.com wrote: Only supported on evergreen and later. Currently limited to single component textures as the hardware GATHER4 instruction ignores texture swizzles. Piglit quick run passes on radeon 6670 with all applicable

Re: [Mesa-dev] [PATCH 00/10] [RFC] Probably useless algebraic optimizations

2014-07-16 Thread Brian Paul
Some of these optimizations are pretty obscure and I can't imagine a real shader hitting them. What's the cost of checking for these cases? I don't know how expensive the equals() methods are. Do we want to litter the optimizer with cases that may never be used in practice? -Brian On

[Mesa-dev] [PATCHi v3] r600g: Implement GL_ARB_texture_gather

2014-07-16 Thread Glenn Kennard
Only supported on evergreen and later. Currently limited to single component textures as the hardware GATHER4 instruction ignores texture swizzles. Piglit quick run passes on radeon 6670 with all applicable textureGather tests, no regressions. Signed-off-by: Glenn Kennard glenn.kenn...@gmail.com

[Mesa-dev] [Bug 78716] Fix Mesa bugs for running Unreal Engine 4.1 Cave effects demo compiled for Linux

2014-07-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78716 Eero Tamminen eero.t.tammi...@intel.com changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH v3] glsl: handle a switch where default is in the middle of cases

2014-07-16 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com At some point we should do some significant re-work of the switch-statement handling in Mesa. The current structure makes it hard to do a lot of things (e.g., jump-tables for uniform control flow). On 07/13/2014 11:45 PM, Tapani Pälli wrote:

[Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result

2014-07-16 Thread Tom Stellard
Also change the wait parameter from false to true. --- I'm really not sure what is correct here, but this patch fixes event profiling on SI. src/gallium/state_trackers/clover/core/timestamp.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/2] clover: Use 1 as default value for CL_DEVICE_PROFILING_TIMER_RESOLUTION

2014-07-16 Thread Tom Stellard
We use PIPE_QUERY_TIMESTAMP for profiling events, and gallium specifies that the timestamp be in nanoseconds. --- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result

2014-07-16 Thread Niels Ole Salscheider
On Wednesday 16 July 2014, 16:49:08, Tom Stellard wrote: Also change the wait parameter from false to true. --- I'm really not sure what is correct here, but this patch fixes event profiling on SI. I think you should call end_query in the constructor right after the call to create_query.

[Mesa-dev] [PATCH 3/5] r600g/compute: Defrag the pool if it's necesary

2014-07-16 Thread Bruno Jiménez
This patch adds a new member to the pool to track its status. For now it is used only for the 'fragmented' status, but if needed it could be used for more statuses. The pool will be considered fragmented if: An item that isn't the last is freed or demoted. This 'strategy' has a problem, although

[Mesa-dev] [PATCH 2/5] r600g/compute: Add a function for defragmenting the pool

2014-07-16 Thread Bruno Jiménez
This new function will move items forward in the pool, so that there's no gap between them, effectively defragmenting the pool. For now this function is a bit dumb as it just moves items forward without trying to see if other items in the pool could fit in the gaps. ---

[Mesa-dev] [PATCH 5/5] r600g/compute: Remove unneeded code from compute_memory_promote_item

2014-07-16 Thread Bruno Jiménez
Now that we know that the pool is defragmented, we positively know that allocated + unallocated will be the total size of the current pool plus all the items that will be promoted. So we only need to grow the pool once. This will allow us to just add the new items to the end of the item_list

[Mesa-dev] [PATCH 0/5] [RFC] r600g/compute: Adding support for defragmenting compute_memory_pool

2014-07-16 Thread Bruno Jiménez
Hi, This series finally adds support for defragmenting the pool for OpenCL buffers in the r600g driver. It is mostly a rewritten of the series that I wrote some months ago. For defragmenting the pool I have thought of two different possibilities: - Creating a new pool and moving every item here

[Mesa-dev] [PATCH 4/5] r600g/compute: Quick exit if there's nothing to add to the pool

2014-07-16 Thread Bruno Jiménez
This way we can avoid defragmenting the pool, even if it is needed to defragment it, and looping again through the list of unallocated items. --- src/gallium/drivers/r600/compute_memory_pool.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c

[Mesa-dev] [PATCH 1/5] r600g/compute: Add a function for moving items in the pool

2014-07-16 Thread Bruno Jiménez
This function will be used in the future by compute_memory_defrag to move items forward in the pool. It does so by first checking for overlaping ranges, if the ranges don't overlap it will copy the contents directly. If they overlap it will try first to make a temporary buffer, if this buffer

[Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

2014-07-16 Thread Tom Stellard
v2: - Move the end_query() call into the timestamp constructor. - Still pass false as the wait parameter to get_query_result(). --- src/gallium/state_trackers/clover/core/timestamp.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/clover/core/timestamp.cpp

Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

2014-07-16 Thread Niels Ole Salscheider
Reviewed-by: Niels Ole Salscheider niels_...@salscheider-online.de On Wednesday 16 July 2014, 17:37:48, Tom Stellard wrote: v2: - Move the end_query() call into the timestamp constructor. - Still pass false as the wait parameter to get_query_result(). ---

[Mesa-dev] [PATCH 00/10] [RFC] Probably useless algebraic optimizations

2014-07-16 Thread Thomas Helland
Some of these optimizations are pretty obscure and I can't imagine a real shader hitting them. Some of these optimizations are indeed obscure. Only reason I can think of for any of these to succeed are if some other optimizations has pushed constants up the tree, or eliminated things. What's

[Mesa-dev] [PATCH] i965: Fix z_offset computation in intel_miptree_unmap_depthstencil()

2014-07-16 Thread Anuj Phogat
The bug is triggered by using glTexSubImage2d() with GL_DEPTH_STENCIL as base internal format and non-zero x, y offsets. Currently x, y offsets are ignored while updating the texture image. Fixes Khronos GLES3 CTS tests: npot_tex_sub_image_2d npot_tex_sub_image_3d npot_pbo_tex_sub_image_2d

[Mesa-dev] [PATCH] Revert i965: Extend compute-to-mrf pass to understand blocks of MOVs

2014-07-16 Thread Anuj Phogat
This reverts commit bbefb15e01e1c16af69646898918982ae00f8c92. Fixes the 11 regressions caused in framebuffer_blit tests in Khronos GLES3 CTS tests: Original patch reduced the instruction count but had no performance benefits. So, it's safe to revert it without causing any performance regressions.

Re: [Mesa-dev] Backends and support for pow-instructions

2014-07-16 Thread Thomas Helland
2014-07-13 20:13 GMT+02:00 Matt Turner matts...@gmail.com: On Sun, Jul 13, 2014 at 10:50 AM, Thomas Helland thomashellan...@gmail.com wrote: I've considered writing an algebraic optimization to convert this into an ir_binop_pow. If my understanding is correct the backend will then

Re: [Mesa-dev] [PATCH] glapi: add indexed blend functions (GL 4.0)

2014-07-16 Thread Anuj Phogat
On Mon, Jul 14, 2014 at 9:38 PM, Tapani Pälli tapani.pa...@intel.com wrote: This makes some of the UE4 engine demos (Stylized, Mobile Temple) render correctly, tested on Intel Haswell machine. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mapi/glapi/gen/GL4x.xml |

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-16 Thread John Paul Adrian Glaubitz
Hi Thorsten! On 07/16/2014 01:03 PM, Thorsten Glaser wrote: updated debdiff attached. Package compiles fine with it (on i386 and m68k), and the invalid alignment assumptions were made explicit with no ABI breakage. Awesome! That's great to hear! Please apply. Absolutely. Could the upstream

[Mesa-dev] [PATCH] Fix crash in update_framebuffer_state

2014-07-16 Thread David Weber
Hi, GPU: Radeon HD 5770 mesa: 10.2.2 with gallium/llvm backend llvm: 3.4.2 linux: 3.15.3 xf86-video-ati: 7.4.0 Switching from the software to the OpenGL backend in Gwenview with EGL enabled QT4 crashes with the following BT: state_tracker/st_atom_framebuffer.c:60:update_framebuffer_size:

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-16 Thread Thorsten Glaser
On Wed, 16 Jul 2014, John Paul Adrian Glaubitz wrote: Absolutely. Could the upstream Mesa developers maybe apply the patch as well? They are not taking us for real, see #728053 for their feedback… We're putting lots of efforts into the m68k port and we have many users who love running

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-16 Thread Eero Tamminen
Hi, On keskiviikko 16 heinäkuu 2014, Thorsten Glaser wrote: On Wed, 16 Jul 2014, John Paul Adrian Glaubitz wrote: Absolutely. Could the upstream Mesa developers maybe apply the patch as well? They are not taking us for real, see #728053 for their feedback… While effect of unaligned

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] i965/fs: Set force_uncompressed and force_sechalf on samplepos setup.

2014-07-16 Thread Anuj Phogat
On Thu, Jul 10, 2014 at 8:51 PM, Kenneth Graunke kenn...@whitecape.org wrote: gen8_fs_generator uses these to decide whether to set the execution size to 8 or 16, so we incorrectly made both of these MOVs the full width in SIMD16 shaders. (It happened to work out on Gen4-7.) Setting them

Re: [Mesa-dev] [PATCH] glapi: add indexed blend functions (GL 4.0)

2014-07-16 Thread Matt Turner
On Wed, Jul 16, 2014 at 5:38 PM, Anuj Phogat anuj.pho...@gmail.com wrote: I agree with Ken's comment# 11 on bugzilla. For those attempting to follow along: https://bugs.freedesktop.org/show_bug.cgi?id=78716 Ian, there's a spec question in there for you.

Re: [Mesa-dev] [PATCH] glapi: add indexed blend functions (GL 4.0)

2014-07-16 Thread Matt Turner
On Mon, Jul 14, 2014 at 9:38 PM, Tapani Pälli tapani.pa...@intel.com wrote: This makes some of the UE4 engine demos (Stylized, Mobile Temple) render correctly, tested on Intel Haswell machine. Signed-off-by: Tapani Pälli tapani.pa...@intel.com This should have a Bugzilla: tag.

Re: [Mesa-dev] [PATCH 0/5] RadeonSI Draw Indirect re-spin

2014-07-16 Thread Michel Dänzer
On 08.07.2014 10:37, Marek Olšák wrote: I'm re-sending what remains to be merged to get ARB_draw_indirect on radeonsi. They are patches 3-5. The first 2 patches bump the LLVM version requirement to 3.4.2, which contains a fix for the calling convention to allow one more user SGPR.

Re: [Mesa-dev] [PATCH] glapi: add indexed blend functions (GL 4.0)

2014-07-16 Thread Tapani
On 07/17/2014 04:31 AM, Matt Turner wrote: On Mon, Jul 14, 2014 at 9:38 PM, Tapani Pälli tapani.pa...@intel.com wrote: This makes some of the UE4 engine demos (Stylized, Mobile Temple) render correctly, tested on Intel Haswell machine. Signed-off-by: Tapani Pälli tapani.pa...@intel.com This