[Mesa-dev] [PATCH 2/5] r600g/radeonsi: Use write-combined CPU mappings of some BOs in GTT

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/r300/r300_query.c | 2 +- src/gallium/drivers/r300/r300_render.c| 2 +- src/gallium/drivers/r300/r300_screen_buffer.c | 4 ++--

[Mesa-dev] [PATCH 1/5] winsys/radeon: Use separate caching buffer managers for VRAM and GTT

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Should reduce overhead because the caching buffer manager doesn't need to consider buffers of the wrong type. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 10 +++---

[Mesa-dev] [PATCH 0/5] radeon: Write-combined CPU mappings of BOs in GTT

2014-07-17 Thread Michel Dänzer
In order to try and improve X(Shm)PutImage performance with glamor, I implemented support for write-combined CPU mappings of BOs in GTT. This did provide a nice speedup, but to my surprise, using VRAM instead of write-combined GTT turned out to be even faster in general on my Kaveri machine, both

[Mesa-dev] [PATCH 4/5] r600g, radeonsi: Use write-combined persistent GTT mappings

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com This is hopefully safe: The kernel makes sure writes to these mappings finish before the GPU might start reading from them, and the GPU caches are invalidated at the start of a command stream. Signed-off-by: Michel Dänzer michel.daen...@amd.com ---

[Mesa-dev] [PATCH 2/5] drm/radeon: Pass GART page flags to radeon_gart_set_page() explicitly

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- drivers/gpu/drm/radeon/r100.c| 2 +- drivers/gpu/drm/radeon/r300.c| 12 +--- drivers/gpu/drm/radeon/radeon.h | 12 +--- drivers/gpu/drm/radeon/radeon_asic.h |

[Mesa-dev] [PATCH 3/5] r600g/radeonsi: Prefer VRAM for CPU - GPU streaming buffers

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeon/r600_buffer_common.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c

[Mesa-dev] [PATCH 5/5] drm/radeon: Use VRAM for indirect buffers on = SI

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- drivers/gpu/drm/radeon/cik.c | 3 +++ drivers/gpu/drm/radeon/cik_sdma.c| 2 ++ drivers/gpu/drm/radeon/ni.c | 3 +++ drivers/gpu/drm/radeon/ni_dma.c | 2 ++

[Mesa-dev] [PATCH 3/5] drm/radeon: Allow write-combined CPU mappings of BOs in GTT

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- drivers/gpu/drm/radeon/cik.c | 4 ++-- drivers/gpu/drm/radeon/cik_sdma.c | 3 ++- drivers/gpu/drm/radeon/evergreen.c| 12 drivers/gpu/drm/radeon/r600.c

[Mesa-dev] [PATCH 4/5] drm/radeon: Use write-combined CPU mappings of rings and IBs on = SI

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- drivers/gpu/drm/radeon/cik.c | 3 +++ drivers/gpu/drm/radeon/cik_sdma.c| 4 drivers/gpu/drm/radeon/ni.c | 3 +++ drivers/gpu/drm/radeon/ni_dma.c | 4

[Mesa-dev] [PATCH 1/5] drm/radeon: Remove radeon_gart_restore()

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Doesn't seem necessary, the GART table memory should be persistent. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- drivers/gpu/drm/radeon/cik.c | 1 - drivers/gpu/drm/radeon/evergreen.c | 1 - drivers/gpu/drm/radeon/ni.c |

[Mesa-dev] [PATCH 5/5] r600g, radeonsi: Prefer VRAM for persistent mappings

2014-07-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeon/r600_buffer_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c

Re: [Mesa-dev] [PATCH 0/5] radeon: Write-combined CPU mappings of BOs in GTT

2014-07-17 Thread Christian König
Am 17.07.2014 12:01, schrieb Michel Dänzer: In order to try and improve X(Shm)PutImage performance with glamor, I implemented support for write-combined CPU mappings of BOs in GTT. This did provide a nice speedup, but to my surprise, using VRAM instead of write-combined GTT turned out to be

Re: [Mesa-dev] [PATCH 4/5] r600g, radeonsi: Use write-combined persistent GTT mappings

2014-07-17 Thread Grigori Goronzy
On 17.07.2014 12:01, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com This is hopefully safe: The kernel makes sure writes to these mappings finish before the GPU might start reading from them, and the GPU caches are invalidated at the start of a command stream. Aren't CPU

Re: [Mesa-dev] [PATCH] Fix crash in update_framebuffer_state

2014-07-17 Thread Marek Olšák
The patch is wrong. is_rtt is only set for textures, not renderbuffers, so it breaks rendering to depth renderbuffers. Marek On Thu, Jul 17, 2014 at 12:02 AM, David Weber weber.aulend...@gmail.com wrote: Hi, GPU: Radeon HD 5770 mesa: 10.2.2 with gallium/llvm backend llvm: 3.4.2 linux:

Re: [Mesa-dev] [PATCH 4/5] r600g, radeonsi: Use write-combined persistent GTT mappings

2014-07-17 Thread Marek Olšák
The resource flags actually tell you what you can do. If the COHERENT flag is set, the mapping must be cached. If it's unset, it's up to you. If write-combining is faster for vertex uploads, then Glamor shouldn't set the coherent flag. Marek On Thu, Jul 17, 2014 at 12:01 PM, Michel Dänzer

Re: [Mesa-dev] [PATCH 1/2] clover: Call end_query before getting timestamp result v2

2014-07-17 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: v2: - Move the end_query() call into the timestamp constructor. - Still pass false as the wait parameter to get_query_result(). Reviewed-by: Francisco Jerez curroje...@riseup.net --- src/gallium/state_trackers/clover/core/timestamp.cpp | 1

Re: [Mesa-dev] [PATCH 5/5] r600g, radeonsi: Prefer VRAM for persistent mappings

2014-07-17 Thread Marek Olšák
Like I said at patch 4, this would be okay if the COHERENT flag wasn't set. If you removed the PERSISTENT flag from the conditional, the placement of persistent non-coherent buffers would be driven by the usage, meaning that you would be able to get any kind of placement you want. Marek On Thu,

Re: [Mesa-dev] [PATCH 2/2] clover: Use 1 as default value for CL_DEVICE_PROFILING_TIMER_RESOLUTION

2014-07-17 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: We use PIPE_QUERY_TIMESTAMP for profiling events, and gallium specifies that the timestamp be in nanoseconds. --- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 0/5] radeon: Write-combined CPU mappings of BOs in GTT

2014-07-17 Thread Marek Olšák
On Thu, Jul 17, 2014 at 12:01 PM, Michel Dänzer mic...@daenzer.net wrote: Mesa patches: [PATCH 1/5] winsys/radeon: Use separate caching buffer managers for [PATCH 2/5] r600g/radeonsi: Use write-combined CPU mappings of some [PATCH 3/5] r600g/radeonsi: Prefer VRAM for CPU - GPU streaming For

Re: [Mesa-dev] [PATCH 0/5] radeon: Write-combined CPU mappings of BOs in GTT

2014-07-17 Thread Alex Deucher
On Thu, Jul 17, 2014 at 6:01 AM, Michel Dänzer mic...@daenzer.net wrote: In order to try and improve X(Shm)PutImage performance with glamor, I implemented support for write-combined CPU mappings of BOs in GTT. This did provide a nice speedup, but to my surprise, using VRAM instead of

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-17 Thread Thorsten Glaser
On Thu, 17 Jul 2014, Eero Tamminen wrote: While effect of unaligned accesses is normally invisible, No, the compiler is inserting padding here silently. We call this “implicit padding”. The problem with it is that this padding is architecture-dependent, and some platforms have other alignment

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-17 Thread Ilia Mirkin
On Thu, Jul 17, 2014 at 4:21 AM, Thorsten Glaser t.gla...@tarent.de wrote: On Thu, 17 Jul 2014, Eero Tamminen wrote: While effect of unaligned accesses is normally invisible, No, the compiler is inserting padding here silently. We call this “implicit padding”. The problem with it [ strip

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-17 Thread Jan Vesely
On Thu, 2014-07-17 at 10:21 +0200, Thorsten Glaser wrote: On Thu, 17 Jul 2014, Eero Tamminen wrote: While effect of unaligned accesses is normally invisible, No, the compiler is inserting padding here silently. We call this “implicit padding”. The problem with it is that this padding is

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-17 Thread Ilia Mirkin
On Thu, Jul 17, 2014 at 10:24 AM, Thorsten Glaser t.gla...@tarent.de wrote: On Thu, 17 Jul 2014, Ilia Mirkin wrote: Yes, implicit padding is definitely bad. I didn't realize I even had it in there, although I'm glad my STATIC_ASSERT did its job. There are ;-) various references to patches,

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-17 Thread Thorsten Glaser
On Thu, 17 Jul 2014, Ilia Mirkin wrote: Yes, implicit padding is definitely bad. I didn't realize I even had it in there, although I'm glad my STATIC_ASSERT did its job. There are ;-) various references to patches, however I haven't seen any. Perhaps they're lost in my inbox, or they were

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-17 Thread Thorsten Glaser
On Thu, 17 Jul 2014, Jan Vesely wrote: why not use __attribute__ ((aligned(X))) for explicit padding? That’s ① GCC-specific and ② relies on environmental guarantees that cannot always be given (e.g. you cannot align a struct more than the stack alignment if it is ever passed on the stack; for

Re: [Mesa-dev] Updated debdiff for mesa to compile on m68k

2014-07-17 Thread John Paul Adrian Glaubitz
Hi Ilia! On 07/17/2014 04:35 PM, Ilia Mirkin wrote: Thanks! Munged the commit description a little and pushed to the master branch. I think the patches for 10.2.4 have already been selected, so it should make its way into 10.2.5. Awesome, thank you so much! Glad we could finally this one :).

Re: [Mesa-dev] [PATCH 0/2] Make a llvmpipe context basically thread safe.

2014-07-17 Thread Jose Fonseca
Hi Mathias, Thanks for doing this. Patch 2 looks great. For patch 1 I'd prefer that instead of keeping a global list of contexts, these are passed by the caller as argument to gallivm_create() . It will be a more invasive change, but it will be cleaner. And in particular it will garantee

[Mesa-dev] [PATCH] mesa: Correctly use glDrawBuffers for multiple buffers and glDrawBuffer for one buffer.

2014-07-17 Thread Pavel Popov
According to spec (OpenGL 4.0 specification, pages 254-255) we have a different bits set for one buffer and for multiple buffers. For glDrawBuffer we may have up to four bits set but for glDrawBuffers we can only have one bit set. The _mesa_drawbuffers is called with ctx-Const.MaxDrawBuffers

[Mesa-dev] [PATCH 1/2] radeon/llvm: enable unsafe math for graphics shaders

2014-07-17 Thread Grigori Goronzy
Accuracy of some operations was recently improved in the R600 backend, at the cost of slower code. This is required for compute shaders, but not for graphics shaders. Add unsafe-fp-math hint to make LLVM generate faster but possibly less accurate code. Piglit didn't indicate any regressions. ---

[Mesa-dev] [PATCH 2/2] radeon/llvm: fix formatting

2014-07-17 Thread Grigori Goronzy
Use KR and same indent as most other code. No functional change intended. --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-07-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #8 from Emil Velikov emil.l.veli...@gmail.com --- Juha-Pekka, Bryan Can you guys test the patch in comment 7 ? I feel slightly reluctant about breaking my system in order to test it myself. -- You are receiving this mail because:

[Mesa-dev] [PATCH 03/12] main/formats: Remove IndexBits

2014-07-17 Thread Jason Ekstrand
Mesa hasn't supported color-indexed textures for some time. This is 0 for all texture formats, so we don't need to store it. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_info.py | 2 +- src/mesa/main/formats.c | 3 +-- 2 files changed, 2 insertions(+), 3

[Mesa-dev] [PATCH 01/12] main: Add a format description CSV file

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/formats.csv | 282 ++ 1 file changed, 282 insertions(+) create mode 100644 src/mesa/main/formats.csv diff --git a/src/mesa/main/formats.csv b/src/mesa/main/formats.csv new file

[Mesa-dev] [PATCH 04/12] main/formats: Add layout and swizzle information

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_info.py | 11 +++ src/mesa/main/formats.c | 46 src/mesa/main/formats.h | 29 3 files changed, 86 insertions(+) diff --git

[Mesa-dev] [PATCH 00/12] Rework texture upload code

2014-07-17 Thread Jason Ekstrand
This is the first installment of some work I've been doing over the past couple of weeks to refactor mesa's texture conversion/storage code. There is more to be done and more that I have done but have not included in this series. This is the first mailing-list-ready fruits of my efforts. The

[Mesa-dev] [PATCH 10/12] main/format_pack: Fix a wrong datatype in pack_ubyte_R8G8_UNORM

2014-07-17 Thread Jason Ekstrand
Before it was only storing one of the color components due to truncation. With this patch it now properly stores all of them. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 06/12] main/format_utils: Add a general format conversion function

2014-07-17 Thread Jason Ekstrand
Most format conversion operations required by GL can be performed by converting one channel at a time, shuffling the channels around, and optionally filling missing channels with zeros and ones. This adds a function to do just that in a general, yet efficient, way. Signed-off-by: Jason Ekstrand

[Mesa-dev] [PATCH 08/12] main/texstore: Split texture storage into three functions: texstore_depth_stencil, texstore_compressed, and texstore_rgba

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 171 +++ 1 file changed, 100 insertions(+), 71 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index d363f9f..e1f2284 100644 ---

[Mesa-dev] [PATCH 07/12] main/format_utils: Add a function for determining if a format is actually an array format and computing the array format parameters

2014-07-17 Thread Jason Ekstrand
This is a direct helper function for using _mesa_swizzle_and_convert Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/format_utils.c | 93 src/mesa/main/format_utils.h | 4 ++ 2 files changed, 97 insertions(+) diff --git

[Mesa-dev] [PATCH 05/12] main: Gather some common format conversion functions into a single format_utils file

2014-07-17 Thread Jason Ekstrand
This initial commit puts all of the RGB - sRGB conversion functions in one place. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/Makefile.sources| 1 + src/mesa/main/format_pack.c | 102 ++- src/mesa/main/format_unpack.c

[Mesa-dev] [PATCH 12/12] mesa/texstore: Add a generic rgba integer texture upload path

2014-07-17 Thread Jason Ekstrand
Again, we delete a lot of functions that aren't really doing anything interesting anymore. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 545 ++- 1 file changed, 66 insertions(+), 479 deletions(-) diff --git

[Mesa-dev] [PATCH 09/12] main/texstore: Use _mesa_swizzle_and_convert when possible

2014-07-17 Thread Jason Ekstrand
This should be both faster and more accurate than our general slow-path of converting everything to float. Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/main/texstore.c | 179 +++ 1 file changed, 164 insertions(+), 15 deletions(-)

[Mesa-dev] [PATCH] i965: Add missing persample_shading field to brw_wm_debug_recompile.

2014-07-17 Thread Kenneth Graunke
Otherwise, the performance warning for shader recompiles will just say something else. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_wm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_wm.c

Re: [Mesa-dev] [PATCH] i965: Fix z_offset computation in intel_miptree_unmap_depthstencil()

2014-07-17 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Wed, Jul 16, 2014 at 3:32 PM, Anuj Phogat anuj.pho...@gmail.com wrote: The bug is triggered by using glTexSubImage2d() with GL_DEPTH_STENCIL as base internal format and non-zero x, y offsets. Currently x, y offsets are ignored while

Re: [Mesa-dev] [PATCH 1/2] radeon/llvm: enable unsafe math for graphics shaders

2014-07-17 Thread Tom Stellard
On Thu, Jul 17, 2014 at 06:44:25PM +0200, Grigori Goronzy wrote: Accuracy of some operations was recently improved in the R600 backend, at the cost of slower code. This is required for compute shaders, but not for graphics shaders. Add unsafe-fp-math hint to make LLVM generate faster but

Re: [Mesa-dev] Release-candidate branch for upcoming 10.2.4

2014-07-17 Thread Marek Olšák
Radeonsi was indeed broken with those fixes (only CubeShadow samplers). The attached patch fixes it. Please add it to 10.2. Thanks. Marek On Tue, Jul 15, 2014 at 6:49 AM, Carl Worth cwo...@cworth.org wrote: Hi folks, I've pushed out an update to the 10.2 branch and I need some specific

Re: [Mesa-dev] [PATCH] i965: Add missing persample_shading field to brw_wm_debug_recompile.

2014-07-17 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On Thu, Jul 17, 2014 at 11:18 AM, Kenneth Graunke kenn...@whitecape.org wrote: Otherwise, the performance warning for shader recompiles will just say something else. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

Re: [Mesa-dev] [PATCH] i915: Fix up intelInitScreen2 for DRI3

2014-07-17 Thread Kenneth Graunke
On Thursday, July 03, 2014 10:13:53 PM Adel Gadllah wrote: Commit 442442026eb updated both i915 and i965 for DRI3 support, but one check in intelInitScreen2 was missed for i915 causing crashes when trying to use i915 with DRI3. So fix that up. Reported-by: Igor Gnatenko

Re: [Mesa-dev] [Mesa-stable] Release-candidate branch for upcoming 10.2.4

2014-07-17 Thread Carl Worth
Marek Olšák mar...@gmail.com writes: Radeonsi was indeed broken with those fixes (only CubeShadow samplers). The attached patch fixes it. Please add it to 10.2. Thanks. Thanks, Marek! This is exactly the kind of breakage I was worried about, and exactly the kind of test reporting I was hoping

[Mesa-dev] [PATCH 2/2] Add support for RGBA8 and RGBX8 textures in intel_texsubimage_tiled_memcpy

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index 04cbc4c..4043eb7 100644

[Mesa-dev] [PATCH 1/2] i965: Improve debug output in intelTexImage and intelTexSubimage

2014-07-17 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_image.c| 4 +++- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c

Re: [Mesa-dev] [PATCH 1/2] i965: Improve debug output in intelTexImage and intelTexSubimage

2014-07-17 Thread Matt Turner
These two are Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/7] i965: Replace cfg instances with calls to calculate_cfg().

2014-07-17 Thread Matt Turner
Avoids regenerating it unnecessarily. Every program in shader-db improved, none by an amount less than a 1/3 reduction. One Dota2 shader decreased from 62 - 24. cfg calculations: 429492 - 193197 (-55.02%) --- .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 20 +++-

[Mesa-dev] [PATCH 7/7] i965: Pass a cfg pointer to generate_{code, assembly}.

2014-07-17 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 4 +++- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 ++ src/mesa/drivers/dri/i965/brw_fs.h| 12 ++-- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 22 +-

[Mesa-dev] [PATCH 0/7] i965: Preserve the CFG (first pass)

2014-07-17 Thread Matt Turner
We'd like to avoid regenerating the control flow graph for every pass that uses it. This series adds a cfg pointer to the backend visitor class that we use to save the CFG across optimization passes. It's invalidated and recreated by invalidate/calculate_cfg and these functions are called by the

[Mesa-dev] [PATCH 4/7] i965/vec4: Use foreach_inst_in_block a couple more places.

2014-07-17 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 + src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 5 + 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 49a4e9b..045e1c5 100644 ---

[Mesa-dev] [PATCH 2/7] i965/cfg: Add a foreach_block_and_inst macro.

2014-07-17 Thread Matt Turner
Will let us abstract how the instructions are stored. --- src/mesa/drivers/dri/i965/brw_cfg.h | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mesa/drivers/dri/i965/brw_cfg.h index cdbadde..01fcc1b 100644 --- a/src/mesa/drivers/dri/i965/brw_cfg.h

[Mesa-dev] [PATCH 6/7] i965: Add and use foreach_block macro.

2014-07-17 Thread Matt Turner
Use this as an opportunity to rename 'block_num' to 'num'. block-num is clear, and block-block_num has always been redundant. --- src/mesa/drivers/dri/i965/brw_cfg.cpp | 17 ++--- src/mesa/drivers/dri/i965/brw_cfg.h| 5 +-

[Mesa-dev] [PATCH 1/7] i965: Add cfg to backend_visitor.

2014-07-17 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp | 6 +++--- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_cse.cpp| 7 +++ .../drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 8 +++-

[Mesa-dev] [PATCH 5/7] i965/cfg: Embed link in bblock_t for main block list.

2014-07-17 Thread Matt Turner
The next patch adds a foreach_block (block, cfg) macro, which works better if it provides a direct bblock_t pointer, rather than a bblock_link pointer that you have to use to find the actual block. --- src/mesa/drivers/dri/i965/brw_cfg.cpp | 10 +- src/mesa/drivers/dri/i965/brw_cfg.h |

Re: [Mesa-dev] [PATCH 0/6] Enable Pixman for Mesa

2014-07-17 Thread Jason Ekstrand
Juha-Pekka, The patch I just sent to the list here: http://lists.freedesktop.org/archives/mesa-dev/2014-July/063501.html Should also help with chrome performance. We have had a fast-path inside the intel driver for some time to do BGRA/RGBA - BGRA conversions. For some reason, chrome seems to

[Mesa-dev] [PATCH] i965/disasm: Don't disassemble the URB complete field on Broadwell.

2014-07-17 Thread Kenneth Graunke
It doesn't exist, so attempting to read it will trigger generation assertions in the brw_inst API. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_disasm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-07-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 Mau mav...@gmail.com changed: What|Removed |Added CC||mav...@gmail.com -- You are

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-07-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 --- Comment #7 from Axel Davy veb...@hotmail.fr --- It could be solved by this commit: http://cgit.freedesktop.org/mesa/mesa/commit/?h=10.2id=3ca21195939477fa1f9b113ce4f6da36a8480321 Please test mesa git or mesa 10.2.3 -- You are receiving

Re: [Mesa-dev] [PATCH 2/2] Add support for RGBA8 and RGBX8 textures in intel_texsubimage_tiled_memcpy

2014-07-17 Thread Kenneth Graunke
On Thursday, July 17, 2014 02:41:31 PM Jason Ekstrand wrote: Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c

[Mesa-dev] [PATCH] i965: Disable hex offset printing in disassembly.

2014-07-17 Thread Kenneth Graunke
Printing the hex offsets makes it basically impossible to diff assembly: if you add even a single instruction, the entire shader shows up as a difference. So, every time I want to compare assembly, I have to strip this out. The hex offsets might be useful when debugging compaction, or when

Re: [Mesa-dev] [PATCH 07/23] glsl/glcpp: Stop using a lexer start condition (SKIP) for token skipping.

2014-07-17 Thread Jordan Justen
On Thu, Jun 26, 2014 at 3:19 PM, Carl Worth cwo...@cworth.org wrote: Here, skipping refers to the lexer not emitting any tokens for portions of the file within an #if condition (or similar) that evaluates to false. Previously, the lexer had a special SKIP start condition used to control this

[Mesa-dev] [PATCH] i965: Don't print WE_normal in disassembly.

2014-07-17 Thread Kenneth Graunke
Dropping this helps most lines fit in an 80 column terminal. The absence of WE_normal also helps call attention to WE_all, where something unusual is going on. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Matt Turner matts...@gmail.com --- src/mesa/drivers/dri/i965/brw_disasm.c | 2

Re: [Mesa-dev] [PATCH] i965: Don't print WE_normal in disassembly.

2014-07-17 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Disable hex offset printing in disassembly.

2014-07-17 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/disasm: Don't disassemble the URB complete field on Broadwell.

2014-07-17 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] glsl/glcpp: A bunch of pre-processor cleanups

2014-07-17 Thread Jordan Justen
Made it ~25% through. :) I'll be busy for a bit, but I'll continue looking at the rest later. 01/23 glsl/glcpp: Emit proper error for #define with a non-identifier Reviewed-by: Jordan Justen jordan.l.jus...@intel.com 02/23 glsl/glcpp: Add support for comments between #define and macro

[Mesa-dev] [PATCH 3/3] gbm: Log at least one dlerror() when we fail to open any drivers.

2014-07-17 Thread Eric Anholt
We don't want to log every single error (such as all the ones where the file wasn't even present in our list of search paths), but if you didn't find any driver, then seeing at least one error is useful (since the common case as a developer is a single DEFAULT_DRIVER_DIR or GBM_DRIVERS_PATH

[Mesa-dev] [PATCH 1/3] gallium: Add a uif() helper function to complement fui()

2014-07-17 Thread Eric Anholt
I found myself often wanting this when I'm printing out a uint32_t mapping of some GPU data, and I want to put in an interpretation of that value as a float. --- src/gallium/auxiliary/util/u_math.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h

[Mesa-dev] [PATCH 2/3] gbm: Fix a debug log message

2014-07-17 Thread Eric Anholt
--- src/gbm/backends/dri/gbm_dri.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 347bc99..f421a03 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri/gbm_dri.c @@ -243,7 +243,7 @@

[Mesa-dev] common-code patches before vc4 driver

2014-07-17 Thread Eric Anholt
Here are the patches I have for common code in my vc4 driver tree. I think they should be obvious enough. I'm curious what people feel about merging vc4. I've got a series at this point that's clean enough in my opinion (copyrights fixed up, and I think a tolerable mix of giant code dump for

Re: [Mesa-dev] [PATCHi v3] r600g: Implement GL_ARB_texture_gather

2014-07-17 Thread Marek Olšák
Pushed. Thanks. Marek On Wed, Jul 16, 2014 at 4:31 PM, Glenn Kennard glenn.kenn...@gmail.com wrote: Only supported on evergreen and later. Currently limited to single component textures as the hardware GATHER4 instruction ignores texture swizzles. Piglit quick run passes on radeon 6670 with

Re: [Mesa-dev] [PATCH 2/2] Add support for RGBA8 and RGBX8 textures in intel_texsubimage_tiled_memcpy

2014-07-17 Thread Chad Versace
Both patches are Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] gallium: Add a uif() helper function to complement fui()

2014-07-17 Thread Michel Dänzer
On 18.07.2014 08:56, Eric Anholt wrote: I found myself often wanting this when I'm printing out a uint32_t mapping of some GPU data, and I want to put in an interpretation of that value as a float. --- src/gallium/auxiliary/util/u_math.h | 8 1 file changed, 8 insertions(+) diff

Re: [Mesa-dev] [PATCH] mesa: Correctly use glDrawBuffers for multiple buffers and glDrawBuffer for one buffer.

2014-07-17 Thread Popov, Pavel E
Hi Kenneth, Ian, Could you look through my patch? Regards, Pavel -Original Message- From: Popov, Pavel E Sent: Thursday, July 17, 2014 10:21 PM To: mesa-dev@lists.freedesktop.org Cc: Popov, Pavel E Subject: [PATCH] mesa: Correctly use glDrawBuffers for multiple buffers and

[Mesa-dev] [Bug 36414] Screen mess white smoke when running vdrift

2014-07-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36414 meng mengmeng.m...@intel.com changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are

[Mesa-dev] [Bug 36414] Screen mess white smoke when running vdrift

2014-07-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36414 --- Comment #12 from meng mengmeng.m...@intel.com --- As the issue is application's bug, verified it. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 0/5] [RFC] r600g/compute: Adding support for defragmenting compute_memory_pool

2014-07-17 Thread Tom Stellard
On Wed, Jul 16, 2014 at 11:12:42PM +0200, Bruno Jiménez wrote: Hi, This series finally adds support for defragmenting the pool for OpenCL buffers in the r600g driver. It is mostly a rewritten of the series that I wrote some months ago. For defragmenting the pool I have thought of two

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-07-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 --- Comment #8 from Joseph Booker j...@neoturbine.net --- Thanks. It doesn't seem to address this. With xf86-video-intel 2.99.912, the same problem shows with mesa 10.2.3 and mesa master branch (on commit f14d217f5c72651b9f24a83b11ace16837db4603

Re: [Mesa-dev] [PATCH 0/5] radeon: Write-combined CPU mappings of BOs in GTT

2014-07-17 Thread Michel Dänzer
On 17.07.2014 19:09, Christian König wrote: Am 17.07.2014 12:01, schrieb Michel Dänzer: In order to try and improve X(Shm)PutImage performance with glamor, I implemented support for write-combined CPU mappings of BOs in GTT. This did provide a nice speedup, but to my surprise, using VRAM

Re: [Mesa-dev] [PATCH 4/5] r600g, radeonsi: Use write-combined persistent GTT mappings

2014-07-17 Thread Michel Dänzer
On 17.07.2014 21:00, Marek Olšák wrote: On Thu, Jul 17, 2014 at 12:01 PM, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com This is hopefully safe: The kernel makes sure writes to these mappings finish before the GPU might start reading from them, and the GPU

Re: [Mesa-dev] [PATCH] i965: Set minimum point size to 1.0 for non-sprite non-aa points

2014-07-17 Thread Popov, Pavel E
Hi Ian, Looks like this patch is not reasonable for Mesa which now concentrates on OpenGL 3.3 Core. Am I right? I prepared this patch to pass Piglit test 'spec_OpenGL_2.0_vs-point_size-zero' which was created for earlier versions of OpenGL. Also I found these analogous patches for 'svga',