Re: [Mesa-dev] [PATCH 1/2] clover: fix tab/space and alignement

2014-11-10 Thread EdB
On Monday 10 November 2014 19:03:43 Francisco Jerez wrote: > EdB writes: > > --- > > > > src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp > > b/src/gal

[Mesa-dev] [PATCH 1/2] i965/fs: Don't use if_block/else_block in SEL peephole.

2014-11-10 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp b/src/mesa/drivers/dri/i965/brw_fs_sel_peephole.cpp index c3bfd00..f18589c 100644 --- a/src/mesa/drivers/d

[Mesa-dev] [PATCH 2/2] i965/cfg: Remove if_block/else_block.

2014-11-10 Thread Matt Turner
I used these in the SEL peephole, but they require extra tracking and fix ups. The SEL peephole can pretty easily find the blocks it needs without these. --- src/mesa/drivers/dri/i965/brw_cfg.cpp | 15 +-- src/mesa/drivers/dri/i965/brw_cfg.h | 8

Re: [Mesa-dev] [PATCH] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-10 Thread Kenneth Graunke
On Monday, November 10, 2014 02:57:22 PM Neil Roberts wrote: > I'm not really sure if I understand your reply correctly. Did you see > that I also posted the corresponding kernel patch? I was testing my > patch on top of the drm-intel-next branch with IvyBridge. That's why. Ivybridge has had the

Re: [Mesa-dev] How difficult would it be to have debugging information for Jitted code show up?

2014-11-10 Thread Kenneth Graunke
On Tuesday, November 11, 2014 12:27:26 AM Steven Stewart-Gallus wrote: > Hello, > > Before filing a bug report, I wanted to have ask first how difficult it'd be > to > have debugging information for Jitted code show up be. It occurs to me that > this > probably wouldn't work for precompiled shad

Re: [Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

2014-11-10 Thread kalyan kondapally
The patch seems to fix the crash I used to see while running this WebGL conformance test on my machine (Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz). and now I can see all the tests pass. I believe 78770 is a different issue (Added my comments to 78770) and not actually dealing with fixing the crash w

[Mesa-dev] How difficult would it be to have debugging information for Jitted code show up?

2014-11-10 Thread Steven Stewart-Gallus
Hello, Before filing a bug report, I wanted to have ask first how difficult it'd be to have debugging information for Jitted code show up be. It occurs to me that this probably wouldn't work for precompiled shader sources and that there's probably not a lot of code that has been written to support

Re: [Mesa-dev] [PATCH v2 04/14] i965/gen7: Don't allocate hiz miptree structure

2014-11-10 Thread Ben Widawsky
On Mon, Jul 21, 2014 at 11:00:53PM -0700, Jordan Justen wrote: > We now skip allocating a hiz miptree for gen7. Instead, we calculate > the required hiz buffer parameters and allocate a bo directly. > > v2: > * Update hz_height calculation as suggested by Topi > > Signed-off-by: Jordan Justen >

Re: [Mesa-dev] Bogus bounds checking in api_validate.c?

2014-11-10 Thread Timothy Arceri
On Mon, 2014-11-10 at 06:09 -0800, Ian Romanick wrote: > On 11/06/2014 11:40 PM, Kenneth Graunke wrote: > > On Thursday, November 06, 2014 08:09:18 PM Ian Romanick wrote: > >> While working on some other things, I came across some bounds checking > >> code in _mesa_validate_DrawElements (and relate

Re: [Mesa-dev] [PATCH] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-10 Thread Neil Roberts
Neil Roberts writes: > It looks like the PRM for Haswell says that MI_LOAD_REGISTER_MEM is > converted to no-op for non-privileged buffers. However I can't find any > mention of this for IvyBridge. Does that mean it's allowed on IvyBridge > but it won't work on Haswell? I haven't tested it on Has

[Mesa-dev] [PATCHv2] auxiliary/vl: rework the build of the VL code

2014-11-10 Thread Emil Velikov
Rather than shoving all the VL code for non-VL targets, increasing their size, just split it out and use it when needed. This gives us the side effect of building vl_winsys_dri.c once, dropping a few automake warnings, and reducing the size of the dri modules as below textdata bss d

Re: [Mesa-dev] [PATCH v2 03/14] i965/gen8: Don't rely directly on the hiz miptree structure

2014-11-10 Thread Ben Widawsky
On Mon, Jul 21, 2014 at 11:00:52PM -0700, Jordan Justen wrote: > We are still allocating a miptree for hiz, but we only use fields from > intel_miptree_aux_buffer. This will allow us to switch over to not > allocating a miptree. > > Signed-off-by: Jordan Justen > Reviewed-by: Topi Pohjolainen >

Re: [Mesa-dev] [PATCH 3/3] gk20a: use NOUVEAU_BO_GART as VRAM domain

2014-11-10 Thread Ilia Mirkin
On Wed, Nov 5, 2014 at 5:23 AM, Alexandre Courbot wrote: > On 10/30/2014 12:29 AM, Ilia Mirkin wrote: >> >> On Mon, Oct 27, 2014 at 6:34 AM, Alexandre Courbot >> wrote: >>> >>> GK20A does not have dedicated VRAM, therefore allocating in VRAM can be >>> sub-optimal and sometimes even harmful. Set

Re: [Mesa-dev] [PATCH v2 02/14] i965/gen7: Don't rely directly on the hiz miptree structure

2014-11-10 Thread Ben Widawsky
On Mon, Jul 21, 2014 at 11:00:51PM -0700, Jordan Justen wrote: > We are still allocating a miptree for hiz, but we only use fields from > intel_miptree_aux_buffer. This will allow us to switch over to not > allocating a miptree. > > Signed-off-by: Jordan Justen > Reviewed-by: Topi Pohjolainen >

Re: [Mesa-dev] [PATCH v2 01/14] i965/hiz: Start to separate miptree out from hiz buffers

2014-11-10 Thread Ben Widawsky
On Mon, Jul 21, 2014 at 11:00:50PM -0700, Jordan Justen wrote: > Today we allocate a miptree's for the hiz buffer. We needed this in > the past because we would point the hardware at offsets of the hiz > buffer. Since the hiz format is not documented, this is not a good > idea. > > Since moving to

Re: [Mesa-dev] [PATCH 2/2] clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS

2014-11-10 Thread Francisco Jerez
EdB writes: > clCompileProgram should return CL_INVALID_COMPILER_OPTIONS > instead of CL_INVALID_BUILD_OPTIONS Looks good to me, Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/api/program.cpp | 2 ++ > src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- >

Re: [Mesa-dev] [PATCH 1/2] clover: fix tab/space and alignement

2014-11-10 Thread Francisco Jerez
EdB writes: > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp > b/src/gallium/state_trackers/clover/llvm/invocation.cpp > index 3a4fcf0..d29f5a6 10064

[Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

2014-11-10 Thread Chad Versace
Fixes regression of WebGL Conformance test texture-size-limit [1] on Ivybridge Mobile GT2 0x0166 with Google Chrome R38. Regression introduced by commit 6c044231535b93c5d16404528946cad618d96bd9 Author: Kenneth Graunke Date: Sun Feb 2 02:58:42 2014 -0800 i965: Bump GL_MAX_C

Re: [Mesa-dev] [PATCH] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-10 Thread Robert Bragg
On Mon, Nov 10, 2014 at 2:57 PM, Neil Roberts wrote: > > The bit I mentioned about OACONTROL was just saying that the method of > detecting whether we can write to OACONTROL specifically doesn't work. > This is because writing to a register that is not in the whitelist > returns EINVAL and Mesa ca

Re: [Mesa-dev] [PATCH] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-10 Thread Neil Roberts
> On Fri, Nov 07, 2014 at 03:28:01PM +, Neil Roberts wrote: >> Unfortunately these two source registers are not in the whitelist of >> available registers in the kernel driver so this needs a kernel patch >> to work. This patch tries to check whether it is possible to write to >> this register

Re: [Mesa-dev] Bogus bounds checking in api_validate.c?

2014-11-10 Thread Ian Romanick
On 11/10/2014 06:09 AM, Ian Romanick wrote: > On 11/06/2014 11:40 PM, Kenneth Graunke wrote: >> On Thursday, November 06, 2014 08:09:18 PM Ian Romanick wrote: >>> While working on some other things, I came across some bounds checking >>> code in _mesa_validate_DrawElements (and related functions) i

Re: [Mesa-dev] Bogus bounds checking in api_validate.c?

2014-11-10 Thread Ian Romanick
On 11/06/2014 11:40 PM, Kenneth Graunke wrote: > On Thursday, November 06, 2014 08:09:18 PM Ian Romanick wrote: >> While working on some other things, I came across some bounds checking >> code in _mesa_validate_DrawElements (and related functions) in >> api_validate.c. >> >> /* use indices i

Re: [Mesa-dev] [PATCH] egl: dri2: Use present extension. (Was: Re: [RFC] egl: Add DRI3 support to the EGL backend.)

2014-11-10 Thread Joonas Lahtinen
Hi, On pe, 2014-11-07 at 17:40 -0800, Eric Anholt wrote: > Ian Romanick writes: > > > On 11/06/2014 06:16 PM, Michel Dänzer wrote: > >> On 06.11.2014 19:18, Joonas Lahtinen wrote: > >>> On to, 2014-11-06 at 18:12 +0900, Michel Dänzer wrote: > On 05.11.2014 20:14, Joonas Lahtinen wrote: > >>

[Mesa-dev] [Bug 54080] glXQueryDrawable fails with GLXBadDrawable for a Window in direct context

2014-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54080 Kevin Rogovin changed: What|Removed |Added Priority|medium |high Severity|normal

Re: [Mesa-dev] [PATCH] gallium: remove unused pipe_viewport_state::translate[3] and scale[3]

2014-11-10 Thread Marek Olšák
Yes, you're right. I'll fix that. Marek On Mon, Nov 10, 2014 at 12:53 AM, Ilia Mirkin wrote: > On Sun, Nov 9, 2014 at 6:39 PM, Marek Olšák wrote: >> >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >> b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >> index f22755