Re: [Mesa-dev] Bogus bounds checking in api_validate.c?

2014-11-11 Thread Ian Romanick
On 11/10/2014 08:12 PM, Timothy Arceri wrote: On Mon, 2014-11-10 at 06:09 -0800, Ian Romanick wrote: On 11/06/2014 11:40 PM, Kenneth Graunke wrote: On Thursday, November 06, 2014 08:09:18 PM Ian Romanick wrote: While working on some other things, I came across some bounds checking code in

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #54 from Iago Toral ito...@igalia.com --- Hi Jason, I think we are close to completing this, so here is a summary of the current state and how we intend to submit the patches for review, since we assume that you will be reviewing

Re: [Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

2014-11-11 Thread Ian Romanick
On 11/10/2014 04:02 PM, Chad Versace wrote: Fixes regression of WebGL Conformance test texture-size-limit [1] on Ivybridge Mobile GT2 0x0166 with Google Chrome R38. Regression introduced by commit 6c044231535b93c5d16404528946cad618d96bd9 Author: Kenneth Graunke

Re: [Mesa-dev] [PATCH 2/2] i965/cfg: Remove if_block/else_block.

2014-11-11 Thread Jason Ekstrand
Both patches are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Nov 10, 2014 11:37 PM, Matt Turner matts...@gmail.com wrote: I used these in the SEL peephole, but they require extra tracking and fix ups. The SEL peephole can pretty easily find the blocks it needs without these. ---

Re: [Mesa-dev] [PATCH 2/2] i965/cfg: Remove if_block/else_block.

2014-11-11 Thread Jason Ekstrand
Two questions: Does it fix the bug? And did you ever figure out what was going on there? On Nov 11, 2014 6:58 AM, Jason Ekstrand ja...@jlekstrand.net wrote: Both patches are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Nov 10, 2014 11:37 PM, Matt Turner matts...@gmail.com wrote: I

[Mesa-dev] [Bug 85419] [llvmpipe] Assertion fail with triangle strips

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85419 José Fonseca jfons...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 0/2] clover: CL_MEM_HOST_* flags checks

2014-11-11 Thread EdB
This serie add CL_MEM_HOST_WRITE_ONLY, CL_MEM_HOST_READ_ONLY and CL_MEM_HOST_NO_ACCESS checks Those flags should be inherited when creting sub buffer. So I change clGetMemObjectInfo to report them and the otherd that should also be reported. EdB (2): clover: add CL_MEM_HOST_* flags checks

[Mesa-dev] [PATCH 1/2] clover: add CL_MEM_HOST_* flags checks

2014-11-11 Thread EdB
those flags have been introduced in OpenCL 1.2 --- src/gallium/state_trackers/clover/api/memory.cpp | 15 -- src/gallium/state_trackers/clover/api/transfer.cpp | 32 -- 2 files changed, 42 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] clover: clGetMemObjectInfo report sub buffer inherited flags

2014-11-11 Thread EdB
when call cbCreateSubBuffer when followings memory flags are not set they should be inherited from parent buffer. Report them when calling clGetMemObjectInfo flags: CL_MEM_READ_WRITE, CL_MEM_READ_ONLY, CL_MEM_WRITE_ONLY, CL_MEM_USE_HOST_PTR, CL_MEM_ALLOC_HOST_PTR, CL_MEM_COPY_HOST_PTR,

[Mesa-dev] [Bug 85419] [llvmpipe] Assertion fail with triangle strips

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85419 --- Comment #7 from James Evans jreva...@earthlink.net --- I am so sorry for bugging you with this. You are absolutely correct. I completely missed the glEnable call. Adding that fixed everything. Thank you. -- You are receiving this mail

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #55 from Jason Ekstrand ja...@jlekstrand.net --- (In reply to Iago Toral from comment #54) Hi Jason, I think we are close to completing this, so here is a summary of the current state and how we intend to submit the patches for

Re: [Mesa-dev] [PATCH 1/2] clover: add CL_MEM_HOST_* flags checks

2014-11-11 Thread EdB
On Tuesday 11 November 2014 17:42:42 EdB wrote: those flags have been introduced in OpenCL 1.2 --- src/gallium/state_trackers/clover/api/memory.cpp | 15 -- src/gallium/state_trackers/clover/api/transfer.cpp | 32 -- 2 files changed, 42 insertions(+), 5

[Mesa-dev] [Bug 72572] no error on draw call without vbo set

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72572 José Fonseca jfons...@vmware.com changed: What|Removed |Added Priority|medium |low

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 80835, which changed state. Bug 80835 Summary: [llvmpipe] piglit fs-struct-pad regression https://bugs.freedesktop.org/show_bug.cgi?id=80835 What|Removed |Added

[Mesa-dev] [Bug 80835] [llvmpipe] piglit fs-struct-pad regression

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80835 José Fonseca jfons...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 2/2] i965/cfg: Remove if_block/else_block.

2014-11-11 Thread Jason Ekstrand
One more comment: These and the other two CFG fixes should probably be promoted to stable. On Tue, Nov 11, 2014 at 7:37 AM, Jason Ekstrand ja...@jlekstrand.net wrote: Two questions: Does it fix the bug? And did you ever figure out what was going on there? On Nov 11, 2014 6:58 AM, Jason

[Mesa-dev] [Bug 70359] [llvmpipe] piglit arb_shader_texture_lod-texgrad fails

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70359 José Fonseca jfons...@vmware.com changed: What|Removed |Added Summary|[llvmpipe] piglit |[llvmpipe] piglit

Re: [Mesa-dev] [PATCH 2/2] i965/cfg: Remove if_block/else_block.

2014-11-11 Thread Matt Turner
On Tue, Nov 11, 2014 at 7:37 AM, Jason Ekstrand ja...@jlekstrand.net wrote: Two questions: Does it fix the bug? And did you ever figure out what was going on there? It does fix the bug. I checked out your nir-v0.7 branch and did the work from there. I spent probably an hour in gdb trying to

Re: [Mesa-dev] [PATCH 2/2] i965/cfg: Remove if_block/else_block.

2014-11-11 Thread Matt Turner
On Tue, Nov 11, 2014 at 9:27 AM, Jason Ekstrand ja...@jlekstrand.net wrote: One more comment: These and the other two CFG fixes should probably be promoted to stable. Seems like a good plan. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] i965/fs: Remove try_replace_with_sel().

2014-11-11 Thread Matt Turner
The rest of our backend optimizations have replaced the need for this since it was written. instructions in affected programs: 30626 - 30564 (-0.20%) Hurts a small number of CSGO shaders by one instruction, but helps even more. Hurts two by a larger number because of something I noticed when

Re: [Mesa-dev] [PATCH] i965/vec4: Allow CSE on uniform-vec4 expansion MOVs.

2014-11-11 Thread Kenneth Graunke
On Friday, October 24, 2014 03:09:45 PM Matt Turner wrote: Three source instructions cannot directly source a packed vec4 (0,4,1 regioning) like vec4 uniforms, so we emit a MOV that expands the vec4 to both halves of a register. If these uniform values are used by multiple three-source

Re: [Mesa-dev] [PATCH] i965/vec4: Allow CSE on uniform-vec4 expansion MOVs.

2014-11-11 Thread Matt Turner
On Tue, Nov 11, 2014 at 9:48 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Friday, October 24, 2014 03:09:45 PM Matt Turner wrote: Three source instructions cannot directly source a packed vec4 (0,4,1 regioning) like vec4 uniforms, so we emit a MOV that expands the vec4 to both halves of

Re: [Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

2014-11-11 Thread Chad Versace
On Mon 10 Nov 2014, kalyan kondapally wrote: The patch seems to fix the crash I used to see while running this WebGL conformance test on my machine (Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz). and now I can see all the tests pass. I believe 78770 is a different issue (Added my comments to 78770)

Re: [Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

2014-11-11 Thread Chad Versace
On Tue 11 Nov 2014, Ian Romanick wrote: On 11/10/2014 04:02 PM, Chad Versace wrote: map-stride = mt-pitch; - map-ptr = base + y * map-stride + x * mt-cpp; + + /* The variables in below pointer arithmetic are 32-bit. The arithmetic + * overflows for large textures.

Re: [Mesa-dev] [PATCH] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-11 Thread Neil Roberts
Kenneth Graunke kenn...@whitecape.org writes: drm-intel-next must have the new software checker turned on, which disallows non-whitelisted register writes (along with libva, so it can't really be enabled upstream yet). For what it's worth, I get the EINVAL error even on the stock Fedora 20

Re: [Mesa-dev] [PATCH] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-11 Thread Kenneth Graunke
On Tuesday, November 11, 2014 06:59:51 PM Neil Roberts wrote: Kenneth Graunke kenn...@whitecape.org writes: drm-intel-next must have the new software checker turned on, which disallows non-whitelisted register writes (along with libva, so it can't really be enabled upstream yet). For

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Rewrite dead code elimination to use live in/out.

2014-11-11 Thread Matt Turner
On Sat, Nov 8, 2014 at 10:18 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, November 03, 2014 01:34:49 PM Matt Turner wrote: +static bool +can_do_writemask(const struct brw_context *brw, + const vec4_instruction *inst) +{ + switch (inst-opcode) { + case

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Rewrite dead code elimination to use live in/out.

2014-11-11 Thread Matt Turner
On Tue, Nov 11, 2014 at 2:17 PM, Matt Turner matts...@gmail.com wrote: On Sat, Nov 8, 2014 at 10:18 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, November 03, 2014 01:34:49 PM Matt Turner wrote: +static bool +can_do_writemask(const struct brw_context *brw, +

Re: [Mesa-dev] [PATCH v2 01/14] i965/hiz: Start to separate miptree out from hiz buffers

2014-11-11 Thread Jordan Justen
On 2014-11-10 10:42:16, Ben Widawsky wrote: On Mon, Jul 21, 2014 at 11:00:50PM -0700, Jordan Justen wrote: Today we allocate a miptree's for the hiz buffer. We needed this in the past because we would point the hardware at offsets of the hiz buffer. Since the hiz format is not documented,

Re: [Mesa-dev] [PATCH v2 02/14] i965/gen7: Don't rely directly on the hiz miptree structure

2014-11-11 Thread Jordan Justen
On 2014-11-10 10:51:17, Ben Widawsky wrote: On Mon, Jul 21, 2014 at 11:00:51PM -0700, Jordan Justen wrote: We are still allocating a miptree for hiz, but we only use fields from intel_miptree_aux_buffer. This will allow us to switch over to not allocating a miptree. Signed-off-by:

Re: [Mesa-dev] How difficult would it be to have debugging information for Jitted code show up?

2014-11-11 Thread Steven Stewart-Gallus
I'm hoping that it would be possible to have symbol names for Jitted code to show up for profiling tools. For example, with software rendering and examining my code using perf utils 70% of my code is just a mysterious callstack inside the i915 shared library that has no symbols and no source

Re: [Mesa-dev] [PATCH v2 02/14] i965/gen7: Don't rely directly on the hiz miptree structure

2014-11-11 Thread Ben Widawsky
On Tue, Nov 11, 2014 at 03:06:03PM -0800, Jordan Justen wrote: On 2014-11-10 10:51:17, Ben Widawsky wrote: On Mon, Jul 21, 2014 at 11:00:51PM -0700, Jordan Justen wrote: We are still allocating a miptree for hiz, but we only use fields from intel_miptree_aux_buffer. This will allow us to

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Rewrite dead code elimination to use live in/out.

2014-11-11 Thread Kenneth Graunke
On Tuesday, November 11, 2014 02:39:13 PM Matt Turner wrote: On Tue, Nov 11, 2014 at 2:17 PM, Matt Turner matts...@gmail.com wrote: On Sat, Nov 8, 2014 at 10:18 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, November 03, 2014 01:34:49 PM Matt Turner wrote: +static bool

Re: [Mesa-dev] How difficult would it be to have debugging information for Jitted code show up?

2014-11-11 Thread Jose Fonseca
Is this the i915 gallium or classic driver? What does glxinfo show? Jose From: mesa-dev mesa-dev-boun...@lists.freedesktop.org on behalf of Steven Stewart-Gallus sstewartgallu...@mylangara.bc.ca Sent: 11 November 2014 23:45 To: Kenneth Graunke Cc:

[Mesa-dev] [Bug 86070] Host application crash on vmware fusion 7 in vmw_swc_flush

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86070 Sinclair Yeh s...@vmware.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Mesa-dev] [Bug 86070] Host application crash on vmware fusion 7 in vmw_swc_flush

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86070 --- Comment #1 from Sinclair Yeh s...@vmware.com --- From the description I assume the submitter is using mplayer. I've done the following steps and could not reproduce this issue: 1. download and build mplayer from http://www.mplayerhq.hu 2.

[Mesa-dev] [Bug 86070] Host application crash on vmware fusion 7 in vmw_swc_flush

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86070 --- Comment #2 from Nicholas Yue yue.nicho...@gmail.com --- Hi Sinclair, The application mplay (not mplayer) is from the Houdini suite of software by Side Effects http://www.sidefx.com/index.php?option=com_downloadtask=apprenticeItemid=208

[Mesa-dev] [Bug 86070] Host application crash on vmware fusion 7 in vmw_swc_flush

2014-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86070 --- Comment #3 from Nicholas Yue yue.nicho...@gmail.com --- I am using the most recent version of VMWare Fusion 7 on OS X Yosemite to host Ubuntu 12.04.5 x64 and it only provides Mesa3D at version 8.0.4 not the 10.4 you are testing with. Is

Re: [Mesa-dev] [PATCH] nvc0: remove unused nvc0_screen::mm_VRAM_fe0

2014-11-11 Thread Ilia Mirkin
LG. I had this same patch locally I think... I came up with it after I went looking at the various VRAM usage after you were asking questions about it. On Tue, Nov 11, 2014 at 11:59 PM, Alexandre Courbot gnu...@gmail.com wrote: Ping, how about this guy? On Mon, Oct 27, 2014 at 7:36 PM,

Re: [Mesa-dev] [PATCH] nvc0: remove unused nvc0_screen::mm_VRAM_fe0

2014-11-11 Thread Alexandre Courbot
On 11/12/2014 03:07 PM, Ilia Mirkin wrote: LG. I had this same patch locally I think... I came up with it after I went looking at the various VRAM usage after you were asking questions about it. Good, I'm dropping this version then, and assume yours will get merged soon. Thanks!