Re: [Mesa-dev] [PATCH v2 17/23] mesa: Add non-normalized formats support for ubyte packing functions

2014-12-02 Thread Samuel Iglesias Gonsálvez
On 01/12/14 20:14, Jason Ekstrand wrote: On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- src/mesa/main/format_pack.c.mako | 4 +++- 1 file

Re: [Mesa-dev] [PATCH v2 16/23] mesa: Add _mesa_pack_uint_rgba_row() format conversion function

2014-12-02 Thread Samuel Iglesias Gonsálvez
On 01/12/14 20:14, Jason Ekstrand wrote: On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com We will use this later on to handle uint conversion scenarios in a master convert function. v2: - Modify

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-02 Thread Iago Toral
On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote: On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: _BaseFormat is a GLenum (unsigned int) so testing if its value is greater than 0 to detect the cases where _mesa_base_tex_format returns -1 doesn't work.

Re: [Mesa-dev] [PATCH v2 08/23] mesa: Fix _mesa_swizzle_and_convert integer conversions to clamp properly

2014-12-02 Thread Samuel Iglesias Gonsálvez
On Tuesday, December 02, 2014 07:54:19 AM Samuel Iglesias Gonsálvez wrote: On Monday, December 01, 2014 10:16:35 AM Jason Ekstrand wrote: This looks much better. Two comments though. First, I think we need to tweak the float_to_uint function to clamp above. I don't know that it properly

Re: [Mesa-dev] [PATCH v2 16/23] mesa: Add _mesa_pack_uint_rgba_row() format conversion function

2014-12-02 Thread Iago Toral
On Mon, 2014-12-01 at 11:14 -0800, Jason Ekstrand wrote: On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com We will use this later on to handle uint conversion scenarios in a

Re: [Mesa-dev] [PATCH 04/10] mesa: Recompute LegalTypesMask if the GL API has changed

2014-12-02 Thread Iago Toral
On Mon, 2014-12-01 at 09:24 -0700, Brian Paul wrote: On 12/01/2014 06:04 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga ito...@igalia.com The current code computes ctx-Array.LegalTypesMask just once, however, computing this needs to consider ctx-API so we need to make sure that

Re: [Mesa-dev] [PATCH 00/10] Various fixes for dEQP failing tests

2014-12-02 Thread Eduardo Lima Mitev
On 12/01/2014 05:29 PM, Brian Paul wrote: On 12/01/2014 06:04 AM, Eduardo Lima Mitev wrote: This set of (unrelated) patches fixes over 230 tests from the dEQP test suite [1]. [...] The non-GLSL changes look good to me and are: Reviewed-by: Brian Paul bri...@vmware.com The GLSL changes

[Mesa-dev] [PATCH] i965: Move PSCDEPTH calculations from draw time to compile time.

2014-12-02 Thread Kenneth Graunke
The Pixel Shader Computed Depth Mode value is entirely based on the shader program, so we can easily do it at compile time. This avoids the if+switch on every 3DSTATE_WM (Gen7)/3DSTATE_PS_EXTRA (Gen8+) upload, and shares a bit more code. This also simplifies the PMA stall code, making it match

[Mesa-dev] [PATCH 1/4] i965: Make Gen4-5 and Gen8+ ALT checks use ctx-_Shader too.

2014-12-02 Thread Kenneth Graunke
Commit c0347705 changed the Gen6-7 code to use ctx-_Shader rather than ctx-Shader, but neglected to change the Gen4-5 or Gen8+ code. This might fix SSO related bugs, but ALT mode is only used for ARB programs, so if there's an actual problem, it's likely no one would run into it. Signed-off-by:

[Mesa-dev] [PATCH 2/4] i965: Store floating point mode choice in brw_stage_prog_data.

2014-12-02 Thread Kenneth Graunke
We use IEEE mode for GLSL programs, but need to use ALT mode for ARB programs so that 0^0 == 1. The choice is based entirely on the shader source language. Previously, our code to determine which mode we wanted was duplicated in 8 different places (VS and FS for Gen4-5, Gen6, Gen7, and Gen8).

[Mesa-dev] [PATCH 4/4] i965: Drop BRW_NEW_VERTEX_PROGRAM and _NEW_TRANSFORM from Gen4 VS state.

2014-12-02 Thread Kenneth Graunke
This simply looks wrong - I don't see any code that uses _NEW_TRANSFORM or BRW_NEW_VERTEX_PROGRAM. It looks like the intention was to duplicate the brw_curbe_offsets atom's flags, which computes brw-curbe.vs_start. This is unnecessary - we flag BRW_NEW_CURBE_OFFSETS whenever that field changes;

[Mesa-dev] [PATCH 3/4] i965: Drop BRW_NEW_VERTEX_PROGRAM from Gen7+ 3DSTATE_VS atoms.

2014-12-02 Thread Kenneth Graunke
We don't access brw-vertex_program or ctx-_Shader since the previous commit, so we don't need this dirty bit. I think it's still necessary on Gen6 because it still conflates constant uploading with unit state uploading. We can fix that later. Signed-off-by: Kenneth Graunke kenn...@whitecape.org

Re: [Mesa-dev] [PATCH 05/10] glsl: Don't allow gl_FragData[i], with i0 in GLES shaders

2014-12-02 Thread Tapani Pälli
On 12/01/2014 05:43 PM, Matteo Bruni wrote: 2014-12-01 14:04 GMT+01:00 Eduardo Lima Mitev el...@igalia.com: The OpenGL ES Shading Language specification describes the values that may be output by a fragment shader. These are gl_FragColor and gl_FragData[0]. Multiple render targets are not

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 3:05 AM, Iago Toral ito...@igalia.com wrote: On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote: On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: _BaseFormat is a GLenum (unsigned int) so testing if its value is greater than 0 to detect the

[Mesa-dev] [PATCH 01/13] mesa/meta: Don't free meta if it was never initialized

2014-12-02 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/common/meta.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 87532c1..e106899 100644 --- a/src/mesa/drivers/common/meta.c +++

[Mesa-dev] [PATCH 03/13] mesa/main: Don't go freeing texture data which was never allocated

2014-12-02 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/texstate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index e0f0852..6f7d781 100644 --- a/src/mesa/main/texstate.c +++

[Mesa-dev] [PATCH 13/13] mesa/main: Verify context creation on progress

2014-12-02 Thread Juha-Pekka Heikkila
Stop context creation if something failed. If something errored during context creation we'd segfault. Now will clean up and return error. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/shared.c | 63 ++ 1 file

Re: [Mesa-dev] [PATCH 05/10] glsl: Don't allow gl_FragData[i], with i0 in GLES shaders

2014-12-02 Thread Eduardo Lima Mitev
On 12/02/2014 01:31 PM, Tapani Pälli wrote: AFAICS this restriction is lifted in ES 3.0+ (e.g. see section 3.9.2 in the OpenGL ES 3.0 spec). Yep, it seems this check should be against earlier versions and only when not having extensions that allow MRT enabled (NV_draw_buffers). Hi, Yes,

Re: [Mesa-dev] [PATCH] i965: Sort array elements to increase chances of reusing buffer relocation

2014-12-02 Thread Neil Roberts
Ok, I've written a somewhat contrived test case here: https://github.com/bpeel/glthing/tree/time-attribs (Make sure to use the time-attribs branch) The example draws a 1000 single-pixel points each with a separate draw call. Each call uses a separate but identical VAO so that the driver will be

Re: [Mesa-dev] [PATCH 2/2] clover: clCompileProgram CL_INVALID_COMPILER_OPTIONS

2014-12-02 Thread Tom Stellard
On Mon, Nov 10, 2014 at 07:04:54PM +0200, Francisco Jerez wrote: EdB edb+m...@sigluy.net writes: clCompileProgram should return CL_INVALID_COMPILER_OPTIONS instead of CL_INVALID_BUILD_OPTIONS Looks good to me, Reviewed-by: Francisco Jerez curroje...@riseup.net I've pushed this, thanks!

Re: [Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak

2014-12-02 Thread Tom Stellard
On Mon, Dec 01, 2014 at 06:33:10PM -0500, Jan Vesely wrote: ping I've pushed this, thanks. -Tom On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- src/gallium/drivers/r600/r600_llvm.c | 1 + 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-12-02 Thread Tom Stellard
On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- moreover, the condition is never true now that clover appends dim info src/gallium/drivers/r600/evergreen_compute.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] draw: use the prim type from prim_info not emit in passthrough emit

2014-12-02 Thread Jose Fonseca
Series sort of sounds sensible but it's really outside my expertise. Zack would be a much better reviewer. This should be thoroughly tested too. Jose On 02/12/14 01:31, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com The prim assembler may change the prim type when

[Mesa-dev] [PATCH] mesa: fix height error check for 1D array textures

2014-12-02 Thread Brian Paul
height=0 is legal for 1D array textures (as height=0 is legal for 2D arrays). Fixes new piglit ext_texture_array-errors test. Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org --- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c

Re: [Mesa-dev] [PATCH] mesa: fix height error check for 1D array textures

2014-12-02 Thread Jose Fonseca
LGTM. On 02/12/14 16:43, Brian Paul wrote: height=0 is legal for 1D array textures (as height=0 is legal for I think you mean as depth=0 is legal for 2D arrays 2D arrays). Fixes new piglit ext_texture_array-errors test. Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH] mesa: fix height error check for 1D array textures

2014-12-02 Thread Brian Paul
On 12/02/2014 09:49 AM, Jose Fonseca wrote: LGTM. On 02/12/14 16:43, Brian Paul wrote: height=0 is legal for 1D array textures (as height=0 is legal for I think you mean as depth=0 is legal for 2D arrays Yes, thanks. -Brian 2D arrays). Fixes new piglit ext_texture_array-errors test.

Re: [Mesa-dev] [PATCH 1/7] mesa: Generate GL_INVALID_OPERATION when drawing w/o a VAO in core profile

2014-12-02 Thread Ian Romanick
On 11/20/2014 05:19 PM, Kenneth Graunke wrote: On Thursday, November 20, 2014 11:14:49 AM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com GL 3-ish versions of the spec are less clear that an error should be generated here, so Ken (and I during review) just missed it in

Re: [Mesa-dev] [PATCH v2 13/23] mesa: Autogenerate most of format_pack.c

2014-12-02 Thread Jason Ekstrand
On Mon, Dec 1, 2014 at 11:03 PM, Samuel Iglesias Gonsálvez sigles...@igalia.com wrote: On 01/12/14 20:00, Jason Ekstrand wrote: On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Jason Ekstrand jason.ekstr...@intel.com We were auto-generating it

Re: [Mesa-dev] [PATCH v2 16/23] mesa: Add _mesa_pack_uint_rgba_row() format conversion function

2014-12-02 Thread Jason Ekstrand
On Tue, Dec 2, 2014 at 2:32 AM, Iago Toral ito...@igalia.com wrote: On Mon, 2014-12-01 at 11:14 -0800, Jason Ekstrand wrote: On Mon, Dec 1, 2014 at 3:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com We will use

Re: [Mesa-dev] [PATCH v2 06/23] mesa: Fix incorrect assertion in init_teximage_fields_ms

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 8:24 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Tue, Dec 2, 2014 at 3:05 AM, Iago Toral ito...@igalia.com wrote: On Mon, 2014-12-01 at 13:25 -0500, Ilia Mirkin wrote: On Mon, Dec 1, 2014 at 6:04 AM, Iago Toral Quiroga ito...@igalia.com wrote: _BaseFormat is a

Re: [Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-12-02 Thread Ian Romanick
On 11/26/2014 06:09 PM, Dave Airlie wrote: Glamor is 4x faster on my ILK using glsl 130 at core text using x11perf -ftext. Ian started writing a spec for this extension a while back, which seems like most of the work, this patch seems to do enough, to advertise GLSL 1.30. Yeah... I started

Re: [Mesa-dev] [PATCH] i965: Sort array elements to increase chances of reusing buffer relocation

2014-12-02 Thread Ben Widawsky
On Tue, Dec 02, 2014 at 04:17:35PM +, Neil Roberts wrote: Ok, I've written a somewhat contrived test case here: https://github.com/bpeel/glthing/tree/time-attribs (Make sure to use the time-attribs branch) The example draws a 1000 single-pixel points each with a separate draw call.

Re: [Mesa-dev] [PATCH] i965: Move PSCDEPTH calculations from draw time to compile time.

2014-12-02 Thread Matt Turner
On Tue, Dec 2, 2014 at 3:50 AM, Kenneth Graunke kenn...@whitecape.org wrote: The Pixel Shader Computed Depth Mode value is entirely based on the shader program, so we can easily do it at compile time. This avoids the if+switch on every 3DSTATE_WM (Gen7)/3DSTATE_PS_EXTRA (Gen8+) upload, and

Re: [Mesa-dev] [PATCH] i965: Sort array elements to increase chances of reusing buffer relocation

2014-12-02 Thread Ian Romanick
On 12/02/2014 08:17 AM, Neil Roberts wrote: Ok, I've written a somewhat contrived test case here: https://github.com/bpeel/glthing/tree/time-attribs (Make sure to use the time-attribs branch) The example draws a 1000 single-pixel points each with a separate draw call. Each call uses a

[Mesa-dev] [Bug 86939] test_vf_float_conversions.cpp:63:12: error: expected primary-expression before ‘union’

2014-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86939 Bug ID: 86939 Summary: test_vf_float_conversions.cpp:63:12: error: expected primary-expression before ‘union’ Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH] i965: Sort array elements to increase chances of reusing buffer relocation

2014-12-02 Thread Ian Romanick
On 12/02/2014 08:17 AM, Neil Roberts wrote: Ok, I've written a somewhat contrived test case here: https://github.com/bpeel/glthing/tree/time-attribs (Make sure to use the time-attribs branch) The example draws a 1000 single-pixel points each with a separate draw call. Each call uses a

[Mesa-dev] [PATCH v2] i965: Sort array elements to increase chances of reusing buffer relocation

2014-12-02 Thread Neil Roberts
Neil wrote: It might be worth making a simpler hard-coded implementation of quicksort because calling qsort is probably not very sensible for such a small array and the function call overhead for each comparison is probably quite a bit. Ok, here is a v2 of the patch which has a simple custom

Re: [Mesa-dev] [PATCH 3/4] i965: Drop BRW_NEW_VERTEX_PROGRAM from Gen7+ 3DSTATE_VS atoms.

2014-12-02 Thread Matt Turner
On Tue, Dec 2, 2014 at 3:51 AM, Kenneth Graunke kenn...@whitecape.org wrote: We don't access brw-vertex_program or ctx-_Shader since the previous commit, so we don't need this dirty bit. I think it's still necessary on Gen6 because it still conflates constant uploading with unit state

[Mesa-dev] [Bug 86939] test_vf_float_conversions.cpp:63:12: error: expected primary-expression before ‘union’

2014-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86939 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 86939] test_vf_float_conversions.cpp:63:12: error: expected primary-expression before ‘union’

2014-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86939 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] [Patch v2] Mesa: Add support for GL_OES_texture_*float* extensions.

2014-12-02 Thread Ian Romanick
On 11/27/2014 10:56 AM, Kalyan Kondapally wrote: This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear. Support for these extensions need to be explicitly

[Mesa-dev] [PATCH] i965: Avoid union literal, for old gcc compatibility.

2014-12-02 Thread Matt Turner
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86939 --- src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp

Re: [Mesa-dev] [PATCH] i965: Avoid union literal, for old gcc compatibility.

2014-12-02 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 12/02/2014 11:24 AM, Matt Turner wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86939 --- src/mesa/drivers/dri/i965/test_vf_float_conversions.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/1] r600, llvm: Don't leak global symbol offsets

2014-12-02 Thread Jan Vesely
Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- You were right, this one was leaking too. src/gallium/drivers/r600/r600_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index 3a3ee3a..a928fb8 100644 ---

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-12-02 Thread Jan Vesely
On Tue, 2014-12-02 at 11:33 -0500, Tom Stellard wrote: On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- moreover, the condition is never true now that clover appends dim info

Re: [Mesa-dev] DRI3/Present fixes for Mesa 10.3+ (v2)

2014-12-02 Thread Mario Kleiner
A slightly updated and extended series of the dri3/present fixes for Mesa i sent last week. Patch 1 and 2 are same as before. Patch 3 now has signed off by Frank Binns and reviewed by Chris Wilson. Patch 4 and 5 are additional fixes. The last one makes INTEL_swap_events behave properly again when

[Mesa-dev] [PATCH 2/5] glx/dri3: Track separate (ust, msc) for PresentPixmap vs. PresentNotifyMsc

2014-12-02 Thread Mario Kleiner
Prevent calls to glXGetSyncValuesOML() and glXWaitForMscOML() from overwriting the (ust,msc) values of the last successfull swapbuffers call (PresentPixmapCompleteNotify event), as glXWaitForSbcOML() relies on those values corresponding to the most recent completed swap, not to whatever was last

[Mesa-dev] [PATCH 3/5] glx/dri3: Request non-vsynced Present for swapinterval zero. (v2)

2014-12-02 Thread Mario Kleiner
Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org v2: Add Frank Binns signed off by for his original earlier patch from April 2014, which is identical to this one, and Chris Wilsons reviewed tag from May

[Mesa-dev] [PATCH 5/5] glx: Handle out-of-sequence swap completion events correctly.

2014-12-02 Thread Mario Kleiner
The code for emitting INTEL_swap_events swap completion events needs to translate from 32-Bit sbc on the wire to 64-Bit sbc for the events and handle wraparound accordingly. It assumed that events would be sent by the server in the order their corresponding swap requests were emitted from the

[Mesa-dev] [PATCH 1/5] glx/dri3: Fix glXWaitForSbcOML() to handle targetSBC==0 correctly.

2014-12-02 Thread Mario Kleiner
targetSBC == 0 is a special case, which asks the function to block until all pending OpenGL bufferswap requests have completed. Currently the function just falls through for targetSBC == 0, returning bogus results. This breaks applications originally written and tested against DRI2 which also

[Mesa-dev] [PATCH 4/5] glx/dri3: Don't fail on glXSwapBuffersMscOML(dpy, window, 0, 0, 0)

2014-12-02 Thread Mario Kleiner
glXSwapBuffersMscOML() with target_msc=divisor=remainder=0 gets translated into target_msc=divisor=0 but remainder=1 by the mesa api. This is done for server DRI2 where there needs to be a way to tell the server-side DRI2ScheduleSwap implementation if a call to glXSwapBuffers() or

Re: [Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-12-02 Thread Chris Forbes
Ian, Dave My ILK is down at the moment, but I don't recall any problem with clip distances. All that work landed in mesa-10.0, and at the time passed all the relevant piglits (with 1.30 + EXT_gpu_shader4 hacked in for entrypoints). The Gen4-5 VS currently lowers all user clipping to clip

[Mesa-dev] [PATCH 1/1] clover: Use switch when creating kernel arguments

2014-12-02 Thread Jan Vesely
This way we get a warning when an enum value is not handled Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- src/gallium/state_trackers/clover/core/kernel.cpp | 45 ++- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

2014-12-02 Thread Jan Vesely
Mostly signed/unsigned comparison Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- src/gallium/state_trackers/xvmc/context.c | 6 +++--- src/gallium/state_trackers/xvmc/subpicture.c | 2 +- src/gallium/state_trackers/xvmc/xvmc_private.h | 4 ++-- 3 files changed, 6 insertions(+), 6

[Mesa-dev] [PATCH RESEND] nv50/ir: use unordered_set instead of list to keep track of var defs

2014-12-02 Thread Tobias Klausmann
The set of variable defs does not need to be ordered in any way, and removing/adding elements is a fairly common operation in various optimization passes. This shortens runtime of piglit test fp-long-alu to ~11s from ~22s No piglit regressions observed on nvc0! Signed-off-by: Tobias Klausmann

[Mesa-dev] [PATCH] mesa: Ensure stack is realigned on x86.

2014-12-02 Thread Jose Fonseca
From: José Fonseca jfons...@vmware.com Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but that is an assumption OpenGL drivers (or any dynamic library for that matter) can affort to make as there are many closed- and open- source application binaries out there that only

Re: [Mesa-dev] [Patch v3] Mesa: Add support for GL_OES_texture_*float* extensions.

2014-12-02 Thread Ian Romanick
On 11/28/2014 01:08 PM, Kalyan Kondapally wrote: This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear. If we are using GLES context and the driver has

Re: [Mesa-dev] [PATCH 4/4] i965: Drop BRW_NEW_VERTEX_PROGRAM and _NEW_TRANSFORM from Gen4 VS state.

2014-12-02 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: This simply looks wrong - I don't see any code that uses _NEW_TRANSFORM or BRW_NEW_VERTEX_PROGRAM. It looks like the intention was to duplicate the brw_curbe_offsets atom's flags, which computes brw-curbe.vs_start. This is unnecessary - we flag

Re: [Mesa-dev] [PATCH 01/10] mesa: Considers GL_DEPTH_STENCIL_ATTACHMENT a valid argument for FBO invalidation under GLES3

2014-12-02 Thread Ian Romanick
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: In OpenGL and OpenGL-Es 3+, GL_DEPTH_STENCIL_ATTACHMENT is a valid attachment point for the family of functions that invalidate a framebuffer object (e.g, glInvalidateFramebuffer, glInvalidateSubFramebuffer, etc). Currently, a

Re: [Mesa-dev] [PATCH 03/10] mesa: Returns zero samples when querying GL_NUM_SAMPLE_COUNTS when internal format is integer

2014-12-02 Thread Ian Romanick
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: In GLES3, multisampling is not supported for signed and unsigned integer internal formats. See https://www.khronos.org/opengles/sdk/docs/man3/docbook4/xhtml/glGetInternalformativ.xml. Fixes 19 dEQP tests under

Re: [Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-12-02 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 11/26/2014 06:09 PM, Dave Airlie wrote: Glamor is 4x faster on my ILK using glsl 130 at core text using x11perf -ftext. Ian started writing a spec for this extension a while back, which seems like most of the work, this patch seems to do enough,

Re: [Mesa-dev] [Patch v3] Mesa: Add support for GL_OES_texture_*float* extensions.

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 3:36 PM, Ian Romanick i...@freedesktop.org wrote: On 11/28/2014 01:08 PM, Kalyan Kondapally wrote: This patch adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear,

Re: [Mesa-dev] [PATCH 05/10] glsl: Don't allow gl_FragData[i], with i0 in GLES shaders

2014-12-02 Thread Ian Romanick
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: The OpenGL ES Shading Language specification describes the values that may be output by a fragment shader. These are gl_FragColor and gl_FragData[0]. Multiple render targets are not supported in GLES. Fixes dEQP test: *

Re: [Mesa-dev] [PATCH 06/10] glsl: invariant qualifier is not valid for shader inputs in GLSL ES 3.00

2014-12-02 Thread Ian Romanick
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com GLSL ES 3.00 spec, chapter 4.6.1 The Invariant Qualifier, Only variables output from a shader can be candidates for invariance. This includes user-defined output variables and the

Re: [Mesa-dev] [PATCH 06/10] glsl: invariant qualifier is not valid for shader inputs in GLSL ES 3.00

2014-12-02 Thread Ian Romanick
On 12/02/2014 12:54 PM, Ian Romanick wrote: On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com GLSL ES 3.00 spec, chapter 4.6.1 The Invariant Qualifier, Only variables output from a shader can be candidates for invariance. This

Re: [Mesa-dev] [PATCH 07/10] glsl: don't allow invariant qualifiers for interface blocks in GLSL ES

2014-12-02 Thread Ian Romanick
On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com From GLSL ES 3.0, chapter 4.3.7 Interface Blocks, page 38: GLSL ES 3.0 does not support interface blocks for shader inputs or outputs. and from GLSL ES 3.0, chapter 4.6.1 The invariant

Re: [Mesa-dev] [PATCH 09/10] main/glsles: return two minor digits for SHADING_LANGUAGE_VERSION

2014-12-02 Thread Ian Romanick
With Brian's suggested change to the commit message, this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com For OpenGL ES 3.0 spec, the minor number for SHADING_LANGUAGE_VERSION

Re: [Mesa-dev] [PATCH 08/10] glsl: A shader cannot redefine or overload built-in functions in GLSL ES 3.00

2014-12-02 Thread Ian Romanick
Oof. I'd really like to have Ken review this code. He's the expert in this area... On 12/01/2014 05:04 AM, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Create a new search function to look for matching built-in functions by name and use it for built-in

Re: [Mesa-dev] [PATCH 08/10] glsl: A shader cannot redefine or overload built-in functions in GLSL ES 3.00

2014-12-02 Thread Chris Forbes
It would be nice if this could be added to the existing logic for the interaction between builtins and app-provided overloads -- or do we need to fail earlier than that? - Chris On Tue, Dec 2, 2014 at 2:04 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH] mesa: Ensure stack is realigned on x86.

2014-12-02 Thread Brian Paul
On 12/02/2014 01:27 PM, Jose Fonseca wrote: From: José Fonseca jfons...@vmware.com Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but that is an assumption OpenGL drivers (or any dynamic library for that matter) can affort to make as there are many closed- and open-

[Mesa-dev] [PATCH 2/2] st/nine: Fix vertex declarations for non-standard (usage/index)

2014-12-02 Thread Axel Davy
Nine code to match vertex declaration to vs inputs was limiting the number of possible combinations. Some sm3 games have issues with that, because arbitrary (usage/index) can be used. This patch does the following changes to fix the problem: . Change the numbers given to (usage/index)

[Mesa-dev] [PATCH 1/2] st/nine: sm1_declusage_to_tgsi, do not restrict indices with TGSI_SEMANTIC_GENERIC

2014-12-02 Thread Axel Davy
With sm3, you can declare an input/output with an usage and an usage index. Nine code hardcodes the translation usage/index to a corresponding TGSI code. The translation was limited to a few usage/index combinations that were corresponding to most of the needs of games, but some games did not

[Mesa-dev] [PATCH 7/8] st/nine: Queries: always succeed for D3DQUERYTYPE_TIMESTAMP when flushing

2014-12-02 Thread Axel Davy
This is the behaviour that Wine tests Tested-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/nine/query9.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/nine/query9.c

[Mesa-dev] [PATCH 5/8] st/nine: Queries: Fix D3DISSUE_END behaviour.

2014-12-02 Thread Axel Davy
Issuing D3DISSUE_END should: . reset previous queries if possible . end the query Previous behaviour wasn't calling end_query for queries not needing D3DISSUE_BEGIN, no resetting previous queries. This fixes several applications not launching properly. Cc: 10.4 mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH 1/8] st/nine: Queries: remove dummy queries

2014-12-02 Thread Axel Davy
Applications are supposed to call CreateQuery with a NULL ppQuery to know if the query is supported. We supported that. However when ppQuery was not NULL, we were accepting to create the query and were creating a dummy query even when the query is not supported. Wine has different behaviour.

[Mesa-dev] [PATCH 3/8] st/nine: Queries: Use gallium caps to get if queries are supported. (v2)

2014-12-02 Thread Axel Davy
Some queries need the driver to advertise a cap to be supported. For example r300 doesn't support them. v2 (David): check also for PIPE_CAP_QUERY_PIPELINE_STATISTICS, fix wine tests on r300g Reviewed-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d...@ens.fr ---

[Mesa-dev] [PATCH 2/8] st/nine: Queries: Remove flush logic

2014-12-02 Thread Axel Davy
get_query_result flushes automatically, we don't need to flush. Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/nine/query9.c | 13 + src/gallium/state_trackers/nine/query9.h | 1 - 2 files changed, 5 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 4/8] st/nine: Queries: return S_FALSE instead of INVALIDCALL when in building query state

2014-12-02 Thread Axel Davy
It is the same behaviour as wine has. Reviewed-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/nine/query9.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/query9.c

[Mesa-dev] [PATCH 6/8] st/nine: Queries: allow app to call GetData without Issuing first

2014-12-02 Thread Axel Davy
Nine was allowing that behaviour, but was not filling the result. Tested-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/nine/query9.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 8/8] st/nine: Queries: Always return D3D_OK when issuing with D3DISSUE_BEGIN

2014-12-02 Thread Axel Davy
This is the behaviour that wine tests. Reviewed-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy axel.d...@ens.fr --- src/gallium/state_trackers/nine/query9.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/query9.c

Re: [Mesa-dev] [PATCH 1/4] i965: Make Gen4-5 and Gen8+ ALT checks use ctx-_Shader too.

2014-12-02 Thread Ian Romanick
On 12/02/2014 03:51 AM, Kenneth Graunke wrote: Commit c0347705 changed the Gen6-7 code to use ctx-_Shader rather than ctx-Shader, but neglected to change the Gen4-5 or Gen8+ code. This might fix SSO related bugs, but ALT mode is only used for ARB programs, so if there's an actual problem,

Re: [Mesa-dev] [PATCH 2/4] i965: Store floating point mode choice in brw_stage_prog_data.

2014-12-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 12/02/2014 03:51 AM, Kenneth Graunke wrote: We use IEEE mode for GLSL programs, but need to use ALT mode for ARB programs so that 0^0 == 1. The choice is based entirely on the shader source language. Previously, our code

Re: [Mesa-dev] [PATCH 3/8] st/nine: Queries: Use gallium caps to get if queries are supported. (v2)

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy axel.d...@ens.fr wrote: Some queries need the driver to advertise a cap to be supported. For example r300 doesn't support them. v2 (David): check also for PIPE_CAP_QUERY_PIPELINE_STATISTICS, fix wine tests on r300g Reviewed-by: David

Re: [Mesa-dev] [PATCH] mesa: Ensure stack is realigned on x86.

2014-12-02 Thread Jose Fonseca
On 02/12/14 21:10, Brian Paul wrote: On 12/02/2014 01:27 PM, Jose Fonseca wrote: From: José Fonseca jfons...@vmware.com Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but that is an assumption OpenGL drivers (or any dynamic library for that matter) can affort to make as

Re: [Mesa-dev] [PATCH 5/8] st/nine: Queries: Fix D3DISSUE_END behaviour.

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy axel.d...@ens.fr wrote: Issuing D3DISSUE_END should: . reset previous queries if possible . end the query Previous behaviour wasn't calling end_query for queries not needing D3DISSUE_BEGIN, no resetting noR resetting previous queries. This fixes

Re: [Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-12-02 Thread Ian Romanick
On 12/02/2014 12:51 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: On 11/26/2014 06:09 PM, Dave Airlie wrote: Glamor is 4x faster on my ILK using glsl 130 at core text using x11perf -ftext. Ian started writing a spec for this extension a while back, which seems like most

Re: [Mesa-dev] [PATCH 8/8] st/nine: Queries: Always return D3D_OK when issuing with D3DISSUE_BEGIN

2014-12-02 Thread Ilia Mirkin
With the very minor corrections I've mentioned earlier, series is Reviwed-by: Ilia Mirkin imir...@alum.mit.edu On Tue, Dec 2, 2014 at 4:12 PM, Axel Davy axel.d...@ens.fr wrote: This is the behaviour that wine tests. Reviewed-by: David Heidelberg da...@ixit.cz Signed-off-by: Axel Davy

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp, line 1455: Error: Badly formed expression.

2014-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86944 Bug ID: 86944 Summary: glsl_parser_extras.cpp, line 1455: Error: Badly formed expression. Product: Mesa Version: git Hardware: x86 (IA32) OS: Solaris

Re: [Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-12-02 Thread Dave Airlie
On 3 December 2014 at 07:32, Ian Romanick i...@freedesktop.org wrote: On 12/02/2014 12:51 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: On 11/26/2014 06:09 PM, Dave Airlie wrote: Glamor is 4x faster on my ILK using glsl 130 at core text using x11perf -ftext. Ian started

Re: [Mesa-dev] [PATCH 1/7] mesa: Generate GL_INVALID_OPERATION when drawing w/o a VAO in core profile

2014-12-02 Thread Kenneth Graunke
On Tuesday, December 02, 2014 09:26:38 AM Ian Romanick wrote: On 11/20/2014 05:19 PM, Kenneth Graunke wrote: On Thursday, November 20, 2014 11:14:49 AM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com GL 3-ish versions of the spec are less clear that an error should be

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp, line 1455: Error: Badly formed expression.

2014-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86944 --- Comment #1 from Matt Turner matts...@gmail.com --- (In reply to Vinson Lee from comment #0) Build error with Oracle Studio. [snip useless warnings] ../../src/glsl/glsl_parser_extras.cpp, line 1455: Error: Badly formed expression. I'm

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp, line 1455: Error: Badly formed expression.

2014-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86944 --- Comment #2 from Matt Turner matts...@gmail.com --- Oh, I bet there's something wrong with the macro. I'd try removing the typeof(*v) cast in src/util/u_atomic.h around line 173. If that fixes it, we should remove those casts from

[Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ben Widawsky
This patch implements ARB_pipeline_statistics_query. This addition to GL does not add a new API. Instead, it adds new tokens to the existing query APIs. The work to hook up the new tokens is trivial due to it's similarity to the previous work done for the query APIs. I've implemented all the new

Re: [Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-12-02 Thread Roland Scheidegger
Am 02.12.2014 um 21:51 schrieb Eric Anholt: Ian Romanick i...@freedesktop.org writes: On 11/26/2014 06:09 PM, Dave Airlie wrote: Glamor is 4x faster on my ILK using glsl 130 at core text using x11perf -ftext. Ian started writing a spec for this extension a while back, which seems like

[Mesa-dev] [PATCH] llvmpipe: decrease MAX_SCENES from 2 to 1

2014-12-02 Thread sroland
From: Roland Scheidegger srol...@vmware.com Multiple scenes per context are meant to be used so a new scene can be built while another one is processed in rasterization. However, quite surprisingly, this does not actually work (and according to git log, possibly never did, though maybe it did at

Re: [Mesa-dev] [PATCH 1/1] r600, llvm: Don't leak global symbol offsets

2014-12-02 Thread Tom Stellard
On Tue, Dec 02, 2014 at 02:47:53PM -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu I've pushed this, thanks! -Tom --- You were right, this one was leaking too. src/gallium/drivers/r600/r600_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH] [RFC] MESA_shading_language_130: is this it?

2014-12-02 Thread Dave Airlie
On 3 December 2014 at 08:46, Dave Airlie airl...@gmail.com wrote: On 3 December 2014 at 07:32, Ian Romanick i...@freedesktop.org wrote: On 12/02/2014 12:51 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: On 11/26/2014 06:09 PM, Dave Airlie wrote: Glamor is 4x faster on my

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: This patch implements ARB_pipeline_statistics_query. This addition to GL does not add a new API. Instead, it adds new tokens to the existing query APIs. The work to hook up the new tokens is trivial due to it's

[Mesa-dev] [Bug 86690] glmark2-es2-wayland shortly freezes on some frames with egl_dri2 backend (Nouveau/GK20A)

2014-12-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86690 --- Comment #7 from Alexandre Courbot gnu...@gmail.com --- Some more input about this oddity. We are really waiting for fences here. During the freezes I can see the EGL client looping in nouveau_fence_wait(), and displaying the fence sequence

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ben Widawsky
On Tue, Dec 02, 2014 at 10:47:37PM -0500, Ilia Mirkin wrote: On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: This patch implements ARB_pipeline_statistics_query. This addition to GL does not add a new API. Instead, it adds new tokens to the existing query

  1   2   >