[Mesa-dev] [PATCH] mesa: Adds check for integer internal formal and num samples in glRenderbufferStorageMultisample

2014-12-15 Thread Eduardo Lima Mitev
Per GLES3 specification, section 4.4 Framebuffer objects page 198, "If internalformat is a signed or unsigned integer format and samples is greater than zero, then the error INVALID_OPERATION is generated.". Fixes 1 dEQP test: * dEQP-GLES3.functional.negative_api.buffer.renderbuffer_storage_multis

Re: [Mesa-dev] Finishing make distcheck

2014-12-15 Thread Emil Velikov
On 11/12/14 16:46, Alan Coopersmith wrote: > On 12/11/14 01:02 AM, Emil Velikov wrote: >> * Don't ship anything but a tar.xz tarball. >> Linux, *BSD and WindowsXP+ have/ship programs that support the format >> for more than 5 years. > > Solaris 11 has been shipping xz support for the past 3 year

Re: [Mesa-dev] Finishing make distcheck

2014-12-15 Thread Emil Velikov
On 12/12/14 22:41, Julien Cristau wrote: > On Thu, Dec 11, 2014 at 09:02:11 +, Emil Velikov wrote: > >> * Don't ship anything but a tar.xz tarball. >> Linux, *BSD and WindowsXP+ have/ship programs that support the format >> for more than 5 years. >> > FWIW I'd appreciate if you kept the tar.g

[Mesa-dev] [PATCH v2] mesa: Check first that draw buffers are valid for glDrawBuffers on GLES3

2014-12-15 Thread Eduardo Lima Mitev
Section 4.2 (Whole Framebuffer Operations) of the OpenGL 3.0 specification says "Each buffer listed in bufs must be BACK, NONE, or one of the values from table 4.3 (NONE, COLOR_ATTACHMENTi)". This patch adds this check before previous other, more complex validation steps. Fixes 1 dEQP test: dEQP-

Re: [Mesa-dev] Finishing make distcheck

2014-12-15 Thread Julien Cristau
On Mon, Dec 15, 2014 at 10:46:25 +, Emil Velikov wrote: > On 12/12/14 22:41, Julien Cristau wrote: > > On Thu, Dec 11, 2014 at 09:02:11 +, Emil Velikov wrote: > > > >> * Don't ship anything but a tar.xz tarball. > >> Linux, *BSD and WindowsXP+ have/ship programs that support the format >

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-15 Thread Iago Toral
On Fri, 2014-12-12 at 11:36 -0800, Jason Ekstrand wrote: > > > On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga > wrote: > For glReadPixels with a Luminance destination format we > compute luminance > values from RGBA as L=R+G+B. This, however, requires ad-hoc >

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-15 Thread Emil Velikov
On 14/12/14 17:19, Matt Turner wrote: > On Sun, Dec 14, 2014 at 7:06 AM, Emil Velikov > wrote: >> On 11/12/14 21:51, Carl Worth wrote: >>> From: Kristian Høgsberg >>> >>> The upcoming shader cache uses the SHA-1 algorithm for cryptographic >>> naming. These new mesa_sha1 functions are implemente

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-15 Thread Eero Tamminen
Hi, On 12/15/2014 07:46 AM, Keith Packard wrote: Mario Kleiner writes: Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Hrm. I'd love for this to be controlled by the GLX_EXT_swap_control_tear extension, but that one uses negative interval values to

Re: [Mesa-dev] [PATCH 00/16] More fixes for dEQP failing tests

2014-12-15 Thread Emil Velikov
On 11/12/14 22:34, Eduardo Lima Mitev wrote: > Hello, > > This is the second series of patches fixing over 90 (unrelated) dEQP failing > tests. > Again, the test failures were gathered on i965 (gen8) against 10.3.3, but > there are several driver and version agnostic fixes. > > A GIT tree with

Re: [Mesa-dev] [PATCH v3 18/24] mesa/format_pack: Add _mesa_pack_int_rgba_row()

2014-12-15 Thread Samuel Iglesias Gonsálvez
On Thursday, December 11, 2014 11:43:26 AM Jason Ekstrand wrote: > On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga > > wrote: > > From: Samuel Iglesias Gonsalvez > > > > This will be used to unify code in pack.c. > > > > v2: > > - Modify pack_int_*() function generator to use c.datatype() a

Re: [Mesa-dev] [PATCH v3 17/24] mesa: Add non-normalized formats support for ubyte packing functions

2014-12-15 Thread Samuel Iglesias Gonsálvez
On Thursday, December 11, 2014 11:54:39 AM Jason Ekstrand wrote: > Let's squash this in to patch 14. > OK. Sam > On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga > > wrote: > > From: Samuel Iglesias Gonsalvez > > > > v2: > > - Add clamping for non-normalized integer formats in pack_ubyte*

Re: [Mesa-dev] [PATCH v3 14/24] mesa: Autogenerate most of format_pack.c

2014-12-15 Thread Samuel Iglesias Gonsálvez
On Thursday, December 11, 2014 11:55:10 AM Jason Ekstrand wrote: > On Tue, Dec 9, 2014 at 4:06 AM, Iago Toral Quiroga > wrote: > > [snip] > > > new file mode 100644 > > index 000..5f6809e > > --- /dev/null > > +++ b/src/mesa/main/format_pack.py > > @@ -0,0 +1,907 @@ > > +#!/usr/bin/env pytho

Re: [Mesa-dev] [PATCH v3 13/24] configure: require python mako module

2014-12-15 Thread Samuel Iglesias Gonsálvez
On Friday, December 12, 2014 08:59:26 AM Matt Turner wrote: > On Tue, Dec 9, 2014 at 4:06 AM, Iago Toral Quiroga wrote: > > diff --git a/m4/ax_check_python_mako_module.m4 > > b/m4/ax_check_python_mako_module.m4 new file mode 100644 > > index 000..f289f26 > > --- /dev/null > > +++ b/m4/ax_chec

Re: [Mesa-dev] [PATCH v3 08/24] mesa: Fix _mesa_swizzle_and_convert integer conversions to clamp properly

2014-12-15 Thread Samuel Iglesias Gonsálvez
On Thursday, December 11, 2014 12:03:19 PM Jason Ekstrand wrote: > I may have brought this up before (I'm starting to not remember things) but > shouldn't we also be clamping float-to-integer as well? Yes, I will do that together with deleting patch 24 as we need a similar function. Sam > --Jas

Re: [Mesa-dev] [PATCH 05/16] i965: Fix bitcast operations with negate

2014-12-15 Thread Iago Toral
On Fri, 2014-12-12 at 09:36 -0800, Matt Turner wrote: > On Thu, Dec 11, 2014 at 2:34 PM, Eduardo Lima Mitev wrote: > > From: Iago Toral Quiroga > > > > For code such as this in a vertex or fragment shader: > > > > uniform float in0; > > flat out float out0; > > ... > > out0 = ceil(in0) > > > > We

Re: [Mesa-dev] [PATCH 00/16] More fixes for dEQP failing tests

2014-12-15 Thread Eduardo Lima Mitev
On 12/15/2014 12:21 PM, Emil Velikov wrote: > > Above you've mentioned "test failures were gathered ... against 10.3.3", > which brings the question: > Should we include those in either one of the 10.3 and 10.4 stable > branches ? Or are they so insignificant/trivial that we don't expect > (m)any

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 83463, which changed state. Bug 83463 Summary: [swrast] piglit glsl-vs-clamp-1 regression https://bugs.freedesktop.org/show_bug.cgi?id=83463 What|Removed |Added -

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-15 Thread Francisco Jerez
Emil Velikov writes: > On 11/12/14 21:51, Carl Worth wrote: >> From: Kristian Høgsberg >> >> The upcoming shader cache uses the SHA-1 algorithm for cryptographic >> naming. These new mesa_sha1 functions are implemented with the nettle >> library. >> --- >> >> This patch is another in support o

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-15 Thread Neil Roberts
If we're looking for something to drop in to Mesa to avoid a dependency maybe we could look at simpler hashing algorithms too. For the shader cache presumably we don't care about the hash being cryptographically secure, just that it is unlikely to *accidentally* make a hash collision. I think it wo

Re: [Mesa-dev] [PATCH 03/16] mesa: Clamps the stencil value masks to GLint when queried

2014-12-15 Thread Eduardo Lima Mitev
On 12/12/2014 03:18 AM, Ian Romanick wrote: > On 12/11/2014 02:34 PM, Eduardo Lima Mitev wrote: >> Stencil value masks values (ctx->Stencil.ValueMask[]) stores GLuint values >> which are initialized with max unsigned integer (~0u). When these values >> are queried by glGet* (GL_STENCIL_VALUE_MASK o

Re: [Mesa-dev] [PATCH 5/5] i965/query: Cache whether the batch references the query BO.

2014-12-15 Thread Eero Tamminen
Hi, On 12/13/2014 09:15 AM, Kenneth Graunke wrote: Chris Wilson noted that repeated calls to CheckQuery() would call drm_intel_bo_references(brw->batch.bo, query->bo) on each invocation, which is expensive. Once we've flushed, we know that future batches won't reference query->bo, so there's no

[Mesa-dev] [PATCH v2] mesa: Initializes the stencil value masks to 0xFF instead of ~0u

2014-12-15 Thread Eduardo Lima Mitev
4.1.4 Stencil Test section of the GLES3 spec says: "In the initial state, [...] the front and back stencil mask are both set to the value 2 s − 1, where s is greater than or equal to the number of bits in the deepest stencil buffer* supported by the GL implementation." Since the maximum supported

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-15 Thread Matt Turner
On Mon, Dec 15, 2014 at 3:15 AM, Emil Velikov wrote: > On 14/12/14 17:19, Matt Turner wrote: >> On Sun, Dec 14, 2014 at 7:06 AM, Emil Velikov >> wrote: >>> On 11/12/14 21:51, Carl Worth wrote: From: Kristian Høgsberg The upcoming shader cache uses the SHA-1 algorithm for cryptogr

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-15 Thread Jason Ekstrand
On Mon, Dec 15, 2014 at 3:12 AM, Iago Toral wrote: > > On Fri, 2014-12-12 at 11:36 -0800, Jason Ekstrand wrote: > > > > > > On Tue, Dec 9, 2014 at 4:07 AM, Iago Toral Quiroga > > wrote: > > For glReadPixels with a Luminance destination format we > > compute luminance > > v

Re: [Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

2014-12-15 Thread Matt Turner
On Fri, Dec 12, 2014 at 8:19 AM, Andres Gomez wrote: > We were asuming, when constructing a new brw_reg struct, that the Typo: assuming > negate and abs register modifiers would not be present by default in > the new register. > > Now, we force explicitly setting these values when constructing a

Re: [Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

2014-12-15 Thread Matt Turner
On Mon, Dec 15, 2014 at 11:03 AM, Matt Turner wrote: > Reviewed-by: Matt Turner > Cc: "10.4 10.3" Oh, I suppose I need to commit this and the piglit test? Just confirm and I'll do it. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lis

Re: [Mesa-dev] [PATCH] i965/brw_reg: struct constructor now needs explicit negate and abs values.

2014-12-15 Thread Andres Gomez
On Mon, 2014-12-15 at 11:24 -0800, Matt Turner wrote: > On Mon, Dec 15, 2014 at 11:03 AM, Matt Turner wrote: > > Reviewed-by: Matt Turner > > Cc: "10.4 10.3" > > Oh, I suppose I need to commit this and the piglit test? Just confirm > and I'll do it. Yes, please, I don't have commit rights (yet

Re: [Mesa-dev] [PATCH v2] mesa: Initializes the stencil value masks to 0xFF instead of ~0u

2014-12-15 Thread Ian Romanick
On 12/15/2014 08:04 AM, Eduardo Lima Mitev wrote: > 4.1.4 Stencil Test section of the GLES3 spec says: "In the initial state, > [...] the front and back stencil mask are both set to the value 2 s − 1, > where s is greater than or equal to the number of bits in the deepest > stencil buffer* supporte

Re: [Mesa-dev] [RFC 6/8] mesa: remove support for GCC older than 4.1.0

2014-12-15 Thread Ian Romanick
On 12/13/2014 02:09 AM, Timothy Arceri wrote: > On Fri, 2014-12-12 at 07:01 -0600, kallisti5 wrote: >> On 2014-12-12 05:46, Timothy Arceri wrote: >>> Signed-off-by: Timothy Arceri >>> --- >>> src/mesa/main/compiler.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/s

Re: [Mesa-dev] [PATCH] glsl: Add gl_MaxViewports to available builtin constants

2014-12-15 Thread Ian Romanick
On 12/14/2014 11:47 AM, Maxence Le Doré wrote: > Hi Matt, > > To be sure to not missing something, I used a simple vertex shader I > have there and had > the following line in : > > int a = gl_MaxDrawBuffers; > > At runtime, everything was ok, and GLSL compiler didn't complain about > anything.

Re: [Mesa-dev] [PATCH] glsl: Add gl_MaxViewports to available builtin constants

2014-12-15 Thread Matt Turner
On Sun, Dec 14, 2014 at 11:47 AM, Maxence Le Doré wrote: > Hi Matt, > > To be sure to not missing something, I used a simple vertex shader I have > there and had > the following line in : > > int a = gl_MaxDrawBuffers; > > At runtime, everything was ok, and GLSL compiler didn't complain about > an

[Mesa-dev] [Bug 87276] u_atomic_test.c:108:1: error: implicit declaration of function 'test_atomic_cmpxchg_int16_t'

2014-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87276 Vinson Lee changed: What|Removed |Added Keywords||bisected --- Comment #1 from Vinson Lee --

[Mesa-dev] [PATCH 1/2] i965: remove commented out code

2014-12-15 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_fp.cpp b/src/mesa/drivers/dri/i965/brw_fs_fp.cpp index 6348bc1..bead05a 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_fp.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_fp.

[Mesa-dev] [PATCH 2/2] glsl: remove commented out code

2014-12-15 Thread Timothy Arceri
MaxGeometryOutputComponents is used as the value for gl_MaxGeometryVaryingComponents --- src/glsl/main.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index 91e457a..ccac839 100644 --- a/src/glsl/main.cpp +++ b/src/glsl/main.cpp @@ -182,8 +182,6 @@ in

Re: [Mesa-dev] [PATCH 2/2] glsl: remove commented out code

2014-12-15 Thread Matt Turner
Feels silly to "review" these, so Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 87276] u_atomic_test.c:108:1: error: implicit declaration of function 'test_atomic_cmpxchg_int16_t'

2014-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87276 --- Comment #2 from José Fonseca --- hmm.. It looks like NetBSD has some sort of weird defines like #define int32_t __int32_t which is making the u_atomic_test.c macro magic go nuts. Not sure what's the best way of fixing this. I feel temp

Re: [Mesa-dev] [PATCH] glx: Fix image size computation for EXT_texture_integer

2014-12-15 Thread Adam Jackson
On Fri, 2014-12-12 at 13:25 -0800, Ian Romanick wrote: > Looking at src/glx/glxextensions.c (the known_glx_extensions array > specifically), I don't think we support GL_EXT_texture_integer on the > client side for indirect rendering. So... do we actually need this patch? Technically no? But pigl

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-15 Thread Emil Velikov
On 15/12/14 14:16, Francisco Jerez wrote: > Emil Velikov writes: > >> On 11/12/14 21:51, Carl Worth wrote: >>> From: Kristian Høgsberg >>> >>> The upcoming shader cache uses the SHA-1 algorithm for cryptographic >>> naming. These new mesa_sha1 functions are implemented with the nettle >>> librar

Re: [Mesa-dev] [PATCH 5/5] i965/query: Cache whether the batch references the query BO.

2014-12-15 Thread Ian Romanick
On 12/14/2014 04:39 PM, Ben Widawsky wrote: > On Fri, Dec 12, 2014 at 11:15:42PM -0800, Kenneth Graunke wrote: >> Chris Wilson noted that repeated calls to CheckQuery() would call >> drm_intel_bo_references(brw->batch.bo, query->bo) on each invocation, >> which is expensive. Once we've flushed, we

Re: [Mesa-dev] [PATCH 1/5] i965/query: Set Ready flag in gen6_queryobj_get_results().

2014-12-15 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick On 12/12/2014 11:15 PM, Kenneth Graunke wrote: > q->Ready means that the results are in, and core Mesa is free to return > them to the application. gen6_queryobj_get_results() is a natural place > to set that flag; doing so means callers don't have to. > > T

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-15 Thread Emil Velikov
On 15/12/14 17:19, Matt Turner wrote: > On Mon, Dec 15, 2014 at 3:15 AM, Emil Velikov > wrote: >> On 14/12/14 17:19, Matt Turner wrote: >>> On Sun, Dec 14, 2014 at 7:06 AM, Emil Velikov >>> wrote: On 11/12/14 21:51, Carl Worth wrote: > From: Kristian Høgsberg > > The upcoming

Re: [Mesa-dev] [PATCH 5/5] i965/query: Cache whether the batch references the query BO.

2014-12-15 Thread Ben Widawsky
On Mon, Dec 15, 2014 at 01:28:52PM -0800, Ian Romanick wrote: > On 12/14/2014 04:39 PM, Ben Widawsky wrote: > > On Fri, Dec 12, 2014 at 11:15:42PM -0800, Kenneth Graunke wrote: > >> Chris Wilson noted that repeated calls to CheckQuery() would call > >> drm_intel_bo_references(brw->batch.bo, query->

Re: [Mesa-dev] [PATCH 5/5] i965/query: Cache whether the batch references the query BO.

2014-12-15 Thread Kenneth Graunke
On Monday, December 15, 2014 01:28:52 PM Ian Romanick wrote: > On 12/14/2014 04:39 PM, Ben Widawsky wrote: > > On Fri, Dec 12, 2014 at 11:15:42PM -0800, Kenneth Graunke wrote: > >> Chris Wilson noted that repeated calls to CheckQuery() would call > >> drm_intel_bo_references(brw->batch.bo, query->b

Re: [Mesa-dev] [PATCH 5/5] i965/query: Cache whether the batch references the query BO.

2014-12-15 Thread Kenneth Graunke
On Monday, December 15, 2014 01:38:47 PM Ben Widawsky wrote: > On Mon, Dec 15, 2014 at 01:28:52PM -0800, Ian Romanick wrote: > > On 12/14/2014 04:39 PM, Ben Widawsky wrote: > > > On Fri, Dec 12, 2014 at 11:15:42PM -0800, Kenneth Graunke wrote: > > >> Chris Wilson noted that repeated calls to CheckQ

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp", line 1455: Error: Badly formed expression.

2014-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86944 --- Comment #6 from Vinson Lee --- 6df72e970c0e2794a5651f7141528baa51c0c491 is the first bad commit commit 6df72e970c0e2794a5651f7141528baa51c0c491 Author: Matt Turner Date: Fri Nov 21 16:33:40 2014 -0800 util: Make u_atomic.h typeless.

Re: [Mesa-dev] r600/sb loop issue

2014-12-15 Thread Vadim Girlin
On 12/12/2014 05:28 PM, Alex Deucher wrote: On Wed, Dec 10, 2014 at 6:50 AM, Vadim Girlin wrote: On 12/09/2014 07:39 AM, Vadim Girlin wrote: On 12/09/2014 05:18 AM, Dave Airlie wrote: On 8 December 2014 at 20:41, Vadim Girlin wrote: On 12/06/2014 07:13 AM, Vadim Girlin wrote: On 12/04

Re: [Mesa-dev] r600/sb loop issue

2014-12-15 Thread Dave Airlie
>>> >>> >>> New patch is attached, the only difference is in the sb_sched.cpp (it >>> disables copy coalescing for some "unsafe" cases, so it may leave more >>> MOVs >>> than previously, but I don't think there will be any noticeable effect on >>> performance). >>> >>> So far I don't see any proble

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Emil Velikov changed: What|Removed |Added Depends on||85529 -- You are receiving this mail bec

Re: [Mesa-dev] r600/sb loop issue

2014-12-15 Thread Vadim Girlin
On 12/16/2014 01:30 AM, Dave Airlie wrote: New patch is attached, the only difference is in the sb_sched.cpp (it disables copy coalescing for some "unsafe" cases, so it may leave more MOVs than previously, but I don't think there will be any noticeable effect on performance). So far I don't se

[Mesa-dev] [PATCH] glsl: Add unit tests for blob.c

2014-12-15 Thread Carl Worth
In addition to exercising all of the functions in blob.h, this includes a stress test that forces some reallocing, and also tests to verify the alignment and overrun-detection code in blob.c. --- src/glsl/Makefile.am | 7 + src/glsl/tests/.gitignore | 1 + src/glsl/tests/blob_test.c | 3

[Mesa-dev] [PATCH] radeon: fix r600/7 fmask pitch

2014-12-15 Thread Dave Airlie
From: Dave Airlie libdrm patch: but mesa seems more suited to discussion. According to a tcore statement, the fmask needs to share pitch with the color surface, and since we pass that color surface pitch in already, we should use it if the one we calculate is less. Now I've no idea if this appl

[Mesa-dev] [PATCH 04/11] mesa: move #include of mtypes.h outside __cplusplus check

2014-12-15 Thread Brian Paul
--- src/mesa/main/errors.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/errors.h b/src/mesa/main/errors.h index 89d4d58..0c521c0 100644 --- a/src/mesa/main/errors.h +++ b/src/mesa/main/errors.h @@ -38,14 +38,13 @@ #include "compiler.h" #include "glheader.

[Mesa-dev] [PATCH 06/11] st/mesa: add extern "C" to st_program.h

2014-12-15 Thread Brian Paul
--- src/mesa/state_tracker/st_program.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/state_tracker/st_program.h b/src/mesa/state_tracker/st_program.h index cf1b40a..870d0d5 100644 --- a/src/mesa/state_tracker/st_program.h +++ b/src/mesa/state_tracker/st_program.h @@ -41,6

[Mesa-dev] [PATCH 03/11] program: add #ifndef SAMPLER_H wrapper

2014-12-15 Thread Brian Paul
--- src/mesa/program/sampler.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/program/sampler.h b/src/mesa/program/sampler.h index 8b7c3b6..61c7f58 100644 --- a/src/mesa/program/sampler.h +++ b/src/mesa/program/sampler.h @@ -23,6 +23,10 @@ * DEALINGS IN THE SOFTWARE. */

[Mesa-dev] [PATCH 05/11] main: remove extern C around #includes in ff_fragment_shader.cpp

2014-12-15 Thread Brian Paul
--- src/mesa/main/ff_fragment_shader.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 5591d57..bc6fdbd 100644 --- a/src/mesa/main/ff_fragment_shader.cpp +++ b/src/mesa/main/ff_fragment

[Mesa-dev] [PATCH 07/11] st/mesa: add extern "C" to st_context.h

2014-12-15 Thread Brian Paul
--- src/mesa/state_tracker/st_context.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/state_tracker/st_context.h b/src/mesa/state_tracker/st_context.h index 15f9df4..20d5678 100644 --- a/src/mesa/state_tracker/st_context.h +++ b/src/mesa/state_tracker/st_context.h @@ -3

[Mesa-dev] [PATCH 10/11] program: remove extern "C" usage in sampler.cpp

2014-12-15 Thread Brian Paul
--- src/mesa/program/sampler.cpp | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mesa/program/sampler.cpp b/src/mesa/program/sampler.cpp index 29a5408..f8584c9 100644 --- a/src/mesa/program/sampler.cpp +++ b/src/mesa/program/sampler.cpp @@ -27,15 +27,14 @@ #includ

[Mesa-dev] [PATCH 11/11] st/mesa: remove extern "C" around #includes in st_glsl_to_tgsi.cpp

2014-12-15 Thread Brian Paul
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 80dd102..e1015fe 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++ b/src

[Mesa-dev] [PATCH 01/11] mesa: put extern "C" in header files

2014-12-15 Thread Brian Paul
--- src/mesa/main/enums.h | 11 +++ src/mesa/main/samplerobj.h| 9 + src/mesa/main/texenvprogram.h | 11 +++ src/mesa/main/texobj.h| 10 ++ 4 files changed, 41 insertions(+) diff --git a/src/mesa/main/enums.h b/src/mesa/main/enums.h index 36c05

[Mesa-dev] [PATCH 02/11] mesa: put extern "C" in src/program/*h header files

2014-12-15 Thread Brian Paul
--- src/mesa/program/prog_cache.h| 11 +++ src/mesa/program/prog_optimize.h | 11 +++ src/mesa/program/prog_print.h| 11 +++ src/mesa/program/programopt.h| 10 ++ 4 files changed, 43 insertions(+) diff --git a/src/mesa/program/prog_cache.h b/src/mesa/pr

[Mesa-dev] [PATCH 08/11] glsl: remove extern "C" around #includes

2014-12-15 Thread Brian Paul
--- src/glsl/glsl_parser_extras.cpp | 3 --- src/glsl/glsl_types.cpp | 3 +-- src/glsl/linker.cpp | 3 +-- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index dd02a80..27e2eaf3 100644 --- a/src/g

[Mesa-dev] [PATCH 09/11] program: remove extern "C" around #includes

2014-12-15 Thread Brian Paul
--- src/mesa/program/ir_to_mesa.cpp | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 5196545..ce3af31 100644 --- a/src/mesa/program/ir_to_mesa.cpp +++ b/src/mesa/program/ir_to_mesa.cpp @@ -43,19 +43,1

[Mesa-dev] [PATCH 02/41] main: Created a standard function that looks up a texture object by its ID and throws INVALID_OPERATION if the ID isn't in the hash table.

2014-12-15 Thread Laura Ekstrand
Most ARB_DIRECT_STATE_ACCESS functions take an object's ID and use it to look up the object in its hash table. If the user passes a fake object ID (ie. a non-generated name), the implementation should throw INVALID_OPERATION. This is a convenience function for texture objects. --- src/mesa/main/t

[Mesa-dev] [PATCH 00/41] ARB_direct_state_access texture functions

2014-12-15 Thread Laura Ekstrand
This implements all of the texture functions for ARB_direct_state_access, with the exception of glTextureBufferRange. There is an outstanding bug on the specification for glTextureBufferRange. Fortunately, glTextureBufferRange shares its implementation with glTextureBuffer and will be trivial t

[Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2014-12-15 Thread Laura Ekstrand
main: Added ARB_direct_state_access to extensions.c as dummy_false. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 11 +++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 6 +- src/mesa/main/extensions.c

[Mesa-dev] [PATCH 08/41] main: Renamed _mesa_get_compressed_teximage to _mesa_GetCompressedTexImage_sw.

2014-12-15 Thread Laura Ekstrand
This reflects the new naming convention for software fallbacks. To avoid confusion with ARB_DIRECT_STATE_ACCESS backend functions, software fallbacks now have the form _mesa_[Driver function name]_sw. --- src/mesa/drivers/common/driverfuncs.c | 2 +- src/mesa/main/texgetimage.c| 6 ++

[Mesa-dev] [PATCH 05/41] main: Moved _mesa_get_current_tex_object from teximage.c to texobj.c.

2014-12-15 Thread Laura Ekstrand
--- src/mesa/main/teximage.c | 81 src/mesa/main/teximage.h | 4 --- src/mesa/main/texobj.c | 81 src/mesa/main/texobj.h | 3 ++ 4 files changed, 84 insertions(+), 85 deletions(-) diff --git a/

[Mesa-dev] [PATCH 07/41] main: Renamed _mesa_get_teximage to _mesa_GetTexImage_sw.

2014-12-15 Thread Laura Ekstrand
This reflects the new naming convention for software fallbacks. To avoid confusion with ARB_DIRECT_STATE_ACCESS backend functions, software fallbacks now have the form _mesa_[Driver function name]_sw. --- src/mesa/drivers/common/meta.c | 2 +- src/mesa/main/texgetimage.c| 6

[Mesa-dev] [PATCH 09/41] main: Removed trailing whitespace in texstate.c.

2014-12-15 Thread Laura Ekstrand
--- src/mesa/main/texstate.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index e0f0852..36eefa6 100644 --- a/src/mesa/main/texstate.c +++ b/src/mesa/main/texstate.c @@ -22,7 +22,7 @@ * OTHER DEALINGS I

[Mesa-dev] [PATCH 18/41] main: Added entry point for glTextureParameterf.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/texparam.c | 52 +- src/mesa/main/texparam.h | 20 ++ 3 files changed, 68 insertions(+), 10 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direc

[Mesa-dev] [PATCH 14/41] main: Added entry point for BindTextureUnit.

2014-12-15 Thread Laura Ekstrand
The following preparations were made in texstate.c and texstate.h to better facilitate the BindTextureUnit function: Dylan Noblesmith: mesa: add _mesa_get_tex_unit() mesa: factor out _mesa_max_tex_unit() This is about to appear in a lot more places, so reduce boilerplate copy paste. add _mesa_get_

[Mesa-dev] [PATCH 03/41] i965: intel_tex_image.c now accepts TEXTURE_CUBE_MAP as a valid target.

2014-12-15 Thread Laura Ekstrand
ARB_DIRECT_STATE_ACCESS permits the user to use TEXTURE_CUBE_MAP as a target. --- src/mesa/drivers/dri/i965/intel_tex_image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index 3317779..855a6b4 100644

[Mesa-dev] [PATCH 10/41] main: Added entry point for glCreateTextures.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 ++ src/mesa/main/texobj.c | 109 +++-- src/mesa/main/texobj.h | 2 + 3 files changed, 92 insertions(+), 27 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state_

[Mesa-dev] [PATCH 06/41] main: Changed _mesa_alloc_texture_storage to _mesa_AllocTextureStorage_sw.

2014-12-15 Thread Laura Ekstrand
In order to implement ARB_DIRECT_STATE_ACCESS, many GL API functions must now rely on a backend that both traditional and DSA functions can use. For instance, _mesa_TexStorage2D and _mesa_TextureStorage2D both call a backend function _mesa_texture_storage that takes a context and a texture object a

[Mesa-dev] [PATCH 04/41] main: Moved _mesa_lock_texture and _mesa_unlock_texture to texobj.h from teximage.h.

2014-12-15 Thread Laura Ekstrand
--- src/mesa/drivers/dri/i965/intel_tex_copy.c | 1 + src/mesa/drivers/dri/swrast/swrast.c | 1 + src/mesa/main/texgetimage.c| 2 +- src/mesa/main/teximage.h | 18 -- src/mesa/main/texobj.h | 18 ++ 5 fi

[Mesa-dev] [PATCH 15/41] main: set_tex_parameteri now handles errors according to the OpenGL 4.5 Specification.

2014-12-15 Thread Laura Ekstrand
Beginning in the OpenGL 4.3 core specification, some error handling has changed. As an example, changing sampler states with a multisample target throws INVALID_ENUM rather than INVALID_OPERATION. --- src/mesa/main/texparam.c | 70 ++-- 1 file changed, 4

[Mesa-dev] [PATCH 20/41] main: Added entry point for glTextureParameteri.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/texparam.c | 54 -- src/mesa/main/texparam.h | 8 3 files changed, 57 insertions(+), 11 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_stat

[Mesa-dev] [PATCH 25/41] main: Added entry points for glGetTextureParameteriv, Iiv, and Iuiv.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 18 src/mesa/main/texparam.c | 144 +++-- src/mesa/main/texparam.h | 10 ++ 3 files changed, 138 insertions(+), 34 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_st

[Mesa-dev] [PATCH 28/41] main: Nameless texture creation and deletion. Does not affect normal creation and deletion paths.

2014-12-15 Thread Laura Ekstrand
In implementing ARB_DIRECT_STATE_ACCESS functions, it is often necessary to abstract the functionality of a traditional GL API function into a backend that both the traditional and dsa API functions can share. For instance, glTexParameteri and glTextureParameteri both call _mesa_texture_parameteri

[Mesa-dev] [PATCH 30/41] main: Added entry point for glGetCompressedTextureImage.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 + src/mesa/main/texgetimage.c| 169 ++--- src/mesa/main/texgetimage.h| 12 ++ 3 files changed, 143 insertions(+), 45 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state

[Mesa-dev] [PATCH 29/41] main: Added entry point for glGetTextureImage.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 9 + src/mesa/main/texgetimage.c| 315 +++-- src/mesa/main/texgetimage.h| 9 + 3 files changed, 267 insertions(+), 66 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state_

[Mesa-dev] [PATCH 19/41] main: Added entry point for glTextureParameterfv.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/texparam.c | 52 +++--- src/mesa/main/texparam.h | 8 3 files changed, 53 insertions(+), 13 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_stat

[Mesa-dev] [PATCH 13/41] main: Corrected comment on _mesa_is_zero_size_texture.

2014-12-15 Thread Laura Ekstrand
--- src/mesa/main/teximage.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.h b/src/mesa/main/teximage.h index 705410d..c014bd9 100644 --- a/src/mesa/main/teximage.h +++ b/src/mesa/main/teximage.h @@ -47,7 +47,7 @@ _mesa_is_cube_face(GLenum target)

[Mesa-dev] [PATCH 12/41] main: Added entry points for glTextureSubImage*D.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 36 +++ src/mesa/main/teximage.c | 343 +++-- src/mesa/main/teximage.h | 30 +++ 3 files changed, 333 insertions(+), 76 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_st

[Mesa-dev] [PATCH 21/41] main: Added entry points for glTextureParameteriv, Iiv, Iuiv.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 18 +++ src/mesa/main/texparam.c | 145 +++-- src/mesa/main/texparam.h | 24 3 files changed, 153 insertions(+), 34 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_s

[Mesa-dev] [PATCH 16/41] main: set_tex_parameterf now handles errors according to the OpenGL 4.5 Specification.

2014-12-15 Thread Laura Ekstrand
Beginning in the OpenGL 4.3 core specification, certain error handling has changed. One example shown here is that INVALID_ENUM is thrown instead of INVALID_OPERATION when a user attempts to set sampler parameters for a multisample target. --- src/mesa/main/texparam.c | 33 ++-

[Mesa-dev] [PATCH 22/41] main: legal_get_tex_level_parameter_target now handles GL_TEXTURE_CUBE_MAP.

2014-12-15 Thread Laura Ekstrand
ARB_DIRECT_STATE_ACCESS functions allow an effective target of GL_TEXTURE_CUBE_MAP. --- src/mesa/main/texparam.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index 5ae3eb6..6e3a877 100644 --- a/src/mesa/mai

[Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 24 +++ src/mesa/main/texstorage.c | 205 +++-- src/mesa/main/texstorage.h | 31 3 files changed, 209 insertions(+), 51 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_s

[Mesa-dev] [PATCH 27/41] main: Added entry points for CopyTextureSubImage*D.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 32 + src/mesa/main/teximage.c | 170 ++--- src/mesa/main/teximage.h | 21 +++ 3 files changed, 177 insertions(+), 46 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_

[Mesa-dev] [PATCH 17/41] main: Added get_texobj_by_name in texparam.c.

2014-12-15 Thread Laura Ekstrand
This is a convenience function for *Texture*Parameter functions. --- src/mesa/main/texparam.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index df2ba3c..6121346 100644 --- a/src/mesa/main/texparam.c

[Mesa-dev] [PATCH 41/41] main: Checking for cube completeness in TextureSubImage.

2014-12-15 Thread Laura Ekstrand
This is part of a potential solution to Khronos Bug 13223. Cube completeness is a concept from glGenerateMipmap, but it seems reasonable to check for it in TextureSubImage when target=GL_TEXTURE_CUBE_MAP. --- src/mesa/main/teximage.c | 27 ++- 1 file changed, 14 insertions

[Mesa-dev] [PATCH 23/41] main: Added entry points for glGetTextureLevelParameteriv, fv.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 +++ src/mesa/main/texparam.c | 136 - src/mesa/main/texparam.h | 9 ++ 3 files changed, 131 insertions(+), 28 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_sta

[Mesa-dev] [PATCH 40/41] main: Checking for cube completeness in GetTextureImage.

2014-12-15 Thread Laura Ekstrand
This is part of a potential solution to Khronos Bug 13223. Cube completeness is a concept from glGenerateMipmap, but it seems reasonable to check for it in GetTextureImage when the target is GL_TEXTURE_CUBE_MAP. --- src/mesa/main/texgetimage.c | 25 + 1 file changed, 13 in

[Mesa-dev] [PATCH 32/41] main: Added entry point for glGenerateTextureMipmap.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 4 ++ src/mesa/main/genmipmap.c | 73 +++--- src/mesa/main/genmipmap.h | 6 +++ 3 files changed, 64 insertions(+), 19 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state_

[Mesa-dev] [PATCH 24/41] main: Added entry point for glGetTextureParameterfv.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/texparam.c | 51 +- src/mesa/main/texparam.h | 5 ++- 3 files changed, 50 insertions(+), 12 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state

[Mesa-dev] [PATCH 26/41] main: Fixed some comments in texparam.c

2014-12-15 Thread Laura Ekstrand
--- src/mesa/main/texparam.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index d9c2af3..a955126 100644 --- a/src/mesa/main/texparam.c +++ b/src/mesa/main/texparam.c @@ -227,7 +227,7 @@ set_swizzle_component(GLuint *swi

[Mesa-dev] [PATCH 37/41] main: Fixed whitespace errors in teximage.h and teximage.c.

2014-12-15 Thread Laura Ekstrand
--- src/mesa/main/teximage.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index bdef7db..4dd0b68 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -744,7 +744,7

[Mesa-dev] [PATCH 31/41] main: Added entry points for glCompressedTextureSubImage*D.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 36 src/mesa/main/teximage.c | 235 +++-- src/mesa/main/teximage.h | 31 3 files changed, 253 insertions(+), 49 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_

[Mesa-dev] [PATCH 33/41] main: Added entry points for glTextureStorage2DMultisample and glTextureStorage3DMultisample.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 19 src/mesa/main/teximage.c | 124 +++-- src/mesa/main/teximage.h | 20 3 files changed, 135 insertions(+), 28 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_

[Mesa-dev] [PATCH 35/41] main: Added entry point for glTextureBuffer.

2014-12-15 Thread Laura Ekstrand
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/teximage.c | 90 +- src/mesa/main/teximage.h | 11 3 files changed, 91 insertions(+), 16 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state

  1   2   3   >