[Mesa-dev] [Bug 88335] format_pack.c:9567:22: error: expected ')'

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88335 --- Comment #3 from Samuel Iglesias --- I have access to a Mac OS X machine. The problem is not the output from Mako template but the "indent" command in Mac OS X (likely the same in FreeBSD) which is not the GNU one. That "indent" command is the

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Cache LLVMTargetMachine object in si_screen

2015-01-13 Thread Michel Dänzer
On 07.01.2015 10:10, Michel Dänzer wrote: > On 07.01.2015 06:33, Tom Stellard wrote: >> On Wed, Dec 24, 2014 at 12:48:31PM +0900, Michel Dänzer wrote: >>> On 24.12.2014 02:49, Tom Stellard wrote: Rather than building a new one every compile. This should reduce some of the overhead of com

[Mesa-dev] [Bug 88335] format_pack.c:9567:22: error: expected ')'

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88335 --- Comment #4 from Samuel Iglesias --- Created attachment 112156 --> https://bugs.freedesktop.org/attachment.cgi?id=112156&action=edit Patch I wrote a patch that fixes the issue for Mac OS X but I have not access to a FreeBSD machine. Vinson

Re: [Mesa-dev] [PATCH] Revert "radeonsi: only set BC_OPTIMIZE_DISABLE when necessary"

2015-01-13 Thread Marek Olšák
This is weird. We only enable this optimization if the shader code doesn't use CENTROID at all. This is the main flag: sctx->ps_shader->info.uses_centroid. You can try to simplify the condition to: bc_optimize_disable = sctx->ps_shader->info.uses_centroid; That should avoid using the optimizatio

[Mesa-dev] [Bug 88354] glXSwapBuffers() can cause BadMatch or lock X when performed repeatedly

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88354 Eero Tamminen changed: What|Removed |Added CC||eero.t.tammi...@intel.com --- Comment #1

Re: [Mesa-dev] [PATCH] mesa: Adds check for integer internal formal and num samples in glRenderbufferStorageMultisample

2015-01-13 Thread Eduardo Lima Mitev
I updated this patch as commented and it is now pending review again. Thanks, Eduardo On 12/15/2014 11:30 AM, Eduardo Lima Mitev wrote: > Per GLES3 specification, section 4.4 Framebuffer objects page 198, "If > internalformat is a signed or unsigned integer format and samples is greater > than z

Re: [Mesa-dev] [PATCH v2] mesa: Check first that draw buffers are valid for glDrawBuffers on GLES3

2015-01-13 Thread Eduardo Lima Mitev
This patch was updated and is pending review. Thanks, Eduardo On 12/15/2014 11:47 AM, Eduardo Lima Mitev wrote: > Section 4.2 (Whole Framebuffer Operations) of the OpenGL 3.0 specification > says "Each buffer listed in bufs must be BACK, NONE, or one of the values from > table 4.3 (NONE, COLOR_AT

[Mesa-dev] [Bug 88369] Build break: generated format_*pack.c files are accessed from wrong directory

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88369 Bug ID: 88369 Summary: Build break: generated format_*pack.c files are accessed from wrong directory Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 88369] Build break: generated format_*pack.c files are accessed from wrong directory

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88369 Samuel Iglesias changed: What|Removed |Added CC||sigles...@igalia.com --- Comment #1 fr

Re: [Mesa-dev] [PATCH] mesa: rename RGBA8888_* format constants to something appropriate.

2015-01-13 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Jan 12, 2015 11:34 PM, "Iago Toral Quiroga" wrote: > The suggests 8-bit components which is not correct, so > replace that with the actual size of the components in each > format. > --- > src/mesa/main/format_utils.c | 20 ++-- > src

[Mesa-dev] [Bug 88369] Build break: generated format_*pack.c files are accessed from wrong directory

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88369 Eero Tamminen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 4/5] meta: Add a BlitFramebuffers-based implementation of TexSubImage

2015-01-13 Thread Neil Roberts
Jason Ekstrand writes: > + _mesa_GenTextures(1, &pbo_tex); > + pbo_tex_obj = _mesa_lookup_texture(ctx, pbo_tex); > + pbo_tex_obj->Target = depth > 2 ? GL_TEXTURE_2D_ARRAY : GL_TEXTURE_2D; Did you miss this? It still looks like it should be depth > 1. Assuming you change that it looks good

Re: [Mesa-dev] [PATCH 5/5] i965: Use _mesa_meta_TexSubImage for PBO's and cases where the texture is busy

2015-01-13 Thread Neil Roberts
This patch and the rest of the series (apart from the comment for patch 4) look good to me and are Reviewed-by: Neil Roberts - Neil pgpBvaoeRSGjh.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.fre

Re: [Mesa-dev] [PATCH v2 50/52] st/nine: Explicit nine requirements

2015-01-13 Thread Axel Davy
On 10/01/2015 14:27, David Heidelberg wrote : I'd prefer not have to revert this patch on my personal r400 based RS690 (laptop AMD X1250). You're correct, that most of applications won't run. Still, there are some earlier DX9 apps, which runs and LFS which shows really visible performance boo

Re: [Mesa-dev] FOSDEM15: Graphics DevRoom: call for speakers.

2015-01-13 Thread Thierry Reding
On Tue, Dec 09, 2014 at 03:39:26PM +0100, Luc Verhaegen wrote: > On Thu, Oct 02, 2014 at 07:44:57PM +0200, Luc Verhaegen wrote: > > Hi, > > > > At FOSDEM on the 31st of january and the 1st of February 2015, there > > will be another graphics DevRoom. URL: https://fosdem.org/2015/ > > > Slots wil

Re: [Mesa-dev] FOSDEM15: Graphics DevRoom: call for speakers.

2015-01-13 Thread Luc Verhaegen
On Tue, Jan 13, 2015 at 01:14:17PM +0100, Thierry Reding wrote: > On Tue, Dec 09, 2014 at 03:39:26PM +0100, Luc Verhaegen wrote: > > On Thu, Oct 02, 2014 at 07:44:57PM +0200, Luc Verhaegen wrote: > > > Hi, > > > > > > At FOSDEM on the 31st of january and the 1st of February 2015, there > > > will

Re: [Mesa-dev] [PATCH] glxinfo: Add support for GLX_MESA_query_renderer

2015-01-13 Thread Brian Paul
On 01/12/2015 12:27 PM, Adam Jackson wrote: This just queries our context, it doesn't attempt to enumerate all the available renderers. Signed-off-by: Adam Jackson --- src/xdemos/glxinfo.c | 49 + 1 file changed, 49 insertions(+) diff --git a/

Re: [Mesa-dev] [PATCH v2 4/5] meta: Add a BlitFramebuffers-based implementation of TexSubImage

2015-01-13 Thread Jason Ekstrand
On Tue, Jan 13, 2015 at 7:05 AM, Neil Roberts wrote: > Jason Ekstrand writes: > > > + _mesa_GenTextures(1, &pbo_tex); > > + pbo_tex_obj = _mesa_lookup_texture(ctx, pbo_tex); > > + pbo_tex_obj->Target = depth > 2 ? GL_TEXTURE_2D_ARRAY : > GL_TEXTURE_2D; > > Did you miss this? It still looks

Re: [Mesa-dev] [PATCH v4] mesa/glsl/glapi: enable GL_EXT_draw_buffers extension

2015-01-13 Thread Matt Turner
On Mon, Jan 12, 2015 at 9:54 PM, Tapani Pälli wrote: > Patch enables ES2 extension that utilizes existing ES3 functionality. > > Changes make all the subtests to run and pass in WebGL conformance > test 'webgl-draw-buffers' when running Chrome on OpenGL ES, also > Piglit test 'draw_buffers_gles2'

[Mesa-dev] [Bug 88335] format_pack.c:9567:22: error: expected ')'

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88335 --- Comment #5 from Vinson Lee --- (In reply to Samuel Iglesias from comment #4) > > Vinson, Can you apply the patch and tell me if it fixes the issue in FreeBSD > too? Once you confirmed that, I will send it to the mailing list. > attachment

Re: [Mesa-dev] [PATCH 2/4] i965: Refactor tiled memcpy functions and move them into their own file

2015-01-13 Thread Chad Versace
On 01/12/2015 10:22 AM, Jason Ekstrand wrote: > From: Sisinty Sasmita Patra > > This commit refactors the tiled_memcpy code in intel_tex_subimage.c and > moves it into its own file intel_tiled_memcpy files. Also, xtile_copy and > ytile_copy are renamed to linear_to_xtiled and linear_to_ytiled >

[Mesa-dev] [PATCH v3 06/10] meta: Add a BlitFramebuffers-based implementation of TexSubImage

2015-01-13 Thread Jason Ekstrand
This meta path, designed for use with PBO's, creates a temporary texture out of the PBO and uses BlitFramebuffers to do the actual texture upload. v2 Jason Ekstrand : - Add support for handling simple packing options v3 Jason Ekstrand : - Refactor to split out the texture-from-pbo code - Renam

[Mesa-dev] [PATCH v3 03/10] i965: Apply the miptree offset to surface state for renderbuffers

2015-01-13 Thread Jason Ekstrand
Previously, we were completely ignoring the mt->offset field for renderbuffers. While it does have some alignment constraints, it is valid to use it. This patch adds the code to each of the 4 surface state setup functions to handle it. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 ++

[Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

2015-01-13 Thread Jason Ekstrand
Going through the for loop every time has noticable overhead. This fixes things up so we only do that once ever and then just do a hash table lookup which should be much cheaper. --- src/mesa/main/formats.c | 67 + 1 file changed, 56 insertions(+),

[Mesa-dev] [PATCH v3 09/10] i965/tex_image: Use meta for instead of the blitter PBO TexImage and GetTexImage

2015-01-13 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_tex_image.c | 203 +++- 1 file changed, 20 insertions(+), 183 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index b533dbd..58d675c 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH v3 08/10] i965/pixel_read: Use meta_pbo_GetTexSubImage for PBO ReadPixels

2015-01-13 Thread Jason Ekstrand
Since the meta path can do strictly more than the blitter path, we just remove the blitter path entirely. --- src/mesa/drivers/dri/i965/intel_pixel_read.c | 130 ++- 1 file changed, 6 insertions(+), 124 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c

[Mesa-dev] [PATCH v3 04/10] i965: Implement SetTextureStorageForBufferObject

2015-01-13 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_tex.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_tex.c b/src/mesa/drivers/dri/i965/intel_tex.c index b2c0335..184702f 100644 --- a/src/mesa/drivers/dri/i965/intel_tex.c +++ b/src/mesa

[Mesa-dev] [PATCH v3 10/10] i965/tex_subimage: use meta instead of the blitter for PBO TexSubImage

2015-01-13 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 115 - 1 file changed, 15 insertions(+), 100 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index 3e4ed1b..b96ad50 100644 --- a/src/mesa/drivers

[Mesa-dev] [PATCH v3 07/10] meta: Add an implementation of GetTexSubImage for PBOs

2015-01-13 Thread Jason Ekstrand
--- src/mesa/drivers/common/meta.h | 8 ++ src/mesa/drivers/common/meta_tex_subimage.c | 117 2 files changed, 125 insertions(+) diff --git a/src/mesa/drivers/common/meta.h b/src/mesa/drivers/common/meta.h index 8b70869..afe55d0 100644 --- a/src/mesa/dr

[Mesa-dev] [PATCH v3 01/10] mesa/dd: Add a function for creating a texture from a buffer object

2015-01-13 Thread Jason Ekstrand
--- src/mesa/main/dd.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 2f40915..eb30847 100644 --- a/src/mesa/main/dd.h +++ b/src/mesa/main/dd.h @@ -415,6 +415,21 @@ struct dd_function_table { struct gl

[Mesa-dev] [PATCH v3 02/10] i965/mipmap_tree: Add a depth parameter to create_for_bo

2015-01-13 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/intel_fbo.c | 1 + src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 +++-- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 1 + src/mesa/drivers/dri/i965/intel_pixel_draw.c | 2 +- src/mesa/drivers/dri/i965/intel_pixel_read.c | 2 +- src/mesa/drivers/dr

[Mesa-dev] [PATCH v3 00/10] i965: Use the render pipeline for PBO uploads and

2015-01-13 Thread Jason Ekstrand
This series adds support for doing texture up/downloads using the render pipeline instead of the blitter. There are a number of good reasons for doing so. 1) The blitter is commonly thought to be slower than the render pipeline in terms of its access to memory. 2) The blitter is on a diffe

Re: [Mesa-dev] [PATCH v3 00/10] i965: Use the render pipeline for PBO uploads and

2015-01-13 Thread Jason Ekstrand
On Tue, Jan 13, 2015 at 10:28 AM, Jason Ekstrand wrote: > This series adds support for doing texture up/downloads using the render > pipeline instead of the blitter. There are a number of good reasons for > doing so. > > 1) The blitter is commonly thought to be slower than the render pipeline >

Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal format type

2015-01-13 Thread Anuj Phogat
On Fri, Jan 9, 2015 at 5:21 PM, wrote: > From: Mike Mason > > Changes the initial internal format of a render buffer > to GL_RGBA4. This fixes a failure in the following > DrawElements test: > > dEQP-GLES3.functional.state_query.rbo.renderbuffer_internal_format > --- > src/mesa/main/renderbuffe

[Mesa-dev] [PATCH] i965/miptree_map_blit: Don't do the initial copy if INVALIDATE_RANGE is set

2015-01-13 Thread Jason Ekstrand
Before we were always coping from the buffer being mapped into the temporary buffer. However, if INVALIDATE_RANGE is set, then we know that the data is going to be junk after we unmap so there's no point in doing the blit. This is important because doing the blit will cause a stall 3 lines later

Re: [Mesa-dev] [PATCH 4/4] i965: Implemente a tiled fast-path for glReadPixels and glGetTexImage

2015-01-13 Thread Chad Versace
On 01/12/2015 10:22 AM, Jason Ekstrand wrote: > From: Sisinty Sasmita Patra > > Added intel_readpixels_tiled_mempcpy and intel_gettexsubimage_tiled_mempcpy > functions. These are the fast paths for glReadPixels and glGetTexImage. > > On chrome, using the RoboHornet 2D Canvas toDataURL test, this

Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal format type

2015-01-13 Thread Chad Versace
On 01/09/2015 05:21 PM, michael.w.ma...@intel.com wrote: > From: Mike Mason > > Changes the initial internal format of a render buffer > to GL_RGBA4. This fixes a failure in the following > DrawElements test: > > dEQP-GLES3.functional.state_query.rbo.renderbuffer_internal_format > --- > src/mes

Re: [Mesa-dev] [PATCH v3] mesa: Enable GL_RGB/GL_RGBA in GLES3 glGetInternalformativ

2015-01-13 Thread Chad Versace
On 01/12/2015 02:37 PM, michael.w.ma...@intel.com wrote: > From: Mike Mason > > Removes commit 7894278 changes and moves fix to _mesa_GetInternalformativ(). > The original commit enabled the GL_RGB and GL_RGBA unsized internal formats > as valid for render buffers in GLES3, but this is incorrect.

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Cache LLVMTargetMachine object in si_screen

2015-01-13 Thread Tom Stellard
On Tue, Jan 13, 2015 at 06:47:00PM +0900, Michel Dänzer wrote: > On 07.01.2015 10:10, Michel Dänzer wrote: > > On 07.01.2015 06:33, Tom Stellard wrote: > >> On Wed, Dec 24, 2014 at 12:48:31PM +0900, Michel Dänzer wrote: > >>> On 24.12.2014 02:49, Tom Stellard wrote: > Rather than building a ne

Re: [Mesa-dev] [PATCH v3] mesa: Enable GL_RGB/GL_RGBA in GLES3 glGetInternalformativ

2015-01-13 Thread Matt Turner
On Tue, Jan 13, 2015 at 10:49 AM, Chad Versace wrote: > On 01/12/2015 02:37 PM, michael.w.ma...@intel.com wrote: >> From: Mike Mason >> >> Removes commit 7894278 changes and moves fix to _mesa_GetInternalformativ(). >> The original commit enabled the GL_RGB and GL_RGBA unsized internal formats >>

Re: [Mesa-dev] [PATCH v3] mesa: Enable GL_RGB/GL_RGBA in GLES3 glGetInternalformativ

2015-01-13 Thread Chad Versace
On 01/13/2015 11:12 AM, Matt Turner wrote: > On Tue, Jan 13, 2015 at 10:49 AM, Chad Versace wrote: >> On 01/12/2015 02:37 PM, michael.w.ma...@intel.com wrote: >>> From: Mike Mason >>> >>> Removes commit 7894278 changes and moves fix to _mesa_GetInternalformativ(). >>> The original commit enabled

Re: [Mesa-dev] [PATCH v4 13/22] configure: require python mako module

2015-01-13 Thread Dave Airlie
>> >> Do we definitely need mako 0.7.3? RHEL6 only ships mako 0.3.4. >> > > Can you test lowering the required Mako version in configure.ac? > > Search the following string: AX_CHECK_PYTHON_MAKO_MODULE > and modify the version number that it receives as argument. > > I tested with Mako 0.3.6 (avail

Re: [Mesa-dev] [PATCH 3/4] i965/fs: Optimize (gl_FrontFacing ? x : y) where x and y are ±1.0.

2015-01-13 Thread Matt Turner
On Thu, Jan 8, 2015 at 10:59 PM, Matt Turner wrote: > total instructions in shared programs: 5886767 -> 5881642 (-0.09%) > instructions in affected programs: 532199 -> 527074 (-0.96%) > GAINED:9 > LOST: 6 > --- And on Ironlake,

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Optimize (gl_FrontFacing ? x : -1.0) where x is ±0.0.

2015-01-13 Thread Matt Turner
On Thu, Jan 8, 2015 at 10:59 PM, Matt Turner wrote: > The pattern > >gl_FrontFacing ? -0.0 : -1.0 > > appears in many shaders, but there's no significance of the 0.0's sign > since it the result of the expression is always used in an addition. > > Getting the sign bit right would be an extra O

Re: [Mesa-dev] [PATCH 036/133] i965/fs: Allow reinterpretation in constant propagation

2015-01-13 Thread Matt Turner
I would have no clue what this patch did if I just read the subject. How about: > i965/fs: Allow constant propagation between different types. Also, this should go in separately from NIR, since it affects things (in Synmark) now: instructions in affected programs: 2288 -> 2144 (-6.29%) It a

Re: [Mesa-dev] [PATCH 036/133] i965/fs: Allow reinterpretation in constant propagation

2015-01-13 Thread Jason Ekstrand
On Tue, Jan 13, 2015 at 1:08 PM, Matt Turner wrote: > I would have no clue what this patch did if I just read the subject. How > about: > > > i965/fs: Allow constant propagation between different types. > Sure. > > Also, this should go in separately from NIR, since it affects things > (in Synm

Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal format type

2015-01-13 Thread Mason, Michael W
> -Original Message- > From: Versace, Chad > Sent: Tuesday, January 13, 2015 10:47 AM > To: Mason, Michael W; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal > format type > > On 01/09/2015 05:21 PM, michael.w.ma...@intel.com wrote

[Mesa-dev] [PATCH 1/2] i965/fs: Emit MADs from (x + -(y * z)).

2015-01-13 Thread Matt Turner
Just use the negation source modifier on one of the multiplicand arguments. total instructions in shared programs: 5889529 -> 5880016 (-0.16%) instructions in affected programs: 600846 -> 591333 (-1.58%) --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 12 1 file changed, 12 in

[Mesa-dev] [PATCH 2/2] i965/fs: Emit MADs from (x + abs(y * z)).

2015-01-13 Thread Matt Turner
Just use the abs source modifier on both of the multiplicand arguments. instructions in affected programs: 300 -> 296 (-1.33%) --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH v4] mesa/glsl/glapi: enable GL_EXT_draw_buffers extension

2015-01-13 Thread Chad Versace
On 01/13/2015 09:46 AM, Matt Turner wrote: > On Mon, Jan 12, 2015 at 9:54 PM, Tapani Pälli wrote: >> Patch enables ES2 extension that utilizes existing ES3 functionality. >> >> Changes make all the subtests to run and pass in WebGL conformance >> test 'webgl-draw-buffers' when running Chrome on Op

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Emit MADs from (x + -(y * z)).

2015-01-13 Thread Kristian Høgsberg
On Tue, Jan 13, 2015 at 3:00 PM, Matt Turner wrote: > Just use the negation source modifier on one of the multiplicand > arguments. > > total instructions in shared programs: 5889529 -> 5880016 (-0.16%) > instructions in affected programs: 600846 -> 591333 (-1.58%) Reviewed-by: Kristian Høgsb

[Mesa-dev] [PATCH 1/2] i965/fs: Don't use backend_visitor::instructions after creating the CFG.

2015-01-13 Thread Matt Turner
This is a fix for a regression introduced in commit a9f8296d ("i965/fs: Preserve the CFG in a few more places."). The errata this code works around is described in a comment before the function: "[DevBW, DevCL] Errata: A destination register from a send can not be used as a destination reg

[Mesa-dev] [PATCH 2/2] i965/fs: Only apply Gen4 work-arounds if regs_written > 1.

2015-01-13 Thread Matt Turner
Otherwise, we would have necessarily read the results or eliminated the dead SEND. In either case, no work around is necessary. Noticed when debugging the problem the previous patch fixed that any time we hit a math instruction, we'd walk through subsequent instructions, and of course each time di

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Emit MADs from (x + abs(y * z)).

2015-01-13 Thread Kristian Høgsberg
On Tue, Jan 13, 2015 at 3:00 PM, Matt Turner wrote: > Just use the abs source modifier on both of the multiplicand > arguments. > > instructions in affected programs: 300 -> 296 (-1.33%) Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 18 ++

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Only apply Gen4 work-arounds if regs_written > 1.

2015-01-13 Thread Matt Turner
On Tue, Jan 13, 2015 at 3:35 PM, Matt Turner wrote: > Otherwise, we would have necessarily read the results or eliminated the > dead SEND. In either case, no work around is necessary. > > Noticed when debugging the problem the previous patch fixed that any > time we hit a math instruction, we'd wa

Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal format type

2015-01-13 Thread Chad Versace
On 01/13/2015 02:34 PM, Mason, Michael W wrote: >> -Original Message- >> From: Versace, Chad >> Sent: Tuesday, January 13, 2015 10:47 AM >> To: Mason, Michael W; mesa-dev@lists.freedesktop.org >> Subject: Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal >> format type >> >>

[Mesa-dev] [Bug 88079] dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0 tests fail due to enabling of GL_RGB and GL_RGBA

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88079 Chad Versace changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #23 from Jose P. --- Any news on this? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freed

Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal format type

2015-01-13 Thread Mason, Michael W
> -Original Message- > From: Versace, Chad > Sent: Tuesday, January 13, 2015 3:42 PM > To: Mason, Michael W; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal > format type > > On 01/13/2015 02:34 PM, Mason, Michael W wrote: > >> ---

Re: [Mesa-dev] [PATCH] mesa: Fix render buffer initial internal format type

2015-01-13 Thread Chad Versace
Brian and Ian, me and Michael have a Mesa TLS question at the message's bottom. On 01/13/2015 04:41 PM, Mason, Michael W wrote: >> -Original Message- >> From: Versace, Chad >> Sent: Tuesday, January 13, 2015 3:42 PM >> To: Mason, Michael W; mesa-dev@lists.freedesktop.org >> Subject: Re: [

Re: [Mesa-dev] No rule to make target ...format_pack.c (Was: [PATCH v4 00/22] auto-generate pack/unpack functions)

2015-01-13 Thread Michel Dänzer
On 12.01.2015 21:48, Jose Fonseca wrote: > On 12/01/15 12:32, Iago Toral Quiroga wrote: >> On lun, 2015-01-12 at 12:18 +, Jose Fonseca wrote: >>> >>> There seems to be some bad or missing dependency when building with >>> automake. I have a build bot that roughly does this every time: >>> >>>

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Cache LLVMTargetMachine object in si_screen

2015-01-13 Thread Michel Dänzer
On 14.01.2015 04:07, Tom Stellard wrote: > On Tue, Jan 13, 2015 at 06:47:00PM +0900, Michel Dänzer wrote: >> On 07.01.2015 10:10, Michel Dänzer wrote: >>> On 07.01.2015 06:33, Tom Stellard wrote: On Wed, Dec 24, 2014 at 12:48:31PM +0900, Michel Dänzer wrote: > On 24.12.2014 02:49, Tom Stel

[Mesa-dev] [Bug 88354] glXSwapBuffers() can cause BadMatch or lock X when performed repeatedly

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88354 --- Comment #2 from Seán de Búrca --- I believe I'm using DRI2. My Xorg logs contain the following: (II) GLX: Initialized DRI2 GL provider for screen 0 If this may be incorrect, please let me know. I am using xorg-server 1.16.2.901 and X Intel

Re: [Mesa-dev] [PATCH] Revert "radeonsi: only set BC_OPTIMIZE_DISABLE when necessary"

2015-01-13 Thread Michel Dänzer
On 13.01.2015 19:11, Marek Olšák wrote: > This is weird. We only enable this optimization if the shader code > doesn't use CENTROID at all. This is the main flag: > sctx->ps_shader->info.uses_centroid. > > You can try to simplify the condition to: > > bc_optimize_disable = sctx->ps_shader->info.u

Re: [Mesa-dev] [PATCH] i965/miptree_map_blit: Don't do the initial copy if INVALIDATE_RANGE is set

2015-01-13 Thread Kenneth Graunke
On Tuesday, January 13, 2015 10:39:22 AM Jason Ekstrand wrote: > Before we were always coping from the buffer being mapped into the > temporary buffer. However, if INVALIDATE_RANGE is set, then we know that > the data is going to be junk after we unmap so there's no point in doing > the blit. Thi

Re: [Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

2015-01-13 Thread Kenneth Graunke
On Tuesday, January 13, 2015 10:28:20 AM Jason Ekstrand wrote: > Going through the for loop every time has noticable overhead. This fixes > things up so we only do that once ever and then just do a hash table lookup > which should be much cheaper. > --- > src/mesa/main/formats.c | 67 > +

Re: [Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

2015-01-13 Thread Jason Ekstrand
On Jan 13, 2015 6:38 PM, "Kenneth Graunke" wrote: > > On Tuesday, January 13, 2015 10:28:20 AM Jason Ekstrand wrote: > > Going through the for loop every time has noticable overhead. This fixes > > things up so we only do that once ever and then just do a hash table lookup > > which should be muc

Re: [Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

2015-01-13 Thread Kenneth Graunke
On Tuesday, January 13, 2015 08:02:54 PM Jason Ekstrand wrote: > On Jan 13, 2015 6:38 PM, "Kenneth Graunke" wrote: > > > > On Tuesday, January 13, 2015 10:28:20 AM Jason Ekstrand wrote: > > > Going through the for loop every time has noticable overhead. This > fixes > > > things up so we only do

Re: [Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

2015-01-13 Thread Matt Turner
On Tue, Jan 13, 2015 at 10:28 AM, Jason Ekstrand wrote: > Going through the for loop every time has noticable overhead. This fixes > things up so we only do that once ever and then just do a hash table lookup > which should be much cheaper. > --- > src/mesa/main/formats.c | 67 > +++

[Mesa-dev] Removing out of date Mesa wiki pages

2015-01-13 Thread Timothy Arceri
Hi all, Not sure how many of you have come across the webpage "Major Linux Problems on the Desktop 2015 edition" [1]. Accurate or not it seems to be getting a bit of attention. Anyway Mesa gets a bit of a bashing in there although most of the information the author uses to backup their claims are

Re: [Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

2015-01-13 Thread Jason Ekstrand
On Tue, Jan 13, 2015 at 8:43 PM, Matt Turner wrote: > On Tue, Jan 13, 2015 at 10:28 AM, Jason Ekstrand > wrote: > > Going through the for loop every time has noticable overhead. This fixes > > things up so we only do that once ever and then just do a hash table > lookup > > which should be much

Re: [Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

2015-01-13 Thread Matt Turner
On Tue, Jan 13, 2015 at 9:45 PM, Jason Ekstrand wrote: > On Tue, Jan 13, 2015 at 8:43 PM, Matt Turner wrote: >> But, it sounded like what you wanted was for subsequent calls to >> format_array_format_table_init() via call_once() to block until the >> first had completed. I don't think call_once()

Re: [Mesa-dev] [PATCH v2] mesa: Check first that draw buffers are valid for glDrawBuffers on GLES3

2015-01-13 Thread Tapani Pälli
Hi; On 12/15/2014 12:47 PM, Eduardo Lima Mitev wrote: Section 4.2 (Whole Framebuffer Operations) of the OpenGL 3.0 specification says "Each buffer listed in bufs must be BACK, NONE, or one of the values from table 4.3 (NONE, COLOR_ATTACHMENTi)". This patch adds this check before previous other,

Re: [Mesa-dev] [PATCH] i965/miptree_map_blit: Don't do the initial copy if INVALIDATE_RANGE is set

2015-01-13 Thread Jason Ekstrand
On Tue, Jan 13, 2015 at 6:35 PM, Kenneth Graunke wrote: > > On Tuesday, January 13, 2015 10:39:22 AM Jason Ekstrand wrote: > > Before we were always coping from the buffer being mapped into the > > temporary buffer. However, if INVALIDATE_RANGE is set, then we know that > > the data is going to b

[Mesa-dev] [PATCH] i965: Pass a shader stage abbreviation to fs_generator().

2015-01-13 Thread Kenneth Graunke
A lot of messages hardcoded the string "FS", which is confusing on Broadwell, where we use this code for VS support as well. shader-db particularly got confused, as it reported two "FS SIMD8" shaders, and no vertex shaders at all. Craziness ensued. Signed-off-by: Kenneth Graunke --- src/mesa/d

[Mesa-dev] [PATCH 1/2] configure: change required Python Mako version to 0.3.4

2015-01-13 Thread Samuel Iglesias Gonsalvez
Signed-off-by: Samuel Iglesias Gonsalvez Reviewed-by: Dave Airlie --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d4cf4b8..3c614ea 100644 --- a/configure.ac +++ b/configure.ac @@ -76,7 +76,7 @@ if test "x$INDENT" != "xcat"; t

[Mesa-dev] [PATCH] i965: Fix "vertex" vs. "geometry" and "VS" vs. "GS" in debug output.

2015-01-13 Thread Kenneth Graunke
We were happily printing "Native code for unnamed vertex shader" and "VS vec4" program for geometry shaders in our INTEL_DEBUG=gs output, as well as the KHR_debug output used by shader-db. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 +- src/mesa/driv

[Mesa-dev] [PATCH 2/2] configure: add check for GNU indent

2015-01-13 Thread Samuel Iglesias Gonsalvez
Only GNU indent is supported when indenting autogenerated format_pack.c and format_unpack.c files. Some non-GNU indent (Mac OS X and FreeBSD) add extra whitespaces than break the build of those files. Fallback to 'cat' if a non-GNU indent is found. Fixes: https://bugs.freedesktop.org/show_bug.cgi

[Mesa-dev] [Bug 88335] format_pack.c:9567:22: error: expected ')'

2015-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88335 --- Comment #6 from Samuel Iglesias --- Patch sent to the mailing list: http://lists.freedesktop.org/archives/mesa-dev/2015-January/074367.html -- You are receiving this mail because: You are the assignee for the bug. _

Re: [Mesa-dev] [PATCH] i965: Pass a shader stage abbreviation to fs_generator().

2015-01-13 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/4] i965: Add more stringent blitter assertions

2015-01-13 Thread Ben Widawsky
Blits to or from a y-tiled surface must always be a multiple of the tile size. From page 16 of the HSW PRM (https://01.org/linuxgraphics/sites/default/files/documentation/intel-gfx-prm-osrc-hsw-memory-views.pdf#16) "The pitch of a tiled enclosing region must be an integral number of tile widths" S

[Mesa-dev] [PATCH 1/4] i965: Consolidate some of the intel_blit logic

2015-01-13 Thread Ben Widawsky
An upcoming patch is going to introduce some code here, and having this code organized as the patch does makes it a bit easier to read later. There should be no functional change here. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_blit.c | 28 1 fi

[Mesa-dev] [PATCH 4/4] i965: Allow Y-tiled allocations for large surfaces

2015-01-13 Thread Ben Widawsky
This patch will use a new calculation to determine if a surface can be blitted from or to. Previously, the "total_height" member was used. Total_height in the case of 2d, 3d, and cube map arrays is the height of each slice/layer/face. Since the GL map APIS only ever deal with a slice at a time howe

[Mesa-dev] [PATCH 3/4] i965: Attempt to blit for larger textures

2015-01-13 Thread Ben Widawsky
The blit engine is limited to 32Kx32K transfer. In cases where we have to fall back to the blitter, and when trying to blit a slice of a 2d texture array, or face of a cube map, we don't need to transfer the entire texture. I doubt this patch will get exercised at this point since we'll always all

Re: [Mesa-dev] [PATCH] i965: Fix "vertex" vs. "geometry" and "VS" vs. "GS" in debug output.

2015-01-13 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] configure: add check for GNU indent

2015-01-13 Thread Matt Turner
On Tue, Jan 13, 2015 at 11:03 PM, Samuel Iglesias Gonsalvez wrote: > Only GNU indent is supported when indenting autogenerated format_pack.c > and format_unpack.c files. Some non-GNU indent (Mac OS X and FreeBSD) > add extra whitespaces than break the build of those files. Seems like those indent