Re: [Mesa-dev] [PATCH 3/3] Mesa: Advertise GL_OES_texture_*float* extensions support with i965.

Reviewed-by: Tapani Pälli I've given it some amount of testing with deferred rendering WebGL demos by running chrome with '--use-gl=egl' option. On 01/08/2015 06:30 AM, Kalyan Kondapally wrote: This patch advertises support for GL_OES_texture_*float* extensions when using i965 drivers. Sign

Re: [Mesa-dev] [PATCH 2/3] Mesa: Add support for HALF_FLOAT_OES type.

Hi; This needs some amount of rebase, I've done it at http://cgit.freedesktop.org/~tpalli/mesa/log/?h=float_rebased Changes are Reviewed-by: Tapani Pälli On 01/08/2015 06:30 AM, Kalyan Kondapally wrote: This patch adds needed support for accepting HALF_FLOAT_OES as valid type for TexImage*D a

Re: [Mesa-dev] [PATCH 1/3] Mesa: Add support for GL_OES_texture_*float* extensions.

On 01/08/2015 06:30 AM, Kalyan Kondapally wrote: This patch series adds support for following GLES2 Texture Float extensions: 1)GL_OES_texture_float, 2)GL_OES_texture_half_float, 3)GL_OES_texture_float_linear, 4)GL_OES_texture_half_float_linear. This patch adds basic infrastructure and needed

[Mesa-dev] [Bug 88820] fake_glx_screen.cpp:78: error: thread-local storage not supported for this target

https://bugs.freedesktop.org/show_bug.cgi?id=88820 --- Comment #1 from Jonathan Gray --- That code uses __thread on all systems regardless of whether they support TLS or not. It should use something like the code in src/glx/glxclient.h perhaps? OpenBSD currently doesn't have support for TLS and

[Mesa-dev] [Bug 88820] fake_glx_screen.cpp:78: error: thread-local storage not supported for this target

https://bugs.freedesktop.org/show_bug.cgi?id=88820 Bug ID: 88820 Summary: fake_glx_screen.cpp:78: error: thread-local storage not supported for this target Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [rfc/r600g] add support for primitive id without geom shader

Hey, This didn't look like it should be too difficult, however I have two worries about my approach a) the prereq change to move the pixel shader selector, I should probably move more code, but it might not matter, but I worry this could have side effects though the ps key doesn't depend

[Mesa-dev] [PATCH 1/2] r600g: move selecting the pixel shader earlier.

From: Dave Airlie In order to detect that a pixel shader has a prim id input when we have no geometry shader we need to reorder the shader selection so the pixel shader is selected first, then the vertex shader key can take into account the primitive id input requirement and lack of geom shader.

[Mesa-dev] [PATCH 2/2] r600g: add support for primitive id without geom shader

From: Dave Airlie GLSL 1.50 specifies a fragment shader may have a primitive id input without a geometry shader present. On r600 hw there is a special GS scenario for this, you have to enable GS_SCENARIO_A and pass the primitive id through the vertex shader which operates in GS_A mode. This is

[Mesa-dev] [Bug 88662] unaligned access to gl_dlist_node

https://bugs.freedesktop.org/show_bug.cgi?id=88662 --- Comment #1 from Brian Paul --- Created attachment 112872 --> https://bugs.freedesktop.org/attachment.cgi?id=112872&action=edit proposed patch Hi Jonathan, Here's a patch which should fix the issue. Can you test? -- You are receiving th

[Mesa-dev] [Bug 88467] nir.c:140: error: ‘nir_src’ has no member named ‘ssa’

https://bugs.freedesktop.org/show_bug.cgi?id=88467 Jason Ekstrand changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 88467, which changed state. Bug 88467 Summary: nir.c:140: error: ‘nir_src’ has no member named ‘ssa’ https://bugs.freedesktop.org/show_bug.cgi?id=88467 What|Removed |Added --

[Mesa-dev] [Bug 88806] nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type

https://bugs.freedesktop.org/show_bug.cgi?id=88806 Jason Ekstrand changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Jason Ekst

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

On Mon, Jan 26, 2015 at 3:58 PM, Eric Anholt wrote: > Jason Ekstrand writes: > > > On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt wrote: > > > >> Jason Ekstrand writes: > >> > + case nir_instr_type_phi: { > >> > + nir_phi_instr *src_phi = nir_instr_as_phi(src_instr); > >> > + > >>

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

Jason Ekstrand writes: > On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt wrote: > >> Jason Ekstrand writes: >> > + case nir_instr_type_phi: { >> > + nir_phi_instr *src_phi = nir_instr_as_phi(src_instr); >> > + >> > + /* Insert an entry and mark it as scalarizable for now. Tha

Re: [Mesa-dev] [PATCH 2/2] nir/opcodes: Use fpclassify() instead of isnormal() for ldexp

On Mon, Jan 26, 2015 at 3:33 PM, Ian Romanick wrote: > On 01/26/2015 02:22 PM, Jason Ekstrand wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88806 > > --- > > src/glsl/nir/nir_opcodes.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/glsl/ni

Re: [Mesa-dev] [PATCH 1/2] util: Move the alternate fpclassify implementation to util

On Mon, Jan 26, 2015 at 3:27 PM, Ian Romanick wrote: > I think the functions in the header file need to be 'static inline'. > Otherwise linking will fail platforms that don't have fpclassify... > which defeats the purpose. :) > done > > On 01/26/2015 02:22 PM, Jason Ekstrand wrote: > > --- > >

Re: [Mesa-dev] [PATCH 2/2] nir/opcodes: Use fpclassify() instead of isnormal() for ldexp

On 01/26/2015 02:22 PM, Jason Ekstrand wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88806 > --- > src/glsl/nir/nir_opcodes.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py > index f54a017..3f21

Re: [Mesa-dev] [PATCH 1/2] util: Move the alternate fpclassify implementation to util

I think the functions in the header file need to be 'static inline'. Otherwise linking will fail platforms that don't have fpclassify... which defeats the purpose. :) On 01/26/2015 02:22 PM, Jason Ekstrand wrote: > --- > src/mesa/main/querymatrix.c | 51 +--

Re: [Mesa-dev] [PATCH 1/2] nir: add a helper function for getting the number of source components

On Mon, Jan 26, 2015 at 2:47 PM, Connor Abbott wrote: > On Sun, Jan 25, 2015 at 7:51 PM, Jason Ekstrand > wrote: > > > > > > On Sun, Jan 25, 2015 at 8:56 AM, Connor Abbott > wrote: > >> > >> Unlike with non-SSA ALU instructions, where if they're per-component > >> you have to look at the writem

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

On Mon, Jan 26, 2015 at 11:21 AM, Eric Anholt wrote: > Jason Ekstrand writes: > > diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c > b/src/glsl/nir/nir_lower_phis_to_scalar.c > > new file mode 100644 > > index 000..9f901d6 > > --- /dev/null > > +++ b/src/glsl/nir/nir_lower_phis_to_scalar

Re: [Mesa-dev] [PATCH 1/2] nir: add a helper function for getting the number of source components

On Sun, Jan 25, 2015 at 7:51 PM, Jason Ekstrand wrote: > > > On Sun, Jan 25, 2015 at 8:56 AM, Connor Abbott wrote: >> >> Unlike with non-SSA ALU instructions, where if they're per-component >> you have to look at the writemask to know which source channels are >> being used, SSA ALU instructions

[Mesa-dev] [Bug 88806] nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type

https://bugs.freedesktop.org/show_bug.cgi?id=88806 --- Comment #2 from Jason Ekstrand --- I just sent two patches to the list that should fix this. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. _

[Mesa-dev] [PATCH 2/2] nir/opcodes: Use fpclassify() instead of isnormal() for ldexp

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88806 --- src/glsl/nir/nir_opcodes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py index f54a017..3f21539 100644 --- a/src/glsl/nir/nir_opcodes.py +++ b/src/glsl/

[Mesa-dev] [PATCH 1/2] util: Move the alternate fpclassify implementation to util

--- src/mesa/main/querymatrix.c | 51 +--- src/util/macros.h | 52 + 2 files changed, 53 insertions(+), 50 deletions(-) diff --git a/src/mesa/main/querymatrix.c b/src/mesa/main/querymatrix.c index ef8517

Re: [Mesa-dev] [PATCH] i965: Do Sandybridge workaround flushes before each primitive.

On 01/21/2015 03:11 PM, Kenneth Graunke wrote: > On Wednesday, January 21, 2015 11:59:39 AM Chad Versace wrote: >> On 01/09/2015 11:07 PM, Kenneth Graunke wrote: >>> Sandybridge requires the post-sync non-zero workaround in a ton of >>> places, and if you ever miss one, the GPU usually hangs. >>> >

Re: [Mesa-dev] [PATCH v2] mesa: simplify detection of fpclassify

Pushed. Thanks. On Fri, Jan 23, 2015 at 8:57 AM, Felix Janda wrote: > Fixes compilation with musl libc. > > Reviewed-by: Ian Romanick > --- > Changes in v2: Add comment by Ian Romanick on fpclassify in C99 > --- > src/mesa/main/querymatrix.c | 18 +++--- > 1 file changed, 7 insert

Re: [Mesa-dev] adding driver specific docs in src/gallium/docs?

On Mon, Jan 26, 2015 at 2:19 PM, Brian Paul wrote: > On 01/26/2015 10:53 AM, Rob Clark wrote: >> >> Btw, I had started putting together some docs for freedreno "ir3" >> compiler.. I was originally just going to use markdown, but the >> graphviz plugin for sphinx is actually a bit too useful for t

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #27 from Eugene --- (In reply to Jason Ekstrand from comment #26) > I tried this on a pineview machine which is i915 not 865 but it works fine, > so this doesn't look a generic driver change. So what could I/we do ? Any ideas ? May b

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||88467 -- You are receiving this mail becau

[Mesa-dev] [Bug 88467] nir.c:140: error: ‘nir_src’ has no member named ‘ssa’

https://bugs.freedesktop.org/show_bug.cgi?id=88467 Vinson Lee changed: What|Removed |Added Blocks||79706 -- You are receiving this mail becau

[Mesa-dev] [PATCH] mesa: Port a variant of 68afbe89c72d085dcbbf2b264f0201ab73fe339e to util/

The idea is that after a remove_from_list(), you might want to be able to do a remove_from_list() on it again or an is_empty_list(). This is apparently relied on by r300g. --- src/util/simple_list.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/simple_list.h b/src/util/simple_list.

[Mesa-dev] [Bug 88806] nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type

https://bugs.freedesktop.org/show_bug.cgi?id=88806 Vinson Lee changed: What|Removed |Added Keywords||bisected CC|

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||88806 -- You are receiving this mail becau

Re: [Mesa-dev] [PATCH] nir: Make vec-to-movs handle src/dest aliasing.

On Mon, Jan 26, 2015 at 2:31 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Fri, Jan 23, 2015 at 5:34 PM, Eric Anholt wrote: >>> Connor Abbott writes: >>> Argh, nevermind, I was reading it wrong... On Thu, Jan 22, 2015 at 8:18 PM, Connor Abbott wrote: > What happens

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

On Mon, Jan 26, 2015 at 2:21 PM, Eric Anholt wrote: > I just notied: When do I need to all nir_metadata_preserve()? I didn't > in my pass. It dirties all the metadata (topologically-sorted block indices, dominance info, liveness info, etc.) except the stuff you tell it to preserve via the flags.

Re: [Mesa-dev] [PATCH] nir: Make vec-to-movs handle src/dest aliasing.

Connor Abbott writes: > On Fri, Jan 23, 2015 at 5:34 PM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> Argh, nevermind, I was reading it wrong... >>> >>> On Thu, Jan 22, 2015 at 8:18 PM, Connor Abbott wrote: What happens if you have something like foo = vec3(foo.z, bar.x, foo.x)

Re: [Mesa-dev] [PATCH] nir: Use pointers for nir_src_copy and nir_dest_copy

Reviewed-by: Connor Abbott On Fri, Jan 23, 2015 at 7:59 PM, Jason Ekstrand wrote: > This avoids the overhead of copying structures and better matches the newly > added nir_alu_src_copy and nir_alu_dest_copy. > --- > > This should be obvious, but this applies on top of Eric Anholt's patch to > ad

Re: [Mesa-dev] [PATCH 2/2] nir/opcodes: Don't go through doubles when constant-folding iabs

Jason Ekstrand writes: > On Mon, Jan 26, 2015 at 11:15 AM, Eric Anholt wrote: > >> Jason Ekstrand writes: >> >> > Previously, we called the abs() function in math.h. However, this >> involves >> > unnecessarily going through double. This commit changes it to use >> integers >> > directly with

Re: [Mesa-dev] [PATCH v2 1/3] nir: Add a pass to lower vector phi nodes to scalar phi nodes

Jason Ekstrand writes: > diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c > b/src/glsl/nir/nir_lower_phis_to_scalar.c > new file mode 100644 > index 000..9f901d6 > --- /dev/null > +++ b/src/glsl/nir/nir_lower_phis_to_scalar.c > @@ -0,0 +1,238 @@ > +/* > + * Copyright © 2014 Intel Corporat

Re: [Mesa-dev] [PATCH 1/2] nir/opcodes: Simplify and fix the unpack_half_*_split_* constant expressions

Indeed, I guess I misunderstood the purpose of this opcode when I was writing the constant expression. I see now that it's supposed to be used for scalarizing unpack_half_2x16. Goes to show how useful this self-documenting stuff is, I guess. Reviewed-by: Connor Abbott On Mon, Jan 26, 2015 at 12:

Re: [Mesa-dev] adding driver specific docs in src/gallium/docs?

On 01/26/2015 10:53 AM, Rob Clark wrote: Btw, I had started putting together some docs for freedreno "ir3" compiler.. I was originally just going to use markdown, but the graphviz plugin for sphinx is actually a bit too useful for this sort of thing to ignore. Otoh setting up a whole doc tree f

Re: [Mesa-dev] [PATCH] nir: Use pointers for nir_src_copy and nir_dest_copy

On Mon, Jan 26, 2015 at 10:45 AM, Eric Anholt wrote: > Jason Ekstrand writes: > > @@ -563,7 +557,7 @@ copy_deref_array(void *mem_ctx, nir_deref_array > *deref) > > ret->base_offset = deref->base_offset; > > ret->deref_array_type = deref->deref_array_type; > > if (deref->deref_array_t

Re: [Mesa-dev] [PATCH 2/2] nir/opcodes: Don't go through doubles when constant-folding iabs

On Mon, Jan 26, 2015 at 11:15 AM, Eric Anholt wrote: > Jason Ekstrand writes: > > > Previously, we called the abs() function in math.h. However, this > involves > > unnecessarily going through double. This commit changes it to use > integers > > directly with a ternary. > > Or just use fabs()?

Re: [Mesa-dev] [PATCH 2/2] nir/opcodes: Don't go through doubles when constant-folding iabs

Jason Ekstrand writes: > Previously, we called the abs() function in math.h. However, this involves > unnecessarily going through double. This commit changes it to use integers > directly with a ternary. Or just use fabs()? signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH 1/2] mesa: fix a trivial spelling mistake

On 01/26/2015 11:12 AM, Kenneth Graunke wrote: On Monday, January 26, 2015 07:52:46 AM Brian Paul wrote: On 01/19/2015 02:26 AM, Martin Peres wrote: On 19/01/15 11:25, Kenneth Graunke wrote: On Monday, January 19, 2015 10:52:05 AM Martin Peres wrote: Signed-off-by: Martin Peres --- src/m

Re: [Mesa-dev] [PATCH] nir: Use pointers for nir_src_copy and nir_dest_copy

Jason Ekstrand writes: > @@ -563,7 +557,7 @@ copy_deref_array(void *mem_ctx, nir_deref_array *deref) > ret->base_offset = deref->base_offset; > ret->deref_array_type = deref->deref_array_type; > if (deref->deref_array_type == nir_deref_array_type_indirect) { > - ret->indirect = ni

[Mesa-dev] [Bug 88720] Account request

https://bugs.freedesktop.org/show_bug.cgi?id=88720 Brian Paul changed: What|Removed |Added Component|Other |New Accounts Version|git

Re: [Mesa-dev] [PATCH 2/2] nir/opcodes: Don't go through doubles when constant-folding iabs

Reviewed-by: Connor Abbott On Mon, Jan 26, 2015 at 12:43 PM, Jason Ekstrand wrote: > Previously, we called the abs() function in math.h. However, this involves > unnecessarily going through double. This commit changes it to use integers > directly with a ternary. > --- > src/glsl/nir/nir_opco

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #26 from Jason Ekstrand --- I tried this on a pineview machine which is i915 not 865 but it works fine, so this doesn't look a generic driver change. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 1/2] mesa: fix a trivial spelling mistake

On Monday, January 26, 2015 07:52:46 AM Brian Paul wrote: > On 01/19/2015 02:26 AM, Martin Peres wrote: > > > > On 19/01/15 11:25, Kenneth Graunke wrote: > >> On Monday, January 19, 2015 10:52:05 AM Martin Peres wrote: > >>> Signed-off-by: Martin Peres > >>> --- > >>> src/mesa/main/feedback.c |

Re: [Mesa-dev] [PATCH] i965: Handle CMP.nz ... 0 and MOV.nz similarly in cmod propagation.

On Sat, Jan 24, 2015 at 4:16 AM, Kenneth Graunke wrote: > "MOV.nz null src" and "CMP.nz null src 0" are equivalent instructions. > > Previously, we deleted MOV.nz instructions when the instruction > generating the MOV's source also wrote the flag register (as the flag > register already contains t

[Mesa-dev] [Bug 88806] nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type

https://bugs.freedesktop.org/show_bug.cgi?id=88806 Bug ID: 88806 Summary: nir/nir_constant_expressions.c:2754:15: error: controlling expression type 'unsigned int' not compatible with any generic association type Product: Me

Re: [Mesa-dev] [PATCH] mesa: improve error messaging for format CSV parser

On Mon, Jan 26, 2015 at 2:35 AM, Tapani Pälli wrote: > Patch adds 2 error messages that point user directly to fix > mispelled or impossible swizzle field for a format. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/format_info.py | 2 +- > src/mesa/main/format_parser.py | 7 ++- >

[Mesa-dev] adding driver specific docs in src/gallium/docs?

Btw, I had started putting together some docs for freedreno "ir3" compiler.. I was originally just going to use markdown, but the graphviz plugin for sphinx is actually a bit too useful for this sort of thing to ignore. Otoh setting up a whole doc tree for one page seems a bit overkill. I wonder

[Mesa-dev] [PATCH 1/2] nir/opcodes: Simplify and fix the unpack_half_*_split_* constant expressions

Previously, these functions were explicitly writing to dst.x and dst.y. However they both return only one component so writing to dst.y is invalid. Also, since they only return one component, we don't need the explicit assignment in the expression and can simplify it use an implicit assignment. ---

[Mesa-dev] [PATCH 2/2] nir/opcodes: Don't go through doubles when constant-folding iabs

Previously, we called the abs() function in math.h. However, this involves unnecessarily going through double. This commit changes it to use integers directly with a ternary. --- src/glsl/nir/nir_opcodes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opco

Re: [Mesa-dev] [PATCH 4/4] i965: Implemente a tiled fast-path for glReadPixels and glGetTexImage

On 01/20/2015 12:09 PM, Jason Ekstrand wrote: > > > On Tue, Jan 13, 2015 at 10:44 AM, Chad Versace > mailto:chad.vers...@intel.com>> wrote: > > On 01/12/2015 10:22 AM, Jason Ekstrand wrote: >> From: Sisinty Sasmita Patra > > >> >> Added intel_readpixels_tiled_mem

[Mesa-dev] [Bug 85380] FTBFS in Clover: /usr/lib/llvm-3.6/include/llvm/Config/Targets.def:26: undefined reference to `LLVMInitialize*Target'

https://bugs.freedesktop.org/show_bug.cgi?id=85380 Kai changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from Kai --- I can confir

[Mesa-dev] [Bug 88783] FTBFS: Clover: src/gallium/state_trackers/clover/llvm/invocation.cpp:335:49: error: no matching function for call to 'llvm::TargetLibraryInfo::TargetLibraryInfo(llvm::Triple)

https://bugs.freedesktop.org/show_bug.cgi?id=88783 Kai changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from Kai --- I can confir

[Mesa-dev] [Bug 88783] FTBFS: Clover: src/gallium/state_trackers/clover/llvm/invocation.cpp:335:49: error: no matching function for call to 'llvm::TargetLibraryInfo::TargetLibraryInfo(llvm::Triple)

https://bugs.freedesktop.org/show_bug.cgi?id=88783 Jan Vesely changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 85380] FTBFS in Clover: /usr/lib/llvm-3.6/include/llvm/Config/Targets.def:26: undefined reference to `LLVMInitialize*Target'

https://bugs.freedesktop.org/show_bug.cgi?id=85380 Jan Vesely changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/6] meta: react to NULL pointers in create_texture_for_pbo()

On Jan 26, 2015 1:08 AM, "Juha-Pekka Heikkila" wrote: > > Check if null pointers were given and bail out. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/common/meta_tex_subimage.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/mesa/drivers/common/meta_tex_su

Re: [Mesa-dev] [PATCH 1/1] clover: Fix build with llvm after r226981

On Sun, Jan 25, 2015 at 04:11:40PM -0500, Jan Vesely wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88783 > Signed-off-by: Jan Vesely Pushed, thanks! > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/

Re: [Mesa-dev] [PATCH 1/2] mesa: fix a trivial spelling mistake

On 01/19/2015 02:26 AM, Martin Peres wrote: On 19/01/15 11:25, Kenneth Graunke wrote: On Monday, January 19, 2015 10:52:05 AM Martin Peres wrote: Signed-off-by: Martin Peres --- src/mesa/main/feedback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/feedb

[Mesa-dev] [PATCH] mesa: improve error messaging for format CSV parser

Patch adds 2 error messages that point user directly to fix mispelled or impossible swizzle field for a format. Signed-off-by: Tapani Pälli --- src/mesa/main/format_info.py | 2 +- src/mesa/main/format_parser.py | 7 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/me

Re: [Mesa-dev] [PATCH 3/6] meta: react to NULL pointers in create_texture_for_pbo()

On Monday, January 26, 2015 11:07:48 AM Juha-Pekka Heikkila wrote: > Check if null pointers were given and bail out. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/common/meta_tex_subimage.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/mesa/drivers/common

Re: [Mesa-dev] [PATCH 3/5] nir: add new constant folding infrastructure

On 20.01.2015 21:43, Jason Ekstrand wrote: > > > On Mon, Jan 19, 2015 at 5:01 PM, Connor Abbott > wrote: > > On Mon, Jan 19, 2015 at 4:04 PM, Jason Ekstrand > mailto:ja...@jlekstrand.net>> wrote: > > I've got some specific comments below, but I want to ma

Re: [Mesa-dev] [PATCH 6/6] nir: check malloc return value in print_block()

On Monday, January 26, 2015 11:07:51 AM Juha-Pekka Heikkila wrote: > report error on null return value and bail out. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/nir/nir_print.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_

Re: [Mesa-dev] [PATCH 4/6] util: in _mesa_set_create() mark error if out of memory

On Monday, January 26, 2015 11:07:49 AM Juha-Pekka Heikkila wrote: > added calls to _mesa_error_no_memory() if memory allocation > returned null pointer. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/util/set.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/s

[Mesa-dev] [PATCH 3/6] meta: react to NULL pointers in create_texture_for_pbo()

Check if null pointers were given and bail out. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/common/meta_tex_subimage.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c index 977ee5a..

[Mesa-dev] [PATCH 2/6] nir: Check in register_*_instr() after null pointers

If _mesa_set_create() return null there is low memory. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/nir/nir_lower_vars_to_ssa.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/nir_lower_vars_to_ssa.c b/src/glsl/nir/nir_lower_vars_to_ssa.c index 8af75

[Mesa-dev] [PATCH 6/6] nir: check malloc return value in print_block()

report error on null return value and bail out. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/nir/nir_print.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c index 9c07950..79c4cd8 100644 --- a/src/glsl/nir/nir_print.c +++ b/src/glsl

[Mesa-dev] [PATCH 5/6] nir: in insert_phi_nodes() check memory allocations succeeded.

Report memory error and bail out on failure. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/nir/nir_to_ssa.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/glsl/nir/nir_to_ssa.c b/src/glsl/nir/nir_to_ssa.c index 9c577fa..ccdbcf3 100644 --- a/src/gl

[Mesa-dev] [PATCH 0/6] Klocwork set again

Regular patch set about klocwork complaints to avoid segfaulting. /Juha-Pekka Juha-Pekka Heikkila (6): mesa/main: in _mesa_unpack_color_index_to_rgba_ubyte() check allocated pointers nir: Check in register_*_instr() after null pointers meta: react to NULL pointers in create_texture_for_

[Mesa-dev] [PATCH 4/6] util: in _mesa_set_create() mark error if out of memory

added calls to _mesa_error_no_memory() if memory allocation returned null pointer. Signed-off-by: Juha-Pekka Heikkila --- src/util/set.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/util/set.c b/src/util/set.c index c3252a0..b0baccc 100644 --- a/src/util/set.c +++

[Mesa-dev] [PATCH 1/6] mesa/main: in _mesa_unpack_color_index_to_rgba_ubyte() check allocated pointers

Check we really got memory we were asking for. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/pack.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index d1f368c..da2128d 100644 --- a/src/mesa/main/pack.c +++ b/src/mesa/main/pack.c @

Re: [Mesa-dev] [PATCH 02/11] glsl: Add link time checks for GLSL precision qualifiers

On Tue, 2015-01-20 at 12:34 +0100, Iago Toral wrote: > On Mon, 2015-01-19 at 19:39 -0800, Ian Romanick wrote: > > On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: > > > From: Iago Toral Quiroga > > > > > > Currently, we only consider precision qualifiers at compile-time. This > > > patch > > >