On Monday, February 02, 2015 10:28:22 PM Jason Ekstrand wrote:
> On Mon, Feb 2, 2015 at 9:08 PM, Kenneth Graunke
> wrote:
>
> > On Thursday, January 29, 2015 01:40:18 PM Jason Ekstrand wrote:
[snip]
> > > +static bool
> > > +is_phi_src_scalarizable(nir_phi_src *src,
> > > +
On Tue, Feb 3, 2015 at 1:54 AM, Connor Abbott wrote:
> This removes phi nodes whose sources all point to the same thing.
>
> Only compile tested.
>
> Signed-off-by: Connor Abbott
> ---
> src/glsl/Makefile.sources | 1 +
> src/glsl/nir/nir.h | 2 +
> src/glsl/nir/nir_
This removes phi nodes whose sources all point to the same thing.
Only compile tested.
Signed-off-by: Connor Abbott
---
src/glsl/Makefile.sources | 1 +
src/glsl/nir/nir.h | 2 +
src/glsl/nir/nir_opt_remove_phis.c | 111 +
3 files
Signed-off-by: Connor Abbott
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index de0d780..4305e14 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
+++ b/s
On Mon, Feb 2, 2015 at 9:08 PM, Kenneth Graunke
wrote:
> On Thursday, January 29, 2015 01:40:18 PM Jason Ekstrand wrote:
> [snip]
> > diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c
> b/src/glsl/nir/nir_lower_phis_to_scalar.c
> > new file mode 100644
> > index 000..bf65f5a
> > --- /dev/n
On Mon, Feb 2, 2015 at 10:00 PM, Kenneth Graunke
wrote:
> On Thursday, January 29, 2015 01:40:20 PM Jason Ekstrand wrote:
> > Originally, get_alu_src was supposed to handle resolving swizzles and
> > things like that. However, now that basically every instruction we have
> > only takes scalar so
On Thursday, January 29, 2015 01:40:20 PM Jason Ekstrand wrote:
> Originally, get_alu_src was supposed to handle resolving swizzles and
> things like that. However, now that basically every instruction we have
> only takes scalar sources, we don't really need it anymore. The only case
> where it'
On Thursday, January 29, 2015 01:40:19 PM Jason Ekstrand wrote:
> Now that we can scalarize with NIR, there's no need for all this code
> anymore. Let's get rid of it and just do scalar operations.
>
> v2: run copy prop before lowering phi nodes
>
> v3: Get rid of the "emit(...)->saturate = foo"
On Mon, 2015-02-02 at 13:22 -0800, Eric Anholt wrote:
> Thomas Helland writes:
>
> > 2015-02-02 19:18 GMT+01:00 Jason Ekstrand :
> >> Hi all,
> >> I wanted to send out a quick message about naming conventions for mesa
> >> entrypoints and dd table fallbacks. There has been some confusion and
> >
On Thursday, January 29, 2015 01:40:18 PM Jason Ekstrand wrote:
[snip]
> diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c
> b/src/glsl/nir/nir_lower_phis_to_scalar.c
> new file mode 100644
> index 000..bf65f5a
> --- /dev/null
> +++ b/src/glsl/nir/nir_lower_phis_to_scalar.c
> @@ -0,0 +1,278
From: Dave Airlie
Like the RGTC code sharing this could be done nicer in the util lib.
This slighty increase i965_dri.so size by ~100 bytes,
but it decreases the combined gallium driver by over 1k,
and its just nicer to avoid TAG().
Signed-off-by: Dave Airlie
---
src/gallium/auxiliary/util/u_
On Mon, Dec 8, 2014 at 9:50 PM, Ben Widawsky wrote:
> Thanks. All the requests look good, and I'll post it in v3.
What happened to this patch? It was pretty close... should be easy to
add gallium support for it too once it's in...
___
mesa-dev mailing l
https://bugs.freedesktop.org/show_bug.cgi?id=88930
Bug ID: 88930
Summary: [osmesa] osbuffer->textures should be indexed by
attachment type
Product: Mesa
Version: git
Hardware: All
OS: All
Status:
GLX_ARB_create_context spec says:
If either or are not a valid GLX drawable, a GLXBadDrawable
error is generated, unless and are both None and the OpenGL
version supported by is 3.0 or greater.
So when both and are None, it could pass NULL drawable into
driver instead of returing GLXBadDraw
Hi Felix,
On 2 February 2015 at 19:04, Felix Janda wrote:
> Previously PTHREAD_MUTEX_RECURSIVE_NP had been used on linux for
> compatibility with old glibc. Since mesa defines __GNU_SOURCE__
> on linux PTHREAD_MUTEX_RECURSIVE is also available since at least
> 1998. So we can unconditionally use
https://bugs.freedesktop.org/show_bug.cgi?id=0
--- Comment #1 from Matt Turner ---
Would be nice to explain why you decided the bug was invalid.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=79629
fangxun changed:
What|Removed |Added
Status|RESOLVED|VERIFIED
--- Comment #11 from fangxun ---
Ver
On Mon, Feb 2, 2015 at 5:30 PM, Ilia Mirkin wrote:
> Reviewed-by: Ilia Mirkin
>
> Oh well. Nothing requiring high throughput uses this afaik... constant
> folding in nouveau (for the relevant glsl instruction), that's
> probably about it. Would be nice to clarify the circumstances, but...
> wtvr.
Reviewed-by: Ilia Mirkin
Oh well. Nothing requiring high throughput uses this afaik... constant
folding in nouveau (for the relevant glsl instruction), that's
probably about it. Would be nice to clarify the circumstances, but...
wtvr. Cc 10.4 stable too?
On Mon, Feb 2, 2015 at 8:28 PM, Matt Turn
https://bugs.freedesktop.org/show_bug.cgi?id=79629
fangxun changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
---
src/glsl/list.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/list.h b/src/glsl/list.h
index 85368a4..6f1a57b 100644
--- a/src/glsl/list.h
+++ b/src/glsl/list.h
@@ -51,6 +51,10 @@
* Therefore, if \c head->next is \c NULL or \c tail_prev->prev is \c NULL,
* the list is em
Unclear circumstances lead to undefined symbols on x86.
Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=536916
---
src/gallium/auxiliary/util/u_math.h | 4
1 file changed, 4 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_math.h
b/src/gallium/auxiliary/util/u_math.h
index 19c7343.
Previously PTHREAD_MUTEX_RECURSIVE_NP had been used on linux for
compatibility with old glibc. Since mesa defines __GNU_SOURCE__
on linux PTHREAD_MUTEX_RECURSIVE is also available since at least
1998. So we can unconditionally use the portable version
PTHREAD_MUTEX_RECURSIVE.
---
Previous patch did
Emil Velikov, le Mon 02 Feb 2015 18:24:29 +, a écrit :
> Did you had the change to try the patch - does it cause issues on your
> setup (build and/or runtime-wise) ?
My setup has neither HAVE_LIBDRM nor HAVE_DRM_PLATFORM so it can't break
it :)
Samuel
_
On Mon, Feb 2, 2015 at 2:38 PM, Ian Romanick wrote:
> On 02/02/2015 07:18 PM, Jason Ekstrand wrote:
> > 1) The entrypoint itself (currently _mesa_EntryPoint)
> > 2) the internal entrypoint (Laura chose _mesa_entry_point)
> > 3) the software fallback for the DD table entry (Laura chose
> > _mes
Connor Abbott writes:
> A few comments here...
>
> 1. We should really split this up into a patch that adds
> nir_shader_compiler_options (which would be empty at this point) and
> the nir_algebraic infrastructure for conditionalizing transforms
> (actually, maybe we should split these up into tw
Connor Abbott writes:
> I mentioned this on IRC, but it would be good to add the ability to
> append the sequence of instructions before/after an instruction as
> well as at the beginning or end of a basic block. We would need to
> store the current basic block, the current instruction, and an en
This will be used to give the optimization passes a chance to customize
behavior for the particular target device.
---
I had things as one giant patch before because I thought you couldn't
have a struct with no members, and having a temporary version with a
dummy member seemed ugly. Turns out you
This will be used so that we can customize the transforms for the target
GPU, so we don't un-lower expressions that had already been lowered (or
introduce new lowering transformations that not all GPUs want)
---
src/glsl/nir/nir_algebraic.py | 44 ---
1 file
Mesa has a shader compiler struct flagging whether GLSL IR's opt_algebraic
and other passes should try and generate certain types of opcodes or
patterns. Extend that to NIR by defining our own struct, which is
automatically generated from the Mesa struct in glsl_to_nir and provided
directly by the
Erik Faye-Lund writes:
> On Sun, Feb 1, 2015 at 10:17 PM, Eric Anholt wrote:
>> This could be done in a separate pass like we do in GLSL IR, but it seems
>> to me like having the definitions of the transformations in the two
>> directions next to each other makes a lot of sense.
>> ---
>> src/g
A few comments here...
1. We should really split this up into a patch that adds
nir_shader_compiler_options (which would be empty at this point) and
the nir_algebraic infrastructure for conditionalizing transforms
(actually, maybe we should split these up into two patches) and a
patch which adds l
On 02/02/2015 07:18 PM, Jason Ekstrand wrote:
> 1) The entrypoint itself (currently _mesa_EntryPoint)
> 2) the internal entrypoint (Laura chose _mesa_entry_point)
> 3) the software fallback for the DD table entry (Laura chose
> _mesa_TableEntry_sw)
I already objected to _mesa_TableEntry_sw beca
On Mon, Feb 2, 2015 at 3:30 AM, Martin Peres
wrote:
> v2: review from Laura Ekstrand
> - use the refactored code to lookup the objects
> - improve some error messages
> - factor out the gl method name computation
> - better handle the spec differences between the DSA and non-DSA cases
> - quote t
On Mon, Feb 2, 2015 at 3:00 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - give more helpful error messages
> - factor the lookup code for the xfb and objBuf
> - replace some already-existing tabs with spaces
> - add comments to explain the cases where xfb == 0 or buffer == 0
> - fi
Oops, what I meant to say was "Make the bufferobj lookup function static."
The lookup transform feedback function doesn't have to be static.
On Mon, Feb 2, 2015 at 6:09 AM, Ilia Mirkin wrote:
> On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
> wrote:
> > +static struct gl_transform_feedback_object
On Mon, Feb 2, 2015 at 2:58 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - generate the name of the gl method once
> - shorten some lines to stay in the 78 chars limit
>
> v3: Review from Fredrik Höglund
> - rename gl_mthd_name to func
> - set EverBound in _mesa_create_transform_fe
Roland Scheidegger writes:
> Am 02.02.2015 um 20:39 schrieb Eric Anholt:
>> I wanted all of these for NIR-to-TGSI.
>> ---
>> src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 4
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
>> b/src/galliu
Thomas Helland writes:
> 2015-02-02 19:18 GMT+01:00 Jason Ekstrand :
>> Hi all,
>> I wanted to send out a quick message about naming conventions for mesa
>> entrypoints and dd table fallbacks. There has been some confusion and
>> disagreement about this with some of the stuff Laura has been doin
On 02/02/2015 12:49 PM, Laura Ekstrand wrote:
After a very thorough search, I did find two lines in i965/intel_fbo.c
that had ctx->DrawBuffer when they were supposed to have drawFb. Here's
the new commit:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=d9d7e65cd6a0fe2c8648
Am 02.02.2015 um 20:39 schrieb Eric Anholt:
> I wanted all of these for NIR-to-TGSI.
> ---
> src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
> b/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
> i
Francisco Jerez writes:
> Eric Anholt writes:
>
>> Francisco Jerez writes:
>>
>>> This reverts commit 3fad0868f023f1d726e230968a4df3327de38823.
>>>
>>> This test doesn't make any sense to me, it begins quoting the GLSL
>>> 1.30 spec on the interaction of the discard keyword with control flow:
>
2015-02-02 19:18 GMT+01:00 Jason Ekstrand :
> Hi all,
> I wanted to send out a quick message about naming conventions for mesa
> entrypoints and dd table fallbacks. There has been some confusion and
> disagreement about this with some of the stuff Laura has been doing to
> implement DSA. Instead
https://bugs.freedesktop.org/show_bug.cgi?id=0
Heinrich Schuchardt changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
After a very thorough search, I did find two lines in i965/intel_fbo.c that
had ctx->DrawBuffer when they were supposed to have drawFb. Here's the new
commit:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=d9d7e65cd6a0fe2c864803a77e34d0f52e8609b6
.
_
I wanted all of these for NIR-to-TGSI.
---
src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
b/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
index 147d989..d8752ce 100644
--- a/src/gallium/auxiliary/tgs
Eric Anholt writes:
> Francisco Jerez writes:
>
>> This reverts commit 3fad0868f023f1d726e230968a4df3327de38823.
>>
>> This test doesn't make any sense to me, it begins quoting the GLSL
>> 1.30 spec on the interaction of the discard keyword with control flow:
>>
>> "[...] Control flow exits the
I wanted to use it for nir-to-tgsi. The equivalent ureg_src_register() is
also located here.
---
src/gallium/auxiliary/tgsi/tgsi_ureg.c | 28
src/gallium/auxiliary/tgsi/tgsi_ureg.h | 25 +
2 files changed, 25 insertions(+), 28 deletions(-)
dif
On 02/02/2015 12:22 PM, Eric Anholt wrote:
Jason Ekstrand writes:
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks. There has been some confusion and
disagreement about this with some of the stuff Laura has been doing to
impleme
Jason Ekstrand writes:
> Hi all,
> I wanted to send out a quick message about naming conventions for mesa
> entrypoints and dd table fallbacks. There has been some confusion and
> disagreement about this with some of the stuff Laura has been doing to
> implement DSA. Instead of side-track one o
I broke out some of the whitespace:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=ebe159fa9a6b1d98d63862bf89044028e67a4377
.
Here is the (hopefully cleaner) BlitFramebuffers refactor:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=fc85665eaa9aff8240
On 22/01/15 20:53, Samuel Thibault wrote:
> Emil Velikov, le Thu 22 Jan 2015 16:52:06 +, a écrit :
>> On 14/01/15 19:36, Axel Davy wrote:
>>> To fix build when libdrm is not found,
>>> commit a594cec7e3ef275c386054127a357110a19dd823 did put several
>>> parts of egl code under #ifdef HAVE_DRM_PL
Hi all,
I wanted to send out a quick message about naming conventions for mesa
entrypoints and dd table fallbacks. There has been some confusion and
disagreement about this with some of the stuff Laura has been doing to
implement DSA. Instead of side-track one of those patches for this
discussion
On Mon, Feb 2, 2015 at 9:53 AM, Jason Ekstrand wrote:
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88841
> ---
> src/mesa/drivers/dri/i965/intel_pixel_read.c | 7 +++
> src/mesa/drivers/dri/i965/intel_tex_image.c | 7 +++
> 2 files changed, 14 insertions(+)
>
> diff --git a
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88841
---
src/mesa/drivers/dri/i965/intel_pixel_read.c | 7 +++
src/mesa/drivers/dri/i965/intel_tex_image.c | 7 +++
2 files changed, 14 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c
b/src/mesa/drivers/dri/
Actually, since ARB_robust_buffer_access_behavior, GL requires some
specfic values, but it's - odd...
"In all the above cases, if the context was created with robust buffer
access enabled then instead of undefined behavior the result of the
texel fetch is zero. For the case of a texel fetch on an i
Acked-by: Brian Paul
On 01/29/2015 02:11 PM, Rob Clark wrote:
From: Rob Clark
Enable the 'sphinx.ext.graphviz' extension, and add in a section for
driver specific docs, with freedreno compiler docs beneath. The
goal is for more complete compiler docs, and hopefully some docs about
other part
I'd have put the swrast whitespace changes in a separate commit, but
it's not a big deal.
Reviewed-by: Brian Paul
On 01/30/2015 05:25 PM, Laura Ekstrand wrote:
In preparation for glBlitNamedFramebuffer, the DD table function
BlitFramebuffer needs to accept two arbitrary framebuffer objects r
I don't think this is really correct. llvmpipe will return all zeros on
purpose, because this is d3d10 behavior (and dummy textures cannot work
correctly with d3d10). Traditionally both d3d9 and gl state trackers
used dummy textures, though I'm unsure what values they required (if
any). (For d3d9 t
For 1-4, Reviewed-by: Brian Paul
On 02/01/2015 10:15 AM, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/auxiliary/tgsi/tgsi_parse.c | 12
src/gallium/auxiliary/tgsi/tgsi_parse.h | 2 ++
src/gallium/drivers/radeon/r600_pipe_common.c | 11 ---
3 file
Please add some bit about this in screen.rst gallium docs.
Other than that 4/6 and 5/6 are
Reviewed-by: Roland Scheidegger
Am 01.02.2015 um 16:18 schrieb Ilia Mirkin:
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
> src/gallium/drivers/i915/i915_scr
On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
wrote:
> +static struct gl_transform_feedback_object *
> +_mesa_lookup_transform_feedback_object_err(struct gl_context *ctx,
> + GLuint xfb, const char* func)
> +{
> + struct gl_transform_feedback_object *obj;
On 02/02/15 11:54, Michel Dänzer wrote:
On 30.01.2015 23:19, Martin Peres wrote:
When both MESA_EXTENSION_OVERRIDE and drirc's mesa_extension_override are
set, the environment variable takes precedence.
This will be used to fix Unigine Tropics and Sanctuary.
Signed-off-by: Martin Peres
[...
On 30/01/15 23:20, Marek Olšák wrote:
The commit message prefix should be "intel:" in this case.
Marek
Fair point, it will be in v2.
Thanks,
Martin
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On Sun, Feb 1, 2015 at 10:17 PM, Eric Anholt wrote:
> This could be done in a separate pass like we do in GLSL IR, but it seems
> to me like having the definitions of the transformations in the two
> directions next to each other makes a lot of sense.
> ---
> src/glsl/nir/nir_opt_algebraic.py | 1
v2: review from Laura Ekstrand
- use the refactored code to lookup the objects
- improve some error messages
- factor out the gl method name computation
- better handle the spec differences between the DSA and non-DSA cases
- quote the spec a little more
v3: review from Laura Ekstrand
- use the ne
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
v3: Revie
v2: Review from Laura Ekstrand
- generate the name of the gl method once
- shorten some lines to stay in the 78 chars limit
v3: Review from Fredrik Höglund
- rename gl_mthd_name to func
- set EverBound in _mesa_create_transform_feedbacks in the dsa case
Signed-off-by: Martin Peres
---
src/mapi
On 30.01.2015 23:19, Martin Peres wrote:
> When both MESA_EXTENSION_OVERRIDE and drirc's mesa_extension_override are
> set, the environment variable takes precedence.
>
> This will be used to fix Unigine Tropics and Sanctuary.
>
> Signed-off-by: Martin Peres
[...]
> diff --git a/src/mesa/drive
You're welcome Marek. Let's not keep these workarounds specific to some
drivers ;)
In any case, please review the new version, the one called "introduce
the equivalent of MESA_EXTENSION_OVERRIDE to drirc". I prefer this
solution better and this one should be dropped.
Sorry for the noise.
Mar
On 02.02.2015 02:37, Marek Olšák wrote:
> From: Marek Olšák
>
> The stipple texture is bound to slot 16, so there are 17 sampler states and
> 34 sampler views now (17 normal slots + 17 fmask slots).
[...]
> @@ -2742,16 +2743,26 @@ static int si_generate_gs_copy_shader(struct
> si_screen *sscre
On 01.02.2015 01:45, Neil Roberts wrote:
> This limits the style changes to modes inherited from prog-mode. The
> main reason to do this is to avoid setting fill-column for people
> using Emacs to edit commit messages because 78 characters is too many
> to make it wrap properly in git log. Note tha
72 matches
Mail list logo
