Re: [Mesa-dev] [PATCH] glsl/fp64: disable varying packing for doubles. (v2)

2015-02-21 Thread Marek Olšák
Hi Dave, I think transform feedback doesn't work without the varying packing. Cc'ing Paul Berry. Marek On Fri, Feb 20, 2015 at 5:03 AM, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure we really care about this, but we need to > write better support if we do. For now just disable it. >

[Mesa-dev] Mesa 10.4.5

2015-02-21 Thread Emil Velikov
Mesa 10.4.5 has been released. Mesa 10.4.5 is a bug fix release fixing bugs since the 10.4.4 release, (see below for a list of changes). The tag in the git repository for Mesa 10.4.5 is 'mesa-10.4.5'. Mesa 10.4.5 is available for download at ftp://freedesktop.org/pub/mesa/10.4.5/ SHA-256 checksu

[Mesa-dev] [PATCH 2/2] glsl: ensure that enter/leave record get a record type

2015-02-21 Thread Ilia Mirkin
May make life easier for tools like Coverity. Signed-off-by: Ilia Mirkin --- src/glsl/link_uniform_blocks.cpp | 2 ++ src/glsl/link_uniforms.cpp | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/glsl/link_uniform_blocks.cpp b/src/glsl/link_uniform_blocks.cpp index 1c175ec..4c28b56

[Mesa-dev] [PATCH 1/2] tgsi: avoid returning pointer to local var

2015-02-21 Thread Ilia Mirkin
Spotted by Coverity. Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index a8fc008..1c08e35 100644 --- a/src/gallium/auxili

[Mesa-dev] [RFC] loader: not having a pci-id should not be a warn

2015-02-21 Thread Rob Clark
From: Rob Clark Lower this to an info message, to avoid confusing users. Perhaps we should just drop this entirely. --- Anyone have any objection to this, or better suggestions? Users are getting confused by this warning messange, and we do actually have non-PCI drivers these days ;-) src/loa

Re: [Mesa-dev] [RFC] loader: not having a pci-id should not be a warn

2015-02-21 Thread Ilia Mirkin
On Sat, Feb 21, 2015 at 2:48 PM, Rob Clark wrote: > From: Rob Clark > > Lower this to an info message, to avoid confusing users. Perhaps we > should just drop this entirely. > --- > Anyone have any objection to this, or better suggestions? Users are > getting confused by this warning messange,

Re: [Mesa-dev] [RFC] loader: not having a pci-id should not be a warn

2015-02-21 Thread Rob Clark
On Sat, Feb 21, 2015 at 3:27 PM, Ilia Mirkin wrote: > On Sat, Feb 21, 2015 at 2:48 PM, Rob Clark wrote: >> From: Rob Clark >> >> Lower this to an info message, to avoid confusing users. Perhaps we >> should just drop this entirely. >> --- >> Anyone have any objection to this, or better suggesti

Re: [Mesa-dev] [PATCH 1/2] tgsi: avoid returning pointer to local var

2015-02-21 Thread Marek Olšák
For this patch: Reviewed-by: Marek Olšák Marek On Sat, Feb 21, 2015 at 7:54 PM, Ilia Mirkin wrote: > Spotted by Coverity. > > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_exec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxil

Re: [Mesa-dev] [PATCH] drivers/x11: add gallium include dirs to Makefile.am

2015-02-21 Thread Kenneth Graunke
On Friday, February 20, 2015 01:20:25 PM Brian Paul wrote: > Fixes xlib driver build after e8c5cbfd921680c. > --- > src/mesa/drivers/x11/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/x11/Makefile.am > b/src/mesa/drivers/x11/Makefile.am > index 76a7cd4..c

Re: [Mesa-dev] [PATCH 1/2] tgsi: avoid returning pointer to local var

2015-02-21 Thread Matt Turner
On Sat, Feb 21, 2015 at 10:54 AM, Ilia Mirkin wrote: > Spotted by Coverity. > > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_exec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c > b/src/gallium/auxiliary/t

Re: [Mesa-dev] [PATCH 2/2] glsl: ensure that enter/leave record get a record type

2015-02-21 Thread Matt Turner
On Sat, Feb 21, 2015 at 10:54 AM, Ilia Mirkin wrote: > May make life easier for tools like Coverity. > > Signed-off-by: Ilia Mirkin > --- > src/glsl/link_uniform_blocks.cpp | 2 ++ > src/glsl/link_uniforms.cpp | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/src/glsl/link_unifor

Re: [Mesa-dev] [PATCH 2/3] i965/fs/nir: Optimize (gl_FrontFacing ? x : y) where x and y are ±1.0.

2015-02-21 Thread Eric Anholt
Matt Turner writes: > On Fri, Feb 20, 2015 at 1:41 PM, Eric Anholt wrote: >>> Or maybe I'm just wrong and some bit is guaranteed to be set? >> >> A "This negation looks like it's safe in practice, because bits 0:4 will >> surely be TRIANGLES" comment seems fine with me. > > Thanks, will do. R-b?

[Mesa-dev] [PATCH] nir/gcm: Add some missing break statements

2015-02-21 Thread Jason Ekstrand
--- src/glsl/nir/nir_opt_gcm.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_opt_gcm.c b/src/glsl/nir/nir_opt_gcm.c index bf565b9..b4f5fd3 100644 --- a/src/glsl/nir/nir_opt_gcm.c +++ b/src/glsl/nir/nir_opt_gcm.c @@ -121,9 +121,11 @@ gcm_pin_instructions_block(nir_block *

[Mesa-dev] [PATCH] i965: Link test programs with gtest before pthreads.

2015-02-21 Thread Matt Turner
Cc: "10.5" Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=540962 --- src/mesa/drivers/dri/i965/Makefile.am | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index 9230a49..23