[Mesa-dev] [Bug 88885] Transform feedback uses incorrect interleaving if a previous draw did not write gl_Position

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=5 --- Comment #3 from Tapani Pälli --- Thanks Chris! This commit has fixed also rendering issues with some of the heavyweight UE4 demos where we had 'yellow tint' colors. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [PATCH V2 06/12] glsl: dont allow gl_PerVertex to be redeclared as an array of arrays

2015-03-23 Thread Timothy Arceri
V2: move single dimensionial array detection into a helper Signed-off-by: Timothy Arceri --- src/glsl/ast.h | 8 src/glsl/ast_to_hir.cpp | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast.h b/src/glsl/ast.h index ef74e51..3f67907 100644 --- a/s

Re: [Mesa-dev] [PATCH 1/2] configure.ac: move AC_MSG_RESULT reportging back into the m4 macro

2015-03-23 Thread Samuel Iglesias Gonsálvez
Thanks Emil! Reviewed-by: Samuel Iglesias Gonsalvez Sam On Monday 23 March 2015 17:49:23 Emil Velikov wrote: > The one who does AC_MSG_CHECKING should provide the AC_MSG_RESULT. > > Fixed: ced9425327b (configure: Introduce new output variable to > ax_check_python_mako_module.m4" > Cc: Samuel I

Re: [Mesa-dev] [PATCH] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

2015-03-23 Thread Zhang, Xiong Y
> You seem to miss the case when one is None and not the other. > It should return BadDrawable too. > > This particular case seems not handled by the dri2 code either, and the > gallium > state tracker seems to handle it in bindContext, but not the intel code for > example. [Zhang, Xiong Y] For

Re: [Mesa-dev] [PATCH] mesa: add OES_EGL_image_external_essl3 support

2015-03-23 Thread Tapani Pälli
On 03/23/2015 02:41 PM, Ilia Mirkin wrote: On Mon, Mar 23, 2015 at 8:06 AM, Tapani Pälli wrote: On 03/23/2015 01:43 PM, Ilia Mirkin wrote: On Mon, Mar 23, 2015 at 3:20 AM, Tapani Pälli wrote: On 03/22/2015 12:07 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- Not sure what

[Mesa-dev] [PATCH] mesa/state_tracker: Fix draw-pixel-with-texture piglit test.

2015-03-23 Thread Matthew Dawson
When glDrawPixels was used with an external texture, the pixels passed in were sampled instead of the texture. Change gallium to instead move the user texture to a new sampler below the glDrawPixels samplers and use the texture coordinates from the raster position. This uses a uniform for the tex

[Mesa-dev] [Bug 89705] lp_bld_debug.cpp:280:54: error: no matching function for call to ‘llvm?=::TargetMachine::getSubtargetImpl()=?UTF-8?Q?’

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89705 --- Comment #5 from Dieter Nützel --- (In reply to Tom Stellard from comment #4) > Fixed in git: 769b366b83dcc12bfe06935f816023cdcfbdf578 Works fine on NI/Turks XT, here. Could be closed for my side. Thanks Tom! -- You are receiving this mail

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-23 Thread Kenneth Graunke
On Monday, March 23, 2015 05:02:51 PM Aaron Watry wrote: > On a related note, > > Has anyone ported shader-db over to working on R600/RadeonSI/ non-intel>? I've been meaning to take a look at the NIR->TGSI pass and see > if there's an easy way to hook it up to the radeon drivers, but I wanted to

Re: [Mesa-dev] [PATCH] nir: Handle vector arguments to logical and/or/xor.

2015-03-23 Thread Matt Turner
On Mon, Mar 23, 2015 at 5:10 PM, Matt Turner wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 39 +-- > 1 file changed, 21 insertions(+), 18 deletions(-) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp > index 357944d..e6f5ffc 100644 >

Re: [Mesa-dev] [PATCH 4/9] nir: Move the compare-with-zero optimizations to the late section

2015-03-23 Thread Jason Ekstrand
On Mon, Mar 23, 2015 at 8:34 PM, Matt Turner wrote: > On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand wrote: >> total instructions in shared programs: 4422307 -> 4422363 (0.00%) >> instructions in affected programs: 4230 -> 4286 (1.32%) >> helped:0 >> HURT:

Re: [Mesa-dev] [PATCH 8/9] i965/nir: Run the ffma peephole after the rest of the optimizations

2015-03-23 Thread Jason Ekstrand
On Mon, Mar 23, 2015 at 8:34 PM, Matt Turner wrote: > On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand wrote: >> The idea here is that fusing multiply-add combinations too early can reduce >> our ability to perform CSE and value-numbering. Instead, we split ffma >> opcodes up-front, hope CSE clea

Re: [Mesa-dev] [PATCH 8/9] i965/nir: Run the ffma peephole after the rest of the optimizations

2015-03-23 Thread Matt Turner
On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand wrote: > The idea here is that fusing multiply-add combinations too early can reduce > our ability to perform CSE and value-numbering. Instead, we split ffma > opcodes up-front, hope CSE cleans up, and then fuse after-the-fact. > Unless an algebraic

Re: [Mesa-dev] [PATCH 4/9] nir: Move the compare-with-zero optimizations to the late section

2015-03-23 Thread Matt Turner
On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand wrote: > total instructions in shared programs: 4422307 -> 4422363 (0.00%) > instructions in affected programs: 4230 -> 4286 (1.32%) > helped:0 > HURT: 12 > > While this does hurt s

Re: [Mesa-dev] [PATCH 7/9] nir/peephole_ffma: Be less agressive about fusing multiply-adds

2015-03-23 Thread Matt Turner
On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand wrote: > shader-db results for fragment shaders on Haswell: > total instructions in shared programs: 4395688 -> 4389623 (-0.14%) > instructions in affected programs: 355876 -> 349811 (-1.70%) > helped:1455 > HURT:

Re: [Mesa-dev] [PATCH 2/9] nir/algebraic: Add a seperate section for "late" optimizations

2015-03-23 Thread Matt Turner
On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand wrote: > --- Subject: s/seperate/separate/ I'd probably just squash patch 3 into this one. I bet this will be useful for something I'm working on too. :) ___ mesa-dev mailing list mesa-dev@lists.freedesk

[Mesa-dev] [PATCH 9/9] i965: Use the same nir options for all gens

2015-03-23 Thread Jason Ekstrand
If we tell NIR to split ffma's, then we don't need seperate options anymore. --- src/mesa/drivers/dri/i965/brw_context.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 7cab1c

[Mesa-dev] [PATCH 8/9] i965/nir: Run the ffma peephole after the rest of the optimizations

2015-03-23 Thread Jason Ekstrand
The idea here is that fusing multiply-add combinations too early can reduce our ability to perform CSE and value-numbering. Instead, we split ffma opcodes up-front, hope CSE cleans up, and then fuse after-the-fact. Unless an algebraic pass does something silly where it inserts something between th

[Mesa-dev] [PATCH 7/9] nir/peephole_ffma: Be less agressive about fusing multiply-adds

2015-03-23 Thread Jason Ekstrand
shader-db results for fragment shaders on Haswell: total instructions in shared programs: 4395688 -> 4389623 (-0.14%) instructions in affected programs: 355876 -> 349811 (-1.70%) helped:1455 HURT: 14 GAINED:

[Mesa-dev] [PATCH 4/9] nir: Move the compare-with-zero optimizations to the late section

2015-03-23 Thread Jason Ekstrand
total instructions in shared programs: 4422307 -> 4422363 (0.00%) instructions in affected programs: 4230 -> 4286 (1.32%) helped:0 HURT: 12 While this does hurt some things, the losses are minor and it prevents the compare-with-z

[Mesa-dev] [PATCH 1/9] nir/algebraic: #define around structure definitions

2015-03-23 Thread Jason Ekstrand
Previously, we couldn't generate two algebraic passes in the same file because of multiple structure definitions. To solve this, we play the age-old header file trick and just #define around it. --- src/glsl/nir/nir_algebraic.py | 17 +++-- 1 file changed, 11 insertions(+), 6 deletion

[Mesa-dev] [PATCH 0/9] NIR: Several optimization patches

2015-03-23 Thread Jason Ekstrand
This series contains several optimization-related patches that are all focussed around being able to do better at emitting MAD instructions. Final shader-db results for the whole series on Haswell: total NIR instructions in shared programs: 2183472 -> 2152911 (-1.40%) NIR instructions in af

[Mesa-dev] [PATCH 3/9] i965/nir: Use the late optimizations

2015-03-23 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 69f296c..fbcfc65 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 5/9] nir: Add a dedicated ffma peephole optimization

2015-03-23 Thread Jason Ekstrand
--- src/glsl/Makefile.sources| 1 + src/glsl/nir/nir_opt_peephole_ffma.c | 220 +++ 2 files changed, 221 insertions(+) create mode 100644 src/glsl/nir/nir_opt_peephole_ffma.c diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.sources index b8

[Mesa-dev] [PATCH 2/9] nir/algebraic: Add a seperate section for "late" optimizations

2015-03-23 Thread Jason Ekstrand
--- src/glsl/nir/nir.h| 1 + src/glsl/nir/nir_opt_algebraic.py | 9 + 2 files changed, 10 insertions(+) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 29fe942..d5ecfa8 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -1612,6 +1612,7 @@ void nir_conve

[Mesa-dev] [PATCH 6/9] i965/nir: Use the dedicated ffma peephole

2015-03-23 Thread Jason Ekstrand
total instructions in shared programs: 4418748 -> 4394618 (-0.55%) instructions in affected programs: 1292790 -> 1268660 (-1.87%) helped:5999 HURT: 457 GAINED:4 LOST:

[Mesa-dev] [Bug 89689] [Regression] Weston on DRM backend won't start with new version of mesa

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89689 Michel Dänzer changed: What|Removed |Added Component|EGL |Drivers/DRI/i965 Assignee|mesa

[Mesa-dev] Project Ideas for Google Summer of Code

2015-03-23 Thread kingue patrick
Hello, I am a computer engineering student from the university of Buea in Cameroon, Africa. I mostly got interested in the following project ideas : - GL/GLSL tests for GL 4.0 and newer - Port optimization passes from GLSL IR to NIR And i wanted to inquire about the possibility of working on one of

[Mesa-dev] [PATCH 2/6] nir: Implement a Mesa IR -> NIR translator.

2015-03-23 Thread Kenneth Graunke
Shamelessly ripped off from Eric Anholt's tgsi_to_nir pass. Not compiled on SCons, like the rest of NIR. Signed-off-by: Kenneth Graunke --- src/mesa/Makefile.am|2 + src/mesa/Makefile.sources |5 + src/mesa/program/prog_instruction.h |2 + src/mesa/program/

[Mesa-dev] [PATCH 1/6] nir: Add glsl_float_type() wrapper.

2015-03-23 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_types.cpp | 6 ++ src/glsl/nir/nir_types.h | 1 + 2 files changed, 7 insertions(+) Patches also available in the `nir-arb` branch of ~kwg/mesa. diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp index a13c3e1..f0d0b46 1

[Mesa-dev] [PATCH 6/6] i965/nir: Use NIR for ARB_vertex_program support on Gen8+.

2015-03-23 Thread Kenneth Graunke
Everything is already in place; we simply have to take the scalar code generation path. This gives us SIMD8 VS programs, instead of SIMD4x2. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --gi

[Mesa-dev] [PATCH 4/6] i965/fs: Implement texture projection support.

2015-03-23 Thread Kenneth Graunke
Our fragment program backend implements support for TXP directly, and there's no NIR lowering pass to remove the projection. When we switch fragment program support over to NIR, we need to support it somehow. It's easy enough to support directly. Signed-off-by: Kenneth Graunke --- src/mesa/dri

[Mesa-dev] [PATCH 5/6] i965/fs: Add ARB_fragment_program support to the NIR backend.

2015-03-23 Thread Kenneth Graunke
Use prog_to_nir where we would normally call glsl_to_nir, handle program parameter lists, and skip a few things that don't exist. Using NIR generates much better shader code than Mesa IR, since we get real optimizations, as opposed to prog_optimize: total instructions in shared programs: 314007 -

[Mesa-dev] [PATCH 3/6] i965/fs: Implement nir_opcode_fsub/isub support.

2015-03-23 Thread Kenneth Graunke
prog_to_nir uses this for OPCODE_SUB. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 69f296c..094303f 100644 --- a/src

[Mesa-dev] [Bug 89689] [Regression] Weston on DRM backend won't start with new version of mesa

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89689 --- Comment #5 from Boyan Ding --- (In reply to Daniel Stone from comment #4) > Have you tried just adding XRGB to the list without modifying depth/stencil? I tried just now and it also works. -- You are receiving this mail because: You are th

[Mesa-dev] [PATCH] nir: Handle vector arguments to logical and/or/xor.

2015-03-23 Thread Matt Turner
--- src/glsl/nir/glsl_to_nir.cpp | 39 +-- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 357944d..e6f5ffc 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir

Re: [Mesa-dev] [PATCH 1/5] glsl: Allow vector logic ops to be generated.

2015-03-23 Thread Matt Turner
On Wed, Mar 18, 2015 at 6:30 PM, Connor Abbott wrote: > So in GLSL, add and mul can take a combination of a scalar and a > vector, and it'll splat the scalar automatically, and with this this > series that means that and/or can now take a combination of a scalar > and a vector as well, and we'll h

Re: [Mesa-dev] OpenGL ES 3.0 support

2015-03-23 Thread Rob Clark
On Mon, Mar 23, 2015 at 3:59 PM, Ilia Mirkin wrote: > On Mon, Mar 23, 2015 at 3:57 PM, Shervin Sharifi wrote: >> Hi, >> >> I'm new to Mesa and I'm trying to understand the status of OpenGL ES 3.0 >> support in Mesa. >> I'm mainly interested in using llvm-pipe backend (software rendering). > > h

Re: [Mesa-dev] [PATCH v3 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

2015-03-23 Thread Laura Ekstrand
On Mon, Mar 23, 2015 at 12:14 PM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - get rid of a change that should not have happened in this patch > - improve the error messages > - fix alignments > - fix a capitalization in a function name in an error message > > v3: Review from Laura Ek

Re: [Mesa-dev] [PATCH] i965/fs: Fix inverted comparison

2015-03-23 Thread Kenneth Graunke
On Monday, March 23, 2015 12:15:17 PM Ian Romanick wrote: > From: Ian Romanick > > Commit b616164 added an optimization of b2f generation of a comparison. > It also included an extra optimization of one of the comparison values > is a constant of zero. The trick was that some value was known to

Re: [Mesa-dev] [PATCH v3 15/17] main: Added entry point for glGetNamedRenderbufferParameteriv

2015-03-23 Thread Laura Ekstrand
On Mon, Mar 23, 2015 at 12:04 PM, Martin Peres wrote: > v2: > - improve an error message > > Reviewed-by: Laura Ekstrand > > v3: > - move a test to less generic functions > - fix an alignment > > Signed-off-by: Martin Peres > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ > src

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-23 Thread Ilia Mirkin
On Mon, Mar 23, 2015 at 6:02 PM, Aaron Watry wrote: > On a related note, > > Has anyone ported shader-db over to working on R600/RadeonSI/ non-intel>? I've been meaning to take a look at the NIR->TGSI pass and see > if there's an easy way to hook it up to the radeon drivers, but I wanted to > be

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-23 Thread Aaron Watry
On a related note, On Mon, Mar 23, 2015 at 2:19 PM, Jason Ekstrand wrote: > On Mon, Mar 23, 2015 at 11:19 AM, Bruno Jimenez > wrote: > > On Wed, 2015-03-18 at 16:37 -0700, Jason Ekstrand wrote: > >> On Wed, Mar 18, 2015 at 4:27 PM, Connor Abbott > wrote: > >> > On Wed, Mar 18, 2015 at 2:58 PM,

Re: [Mesa-dev] [RFC PATCH 06/12] glsl: dont allow gl_PerVertex to be redeclared as an array of arrays

2015-03-23 Thread Timothy Arceri
On Mon, 2015-03-23 at 08:58 -0400, Ilia Mirkin wrote: > On Sat, Mar 21, 2015 at 11:00 PM, Timothy Arceri > wrote: > > On Sat, 2015-03-21 at 19:34 -0400, Ilia Mirkin wrote: > >> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri > >> wrote: > >> > Signed-off-by: Timothy Arceri > >> > --- > >> > s

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-23 Thread Ian Romanick
On 03/19/2015 12:28 AM, Martin Peres wrote: > On 16/03/15 18:32, Laura Ekstrand wrote: >> That was basically my background (mechanical engineering + lots of >> OpenGL) when I started six months ago, but I have found the lack of >> mentoring to be a large roadblock. At that time, I wrote tests, but

Re: [Mesa-dev] [PATCH 1/1] Fix runtime error with uClibc

2015-03-23 Thread Bernd Kuhls
Matt Turner wrote in news:caedq38ela86kqtjkagscovt70ep8ato3aeqtowbuvk-+xuf...@mail.gmail.com: > so maybe uclibc just needs to add them. Hi, they did :) http://git.uclibc.org/uClibc/commit/?id= 6c4538905e65ceb203f59aaa9a61728e81c6bc0a Run-time testing was positive, so my patch is obsolete now.

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #11 from Tom Stellard --- Are these these same patches you sent to the mailing list? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mes

Re: [Mesa-dev] Correct behaviour of glDrawPixels and glBitmap when texturing is enabled.

2015-03-23 Thread Brian Paul
On 03/23/2015 01:28 PM, Matthew Dawson wrote: On March 23, 2015 10:21:32 AM Brian Paul wrote: On 03/22/2015 05:50 PM, Matthew Dawson wrote: If it isn't fully realized, is it worth it to test/implement this section, since its removed in the core profile? Would a reduced implementation to fix th

Re: [Mesa-dev] OpenGL ES 3.0 support

2015-03-23 Thread Ilia Mirkin
On Mon, Mar 23, 2015 at 3:57 PM, Shervin Sharifi wrote: > Hi, > > I'm new to Mesa and I'm trying to understand the status of OpenGL ES 3.0 > support in Mesa. > I'm mainly interested in using llvm-pipe backend (software rendering). http://people.freedesktop.org/~imirkin/glxinfo/glxinfo.html#p=es

[Mesa-dev] OpenGL ES 3.0 support

2015-03-23 Thread Shervin Sharifi
Hi, I'm new to Mesa and I'm trying to understand the status of OpenGL ES 3.0 support in Mesa. I'm mainly interested in using llvm-pipe backend (software rendering). Thanks, Shervin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://l

Re: [Mesa-dev] [PATCH] i965/fs: Fix inverted comparison

2015-03-23 Thread Ian Romanick
Arg. I changed the code and the body of the commit message, but I didn't change the short log. I'll change it to: i965/fs: Always invert predicate of SEL with swapped arguments On 03/23/2015 12:15 PM, Ian Romanick wrote: > From: Ian Romanick > > Commit b616164 added an optimization of b2f gen

Re: [Mesa-dev] Correct behaviour of glDrawPixels and glBitmap when texturing is enabled.

2015-03-23 Thread Matthew Dawson
On March 23, 2015 10:21:32 AM Brian Paul wrote: > On 03/22/2015 05:50 PM, Matthew Dawson wrote: > > If it isn't fully realized, is it worth it to test/implement this > > section, since its removed in the core profile? Would a reduced > > implementation to fix this test be OK (ignoring things like

[Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support.

2015-03-23 Thread Stefan Dösinger
This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a dependency on GL_ARB_shadow or GL_ARB_depth_texture for this value. Just set the value and don't do anything else. It won't matter without a depth texture being assigned anyway. --- src/mesa/mai

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-23 Thread Jason Ekstrand
On Mon, Mar 23, 2015 at 11:19 AM, Bruno Jimenez wrote: > On Wed, 2015-03-18 at 16:37 -0700, Jason Ekstrand wrote: >> On Wed, Mar 18, 2015 at 4:27 PM, Connor Abbott wrote: >> > On Wed, Mar 18, 2015 at 2:58 PM, Matt Turner wrote: >> >> On Thu, Mar 12, 2015 at 9:46 PM, Matt Turner wrote: >> >>> He

[Mesa-dev] [PATCH] i965/fs: Fix inverted comparison

2015-03-23 Thread Ian Romanick
From: Ian Romanick Commit b616164 added an optimization of b2f generation of a comparison. It also included an extra optimization of one of the comparison values is a constant of zero. The trick was that some value was known to be zero, so that value could be used in the SEL instruction instead

[Mesa-dev] [PATCH v3 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

2015-03-23 Thread Martin Peres
v2: Review from Laura Ekstrand - get rid of a change that should not have happened in this patch - improve the error messages - fix alignments - fix a capitalization in a function name in an error message v3: Review from Laura Ekstrand - move the test for the validity of the renderbuffer to less g

[Mesa-dev] [PATCH v3 15/17] main: Added entry point for glGetNamedRenderbufferParameteriv

2015-03-23 Thread Martin Peres
v2: - improve an error message Reviewed-by: Laura Ekstrand v3: - move a test to less generic functions - fix an alignment Signed-off-by: Martin Peres --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/fbobject.c | 63 +++--- sr

Re: [Mesa-dev] [PATCH 10/22] mesa: Refactor VertexAttrib[I|L]Format

2015-03-23 Thread Fredrik Höglund
On Friday 20 March 2015, Laura Ekstrand wrote: > On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > > > The only difference between these functions is the legal types and > > sizes, so consolidate the code into a single vertex_attrib_format() > > function and call it from all three entry p

Re: [Mesa-dev] [PATCH v3 0/9] Support multiple state pipelines for i965

2015-03-23 Thread Kristian Høgsberg
On Fri, Mar 20, 2015 at 5:28 PM, Jordan Justen wrote: > git://people.freedesktop.org/~jljusten/mesa i965-pipelines-v3 > > v2: > * Rename brw->atoms[] to render_atoms > * Add brw->compute_atoms[] >* Replace brw_pipeline_first_atom with brw_get_pipeline_atoms > > v3: > * Avoid changing pipel

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-23 Thread Bruno Jimenez
On Wed, 2015-03-18 at 16:37 -0700, Jason Ekstrand wrote: > On Wed, Mar 18, 2015 at 4:27 PM, Connor Abbott wrote: > > On Wed, Mar 18, 2015 at 2:58 PM, Matt Turner wrote: > >> On Thu, Mar 12, 2015 at 9:46 PM, Matt Turner wrote: > >>> Here are some ideas I think might be reasonable GSoC ideas. > >>

Re: [Mesa-dev] [PATCH 3/3] mesa: Validate the target argument earlier in glGenerateMipmap()

2015-03-23 Thread Laura Ekstrand
Looks good to me. Reviewed-by: Laura Ekstrand On Mon, Mar 23, 2015 at 4:30 AM, Eduardo Lima Mitev wrote: > glGenerateMipmap() queries the current texture object corresponding to the > target > argument before ever validating it. It does so by calling > _mesa_get_current_tex_object() which expl

Re: [Mesa-dev] [PATCH] gbm: remove gbm_gallium_drm from the loader

2015-03-23 Thread Kristian Høgsberg
On Sat, Mar 21, 2015 at 10:45 AM, Emil Velikov wrote: > Signed-off-by: Emil Velikov Reviewed-by: Kristian Høgsberg > --- > > Should have sent with the "remove st/gbm" series. Ohh well. > > -Emil > > > src/gbm/main/backend.c | 24 > 1 file changed, 24 deletions(-) > >

Re: [Mesa-dev] [PATCH 2/3] mesa: Fix error in target validation of glCompressedTex(ture)SubImage3D() calls

2015-03-23 Thread Laura Ekstrand
Looks correct to me. Reviewed-by: Laura Ekstrand On Mon, Mar 23, 2015 at 4:30 AM, Eduardo Lima Mitev wrote: > Basically, two different target error checks are chained consecutively, > and the > second one is executed regardless the result of the first one. This > produces an incorrect error if

Re: [Mesa-dev] [PATCH 1/3] mesa: Improve validation of target, format and type of glTexSubImage[2, 3]D

2015-03-23 Thread Laura Ekstrand
I'm glad you found this target checking problem. I have come across the same problem in other texture functions, but I have been too busy to find all instances of this. It's kind of a natural, negative byproduct of adding DSA. On Mon, Mar 23, 2015 at 4:29 AM, Eduardo Lima Mitev wrote: > Curren

Re: [Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set v2

2015-03-23 Thread Francisco Jerez
Tom Stellard writes: > The storage size for local kernel args can be queried before the > arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZE param > of clGetKernelWorkGroupInfo(). > > The spec says that if local kernel arguments have not been specified, > then we should assume their size is

[Mesa-dev] [PATCH 2/2] configure.ac: error out if python/mako is not found when required

2015-03-23 Thread Emil Velikov
In case of using a distribution tarball (or a dirty git tree) one can have the generated sources locally. Make configure.ac error out otherwise, to alert that about the unmet requirement(s) of python/mako. Cc: Matt Turner Suggested-by: Matt Turner Signed-off-by: Emil Velikov --- configure.ac |

[Mesa-dev] [PATCH 1/2] configure.ac: move AC_MSG_RESULT reportging back into the m4 macro

2015-03-23 Thread Emil Velikov
The one who does AC_MSG_CHECKING should provide the AC_MSG_RESULT. Fixed: ced9425327b (configure: Introduce new output variable to ax_check_python_mako_module.m4" Cc: Samuel Iglesias Gonsalvez Cc: "10.5" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89328 Signed-off-by: Emil Velikov --

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glsl: fix names in lower_constant_arrays_to_uniforms

2015-03-23 Thread Ian Romanick
On 03/23/2015 12:12 AM, Tapani Pälli wrote: > Patch changes lowering pass to use unique name for each uniform > so that arrays from different stages cannot end up having same > name. > > v2: instead of global counter, use pointer to achieve > unique name (Kenneth Graunke) > > Signed-off-by: T

Re: [Mesa-dev] [PATCH 1/3] makefile: add all headers to the tarball

2015-03-23 Thread Matt Turner
Thanks Emil. For the series Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 89689] [Regression] Weston on DRM backend won't start with new version of mesa

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89689 --- Comment #4 from Daniel Stone --- (In reply to Boyan Ding from comment #3) > Created attachment 114500 [details] [review] > dri/i965: Add XRGB to dri config > > I hacked the i965 driver and wrote this patch. After applying this to mesa, >

Re: [Mesa-dev] Correct behaviour of glDrawPixels and glBitmap when texturing is enabled.

2015-03-23 Thread Brian Paul
On 03/22/2015 05:50 PM, Matthew Dawson wrote: Hi all, I've been working fixing the piglit tests around glDrawPixels, and I'm not sure what the correct behaviour of glDrawPixels is when any texturing units are enabled (tested with the draw-pixel-with-texture piglit test). After asking on irc, im

[Mesa-dev] [PATCH 3/3] i965: add the remaining files to the tarball

2015-03-23 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/Makefile.sources | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/Makefile.sources b/src/mesa/drivers/dri/i965/Makefile.sources index c69441b..fd96b97 100644 --- a/src/mesa/drivers/dri/i965/Makefile.sources

[Mesa-dev] [PATCH 2/3] glsl: add the remaining files to the tarball

2015-03-23 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/glsl/Makefile.am | 1 + src/glsl/Makefile.sources | 1 + 2 files changed, 2 insertions(+) diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am index b466a3b..ed90366 100644 --- a/src/glsl/Makefile.am +++ b/src/glsl/Makefile.am @@ -46,6 +46,7 @@ EXTRA_

[Mesa-dev] [PATCH 1/3] makefile: add all headers to the tarball

2015-03-23 Thread Emil Velikov
Signed-off-by: Emil Velikov --- Makefile.am | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index f4f0912..9f49ce6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -44,12 +44,15 @@ EXTRA_DIST = \ scons \ SConstruct -noin

[Mesa-dev] [PATCH 1/2] automake: add missing egl files to the tarball

2015-03-23 Thread Emil Velikov
Namely the Haiku EGL driver backend and the SConscript for the dri2 EGL driver backend. Cc: Alexander von Gluck IV Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/Makefile.am | 5 - src/egl/drivers/dri2/Makefile.am | 2 ++ 2 files changed, 6 insert

[Mesa-dev] [PATCH 2/2] st/egl: don't ship the dri2, c link at the tarball

2015-03-23 Thread Emil Velikov
During 'make dist' the path of the symbolic link (x11/dri2.c) becomes too long, and tar converts it to hard one. To make it more complicated on Haiku tar errors out (due to lack of hardlink support) rather than falling back to the next best thing. So remove the symlink from git, and disable the sco

Re: [Mesa-dev] Correct behaviour of glDrawPixels and glBitmap when texturing is enabled.

2015-03-23 Thread Roland Scheidegger
Am 23.03.2015 um 00:50 schrieb Matthew Dawson: > Hi all, > > I've been working fixing the piglit tests around glDrawPixels, and I'm not > sure what the correct behaviour of glDrawPixels is when any texturing units > are enabled (tested with the draw-pixel-with-texture piglit test). After > ask

Re: [Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set v2

2015-03-23 Thread Jan Vesely
On Mon, 2015-03-23 at 14:52 +, Tom Stellard wrote: > The storage size for local kernel args can be queried before the > arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZE param > of clGetKernelWorkGroupInfo(). > > The spec says that if local kernel arguments have not been specified, > the

[Mesa-dev] [PATCH] radeonsi/compute: Default to the same PIPE_SHADER_CAP values as other shader types v2

2015-03-23 Thread Tom Stellard
v2: - Fix typo --- src/gallium/drivers/radeonsi/si_pipe.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index d335bda..c7773b7 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b/src

[Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set v2

2015-03-23 Thread Tom Stellard
The storage size for local kernel args can be queried before the arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZE param of clGetKernelWorkGroupInfo(). The spec says that if local kernel arguments have not been specified, then we should assume their size is 0. v2: - Implement using c++11

[Mesa-dev] [Bug 89705] lp_bld_debug.cpp:280:54: error: no matching function for call to ‘llvm?=::TargetMachine::getSubtargetImpl()=?UTF-8?Q?’

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89705 Tom Stellard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] Force update in mesa/master

2015-03-23 Thread Tom Stellard
On Mon, Mar 23, 2015 at 07:53:06AM -0700, Tom Stellard wrote: > Hi, > > I just did a fetch from mesa git and I received a force update from > mesa/master. > The current head commit form that remote is: > > commit 1e02f2badfd925739099bcfaa55ca99a484470d8 > Author: Tiziano Bacocco > Date: Fri F

[Mesa-dev] Force update in mesa/master

2015-03-23 Thread Tom Stellard
Hi, I just did a fetch from mesa git and I received a force update from mesa/master. The current head commit form that remote is: commit 1e02f2badfd925739099bcfaa55ca99a484470d8 Author: Tiziano Bacocco Date: Fri Feb 6 19:03:41 2015 +0100 nv50,nvc0: Mark PIPE_QUERY_TIMESTAMP_DISJOINT as re

Re: [Mesa-dev] [PATCH] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

2015-03-23 Thread Axel Davy
You seem to miss the case when one is None and not the other. It should return BadDrawable too. This particular case seems not handled by the dri2 code either, and the gallium state tracker seems to handle it in bindContext, but not the intel code for example. Axel Davy On 23/03/2015 08:07, Xio

Re: [Mesa-dev] [PATCH 6/6] i965: Allow Y-tiled allocations for large surfaces

2015-03-23 Thread Neil Roberts
Sorry for the delay in replying to this. Ben Widawsky writes: >> > +static inline uint32_t >> > +intel_miptree_blit_height(struct intel_mipmap_tree *mt) >> > +{ >> > + switch (mt->target) { >> > + case GL_TEXTURE_CUBE_MAP: >> > + case GL_TEXTURE_1D_ARRAY: >> > + case GL_TEXTURE_2D_ARRAY:

Re: [Mesa-dev] [PATCHv5 0/4] Separate device from driver vendor

2015-03-23 Thread Tom Stellard
On Sun, Mar 22, 2015 at 07:20:58AM +0100, Giuseppe Bilotta wrote: > OpenCL (as opposed to OpenGL) has separate vendor strings for the > implementation/driver/platform and the device. CL_PLATFORM_VENDOR > is akin to the GL_VENDOR string, while CL_DEVICE_VENDOR is supposed to > return the actual devi

Re: [Mesa-dev] [PATCH 5/6] i965: Attempt to blit for larger textures

2015-03-23 Thread Neil Roberts
Ben Widawsky writes: > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h > b/src/mesa/drivers/dri/i965/intel_blit.h > index 52dd67c..aff2d58 100644 > --- a/src/mesa/drivers/dri/i965/intel_blit.h > +++ b/src/mesa/drivers/dri/i965/intel_blit.h > @@ -78,14 +78,34 @@ void intel_emit_linear_blit(st

[Mesa-dev] [Bug 89705] lp_bld_debug.cpp:280:54: error: no matching function for call to ‘llvm?=::TargetMachine::getSubtargetImpl()=?UTF-8?Q?’

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89705 --- Comment #3 from LoneVVolf --- I found a patch by archlinux developer here : http://pkgbuild.com/~lcarlier/mesa-git/sources/mesa-git/radeonsi.patch It allows building mesa-git against latest llvm . -- You are receiving this mail because: Y

Re: [Mesa-dev] [PATCH 3/6] i965: Create and use #defines for blitter constraints

2015-03-23 Thread Neil Roberts
Ben Widawsky writes: > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h > b/src/mesa/drivers/dri/i965/intel_blit.h > index f563939..531d329 100644 > --- a/src/mesa/drivers/dri/i965/intel_blit.h > +++ b/src/mesa/drivers/dri/i965/intel_blit.h > @@ -30,6 +30,9 @@ > > #include "brw_context.h"

Re: [Mesa-dev] [PATCH 2/6] i965: Fix comments about blit constraints

2015-03-23 Thread Neil Roberts
Looks good to me. Reviewed-by: Neil Roberts - Neil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH 10/12] glsl: add AoA support for an inteface with unsized array members

2015-03-23 Thread Ilia Mirkin
On Sun, Mar 22, 2015 at 2:09 AM, Timothy Arceri wrote: > On Sat, 2015-03-21 at 19:57 -0400, Ilia Mirkin wrote: >> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri >> wrote: >> > Add support for setting the max access of an unsized member >> > of an interface array of arrays. >> > >> > For example

Re: [Mesa-dev] [RFC PATCH 09/12] glsl: add AoA support for linking interface blocks

2015-03-23 Thread Ilia Mirkin
On Sat, Mar 21, 2015 at 11:37 PM, Timothy Arceri wrote: > On Sat, 2015-03-21 at 19:51 -0400, Ilia Mirkin wrote: >> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri >> wrote: >> > Adds support for linking AoA interface blocks >> > which countain unsized arrays >> > --- >> > src/glsl/ir.cpp |

Re: [Mesa-dev] [RFC PATCH 06/12] glsl: dont allow gl_PerVertex to be redeclared as an array of arrays

2015-03-23 Thread Ilia Mirkin
On Sat, Mar 21, 2015 at 11:00 PM, Timothy Arceri wrote: > On Sat, 2015-03-21 at 19:34 -0400, Ilia Mirkin wrote: >> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri >> wrote: >> > Signed-off-by: Timothy Arceri >> > --- >> > src/glsl/ast_to_hir.cpp | 6 +- >> > 1 file changed, 5 insertions(+)

[Mesa-dev] [PATCH 17/20] i915: Remember to call intel_prepare_render() before blitting

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä Bring over the following fix from i965: commit fb3d62fe3d4fc40ba4ad9804d8b6f451316c9ae2 Author: Kenneth Graunke Date: Tue Aug 6 14:36:09 2013 -0700 i965: Remember to call intel_prepare_render() before blitting. Fixes a crash in the following piglit tests: bin/fbo-

[Mesa-dev] [PATCH 14/20] i915: Use COPY_DWORDS for points

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä The sub-pixel adjustment for points was killed off in commit 60d762aa625095a8c1f9597d8530bb5a6fa61b4c Author: Xiang, Haihao Date: Wed Jan 2 11:38:51 2008 +0800 i915: Needn't adjust pixel centers. fix #12944 so we can just as well use COPY_DWORDS(). Signed-off-by:

[Mesa-dev] [PATCH 12/20] i915: Make hw_prim[] const

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä The table used to map the GL primitive to the hw primitive never changes so make it const. Signed-off-by: Ville Syrjälä --- src/mesa/drivers/dri/i915/intel_render.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i915/intel_render.c

[Mesa-dev] [PATCH 19/20] i915: Fix culling with user fbos on gen2

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä Flip the cull bits when rendering to a user fbo on gen2. This was already done on gen3 (since before git history starts) but was missing from the gen2 code. Fixes rendering of the driver+kart model in supertuxkart kart selection screen. Signed-off-by: Ville Syrjälä --- src

[Mesa-dev] [PATCH 15/20] i915: Enable intel_render path for points

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä The sub-pixel adjustment for points was killed off in commit 60d762aa625095a8c1f9597d8530bb5a6fa61b4c Author: Xiang, Haihao Date: Wed Jan 2 11:38:51 2008 +0800 i915: Needn't adjust pixel centers. fix #12944 so if we don't need it in intel_tris.c we don't need it in

[Mesa-dev] [PATCH 11/20] i915: Use _tnl_RenderClippedPolygon and _tnl_RenderClippedLine

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä _tnl_RenderClippedPolygon and _tnl_RenderClippedLine already do most of what we want so use them. Signed-off-by: Ville Syrjälä --- src/mesa/drivers/dri/i915/intel_tris.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/src/mesa/driver

[Mesa-dev] [PATCH 20/20] i915: Fix texcoord vs. varying collision in fragment programs

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä i915 fragment programs utilize the texture coordinate registers for both texture coordinates and varyings. Unfortunately the code doesn't check if the same index might be in use for both. It just naively uses the index to pick a texture unit, which could lead to collisions. A

[Mesa-dev] [PATCH 13/20] i915: Use c99 initializers for primitive arrays

2015-03-23 Thread ville . syrjala
From: Ville Syrjälä Using c99 initializers for the primitive arrays makes things more readable. Signed-off-by: Ville Syrjälä --- src/mesa/drivers/dri/i915/intel_render.c | 60 src/mesa/drivers/dri/i915/intel_tris.c | 40 ++--- 2 files changed,

  1   2   >