Good to have your input. I'll work on it.
Marek Olšák wrote:
>I think I didn't tell you how I'd like the viewport and scissor states
>to be implemented. Here it is:
>
>1 r600_atom for all 16 viewports
>1 r600_atom for all 16 scissors
>
>Each atom should have a bitmask saying which "slots" are di
On Mon, Dec 01, 2014 at 02:04:50PM +0100, Eduardo Lima Mitev wrote:
> From: Samuel Iglesias Gonsalvez
>
> GLSL ES 3.00 spec, 4.3.10 (Linking of Vertex Outputs and Fragment Inputs),
> page 45 says the following:
>
> "The type of vertex outputs and fragment input with the same name must match,
> o
On Fri, Mar 27, 2015 at 1:06 AM, Vinson Lee wrote:
> On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
> wrote:
>> @@ -1404,14 +1405,36 @@ _mesa_GenRenderbuffers(GLsizei n, GLuint
>> *renderbuffers)
>> for (i = 0; i < n; i++) {
>>GLuint name = first + i;
>>renderbuffers[i] = name
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> @@ -1404,14 +1405,36 @@ _mesa_GenRenderbuffers(GLsizei n, GLuint
> *renderbuffers)
> for (i = 0; i < n; i++) {
>GLuint name = first + i;
>renderbuffers[i] = name;
> - /* insert dummy placeholder into hash table */
> +
From: Ian Romanick
The CSE algorithm will continuously allocate new ae_entry objects. As
each new basic block is exited, all of the previously allocated objects
are dumped. Instead, put them in a free list and re-use them in the
next basic block. Reduce, reuse, recycle!
Signed-off-by: Ian Rom
https://bugs.freedesktop.org/show_bug.cgi?id=89759
Ilia Mirkin changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Thu, 2015-03-26 at 22:27 -0400, Ilia Mirkin wrote:
> On Thu, Mar 26, 2015 at 10:17 PM, Jan Vesely wrote:
> > On Thu, 2015-03-26 at 21:11 -0400, Rob Clark wrote:
> >> On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote:
> >> > On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote:
> >> >> On Thu, Ma
https://bugs.freedesktop.org/show_bug.cgi?id=89754
Ilia Mirkin changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Thu, Mar 26, 2015 at 10:17 PM, Jan Vesely wrote:
> On Thu, 2015-03-26 at 21:11 -0400, Rob Clark wrote:
>> On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote:
>> > On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote:
>> >> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
>> >>> On Thu, Mar 26
On Thu, Mar 26, 2015 at 10:17 PM, Jan Vesely wrote:
> On Thu, 2015-03-26 at 21:11 -0400, Rob Clark wrote:
>> On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote:
>> > On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote:
>> >> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
>> >>> On Thu, Mar 26
On Thu, 2015-03-26 at 21:11 -0400, Rob Clark wrote:
> On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote:
> > On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote:
> >> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
> >>> On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand
> >>> wrote:
> On
On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote:
> On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote:
>> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
>>> On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand
>>> wrote:
On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash
wrote:
>
well, bringing compute to the other gallium drivers in general, beyond
radeon, is probably an entire project on it's own.. but a very
worthwhile project (IMHO).. since opencl (beyond embedded profile)
requires double support, that probably also would expose the need for
fp64 lowering in more driver
From: Michel Dänzer
Fixes a crash in genymotion with several threads compiling shaders
concurrently.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89746
Cc: 10.5
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_compute.c | 3 +-
src/gallium/drivers/radeonsi/si
On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote:
> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
>> On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand wrote:
>>> On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash
>>> wrote:
I mean, implementing fp64 on single precision systems.
>>>
>>> O
Are you suggesting bringing OpenCL support for Adreno gpus and using
softfloat?
On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote:
> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
> > On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand
> wrote:
> >> On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avi
On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
> On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand wrote:
>> On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash
>> wrote:
>>> I mean, implementing fp64 on single precision systems.
>>
>> Ok, That makes more sense! Having lowering passes for vario
On Thu, Mar 26, 2015 at 1:35 PM, Jason Ekstrand wrote:
> What about other datatypes such as D or UW? Perhaps we should have
> some sort of is_integer function and just do is_integer(a) !=
> is_integer(b)?
I can't come up with any case where we'd be doing a partial write
(with B/UB/W/UW types) an
Reviewed-by: Marek Olšák
Marek
On Fri, Mar 27, 2015 at 12:37 AM, Ilia Mirkin wrote:
> Spotted by Coverity.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/auxiliary/hud/hud_driver_query.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/hud/h
Spotted by Coverity.
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/hud/hud_driver_query.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_driver_query.c
b/src/gallium/auxiliary/hud/hud_driver_query.c
index b48708c..53771fc 100644
--- a/
Reviewed-by: Brian Paul
On 03/26/2015 05:26 PM, Ilia Mirkin wrote:
Does not appear to be used in tree. Coverity spotted some errors in the
bitmask stuff, but the whole thing appears to be unused.
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/Makefile.sources | 2 -
src/g
On 03/26/2015 05:33 PM, Ilia Mirkin wrote:
Spotted by Coverity.
Signed-off-by: Ilia Mirkin
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index b619326
Spotted by Coverity.
Signed-off-by: Ilia Mirkin
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index b619326..e97ab83 100644
--- a/src/mesa/state_tracker/s
Does not appear to be used in tree. Coverity spotted some errors in the
bitmask stuff, but the whole thing appears to be unused.
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/Makefile.sources | 2 -
src/gallium/auxiliary/util/u_linkage.c | 149 ---
Am 27.03.2015 um 00:06 schrieb Ilia Mirkin:
> The CUBE_ARRAY case uses r[4]. Make sure that the stack variable is
> there.
>
> Noticed by Coverity.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/gallium/auxiliary/tgsi/tgsi_exec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
I think I didn't tell you how I'd like the viewport and scissor states
to be implemented. Here it is:
1 r600_atom for all 16 viewports
1 r600_atom for all 16 scissors
Each atom should have a bitmask saying which "slots" are dirty. (same
principle as resource slots)
The "emit" functions should on
The CUBE_ARRAY case uses r[4]. Make sure that the stack variable is
there.
Noticed by Coverity.
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c
b/src/gallium/auxilia
Emil Velikov wrote in news:55136BE1.6090001
@gmail.com:
> and no longer requires python/mako in order to build.
Hi,
I am a bit confused, quoting the commit
http://cgit.freedesktop.org/mesa/mesa/commit/?h=10.5
&id=e98909b0567b8a83a6a953cfa4ee4e7beef436b9
"It is still returning error when Python
Update on radeonsi's GL_ARB_viewport_array: even though I don't have
much time right now, the easy part is done. I should push my changes to
my git tree soon. I'll let you know where it is.
However, I may need some help for the last part, mostly because r600g
doesn't help a lot on that matter.
On Sat, 2015-03-21 at 20:06 -0400, Ilia Mirkin wrote:
> Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin
>
Is anyone interested in taking a look at the remaining patches?
>
> The rest I sent comments on, although even if you address my feedback,
> I'm not sufficiently familiar to r-b
On Thu, Mar 26, 2015 at 12:27 PM, Matt Turner wrote:
> The thing we want to avoid is int/float comparisons, but int/unsigned
> comparisons with 0 are equivalent.
>
> total instructions in shared programs: 6194829 -> 6193996 (-0.01%)
> instructions in affected programs: 117192 -> 116359 (-0.71%
Reviewed-by: Marek Olšák
Marek
On Thu, Mar 26, 2015 at 8:14 PM, Ilia Mirkin wrote:
> Fixes the recently-sent gl-2.0-vertex-const-attr piglit test. Makes sure
> to revalidate arrays when only the current attribute has been updated
> via glVertexAttrib*.
>
> Bugzilla: https://bugs.freedesktop.org
On 27 March 2015 at 05:14, Ilia Mirkin wrote:
> Fixes the recently-sent gl-2.0-vertex-const-attr piglit test. Makes sure
> to revalidate arrays when only the current attribute has been updated
> via glVertexAttrib*.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89754
> Signed-off-by:
On 25/03/15 19:03, srol...@vmware.com wrote:
From: Roland Scheidegger
There are issues with inlining everything, most notably llvm will use much
more memory (and be slower) when compiling. Ideally we'd probably use
functions for shader functions too but texture sampling usually is responsible
f
instructions in affected programs: 2858 -> 2808 (-1.75%)
helped:12
---
src/glsl/nir/nir_opt_algebraic.py | 8
1 file changed, 8 insertions(+)
diff --git a/src/glsl/nir/nir_opt_algebraic.py
b/src/glsl/nir/nir_opt_algebraic.py
index 6730408..34a401a 100
No changes in shader-db.
---
src/glsl/nir/nir_opt_algebraic.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/glsl/nir/nir_opt_algebraic.py
b/src/glsl/nir/nir_opt_algebraic.py
index 350a482..4fe4cc0 100644
--- a/src/glsl/nir/nir_opt_algebraic.py
+++ b/src/glsl/nir/nir_opt_algebraic
total instructions in shared programs: 6195924 -> 6195768 (-0.00%)
instructions in affected programs: 4876 -> 4720 (-3.20%)
helped:58
HURT: 10
---
src/glsl/nir/nir_opt_algebraic.py | 1 +
1 file changed, 1 insertion(+)
diff --gi
The rcp(log(x)) pattern affects instruction counts.
instructions in affected programs: 144 -> 138 (-4.17%)
helped:6
---
src/glsl/nir/nir_opt_algebraic.py | 8
1 file changed, 8 insertions(+)
diff --git a/src/glsl/nir/nir_opt_algebraic.py
b/src/glsl/n
total instructions in shared programs: 6197614 -> 6195924 (-0.03%)
instructions in affected programs: 34773 -> 33083 (-4.86%)
helped:147
HURT: 6
---
These are all based on top of Jason's ffma series and my i965/fs CSE patch.
src
Doesn't work for analogous && cases, because of NaNs.
total instructions in shared programs: 6195712 -> 6194829 (-0.01%)
instructions in affected programs: 42000 -> 41117 (-2.10%)
helped:403
---
src/glsl/nir/nir_opt_algebraic.py | 2 ++
1 file changed, 2 insert
No shader-db changes, probably because they're all removed by the GLSL
compiler optimization added in commit 69ad5fd4.
---
src/glsl/nir/nir_opt_algebraic.py | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/nir/nir_opt_algebraic.py
b/src/glsl/nir/nir_opt_algebraic.py
index 56dd8be.
The thing we want to avoid is int/float comparisons, but int/unsigned
comparisons with 0 are equivalent.
total instructions in shared programs: 6194829 -> 6193996 (-0.01%)
instructions in affected programs: 117192 -> 116359 (-0.71%)
helped:471
---
src/mesa/driv
What about Nouveau and Intel?
On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote:
> On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand
> wrote:
> > On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash
> > wrote:
> >> I mean, implementing fp64 on single precision systems.
> >
> > Ok, That makes more s
GL4-capable NVIDIA chips all support fp64 natively. Not sure about
Intel, I believe there's partial support there. I didn't say there
were no customers for it, merely to make sure that the work you're
proposing would satisfy them :)
On Thu, Mar 26, 2015 at 3:11 PM, Aditya Avinash
wrote:
> What ab
Fixes the recently-sent gl-2.0-vertex-const-attr piglit test. Makes sure
to revalidate arrays when only the current attribute has been updated
via glVertexAttrib*.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89754
Signed-off-by: Ilia Mirkin
---
src/mesa/state_tracker/st_atom_array.c |
On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand wrote:
> On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash
> wrote:
>> I mean, implementing fp64 on single precision systems.
>
> Ok, That makes more sense! Having lowering passes for various FP64
> operations would be great.
We should make sure th
Do you know anyone working on it?
On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand
wrote:
> On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash
> wrote:
> > I mean, implementing fp64 on single precision systems.
>
> Ok, That makes more sense! Having lowering passes for various FP64
> operations wo
On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash
wrote:
> I mean, implementing fp64 on single precision systems.
Ok, That makes more sense! Having lowering passes for various FP64
operations would be great.
--Jason
> On Thu, Mar 26, 2015 at 2:59 PM, Jason Ekstrand
> wrote:
>>
>> On Thu, Mar 26
I mean, implementing fp64 on single precision systems.
On Thu, Mar 26, 2015 at 2:59 PM, Jason Ekstrand
wrote:
> On Thu, Mar 26, 2015 at 11:20 AM, Aditya Avinash
> wrote:
> > Hi,
> > I would like to softfloat for GSOC. Is anyone working on it?
> > Thank you!! :)
>
> What do you mean by softfloat
On Thu, Mar 26, 2015 at 11:20 AM, Aditya Avinash
wrote:
> Hi,
> I would like to softfloat for GSOC. Is anyone working on it?
> Thank you!! :)
What do you mean by softfloat? If you're talking about doing software
floating-point on the GPU, I don't think that's a thing. GPUs
frequently don't supp
On 25/03/15 15:41, srol...@vmware.com wrote:
From: Roland Scheidegger
The callbacks used for getting the dynamic texture/sampler state were using
the jit_context from the generated jit function. This works just fine, however
that way it's impossible to generate separate functions for texture sa
Hi,
I would like to softfloat for GSOC. Is anyone working on it?
Thank you!! :)
On Tue, Mar 24, 2015 at 12:16 AM, Kenneth Graunke
wrote:
> On Monday, March 23, 2015 05:02:51 PM Aaron Watry wrote:
> > On a related note,
> >
> > Has anyone ported shader-db over to working on R600/RadeonSI/ > non-i
This is a problem when we have IR like this:
(array_ref (var_ref temps) (swiz x (expression ivec4 bitcast_f2i
(swiz (array_ref (var_ref temps) (constant int (2)) ) )) )) ) )
where we are indexing an array with the result of an expression that
accesses the same array.
In this scenario, te
On 03/26/2015 03:32 PM, Marek Olšák wrote:
It can be fixed after the series, but the fix should be committed
_with_ the series.
Well, let me update it locally and submit a v3 when the other patches
will be reviewed. :-)
Marek
On Thu, Mar 26, 2015 at 2:05 PM, Samuel Pitoiset
wrote:
On
On Wed, Mar 25, 2015 at 4:52 PM, Ben Widawsky
wrote:
> The PMA depth stall must be enabled (optimization turned off) under certain
> circumstances on gen8. This was supposedly fixed for Gen9, which means we do
> not
> need to check, or toggle the state. The hardware is supposed to enable the
> ha
https://bugs.freedesktop.org/show_bug.cgi?id=89754
--- Comment #2 from Ilia Mirkin ---
I sent a piglit test which should make this easier to debug:
http://patchwork.freedesktop.org/patch/45692/
I believe the problem is that gallium never notices the updated vertex size. I
haven't debugged it in
On 26/03/15 16:36, Emil Velikov wrote:
On 25/03/15 19:58, Jose Fonseca wrote:
On 25/03/15 19:35, Emil Velikov wrote:
On 25/03/15 15:21, Jose Fonseca wrote:
On 25/03/15 14:53, Emil Velikov wrote:
On 24 March 2015 at 21:16, Jose Fonseca wrote:
There doesn't seem much interest on osmesa on Win
On 25/03/15 19:58, Jose Fonseca wrote:
> On 25/03/15 19:35, Emil Velikov wrote:
>> On 25/03/15 15:21, Jose Fonseca wrote:
>>> On 25/03/15 14:53, Emil Velikov wrote:
On 24 March 2015 at 21:16, Jose Fonseca wrote:
> There doesn't seem much interest on osmesa on Windows, particularly
> c
On Thu, Mar 26, 2015 at 6:57 AM, Christian König
wrote:
> From: Christian König
>
> The data in memory is in big endian format and needs to be converted
> into CPU byte order. So the patch actually reversed what needs to be done.
>
> Signed-off-by: Christian König
> ---
> src/gallium/auxiliary/
It can be fixed after the series, but the fix should be committed
_with_ the series.
Marek
On Thu, Mar 26, 2015 at 2:05 PM, Samuel Pitoiset
wrote:
>
>
> On 03/26/2015 12:45 PM, Marek Olšák wrote:
>>
>> Patches 1-5, 7, 10, 12:
>>
>> Reviewed-by: Marek Olšák
>
>
> Thank you Marek.
>
>>
>> Radeon
From: Christian König
The data in memory is in big endian format and needs to be converted
into CPU byte order. So the patch actually reversed what needs to be done.
Signed-off-by: Christian König
---
src/gallium/auxiliary/vl/vl_vlc.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
On 03/26/2015 12:45 PM, Marek Olšák wrote:
Patches 1-5, 7, 10, 12:
Reviewed-by: Marek Olšák
Thank you Marek.
Radeon drivers still set the query type to TRUE/FALSE, which is incorrect.
Good catch!
But I'm a bit confused because you already have ACKed that patch, do I
need to submit a v
Am Donnerstag, 26. März 2015, 11:33:57 schrieb Marc Dietrich:
> Am Donnerstag, 26. März 2015, 11:24:24 schrieb Marc Dietrich:
> > Am Donnerstag, 26. März 2015, 02:56:50 schrieb Glenn Kennard:
> > > CF_END could end up emitted in the middle of a shader on cayman
> > > when there was a loop at the ve
Patches 1-5, 7, 10, 12:
Reviewed-by: Marek Olšák
Radeon drivers still set the query type to TRUE/FALSE, which is incorrect.
Marek
On Sun, Mar 22, 2015 at 4:35 PM, Samuel Pitoiset
wrote:
> Hello,
>
> A series I have waited too long to re-submit, but I recently refactored the
> code and fixed s
Am Donnerstag, 26. März 2015, 11:24:24 schrieb Marc Dietrich:
> Am Donnerstag, 26. März 2015, 02:56:50 schrieb Glenn Kennard:
> > CF_END could end up emitted in the middle of a shader on cayman
> > when there was a loop at the very end.
> >
> > Fixes glsl-1.50-geometry-end-primitive and
> > ext_tr
Am Donnerstag, 26. März 2015, 02:56:50 schrieb Glenn Kennard:
> CF_END could end up emitted in the middle of a shader on cayman
> when there was a loop at the very end.
>
> Fixes glsl-1.50-geometry-end-primitive and
> ext_transform_feedback-geometry-shaders-basic piglit tests.
yes, I just found o
On 03/20/2015 10:58 PM, Ian Romanick wrote:
From: Ian Romanick
This is like Matt's earlier patch, but it enables the optimization for
ir_triop_csel.
There are no shader-db changes now, but this prevents a large number of
regressions from a later commit (glsl: Optimize certain if-statements to
Hi Xiong Zhang,
> On 25 March 2015 at 08:05, Xiong Zhang wrote:
> > GLX_ARB_create_context spec says:
> > If either or are not a valid GLX drawable, a
> > GLXBadDrawable error is generated, unless and are both
> > None and the OpenGL version supported by is 3.0 or greater.
> >
> > So when bo
68 matches
Mail list logo