Re: [Mesa-dev] [PATCH] nir: fix bit of cargo-culting in lower_idiv

On Apr 10, 2015 1:42 PM, "Rob Clark" wrote: > > From: Rob Clark > > I guess I was looking too much at how lower_system_values worked when > writing lower_idiv. > > Since ttn wasn't emitting load_var for sysvals and the only drivers > using lower_idiv were using ttn, I think nothing was broken as

Re: [Mesa-dev] [PATCH v2 2/3] i965/fs: Change SEL and MOV types as needed to propagate source modifiers

On Apr 10, 2015 10:34 PM, "Matt Turner" wrote: > > On Fri, Apr 10, 2015 at 10:24 PM, Matt Turner wrote: > > On Fri, Apr 10, 2015 at 2:16 PM, Jason Ekstrand wrote: > >> Ping > > > > 1-2 are > > > > Reviewed-by: Matt Turner > > > > Thanks! > > Though I should mention that I do see some shaders th

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Only emit FS_OPCODE_PLACEHOLDER_HALT if there are discards

On Fri, Apr 10, 2015 at 07:50:19PM -0700, Kenneth Graunke wrote: > On Friday, April 10, 2015 12:52:03 PM Ben Widawsky wrote: > > Based originally on a patch from Ken in May 2014 of the same title. Things > > changed enough that I didn't feel comfortable leaving his authorship. Ken, > > if > > you

Re: [Mesa-dev] [PATCH v2 2/3] i965/fs: Change SEL and MOV types as needed to propagate source modifiers

On Fri, Apr 10, 2015 at 10:24 PM, Matt Turner wrote: > On Fri, Apr 10, 2015 at 2:16 PM, Jason Ekstrand wrote: >> Ping > > 1-2 are > > Reviewed-by: Matt Turner > > Thanks! Though I should mention that I do see some shaders that still do SEL on UD types. Maybe we're not losing anything by doing t

Re: [Mesa-dev] [PATCH v2 2/3] i965/fs: Change SEL and MOV types as needed to propagate source modifiers

On Fri, Apr 10, 2015 at 2:16 PM, Jason Ekstrand wrote: > Ping 1-2 are Reviewed-by: Matt Turner Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Only emit FS_OPCODE_PLACEHOLDER_HALT if there are discards

On Friday, April 10, 2015 12:52:03 PM Ben Widawsky wrote: > Based originally on a patch from Ken in May 2014 of the same title. Things > changed enough that I didn't feel comfortable leaving his authorship. Ken, if > you feel you should retain authorship, it's fine with me, just call it > reviewed-

Re: [Mesa-dev] [PATCH] drirc: Add "Second Life" quirk (allow_glsl_extension_directive_midshader).

On Friday, April 10, 2015 11:09:01 AM Matt Turner wrote: > On Fri, Apr 10, 2015 at 10:30 AM, Kenneth Graunke > wrote: > > Appears to fix shader compilation. Tested by starting the client, > > dragging the "quality and speed" slider back and forth, and watching the > > console output - instead of

Re: [Mesa-dev] [PATCH] gallium/hud: add more options to customize HUD panes

On 2015.04.10 02:05, Gediminas Jakutis wrote: > Extends the syntax of GALLIUM_HUD environment variable to: > Add options to set the size and exact location of each pane. > Add an option to limit the maximum allowed value of the X axis > on a pane, clamping down the graph to not go above this value.

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #8 from nerdopol...@verizon.net --- Seems that there is still no way for running weston-simple-egl or weston-gears on software rendering? -- You are receiving this mail because: You are the assignee for the bug. _

[Mesa-dev] [PATCH 10/12] nir/locals_to_regs: Pass around the nir_shader rather than a void * mem_ctx

--- src/glsl/nir/nir_lower_locals_to_regs.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/glsl/nir/nir_lower_locals_to_regs.c b/src/glsl/nir/nir_lower_locals_to_regs.c index 8c1977a..6ad8ab0 100644 --- a/src/glsl/nir/nir_lower_locals_to_regs.

[Mesa-dev] [PATCH 05/12] i965/nir: Use the correct offsets when handling register indirects

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 54 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index a874337..863b687 100644 --- a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 02/12] nir: Refactor tex_instr_dest_size to use a switch statement

--- src/glsl/nir/nir.h | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index f9ca0f7..9e62f13 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -959,7 +959,8 @@ typedef struct { static inline unsigned nir_tex_ins

[Mesa-dev] [PATCH 07/12] nir: Move get_const_initializer_load from vars_to_ssa to NIR core

--- src/glsl/nir/nir.c | 60 + src/glsl/nir/nir.h | 3 ++ src/glsl/nir/nir_lower_vars_to_ssa.c | 64 ++-- 3 files changed, 65 insertions(+), 62 deletions(-) diff --git a/src/glsl/nir/nir.c b/src/g

[Mesa-dev] [PATCH 03/12] nir/tex: Use the correct return size for query_levels and lod

--- src/glsl/nir/nir.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 9e62f13..5a7f581 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -985,9 +985,12 @@ nir_tex_instr_dest_size(nir_tex_instr *instr) return re

[Mesa-dev] [PATCH 11/12] nir/locals_to_regs: Initialize registers with constant initializers

--- src/glsl/nir/nir_lower_locals_to_regs.c | 103 1 file changed, 103 insertions(+) diff --git a/src/glsl/nir/nir_lower_locals_to_regs.c b/src/glsl/nir/nir_lower_locals_to_regs.c index 6ad8ab0..48459f7 100644 --- a/src/glsl/nir/nir_lower_locals_to_regs.c +++ b/s

[Mesa-dev] [PATCH 06/12] nir/lower_vars_to_ssa: Pass around the nir_shader instead of a void mem_ctx

--- src/glsl/nir/nir_lower_vars_to_ssa.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/glsl/nir/nir_lower_vars_to_ssa.c b/src/glsl/nir/nir_lower_vars_to_ssa.c index 8b7261c..1afa9b7 100644 --- a/src/glsl/nir/nir_lower_vars_to_ssa.c +++ b/sr

[Mesa-dev] [PATCH 12/12] nir/locals_to_regs: Hanadle indirect accesses of length-1 arrays

--- src/glsl/nir/nir_lower_locals_to_regs.c | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_lower_locals_to_regs.c b/src/glsl/nir/nir_lower_locals_to_regs.c index 48459f7..bc6a3d3 100644 --- a/src/glsl/nir/nir_lower_locals_to_regs.c +++ b/src/glsl/nir/nir_lower_locals

[Mesa-dev] [PATCH 04/12] nir/print: Print the closing paren on load_const instructions

--- src/glsl/nir/nir_print.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c index fb8c934..eb4045c 100644 --- a/src/glsl/nir/nir_print.c +++ b/src/glsl/nir/nir_print.c @@ -533,6 +533,8 @@ print_load_const_instr(nir_load_const_instr *instr,

[Mesa-dev] [PATCH 08/12] nir/types: Make glsl_get_length smarter

Previously, this function returned the number of elements for structures and arrays and 0 for everything else. In NIR, this is almost never what you want because we also treat matricies as arrays so you have to special-case constantly. We already had a helper for this in two places and should hav

[Mesa-dev] [PATCH 09/12] nir: Add a simple growing array data structure

--- src/glsl/nir/nir_array.h | 96 1 file changed, 96 insertions(+) create mode 100644 src/glsl/nir/nir_array.h diff --git a/src/glsl/nir/nir_array.h b/src/glsl/nir/nir_array.h new file mode 100644 index 000..1db4e8c --- /dev/null +++ b/src/gl

[Mesa-dev] [PATCH 00/12] nir: Various indirect variable use fixes

Right now, most of the code to handle indirect dereferences of variables is dead. However, I have a patch series (which I haven't cleaned up yet) that makes it very much alive for the i965 backend. While working on this, I found a number of bugs in NIR's handling of indirect references. All in a

[Mesa-dev] [PATCH 01/12] nir/lower_vars_to_ssa: Actually look for indirects when determining aliasing

--- src/glsl/nir/nir_lower_vars_to_ssa.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_lower_vars_to_ssa.c b/src/glsl/nir/nir_lower_vars_to_ssa.c index 2ca74d7..8b7261c 100644 --- a/src/glsl/nir/nir_lower_vars_to_ssa.c +++ b/src/glsl/nir/nir_lower_vars_to_ssa.c @@ -317,

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: platform_drm should also try render node first.

On Fri 10 Apr 2015, Emil Velikov wrote: Hi Haixia, On 18/02/15 02:08, Haixia Shi wrote: Signed-off-by: Haixia Shi --- src/egl/drivers/dri2/platform_drm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform

Re: [Mesa-dev] [PATCH] glx: Allow to create any OpenGL ES version.

On Fri 10 Apr 2015, Jose Fonseca wrote: From: José Fonseca The latest version of GLX_EXT_create_context_es2_profile states: "If the version requested is a valid and supported OpenGL-ES version, and the GLX_CONTEXT_ES_PROFILE_BIT_EXT bit is set in the GLX_CONTEXT_PROFILE_MASK_ARB attribute (

[Mesa-dev] [PATCH 1/2] st/mesa: add a debug option to compile shaders at link time

From: Marek Olšák v2: fix crashes --- src/mesa/state_tracker/st_cb_program.c | 4 +++ src/mesa/state_tracker/st_debug.c | 1 + src/mesa/state_tracker/st_debug.h | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +- src/mesa/state_tracker/st_program.c| 47 +++

[Mesa-dev] [PATCH 2/2] i965/bsw: Enabling floating point blend optimization

Same as previous, but for BSW. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_state_upload.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c index 11098cf..ec6c4e6 100644 --- a/

[Mesa-dev] [PATCH 1/2] i965/skl: Enable floating blend optimization

This optimization is disabled by default, and it is recommended to be enabled. The docs do not provide much info. Cc: Ian Romanick Cc: "Neil S. Roberts" Signed-off-by: Ben Widawsky --- Notes: I am enabling this optimization separately for BSW as the recommendation was explicit for SKL

Re: [Mesa-dev] [PATCH 0/4] remove unneeded #include of colormac.h

Sounds reasonable. Assuming you build tested, series Reviewed-by: Jordan Justen On 2015-04-10 13:45:24, Mark Janes wrote: > Please pardon the git-send-email mistake. I meant to set a proper > subject for the thread. > > -Mark > > Mark Janes writes: > > > With the removal of unused colormac.h

[Mesa-dev] [PATCH] glx: Allow to create any OpenGL ES version.

From: José Fonseca The latest version of GLX_EXT_create_context_es2_profile states: "If the version requested is a valid and supported OpenGL-ES version, and the GLX_CONTEXT_ES_PROFILE_BIT_EXT bit is set in the GLX_CONTEXT_PROFILE_MASK_ARB attribute (see below), then the context returned

Re: [Mesa-dev] [PATCH 11/11] i965: Fix textureSize for Lod > 0 with non-mipmap filters

On Tue, Feb 10, 2015 at 04:40:48PM +0100, Eduardo Lima Mitev wrote: > From: Iago Toral Quiroga > > Currently, when the MinFilter is GL_LINEAR or GL_NEAREST we hide the > actual miplevel count from the hardware (and we avoid re-creating > the miptree structure with all the levels), since we don't

[Mesa-dev] [PATCH 2/2] radeonsi: add a debug option to compile shaders when they're created

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 4 3 files changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/galliu

[Mesa-dev] [PATCH 1/2] st/mesa: add a debug option to compile shaders at link time

From: Marek Olšák --- src/mesa/state_tracker/st_cb_program.c | 4 src/mesa/state_tracker/st_debug.c | 1 + src/mesa/state_tracker/st_debug.h | 1 + src/mesa/state_tracker/st_program.c| 44 ++ src/mesa/state_tracker/st_program.h| 3 +++ 5

Re: [Mesa-dev] [PATCH 3/3] glx: Allow to create any OpenGL ES version.

On 12/11/14 18:16, Daniel Stone wrote: Hi, On 12 November 2014 12:37, mailto:jfons...@vmware.com>> wrote: @@ -544,9 +544,22 @@ dri2_convert_glx_attribs(unsigned num_attribs, const uint32_t *attribs, case GLX_CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB: *api = __DRI_A

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

https://bugs.freedesktop.org/show_bug.cgi?id=89978 David Heidelberg (okias) changed: What|Removed |Added CC||da...@ixit.cz --- Comment #2

Re: [Mesa-dev] Problem with LLVM on Windows with MSVC

I suspect that when you built LLVM, you built with the Debug build type instead of Release. That's why you need LLVM_USE_CRT_DEBUG= instead of LLVM_USE_CRT_RELEASE=. But I don't recommend you use a Debug LLVM build, it can be much slower. To be safe, I could update the instructions to menti

Re: [Mesa-dev] Problem with LLVM on Windows with MSVC

Thanks everyone. I was able to compile it using the instructions Jose sent from this page: http://mesa3d.org/llvmpipe.html. However, I believe there's a typo in that page. In the text I've pasted below, the highlighted RELEASE should be DEBUG. Thanks again, Shervin For Windows you will need

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

https://bugs.freedesktop.org/show_bug.cgi?id=89978 --- Comment #1 from David Heidelberg (okias) --- Can you provide which one gcc version is latest working? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH v2] glsl: fix assignment of multiple scalar and vecs to matrices.

On Tue, Apr 07, 2015 at 03:49:55PM +0200, Samuel Iglesias Gonsalvez wrote: > When a vec has more elements than row components in a matrix, the > code could end up failing an assert inside assign_to_matrix_column(). > > This patch makes sure that when there is still room in the matrix for > more el

Re: [Mesa-dev] [PATCH v2 2/3] i965/fs: Change SEL and MOV types as needed to propagate source modifiers

On Mon, Apr 6, 2015 at 6:13 PM, Jason Ekstrand wrote: > On Mon, Apr 6, 2015 at 4:55 PM, Matt Turner wrote: >> On Fri, Apr 3, 2015 at 2:06 PM, Jason Ekstrand wrote: >>> SEL and MOV instructions, as long as they don't have source modifiers, are >>> just copying bits around. This commit adds suppo

Re: [Mesa-dev] [PATCH 0/4] remove unneeded #include of colormac.h

Please pardon the git-send-email mistake. I meant to set a proper subject for the thread. -Mark Mark Janes writes: > With the removal of unused colormac.h macros > 2ad8af1a0c319c83e4a8e00db3a9b9cb0ae029eb, several unused includes were > eliminated. This patch set removes the remaining places

[Mesa-dev] [PATCH] nir: fix bit of cargo-culting in lower_idiv

From: Rob Clark I guess I was looking too much at how lower_system_values worked when writing lower_idiv. Since ttn wasn't emitting load_var for sysvals and the only drivers using lower_idiv were using ttn, I think nothing was broken as a result. But might as well fix this before it becomes a pr

[Mesa-dev] [PATCH 1/4] i915: remove unneeded #include of colormac.h

--- src/mesa/drivers/dri/i915/i915_vtbl.c | 1 - src/mesa/drivers/dri/i915/intel_state.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i915_vtbl.c b/src/mesa/drivers/dri/i915/i915_vtbl.c index 706e0c3..8e5e393 100644 --- a/src/mesa/drivers/dri/i915/i915_vtbl.c +

[Mesa-dev] [PATCH 2/4] i965: remove unneeded #include of colormac.h

--- src/mesa/drivers/dri/i965/intel_blit.c | 1 - src/mesa/drivers/dri/i965/intel_state.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index 9500bd7..be67111 100644 --- a/src/mesa/drivers/dri/i965/intel_blit.

[Mesa-dev] [PATCH 3/4] radeon/r200: remove unneeded #include of colormac.h

--- src/mesa/drivers/dri/r200/r200_context.h | 1 - src/mesa/drivers/dri/r200/r200_maos_arrays.c | 1 - src/mesa/drivers/dri/r200/r200_state.c| 1 - src/mesa/drivers/dri/r200/r200_state_init.c | 1 - src/mesa/drivers/dri/r200/r200_swtcl.c| 1 - src/mesa/drivers/dri/r200/r20

[Mesa-dev] [PATCH 4/4] mesa: remove unneeded #include of colormac.h

--- src/mesa/main/pack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index f723608..c444890 100644 --- a/src/mesa/main/pack.c +++ b/src/mesa/main/pack.c @@ -43,7 +43,6 @@ #include "glheader.h" -#include "colormac.h" #include "enums.h" #incl

[Mesa-dev] (no subject)

With the removal of unused colormac.h macros 2ad8af1a0c319c83e4a8e00db3a9b9cb0ae029eb, several unused includes were eliminated. This patch set removes the remaining places where colormac.h is included but not used. ___ mesa-dev mailing list mesa-dev@lis

Re: [Mesa-dev] [PATCH 1/2] gallium/ttn: fix TXD

Rob Clark writes: > From: Rob Clark > > With TXD we also have the ddx/ddy sources (before the sampler). These two are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http:

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Combine tex/fb_write operations (opt)

On Fri, Apr 10, 2015 at 12:52 PM, Ben Widawsky wrote: > Certain platforms support the ability to sample from a texture, and write it > out > to the file RT - thus saving a costly send instructions (note that this is a > potnential win if one wanted to backport to a tag that didn't have the patch

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Only emit FS_OPCODE_PLACEHOLDER_HALT if there are discards

On Fri, Apr 10, 2015 at 12:52 PM, Ben Widawsky wrote: > Based originally on a patch from Ken in May 2014 of the same title. Things > changed enough that I didn't feel comfortable leaving his authorship. Ken, if > you feel you should retain authorship, it's fine with me, just call it > reviewed-by

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Create a has_side_effects for fs_inst

On Fri, Apr 10, 2015 at 12:52 PM, Ben Widawsky wrote: > When an instruction has a side effect, it impacts the available options when > reordering an instruction. As the EOT flag is an implied write to the render > target in the FS, it can be considered a side effect. > > This patch shouldn't actua

[Mesa-dev] [PATCH 3/3] i965/fs: Combine tex/fb_write operations (opt)

Certain platforms support the ability to sample from a texture, and write it out to the file RT - thus saving a costly send instructions (note that this is a potnential win if one wanted to backport to a tag that didn't have the patch from Topi which removed excess MOVs from LOAD_PAYLOAD - 97caf5fa

[Mesa-dev] [PATCH 1/3] i965/fs: Create a has_side_effects for fs_inst

When an instruction has a side effect, it impacts the available options when reordering an instruction. As the EOT flag is an implied write to the render target in the FS, it can be considered a side effect. This patch shouldn't actually have any impact on the current code since the EOT flag impli

[Mesa-dev] [PATCH 2/3] i965/fs: Only emit FS_OPCODE_PLACEHOLDER_HALT if there are discards

Based originally on a patch from Ken in May 2014 of the same title. Things changed enough that I didn't feel comfortable leaving his authorship. Ken, if you feel you should retain authorship, it's fine with me, just call it reviewed-by me instead. Cc: Kenneth Graunke Signed-off-by: Ben Widawsky

Re: [Mesa-dev] [PATCH] gallivm: Fix build since llvm-3.7.0svn r234495

On Fri, 2015-04-10 at 15:38 -0400, Nick Sarnie wrote: > Yes, if you could that would be great. I have no push access. pushed, thanks jan > > Thanks, > Nick Sarnie > > On Fri, Apr 10, 2015 at 3:37 PM, Nick Sarnie > wrote: > > > Yes, if you could that would be great. I have no push access. > >

[Mesa-dev] [Bug 89978] nine_state.c:1440: error: unknown field ‘m’ specified in initializer

https://bugs.freedesktop.org/show_bug.cgi?id=89978 Bug ID: 89978 Summary: nine_state.c:1440: error: unknown field ‘m’ specified in initializer Product: Mesa Version: 10.5 Hardware: x86-64 (AMD64) OS: Linux (