[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #20 from Pekka Paalanen --- (In reply to nerdopolis1 from comment #18) > Hi. I realized that the hang happens when I hover over an icon on the > desktop shell, and it tries to show a tooltip > > Output of weston running with WAYLAND_

Re: [Mesa-dev] [PATCH v3] glsl: set the binding value regardless explicit_binding

2015-05-12 Thread Alejandro Piñeiro
On 12/05/15 23:17, Timothy Arceri wrote: > On Mon, 2015-05-11 at 12:37 +0200, Alejandro Piñeiro wrote: >> Since commit c0cd5b var->data.binding was set only when explicit_binding >> was false, thas was wrong, should be a test to true. This prevented >> to use any binding point different to 0. >> >>

[Mesa-dev] [Bug 90162] glGetFramebufferAttachmentParameteriv failing if certain FB attributes are zero

2015-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90162 --- Comment #5 from Tapani Pälli --- These errors are according to the spec and happen because of following reason. 8< OpenGL 4.0 Compatibility, page 449: If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE, no fram

Re: [Mesa-dev] Possible ideas for optimisations in Mesa

2015-05-12 Thread Ian Romanick
On 05/12/2015 03:12 PM, Timothy Arceri wrote: > On Sat, 2015-04-18 at 12:26 +0200, Marek Olšák wrote: >> On Fri, Apr 17, 2015 at 1:21 PM, Timothy Arceri >> wrote: >>> Hi all, >>> >>> Last year I spent a whole bunch of time profiling Mesa looking for areas >>> where improvements could be made. Any

Re: [Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Kenneth Graunke
On Tuesday, May 12, 2015 09:23:38 PM Jordan Justen wrote: > On 2015-05-12 17:55:36, Kenneth Graunke wrote: > > For scalar GS support, we either need to add a third constructor which > > forth, right? > > Did you miss removing the compute constructor prototype from brw_fs.h? > > Reviewed-by: Jord

Re: [Mesa-dev] [PATCH] glsl: add stage references for UBO uniforms

2015-05-12 Thread Tapani Pälli
On 05/13/2015 08:02 AM, Samuel Iglesias Gonsálvez wrote: Thanks Tapani! Reviewed-by: Samuel Iglesias Gonsalvez Can you add a test to piglit to check this case? I was hoping you had some test that hit this? :) I'll take a look if existing tests can be modified easily to cover this case.

Re: [Mesa-dev] [PATCH] glsl: add stage references for UBO uniforms

2015-05-12 Thread Samuel Iglesias Gonsálvez
Thanks Tapani! Reviewed-by: Samuel Iglesias Gonsalvez Can you add a test to piglit to check this case? Sam On 11/05/15 12:24, Tapani Pälli wrote: > Patch marks uniforms inside UBO properly referenced by stages. > > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug

Re: [Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Jordan Justen
On 2015-05-12 17:55:36, Kenneth Graunke wrote: > For scalar GS support, we either need to add a third constructor which forth, right? Did you miss removing the compute constructor prototype from brw_fs.h? Reviewed-by: Jordan Justen > takes the GS structures, or combine the existing two and pas

Re: [Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Jason Ekstrand
On May 12, 2015 5:56 PM, "Kenneth Graunke" wrote: > > For scalar GS support, we either need to add a third constructor which > takes the GS structures, or combine the existing two and pass the shader > stage. > > Given that they're not significantly different, I opted for the latter. > > Signed-of

Re: [Mesa-dev] [PATCH 3/3] softpipe: enable ARB_texture_view

2015-05-12 Thread Roland Scheidegger
Am 13.05.2015 um 04:45 schrieb Ilia Mirkin: > On Tue, May 12, 2015 at 10:36 PM, wrote: >> From: Roland Scheidegger >> >> Some bits were already there for texture views but some were missing. >> In particular for cube map views things needed to change a bit. >> For simplicity I ended up removing

Re: [Mesa-dev] [PATCH 3/3] softpipe: enable ARB_texture_view

2015-05-12 Thread Ilia Mirkin
On Tue, May 12, 2015 at 10:36 PM, wrote: > From: Roland Scheidegger > > Some bits were already there for texture views but some were missing. > In particular for cube map views things needed to change a bit. > For simplicity I ended up removing the separate face addr bit (just use > the z bit) -

Re: [Mesa-dev] [PATCH 1/3] gallium/util: fix blitter sampler view target initialization

2015-05-12 Thread Dave Airlie
On 13 May 2015 at 12:36, wrote: > From: Roland Scheidegger > > This was missing, and drivers relying on the target in the view could get > into quite some trouble. Missing signoff, otherwise Reviewed-by: Dave Airlie > --- > src/gallium/auxiliary/util/u_blitter.c | 1 + > 1 file changed, 1 in

[Mesa-dev] [PATCH 3/3] softpipe: enable ARB_texture_view

2015-05-12 Thread sroland
From: Roland Scheidegger Some bits were already there for texture views but some were missing. In particular for cube map views things needed to change a bit. For simplicity I ended up removing the separate face addr bit (just use the z bit) - cube arrays didn't use it already, so just follow the

[Mesa-dev] [PATCH 1/3] gallium/util: fix blitter sampler view target initialization

2015-05-12 Thread sroland
From: Roland Scheidegger This was missing, and drivers relying on the target in the view could get into quite some trouble. --- src/gallium/auxiliary/util/u_blitter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitte

[Mesa-dev] [PATCH 2/3] llvmpipe: enable ARB_texture_view

2015-05-12 Thread sroland
From: Roland Scheidegger All the functionality was pretty much there, just not tested. Trivially fix up the missing pieces (take target info from view not resource), and add some missing bits for cubes. Also add some minimal debug validation to detect uninitialized target values in the view... 4

[Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Kenneth Graunke
For scalar GS support, we either need to add a third constructor which takes the GS structures, or combine the existing two and pass the shader stage. Given that they're not significantly different, I opted for the latter. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_cs.cpp

Re: [Mesa-dev] [PATCH] i965/cs: drop explicit initialisers in C++ file

2015-05-12 Thread Jordan Justen
We could keep them in comments... Reviewed-by: Jordan Justen On 2015-05-12 17:01:17, Dave Airlie wrote: > From: Dave Airlie > > gcc 4.4.7 really doesn't like them, and they aren't standard > C++, they seem to be a gcc extension. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH] i965/cs: drop explicit initialisers in C++ file

2015-05-12 Thread Dave Airlie
From: Dave Airlie gcc 4.4.7 really doesn't like them, and they aren't standard C++, they seem to be a gcc extension. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/brw_cs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #19 from nerdopol...@verizon.net --- As suggested as a test, before running Weston, I exported vblank_mode=0 And this prevents the hangs -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 90147] swrast: build error undeclared _SC_PHYS_PAGES on osx

2015-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90147 --- Comment #11 from Julien Isorce --- (In reply to Brian Paul from comment #10) > Julien, can you test the new patch? It is missing a #else just before #error "Unsupported platform", otherwise it is working fine. -- You are receiving this mai

Re: [Mesa-dev] [PATCH] egl/main: fix EGL_KHR_get_all_proc_addresses

2015-05-12 Thread Chad Versace
On Tue 12 May 2015, Emil Velikov wrote: > The extension requires that the address of the core functions should be > available via eglGetProcAddress. Currently the list is guarded by > _EGL_GET_CORE_ADDRESSES, which was only set for the scons (windows) > build. > > Unconditionally enable it for all

[Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglapi.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 6457798..34a113b 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -251,6 +251,30 @@ _eglUnl

[Mesa-dev] [PATCH 08/15] egl: use EGL 1.5 types without suffixes

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/drivers/dri2/egl_dri2.c | 4 ++-- src/egl/main/eglapi.c | 40 src/egl/main/eglapi.h | 4 ++-- src/egl/main/eglimage.h | 10 +- src/egl/main/eglsync.c | 4 ++-- src/egl/main/egls

[Mesa-dev] [PATCH 14/15] egl: return correct invalid-type error from eglCreateSync

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglapi.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index e3b8ec2..ff0217e 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1241,7 +1241,7 @@ e

[Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

2015-05-12 Thread Marek Olšák
From: Marek Olšák with the extension of keeping: #define KHRONOS_APICALL __attribute__((visibility("default"))) And don't include mesa headers in egl.h. --- include/EGL/egl.h | 562 + include/EGL/eglext.h | 259 +++--

[Mesa-dev] [PATCH 07/15] egl: add context attribs from EGL 1.5

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglcontext.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index e50b8fb..e767f4b 100644 --- a/src/egl/main/eglcontext.c +++ b/src/egl/main/eglcontext.c @@ -198,6 +198,3

[Mesa-dev] [PATCH 03/15] egl: combine VersionMajor and VersionMinor into one variable

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglapi.c | 9 - src/egl/main/egldisplay.h | 3 +-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index d9053dc..51c2e78 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@

[Mesa-dev] [PATCH 10/15] egl: add eglWaitSync

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglapi.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 60df297..544f7e4 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1162,6 +1162,7 @@ eglGetProcAddress(const char *pr

[Mesa-dev] [PATCH 01/15] egl: remove unused _egl_global::ClientExtensions

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglglobals.c | 10 -- src/egl/main/eglglobals.h | 9 - 2 files changed, 19 deletions(-) diff --git a/src/egl/main/eglglobals.c b/src/egl/main/eglglobals.c index 129bf29..884cff0 100644 --- a/src/egl/main/eglglobals.c +++ b/src/egl/main/eglglob

[Mesa-dev] [PATCH 02/15] egl: set the EGL version in common code

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/drivers/dri2/platform_android.c | 4 src/egl/drivers/dri2/platform_drm.c | 4 src/egl/drivers/dri2/platform_wayland.c | 8 src/egl/drivers/dri2/platform_x11.c | 8 src/egl/main/eglapi.c | 7 +++ 5 files chang

[Mesa-dev] [PATCH 15/15] egl: expose EGL 1.5 if all requirements are met

2015-05-12 Thread Marek Olšák
From: Marek Olšák There's no driver support yet, because EGL_KHR_gl_colorspace isn't implemented. --- src/egl/main/eglapi.c | 15 +++ src/egl/main/egldisplay.h | 1 + 2 files changed, 16 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index ff0217e..8c1

[Mesa-dev] [PATCH 05/15] egl: remove duplicated EGL extension definitions

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- include/EGL/eglmesaext.h | 28 1 file changed, 28 deletions(-) diff --git a/include/EGL/eglmesaext.h b/include/EGL/eglmesaext.h index 27cf7eb..80601f0 100644 --- a/include/EGL/eglmesaext.h +++ b/include/EGL/eglmesaext.h @@ -98,39 +98,11 @@ type

[Mesa-dev] [PATCH 06/15] egl: fix setting context flags

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglcontext.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index 514b91a..e50b8fb 100644 --- a/src/egl/main/eglcontext.c +++ b/src/egl/main/eglcontext.c @@ -131,7 +131,7 @@ _eglPar

[Mesa-dev] [PATCH 11/15] egl: add eglGetSyncAttrib

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/egl/main/eglapi.c | 14 +- src/egl/main/eglapi.h | 2 +- src/egl/main/eglsync.c | 2 +- src/egl/main/eglsync.h | 2 +- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 544f7e4..6457798 1

[Mesa-dev] [PATCH 13/15] egl: add new platform functions

2015-05-12 Thread Marek Olšák
From: Marek Olšák These are just wrappers around the existing extension functions. --- src/egl/main/eglapi.c | 45 + 1 file changed, 45 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 34a113b..e3b8ec2 100644 --- a/src/eg

[Mesa-dev] [PATCH 00/15] EGL 1.5 support and fixes

2015-05-12 Thread Marek Olšák
Hi, This patch series adds most things needed to enable EGL 1.5. The last missing features are EGL_KHR_gl_colorspace and EGL_KHR_gl_texture_3D_image, though the latter should be at least partially done I think. Please review. Marek ___ mesa-dev maili

[Mesa-dev] [PATCH 09/15] egl: add EGL 1.5 functions that don't need any changes from extensions

2015-05-12 Thread Marek Olšák
From: Marek Olšák Declare the functions without the suffix, so that the core names are exported. --- src/egl/main/eglapi.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 9f09466..60df297 100644 --- a/s

[Mesa-dev] [Bug 86701] [regression] weston-simple-egl not running anymore inside qemu

2015-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86701 --- Comment #18 from nerdopol...@verizon.net --- Hi. I realized that the hang happens when I hover over an icon on the desktop shell, and it tries to show a tooltip Output of weston running with WAYLAND_DEBUG=server http://pastebin.com/0aQGBLFH

[Mesa-dev] [PATCH] clover: clarify and fix the EGL interop error case

2015-05-12 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/clover/api/interop.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/interop.cpp b/src/gallium/state_trackers/clover/api/interop.cpp index ea0c7c7..b96069f 100644 --- a/src/gallium

Re: [Mesa-dev] Possible ideas for optimisations in Mesa

2015-05-12 Thread Timothy Arceri
On Sat, 2015-04-18 at 12:26 +0200, Marek Olšák wrote: > On Fri, Apr 17, 2015 at 1:21 PM, Timothy Arceri wrote: > > Hi all, > > > > Last year I spent a whole bunch of time profiling Mesa looking for areas > > where improvements could be made. Anyway I thought I'd point out a > > couple of things, a

Re: [Mesa-dev] [RFC 3/6] Model INTEL perf query backend after query object BE

2015-05-12 Thread Robert Bragg
On Mon, May 11, 2015 at 4:11 PM, Samuel Pitoiset wrote: > Patches 1 and 2 look fine to me. > > See my comments below for this one. > > > On 05/06/2015 02:53 AM, Robert Bragg wrote: >> >> --- a/src/mesa/main/performance_query.c >> +++ b/src/mesa/main/performance_query.c >> @@ -1,5 +1,5 @@ >> /*

Re: [Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2015-05-12 Thread Roland Scheidegger
I like faster! I don't really understand though where the wins come from. softpipe can't have much pending work in the first place (maybe tile cache?), llvmpipe potentially has the rasterizer threads I guess but I'm not quite sure how this works... Though I'm not really too familiar with the dri i

Re: [Mesa-dev] [PATCH] glsl: set the binding value regardless explicit_binding

2015-05-12 Thread Timothy Arceri
On Mon, 2015-05-11 at 12:37 +0200, Alejandro Piñeiro wrote: > Since commit c0cd5b var->data.binding was set only when explicit_binding > was false, thas was wrong, should be a test to true. This prevented > to use any binding point different to 0. > > In any case, that if statement is not needed.

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix PBO cache coherency issue after _mesa_meta_pbo_GetTexSubImage().

2015-05-12 Thread Anuj Phogat
On Tue, May 12, 2015 at 7:55 AM, Francisco Jerez wrote: > This problem can easily be reproduced with a number of > ARB_shader_image_load_store piglit tests, which use a buffer object as > PBO for a pixel transfer operation and later on bind the same buffer > to the pipeline as shader image -- The

[Mesa-dev] [Bug 90147] swrast: build error undeclared _SC_PHYS_PAGES on osx

2015-05-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90147 Brian Paul changed: What|Removed |Added CC||julien.iso...@gmail.com --- Comment #10 fro

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v2)

2015-05-12 Thread Matt Turner
On Tue, May 5, 2015 at 2:17 PM, Francisco Jerez wrote: > Kenneth Graunke writes: >> I like the idea of the builder refactor - having a mechanism for emitting >> code at arbitrary points makes a ton of sense. But I'm uncomfortable >> with how much code is added - and duplicated from the existing

Re: [Mesa-dev] [PATCH 5/6] egl/main: expose only core EGL functions statically

2015-05-12 Thread Chad Versace
On Mon 11 May 2015, Emil Velikov wrote: > The EGL 1.3, 1.4 and 1.5 spec explicitly mentions that providing > static symbols for functions provided by EGL extensions is not portable. > Considering that relatively recently we've seen a non-mesa desktop EGL > implementation, the fact that we opt for s

[Mesa-dev] [PATCH] freedreno: enable a306

2015-05-12 Thread Rob Clark
From: Rob Clark Whitelist adreno 306 (as found in msm8916/apq8016). Works pretty much out of the box, although the smaller GMEM size requires more tiles to fit 1920x1080, so bump up the max # of tiles as well. Since it is just whitelist + trivial change, it makes sense to land on all the active

Re: [Mesa-dev] [PATCH 1/6] egl/main: drop support for external egl drivers

2015-05-12 Thread Chad Versace
On Tue 12 May 2015, Chad Versace wrote: > On Mon 11 May 2015, Emil Velikov wrote: > > The only user (egl_gallium) is not longer around. > > > > Signed-off-by: Emil Velikov > > For the series, > Reviewed-by: Chad Versace Um... except for patch 5, the one that redeclares some entrypoints as stat

Re: [Mesa-dev] [PATCH 1/6] egl/main: drop support for external egl drivers

2015-05-12 Thread Chad Versace
On Mon 11 May 2015, Emil Velikov wrote: > The only user (egl_gallium) is not longer around. > > Signed-off-by: Emil Velikov For the series, Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

[Mesa-dev] [PATCH 2/2] clover: Use threadsafe wrappers for pipe_screen and pipe_context

2015-05-12 Thread Tom Stellard
Events can be added to an OpenCL command queue concurrently from multiple threads, but pipe_context and pipe_screen objects are not threadsafe. The threadsafe wrappers protect all pipe_screen and pipe_context function calls with a mutex, so we can safely use them with multiple threads. CC: 10.5 d

[Mesa-dev] [PATCH 1/2] gallium/drivers: Add threadsafe wrappers for pipe_context and pipe_screen

2015-05-12 Thread Tom Stellard
These wrappers can be used by state trackers to ensure threadsafe access to pipe_context and pipe_screen objects. CC: 10.5 + * + */ + +#ifdef __cplusplus +extern "C" { +#endif + +struct pipe_context; +struct pipe_screen; + +struct pipe_context *pipe_threadsafe_context(struct pipe_context *ctx); +

Re: [Mesa-dev] [PATCH 7/9] gallium: Wire up flush control

2015-05-12 Thread Marek Olšák
Patches 7 & 8: Reviewed-by: Marek Olšák Marek On Tue, May 12, 2015 at 5:54 PM, Adam Jackson wrote: > This still doesn't do anything unless your driver exposes the flush > control extension. > > Signed-off-by: Adam Jackson > --- > src/gallium/include/state_tracker/st_api.h | 1 + > src/gall

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add new bonaire pci id

2015-05-12 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, May 12, 2015 at 7:35 PM, Alex Deucher wrote: > Signed-off-by: Alex Deucher > Cc: mesa-sta...@lists.freedesktop.org > --- > include/pci_ids/radeonsi_pci_ids.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/pci_ids/radeon

[Mesa-dev] [PATCH 1/2] radeonsi: add new bonaire pci id

2015-05-12 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index ca81f76..464031c 100644 --- a/include/pci_ids/radeonsi_pci_id

Re: [Mesa-dev] [PATCH] i965/fs: set execution size to 8 with simd8 ddy instruction

2015-05-12 Thread Matt Turner
On Tue, May 12, 2015 at 4:24 AM, Tapani Pälli wrote: > Commit dd5c825 changed the way how execution size for instructions > get set. Previously it was based on destination register width, now > it is set explicitly when emitting instructions. > > Signed-off-by: Tapani Pälli > Reviewed-by: Francis

[Mesa-dev] [PATCH 2/2] radeonsi: add some additional tonga pci ids

2015-05-12 Thread Alex Deucher
Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 464031c..197ce8e 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include/pci_ids/radeonsi_p

Re: [Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-12 Thread Robert Bragg
On Wed, May 6, 2015 at 9:36 AM, Samuel Pitoiset wrote: > > > On 05/06/2015 02:53 AM, Robert Bragg wrote: >> >> As we've learned more about the observability capabilities of Gen >> graphics we've found that it's not enough to only try and configure the >> OA unit from userspace without any dedicate

Re: [Mesa-dev] [PATCH 03/29] i965: Define consistent interface to disable control flow execution masking.

2015-05-12 Thread Matt Turner
On Tue, May 12, 2015 at 5:18 AM, Francisco Jerez wrote: > Kenneth Graunke writes: >> On Monday, May 11, 2015 05:12:41 PM Matt Turner wrote: >>> I think set_* would be better. >> >> Agreed. Reading this in action... >> >>exec_all(bld.MOV(...)) >> >> sounds a bit funny to me - execute this MOV

Re: [Mesa-dev] [PATCH] i965/fs: set execution size to 8 with simd8 ddy instruction

2015-05-12 Thread Mark Janes
Tested-by: Mark Janes Tapani Pälli writes: > Commit dd5c825 changed the way how execution size for instructions > get set. Previously it was based on destination register width, now > it is set explicitly when emitting instructions. > > Signed-off-by: Tapani Pälli > Reviewed-by: Francisco Jer

Re: [Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-12 Thread Robert Bragg
Petri Latval wrote some piglit test for the core INTEL_performance_query behaviour (i.e not assuming anything about the semantics of the counters themselves) that he sent to the list some time last year, but unfortunately they fell through the cracks and never landed. The other week I revived thos

Re: [Mesa-dev] [PATCH] i965: Fix PBO cache coherency issue after _mesa_meta_pbo_GetTexSubImage().

2015-05-12 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On May 12, 2015 7:55 AM, "Francisco Jerez" wrote: > This problem can easily be reproduced with a number of > ARB_shader_image_load_store piglit tests, which use a buffer object as > PBO for a pixel transfer operation and later on bind the same buffer > to the pipeline

[Mesa-dev] [PATCH 4/9] intel: Don't flush the old context in intelMakeCurrent

2015-05-12 Thread Adam Jackson
From: Neil Roberts It shouldn't be necessary to flush the context within the driver implementation because the old context is explicitly flushed in _mesa_make_current which is called a little further on. It is useful to only have a single place that flushes when switching contexts to make it easi

[Mesa-dev] [PATCH 2/9] dri: Add a flush control extension

2015-05-12 Thread Adam Jackson
From: Neil Roberts Adds a DRI extension which advertises that the driver can accept a new __DRI_CTX_ATTRIB_RELEASE_BEHAVIOR attribute in the createContextAttribs function. If the attribute is specified then it will be passed down to the CreateContext function in the release_behavior member of __D

[Mesa-dev] [PATCH 6/9] glx: Implement ARB_context_flush_control in drisw too

2015-05-12 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/drisw_glx.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index a07feb9..c2f8c4b 100644 --- a/src/glx/drisw_glx.c +++ b/src/glx/drisw_glx.c @@ -410,7 +410,7 @@ drisw_create_conte

[Mesa-dev] [PATCH 1/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

2015-05-12 Thread Adam Jackson
From: Neil Roberts Previously the CreateContext method of __DriverApiRec took a set of arguments to describe the attribute values from the window system API's CreateContextAttribs function. As more attributes get added this could quickly get unworkable and every new attribute needs a modification

[Mesa-dev] [PATCH 9/9] hacks: Enable testing this series on slightly older userspace

2015-05-12 Thread Adam Jackson
This hides the flush control attribute from the CreateContextAttribs request. Older X servers don't know about it and will throw an error, and at least for purposes of testing it's not something that matters. Signed-off-by: Adam Jackson --- src/glx/create_context.c | 19 ++- src

[Mesa-dev] [PATCH 3/9] glx: Add the GLX_ARB_context_flush_control extension

2015-05-12 Thread Adam Jackson
From: Neil Roberts This adds the framework for the GLX flush control extension. It is advertised if the DRI driver implements the new __DRI2_FLUSH_CONTROL extension. The GLX attributes are converted to the appropriate DRI attributes. --- src/glx/dri2_glx.c | 19 +-- src/glx/

[Mesa-dev] [PATCH 5/9] i965: Implement the __DRI2_FLUSH_CONTROL extension

2015-05-12 Thread Adam Jackson
From: Neil Roberts Implementing the extension just involves copying the release behaviour value from the context config to the GL context's constants. The upper layers of Mesa handles the actual flushing. --- src/mesa/drivers/dri/i965/brw_context.c | 20 +++- src/mesa/drivers/dr

[Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2015-05-12 Thread Adam Jackson
Hilariously this is a fairly big win. Neil's multi-context-test improves from ~24 to ~36 fps with llvmpipe on a Core i5-3317U. softpipe also improves, from about 2.25 to 3.09 fps (when it's that slow, you're allowed to be that precise). I'd have added it to swrast classic, but the testcase wants

[Mesa-dev] [PATCH 0/9] Implement GLX_ARB_context_flush_control

2015-05-12 Thread Adam Jackson
This is a rebase of Neil's work through patch 5. 6 through 8 wire the extension through gallium and drisw. Adding it to the gallium hardware drivers would be similarly trivial. The last patch hides some grossness with the protocol, where xserver has to be taught about the new context attribute b

[Mesa-dev] [PATCH 7/9] gallium: Wire up flush control

2015-05-12 Thread Adam Jackson
This still doesn't do anything unless your driver exposes the flush control extension. Signed-off-by: Adam Jackson --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_context.c | 7 ++- src/mesa/state_tracker/st_manager.c | 3 +++ 3 files chang

Re: [Mesa-dev] [PATCH v2 1/5] nv30: remove unused nvfx_fp_memcpy() function and comment nv40_fp_bra()

2015-05-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, May 12, 2015 at 11:35 AM, Samuel Pitoiset wrote: > The nv40_fp_bra() function in the same file is also unused but this is > the only place where the nv30/nv40 isa is documented. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv30/nvfx_fr

[Mesa-dev] [PATCH v2 1/5] nv30: remove unused nvfx_fp_memcpy() function and comment nv40_fp_bra()

2015-05-12 Thread Samuel Pitoiset
The nv40_fp_bra() function in the same file is also unused but this is the only place where the nv30/nv40 isa is documented. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/

Re: [Mesa-dev] [PATCH 2/5] nv30: do not use container_of() when sample param is not initialized

2015-05-12 Thread Samuel Pitoiset
On 05/12/2015 05:36 PM, Ilia Mirkin wrote: On Tue, May 12, 2015 at 11:24 AM, Samuel Pitoiset wrote: On 05/12/2015 05:21 PM, Ilia Mirkin wrote: On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: This has been detected by Clang 3.6 which displays a warning message because variable 'nv

Re: [Mesa-dev] [PATCH 2/5] nv30: do not use container_of() when sample param is not initialized

2015-05-12 Thread Ilia Mirkin
On Tue, May 12, 2015 at 11:24 AM, Samuel Pitoiset wrote: > > > On 05/12/2015 05:21 PM, Ilia Mirkin wrote: >> >> On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset >> wrote: >>> >>> This has been detected by Clang 3.6 which displays a warning message >>> because variable 'nv30' is uninitialized whe

Re: [Mesa-dev] [PATCH 1/5] nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions

2015-05-12 Thread Ilia Mirkin
On Tue, May 12, 2015 at 11:25 AM, Samuel Pitoiset wrote: > > > On 05/12/2015 05:24 PM, Ilia Mirkin wrote: >> >> On Tue, May 12, 2015 at 11:19 AM, Samuel Pitoiset >> wrote: > > -/* warning: this only works forward, and probably only if not inside > any > IF */ > -static void >>

Re: [Mesa-dev] [PATCH 1/5] nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions

2015-05-12 Thread Ilia Mirkin
On Tue, May 12, 2015 at 11:19 AM, Samuel Pitoiset wrote: >>> -/* warning: this only works forward, and probably only if not inside any >>> IF */ >>> -static void >>> -nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) >> >> Please keep. This is the only docs for this stuff. > > I didn't know that

Re: [Mesa-dev] [PATCH 1/5] nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions

2015-05-12 Thread Samuel Pitoiset
On 05/12/2015 05:24 PM, Ilia Mirkin wrote: On Tue, May 12, 2015 at 11:19 AM, Samuel Pitoiset wrote: -/* warning: this only works forward, and probably only if not inside any IF */ -static void -nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) Please keep. This is the only docs for this stu

Re: [Mesa-dev] [PATCH 2/5] nv30: do not use container_of() when sample param is not initialized

2015-05-12 Thread Ilia Mirkin
On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: > This has been detected by Clang 3.6 which displays a warning message > because variable 'nv30' is uninitialized when used here. According to > the description of container_of, 'sample' must be initialized, otherwise > the result is undefin

Re: [Mesa-dev] [PATCH 2/5] nv30: do not use container_of() when sample param is not initialized

2015-05-12 Thread Samuel Pitoiset
On 05/12/2015 05:21 PM, Ilia Mirkin wrote: On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: This has been detected by Clang 3.6 which displays a warning message because variable 'nv30' is uninitialized when used here. According to the description of container_of, 'sample' must be init

Re: [Mesa-dev] [PATCH 1/5] nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions

2015-05-12 Thread Ilia Mirkin
On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 40 > > 1 file changed, 40 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c > b/src/galliu

Re: [Mesa-dev] [PATCH 3/5] nv50/ir: remove unused private field cycle to SchedDataCalculator

2015-05-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp

Re: [Mesa-dev] [PATCH 5/5] nvc0: remove unused nv50_tsc_wrap_mode() function

2015-05-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 18 -- > 1 file changed, 18 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_state.c >

Re: [Mesa-dev] [PATCH 4/5] nv50/ir: silence compiler warnings about mismatched tags

2015-05-12 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: > These warnings have been detected by Clang 3.6. > > codegen/nv50_ir_from_tgsi.cpp:1319:10: warning: struct 'Source' was > previously declared as a class [-Wmismatched-tags] const struct tgsi::Source > *code; > >

Re: [Mesa-dev] [PATCH 1/5] nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions

2015-05-12 Thread Samuel Pitoiset
On 05/12/2015 05:19 PM, Ilia Mirkin wrote: On Tue, May 12, 2015 at 11:13 AM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 40 1 file changed, 40 deletions(-) diff --git a/src/gallium/drivers/nouveau/

[Mesa-dev] [PATCH 1/5] nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions

2015-05-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 40 1 file changed, 40 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c b/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c index bbdca81..29603fb 100644 --- a

[Mesa-dev] [PATCH 2/5] nv30: do not use container_of() when sample param is not initialized

2015-05-12 Thread Samuel Pitoiset
This has been detected by Clang 3.6 which displays a warning message because variable 'nv30' is uninitialized when used here. According to the description of container_of, 'sample' must be initialized, otherwise the result is undefined. This patch gets rid of container_of() which is not required h

[Mesa-dev] [PATCH 4/5] nv50/ir: silence compiler warnings about mismatched tags

2015-05-12 Thread Samuel Pitoiset
These warnings have been detected by Clang 3.6. codegen/nv50_ir_from_tgsi.cpp:1319:10: warning: struct 'Source' was previously declared as a class [-Wmismatched-tags] const struct tgsi::Source *code; Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp |

[Mesa-dev] [PATCH 0/5] nouveau: silence warnings detected by Clang 3.6

2015-05-12 Thread Samuel Pitoiset
Hi, This series just fixes some compilation warnings reported by Clang for Nouveau. Feel free to review. Samuel Pitoiset (5): nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions nv30: do not use container_of() when sample param is not initialized nv50/ir: remove unused private

[Mesa-dev] [PATCH 3/5] nv50/ir: remove unused private field cycle to SchedDataCalculator

2015-05-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp index d9aed34..be6fe95 100644 ---

[Mesa-dev] [PATCH 5/5] nvc0: remove unused nv50_tsc_wrap_mode() function

2015-05-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_state.c index dca06f4..63c3c52 100644 --- a/src/gallium/dr

Re: [Mesa-dev] [PATCH] glsl/es31:Allow GL_ARB_TEXTURE_MULTISAMPLE in GLSL ES 3.10

2015-05-12 Thread Ilia Mirkin
On Tue, May 12, 2015 at 10:53 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Signed-off-by: Marta Lofstedt > --- > src/glsl/builtin_functions.cpp | 3 +-- > src/glsl/builtin_types.cpp | 2 +- > src/glsl/glsl_lexer.ll | 13 +++-- > src/glsl/glsl_parser_extras.h | 5

Re: [Mesa-dev] [PATCH] configure: Bump libdrm requirement for Intel to 2.4.61

2015-05-12 Thread Emil Velikov
Hi Neil, On 12/05/15 11:14, Neil Roberts wrote: > This is required for the I915_PARAM_REVISION macro. Previously this > define was directly copied into the Mesa source. Tobias (tobijk on IRC) spotted a regression that was caused by the commit introducing the define in libdrm. Would be nice to conf

[Mesa-dev] [PATCH] i965: Fix PBO cache coherency issue after _mesa_meta_pbo_GetTexSubImage().

2015-05-12 Thread Francisco Jerez
This problem can easily be reproduced with a number of ARB_shader_image_load_store piglit tests, which use a buffer object as PBO for a pixel transfer operation and later on bind the same buffer to the pipeline as shader image -- The problem is not exclusive to images though, and is likely to affec

[Mesa-dev] [PATCH] glsl/es31:Allow GL_ARB_TEXTURE_MULTISAMPLE in GLSL ES 3.10

2015-05-12 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/glsl/builtin_functions.cpp | 3 +-- src/glsl/builtin_types.cpp | 2 +- src/glsl/glsl_lexer.ll | 13 +++-- src/glsl/glsl_parser_extras.h | 5 + 4 files changed, 14 insertions(+), 9 deletions(-) diff --git a/s

Re: [Mesa-dev] [PATCH v3] mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1

2015-05-12 Thread Ilia Mirkin
Not all contexts have geometry shaders. For example, ES 3.1 doesn't have them. Or a pre-3.2 GL context. This needs to be checked for MAX_GEOMETRY_ATOMIC_COUNTERS and the other one. On Tue, May 12, 2015 at 10:29 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > v3: only expose ARB_shader_atomi

[Mesa-dev] [PATCH v3] mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1

2015-05-12 Thread Marta Lofstedt
From: Marta Lofstedt v3: only expose ARB_shader_atomic_counters enums for gles 3.1 and GL core and remove functionality related to obsolete: extra_ARB_shader_atomic_counters_and_geometry_shader. Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 17 ++--- src/mesa

Re: [Mesa-dev] [PATCH 1/3] clover: Refactor event::trigger and ::abort to prevent deadlock and reentrancy issues.

2015-05-12 Thread Francisco Jerez
Tom Stellard writes: > On Sat, May 09, 2015 at 04:42:29PM +0300, Francisco Jerez wrote: >> Refactor ::trigger and ::abort to split out the operations that access >> concurrently modified data members and require locking from the >> recursive and possibly re-entrant part of these methods. This wi

Re: [Mesa-dev] [PATCH 03/29] i965: Define consistent interface to disable control flow execution masking.

2015-05-12 Thread Francisco Jerez
Kenneth Graunke writes: > On Monday, May 11, 2015 05:12:41 PM Matt Turner wrote: >> On Tue, May 5, 2015 at 9:57 AM, Francisco Jerez >> wrote: >> > Kenneth Graunke writes: >> > >> >> On Saturday, May 02, 2015 06:29:30 PM Francisco Jerez wrote: >> >>> --- >> >>> src/mesa/drivers/dri/i965/brw_ir

  1   2   >