Re: [Mesa-dev] [PATCH 03/16] main: store the common option in a struct of the Const part of the GL context

2015-06-08 Thread Martin Peres
On 05/06/15 16:53, Brian Paul wrote: This is a big patch that touches a lot of files all over the place. I wonder if it could be broken up a bit. In any case, comments below... Thanks for the quick review, Brian! I tried to keep the diff minimal but aside from the empty declarations and new

[Mesa-dev] [Bug 90797] [ALL bisected] Mesa change cause performance case manhattan fail.

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90797 Ding Heng changed: What|Removed |Added Status|REOPENED|NEW --- Comment #9 from Ding Heng --- (In r

[Mesa-dev] [PATCH 0/2] OES_texture_float + EXT_texture_rg

2015-06-08 Thread Tapani Pälli
Hello; These 2 patches add support for using GL_RED and GL_RG with floating point textures. Patches fix following failing tests in DEQP-GLES3: functional.fbo.completeness.renderable.texture.depth.rg_half_float_oes functional.fbo.completeness.renderable.texture.color0.red_half_float_oes functiona

[Mesa-dev] [PATCH 2/2] mesa: allow unsized formats GL_RG, GL_RED for GLES 3.0 with half float

2015-06-08 Thread Tapani Pälli
Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90748 --- src/mesa/main/glformats.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index edc4918..aa36cbb 100644 --- a/src/mesa/main/glformats.c +++ b/

[Mesa-dev] [PATCH 1/2] mesa: add GL_RED, GL_RG support for floating point textures

2015-06-08 Thread Tapani Pälli
Mesa supports EXT_texture_rg and OES_texture_float. This patch adds support for using unsized enums GL_RED and GL_RG for floating point targets and writes proper checks for internalformat when format is GL_RED or GL_RG and type is of GL_FLOAT or GL_HALF_FLOAT. Later, internalformat will get adjust

Re: [Mesa-dev] [PATCH 2/2] mesa: allow unsized formats GL_RG, GL_RED for GLES 3.0 with half float

2015-06-08 Thread Tapani Pälli
On 06/08/2015 11:14 AM, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90748 --- src/mesa/main/glformats.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index edc4918..aa3

Re: [Mesa-dev] [PATCH 1/5] mesa: Fix errors values returned by glShaderBinary()

2015-06-08 Thread Eduardo Lima Mitev
On 06/05/2015 03:38 AM, Ben Widawsky wrote: > On Wed, Mar 11, 2015 at 10:01:24AM +0100, Eduardo Lima Mitev wrote: >> Page 68, section 7.2 'Shader Binaries" of the of the OpenGL ES 3.1, >> and page 88 of the OpenGL 4.5 specs state: >> >> "An INVALID_VALUE error is generated if count or length is

[Mesa-dev] [PATCH] mesa: store full array type in gl_uniform_storage

2015-06-08 Thread Timothy Arceri
Previously only the type of a single array element was stored. _mesa_sampler_uniforms_pipeline_are_valid() was expecting to get the array type so this probably fixes a bug there. However the main reason for doing this is to use the array type for implementing arrays of arrays in glGetUniformLocati

Re: [Mesa-dev] [PATCH] mesa: store full array type in gl_uniform_storage

2015-06-08 Thread Timothy Arceri
Forgot to add that I did a full piglit run with no regressions. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH V2] mesa: store full array type in gl_uniform_storage

2015-06-08 Thread Timothy Arceri
Previously only the type of a single array element was stored. _mesa_sampler_uniforms_pipeline_are_valid() was expecting to get the array type so this probably fixes a bug there. However the main reason for doing this is to use the array type for implementing arrays of arrays in glGetUniformLocati

Re: [Mesa-dev] [PATCH 0/4] Fix some warnings caught by GCC5

2015-06-08 Thread Martin Peres
On 05/06/15 16:31, Brian Paul wrote: Series looks good to me. Reviewed-by: Brian Paul I pushed patches 1 and 4. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: fix GLES1 version initialization for gallium

2015-06-08 Thread Martin Peres
On 01/06/15 22:59, Matt Turner wrote: On Mon, Jun 1, 2015 at 12:44 PM, Marek Olšák wrote: From: Marek Olšák eglCreateContext was failing. Broken by 03fd6704db9f1d0f203bf8da18bd587c7e35ce60 --- src/mesa/main/version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/

Re: [Mesa-dev] [PATCH] glsl: fix constructing a vector from a matrix

2015-06-08 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/26/2015 03:32 PM, Martin Peres wrote: Without this patch, the following constructs (not an extensive list) would crash mesa: - mat2 foo = mat2(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); ivec4 bar = ivec4(foo); Th

[Mesa-dev] [PATCH 2/2] r600, compute: Allow image resource creation

2015-06-08 Thread Zoltan Gilian
Allow creation and binding of compute image resources to be able to test the currently working pieces of OpenCL image support. --- src/gallium/drivers/r600/evergreen_compute.c | 2 +- src/gallium/drivers/r600/evergreen_state.c| 4 src/gallium/drivers/r600/r600_state_common.c | 1 + src/

[Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-08 Thread Zoltan Gilian
Image attributes are passed to the kernel as hidden parameters after the image attribute itself. An llvm pass replaces the getter builtins to the appropriate parameters. --- src/gallium/state_trackers/clover/core/kernel.cpp | 13 ++ src/gallium/state_trackers/clover/core/memory.cpp | 2 +- ..

Re: [Mesa-dev] [PATCH 2/2] r600, compute: Allow image resource creation

2015-06-08 Thread Marek Olšák
On Mon, Jun 8, 2015 at 1:20 PM, Zoltan Gilian wrote: > Allow creation and binding of compute image resources to be able to test the > currently working pieces of OpenCL image support. > --- > src/gallium/drivers/r600/evergreen_compute.c | 2 +- > src/gallium/drivers/r600/evergreen_state.c| 4

[Mesa-dev] [PATCH v2] mesa: allow unsized formats GL_RG, GL_RED for GLES 3.0 with half float

2015-06-08 Thread Tapani Pälli
v2: && -> ||, we enable on gles3 or if ARB_texture_rg is enabled Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90748 --- src/mesa/main/glformats.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c in

Re: [Mesa-dev] [PATCH 1/2] clover: Implement image attribute getters

2015-06-08 Thread Francisco Jerez
Zoltan Gilian writes: > Image attributes are passed to the kernel as hidden parameters after the > image attribute itself. An llvm pass replaces the getter builtins to > the appropriate parameters. > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 13 ++ > src/gallium/state_trackers/

[Mesa-dev] [PATCH 1/4] mesa: Include simple_list.h explicitly in errors.c.

2015-06-08 Thread Francisco Jerez
This seems to be the only user of simple_list in core mesa not including the header explicitly. --- src/mesa/main/errors.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index 2aa1deb..16f10dd 100644 --- a/src/mesa/main/errors.c +++ b/src/mesa/m

[Mesa-dev] [PATCH 4/4] mesa: Drop include of simple_list.h from mtypes.h.

2015-06-08 Thread Francisco Jerez
simple_list.h defines a number of macros with short non-namespaced names that can easily collide with other declarations (first_elem, last_elem, next_elem, prev_elem, at_end), and according to the comment it was only being included because of struct simple_node, which is no longer used in this file

[Mesa-dev] [PATCH 3/4] dri/nouveau: Include simple_list.h explicitly in nv*_state_tnl.c.

2015-06-08 Thread Francisco Jerez
--- src/mesa/drivers/dri/nouveau/nv10_state_tnl.c | 2 ++ src/mesa/drivers/dri/nouveau/nv20_state_tnl.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/nouveau/nv10_state_tnl.c b/src/mesa/drivers/dri/nouveau/nv10_state_tnl.c index c0c7b26..1398385 100644 --- a/src/mesa

[Mesa-dev] [PATCH 2/4] tnl: Include simple_list.h explicitly in t_context.c.

2015-06-08 Thread Francisco Jerez
--- src/mesa/tnl/t_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/tnl/t_context.c b/src/mesa/tnl/t_context.c index 5b9dd54..bc77ba8 100644 --- a/src/mesa/tnl/t_context.c +++ b/src/mesa/tnl/t_context.c @@ -36,6 +36,7 @@ #include "math/m_xform.h" #include "main/state.h" #i

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #21 from Sami Liedes --- Ok, I bisected this because I was curious. The commit that fixed the black patches on minimum terrain setting was: commit 2b5355c8ab383d86bb6332dd29c417a6a1bc52bd Author: Ilia Mirkin Date: Wed May 6 23:29:

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #22 from Jérémy Viès --- Hi, I'm not "git aware", so I don't know how to check if this commit (2b5355c8ab383d86bb6332dd29c417a6a1bc52bd) has been done before the mesa-10.6 branch or not. Can someone check (or even better explain me h

Re: [Mesa-dev] [PATCH 17/38] i965/fs: Migrate Gen4 send dependency workarounds to the IR builder.

2015-06-08 Thread Francisco Jerez
Matt Turner writes: > On Thu, Jun 4, 2015 at 9:05 AM, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 26 +- >> src/mesa/drivers/dri/i965/brw_fs.h | 2 +- >> 2 files changed, 10 insertions(+), 18 deletions(-) >> >> diff --git a/src/mesa/drivers

Re: [Mesa-dev] [PATCH 1/4] mesa: Include simple_list.h explicitly in errors.c.

2015-06-08 Thread Brian Paul
On 06/08/2015 06:34 AM, Francisco Jerez wrote: This seems to be the only user of simple_list in core mesa not including the header explicitly. --- src/mesa/main/errors.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index 2aa1deb..16f10dd 1

Re: [Mesa-dev] [PATCH 31/38] i965/fs: Migrate translation of NIR control flow to the IR builder.

2015-06-08 Thread Francisco Jerez
Matt Turner writes: > On Thu, Jun 4, 2015 at 9:05 AM, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 23 --- >> 2 files changed, 14 insertions(+), 12 deletions(-) >> >> diff --git a/src/mesa/d

Re: [Mesa-dev] [PATCH 1/4] mesa: Include simple_list.h explicitly in errors.c.

2015-06-08 Thread Francisco Jerez
Brian Paul writes: > On 06/08/2015 06:34 AM, Francisco Jerez wrote: >> This seems to be the only user of simple_list in core mesa not >> including the header explicitly. >> --- >> src/mesa/main/errors.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/mesa/main/errors.c b/src/me

Re: [Mesa-dev] [PATCH 34/38] i965/fs: Migrate translation of NIR texturing instructions to the IR builder.

2015-06-08 Thread Francisco Jerez
Matt Turner writes: > On Thu, Jun 4, 2015 at 9:05 AM, Francisco Jerez wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 --- >> 2 files changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 1/2] clover: fix event handling of buffer operations

2015-06-08 Thread Tom Stellard
cc Francisco On Thu, May 28, 2015 at 10:10:19AM +0200, Grigori Goronzy wrote: > Wrap MapBuffer and MapImage as hard_event actions, like other > operations. This enables correct profiling. Also make sure to wait > for events to finish when blocking is requested by the caller. > --- > src/gallium/s

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 --- Comment #23 from Marek Olšák --- (In reply to Jérémy Viès from comment #22) > Hi, > > I'm not "git aware", so I don't know how to check if this commit > (2b5355c8ab383d86bb6332dd29c417a6a1bc52bd) has been done before the > mesa-10.6 branch o

Re: [Mesa-dev] [PATCH] RFC: drisw/glx: use XShm if possible

2015-06-08 Thread Adam Jackson
On Fri, 2015-06-05 at 19:14 +0200, Marc-André Lureau wrote: > XPutImage requires to copy the images around, and the request may be > split over several chunks. Using XShm may improve performance. Almost certainly will, the XPutImage implementation is fairly comic. > +static volatile int XErrorFla

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-06-08 Thread Jan Vesely
On Fri, Jun 5, 2015 at 1:49 PM, Marek Olšák wrote: > I don't think so. The LLVM IR generated by radeonsi is slightly > different from the one generated by r600g. The most code that can be > shared is shared already. > > Right now the main problem of the R600 LLVM backend is lack of > features. I

[Mesa-dev] [PATCHv2 35/38] i965/fs: Migrate test_fs_saturate_propagation to the IR builder.

2015-06-08 Thread Francisco Jerez
v2: Use set_saturate. Use fs_builder::OPCODE instead of ::emit. --- .../dri/i965/test_fs_saturate_propagation.cpp | 69 +++--- 1 file changed, 34 insertions(+), 35 deletions(-) diff --git a/src/mesa/drivers/dri/i965/test_fs_saturate_propagation.cpp b/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCHv2 36/38] i965/fs: Migrate test_fs_cmod_propagation to the IR builder.

2015-06-08 Thread Francisco Jerez
v2: Use set_predicate/condmod. Use fs_builder::OPCODE instead of ::emit. --- .../drivers/dri/i965/test_fs_cmod_propagation.cpp | 102 ++--- 1 file changed, 50 insertions(+), 52 deletions(-) diff --git a/src/mesa/drivers/dri/i965/test_fs_cmod_propagation.cpp b/src/mesa/drive

[Mesa-dev] [PATCHv2 08/38] i965/fs: Don't drop force_writemask_all and _sechalf when copying a CSE temporary.

2015-06-08 Thread Francisco Jerez
LOAD_PAYLOAD instructions need the same treatment as any other generator instructions, at least FB writes and typed surface messages will need a payload built with non-zero execution controls. --- Same as v1, with a longer explanation in the commit message. src/mesa/drivers/dri/i965/brw_fs_cse.cp

[Mesa-dev] [PATCHv2 26/38] i965/fs: Migrate FS framebuffer writes to the IR builder.

2015-06-08 Thread Francisco Jerez
The explicit call to fs_builder::group() in emit_single_fb_write() is required by the builder (otherwise the assertion in fs_builder::emit() would fail) because the subsequent LOAD_PAYLOAD and FB_WRITE instructions are in some cases emitted with a non-native execution width. The previous code woul

Re: [Mesa-dev] [PATCH 34/38] i965/fs: Migrate translation of NIR texturing instructions to the IR builder.

2015-06-08 Thread Matt Turner
On Mon, Jun 8, 2015 at 7:20 AM, Francisco Jerez wrote: > Matt Turner writes: > >> On Thu, Jun 4, 2015 at 9:05 AM, Francisco Jerez >> wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- >>> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 11 --- >>> 2 files changed, 6 inser

Re: [Mesa-dev] [PATCHv2 35/38] i965/fs: Migrate test_fs_saturate_propagation to the IR builder.

2015-06-08 Thread Matt Turner
On Mon, Jun 8, 2015 at 8:40 AM, Francisco Jerez wrote: > v2: Use set_saturate. Use fs_builder::OPCODE instead of ::emit. > --- Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listi

Re: [Mesa-dev] [PATCHv2 36/38] i965/fs: Migrate test_fs_cmod_propagation to the IR builder.

2015-06-08 Thread Matt Turner
On Mon, Jun 8, 2015 at 8:41 AM, Francisco Jerez wrote: > v2: Use set_predicate/condmod. Use fs_builder::OPCODE instead of > ::emit. > --- > .../drivers/dri/i965/test_fs_cmod_propagation.cpp | 102 > ++--- > 1 file changed, 50 insertions(+), 52 deletions(-) > > diff --git a/

Re: [Mesa-dev] [PATCH 01/38] i965/fs: Introduce FS IR builder.

2015-06-08 Thread Matt Turner
On Fri, Jun 5, 2015 at 4:13 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Fri, Jun 5, 2015 at 1:42 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> On Thu, Jun 4, 2015 at 9:04 AM, Francisco Jerez wrote: > The purpose of this change is threefold: First, it im

Re: [Mesa-dev] [PATCH 08/38] i965/fs: Don't drop force_writemask_all and _sechalf when copying a CSE temporary.

2015-06-08 Thread Matt Turner
On Fri, Jun 5, 2015 at 4:19 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Thu, Jun 4, 2015 at 9:04 AM, Francisco Jerez >> wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 2/3] i915: Blit RGBX<->RGBA drawpixels

2015-06-08 Thread Chris Wilson
On Sun, Jun 07, 2015 at 02:21:27AM -0700, Kenneth Graunke wrote: > On Sunday, June 07, 2015 11:29:16 AM Alexander Monakov wrote: > > On Sun, Jun 7, 2015 at 11:06 AM, Kenneth Graunke > > wrote: > > > On Friday, June 05, 2015 03:14:30 PM Chris Wilson wrote: > > >> The blitter already has code to ac

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-06-08 Thread Marek Olšák
On Mon, Jun 8, 2015 at 5:24 PM, Jan Vesely wrote: > > > On Fri, Jun 5, 2015 at 1:49 PM, Marek Olšák wrote: >> >> I don't think so. The LLVM IR generated by radeonsi is slightly >> different from the one generated by r600g. The most code that can be >> shared is shared already. >> >> Right now the

Re: [Mesa-dev] [PATCH 31/38] i965/fs: Migrate translation of NIR control flow to the IR builder.

2015-06-08 Thread Matt Turner
On Mon, Jun 8, 2015 at 7:00 AM, Francisco Jerez wrote: > Matt Turner writes: > >> On Thu, Jun 4, 2015 at 9:05 AM, Francisco Jerez >> wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_fs.h | 3 ++- >>> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 23 --- >>> 2 files chan

Re: [Mesa-dev] i965 FS back-end IR builder migration.

2015-06-08 Thread Matt Turner
On Thu, Jun 4, 2015 at 7:48 PM, Matt Turner wrote: > On Thu, Jun 4, 2015 at 9:04 AM, Francisco Jerez wrote: >> This series migrates the FS compiler back-end to the i965 IR builder I >> proposed a while ago as part of my ARB_shader_image_load_store series, >> and fixes a couple of bugs I found dur

Re: [Mesa-dev] [PATCH] i965/vec4: Fix the source register for indexed samplers

2015-06-08 Thread Matt Turner
On Thu, Jun 4, 2015 at 5:59 AM, Neil Roberts wrote: > Matt Turner writes: > >> I don't know why I was confused by this patch -- after arriving at the >> same conclusion independently I see that all of the analysis I needed >> was right there. > > Yes sorry, I probably didn't explain it very well.

Re: [Mesa-dev] [PATCH] RFC: drisw/glx: use XShm if possible

2015-06-08 Thread Marc-André Lureau
Hi Jose Thanks a lot for the quick feedback! On Fri, Jun 5, 2015 at 9:13 PM, Jose Fonseca wrote: > Sounds good in principle. I'm actually surprised this was happening > already. I always use llvmpipe the the non-DRI pure XLIB state tracker > which already does this. > > I saw that code, but I

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_COMPUTE_CAP_SUBGROUP_SIZE

2015-06-08 Thread Giuseppe Bilotta
On Sat, Jun 6, 2015 at 3:21 PM, Francisco Jerez wrote: > Giuseppe Bilotta writes: > >> What I was trying to say is that while the cap itself is per-device, >> the OpenCL property that relies on this cap isn't. >> In this sense, I would expect the cap to report the actual _hardware_ >> property, a

[Mesa-dev] [PATCH 2/2] gallium/ttn: add texture-type support

2015-06-08 Thread Rob Clark
From: Rob Clark v2: rebased on using SVIEW to hold type information Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/

[Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-08 Thread Rob Clark
From: Rob Clark Freedreno needs sampler type information to deal with int/uint textures. To accomplish this, start creating sampler-view declarations, as suggested here: http://lists.freedesktop.org/archives/mesa-dev/2014-November/071583.html create a sampler-view with index matching the sampl

Re: [Mesa-dev] [PATCH] RFC: drisw/glx: use XShm if possible

2015-06-08 Thread Marc-André Lureau
Hi Adam, Thanks for the feedback On Mon, Jun 8, 2015 at 5:12 PM, Adam Jackson wrote: > On Fri, 2015-06-05 at 19:14 +0200, Marc-André Lureau wrote: > > XPutImage requires to copy the images around, and the request may be > > split over several chunks. Using XShm may improve performance. > > Almo

[Mesa-dev] [Bug 90901] DrawElements regression: "Detected variance between two invariant values"

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90901 Bug ID: 90901 Summary: DrawElements regression: "Detected variance between two invariant values" Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64) OS: Li

[Mesa-dev] [Bug 90902] DrawElements regression: "Found invalid pixel values"

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90902 Bug ID: 90902 Summary: DrawElements regression: "Found invalid pixel values" Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH] RFC: drisw/glx: use XShm if possible

2015-06-08 Thread Adam Jackson
On Mon, 2015-06-08 at 20:19 +0200, Marc-André Lureau wrote: > This was based off similar code in xlib_sw_winsys.c You're right, that code's all wrong too. I'll send some patches to fix that up. - aja ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] [RFC v2 01/15] mesa/formats: define the 2D ASTC formats

2015-06-08 Thread Anuj Phogat
On Mon, Jun 1, 2015 at 10:13 AM, Nanley Chery wrote: > From: Nanley Chery > > Includes definition of the formats, updates to functions likely to be used, as > well as changes necessary for compilation. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/format_info.py | 3 + > src/mesa/main

Re: [Mesa-dev] [RFC v2 02/15] glapi: add support for KHR_texture_compression_astc_ldr

2015-06-08 Thread Anuj Phogat
On Mon, Jun 1, 2015 at 10:13 AM, Nanley Chery wrote: > From: Nanley Chery > > v2: correct the spelling of the sRGB variants. > remove spaces around "=" when setting the enum value. > Signed-off-by: Nanley Chery > --- > .../glapi/gen/KHR_texture_compression_astc.xml | 40 > +

[Mesa-dev] [Bug 90902] DrawElements regression: "Found invalid pixel values"

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90902 Kenneth Graunke changed: What|Removed |Added Component|GLX |Drivers/DRI/i965 Assignee|me

[Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-08 Thread Rob Clark
From: Rob Clark I need something like this in a couple places. And didn't see anything like it anywhere. Signed-off-by: Rob Clark --- v2: Added similar helper for nir_src, and cleaned up a few places that open coded this. There are a couple left (such as validate_alu_src()) but that handle is

[Mesa-dev] [Bug 90249] Fails to build egl_dri2 on osx

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90249 Julien Isorce changed: What|Removed |Added CC||bri...@vmware.com -- You are receiving

[Mesa-dev] [Bug 90249] Fails to build egl_dri2 on osx

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90249 Julien Isorce changed: What|Removed |Added Attachment #115468|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 08/38] i965/fs: Don't drop force_writemask_all and _sechalf when copying a CSE temporary.

2015-06-08 Thread Francisco Jerez
Matt Turner writes: > On Fri, Jun 5, 2015 at 4:19 PM, Francisco Jerez wrote: >> Matt Turner writes: >> >>> On Thu, Jun 4, 2015 at 9:04 AM, Francisco Jerez >>> wrote: --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH v2 08/15] egl/main: let EGL_RECORDABLE_ANDROID be a valid attrib

2015-06-08 Thread Eric Anholt
Chih-Wei Huang writes: > Signed-off-by: Chih-Wei Huang > --- > src/egl/main/eglconfig.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h > index 84cb227..7121b3d 100644 > --- a/src/egl/main/eglconfig.h > +++ b/src/egl/main/eglconfig.

[Mesa-dev] [Bug 90903] egl_dri2.c:dri2_load fails to load libglapi on osx

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90903 Bug ID: 90903 Summary: egl_dri2.c:dri2_load fails to load libglapi on osx Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 90903] egl_dri2.c:dri2_load fails to load libglapi on osx

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90903 Julien Isorce changed: What|Removed |Added CC||bri...@vmware.com -- You are receiving

[Mesa-dev] [Bug 90904] OSX: EXC_BAD_ACCESS when using translate_sse + gallium + softpipe/llvmpipe

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90904 Bug ID: 90904 Summary: OSX: EXC_BAD_ACCESS when using translate_sse + gallium + softpipe/llvmpipe Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] i965 FS back-end IR builder migration.

2015-06-08 Thread Francisco Jerez
Matt Turner writes: > On Thu, Jun 4, 2015 at 7:48 PM, Matt Turner wrote: >> On Thu, Jun 4, 2015 at 9:04 AM, Francisco Jerez >> wrote: >>> This series migrates the FS compiler back-end to the i965 IR builder I >>> proposed a while ago as part of my ARB_shader_image_load_store series, >>> and fi

[Mesa-dev] [Bug 90904] OSX: EXC_BAD_ACCESS when using translate_sse + gallium + softpipe/llvmpipe

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90904 Julien Isorce changed: What|Removed |Added CC||bri...@vmware.com --- Comment #1 from Ju

Re: [Mesa-dev] [PATCH v2 06/15] android: try to load gallium_dri.so directly

2015-06-08 Thread Eric Anholt
Chih-Wei Huang writes: > To avoid the trick of creating links for all dri drivers. > > Signed-off-by: Chih-Wei Huang > --- > src/egl/drivers/dri2/egl_dri2.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c > index fe5

[Mesa-dev] [Bug 90904] OSX: EXC_BAD_ACCESS when using translate_sse + gallium + softpipe/llvmpipe

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90904 --- Comment #2 from José Fonseca --- Probably the old (non-LLVM) JIT machine code generator doesn't support MacOSX. This patch should work around it: diff --git a/src/gallium/auxiliary/translate/translate_sse.c b/src/gallium/auxiliary/translate

[Mesa-dev] [Bug 90905] mesa: Finish subdir-objects transition

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90905 Bug ID: 90905 Summary: mesa: Finish subdir-objects transition Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v2 08/82] glsl: lower SSBO reads to ir_binop_ssbo_load expressions

2015-06-08 Thread Jordan Justen
Patches 3-8 Reviewed-by: Jordan Justen On 2015-06-03 00:00:58, Iago Toral Quiroga wrote: > From: Kristian Høgsberg > > The same we do for UBO loads with ir_binop_ubo_load. > --- > src/glsl/lower_ubo_reference.cpp | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/

Re: [Mesa-dev] [PATCH v2 09/82] mesa: Add shader storage buffer support to struct gl_context

2015-06-08 Thread Jordan Justen
On 2015-06-03 00:00:59, Iago Toral Quiroga wrote: > This includes the array of bindings, the current buffer bound to the > GL_SHADER_STORAGE_BUFFER target and a set of general limits and default > values for shader storage buffers. > --- > src/mesa/main/bufferobj.c | 5 + > src/mesa/main/conf

Re: [Mesa-dev] [RFC v2 14/15] i965: refactor miptree alignment calculation code

2015-06-08 Thread Anuj Phogat
On Mon, Jun 1, 2015 at 10:13 AM, Nanley Chery wrote: > From: Nanley Chery > > - Remove redundant checks and comments by grouping our calculations for > align_w and align_h wherever possible. > - Don't pass more parameters than necessary. > - Minor code simplifications. > > Signed-off-by: Nanley

[Mesa-dev] [Bug 90904] OSX: EXC_BAD_ACCESS when using translate_sse + gallium + softpipe/llvmpipe

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90904 --- Comment #3 from Julien Isorce --- (In reply to José Fonseca from comment #2) > diff --git a/src/gallium/auxiliary/rtasm/rtasm_execmem.c > b/src/gallium/auxiliary/rtasm/rtasm_execmem.c > index 8c3dbef..f935879 100644 > --- a/src/gallium/auxili

Re: [Mesa-dev] [PATCH 08/12] android: clean up the makefile of libGLES_mesa

2015-06-08 Thread Eric Anholt
Chih-Wei Huang writes: > Most of the logic for the gallium drivers has been moved to > src/gallium/targets/dri/Android.mk. I don't think this and the previous patch make sense on their own -- the previous one was dropping swrast but not the other drivers, and some of the gallium bits but not all

[Mesa-dev] [PATCH 6/6] i965/gen8+: Add aux buffer alignment assertions

2015-06-08 Thread Ben Widawsky
This helped find the incorrect HALIGN values from the previous patches. Since this patch adds the asserts, I thought it was a good place for the series' piglit results: http://otc-mesa-ci.jf.intel.com/view/dev/job/bwidawsk/lastSuccessfulBuild/ v2: Add PRM references for assertions (Chad) Signed-

[Mesa-dev] [PATCH 5/6] i965/gen9: Set HALIGN_16 for all aux buffers

2015-06-08 Thread Ben Widawsky
Just like the previous patch, but for the GEN9 constraints. v2: bugfix: Gen9 HALIGN was being set for all miptree buffers (Chad). To address this, move the check to where the gen8 check is, and do the appropriate conditional there. Signed-off-by: Ben Widawsky Cc: Chad Versace Reviewed-by: Anuj

[Mesa-dev] [PATCH 3/6] i965: Extract tiling from fast clear decision

2015-06-08 Thread Ben Widawsky
There are several constraints when determining if one can fast clear a surface. Some of these are alignment, pixel density, tiling formats, and others that vary by generation. The helper function which exists today does a suitable job, however it conflates "BO properties" with "Miptree properties"

[Mesa-dev] [PATCH 4/6] i965/gen8: Correct HALIGN for AUX surfaces

2015-06-08 Thread Ben Widawsky
This restriction was attempted in this commit: commit 47053464630888f819ef8cc44278f1a1220159b9 Author: Anuj Phogat Date: Fri Feb 13 11:21:21 2015 -0800 i965/gen8: Use HALIGN_16 if MCS is enabled for non-MSRT However, the commit itself doesn't achieve the desired goal as determined by the as

[Mesa-dev] [PATCH 2/6] i965/gen9: Only allow Y-Tiled MCS buffers

2015-06-08 Thread Ben Widawsky
For GEN9, much of the logic to use X-Tiled buffers has been stripped out. It is still supported in some places, but it's never desirable. Unfortunately we don't yet have the ability to have Y-Tiled scanout (see: http://patchwork.freedesktop.org/patch/46984/), NOTE: This patch shouldn't actually do

[Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-06-08 Thread Ben Widawsky
I think pretty much everyone agrees that having more than a single bool as a function argument is bordering on a bad idea. What sucks about the current code is in several instances it's necessary to propagate these boolean selections down to lower layers of the code. This requires plumbing (mechani

[Mesa-dev] [PATCH] i965/gen9: Use raw PS invocation count for queries

2015-06-08 Thread Ben Widawsky
Previously the number needed to be divided by 4 to get the proper results. Now the hardware does the right thing. Through experimentation it seems Braswell (CHV) does also need this. Fixes piglit test: arb_pipeline_statistics_query-frag Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH] i965/gen9: Use raw PS invocation count for queries

2015-06-08 Thread Ben Widawsky
On Mon, Jun 08, 2015 at 03:50:19PM -0700, Ben Widawsky wrote: > Previously the number needed to be divided by 4 to get the proper results. Now > the hardware does the right thing. Through experimentation it seems Braswell > (CHV) does also need this. I need to reword this, which I've done locally.

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-08 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Freedreno needs sampler type information to deal with int/uint textures. > To accomplish this, start creating sampler-view declarations, as > suggested here: > > http://lists.freedesktop.org/archives/mesa-dev/2014-November/071583.html These two are: Rev

[Mesa-dev] [Bug 90908] osx: src/mesa/x86-64/xform4.S does not build

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90908 Bug ID: 90908 Summary: osx: src/mesa/x86-64/xform4.S does not build Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 90908] osx: src/mesa/x86-64/xform4.S does not build

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90908 Julien Isorce changed: What|Removed |Added CC||bri...@vmware.com -- You are receiving

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 Peter Asplund changed: What|Removed |Added CC||peteraspl...@gentoo.se -- You are recei

[Mesa-dev] [Bug 90901] DrawElements regression: "Detected variance between two invariant values"

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90901 --- Comment #1 from Kenneth Graunke --- These all pass for me with Mesa master. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-d

[Mesa-dev] [PATCH] i965/fs_live_variables: Do liveness analysis bottom-to-top

2015-06-08 Thread Jason Ekstrand
Generally, liveness information propagates up the program, not down. Previously, we were walking the blocks forwards and updating the livein and then the liveout. However, the livein calculation depends on the liveout and the liveout depends on the successor blocks. The net result is that it take

[Mesa-dev] [Bug 90901] DrawElements regression: "Detected variance between two invariant values"

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90901 Kenneth Graunke changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 Assignee|me

[Mesa-dev] [Bug 89819] WebGL Conformance swrast failure in conformance/uniforms/uniform-default-values.html

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89819 --- Comment #5 from Roland Scheidegger --- FWIW I've fixed the crash. I don't see any failures anymore with neither chromium nor firefox in that test now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the a

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 8, 2015 at 8:15 PM, Rob Clark wrote: > From: Rob Clark > > Freedreno needs sampler type information to deal with int/uint textures. > To accomplish this, start creating sampler-view declarations, as > suggested here: > > http://lists.freedesktop.org/

[Mesa-dev] [Bug 90905] mesa: Finish subdir-objects transition

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90905 Erik Faye-Lund changed: What|Removed |Added CC||kusmab...@gmail.com --- Comment #1 from

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-08 Thread Roland Scheidegger
Am 08.06.2015 um 20:15 schrieb Rob Clark: > From: Rob Clark > > Freedreno needs sampler type information to deal with int/uint textures. > To accomplish this, start creating sampler-view declarations, as > suggested here: > > http://lists.freedesktop.org/archives/mesa-dev/2014-November/071583.h

[Mesa-dev] [Mesa3d-dev] Softpipe and OpenMP

2015-06-08 Thread Chih-Sheng Lin
Hi, I am working on parallelizing softpipe of Mesa-9.1 by using OpenMP. My idea is trying to do sp_setup_tri in parallel with multiple threads. So first in the function sp_vbuf_draw_elements, I duplicate setup_context for avoiding race condition And then sp_setup_tri is set to OpenMP parallel s

[Mesa-dev] [Bug 90905] mesa: Finish subdir-objects transition

2015-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90905 --- Comment #2 from Erik Faye-Lund --- Created attachment 116377 --> https://bugs.freedesktop.org/attachment.cgi?id=116377&action=edit subdir-objects2 Here's a version that works with out-of-tree builds, and also gets rid of --allow-multiple-d

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-08 Thread Rob Clark
On Mon, Jun 8, 2015 at 8:35 PM, Roland Scheidegger wrote: > Am 08.06.2015 um 20:15 schrieb Rob Clark: >> From: Rob Clark >> >> Freedreno needs sampler type information to deal with int/uint textures. >> To accomplish this, start creating sampler-view declarations, as >> suggested here: >> >> htt

Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

2015-06-08 Thread Roland Scheidegger
Am 09.06.2015 um 03:20 schrieb Rob Clark: > On Mon, Jun 8, 2015 at 8:35 PM, Roland Scheidegger wrote: >> Am 08.06.2015 um 20:15 schrieb Rob Clark: >>> From: Rob Clark >>> >>> Freedreno needs sampler type information to deal with int/uint textures. >>> To accomplish this, start creating sampler-vi

Re: [Mesa-dev] [Mesa3d-dev] Softpipe and OpenMP

2015-06-08 Thread Roland Scheidegger
Am 08.06.2015 um 09:33 schrieb Chih-Sheng Lin: > Hi, > > I am working on parallelizing softpipe of Mesa-9.1 by using OpenMP. > > My idea is trying to do sp_setup_tri in parallel with multiple threads. > > So first in the function sp_vbuf_draw_elements, I duplicate > setup_context for avoiding ra

  1   2   >