[Mesa-dev] [Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

2015-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91016 Kenneth Graunke changed: What|Removed |Added Component|Mesa core |Drivers/Gallium/i915g Assign

[Mesa-dev] [Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api

2015-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91015 Kenneth Graunke changed: What|Removed |Added Component|Mesa core |Drivers/Gallium/i915g Assign

[Mesa-dev] [Bug 91014] Piglit regression: spec/!OpenGL 1.2/texture-packed-formats

2015-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91014 Kenneth Graunke changed: What|Removed |Added Component|Mesa core |Drivers/Gallium/i915g Assign

Re: [Mesa-dev] [PATCH 1/2] i965: Split VUE map handling out of brw_vs.c into brw_vue_map.c.

2015-06-17 Thread Pohjolainen, Topi
On Wed, Jun 17, 2015 at 10:36:04PM -0700, Kenneth Graunke wrote: > This was originally only used by the vertex shader, but it's now used by > the geometry shader as well, and will also eventually be used for > tessellation control and evaluation shaders. > > I suspect it will be easier to find in

Re: [Mesa-dev] [PATCH v2 23/82] glsl: Do not do CSE for expressions involving SSBO loads

2015-06-17 Thread Iago Toral
On Wed, 2015-06-17 at 17:20 -0700, Jordan Justen wrote: > I wanted to question whether this was required, based on this text > from the extension spec: > > "The ability to write to buffer objects creates the potential for > multiple independent shader invocations to read and write the same > und

[Mesa-dev] [PATCH 3/5] egl/dri2: load libglapi.0.dylib on osx

2015-06-17 Thread Julien Isorce
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90903 Signed-off-by: Julien Isorce --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index a1cbd43..90b9648 100644 --- a/src/egl/drivers

[Mesa-dev] [PATCH 4/5] egl: use unix defines on osx with clang

2015-06-17 Thread Julien Isorce
CC egl_dri2.lo include/EGL/eglplatform.h:135:2: error: "Platform not recognized" include/EGL/eglplatform.h:140:9: error: unknown type name 'EGLNativeDisplayType' typedef EGLNativeDisplayType NativeDisplayType; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90249 Signed-off-by: Ju

[Mesa-dev] [PATCH 5/5] osx: fix asm support on darwin

2015-06-17 Thread Julien Isorce
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90908 Signed-off-by: Julien Isorce --- configure.ac | 2 +- src/mesa/x86-64/xform4.S | 53 +--- src/mesa/x86/assyntax.h | 2 +- 3 files changed, 30 insertions(+), 27 deletions(-) dif

[Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-17 Thread Julien Isorce
From: Jon TURNEY On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa software renderer the shader program handle is not a real pointer, but a integer handle Probably this

[Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-06-17 Thread Julien Isorce
From: Jon TURNEY _SET_DrawBuffers requires driDispatchRemapTable, so we need to link with libmesa for remap.c. libmesa requires the C++ linker. Also need to arrange to call _mesa_init_remap_table() to initialize the remap table. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90311 Signe

[Mesa-dev] [PATCH 1/2] i965: Split VUE map handling out of brw_vs.c into brw_vue_map.c.

2015-06-17 Thread Kenneth Graunke
This was originally only used by the vertex shader, but it's now used by the geometry shader as well, and will also eventually be used for tessellation control and evaluation shaders. I suspect it will be easier to find in a file named after the concept. Signed-off-by: Kenneth Graunke --- src/m

[Mesa-dev] [PATCH 2/2] i965: Add and fix comments in brw_vue_map.c.

2015-06-17 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_vue_map.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vue_map.c b/src/mesa/drivers/dri/i965/brw_vue_map.c index ff92bd2..7687578 100644 --- a/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH v2 23/82] glsl: Do not do CSE for expressions involving SSBO loads

2015-06-17 Thread Jordan Justen
On 2015-06-17 19:33:23, Matt Turner wrote: > On Wed, Jun 17, 2015 at 5:20 PM, Jordan Justen > wrote: > > I wanted to question whether this was required, based on this text > > from the extension spec: > > > > "The ability to write to buffer objects creates the potential for > > multiple independe

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-17 Thread Connor Abbott
On Wed, Jun 17, 2015 at 12:02 PM, Rob Clark wrote: > On Wed, Jun 17, 2015 at 2:27 PM, Connor Abbott wrote: >> So, as is, this patch isn't quite correct. When I originally wrote >> NIR, the idea was that the size of each instruction would be explicit >> -- that is, each instruction has it's own si

Re: [Mesa-dev] [PATCH v2 22/82] glsl: Do not kill dead assignments to buffer variables or SSBO declarations.

2015-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/15 21:24, Jordan Justen wrote: > On 2015-06-03 00:01:12, Iago Toral Quiroga wrote: >> If we kill dead assignments we lose the buffer writes. >> >> Also, we never kill UBO declarations even if they are never referenced >> by the shader, they are always considered active. Although the spec

Re: [Mesa-dev] [PATCH v2 17/82] mesa: Implement _mesa_BindBuffersBase for target GL_SHADER_STORAGE_BUFFER

2015-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/15 20:47, Jordan Justen wrote: > On 2015-06-03 00:01:07, Iago Toral Quiroga wrote: >> --- >> src/mesa/main/bufferobj.c | 142 >> ++ >> src/mesa/main/mtypes.h| 7 +++ >> 2 files changed, 149 insertions(+) >> >> diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH v2 21/82] glsl: Don't do tree grafting on buffer variables

2015-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/15 21:19, Jordan Justen wrote: > On 2015-06-03 00:01:11, Iago Toral Quiroga wrote: >> Otherwise we can lose writes into the buffers backing the variables. >> --- >> src/glsl/opt_tree_grafting.cpp | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/src/gl

Re: [Mesa-dev] [PATCH v2 18/82] mesa: Implement _mesa_BindBuffersRange for target GL_SHADER_STORAGE_BUFFER

2015-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/15 20:56, Jordan Justen wrote: > On 2015-06-03 00:01:08, Iago Toral Quiroga wrote: >> --- >> src/mesa/main/bufferobj.c | 110 >> ++ >> 1 file changed, 110 insertions(+) >> >> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH v2 16/82] mesa: Implement _mesa_DeleteBuffers for target GL_SHADER_STORAGE_BUFFER

2015-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/15 20:44, Jordan Justen wrote: > On 2015-06-03 00:01:06, Iago Toral Quiroga wrote: >> --- >> src/mesa/main/bufferobj.c | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c >> index a528787..0e762df 100644 >> --- a

[Mesa-dev] [PATCH] mesa: add GL_PROGRAM_PIPELINE support in KHR_debug calls

2015-06-17 Thread Ilia Mirkin
This was apparently missed when KHR_debug or ARB_sso support was added. Add label support to pipeline objects just like all the other debug-related objects. Signed-off-by: Ilia Mirkin Cc: "10.5 10.6" --- src/mesa/main/mtypes.h | 2 ++ src/mesa/main/objectlabel.c | 10 -- src/mesa/

Re: [Mesa-dev] [PATCH v2 23/82] glsl: Do not do CSE for expressions involving SSBO loads

2015-06-17 Thread Matt Turner
On Wed, Jun 17, 2015 at 5:20 PM, Jordan Justen wrote: > I wanted to question whether this was required, based on this text > from the extension spec: > > "The ability to write to buffer objects creates the potential for > multiple independent shader invocations to read and write the same > under

Re: [Mesa-dev] [RFC v2 10/15] i965: enable ASTC support for Skylake

2015-06-17 Thread Nanley Chery
I agree. This will be fixed in the next revision. On Tue, Jun 9, 2015 at 12:03 PM, Ian Romanick wrote: > Should this patch be last? It looks like later patches fix bugs. > > On 06/01/2015 10:13 AM, Nanley Chery wrote: >> From: Nanley Chery >> >> v2: remove OES ASTC extension reference. >> >> Si

Re: [Mesa-dev] [PATCH v2 23/82] glsl: Do not do CSE for expressions involving SSBO loads

2015-06-17 Thread Jordan Justen
I wanted to question whether this was required, based on this text from the extension spec: "The ability to write to buffer objects creates the potential for multiple independent shader invocations to read and write the same underlying memory. The same issue exists with the ARB_shader_image_loa

[Mesa-dev] [Bug 91016] Piglit regression: shaders/glsl-floating-constant-120

2015-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91016 Bug ID: 91016 Summary: Piglit regression: shaders/glsl-floating-constant-120 Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Marek Olšák
On Wed, Jun 17, 2015 at 4:48 PM, Dieter Nützel wrote: > Am 17.06.2015 14:34, schrieb Marek Olšák: >> >> Only the RadeonSI driver supports it right now. >> >> Marek > > > Marek, > > will we ever see something on r600 or do we need 'new' boards (Turks, here)? I would like to see on R600, but I don'

[Mesa-dev] [Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api

2015-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91015 Bug ID: 91015 Summary: Piglit regression: spec/ARB_occlusion_query2/api Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW S

[Mesa-dev] [Bug 91014] Piglit regression: spec/!OpenGL 1.2/texture-packed-formats

2015-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91014 Bug ID: 91014 Summary: Piglit regression: spec/!OpenGL 1.2/texture-packed-formats Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 2/2] glsl: add version checks to conditionals for builtin variable enablement

2015-06-17 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On Wed, 2015-06-17 at 15:15 -0400, Ilia Mirkin wrote: > A number of builtin variables have checks based on the extension being > enabled, but were missing enablement via a higher GLSL version. > > Signed-off-by: Ilia Mirkin > Cc: "10.5 10.6" > --- > src/glsl/builti

[Mesa-dev] [PATCH 4/4] i965/bxt: Add known PCI IDs

2015-06-17 Thread Ben Widawsky
These match the ones defined in the kernel. The only one tested by us is 0x0a84. Signed-off-by: Ben Widawsky --- include/pci_ids/i965_pci_ids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h index 8d757aa..4d8b419 100644 ---

[Mesa-dev] [PATCH 1/4] i965/bxt: Add basic Broxton infrastructure

2015-06-17 Thread Ben Widawsky
The thread counts and URB information are all speculative numbers that were based on some CHV numbers at the time. v2: Originally this patch had PCI IDs. I've moved that to a new patch at the end of the series. Remove is_cherryview hack. Cc: Neil Roberts Cc: "Lecluse, Philippe" Signed-off-by: B

[Mesa-dev] [PATCH 2/4] i965/bxt: Don't allow 16B pitch for blits

2015-06-17 Thread Ben Widawsky
NOTE: I can no longer find where this workaround is documented. In my notes it is required for BXT A*, and B*. I'm happy to drop the patch, but I figured I'd put it here for completeness. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_blit.c | 3 +++ 1 file changed, 3 insertions

[Mesa-dev] [PATCH 3/4] i965/gen9: Don't use encrypted MOCS

2015-06-17 Thread Ben Widawsky
On gen9+ MOCS is an index into a table. It is 7 bits, and AFAICT, bit 0 is for doing encrypted reads. I don't recall how I decided to do this for BXT. I don't know this patch was ever needed, since it seems nothing is broken today on SKL. Furthermore, this patch may no longer be needed because of

Re: [Mesa-dev] [PATCH] mesa: store full array type in gl_uniform_storage

2015-06-17 Thread Timothy Arceri
I've sent a smaller fix for this bug, will save this change for an upcoming AoA patch series. On Wed, 2015-06-17 at 22:24 +1000, Timothy Arceri wrote: > I've created a new piglit test to confirm this fixes a bug in > _mesa_sampler_uniforms_pipeline_are_valid() > > http://lists.freedesktop.org/arc

[Mesa-dev] [PATCH] mesa: fix active sampler conflict validation for arrays

2015-06-17 Thread Timothy Arceri
The type stored in gl_uniform_storage is the type of a single array element not the array type so size was always 1 --- src/mesa/main/uniform_query.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Fixes new piglit test: http://lists.freedesktop.org/archives/piglit/2015-June/016270

Re: [Mesa-dev] [PATCH v2 22/82] glsl: Do not kill dead assignments to buffer variables or SSBO declarations.

2015-06-17 Thread Jordan Justen
On 2015-06-03 00:01:12, Iago Toral Quiroga wrote: > If we kill dead assignments we lose the buffer writes. > > Also, we never kill UBO declarations even if they are never referenced > by the shader, they are always considered active. Although the spec > does not seem say this specifically for SSBO

Re: [Mesa-dev] [PATCH v2 21/82] glsl: Don't do tree grafting on buffer variables

2015-06-17 Thread Jordan Justen
On 2015-06-03 00:01:11, Iago Toral Quiroga wrote: > Otherwise we can lose writes into the buffers backing the variables. > --- > src/glsl/opt_tree_grafting.cpp | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/glsl/opt_tree_grafting.cpp b/src/glsl/opt_tree_graf

[Mesa-dev] [PATCH 1/2] glsl: handle conversions to double when comparing param matches

2015-06-17 Thread Ilia Mirkin
This allows mod(int, int) to become selected as float mod when doubles are supported. Signed-off-by: Ilia Mirkin Cc: "10.6" --- src/glsl/ir_function.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp index 2b2643c.

Re: [Mesa-dev] [PATCH v2 20/82] mesa: Implement _mesa_BindBufferRange for target GL_SHADER_STORAGE_BUFFER

2015-06-17 Thread Jordan Justen
19-20 Reviewed-by: Jordan Justen On 2015-06-03 00:01:10, Iago Toral Quiroga wrote: > --- > src/mesa/main/bufferobj.c | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index fb5331e..4277880 100

[Mesa-dev] [PATCH 2/2] glsl: add version checks to conditionals for builtin variable enablement

2015-06-17 Thread Ilia Mirkin
A number of builtin variables have checks based on the extension being enabled, but were missing enablement via a higher GLSL version. Signed-off-by: Ilia Mirkin Cc: "10.5 10.6" --- src/glsl/builtin_variables.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-17 Thread Rob Clark
On Wed, Jun 17, 2015 at 2:27 PM, Connor Abbott wrote: > So, as is, this patch isn't quite correct. When I originally wrote > NIR, the idea was that the size of each instruction would be explicit > -- that is, each instruction has it's own size, and the size of > registers/SSA values was merely a h

Re: [Mesa-dev] [PATCH v2 18/82] mesa: Implement _mesa_BindBuffersRange for target GL_SHADER_STORAGE_BUFFER

2015-06-17 Thread Jordan Justen
On 2015-06-03 00:01:08, Iago Toral Quiroga wrote: > --- > src/mesa/main/bufferobj.c | 110 > ++ > 1 file changed, 110 insertions(+) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index c8b29a7..70ac638 100644 > --- a/src/mesa/

Re: [Mesa-dev] [PATCH v2 17/82] mesa: Implement _mesa_BindBuffersBase for target GL_SHADER_STORAGE_BUFFER

2015-06-17 Thread Jordan Justen
On 2015-06-03 00:01:07, Iago Toral Quiroga wrote: > --- > src/mesa/main/bufferobj.c | 142 > ++ > src/mesa/main/mtypes.h| 7 +++ > 2 files changed, 149 insertions(+) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index 0

Re: [Mesa-dev] [PATCH v2 16/82] mesa: Implement _mesa_DeleteBuffers for target GL_SHADER_STORAGE_BUFFER

2015-06-17 Thread Jordan Justen
On 2015-06-03 00:01:06, Iago Toral Quiroga wrote: > --- > src/mesa/main/bufferobj.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index a528787..0e762df 100644 > --- a/src/mesa/main/bufferobj.c > +++ b/src/mesa/main/b

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-17 Thread Connor Abbott
So, as is, this patch isn't quite correct. When I originally wrote NIR, the idea was that the size of each instruction would be explicit -- that is, each instruction has it's own size, and the size of registers/SSA values was merely a hint to say "by the way, you actually need this many components

Re: [Mesa-dev] [PATCH 0/4] CLOEXEC fix-ups

2015-06-17 Thread Kristian Høgsberg
On Wed, Jun 17, 2015 at 9:28 AM, Derek Foreman wrote: > This series catches a couple of places where we forget to set CLOEXEC on > file descriptors, and makes a helper function for the necessarily ugly > way we have to open fds to make sure CLOEXEC is set. > > Derek Foreman (4): > egl/drm: Dupli

Re: [Mesa-dev] [PATCH 03/14] mesa: Fix conditions to test signed, unsigned integer format

2015-06-17 Thread Anuj Phogat
On Tue, Jun 16, 2015 at 9:16 PM, Jason Ekstrand wrote: > Please note in the commit message exactly what is broken. > I didn't notice any piglit failure without this change. As requested I'll add this in the commit message: "Just checking the type in glReadPixels() is not sufficient to decide if t

[Mesa-dev] [PATCH 2/4] loader: Rename drm_open_device() to loader_open_device() and share it

2015-06-17 Thread Derek Foreman
This is already our common idiom for opening files with CLOEXEC and it's a little ugly, so let's share this one implementation. Signed-off-by: Derek Foreman --- src/loader/loader.c | 6 +++--- src/loader/loader.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/loader/

[Mesa-dev] [PATCH 3/4] glx: Use loader_open_device() helper

2015-06-17 Thread Derek Foreman
We've moved the open with CLOEXEC idiom into a helper function, so call it instead of duplicating the code here. Signed-off-by: Derek Foreman --- src/glx/dri2_glx.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 538cf1a

[Mesa-dev] [PATCH 1/4] egl/drm: Duplicate fd with F_DUPFD_CLOEXEC to prevent leak

2015-06-17 Thread Derek Foreman
Replacing dup() with fcntl F_DUPFD_CLOEXEC creates the duplicate file descriptor with CLOEXEC so it won't be leaked to child processes if the process fork()s later. Signed-off-by: Derek Foreman --- src/egl/drivers/dri2/platform_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Mesa-dev] [PATCH 4/4] egl: Use the loader_open_device() helper to do open with CLOEXEC

2015-06-17 Thread Derek Foreman
We've moved the open with CLOEXEC idiom into a helper function, so call it instead of duplicating the code. This also replaces a couple of opens that didn't properly do CLOEXEC. Signed-off-by: Derek Foreman --- src/egl/drivers/dri2/platform_drm.c | 4 ++-- src/egl/drivers/dri2/platform

[Mesa-dev] [PATCH 0/4] CLOEXEC fix-ups

2015-06-17 Thread Derek Foreman
This series catches a couple of places where we forget to set CLOEXEC on file descriptors, and makes a helper function for the necessarily ugly way we have to open fds to make sure CLOEXEC is set. Derek Foreman (4): egl/drm: Duplicate fd with F_DUPFD_CLOEXEC to prevent leak loader: Rename drm_

Re: [Mesa-dev] [PATCH 01/14] gallium: add PIPE_CAP_MAX_SHADER_PATCH_VARYINGS

2015-06-17 Thread Ilia Mirkin
There appears to be a tabs/spaces screwup in vc4_screen.c, otherwise this patch is Reviewed-by: Ilia Mirkin Could I trouble you to land this sooner rather than later? The gallium-side driver impl depends on this too. I guess I could just carry it in my nvc0-tess tree as well. On Tue, Jun 16, 20

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Dieter Nützel
Am 17.06.2015 14:34, schrieb Marek Olšák: Only the RadeonSI driver supports it right now. Marek Marek, will we ever see something on r600 or do we need 'new' boards (Turks, here)? GREAT stuff. -Dieter On Wed, Jun 17, 2015 at 2:21 PM, Ilyes Gouta wrote: Hi, On Wed, Jun 17, 2015 at 1:0

Re: [Mesa-dev] [PATCH] nir: add helper to get # of src/dest components

2015-06-17 Thread Iago Toral
On Mon, 2015-06-08 at 15:45 -0400, Rob Clark wrote: > From: Rob Clark > > I need something like this in a couple places. And didn't see anything > like it anywhere. We ended up doing something similar in our work-in-progress nir/vec4 pass, it makes the code a bit easier to read, so if nobody el

Re: [Mesa-dev] [PATCH] i965: correct alignment units for 2D compressed textures on Skylake

2015-06-17 Thread Nanley Chery
Thanks for the diagram and explanation. The Bspec's Calculating Texel Location for 2D Surfaces section says that each LOD's width and height is determined by a formula using an alignment term. One reason is to calculate the LOD positions. I'm assuming another is to prevent the sampler engine from f

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Roland Scheidegger
No, there is no such list. On that list would be: - implement multisampling (basic GL 3.0 feature, we cheat our way out of it...) - related to multisampling, rewrite attribute interpolation. This has problems nowadays even without msaa (particularly precision loss if a tri is far away from screen o

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Ilyes Gouta
Hi, On Wed, Jun 17, 2015 at 1:51 PM, Roland Scheidegger wrote: > No. And as far as I know noone is working on it for llvmpipe. If I'd > write a to do list for llvmpipe, that would probably be on page 50 or so > :-). But patches always welcome... Well, is such a to-do list for LLVMpipe online?

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Roland Scheidegger
No. And as far as I know noone is working on it for llvmpipe. If I'd write a to do list for llvmpipe, that would probably be on page 50 or so :-). But patches always welcome... Roland Am 17.06.2015 um 14:21 schrieb Ilyes Gouta: > Hi, > > On Wed, Jun 17, 2015 at 1:03 PM, Dragomir Ivanov

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Marek Olšák
Only the RadeonSI driver supports it right now. Marek On Wed, Jun 17, 2015 at 2:21 PM, Ilyes Gouta wrote: > Hi, > > On Wed, Jun 17, 2015 at 1:03 PM, Dragomir Ivanov > wrote: >> >> Wonderful Marek. Many thanks to you all. I hope till the end of the year >> we will have OGL 4.3 in Mesa. > > > Is

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Dragomir Ivanov
I only guess, that TESS is too much for the software rasterization, so they may very well fake it. On Wed, Jun 17, 2015 at 3:21 PM, Ilyes Gouta wrote: > Hi, > > On Wed, Jun 17, 2015 at 1:03 PM, Dragomir Ivanov > wrote: > >> Wonderful Marek. Many thanks to you all. I hope till the end of the yea

Re: [Mesa-dev] [PATCH] mesa: store full array type in gl_uniform_storage

2015-06-17 Thread Timothy Arceri
I've created a new piglit test to confirm this fixes a bug in _mesa_sampler_uniforms_pipeline_are_valid() http://lists.freedesktop.org/archives/piglit/2015-June/016270.html I'll update the commit message to: "Previously only the type of a single array element was stored. _mesa_sampler_uniforms

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Ilyes Gouta
Hi, On Wed, Jun 17, 2015 at 1:03 PM, Dragomir Ivanov wrote: > Wonderful Marek. Many thanks to you all. I hope till the end of the year > we will have OGL 4.3 in Mesa. > Is LLVMpipe (and software rasterziation) also supported? Ilyes > > On Wed, Jun 17, 2015 at 2:18 AM, Marek Olšák wrote: > >

Re: [Mesa-dev] [PATCHES] Tessellation is here

2015-06-17 Thread Dragomir Ivanov
Wonderful Marek. Many thanks to you all. I hope till the end of the year we will have OGL 4.3 in Mesa. On Wed, Jun 17, 2015 at 2:18 AM, Marek Olšák wrote: > You can also use this for nicer reviewing: > http://cgit.freedesktop.org/~mareko/mesa/log/?h=tessellation-review > > Please note that there

[Mesa-dev] [PATCH 2/2] i965: Actually enable L3 caching for everything on CHV

2015-06-17 Thread ville . syrjala
From: Ville Syrjälä Looks like CHV MOCS behaves a bit differently than BDW MOCS. On BDW the target cache bits can be used to enable L3 caching regardless if how the other bits are set up to select the UC/WT/WB caching mode for LLC/eLLC. On CHV however it appears that the other bits control the ca

[Mesa-dev] [PATCH 1/2] i965: House MOCS settings in brw_context/brw_device_info

2015-06-17 Thread ville . syrjala
From: Ville Syrjälä The layout of the MOCS bits has kept changing for each new platform. Instead of adding platform checks all over the place just store the MOCS settings in the device info and context. Currently MOCS is only ever set up in two ways: either let the PTE choose the LLC/eLLC cachin

Re: [Mesa-dev] [PATCH] winsys/radeon: Unmap GPU VM address range when destroying BO

2015-06-17 Thread Christian König
On 17.06.2015 04:54, Michel Dänzer wrote: On 16.06.2015 20:39, Christian König wrote: On 16.06.2015 10:56, Michel Dänzer wrote: On 16.06.2015 17:34, Christian König wrote: What we would need to really clean that up is to make the VM mappings per GEM handle like you suggested or allow multiple

Re: [Mesa-dev] [PATCH 13/46] mesa: require VS if TCS or TES is present in pipeline

2015-06-17 Thread Marek Olšák
Sure. Marek On Wed, Jun 17, 2015 at 2:54 AM, Jordan Justen wrote: > On 2015-06-16 17:02:57, Marek Olšák wrote: >> On Wed, Jun 17, 2015 at 1:46 AM, Jordan Justen >> wrote: >> > This patch was in a range of 11 patches that I added my r-b for: >> > http://lists.freedesktop.org/archives/mesa-dev/20

Re: [Mesa-dev] [PATCH 2/9] i965: Fix textureGrad with cube samplers

2015-06-17 Thread Iago Toral
On Tue, 2015-06-16 at 23:52 -0700, Ben Widawsky wrote: > On Tue, Feb 24, 2015 at 07:02:50PM +0100, Eduardo Lima Mitev wrote: > > From: Iago Toral Quiroga > > > > We can't use sampler messages with gradient information (like > > sample_g or sample_d) to deal with this scenario because according >

Re: [Mesa-dev] [PATCH 2/9] i965: Fix textureGrad with cube samplers

2015-06-17 Thread Iago Toral
On Tue, 2015-06-16 at 23:52 -0700, Ben Widawsky wrote: > On Tue, Feb 24, 2015 at 07:02:50PM +0100, Eduardo Lima Mitev wrote: > > From: Iago Toral Quiroga > > > > We can't use sampler messages with gradient information (like > > sample_g or sample_d) to deal with this scenario because according >