Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glsl: validate sampler array indexing for 'constant-index-expression'

2015-06-30 Thread Tapani Pälli
Hi Emil; I got r-b now for all the patches considering this series. At least one of these (i965: use EmitNoIndirectSampler for gen 7) does not apply as is to the 10.6 tree as it is due to other changes. How does the process go, should I sent a separate patch for 10.6 tree (there the change

Re: [Mesa-dev] [PATCH 08/78] i965/nir/vec4: Add setup for system values

2015-06-30 Thread Alejandro Piñeiro
On 30/06/15 01:34, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Alejandro Piñeiro apinhe...@igalia.com Similar to other variable setups, system values will initialize the corresponding register inside a 'nir_system_values' map,

Re: [Mesa-dev] [PATCH 06/78] i965/nir/vec4: Add setup of uniform variables

2015-06-30 Thread Iago Toral
Hi Jason, On Mon, 2015-06-29 at 16:22 -0700, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com This is based on similar code existing in vec4_visitor. It builds the uniform register file iterating

[Mesa-dev] [PATCH 2/2] i965/fs: Use the builder directly for the gen6 interpolation add(32)

2015-06-30 Thread Jason Ekstrand
Now that we can create builders with a bigger width than their parent as long as it's exec_all, we don't need to create the instruction manually. --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] i965/fs: Relax fs_builder channel group assertion when force_writemask_all is on.

2015-06-30 Thread Jason Ekstrand
From: Francisco Jerez curroje...@riseup.net This assertion was meant to catch code inadvertently escaping the control flow jail determined by the group of channel enable signals selected by some caller, however it seems useful to be able to increase the default execution size as long as

Re: [Mesa-dev] [PATCH 2/3] gallivm: add fp64 support.

2015-06-30 Thread Dave Airlie
On 1 July 2015 at 00:52, Roland Scheidegger srol...@vmware.com wrote: Am 30.06.2015 um 03:42 schrieb Dave Airlie: On 30 June 2015 at 09:36, Roland Scheidegger srol...@vmware.com wrote: Am 29.06.2015 um 22:18 schrieb Dave Airlie: On 30 June 2015 at 00:58, Roland Scheidegger srol...@vmware.com

Re: [Mesa-dev] [PATCH] gallivm: add fp64 support. (v2)

2015-06-30 Thread Dave Airlie
LLVMValueRef base_ptr, LLVMValueRef indexes, - LLVMValueRef overflow_mask) + LLVMValueRef overflow_mask, LLVMValueRef indexes2) { struct gallivm_state *gallivm = bld_base-base.gallivm; LLVMBuilderRef builder = gallivm-builder;

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

2015-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91169 Bug ID: 91169 Summary: The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] git fsck errors on mesa repo

2015-06-30 Thread Liam R. Howlett
* Emil Velikov emil.l.veli...@gmail.com [150630 10:04]: Hi Liam, On 29/06/15 18:23, Liam R. Howlett wrote: Hello, Since git 2.3, there have been a number of new fsck options added which produce issues when I clone the repository git://anongit.freedesktop.org/git/mesa/mesa Can

[Mesa-dev] [PATCH v2] nvc0: create screen fence objects with coherent attribute

2015-06-30 Thread Alexandre Courbot
This is required on non-coherent architectures to ensure the value of the fence is correct at all times. Failure to do this results in the display freezing for a few seconds every now and then on Tegra. The NOUVEAU_BO_COHERENT is a no-op for coherent architectures, so behavior on x86 should not

[Mesa-dev] [PATCH] i965/fs: Don't use the pixel interpolater for centroid interpolation

2015-06-30 Thread Neil Roberts
For centroid interpolation we can just directly use the values set up in the shader payload instead of querying the pixel interpolator. To do this we need to modify brw_compute_barycentric_interp_modes to detect when interpolateAtCentroid is called. This fixes the interpolateAtCentroid tests on

Re: [Mesa-dev] git fsck errors on mesa repo

2015-06-30 Thread Emil Velikov
Hi Liam, On 29/06/15 18:23, Liam R. Howlett wrote: Hello, Since git 2.3, there have been a number of new fsck options added which produce issues when I clone the repository git://anongit.freedesktop.org/git/mesa/mesa Can you be more specific about the fsck options and the messages that

Re: [Mesa-dev] [PATCH 06/78] i965/nir/vec4: Add setup of uniform variables

2015-06-30 Thread Jason Ekstrand
On Jun 30, 2015 1:05 AM, Iago Toral ito...@igalia.com wrote: Hi Jason, On Mon, 2015-06-29 at 16:22 -0700, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com This is based on similar code

[Mesa-dev] [Bug 91169] The Chronicles of Riddick: Assault on Dark Athena fails to start with nouveau

2015-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91169 --- Comment #1 from Ilia Mirkin imir...@alum.mit.edu --- One thing to note is that the shaders don't *actually* use the functionality. They all have the same copy pasted adapter which makes glsl look more like hlsl, and it includes some

Re: [Mesa-dev] [PATCH 78/78] nir: Fix output swizzle in get_mul_for_src

2015-06-30 Thread Samuel Iglesias Gonsálvez
On 01/07/15 01:41, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:07 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Avoid copying an overwritten swizzle, use the original values. Bugzilla:

[Mesa-dev] [Bug 91173] Oddworld: Stranger's Wrath HD: disfigured models in wrong colors

2015-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91173 Bug ID: 91173 Summary: Oddworld: Stranger's Wrath HD: disfigured models in wrong colors Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [PATCH 7/8] pipe-loader: use loader_open_device() rather than open()

2015-06-30 Thread Emil Velikov
The former handles O_CLOEXEC (and the lack of it) appropriately. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c

[Mesa-dev] [PATCH 8/8] auxiliary/vl: use loader_open_device() over open()

2015-06-30 Thread Emil Velikov
The former handles O_CLOEXEC (and the lack of it) appropriately. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/Makefile.am| 1 + src/gallium/auxiliary/vl/vl_winsys_dri.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] radeonsi: directly include radeon/* headers

2015-06-30 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/radeonsi/cik_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/cik_sdma.c b/src/gallium/drivers/radeonsi/cik_sdma.c index 86111cb..47b586f 100644 ---

[Mesa-dev] [PATCH 6/8] pipe-loader: remove pipe_loader_sw_probe_xlib

2015-06-30 Thread Emil Velikov
It was only useful for st/egl, although I've never got to merging the pipe-loader and inline-helpers before it was removed. There are no users for it ATM. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 13 ++-

[Mesa-dev] [PATCH 3/8] pipe-loader: remove pipe_loader_drm_probe_fd() x_auth argument

2015-06-30 Thread Emil Velikov
No longer used by anyone, as of last commit. Cc: Tom Stellard thomas.stell...@amd.com Cc: Francisco Jerez curroje...@riseup.net Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/pipe-loader/pipe_loader.h| 6 +- .../auxiliary/pipe-loader/pipe_loader_drm.c

[Mesa-dev] [PATCH 5/8] automake: remove empty GALLIUM_PIPE_LOADER_LIBS

2015-06-30 Thread Emil Velikov
Cc: Rob Clark robcl...@freedesktop.org Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 1 - src/gallium/auxiliary/pipe-loader/Makefile.am | 3 --- src/gallium/targets/d3dadapter9/Makefile.am | 3 +-- src/gallium/targets/dri/Makefile.am

[Mesa-dev] [PATCH 4/8] automake: pipe-loader: remove the 'client' pipe-loader

2015-06-30 Thread Emil Velikov
Was only around as opencl's pipe-loader needed to link against xcb. Cc: Rob Clark robcl...@freedesktop.org Cc: Tom Stellard thomas.stell...@amd.com Cc: Francisco Jerez curroje...@riseup.net Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac |

[Mesa-dev] [PATCH 0/8] Render node only opencl and pipe-loader cleanups

2015-06-30 Thread Emil Velikov
Hello all, As mentioned over IRC a few weeks back, here is a series that removes support for non-render node devices. The two main motivations being: - Currently we force X/xcb onto everyone that wants to use OpenCL (headless OpenCL systems/farms anyone ?) - Nice overall cleanup - 43

[Mesa-dev] [PATCH 1/8] pipe-loader: drop support for non-render node devices

2015-06-30 Thread Emil Velikov
Render nodes have been around for quite some time. Removing support via the master/primary node allows us to clean up the conditional compilation and simplify the build greatly. For example currently we the pipe-loader, with an explicit link against xcb and friends (for X auth). Although forcing

[Mesa-dev] [PATCH 2/8] pipe-loader: simplify pipe_loader_drm_probe

2015-06-30 Thread Emil Velikov
Do not iterate and (attempt to) open the render device, if we're over the requested number of devices. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [Bug 84570] Borderlands 2/Pre-Sequel: Constant frame rate drops while playing; really bad with additionl lighting

2015-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84570 --- Comment #37 from Ian C. Bullard ibull...@aspyr.com --- Just so you're aware... The glDrawRangeElements fix mentioned above should be live. I've checked our depot's history and no rendering code changes have been made since January. If

Re: [Mesa-dev] [PATCH v2 09/19] i965/fs: Add a builder argument to offset()

2015-06-30 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 42 src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 58 +--

Re: [Mesa-dev] [PATCH v2 12/19] i965/fs: Use exec_size for determining regs read/written and partial writes

2015-06-30 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/8] pipe-loader: drop support for non-render node devices

2015-06-30 Thread Martin Peres
On 30/06/15 18:09, Emil Velikov wrote: Render nodes have been around for quite some time. Removing support via the master/primary node allows us to clean up the conditional compilation and simplify the build greatly. For example currently we the pipe-loader, with an explicit link against The

Re: [Mesa-dev] [RFC] Compatibility between old dri modules and new loaders, and vice verse

2015-06-30 Thread Emil Velikov
On 22 June 2015 at 23:19, Dave Airlie airl...@gmail.com wrote: On 23 June 2015 at 08:16, Ian Romanick i...@freedesktop.org wrote: On 06/22/2015 11:54 AM, Dave Airlie wrote: As kindly hinted by Marek, currently we do have a wide selection of supported dri loader combinations. Although we

Re: [Mesa-dev] [PATCH] gallivm: add fp64 support. (v2)

2015-06-30 Thread Roland Scheidegger
Am 30.06.2015 um 03:41 schrieb Dave Airlie: This adds support for ARB_gpu_shader_fp64 and ARB_vertex_attrib_64bit to llvmpipe. Two things that don't mix well are SoA and doubles, see emit_fetch_double, and emit_store_double_chan in this. I've also had to split emit_data.chan, to add

Re: [Mesa-dev] [PATCH 2/3] gallivm: add fp64 support.

2015-06-30 Thread Roland Scheidegger
Am 30.06.2015 um 03:42 schrieb Dave Airlie: On 30 June 2015 at 09:36, Roland Scheidegger srol...@vmware.com wrote: Am 29.06.2015 um 22:18 schrieb Dave Airlie: On 30 June 2015 at 00:58, Roland Scheidegger srol...@vmware.com wrote: Don't worry about the AoS stuff. Only meant to do simple things.

Re: [Mesa-dev] [PATCH 1/8] pipe-loader: drop support for non-render node devices

2015-06-30 Thread Emil Velikov
On 30 June 2015 at 16:06, Martin Peres martin.pe...@free.fr wrote: On 30/06/15 18:09, Emil Velikov wrote: Render nodes have been around for quite some time. Removing support via the master/primary node allows us to clean up the conditional compilation and simplify the build greatly. For

Re: [Mesa-dev] [PATCH] glx: Drop CRAY support.

2015-06-30 Thread Emil Velikov
On 29 June 2015 at 17:58, Matt Turner matts...@gmail.com wrote: It couldn't have worked anyway. There were calls to undefined functions. Reviewed-by: Emil Velikov emil.l.veli...@gmail.com Nice one ! Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/4] egl/drm: plug memory leak

2015-06-30 Thread Emil Velikov
On 27 June 2015 at 09:46, Marek Olšák mar...@gmail.com wrote: For the whole series: Reviewed-by: Marek Olšák marek.ol...@amd.com Fixed the typo spotted by Michel and pushed to master. Thank you Marek. -Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-30 Thread Jason Ekstrand
Another general comment: It seems like you may have copied+pasted a bit much when it comes to handling arrays in the backend. In the FS backend, we have to multiply lots of stuff by reg-num_components because we need to scalarize it. In the vec4 backend, we don't need to do this because

Re: [Mesa-dev] [PATCH 13/78] i965/nir/vec4: Implement conditional statements (nir_cf_node_if)

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com The same we do in the FS NIR backend, only that here we need to consider the number of components in the condition and adjust the swizzle accordingly. Bugzilla:

Re: [Mesa-dev] [PATCH 18/78] i965: Take is_scalar_shader_stage() method out to allow reuse

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: This patch makes public the is_scalar_shader_stage() method in brw_shader, and renames it to brw_compiler_is_scalar_shader_stage(). The plan is to later reuse it in brw_nir, to enable/disable optimization passes

Re: [Mesa-dev] [PATCH 19/78] nir/nir_lower_io: Add vec4 support

2015-06-30 Thread Jason Ekstrand
I'm not sure what I think about adding an is_scalar flag vs. having _scalar and _vec4 versions of each function. My feeling is that once we tweak assign_var_locations as I mentioned for vec4 outputs, we'll find that we want to have them separate. The big thing here is that I'd rather have _vec4

[Mesa-dev] [PATCH v2] bugzilla_mesa.sh: sort the bugs list by number

2015-06-30 Thread Emil Velikov
v2: Use another sed pattern as per Ilia's suggestion. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- Ilia's approach seems to be slightly faster than Chad's so I've went ahead with it. -Emil bin/bugzilla_mesa.sh | 13 + 1 file changed, 5 insertions(+), 8 deletions(-)

Re: [Mesa-dev] [PATCH 16/78] i965/nir/vec4: Implement store_output intrinsic

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: The index into the output_reg array where to store the destination register is fetched from the nir_outputs map built during nir_setup_outputs stage. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89580 ---

Re: [Mesa-dev] git fsck errors on mesa repo

2015-06-30 Thread Emil Velikov
On 30/06/15 15:39, Liam R. Howlett wrote: * Emil Velikov emil.l.veli...@gmail.com [150630 10:04]: Hi Liam, On 29/06/15 18:23, Liam R. Howlett wrote: Hello, Since git 2.3, there have been a number of new fsck options added which produce issues when I clone the repository

Re: [Mesa-dev] [PATCH 12/78] i965/nir/vec4: Add nir_get_dst() and nir_get_src() methods

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com These methods are essential for the implementation of the NIR-vec4 pass. They work similar to their fs_nir counter-parts. When processing instructions, these

Re: [Mesa-dev] [PATCH v2 05/19] i965/fs: Explicitly set the exec_size on the add(32) in interpolation setup

2015-06-30 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: Soon we will start using the builder to explicitly set all the execution sizes. We could make a 32-wide builder, but the builder asserts that we never grow it which is usually a reasonable assumption. Sinc this one instruction is a bit of an

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #29 from Matt Whitlock freedesk...@mattwhitlock.name --- (In reply to Ilia Mirkin from comment #28) If you get the nouveau ddx from git, it should have DRI3 support. I might look into that. Is there any compelling reason why I

Re: [Mesa-dev] [PATCH] i965/gen9: Use custom MOCS entries set up by the kernel.

2015-06-30 Thread Ben Widawsky
On Tue, Jun 30, 2015 at 11:25:42PM +0300, Francisco Jerez wrote: Instead of relying on hardware defaults the i915 kernel driver is going program custom MOCS tables system-wide on Gen9 hardware. The WT entry previously used for renderbuffers had a number of problems: It disabled caching on

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #28 from Ilia Mirkin imir...@alum.mit.edu --- (In reply to Matt Whitlock from comment #27) (In reply to Eero Tamminen from comment #26) (In reply to Matt Whitlock from comment #15) (In reply to Furkan from comment #14) For

[Mesa-dev] [PATCH] i965/gen9: Use custom MOCS entries set up by the kernel.

2015-06-30 Thread Francisco Jerez
Instead of relying on hardware defaults the i915 kernel driver is going program custom MOCS tables system-wide on Gen9 hardware. The WT entry previously used for renderbuffers had a number of problems: It disabled caching on eLLC, it used a reserved L3 cacheability setting, and it used to

Re: [Mesa-dev] [PATCH 20/78] i965/nir/vec4: Implement load_uniform intrinsic

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com For the indirect case we need to take the index delivered by NIR and compute the parent uniform that we are accessing (the one that we uploaded to a surface) and the constant

Re: [Mesa-dev] [PATCH] i965/fs: Don't use the pixel interpolater for centroid interpolation

2015-06-30 Thread Ben Widawsky
On Tue, Jun 30, 2015 at 03:02:05PM +0100, Neil Roberts wrote: For centroid interpolation we can just directly use the values set up in the shader payload instead of querying the pixel interpolator. To do this we need to modify brw_compute_barycentric_interp_modes to detect when

Re: [Mesa-dev] [PATCH] mesa/st: Add checks for signed/unsigned integer conversions in ReadPixels

2015-06-30 Thread Michel Dänzer
On 29.06.2015 17:44, Iago Toral Quiroga wrote: These checks were in Mesa prior to commit fbba25bba, but they were not necessary for the purpose that Mesa intended (check if we could resolve ReadPixels via memcpy), so that commit took them away. Unfortunately, it seems that some Gallium

Re: [Mesa-dev] [PATCH 07/78] i965/vec4: Overload make_reg_for_system_value() to allow reuse in NIR-vec4 pass

2015-06-30 Thread Alejandro Piñeiro
On 30/06/15 01:27, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Alejandro Piñeiro apinhe...@igalia.com The new virtual method is more flexible, it has a signature: dst_reg *make_reg_for_system_value(int location, const glsl_type

Re: [Mesa-dev] [PATCH v3 15/18] i965: change the meaning of cpp for compressed textures

2015-06-30 Thread Anuj Phogat
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery nanleych...@gmail.com wrote: From: Nanley Chery nanley.g.ch...@intel.com An ASTC block takes up 16 bytes for all block width and height configurations. This size is not integrally divisible by all ASTC block widths. Therefore cpp is changed to

[Mesa-dev] [PATCH v2 7/7] nv50: enable GL_AMD_performance_monitor

2015-06-30 Thread Samuel Pitoiset
This exposes a group of global performance counters that enables GL_AMD_performance_monitor. All piglit tests are okay. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 35 ++

[Mesa-dev] [PATCH v2 5/7] nv50: add support for compute/graphics global performance counters

2015-06-30 Thread Samuel Pitoiset
This commit adds support for both compute and graphics global performance counters which have been reverse engineered with CUPTI (Linux) and PerfKit (Windows). Currently, only one query type can be monitored at the same time because the Gallium's HUD doesn't fit pretty well. This will be improved

Re: [Mesa-dev] [PATCH] i965/surface_formats: add support for 2D ASTC surface formats

2015-06-30 Thread Anuj Phogat
On Tue, Jun 30, 2015 at 4:15 PM, Nanley Chery nanleych...@gmail.com wrote: From: Nanley Chery nanley.g.ch...@intel.com Define two-thirds of the 2D Intel ASTC surface formats (LDR-only). This allows a 1-to-1 mapping from the mesa format to the Intel format. ASTC textures will default to being

Re: [Mesa-dev] [PATCH 00/78] i965: A new vec4 backend based on NIR

2015-06-30 Thread Jason Ekstrand
Ok, I think I've looked through more-or-less the whole thing. The only thing I haven't looked at is the texturing stuff but I think I'd like (and Ken agrees) to just refactor the old code to split the guts into something re-usable and make a much shorter NIR function. Most of it really looks

Re: [Mesa-dev] [PATCH 39/78] i965/nir/vec4: Add swizzle utility method for vector ops

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Antia Puentes apuen...@igalia.com For operations that have a predefined operand size 0, defined in glsl/nir/nir_opcodes.c, NIR returns a swizzle containing zeros in the components from outside the source

Re: [Mesa-dev] [PATCH] i965/gen9: Use custom MOCS entries set up by the kernel.

2015-06-30 Thread Ben Widawsky
On Wed, Jul 01, 2015 at 12:33:54AM +0300, Francisco Jerez wrote: Ben Widawsky b...@bwidawsk.net writes: On Tue, Jun 30, 2015 at 11:25:42PM +0300, Francisco Jerez wrote: Instead of relying on hardware defaults the i915 kernel driver is going program custom MOCS tables system-wide on Gen9

[Mesa-dev] [PATCH v2 3/7] nv50: allocate and map a notifier buffer object for PM

2015-06-30 Thread Samuel Pitoiset
This notifier buffer object will be used to read back global performance counters results written by the kernel. For each domain, we will store the handle of the perfdom object, an array of 4 counters and the number of cycles. Like the Gallium's HUD, we keep a list of busy queries in a ring in

[Mesa-dev] [PATCH v2 1/7] nouveau: implement the nvif hardware performance counters interface

2015-06-30 Thread Samuel Pitoiset
This commit implements the base interface for hardware performance counters that will be shared between nv50 and nvc0 drivers. TODO: Bump libdrm version of mesa when nvif will be merged. Changes since v2: - remove double-query thing for domains, signals and sources Signed-off-by: Samuel

[Mesa-dev] [PATCH v2 2/7] nv50: allocate a software object class

2015-06-30 Thread Samuel Pitoiset
This will allow to monitor global performance counters through the command stream of the GPU instead of using ioctls. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 11 +++ src/gallium/drivers/nouveau/nv50/nv50_screen.h | 1

[Mesa-dev] [PATCH v2 4/7] nv50: configure the ring buffer for reading back PM counters

2015-06-30 Thread Samuel Pitoiset
To write data at the right offset, the kernel has to know some parameters of this ring buffer, like the number of domains and the maximum number of queries. Changes since v2: - only configure the ring buffer if the notifier BO is allocated - only use one BEGIN_NV04() Signed-off-by: Samuel

[Mesa-dev] [PATCH v2 6/7] nv50: expose global performance counters to the HUD

2015-06-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 41 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 1 + src/gallium/drivers/nouveau/nv50/nv50_screen.h | 3 ++ 3 files changed, 45 insertions(+) diff --git

[Mesa-dev] [PATCH v2 0/7] nv50: expose global performance counters

2015-06-30 Thread Samuel Pitoiset
Hello there, This series exposes NVIDIA's global performance counters for Tesla through the Gallium's HUD and the GL_AMD_performance_monitor extension. This adds support for 24 hardware events which have been reverse engineered with PerfKit (Windows) and CUPTI (Linux). These hardware events will

[Mesa-dev] [PATCH] i965/surface_formats: add support for 2D ASTC surface formats

2015-06-30 Thread Nanley Chery
From: Nanley Chery nanley.g.ch...@intel.com Define two-thirds of the 2D Intel ASTC surface formats (LDR-only). This allows a 1-to-1 mapping from the mesa format to the Intel format. ASTC textures will default to being processed in LDR mode. If there is hardware support for HDR/Full mode and the

[Mesa-dev] [PATCH v2] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-30 Thread Julien Isorce
darwin: silence GLhandleARB convertions from and to GLuint This patch and its description are inspired from Jose Fonseca explanations and suggestions. With this patch the following logic applies and only if __APPLE__: When building mesa, GLhandleARB is defined as unsigned long and at some point

Re: [Mesa-dev] [PATCH 78/78] nir: Fix output swizzle in get_mul_for_src

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:07 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com Avoid copying an overwritten swizzle, use the original values. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89580 Signed-off-by: Samuel Iglesias

Re: [Mesa-dev] [PATCH] i965/gen9: Use custom MOCS entries set up by the kernel.

2015-06-30 Thread Francisco Jerez
Ben Widawsky b...@bwidawsk.net writes: On Tue, Jun 30, 2015 at 11:25:42PM +0300, Francisco Jerez wrote: Instead of relying on hardware defaults the i915 kernel driver is going program custom MOCS tables system-wide on Gen9 hardware. The WT entry previously used for renderbuffers had a number

Re: [Mesa-dev] [PATCH 59/78] i965/nir/vec4: Add utility method shader_opcode_for_nir_opcode()

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 1:07 AM, Eduardo Lima Mitev el...@igalia.com wrote: This is a helper method that returns a shader instruction opcode from the corresponding NIR texture opcode. It will be used to keep code in nir_emit_texture() clean. Bugzilla:

Re: [Mesa-dev] [PATCH v2 09/19] i965/fs: Add a builder argument to offset()

2015-06-30 Thread Jason Ekstrand
On Tue, Jun 30, 2015 at 9:16 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 42 src/mesa/drivers/dri/i965/brw_fs.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_cse.cpp |

Re: [Mesa-dev] [PATCH v2 12/19] i965/fs: Use exec_size for determining regs read/written and partial writes

2015-06-30 Thread Jason Ekstrand
On Tue, Jun 30, 2015 at 7:19 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [Mesa-dev] [PATCH 61/78] i965/nir/vec4: Add skeleton implementation of nir_emit_texture()

2015-06-30 Thread Jason Ekstrand
If we can avoid duplication in the texturing code, that would be really nice. Could we do this as a refactor of the old code and then a much smaller NIR function that calls some shared code? That's what we did for FS and it worked ok. I looked at the layout of your code and, after you finish

Re: [Mesa-dev] [PATCH v3 17/18] i965: refactor miptree alignment calculation code

2015-06-30 Thread Anuj Phogat
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery nanleych...@gmail.com wrote: From: Nanley Chery nanley.g.ch...@intel.com Remove redundant checks and comments by grouping our calculations for align_w and align_h wherever possible. v2: reintroduce brw. don't include functional changes.

Re: [Mesa-dev] [PATCH v2 02/19] i965/fs: Actually set/use the mlen for gen7 uniform pull constant loads

2015-06-30 Thread Kenneth Graunke
On Thursday, June 25, 2015 01:24:46 PM Jason Ekstrand wrote: Previously, we were allocating the payload with different sizes per gen and then figuring out the mlen in the generator based on gen. This meant, among other things, that the higher level passes knew nothing about it. ---

Re: [Mesa-dev] [PATCH 33/78] i965/nir/vec4: Implement float-related functions

2015-06-30 Thread Jason Ekstrand
First off, this needs a different commit message. float-related functions isn't particularly descriptive. How about various rounding functions because these really are all rounding modes. On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev el...@igalia.com wrote: From: Antia Puentes

Re: [Mesa-dev] [PATCH v3 10/18] i965/surface_formats: add support for 2D ASTC surface formats

2015-06-30 Thread Anuj Phogat
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery nanleych...@gmail.com wrote: From: Nanley Chery nanley.g.ch...@intel.com Intel surface formats default to LDR unless there is hardware support for HDR and the texture is able to be processed in HDR mode. v2: remove extra newlines. v3: follow

Re: [Mesa-dev] [PATCH v3 16/18] i965: enable ASTC support for Skylake

2015-06-30 Thread Anuj Phogat
On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery nanleych...@gmail.com wrote: From: Nanley Chery nanley.g.ch...@intel.com v2: remove OES ASTC extension reference. Signed-off-by: Nanley Chery nanley.g.ch...@intel.com --- src/mesa/drivers/dri/i965/intel_extensions.c | 5 + 1 file changed,

[Mesa-dev] [Bug 91149] make check optimization-test regression

2015-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91149 --- Comment #4 from Vinson Lee v...@freedesktop.org --- attachment 116806 fixes the make check regression. Tested-by: Vinson Lee v...@freedesktop.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the

Re: [Mesa-dev] [PATCH] i965/gen9: Use custom MOCS entries set up by the kernel.

2015-06-30 Thread Francisco Jerez
Ben Widawsky b...@bwidawsk.net writes: On Wed, Jul 01, 2015 at 12:33:54AM +0300, Francisco Jerez wrote: Ben Widawsky b...@bwidawsk.net writes: On Tue, Jun 30, 2015 at 11:25:42PM +0300, Francisco Jerez wrote: Instead of relying on hardware defaults the i915 kernel driver is going program

Re: [Mesa-dev] [PATCH v2 16/19] i965/fs: Use the builder dispatch_width for computing register offsets

2015-06-30 Thread Jason Ekstrand
On Fri, Jun 26, 2015 at 11:51 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Fri, Jun 26, 2015 at 8:52 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: Reviewed-by: Topi Pohjolainen