Re: [Mesa-dev] [PATCH] mesa: Fix generation of git_sha1.h.tmp for gitlinks

2015-07-09 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2015-07-09 at 18:59 -0700, Chad Versace wrote: > Don't assume that $(top_srcdir)/.git is a directory. It may be a > gitlink file [1] if $(top_srcdir) is a submodule checkout or a linked > worktree [2]. > > [1] A "gitlink" is a text file that specifies the

Re: [Mesa-dev] [PATCH] glsl: use the fast hash table for ir_validate

2015-07-09 Thread Timothy Arceri
On Thu, 2015-07-09 at 17:50 -0700, Eric Anholt wrote: > Timothy Arceri writes: > > > --- > > > > Some of the AoA tests currently get stuck in an optimisation > > loop for a long time and this was taking a large amount of time. > > Its a symptom not a cause but I don't see any issue with using

[Mesa-dev] [PATCH] glsl: use set rather than old hash table for ir_validate

2015-07-09 Thread Timothy Arceri
This implementation should be faster and there was no need to store a data field. --- src/glsl/ir_validate.cpp | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp index cfe0df3..684bef2 100644 --- a/src/

[Mesa-dev] [Bug 91263] R600 Segfault in finalize_textures

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91263 Michel Dänzer changed: What|Removed |Added Component|Drivers/Gallium/r600|Mesa core Assignee|dri-devel@l

[Mesa-dev] [Bug 91290] SIGSEGV glcpp/glcpp-parse.y:1077

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91290 Bug ID: 91290 Summary: SIGSEGV glcpp/glcpp-parse.y:1077 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords: have-backtrace

Re: [Mesa-dev] [PATCH 3/4] radeon, r200: allow hyperz for radeon DRM module v2

2015-07-09 Thread Michel Dänzer
On 10.07.2015 05:13, Emil Velikov wrote: > The original code only half considered hyperz as an option. As per > previous commit "major != 2 cannot occur" we can simply things, and > allow users to set the option if they choose to do so. > > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 1/4] radeon, r200: remove unused variable texmicrotile

2015-07-09 Thread Roland Scheidegger
Ohhh ripping out some more of my _very_ old code, how dare you :-). Too bad some parts (fast z clear for instance) never made it past UMS for these chips, quake3 never was as fast again ;-). I wonder how well things actually work these days with enabled hyperz, it has some, let's say, limitations..

[Mesa-dev] [PATCH] mesa: Fix generation of git_sha1.h.tmp for gitlinks

2015-07-09 Thread Chad Versace
Don't assume that $(top_srcdir)/.git is a directory. It may be a gitlink file [1] if $(top_srcdir) is a submodule checkout or a linked worktree [2]. [1] A "gitlink" is a text file that specifies the real location of the gitdir. [2] Linked worktrees are a new feature in Git 2.5. Cc: "10.6, 10.

Re: [Mesa-dev] [PATCH 07/19] glsl/types: add new subroutine type (v3)

2015-07-09 Thread Chris Forbes
7-12 inclusive are Reviewed-by: Chris Forbes On Thu, Jul 9, 2015 at 7:17 PM, Dave Airlie wrote: > From: Dave Airlie > > This type will be used to store the name of subroutine types > > as in subroutine void myfunc(void); > will store myfunc into a subroutine type. > > This is required to the p

Re: [Mesa-dev] [PATCH] glsl: use the fast hash table for ir_validate

2015-07-09 Thread Eric Anholt
Timothy Arceri writes: > --- > > Some of the AoA tests currently get stuck in an optimisation > loop for a long time and this was taking a large amount of time. > Its a symptom not a cause but I don't see any issue with using the faster > version. > > src/glsl/ir_validate.cpp | 17 --

Re: [Mesa-dev] [PATCH 09/11] android: dri: correctly set HAVE_LIBDRM

2015-07-09 Thread Chih-Wei Huang
Emil Velikov 於 西元2015年07月09日 01:07 寫道: > Set the macro if we're not building swrast alone. > > Cc: Chih-Wei Huang > Cc: Eric Anholt > Signed-off-by: Emil Velikov > --- > src/gallium/targets/dri/Android.mk | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH 1/2] i965/cs: Setup push constant data for uniforms

2015-07-09 Thread Ben Widawsky
On Tue, Jun 16, 2015 at 02:21:39PM -0700, Jordan Justen wrote: > brw_upload_cs_push_constants was based on gen6_upload_push_constants. This review is based off of 2838833bfd5eb0a87fdacfa1cd6391b50f9c0b8b in your repository. This patch doesn't apply cleanly in its current form. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 2/5] i965/gen9: Plugin the code for selecting YF/YS tiling on skl+

2015-07-09 Thread Anuj Phogat
On Tue, Jul 7, 2015 at 2:47 AM, Kenneth Graunke wrote: > On Wednesday, June 10, 2015 03:30:47 PM Anuj Phogat wrote: >> Buffers with Yf/Ys tiling end up using meta upload / download >> paths or the blitter for cases where they used tiled_memcpy paths >> in case of Y tiling. This has exposed some bu

[Mesa-dev] [Bug 91288] [swrast] piglit depthfunc double free

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91288 Bug ID: 91288 Summary: [swrast] piglit depthfunc double free Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: hav

Re: [Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

2015-07-09 Thread Chad Versace
On Thu 09 Jul 2015, Emil Velikov wrote: > On 9 July 2015 at 21:21, Chad Versace wrote: > > On Thu 09 Jul 2015, Emil Velikov wrote: > >> On 9 July 2015 at 09:39, Chad Versace wrote: > >> > EGL_EXT_image_dma_buf_import now supports those formats. > >> > > >> Do I have an old version of it (v6) or I

[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 --- Comment #20 from Vinson Lee --- (In reply to José Fonseca from comment #19) > (In reply to Vinson Lee from comment #18) > > mesa: 0166b4c165271bd7525a91049e58e390cb596c60 (master 10.7.0-devel) > > > > Still see this build error. BUILDING_MES

Re: [Mesa-dev] [PATCH v2 30/82] i965: Use 16-byte offset alignment for shader storage buffers

2015-07-09 Thread Jordan Justen
30-32 Reviewed-by: Jordan Justen On 2015-06-03 00:01:20, Iago Toral Quiroga wrote: > This is the same we do for other things like uniforms because it ensures > optimal performance. > --- > src/mesa/drivers/dri/i965/brw_context.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/

[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 --- Comment #19 from José Fonseca --- (In reply to Vinson Lee from comment #18) > mesa: 0166b4c165271bd7525a91049e58e390cb596c60 (master 10.7.0-devel) > > Still see this build error. BUILDING_MESA is only defined for darwin DRI > enabled builds.

Re: [Mesa-dev] [PATCH 4/4] gallium: add interface for writable shader buffers

2015-07-09 Thread Ilia Mirkin
This all seems fine to me. This series is: Reviewed-by: Ilia Mirkin Might want to wait for someone more experienced with all this to also take a look before pushing. -ilia On Thu, Jul 9, 2015 at 5:46 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/include/pipe/p_context.

Re: [Mesa-dev] [PATCH 1/4] radeon, r200: remove unused variable texmicrotile

2015-07-09 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Jul 9, 2015 at 10:13 PM, Emil Velikov wrote: > Dead since at least 2009 with commit ccf7814a315(radeon: major cleanups > removing old dead codepaths.) > > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dri/r200/r200_context.c

[Mesa-dev] [PATCH] glsl: use the fast hash table for ir_validate

2015-07-09 Thread Timothy Arceri
--- Some of the AoA tests currently get stuck in an optimisation loop for a long time and this was taking a large amount of time. Its a symptom not a cause but I don't see any issue with using the faster version. src/glsl/ir_validate.cpp | 17 - 1 file changed, 8 insertions(+

[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 Vinson Lee changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 66346, which changed state. Bug 66346 Summary: shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint' https://bugs.freedesktop.org/show_bug.cgi?id=66346 What|Removed |A

[Mesa-dev] [PATCH 4/4] gallium: add interface for writable shader buffers

2015-07-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/include/pipe/p_context.h | 18 ++ src/gallium/include/pipe/p_state.h | 10 ++ 2 files changed, 28 insertions(+) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index 022ace5..b4512e7 100644 ---

[Mesa-dev] [PATCH 2/4] gallium: add new limits for shader buffers and images

2015-07-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/ilo/core/ilo_state_3d.h | 2 +- src/gallium/include/pipe/p_state.h| 3 ++- src/gallium/state_trackers/clover/core/device.cpp | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/ilo/core/ilo_s

[Mesa-dev] [PATCH 3/4] gallium: add interface for writable shader images

2015-07-09 Thread Marek Olšák
From: Marek Olšák PIPE_CAPs will be added some other time. --- src/gallium/auxiliary/util/u_debug_describe.c | 9 +++ src/gallium/auxiliary/util/u_debug_describe.h | 2 ++ src/gallium/auxiliary/util/u_dump.h | 3 +++ src/gallium/auxiliary/util/u_dump_state.c | 27 +++

[Mesa-dev] [PATCH 1/4] gallium: add BIND flags for R/W buffers and images

2015-07-09 Thread Marek Olšák
From: Marek Olšák PIPE_CAPs and TGSI support will be added later. The TGSI support should be straightforward. We only need to split TGSI_FILE_RESOURCE into TGSI_FILE_IMAGE and TGSI_FILE_BUFFER, though duplicating all opcodes shouldn't be necessary. The idea is: * ARB_shader_image_load_store shou

Re: [Mesa-dev] [PATCH shader-db] Add support for shadertoy tests

2015-07-09 Thread Dylan Baker
There's a few more cleanups you could do if you wanted, but either way: Reviewed-by: Dylan Baker On Thu, Jul 09, 2015 at 10:41:05AM -0400, Rob Clark wrote: > Attached script grabs shaders from shadertoy, and dumps them out as > .shader_test files which can be run through shader-db for compiler >

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-09 Thread Ilia Mirkin
On Thu, Jul 9, 2015 at 5:30 PM, Ilia Mirkin wrote: > On Thu, Jul 9, 2015 at 5:05 PM, Marek Olšák wrote: >> I'd like to discuss one more thing that will affect whether image >> slots will be global (shared by all shaders) or not. >> >> Which image unit an image uniform uses is not a compile-time t

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-09 Thread Ilia Mirkin
On Thu, Jul 9, 2015 at 5:05 PM, Marek Olšák wrote: > I'd like to discuss one more thing that will affect whether image > slots will be global (shared by all shaders) or not. > > Which image unit an image uniform uses is not a compile-time thing, > but it's specified later using glUniform1i. That m

Re: [Mesa-dev] [PATCH 09/19] glsl/ir: add subroutine information storage to ir_function (v1.1)

2015-07-09 Thread Chris Forbes
Do you really need is_subroutine_def ? It seems redundant with num_subroutine_types>0. On Thu, Jul 9, 2015 at 7:17 PM, Dave Airlie wrote: > From: Dave Airlie > > We need to store two sets of info into the ir_function, > if this is a function definition with a subroutine list > (subroutine_def) o

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-09 Thread Marek Olšák
I'd like to discuss one more thing that will affect whether image slots will be global (shared by all shaders) or not. Which image unit an image uniform uses is not a compile-time thing, but it's specified later using glUniform1i. That means we need a per-shader table that maps image uniforms to g

Re: [Mesa-dev] [RFC] loader: libudev vs sysfs vs libdrm

2015-07-09 Thread Emil Velikov
On 09/07/15 15:40, Axel Davy wrote: > On 09/07/2015 15:33, Emil Velikov wrote : >> >> Yakes forgot about that one. From a quick look we can (I know it feels >> durty) use readlink( >> /sys/dev/char/$(major):$(minor)). >> >> Everything seems to be there - bus type and exact location of the >> device

Re: [Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 21:21, Chad Versace wrote: > On Thu 09 Jul 2015, Emil Velikov wrote: >> On 9 July 2015 at 09:39, Chad Versace wrote: >> > EGL_EXT_image_dma_buf_import now supports those formats. >> > >> Do I have an old version of it (v6) or I simply cannot see those listed ? > > I should have

Re: [Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

2015-07-09 Thread Chad Versace
On Thu 09 Jul 2015, Emil Velikov wrote: > On 9 July 2015 at 09:39, Chad Versace wrote: > > EGL_EXT_image_dma_buf_import now supports those formats. > > > Do I have an old version of it (v6) or I simply cannot see those listed ? I should have been more clear when I said "EGL_EXT_image_dma_buf_impo

Re: [Mesa-dev] [PATCH 4/4] droi/common: remove unused drm_version variable

2015-07-09 Thread Emil Velikov
The title should obviously say "dri/common:" consider that fixed. Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] configure.ac: do not set HAVE_DRI(23) when libdrm is missing

2015-07-09 Thread Emil Velikov
These conditionals are used to guard both dri modules and loader(s). Currently if we try to build the gallium swrast dri module (without glx) on a system that's missing libdrm the build will fail. v2: Make sure we assign prior to checking the have_libdrm variable. Cc: 10.6 Signed-off-by: Emil V

Re: [Mesa-dev] [PATCH 04/11] dri_interface: drop __NOT_HAVE_DRM_H magic

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 18:50, Ian Romanick wrote: > On 07/08/2015 10:07 AM, Emil Velikov wrote: >> Signed-off-by: Emil Velikov >> --- >> include/GL/internal/dri_interface.h | 11 --- >> 1 file changed, 11 deletions(-) >> >> diff --git a/include/GL/internal/dri_interface.h >> b/include/GL/int

Re: [Mesa-dev] [PATCH] i965/fs: Reimplement nir_op_uadd_carry and _usub_borrow without accumulator.

2015-07-09 Thread Francisco Jerez
Ilia Mirkin writes: > FYI there's already a lowering pass that does this in the GLSL IR > (CARRY_TO_ARITH in lower_instructions). Perhaps the right place to do > this is NIR though, just wanted to let you know. > Ah, I wasn't aware of that flag, that seems even better. I just tried it and it see

[Mesa-dev] [PATCH 1/4] radeon, r200: remove unused variable texmicrotile

2015-07-09 Thread Emil Velikov
Dead since at least 2009 with commit ccf7814a315(radeon: major cleanups removing old dead codepaths.) Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/r200/r200_context.c | 3 --- src/mesa/drivers/dri/r200/r200_context.h | 1 - src/mesa/drivers/dri/radeon/radeon_context.c | 3 --- sr

[Mesa-dev] [PATCH 2/4] radeon, r200: remove support for UMS radeon DRM module

2015-07-09 Thread Emil Velikov
As mentioned by Michel Dänzer "FWIW though, any code which is specific to radeon DRM major version 1 can be removed, because that's the UMS major version." and Marek Olšák "major != 2" can't occur. You don't have to check the major version at all and you can just assume it's always 2." Sign

[Mesa-dev] [PATCH 0/4] radeon/r200 remove drm_version and related hacks

2015-07-09 Thread Emil Velikov
Hi all, This is a follow up to my earlier "Bye bye __NOT_HAVE_DRM_H" series, on which thise series depends upon. As mentioned in there my Michel & Marek, radeon DRM module 2 is only possible with the in-tree drivers, so I've ripped them out and as a side effect removed a _very_ nasty hack that we

[Mesa-dev] [PATCH 3/4] radeon, r200: allow hyperz for radeon DRM module v2

2015-07-09 Thread Emil Velikov
The original code only half considered hyperz as an option. As per previous commit "major != 2 cannot occur" we can simply things, and allow users to set the option if they choose to do so. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/r200/r200_context.c | 10 ++ src/mesa/dri

[Mesa-dev] [PATCH 4/4] droi/common: remove unused drm_version variable

2015-07-09 Thread Emil Velikov
As of last commit the only user of it (radeon/r200) no longer uses it. As such let's remove it and cleanup the nasty hacks that we had in place to support this. Signed-off-by: Emil Velikov --- configure.ac| 21 - src/mesa/drivers/dri/common/Android

Re: [Mesa-dev] [PATCH] i965/fs: Reimplement nir_op_uadd_carry and _usub_borrow without accumulator.

2015-07-09 Thread Ilia Mirkin
FYI there's already a lowering pass that does this in the GLSL IR (CARRY_TO_ARITH in lower_instructions). Perhaps the right place to do this is NIR though, just wanted to let you know. On Thu, Jul 9, 2015 at 3:51 PM, Francisco Jerez wrote: > This gets rid of two no16() fall-backs and should allow

[Mesa-dev] [PATCH] i965/fs: Reimplement nir_op_uadd_carry and _usub_borrow without accumulator.

2015-07-09 Thread Francisco Jerez
This gets rid of two no16() fall-backs and should allow better scheduling of the generated IR. There are no uses of usubBorrow() or uaddCarry() in shader-db so no changes are expected. However the "arb_gpu_shader5/execution/built-in-functions/fs-usubBorrow" and "arb_gpu_shader5/execution/built-in

Re: [Mesa-dev] [HACK] i965/fs: Fix ordering of src0 alpha and oMask in the framebuffer write payload.

2015-07-09 Thread Jason Ekstrand
On Jul 9, 2015 7:57 AM, "Francisco Jerez" wrote: > > We were passing src0 alpha and oMask in reverse order. There seems to > be no good way to pass them in the correct order to the new-style > LOAD_PAYLOAD (how surprising) because src0 alpha is per-channel while > oMask is not. Just split src0 a

[Mesa-dev] [HACK] i965/fs: Fix rescale_texcoord() for SIMD16 and remove no16 fall-back.

2015-07-09 Thread Francisco Jerez
Aside from the trivial GRF underallocation problem in the "devinfo->gen < 6 && is_rect" if-block, the texrect scale uniform look-up code was assuming a one-to-one mapping between UNIFORM register indices and the param array, which only holds during the SIMD8 run. It seems dubious that this needs t

Re: [Mesa-dev] [PATCH] i965/cs: Initialize GPGPU Thread Count

2015-07-09 Thread Ben Widawsky
On Thu, Jul 02, 2015 at 11:32:03PM -0700, Jordan Justen wrote: > On 2015-06-25 11:34:59, Ben Widawsky wrote: > > On Thu, Jun 11, 2015 at 09:04:45PM -0700, Jordan Justen wrote: > > > + desc[dw++] = 0; > > > + const uint32_t media_threads = > > > + brw->gen >= 8 ? > > > + SET_FIELD(thre

[Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-09 Thread Ben Widawsky
While implementing the workaround in the previous patch I noticed things were starting to get a bit messy. Since gen8 works differently enough from gen7, I thought splitting it out with be good. While here, get rid of gen8 MOCS which does nothing and was in the wrong place anyway. This patch is t

Re: [Mesa-dev] [PATCH 06/11] loader: use HAVE_LIBDRM instead of ! __NOT_HAVE_DRM_H

2015-07-09 Thread Ian Romanick
I can't really speak to the Android.mk or SConscript changes, but the rest of this patch is Reviewed-by: Ian Romanick You might also see what Jeremy Huddleston Sequoia thinks, since most of this exists to support his platform. :) On 07/08/2015 10:07 AM, Emil Velikov wrote: > Double negatives i

Re: [Mesa-dev] [PATCH 04/11] dri_interface: drop __NOT_HAVE_DRM_H magic

2015-07-09 Thread Ian Romanick
On 07/08/2015 10:07 AM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > include/GL/internal/dri_interface.h | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/include/GL/internal/dri_interface.h > b/include/GL/internal/dri_interface.h > index c827bb6..c0545b1 100644

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Ian Romanick
On 07/08/2015 10:07 AM, Emil Velikov wrote: > Most of the data stored(duplicated) was unused, and for the one that is > follow the approach set by other drivers. > This eliminates the use of legacy (dri1) types. > > XXX: The radeon code is the only user of __DRIscreen::drm_version (the > only __DR

[Mesa-dev] [PATCH] i965/hsw: Implement end of batch workaround

2015-07-09 Thread Kenneth Graunke
From: Ben Widawsky This patch can cause an infinite recursion if the previous patch titled, "i965: Track finished batch state" isn't present (backporters take notice). v2: Sent out the wrong patch originally. This patches switches the order of flushes, doing the generic flush before the CC_STATE

Re: [Mesa-dev] [PATCH] [v2] i965: Split out gen8 push constant state upload

2015-07-09 Thread Ben Widawsky
On Thu, Jul 09, 2015 at 09:44:52AM -0700, Ben Widawsky wrote: > While implementing the workaround in the previous patch I noticed things were > starting to get a bit messy. Since gen8 works differently enough from gen7, I > thought splitting it out with be good. > > While here, get rid of gen8 MOC

[Mesa-dev] [PATCH] [v2] i965: Split out gen8 push constant state upload

2015-07-09 Thread Ben Widawsky
While implementing the workaround in the previous patch I noticed things were starting to get a bit messy. Since gen8 works differently enough from gen7, I thought splitting it out with be good. While here, get rid of gen8 MOCS which does nothing and was in the wrong place anyway. This patch is t

Re: [Mesa-dev] [PATCH 06/78] i965/nir/vec4: Add setup of uniform variables

2015-07-09 Thread Kenneth Graunke
On Tuesday, June 30, 2015 10:04:47 AM Iago Toral wrote: > Hi Jason, > > On Mon, 2015-06-29 at 16:22 -0700, Jason Ekstrand wrote: > > On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev > > wrote: > > > From: Iago Toral Quiroga > > > > > > This is based on similar code existing in vec4_visitor.

[Mesa-dev] [HACK] i965/fs: Fix ordering of src0 alpha and oMask in the framebuffer write payload.

2015-07-09 Thread Francisco Jerez
We were passing src0 alpha and oMask in reverse order. There seems to be no good way to pass them in the correct order to the new-style LOAD_PAYLOAD (how surprising) because src0 alpha is per-channel while oMask is not. Just split src0 alpha in fixed-width registers and pass them to LOAD_PAYLOAD

Re: [Mesa-dev] [PATCH 2/2] i965: Optimize intel_batchbuffer_emit_dword().

2015-07-09 Thread Martin Peres
On 09/07/15 11:13, Chris Wilson wrote: On Wed, Jul 08, 2015 at 05:08:11PM -0700, Matt Turner wrote: On Wed, Jul 8, 2015 at 4:53 PM, Chris Wilson wrote: static void upload_viewport_state_pointers(struct brw_context *brw) { BEGIN_BATCH(4); brw->batch.map[0] = (_3DSTATE_VIEWPORT_STATE_POI

Re: [Mesa-dev] [Mesa-stable] [PATCHv2] i965/gen9: Use custom MOCS entries set up by the kernel.

2015-07-09 Thread Francisco Jerez
Ben Widawsky writes: > On Tue, Jul 07, 2015 at 10:21:28PM +0300, Francisco Jerez wrote: >> Instead of relying on hardware defaults the i915 kernel driver is >> going program custom MOCS tables system-wide on Gen9 hardware. The >> "WT" entry previously used for renderbuffers had a number of probl

[Mesa-dev] [PATCH shader-db] Add support for shadertoy tests

2015-07-09 Thread Rob Clark
Attached script grabs shaders from shadertoy, and dumps them out as .shader_test files which can be run through shader-db for compiler testing. shadertoy only gives you a fragment shader (which works based on gl_FragCoord), so a generic vertex shader is used. And a blurb is inserted for the pre-d

Re: [Mesa-dev] [RFC] loader: libudev vs sysfs vs libdrm

2015-07-09 Thread Axel Davy
On 09/07/2015 15:33, Emil Velikov wrote : Yakes forgot about that one. From a quick look we can (I know it feels durty) use readlink( /sys/dev/char/$(major):$(minor)). Everything seems to be there - bus type and exact location of the device on the bus. It's limited to sysfs users, but they are

Re: [Mesa-dev] [PATCH 1/2] i965: Set brw->batch.emit only #ifdef DEBUG.

2015-07-09 Thread Iago Toral
Even if your next patch needs more work this one alone still makes sense: Reviewed-by: Iago Toral Quiroga Iago On Wed, 2015-07-08 at 14:00 -0700, Matt Turner wrote: > It's only used inside #ifdef DEBUG. Cuts ~1.7k of .text, and more > importantly prevents a larger code size regression in the ne

[Mesa-dev] [PATCH] glsl: fix Bug 85252 - Segfault in compiler while processing ternary operator with void arguments

2015-07-09 Thread Renaud Gaubert
This is done by returning an rvalue of type void in the ast_function_expression::hir function instead of a void expression. This produces (in the case of the ternary) an hir with a call to the void returning function and an assignement of a void variable which will be optimized out (the assignemen

Re: [Mesa-dev] [PATCH 4/4] vc4: unref old fence

2015-07-09 Thread Rob Clark
On Thu, Jul 9, 2015 at 8:36 AM, Emil Velikov wrote: > On 9 July 2015 at 01:46, Rob Clark wrote: >> From: Rob Clark >> >> Some, but not all, state trackers will explicitly unref (and set to >> NULL) the previous *fence before calling pipe->flush(). So driver >> should use fence_ref() which will

[Mesa-dev] [PATCH] glsl: fix Bug 85252 - Segfault in compiler while processing ternary operator with void arguments

2015-07-09 Thread Renaud Gaubert
This is done by returning an rvalue of type void in the ast_function_expression::hir function instead of a void expression. This produces (in the case of the ternary) an hir with a call to the void returning function and an assignement of a void variable which will be optimized out (the assignemen

Re: [Mesa-dev] [RFC] Compatibility between old dri modules and new loaders, and vice verse

2015-07-09 Thread Emil Velikov
On 30 June 2015 at 16:29, Emil Velikov wrote: > On 22 June 2015 at 23:19, Dave Airlie wrote: >> On 23 June 2015 at 08:16, Ian Romanick wrote: >>> On 06/22/2015 11:54 AM, Dave Airlie wrote: > > As kindly hinted by Marek, currently we do have a wide selection of > supported dri <> load

Re: [Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 09:39, Chad Versace wrote: > EGL_EXT_image_dma_buf_import now supports those formats. > Do I have an old version of it (v6) or I simply cannot see those listed ? Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 14:16, Marek Olšák wrote: > "major != 2" can't occur. You don't have to check the major version at > all and you can just assume it's always 2. > That's even better than expected. Thanks ! -Emil ___ mesa-dev mailing list mesa-dev@lists

Re: [Mesa-dev] [RFC] loader: libudev vs sysfs vs libdrm

2015-07-09 Thread Emil Velikov
On 8 July 2015 at 18:55, Axel Davy wrote: > On 08/07/2015 00:15, Emil Velikov wrote : >> >> >> >> Can anyone shed a light/cast their 2c ? >> >> Thanks >> Emil >> ___ >> > > The DRI3/Wayland/Gallium Nine DRI_PRIME path uses libudev, > and I'm not sure it

[Mesa-dev] [PATCH v2] i965/fs: Don't use the pixel interpolater for centroid interpolation

2015-07-09 Thread Neil Roberts
For centroid interpolation we can just directly use the values set up in the shader payload instead of querying the pixel interpolator. To do this we need to modify brw_compute_barycentric_interp_modes to detect when interpolateAtCentroid is called. v2: Rebase on top of changes to set the pulls ba

Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-07-09 Thread Roland Scheidegger
Should expose that only if hw has glsl 130 support? Roland Am 09.07.2015 um 09:17 schrieb Dave Airlie: > From: Dave Airlie > > I'm not sure if we shouldn't enable this everywhere > and rip out the API checks, > > discuss, > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_exte

Re: [Mesa-dev] [RFC] loader: libudev vs sysfs vs libdrm

2015-07-09 Thread Emil Velikov
On 8 July 2015 at 18:35, Eric Anholt wrote: > Emil Velikov writes: > >> Hello all, >> >> A recent patch by Chris, fixing some libudev fun in our loader, made >> me think if we can clear it up a bit. >> >> Having three different ways of retrieving the vendor/device ID does >> feel a bit excessive.

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Marek Olšák
"major != 2" can't occur. You don't have to check the major version at all and you can just assume it's always 2. Marek On Thu, Jul 9, 2015 at 2:55 PM, Emil Velikov wrote: > On 9 July 2015 at 04:45, Michel Dänzer wrote: >> On 09.07.2015 02:07, Emil Velikov wrote: >>> Most of the data stored(dup

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 04:45, Michel Dänzer wrote: > On 09.07.2015 02:07, Emil Velikov wrote: >> Most of the data stored(duplicated) was unused, and for the one that is >> follow the approach set by other drivers. >> This eliminates the use of legacy (dri1) types. > > The commentary below should have b

Re: [Mesa-dev] [PATCH 02/11] i915; remove unused driFd variable

2015-07-09 Thread Emil Velikov
On 8 July 2015 at 18:08, Matt Turner wrote: > On Wed, Jul 8, 2015 at 10:07 AM, Emil Velikov > wrote: >> Signed-off-by: Emil Velikov >> --- >> src/mesa/drivers/dri/i915/intel_context.c | 1 - >> src/mesa/drivers/dri/i915/intel_context.h | 2 -- >> 2 files changed, 3 deletions(-) >> >> diff --gi

Re: [Mesa-dev] [PATCH 4/4] vc4: unref old fence

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 01:46, Rob Clark wrote: > From: Rob Clark > > Some, but not all, state trackers will explicitly unref (and set to > NULL) the previous *fence before calling pipe->flush(). So driver > should use fence_ref() which will unref the old fence if not NULL. > > Signed-off-by: Rob Clar

[Mesa-dev] New stable-branch 10.6 candidate pushed

2015-07-09 Thread Emil Velikov
Hello list, The candidate for the Mesa 10.6.2 is now available. Currently we have: - 37 queued - 26 nominated (outstanding) - and 2 rejected/obsolete patches We have a moderate list of fixes this time around, most of which in the glsl, core mesa, and the i965 & nouveau. From a users perspecti

Re: [Mesa-dev] [PATCH 0/4] fence refcnting fixes

2015-07-09 Thread Rob Clark
On Thu, Jul 9, 2015 at 4:21 AM, Christian König wrote: > On 08.07.2015 22:34, Rob Clark wrote: >> >> From: Rob Clark >> >> This isn't at all clear for pipe driver writers currently, since it >> is not documented anywhere. But radeon/nouveau/llvmpipe seem to drop >> the ref on the **fence passed

Re: [Mesa-dev] [PATCH] glsl: fix Bug 85252 - Segfault in compiler while processing ternary operator with void arguments

2015-07-09 Thread Samuel Iglesias Gonsálvez
On 07/07/15 21:47, Renaud Gaubert wrote: > This is done by returning an rvalue of type void in the > ast_function_expression::hir function instead of a void expression. > > This produces (in the case of the ternary) an hir with a call > to the void returning function and an assignement of a void v

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 66346, which changed state. Bug 66346 Summary: shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint' https://bugs.freedesktop.org/show_bug.cgi?id=66346 What|Removed |A

[Mesa-dev] [Bug 66346] shader_query.cpp:49: error: invalid conversion from 'void*' to 'GLuint'

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66346 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 90249] Fails to build egl_dri2 on osx

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90249 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED URL|

[Mesa-dev] [Bug 90903] egl_dri2.c:dri2_load fails to load libglapi on osx

2015-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90903 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] i965: bump libdrm requirement to 2.4.61 and drop in-tree workaround

2015-07-09 Thread Samuel Iglesias Gonsálvez
On 08/07/15 18:57, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > configure.ac | 2 +- > src/mesa/drivers/dri/i965/intel_screen.c | 5 - > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/configure.ac b/configure.ac > index d819bef..eb71

Re: [Mesa-dev] [PATCH] r600g: move sampler/ubo index registers before temp reg

2015-07-09 Thread Glenn Kennard
On Thu, 09 Jul 2015 08:00:48 +0200, Dave Airlie wrote: From: Dave Airlie temp_reg needs to be last, as we increment things away from it, otherwise on cayman some tests were overwriting the index regs. Fixes 2 piglit with ARB_gpu_shader5 forced on cayman. Signed-off-by: Dave Airlie --- src

Re: [Mesa-dev] [PATCH] r600g: fix sampler/ubo indexing on cayman

2015-07-09 Thread Glenn Kennard
On Thu, 09 Jul 2015 07:37:59 +0200, Dave Airlie wrote: From: Dave Airlie Cayman needs a different method to upload the CF IDX0/1 This fixes 31 piglits when ARB_gpu_shader5 is forced on with cayman. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/eg_asm.c | 17 +++-- sr

[Mesa-dev] [PATCH 1/2] egl: Add support for DRM_FORMAT_R8, RG88, and GR88

2015-07-09 Thread Chad Versace
The Kodi/XBMC developers want to transcode NV12 to RGB with OpenGL shaders, importing the two source planes through EGL_EXT_image_dma_buf_import. That requires importing the Y plane as an R8 EGLImage and the UV plane as either an RG88 or GR88 EGLImage. This patch teaches the driver-independent par

[Mesa-dev] [PATCH 2/2] i965: Support importing R8 and GR88 dma_bufs

2015-07-09 Thread Chad Versace
EGL_EXT_image_dma_buf_import now supports those formats. CC: Peter Frühberger Cc: Rainer Hochecker Signed-off-by: Chad Versace --- include/GL/internal/dri_interface.h | 9 +++-- src/mesa/drivers/dri/i965/intel_screen.c | 6 ++ 2 files changed, 13 insertions(+), 2 deletions(-) dif

[Mesa-dev] [PATCH 0/2] egl, i965: Support importing R8 and GR88 dma_bufs as textures

2015-07-09 Thread Chad Versace
Teach EGL_EXT_image_dma_buf_import about DRM_FORMAT_R8 and DRM_FORMAT_GR88 in egl_dri2.c. Then add the plumbing to i965 to import R8 and GR88 dma_bufs as textures. This Mesa series shouldn't land until my kernel patch lands: To: dri-de...@freedesktop.org Subject: [PATCH] drm/fourcc: Add fo

Re: [Mesa-dev] [PATCH 0/4] fence refcnting fixes

2015-07-09 Thread Christian König
On 08.07.2015 22:34, Rob Clark wrote: From: Rob Clark This isn't at all clear for pipe driver writers currently, since it is not documented anywhere. But radeon/nouveau/llvmpipe seem to drop the ref on the **fence passed in to pipe->flush() (if *fence!=NULL). Freedreno/ilo/vc4 where not doing

Re: [Mesa-dev] [PATCH 2/2] i965: Optimize intel_batchbuffer_emit_dword().

2015-07-09 Thread Chris Wilson
On Wed, Jul 08, 2015 at 05:08:11PM -0700, Matt Turner wrote: > On Wed, Jul 8, 2015 at 4:53 PM, Chris Wilson wrote: > > static void upload_viewport_state_pointers(struct brw_context *brw) > > { > >BEGIN_BATCH(4); > >brw->batch.map[0] = (_3DSTATE_VIEWPORT_STATE_POINTERS << 16 | (4 - 2) | > >

[Mesa-dev] [PATCH 14/19] glsl: add uniform and program resource support

2015-07-09 Thread Dave Airlie
From: Dave Airlie This adds linker support for subroutine uniforms, they have some subtle differences from real uniforms, we also hide them and they are given internal uniform names. This also adds the subroutine locations and subroutine uniforms to the program resource tracking for later use.

[Mesa-dev] [PATCH 17/19] mesa: fill out the ARB_shader_subroutine APIs

2015-07-09 Thread Dave Airlie
From: Dave Airlie This fleshes out the APIs, using the program resource APIs where they should match. It also sets the default values to valid subroutines. Signed-off-by: Dave Airlie --- src/mesa/main/shaderapi.c | 457 +- src/mesa/main/shaderapi.h

[Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-07-09 Thread Dave Airlie
From: Dave Airlie I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker

[Mesa-dev] [PATCH 13/19] mesa/mtypes: add gl_subroutine_function and uniform storage to shader

2015-07-09 Thread Dave Airlie
From: Dave Airlie This adds the necessary storage for subroutine info to gl_shader. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index a93fe94..c53bf2d 100644 --- a/src

[Mesa-dev] [PATCH 12/19] glsl/ir: add subroutine lowering pass (v2.1)

2015-07-09 Thread Dave Airlie
From: Dave Airlie This lowers the enhanced ir_call using the lookaside table of subroutines into an if ladder. This initially was done at the AST level but it caused some ordering issues so a separate pass was required. v2: clone return value derefs. v2.1: update for subroutine->int convert. Si

[Mesa-dev] [PATCH 15/19] program_resource: add subroutine support

2015-07-09 Thread Dave Airlie
From: Dave Airlie This fleshes out the ARB_program_query support for the APIs that ARB_shader_subroutine introduces, leaving some TODOs for later addition. Signed-off-by: Dave Airlie --- src/mesa/main/shader_query.cpp | 46 ++ 1 file changed, 46 insertio

[Mesa-dev] [PATCH 18/19] st/mesa: add subroutine bits (v1.1)

2015-07-09 Thread Dave Airlie
From: Dave Airlie Just add support for the subroutine type to the glsl->tgsi convertor. v1.1: add subroutine to int support. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracke

[Mesa-dev] [PATCH 16/19] program: add subroutine uniform support (v1.1)

2015-07-09 Thread Dave Airlie
From: Dave Airlie Add support for the subroutine uniform type ir->mesa.cpp v1.1: add subroutine to int to switch Signed-off-by: Dave Airlie --- src/mesa/program/ir_to_mesa.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.

  1   2   >