Re: [Mesa-dev] [PATCH V2 12/14] meta: Fix reading luminance texture as rgba in _mesa_meta_pbo_GetTexSubImage()

2015-07-23 Thread Iago Toral
On Thu, 2015-07-23 at 11:40 -0700, Anuj Phogat wrote: > On Wed, Jul 22, 2015 at 7:10 AM, Iago Toral wrote: > > The problem here is that the _mesa_meta_BlitFramebuffer is not setting > > G/B channels to 0.0 when doing Luminance/Intensity to RGBA conversions, > > so why not implement the fix in _mes

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Michael Schellenberger Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Am 21.07.2015 um 18:38 schrieb Francisco Jerez: > Define a function to calculate the memory address of the image > location given by a vector of coordinates. This is required in > cases where we need to fall back to untyped surface access, which

Re: [Mesa-dev] [PATCH v4 (part2) 52/56] mesa: Add getters for the GL_ARB_shader_storage_buffer_object max constants

2015-07-23 Thread Samuel Iglesias Gonsálvez
On 23/07/15 08:42, Samuel Iglesias Gonsalvez wrote: > v2: > - Add tessellation shader constants support > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/main/get.c | 1 + > src/mesa/main/get_hash_params.py | 14 ++ > 2 files changed, 15 insertions(+) > >

[Mesa-dev] [PATCH] gm107/ir: avoid letting the lowering pass get out of sync

2015-07-23 Thread Ilia Mirkin
There's a lot of functionality duplicated in the gm107 lowering pass from the nvc0 pass. As that one gets updated, the gm107 one falls behind. Avoid this by sharing the code. Signed-off-by: Ilia Mirkin --- Ben, any reason you didn't do this in the first place? .../nouveau/codegen/nv50_ir_lower

[Mesa-dev] [Bug 91441] make check DispatchSanity_test.GL30 regression

2015-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91441 Dave Airlie changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 91290] SIGSEGV glcpp/glcpp-parse.y:1077

2015-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91290 Samuel Iglesias changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glsl/glcpp: fix SIGSEGV when checking error condition for macro redefinition

2015-07-23 Thread Samuel Iglesias Gonsálvez
On 23/07/15 18:22, Anuj Phogat wrote: > On Thu, Jul 23, 2015 at 2:19 AM, Samuel Iglesias Gonsalvez > wrote: >> Commit a6e9cd14c does not take into account than node_{a,b}->next could be >> NULL >> in some circumstances, such as in a shader containing this code: >> >> #define A 1 /* comment */

Re: [Mesa-dev] [PATCH] glsl/glcpp: fix SIGSEGV when checking error condition for macro redefinition

2015-07-23 Thread Samuel Iglesias Gonsálvez
On 23/07/15 18:56, Emil Velikov wrote: > On 23 July 2015 at 10:19, Samuel Iglesias Gonsalvez > wrote: >> Commit a6e9cd14c does not take into account than node_{a,b}->next could be >> NULL >> in some circumstances, such as in a shader containing this code: >> >> #define A 1 /* comment */ >>

[Mesa-dev] [PATCH 2/2] radeonsi: ubo indexing support (v2)

2015-07-23 Thread Dave Airlie
From: Dave Airlie This is required as part of ARB_gpu_shader5. no backend changes are required for this, or if any are, it's the same ones as for samplers. v2: use get_indirect_index (Marek) Signed-off-by: Dave Airlie --- docs/GL3.txt | 2 +- src/gallium/drivers/

[Mesa-dev] [PATCH 1/2] radeonsi: add support for indirect samplers (v2)

2015-07-23 Thread Dave Airlie
From: Dave Airlie This adds the frontend support, however the llvm backend produces the wrong pattern, however we can conditionalise enabling ARB_gpu_shader5 on whatever version of llvm we fix this in. v2: drop unneeded sampler_indirect checks (Marek) Signed-off-by: Dave Airlie --- docs/GL3.tx

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for indirect samplers

2015-07-23 Thread Dave Airlie
> >> + >> static void tex_fetch_args( >> struct lp_build_tgsi_context * bld_base, >> struct lp_build_emit_data * emit_data) >> @@ -1640,10 +1658,36 @@ static void tex_fetch_args( >> unsigned num_coords = tgsi_util_get_texture_coord_dim(target, >> &ref_pos); >> unsi

[Mesa-dev] [PATCH 1/2] radeonsi: split out interpolation input selection

2015-07-23 Thread Dave Airlie
From: Dave Airlie This is prep work for using it in the interpolation code later. Also add storage for the input interpolation mode so we can pick it up later. Reviewed-by: Marek Olšák Signed-off-by: Dave Airlie --- src/gallium/drivers/radeonsi/si_shader.c | 62 +++---

[Mesa-dev] [PATCH 2/2] radeonsi: add fine derivate control (v2)

2015-07-23 Thread Dave Airlie
From: Dave Airlie This adds support for fine derivatives and enables ARB_derivative_control on radeonsi. (just fell out of my working out interpolation) v2: cleanup some bits, and try and write an explaination. Signed-off-by: Dave Airlie --- docs/GL3.txt | 2 +-

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add support for interpolateAt functions

2015-07-23 Thread Dave Airlie
On 24 July 2015 at 13:29, Michel Dänzer wrote: > On 22.07.2015 07:51, Dave Airlie wrote: >> From: Dave Airlie >> >> This is part of ARB_gpu_shader5, and this passes >> all the piglit tests currently available. >> >> Signed-off-by: Dave Airlie > > [...] > >> @@ -2263,6 +2263,225 @@ static void si

Re: [Mesa-dev] [PATCH] radeonsi: fix GLSL textureGrad(samplerCube*) functions

2015-07-23 Thread Michel Dänzer
On 24.07.2015 08:11, Marek Olšák wrote: > From: Marek Olšák > > +4 piglits Awesome! I love piglits. :) Just some cosmetic issues: > @@ -174,7 +174,8 @@ static inline LLVMValueRef bitcast( > > void radeon_llvm_emit_prepare_cube_coords(struct lp_build_tgsi_context * > bld_base, >

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add support for interpolateAt functions

2015-07-23 Thread Michel Dänzer
On 22.07.2015 07:51, Dave Airlie wrote: > From: Dave Airlie > > This is part of ARB_gpu_shader5, and this passes > all the piglit tests currently available. > > Signed-off-by: Dave Airlie [...] > @@ -2263,6 +2263,225 @@ static void si_llvm_emit_ddxy( > emit_data->output[0] = lp_build_ga

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add fine derivate control

2015-07-23 Thread Michel Dänzer
On 22.07.2015 07:51, Dave Airlie wrote: > From: Dave Airlie > > This adds support for fine derivatives and enables > ARB_derivative_control on radeonsi. > > (just fell out of my working out interpolation) In addition to Marek's comments: > diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [Bug 91441] make check DispatchSanity_test.GL30 regression

2015-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91441 Vinson Lee changed: What|Removed |Added Keywords||bisected CC|

[Mesa-dev] [Bug 91441] make check DispatchSanity_test.GL30 regression

2015-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91441 Bug ID: 91441 Summary: make check DispatchSanity_test.GL30 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keyw

Re: [Mesa-dev] [PATCH] nir: Add a value range propagation pass

2015-07-23 Thread Connor Abbott
(I'm replying to this version, since I can't find an email corresponding to the version you have on Github. Did you ever get git-send-email working again?) On Tue, Jul 14, 2015 at 4:29 PM, Thomas Helland wrote: > Signed-off-by: Thomas Helland > --- > src/glsl/Makefile.sources |1 +

[Mesa-dev] [PATCH] mesa: return INVALID_OPERATION if there's no image in GetTex*Image

2015-07-23 Thread Ilia Mirkin
Commit 17f714836 (mesa: rearrange texture error checking order) moved the width/height/depth == 0 allowance before checking if the image was there. This was in part due to depth having to be == 1 for 2D images and width having to be == 1 for 1D images. Instead relax the height/depth checks to also

Re: [Mesa-dev] [PATCH] st/mesa: fix GLSL 1.30 texture shadow functions with the GL_ALPHA depth mode

2015-07-23 Thread Dave Airlie
On 24 July 2015 at 09:11, Marek Olšák wrote: > From: Marek Olšák > > Fixes piglit: > spec@glsl-1.30@execution@fs-texture-sampler2dshadow-10 > spec@glsl-1.30@execution@fs-texture-sampler2dshadow-11 Oh good idea for a fix, I'm not sure I like the passing both MESA_ and PIPE_ stages, maybe

Re: [Mesa-dev] [PATCH 09/12] i965/fs: Hook up SIMD lowering to handle texturing opcodes of unsupported width.

2015-07-23 Thread Kenneth Graunke
On Saturday, July 18, 2015 05:34:55 PM Francisco Jerez wrote: > This should match the set of cases in which we currently call fail() > or no16() from the emit_texture_*() methods and the ones in which > emit_texture_gen4() enables the SIMD16 workaround. > > Hint for reviewers: It's not a big deal

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Jason Ekstrand
Ok, I've looked through this again and convinced myself that it's *mostly* correct. I am a bit skeptical of the address swizzling for Y-major tiling. I've also included some comments that I'd like to see added (assuming they're correct). Sometimes it's easier to write helpful comments if the per

[Mesa-dev] [PATCH] radeonsi: fix GLSL textureGrad(samplerCube*) functions

2015-07-23 Thread Marek Olšák
From: Marek Olšák +4 piglits --- src/gallium/drivers/radeon/radeon_llvm.h | 3 +- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 84 -- src/gallium/drivers/radeonsi/si_shader.c | 35 ++--- 3 files changed, 89 insertions(+), 33 deletions(-) diff

[Mesa-dev] [PATCH] st/mesa: fix GLSL 1.30 texture shadow functions with the GL_ALPHA depth mode

2015-07-23 Thread Marek Olšák
From: Marek Olšák Fixes piglit: spec@glsl-1.30@execution@fs-texture-sampler2dshadow-10 spec@glsl-1.30@execution@fs-texture-sampler2dshadow-11 --- src/mesa/state_tracker/st_atom_texture.c | 67 1 file changed, 51 insertions(+), 16 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Chad Versace
On Wed 22 Jul 2015, Jason Ekstrand wrote: > This needs a *lot* more commentary. These calculations are extremely > tricky and there are almost no comments. For instance, you are > turning a 2D offset on a tiled surface into a new 2D address into the > raw view of the surface. Nowhere do you expl

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Ilia Mirkin
On Thu, Jul 23, 2015 at 6:49 PM, Brian Paul wrote: > On 07/23/2015 04:37 PM, Ilia Mirkin wrote: >> >> On Thu, Jul 23, 2015 at 6:34 PM, Brian Paul wrote: >>> >>> On 07/23/2015 04:24 PM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: > > > On 07/22

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Brian Paul
On 07/23/2015 04:37 PM, Ilia Mirkin wrote: On Thu, Jul 23, 2015 at 6:34 PM, Brian Paul wrote: On 07/23/2015 04:24 PM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: O

Re: [Mesa-dev] [PATCH v2 12/78] i965/nir/vec4: Implement load_const intrinsic

2015-07-23 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 3:16 AM, Eduardo Lima Mitev wrote: > Similar to fs_nir backend, a nir_local_values map will be filled with > newly allocated registers as the load_const instrinsic instructions are > processed. Later, get_nir_src() will fetch the registers from this map > for sources that a

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Ilia Mirkin
On Thu, Jul 23, 2015 at 6:34 PM, Brian Paul wrote: > On 07/23/2015 04:24 PM, Ilia Mirkin wrote: >> >> On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: >>> >>> On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: > > > On 07/22

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Brian Paul
On 07/23/2015 04:24 PM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the fron

Re: [Mesa-dev] [PATCH v2 09/78] i965/nir: Pass a is_scalar boolean to brw_create_nir()

2015-07-23 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 3:16 AM, Eduardo Lima Mitev wrote: > The upcoming introduction of NIR->vec4 pass will require that some NIR > lowering > passes are enabled/disabled depending on the type of shader (scalar vs. > vector). > > With this patch we pass a 'is_scalar' variable to the process of

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Ilia Mirkin
On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: > On 07/22/2015 11:29 AM, Ilia Mirkin wrote: >> >> On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: >>> >>> On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doin

Re: [Mesa-dev] [PATCH 01/12] i965/fs: Define logical texture sampling opcodes.

2015-07-23 Thread Kenneth Graunke
On Saturday, July 18, 2015 05:34:47 PM Francisco Jerez wrote: > Each logical variant is largely equivalent to the original opcode but > instead of taking a single payload source it expects the arguments > separately as individual sources, like: > > tex_logical dst, coordinates, shadow_c, lod, lod

Re: [Mesa-dev] [PATCH v2 05/78] i965/nir/vec4: Add setup of uniform variables

2015-07-23 Thread Jason Ekstrand
You seem to switch back and forth between "uniforms" and "this->uniforms". It would be nice to be consistent. On Thu, Jul 23, 2015 at 3:16 AM, Eduardo Lima Mitev wrote: > From: Iago Toral Quiroga > > This is based on similar code existing in vec4_visitor. It builds the > uniform register file i

Re: [Mesa-dev] [PATCH v2 02/78] i965/nir/vec4: Select between new nir_vec4 or current vec4_visitor code-paths

2015-07-23 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 3:16 AM, Eduardo Lima Mitev wrote: > The NIR->vec4 pass will be activated if both the following conditions are met: > > * INTEL_USE_NIR environment variable is defined and is positive (1 or true) > * The stage is vertex shader (support for geometry shaders and > ARB_verte

[Mesa-dev] [PATCH] docs: remove expanded ARB_dsa notes

2015-07-23 Thread Ilia Mirkin
This doesn't provide much value since it's all done. The qbo interaction is fairly trivial. Signed-off-by: Ilia Mirkin --- docs/GL3.txt | 9 - 1 file changed, 9 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 5200737..9384923 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -

Re: [Mesa-dev] [PATCH] mesa: fix _mesa_error() compiler warnings in shaderapi.c

2015-07-23 Thread Kai Wasserbäch
Brian Paul wrote on 07/23/2015 03:58 PM: > Fix many instances of: > main/shaderapi.c: In function '_mesa_GetSubroutineUniformLocation': > main/shaderapi.c:2176:7: warning: format not a string literal and no format > arguments [-Wformat-security] >_mesa_error(ctx, GL_INVALID_OPERATION, api_

Re: [Mesa-dev] [PATCH] Match swrast modes more loosely.

2015-07-23 Thread Marek Olšák
Removing the "__DRI_ATTRIB_DOUBLE_BUFFER" case fixes it. I'm not familiar with this code. Some investigation would have to be done to know why it broke. Marek On Thu, Jul 23, 2015 at 10:03 PM, Jose Fonseca wrote: > Sure. It's not easy to grasp the side effects of this, so it doesn't > surprise

Re: [Mesa-dev] [PATCH] Match swrast modes more loosely.

2015-07-23 Thread Jose Fonseca
Sure. It's not easy to grasp the side effects of this, so it doesn't surprise me. Do you know which hunk caused problems? Also, I wonder if it would be possible to make the relaxed matching specific to swrast. (Because for HW renderer it's pretty much guaranteed that the X visuals will match

[Mesa-dev] [Bug 90817] swrast fails to load with certain remote X servers

2015-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90817 José Fonseca changed: What|Removed |Added Status|RESOLVED|REOPENED CC|

Re: [Mesa-dev] [PATCH] Match swrast modes more loosely.

2015-07-23 Thread Marek Olšák
Hi Jose, FYI, I had to revert this, because it broke glxgears on radeonsi. Marek On Wed, Jul 15, 2015 at 3:25 PM, Jose Fonseca wrote: > From: Tom Hughes > > https://bugs.freedesktop.org/show_bug.cgi?id=90817 > > Signed-off-by: Jose Fonseca > --- > src/glx/dri_common.c | 59 > +++

Re: [Mesa-dev] [PATCH] i965: add support for ARB_shader_subroutine

2015-07-23 Thread Kenneth Graunke
On Thursday, July 23, 2015 05:41:51 PM Dave Airlie wrote: > From: Dave Airlie > > This just adds some missing pieces to nir/i965, > it is lightly tested on my Haswell. > > Signed-off-by: Dave Airlie Thanks Dave! Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally si

Re: [Mesa-dev] [PATCH 7.5/20] i965/fs: Import code to transform image coordinates into surface coordinates.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > This moves the calculations to near other stuff. Can't we make > emit_image_load/store() take both dims and is_array parameters and > have it do the adjustment? Yeah, that's sort of what I did, see v4 of PATCH 10/20. > --Jason > > On Thu, Jul 23, 2015 at 10:33 AM, Fran

Re: [Mesa-dev] [PATCH V2 12/14] meta: Fix reading luminance texture as rgba in _mesa_meta_pbo_GetTexSubImage()

2015-07-23 Thread Anuj Phogat
On Wed, Jul 22, 2015 at 7:10 AM, Iago Toral wrote: > The problem here is that the _mesa_meta_BlitFramebuffer is not setting > G/B channels to 0.0 when doing Luminance/Intensity to RGBA conversions, > so why not implement the fix in _mesa_meta_BlitFramebuffer directly? The > GL spec expects frambuf

Re: [Mesa-dev] [PATCH 7.5/20] i965/fs: Import code to transform image coordinates into surface coordinates.

2015-07-23 Thread Jason Ekstrand
This moves the calculations to near other stuff. Can't we make emit_image_load/store() take both dims and is_array parameters and have it do the adjustment? --Jason On Thu, Jul 23, 2015 at 10:33 AM, Francisco Jerez wrote: > Accounting for the padding required for 1D arrays in certain cases. > --

Re: [Mesa-dev] [PATCH] glsl/glcpp: fix SIGSEGV when checking error condition for macro redefinition

2015-07-23 Thread Emil Velikov
On 23 July 2015 at 10:19, Samuel Iglesias Gonsalvez wrote: > Commit a6e9cd14c does not take into account than node_{a,b}->next could be > NULL > in some circumstances, such as in a shader containing this code: > > #define A 1 /* comment */ > #define A 1 /* comment */ > > This patch fixes the

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-23 Thread Stéphane Marchesin
On Thu, Jul 23, 2015 at 9:55 AM, Alex Deucher wrote: > On Wed, Jul 22, 2015 at 6:32 PM, Brian Paul wrote: >> Hi Marek, >> >> This is regarding your commit "st/mesa: use pipe_sampler_view_release for >> releasing sampler views" from last October. >> >> Basically, we have: >> >> void >> st_texture_

[Mesa-dev] [PATCH 7.5/20] i965/fs: Import code to transform image coordinates into surface coordinates.

2015-07-23 Thread Francisco Jerez
Accounting for the padding required for 1D arrays in certain cases. --- .../drivers/dri/i965/brw_fs_surface_builder.cpp| 52 ++ 1 file changed, 52 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp b/src/mesa/drivers/dri/i965/brw_fs_surface_bu

[Mesa-dev] [PATCHv2 18/20] i965/fs: Translate image load, store and atomic NIR intrinsics.

2015-07-23 Thread Francisco Jerez
v2: Move array coordinate workaround into the surface builder. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 106 +++ 1 file changed, 106 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 805f782..318

[Mesa-dev] [PATCHv4 10/20] i965/fs: Implement image load, store and atomic.

2015-07-23 Thread Francisco Jerez
v2: Drop VEC4 suport. v3: Rebase. v4: Move array coordinate workaround into the surface builder. --- .../drivers/dri/i965/brw_fs_surface_builder.cpp| 244 + src/mesa/drivers/dri/i965/brw_fs_surface_builder.h | 20 ++ 2 files changed, 264 insertions(+) diff --git a/src/mes

[Mesa-dev] [PATCHv4 09/20] i965/fs: Import image format conversion primitives.

2015-07-23 Thread Francisco Jerez
Define bitfield packing, unpacking and type conversion operations in terms of which the image format conversion code will be implemented. These don't directly know about image formats: The packing and unpacking functions take a 4-tuple of bit shifts and a 4-tuple of bit widths as arguments, determi

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-23 Thread Alex Deucher
On Wed, Jul 22, 2015 at 6:32 PM, Brian Paul wrote: > Hi Marek, > > This is regarding your commit "st/mesa: use pipe_sampler_view_release for > releasing sampler views" from last October. > > Basically, we have: > > void > st_texture_release_all_sampler_views(struct st_context *st, >

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-23 Thread Roland Scheidegger
Well they are not sharable by definition (per-context entities), it is not meant to work. So, it definitely should be fixed one way or another. Roland Am 23.07.2015 um 17:44 schrieb Marek Olšák: > Hi Brian, > > Like the commit message says, I have no idea how Firefox does it. My > commit only ch

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Thu, Jul 23, 2015 at 3:55 AM, Francisco Jerez > wrote: >> Francisco Jerez writes: >> >>> Jason Ekstrand writes: >>> On Wed, Jul 22, 2015 at 10:05 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Wed, Jul 22, 2015 at 12:31 AM, Fra

Re: [Mesa-dev] [PATCH] glsl/glcpp: fix SIGSEGV when checking error condition for macro redefinition

2015-07-23 Thread Anuj Phogat
On Thu, Jul 23, 2015 at 2:19 AM, Samuel Iglesias Gonsalvez wrote: > Commit a6e9cd14c does not take into account than node_{a,b}->next could be > NULL > in some circumstances, such as in a shader containing this code: > > #define A 1 /* comment */ > #define A 1 /* comment */ > > This patch fix

Re: [Mesa-dev] [PATCH 1/3] gallivm: Don't use raw_debug_ostream for dissasembling

2015-07-23 Thread Jose Fonseca
On 20/07/15 21:39, Jose Fonseca wrote: On 20/07/15 18:35, Tom Stellard wrote: All LLVM API calls that require an ostream object have been removed from the disassemble() function, so we don't need to use this class to wrap _debug_printf() we can just call this function directly. --- src/gallium

Re: [Mesa-dev] [PATCH 17/20] i965/fs: Handle image uniforms in NIR programs.

2015-07-23 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 4:42 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez >> wrote: >>> v2: Move the image_params array back to brw_stage_prog_data. >>> --- >>> src/mesa/drivers/dri/i965/brw_fs.h | 1 + >>> src/mesa/drivers/dr

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-23 Thread Marek Olšák
Hi Brian, Like the commit message says, I have no idea how Firefox does it. My commit only changed the situation from "crash on all drivers" to "undefined behavior on drivers where sampler views are not sharable by contexts". Marek On Thu, Jul 23, 2015 at 12:32 AM, Brian Paul wrote: > Hi Marek,

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-23 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 3:55 AM, Francisco Jerez wrote: > Francisco Jerez writes: > >> Jason Ekstrand writes: >> >>> On Wed, Jul 22, 2015 at 10:05 AM, Francisco Jerez >>> wrote: Jason Ekstrand writes: > On Wed, Jul 22, 2015 at 12:31 AM, Francisco Jerez > wrote: >> Jaso

Re: [Mesa-dev] [PATCH 16/78] i965/nir/vec4: Implement store_output intrinsic

2015-07-23 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 1:01 AM, Eduardo Lima Mitev wrote: > On 07/23/2015 05:20 AM, Jason Ekstrand wrote: >> On Wed, Jul 22, 2015 at 4:37 AM, Eduardo Lima Mitev wrote: >>> On 07/13/2015 01:57 PM, Jason Ekstrand wrote: On Wed, Jul 8, 2015 at 11:54 PM, Eduardo Lima Mitev wrote: > O

Re: [Mesa-dev] [PATCH v2 7/7] nv50: enable GL_AMD_performance_monitor

2015-07-23 Thread Samuel Pitoiset
On 07/23/2015 12:14 AM, Martin Peres wrote: On 01/07/15 01:01, Samuel Pitoiset wrote: This exposes a group of global performance counters that enables GL_AMD_performance_monitor. All piglit tests are okay. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c |

Re: [Mesa-dev] [PATCH v2 5/7] nv50: add support for compute/graphics global performance counters

2015-07-23 Thread Samuel Pitoiset
On 07/23/2015 12:05 AM, Martin Peres wrote: On 01/07/15 01:01, Samuel Pitoiset wrote: This commit adds support for both compute and graphics global performance counters which have been reverse engineered with CUPTI (Linux) and PerfKit (Windows). Currently, only one query type can be monitored

Re: [Mesa-dev] [PATCH v2 4/7] nv50: configure the ring buffer for reading back PM counters

2015-07-23 Thread Samuel Pitoiset
On 07/22/2015 10:54 PM, Martin Peres wrote: On 01/07/15 01:01, Samuel Pitoiset wrote: To write data at the right offset, the kernel has to know some parameters of this ring buffer, like the number of domains and the maximum number of queries. Changes since v2: - only configure the ring buff

Re: [Mesa-dev] [PATCH v2 2/7] nv50: allocate a software object class

2015-07-23 Thread Samuel Pitoiset
On 07/22/2015 10:35 PM, Martin Peres wrote: On 01/07/15 01:01, Samuel Pitoiset wrote: This will allow to monitor global performance counters through the command stream of the GPU instead of using ioctls. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 11

Re: [Mesa-dev] [PATCH v2 1/7] nouveau: implement the nvif hardware performance counters interface

2015-07-23 Thread Samuel Pitoiset
On 07/22/2015 10:29 PM, Martin Peres wrote: On 01/07/15 01:01, Samuel Pitoiset wrote: This commit implements the base interface for hardware performance counters that will be shared between nv50 and nvc0 drivers. TODO: Bump libdrm version of mesa when nvif will be merged. Changes since v2:

[Mesa-dev] [Bug 90817] swrast fails to load with certain remote X servers

2015-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90817 José Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 91418] Visual Studio 2015 vsnprintf build error

2015-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91418 José Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/3] mesa: do more thorough target checking in compressed_subtexture_target_check()

2015-07-23 Thread Brian Paul
On 07/23/2015 08:26 AM, Roland Scheidegger wrote: Am 23.07.2015 um 15:57 schrieb Brian Paul: When we're error-checking the target, we also need to check if the corresponding extension is supported. --- src/mesa/main/teximage.c | 67 +--- 1 file chan

Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-07-23 Thread Lofstedt, Marta
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Wednesday, July 22, 2015 8:55 PM > To: Ilia Mirkin; Palli, Tapani > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable > GL_A

Re: [Mesa-dev] [PATCH] st/mesa: remove unused 'samp' function parameters

2015-07-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 23, 2015 at 3:57 PM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_atom_texture.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/state_tracker/st_atom_texture.c > b/src/mesa/state_tracker/st_atom_textu

Re: [Mesa-dev] [PATCH 2/2] radeonsi: ubo indexing support

2015-07-23 Thread Marek Olšák
On Wed, Jul 22, 2015 at 3:27 AM, Dave Airlie wrote: > From: Dave Airlie > > This is required as part of ARB_gpu_shader5. > > no backend changes are required for this, or if > any are, it's the same ones as for samplers. > > Signed-off-by: Dave Airlie > --- > docs/GL3.txt

[Mesa-dev] [PATCH V5 7/7] mesa/es3.1: enable GL_ARB_explicit_uniform_location for GLES 3.1

2015-07-23 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 072c1a5..5b308e8 100644 --- a/src/mesa/mai

[Mesa-dev] [PATCH V5 4/7] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-07-23 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 18 +- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 39fe725..60c1b1b 100644

[Mesa-dev] [PATCH V5 6/7] mesa/es3.1: enable GL_ARB_compute_shader for GLES 3.1

2015-07-23 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 20 ++-- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index a443493..072c1a5 1006

[Mesa-dev] [PATCH V5 2/7] mesa/es3.1: enable GL_ARB_shader_image_load_store for GLES 3.1

2015-07-23 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 17 +++-- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index ec7eb71..dc04930 100644 -

[Mesa-dev] [PATCH V5 3/7] mesa/es3.1: enable GL_ARB_shader_atomic_counters for GLES 3.1

2015-07-23 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 20 +++- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index dc04930..39fe725 10064

[Mesa-dev] [PATCH V5 1/7] mesa/es3.1: Add ES 3.1 handling to get.c and get_hash_generator.py

2015-07-23 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 5 - src/mesa/main/get_hash_generator.py | 12 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index ce78691..ec7eb71 100644 -

[Mesa-dev] [PATCH V5 5/7] mesa/es3.1: enable GL_ARB_texture_gather for GLES 3.1

2015-07-23 Thread Marta Lofstedt
From: Marta Lofstedt Signed-off-by: Marta Lofstedt --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 10 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 60c1b1b..a443493 100644 --- a/sr

[Mesa-dev] [PATCH V5 0/7] Enabling extension enums for OpenGL ES 3.1

2015-07-23 Thread Marta Lofstedt
This is V5 of my patch-set for enabling extension enums for OpenGL ES 3.1. This update address comments from Ilia Mirkin and adds a new GLES31 label. I have my current GLES 3.1 work on github: https://github.com/MartaLo/mesa For theese patches see the gles31_resent_patches, branch Marta Lofsted

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for indirect samplers

2015-07-23 Thread Marek Olšák
On Wed, Jul 22, 2015 at 3:27 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds the frontend support, however the llvm > backend produces the wrong pattern, however > we can conditionalise enabling ARB_gpu_shader5 > on whatever version of llvm we fix this in. The driver can assume that thi

Re: [Mesa-dev] [PATCH 3/3] mesa: do more thorough target checking in compressed_subtexture_target_check()

2015-07-23 Thread Roland Scheidegger
Am 23.07.2015 um 15:57 schrieb Brian Paul: > When we're error-checking the target, we also need to check if the > corresponding extension is supported. > --- > src/mesa/main/teximage.c | 67 > +--- > 1 file changed, 41 insertions(+), 26 deletions(-) >

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v4)

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > *whew*, I've made it through the entire series... > Thanks! > On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez > wrote: >> Another resend of the i965 compiler-related changes for >> ARB_shader_image_load_store, reworked to make use of the SIMD lowering >> infrastructur

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > This needs a *lot* more commentary. These calculations are extremely > tricky and there are almost no comments. For instance, you are > turning a 2D offset on a tiled surface into a new 2D address into the > raw view of the surface. Nowhere do you explain what the "raw

[Mesa-dev] [PATCH] mesa: fix _mesa_error() compiler warnings in shaderapi.c

2015-07-23 Thread Brian Paul
Fix many instances of: main/shaderapi.c: In function '_mesa_GetSubroutineUniformLocation': main/shaderapi.c:2176:7: warning: format not a string literal and no format arguments [-Wformat-security] _mesa_error(ctx, GL_INVALID_OPERATION, api_name); ^ Ideally, many of these error messa

[Mesa-dev] [PATCH 3/3] mesa: do more thorough target checking in compressed_subtexture_target_check()

2015-07-23 Thread Brian Paul
When we're error-checking the target, we also need to check if the corresponding extension is supported. --- src/mesa/main/teximage.c | 67 +--- 1 file changed, 41 insertions(+), 26 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/texi

[Mesa-dev] [PATCH 1/3] mesa: simplify format check in compressed_subtexture_target_check()

2015-07-23 Thread Brian Paul
Lose the invalidformat local variable. --- src/mesa/main/teximage.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 3b309ab..4fe6ee4 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/texima

[Mesa-dev] [PATCH] st/mesa: remove unused 'samp' function parameters

2015-07-23 Thread Brian Paul
--- src/mesa/state_tracker/st_atom_texture.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/st_atom_texture.c index ba3cf9b..1e31533 100644 --- a/src/mesa/state_tracker/st_atom_texture.c +++ b/src/mesa/

Re: [Mesa-dev] [PATCH 1/4] radeonsi: separate out load sample position

2015-07-23 Thread Marek Olšák
Patches 1 & 2: Reviewed-by: Marek Olšák I can't review 3 & 4 before I know more about derivatives. Marek On Wed, Jul 22, 2015 at 12:51 AM, Dave Airlie wrote: > From: Dave Airlie > > This is prep work for reusing this in the interpolation > code later. > > Signed-off-by: Dave Airlie > --- >

[Mesa-dev] [PATCH 2/3] mesa: another target fix in compressed_subtexture_target_check()

2015-07-23 Thread Brian Paul
The previous fix added GL_TEXTURE_CUBE_MAP_ARRAY but we also need to support GL_TEXTURE_CUBE_MAP (via DSA). So in the end, GL_TEXTURE_3D is the only (legal) target for glCompressedTex*SubImage3D() which needs additional compression format checking. GL_TEXTURE_2D_ARRAY, GL_TEXTURE_CUBE_MAP_ARRAY a

Re: [Mesa-dev] [PATCH 1/2] doxygen: Correct grammatical typo in math/m_vector.h

2015-07-23 Thread Brian Paul
On 07/22/2015 10:14 PM, rhysk...@gmail.com wrote: From: Rhys Kidd Signed-off-by: Rhys Kidd --- src/mesa/math/m_vector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/math/m_vector.h b/src/mesa/math/m_vector.h index 8551ee7..3b7f583 100644 --- a/src/mesa/math/m

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add fine derivate control

2015-07-23 Thread Marek Olšák
On Wed, Jul 22, 2015 at 12:51 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds support for fine derivatives and enables > ARB_derivative_control on radeonsi. > > (just fell out of my working out interpolation) > > Signed-off-by: Dave Airlie > --- > docs/GL3.txt

Re: [Mesa-dev] [PATCH 2/4] radeonsi: split out interpolation input selection

2015-07-23 Thread Marek Olšák
On Wed, Jul 22, 2015 at 12:51 AM, Dave Airlie wrote: > From: Dave Airlie > > This is prep work for using it in the interpolation code > later. > > Also add storage for the input interpolation mode so we > can pick it up later. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/radeonsi/

Re: [Mesa-dev] [PATCH 18/20] i965/fs: Translate image load, store and atomic NIR intrinsics.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez > wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 149 >> +++ >> 1 file changed, 149 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp >> b/src/mesa/drive

[Mesa-dev] New stable-branch 10.6 candidate pushed

2015-07-23 Thread Emil Velikov
Hello list, The candidate for the Mesa 10.6.3 is now available. Currently we have: - 14 queued - 31 nominated (outstanding) - and 3 rejected/obsolete patches The biggest hunk this time around are nouveau fixes, although we also have fixes in the VL module (affecting VDPAU/VAAPI/OMX), XA (memor

Re: [Mesa-dev] [PATCH 20/20] i965: Expose ARB_shader_image_load_store.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez > wrote: >> Reviewed-by: Paul Berry > > I'm sure that Paul still thinks this patch does what the commit > message says. However, does the r-b really still apply to the rest of > it? > To the rest of the series? Seems u

Re: [Mesa-dev] [PATCH 17/20] i965/fs: Handle image uniforms in NIR programs.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez > wrote: >> v2: Move the image_params array back to brw_stage_prog_data. >> --- >> src/mesa/drivers/dri/i965/brw_fs.h | 1 + >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50 >> +++- >>

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > This all looks correct as far as I can tell. However, I'm very > concerned about the number of checks such as > has_matching_typed_format() that are built-in to the compiler (via > surface_builder) where we then go on to do something that is highly > dependant on state s

Re: [Mesa-dev] [PATCH 09/20] i965/fs: Import image format conversion primitives.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez > wrote: >> Define bitfield packing, unpacking and type conversion operations in >> terms of which the image format conversion code will be implemented. >> These don't directly know about image formats: The packing and >>

  1   2   >