Re: [Mesa-dev] [PATCH 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-03 Thread Emil Velikov
On 2 August 2015 at 11:37, Oded Gabbay oded.gab...@gmail.com wrote: This patch fixes a bug in big-endian handling, where the previous swizzle info wasn't cleared before a new swizzle info was inserted into the format field using a bitwise-OR operation. Signed-off-by: Oded Gabbay

Re: [Mesa-dev] [PATCH 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-03 Thread Emil Velikov
Hi Oded, On 2 August 2015 at 11:37, Oded Gabbay oded.gab...@gmail.com wrote: This patch fixes a bug that is manifested in the read path of mesa when running on big-endian machines. The effects can be seen when running piglit sanity test and/or taking a screen capture. The bug is caused when

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Marek Olšák
On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Patches 1-6 are: Reviewed-by: Samuel Pitoiset samuel.pitoi...@gmail.com But please, fix the commit message for patches 1 and 3 (ie. gallium/hud instead of gallium, hud). Btw, it would be good to display

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Eduardo Lima Mitev
On 08/03/2015 04:57 PM, Jason Ekstrand wrote: On Aug 3, 2015 4:17 AM, Eduardo Lima Mitev el...@igalia.com mailto:el...@igalia.com wrote: On 08/01/2015 02:59 PM, Eduardo Lima Mitev wrote: On 07/31/2015 10:48 AM, Eduardo Lima Mitev wrote: On 07/30/2015 09:48 PM, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Daniel Scharrer
Hi, thanks for looking at this. On 2015-08-03 16:18, Brian Paul wrote: On 08/03/2015 06:01 AM, Daniel Scharrer wrote: Ping. Can someone please review and/or commit this. I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch be Cc'd to that? Probably. -- Daniel

Re: [Mesa-dev] [PATCH 05/21] mesa: Resolve GCC sign-compare warning.

2015-08-03 Thread Brian Paul
On 08/03/2015 12:09 AM, Rhys Kidd wrote: mesa/src/mesa/drivers/dri/common/utils.c: In function 'driGetConfigAttrib': mesa/src/mesa/drivers/dri/common/utils.c:457:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ARRAY_SIZE(attribMap);

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 --- Comment #10 from di...@gmx.net --- Can someone please look into this issue. On every start of mpv my system freezes for some seconds and every instance of the flashplugin crashes in my browser. I'm always using mpv for watching flashvideos

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Samuel Pitoiset
On 08/03/2015 05:28 PM, Marek Olšák wrote: On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Patches 1-6 are: Reviewed-by: Samuel Pitoiset samuel.pitoi...@gmail.com But please, fix the commit message for patches 1 and 3 (ie. gallium/hud instead of gallium,

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

2015-08-03 Thread Matt Turner
On Fri, Jul 17, 2015 at 11:53 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 17 July 2015 at 19:09, Matt Turner matts...@gmail.com wrote: On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hello all, A few days ago I realised that BSD make (bmake) is

Re: [Mesa-dev] [PATCH 3/7] mesa: Replace F_TO_I() with _mesa_lroundevenf().

2015-08-03 Thread Matt Turner
On Fri, Jul 31, 2015 at 5:46 PM, Roland Scheidegger srol...@vmware.com wrote: + */ +static inline long +_mesa_lroundevenf(float x) +{ + return lrintf(x); +} + +/** + * \brief Rounds \c x to the nearest integer, with ties to the even integer, + * and returns the value as a long int. +

[Mesa-dev] [PATCH] st/mesa: implement query pause/resume for meta operations

2015-08-03 Thread Brian Paul
glClear, blitting, mipmap generation, etc. implemented with quad drawing should not effect queries like occlusion count. To accomplish that, this patch implements a simple pause/resume mechanism for active queries. We now keep a list of active queries. When we pause queries we actually end

[Mesa-dev] [PATCH] nir: Add a nir_lower_load_const_to_scalar() pass.

2015-08-03 Thread Eric Anholt
This is useful to increase the CSE opportunities for a scalar backend. It avoids regressions when dropping vc4's custom CSE implementation. --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h| 1 +

Re: [Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote: On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote: Currently stage reference mask is built using the variable name only. However it can happen that input of one stage has same name as output from another stage. Adding check of

[Mesa-dev] [PATCH] mesa: handle no-op cases sooner in _mesa_[Client]ActiveTexture()

2015-08-03 Thread Brian Paul
If the new texture unit is the current texture unit, we can return before error checking. --- src/mesa/main/texstate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 1e75e0a..9b5928c 100644 ---

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Roland Scheidegger
Am 03.08.2015 um 18:43 schrieb Matt Turner: gcc actually generates this for us now that we use -fno-math-errno (which is weird, since lrintf()/lrint() don't set errno) but clang still does not. Presumably helps MSVC as well. Reduced .text size by 8.5k with gcc before -fno-math-errno.

Re: [Mesa-dev] [PATCH] st/mesa: implement query pause/resume for meta operations

2015-08-03 Thread Marek Olšák
My understanding was that pipe-clear, blit, and resource_copy_region should not increment query values (except for TIME_ELAPSED). Currently, all radeon drivers implement this in the same way as this patch does (it's done more efficiently though), but I've been meaning to get rid of that and just

Re: [Mesa-dev] [PATCH 5/5] vc4: add missing nir include, to fix the build

2015-08-03 Thread Eric Anholt
Emil Velikov emil.l.veli...@gmail.com writes: On 17/07/15 18:17, Emil Velikov wrote: Cc: 10.6 mesa-sta...@lists.freedesktop.org Cc: Eric Anholt e...@anholt.net Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/vc4/Makefile.am | 1 + 1 file changed, 1

[Mesa-dev] [PATCH 2/2] nir: Don't try to scalarize unpack ops.

2015-08-03 Thread Eric Anholt
--- src/glsl/nir/nir_lower_alu_to_scalar.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/nir/nir_lower_alu_to_scalar.c b/src/glsl/nir/nir_lower_alu_to_scalar.c index 5d15fb2..96c84e8 100644 --- a/src/glsl/nir/nir_lower_alu_to_scalar.c +++

[Mesa-dev] [PATCH 1/2] nir: Add algebraic opt for no-op iand.

2015-08-03 Thread Eric Anholt
I lazily generated some of these in VC4 NIR lowering. --- src/glsl/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py index 3068445..d7c1740 100644 --- a/src/glsl/nir/nir_opt_algebraic.py +++

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Jason Ekstrand
On Mon, Aug 3, 2015 at 9:51 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Mon, Aug 3, 2015 at 8:54 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 08/03/2015 04:57 PM, Jason Ekstrand wrote: On Aug 3, 2015 4:17 AM, Eduardo Lima Mitev el...@igalia.com mailto:el...@igalia.com wrote: On

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #43 from Antoine Labour pi...@chromium.org --- I see, the XResizeWindow would cause a DRI2 Invalidate event on the server side, and the XSync would make sure it's handled on the client before anything else happens. That seems like it

Re: [Mesa-dev] [PATCH] st/mesa: implement query pause/resume for meta operations

2015-08-03 Thread Ilia Mirkin
I think I brought this up recently (perhaps this is even in response to my comments about this)... my suggestion was to introduce a draw flag that says whether the draw should be counted. mipmap (and blit) should be using pipe-blit, which should never get counted anyways, so all that's left are

[Mesa-dev] [PATCH 5/5] i965/vec4_nir: Properly handle integer multiplies on BDW+

2015-08-03 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 52 -- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp index 1b7fb5e..7251ca0 100644 ---

[Mesa-dev] [PATCH 4/5] i965/vec4_nir: Do boolean source modifier resolves on BDW+

2015-08-03 Thread Jason Ekstrand
On BDW+, the negation source modifier on NOT, AND, OR, and XOR, is actually a boolean negate and not an integer negate. However, NIR's soruce modifiers are the integer version. We have to resolve it with a MOV prior to emitting the actual instruction. This is basically the same thing we do in

[Mesa-dev] [PATCH 1/5] i965/nir: Use nir_op_info.output_type for determining when to resolve

2015-08-03 Thread Jason Ekstrand
Previously, we were explicitly listing every instruction that needs a resolve. However, those instructions were precicely the ones that returned booleans so there's no reason why we shouldn't just have that check. Also, all of the reduction opcodes such as bany and ball were missing so it didn't

[Mesa-dev] [PATCH 3/5] i965/vec4-nir: Handle boolean resolvese on ILK-

2015-08-03 Thread Jason Ekstrand
The analysis code was already there and running, we just weren't doing anything with the result of it yet. --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp

[Mesa-dev] [PATCH 0/5] i965/vec4_nir: Various fixes for ILK- and BDW+

2015-08-03 Thread Jason Ekstrand
This is a quick little series that fixes a bunch of piglit regressions with vec4 NIR on ILK- and BDW+. With this series, vec4 NIR has (I think) zero regressions versus non-NIR on all intel platforms. I haven't yet tested NIR with vec4 vertex shaders on BDW, but I think it's probably ok. We

[Mesa-dev] [PATCH 2/5] i965/nir: Don't mark bany or ball instructions for resolve

2015-08-03 Thread Jason Ekstrand
--- .../dri/i965/brw_nir_analyze_boolean_resolves.c| 23 ++ 1 file changed, 23 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir_analyze_boolean_resolves.c b/src/mesa/drivers/dri/i965/brw_nir_analyze_boolean_resolves.c index d1fc06d..c995d2b 100644 ---

Re: [Mesa-dev] [PATCH 2/5] ra: Delete the conflict lists in ra_set_finalize

2015-08-03 Thread Eric Anholt
Jason Ekstrand ja...@jlekstrand.net writes: I'm not 100% sure that this is the right patch. Instead of baking 256 into the allocator, we could allow the user to pass in an initial constant. Since the maximum is statically known, we could also make said constant a hard limit and allocate

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
On Mon, Aug 3, 2015 at 4:17 PM, Roland Scheidegger srol...@vmware.com wrote: Reviewed-by: Roland Scheidegger srol...@vmware.com Thanks! I'm wondering though if this is really exactly implementing lrintf why we're using a different name and not just something like _mesa_lrintf(). Though

[Mesa-dev] [PATCH] i965/cs: Enable barrier in MEDIA_INTERFACE_DESCRIPTOR

2015-08-03 Thread Jordan Justen
Enable barrier in MEDIA_INTERFACE_DESCRIPTOR if the program uses the barrier() GLSL function. On Ivy Bridge and Haswell, this allows the piglit test tests/spec/arb_compute_shader/execution/simple-barrier-atomics.shader_test to pass. On gen8, this enables a similar test with a local group size of

Re: [Mesa-dev] [PATCH 2/2] clover: pass image attributes to the kernel

2015-08-03 Thread Jan Vesely
On Mon, 2015-08-03 at 13:38 +0200, Zoltán Gilián wrote: Committed as 9ef5b7a. On Fri, Jul 31, 2015 at 4:07 PM, Zoltán Gilián zoltan.gil...@gmail.com wrote: Could you please commit this? On Mon, Jul 27, 2015 at 1:28 PM, Francisco Jerez curroje...@riseup.net wrote: Zoltan Gilian

Re: [Mesa-dev] [PATCH 2/5] ra: Delete the conflict lists in ra_set_finalize

2015-08-03 Thread Jason Ekstrand
On Mon, Aug 3, 2015 at 6:12 PM, Eric Anholt e...@anholt.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: I'm not 100% sure that this is the right patch. Instead of baking 256 into the allocator, we could allow the user to pass in an initial constant. Since the maximum is statically

Re: [Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-03 Thread Tapani Pälli
On 08/04/2015 01:27 AM, Timothy Arceri wrote: On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote: On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote: Currently stage reference mask is built using the variable name only. However it can happen that input of one stage has same name as

Re: [Mesa-dev] [PATCH] mesa: handle no-op cases sooner in _mesa_[Client]ActiveTexture()

2015-08-03 Thread Eric Anholt
Brian Paul bri...@vmware.com writes: If the new texture unit is the current texture unit, we can return before error checking. Reviewed-by: Eric Anholt e...@anholt.net signature.asc Description: PGP signature ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v3 (part2) 49/56] main: Add SHADER_STORAGE_BLOCK and BUFFER_VARIABLE support for ARB_program_interface_query

2015-08-03 Thread Tapani Pälli
On 07/31/2015 12:37 PM, Samuel Iglesias Gonsálvez wrote: On Fri, 2015-07-31 at 09:32 +0200, Samuel Iglesias Gonsálvez wrote: On Fri, 2015-07-31 at 09:09 +0300, Tapani Pälli wrote: On 07/14/2015 10:46 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com

Re: [Mesa-dev] [PATCH] mesa: fix name returned for XFB varyings

2015-08-03 Thread Martin Peres
On 03/08/15 11:10, Tapani Pälli wrote: _mesa_get_program_resource_name has logic to append '[0]' in name if variable is an array, this should be skipped for XFB varyings that have array index already appended. Fixes: ES31-CTS.program_interface_query.transform-feedback-types Signed-off-by:

[Mesa-dev] [PATCH 05/21] mesa: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/common/utils.c: In function 'driGetConfigAttrib': mesa/src/mesa/drivers/dri/common/utils.c:457:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ARRAY_SIZE(attribMap); i++) ^ Signed-off-by:

[Mesa-dev] [PATCH 11/21] mesa/egl: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/egl/drivers/dri2/platform_drm.c: In function 'release_buffer': mesa/src/egl/drivers/dri2/platform_drm.c:73:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ARRAY_SIZE(dri2_surf-color_buffers); i++) { ^

[Mesa-dev] [PATCH 02/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_wm_state.c: In function 'brw_color_buffer_write_enabled': mesa/src/mesa/drivers/dri/i965/brw_wm_state.c:53:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ctx-DrawBuffer-_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH 08/21] mesa/glx: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/glx/dri_common.c: In function 'scalarEqual': mesa/src/glx/dri_common.c:259:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ARRAY_SIZE(attribMap); i++) ^ Signed-off-by: Rhys Kidd rhysk...@gmail.com ---

[Mesa-dev] [PATCH 18/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c: In function 'brw_upload_abo_surfaces': mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c:961:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i prog-NumAtomicBuffers; i++) {

[Mesa-dev] [PATCH 00/21] Resolve GCC sign-compare warnings patchset

2015-08-03 Thread Rhys Kidd
GCC warns on -Wsign-compare in a number of locations within i965. This patchset goes a significant way to addressing these compiler warnings. Changes have been made with preference to remain consistent with immediate context of that file, rather than the whole patchset adopting one approach. No

[Mesa-dev] [PATCH 10/21] mesa/gbm: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/gbm/main/backend.c: In function 'find_backend': mesa/src/gbm/main/backend.c:70:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ARRAY_SIZE(backends); ++i) { ^ mesa/src/gbm/main/backend.c: In function

[Mesa-dev] [PATCH 14/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_primitive_restart.c: In function 'can_cut_index_handle_prims': mesa/src/mesa/drivers/dri/i965/brw_primitive_restart.c:94:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i nr_prims; i++) {

[Mesa-dev] [PATCH 12/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_draw_destroy': mesa/src/mesa/drivers/dri/i965/brw_draw.c:630:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i brw-vb.nr_buffers; i++) { ^

[Mesa-dev] [PATCH 03/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_blit_framebuffer_with_blitter': mesa/src/mesa/drivers/dri/i965/intel_fbo.c:836:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i drawFb-_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH 04/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_screen.c: In function 'aub_dump_bmp': mesa/src/mesa/drivers/dri/i965/intel_screen.c:125:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i fb-_NumColorDrawBuffers; i++) { ^

Re: [Mesa-dev] [PATCH 2/2] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

2015-08-03 Thread Tapani Pälli
Sorry, this is not right, forget about this patch :/ On 08/03/2015 09:02 AM, Tapani Pälli wrote: Fixes rest of the failures with ES31-CTS.program_interface_query.no-locations Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/shader_query.cpp | 7 +-- 1 file

Re: [Mesa-dev] [PATCH 06/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Matt Turner
On Sun, Aug 2, 2015 at 11:09 PM, Rhys Kidd rhysk...@gmail.com wrote: mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_validate_framebuffer': mesa/src/mesa/drivers/dri/i965/intel_fbo.c:734:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

[Mesa-dev] [PATCH] mesa: fix name returned for XFB varyings

2015-08-03 Thread Tapani Pälli
_mesa_get_program_resource_name has logic to append '[0]' in name if variable is an array, this should be skipped for XFB varyings that have array index already appended. Fixes: ES31-CTS.program_interface_query.transform-feedback-types Signed-off-by: Tapani Pälli tapani.pa...@intel.com ---

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-03 Thread Timothy Arceri
On Sun, 2015-08-02 at 20:39 -0400, Ilia Mirkin wrote: Given that this is a debug-only thing, I doubt perf numbers are that interesting. I have no clue what the diff is between the two hash tables, but if one is allegedly faster than the other, that should be determined, and we should just

Re: [Mesa-dev] [PATCH] mesa: fix name returned for XFB varyings

2015-08-03 Thread Tapani Pälli
On 08/03/2015 01:48 PM, Martin Peres wrote: On 03/08/15 11:10, Tapani Pälli wrote: _mesa_get_program_resource_name has logic to append '[0]' in name if variable is an array, this should be skipped for XFB varyings that have array index already appended. Fixes:

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 19:32 +1000, Timothy Arceri wrote: On Sun, 2015-08-02 at 20:39 -0400, Ilia Mirkin wrote: Given that this is a debug-only thing, I doubt perf numbers are that interesting. I have no clue what the diff is between the two hash tables, but if one is allegedly faster

Re: [Mesa-dev] [PATCH] mesa: fix name returned for XFB varyings

2015-08-03 Thread Martin Peres
On 03/08/15 13:50, Tapani Pälli wrote: On 08/03/2015 01:48 PM, Martin Peres wrote: On 03/08/15 11:10, Tapani Pälli wrote: _mesa_get_program_resource_name has logic to append '[0]' in name if variable is an array, this should be skipped for XFB varyings that have array index already appended.

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 03:54 +0200, Alejandro Seguí Díaz wrote: I'm starting to contribute and Timothy Arceri told me about this task. The change was made at that sole file because we talked about no need to migrate all tables at once, but we discuss this and I take note to migrate all hash

Re: [Mesa-dev] [PATCH] clover: clEnqueue* should block when asked for

2015-08-03 Thread Francisco Jerez
EdB edb+m...@sigluy.net writes: As a side effect, this fix clRetain/ReleaseEvent Piglit test --- src/gallium/state_trackers/clover/api/transfer.cpp | 29 -- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-03 Thread Tapani Pälli
Currently stage reference mask is built using the variable name only. However it can happen that input of one stage has same name as output from another stage. Adding check of variable mode makes sure we do not pick wrong variable. Fixes some subcases from

[Mesa-dev] [PATCH 2/2] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

2015-08-03 Thread Tapani Pälli
Fixes rest of the failures with ES31-CTS.program_interface_query.no-locations Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/shader_query.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shader_query.cpp

Re: [Mesa-dev] [PATCH] mesa: fix type for array indexing validation

2015-08-03 Thread Tapani Pälli
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 08/02/2015 04:47 AM, Timothy Arceri wrote: parse_program_resource_name returns -1 when the index is invalid this needs to be tested before assigning the value to the unsigned array_index. In link_varyings.cpp (the other place

Re: [Mesa-dev] [PATCH] vl/mpeg12: Silence GCC unused-variable warning.

2015-08-03 Thread Christian König
On 01.08.2015 20:45, Vinson Lee wrote: vl/vl_mpeg12_bitstream.c: In function 'decode_slice': vl/vl_mpeg12_bitstream.c:928:19: warning: unused variable 'extra' [-Wunused-variable] unsigned extra = vl_vlc_get_uimsbf(bs-vlc, 1); ^ Signed-off-by: Vinson Lee

Re: [Mesa-dev] [PATCH 4/4] i965/es3.1: Implement glMemoryBarrierByRegion

2015-08-03 Thread Lofstedt, Marta
-Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Matt Turner Sent: Friday, July 31, 2015 7:48 PM To: Ilia Mirkin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 4/4] i965/es3.1: Implement glMemoryBarrierByRegion On

Re: [Mesa-dev] [PATCH 2/2] radeon/winsys: increase the IB size for VM

2015-08-03 Thread Michel Dänzer
On 01.08.2015 00:16, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Luckily, there is a kernel query, so use the size from that. It currently returns 256KB. It can be increased in the kernel. Both patches are Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel

[Mesa-dev] [PATCH v2] mesa: fix ARRAY_SIZE query for GetProgramResourceiv

2015-08-03 Thread Tapani Pälli
Fixes rest of the failures with ES31-CTS.program_interface_query.no-locations v2: make additional check only for GS inputs Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/mesa/main/shader_query.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] nir: Use a single bit for the dual-source blend index

2015-08-03 Thread Tapani Pälli
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 08/02/2015 08:04 AM, Timothy Arceri wrote: The only values allowed are 0 and 1, and the value is checked before assigning. This is a copy of 8eeca7a56c that seems to have been made to the glsl ir type after it was copied for use in nir but

Re: [Mesa-dev] [PATCH] mesa: fix type for array indexing validation

2015-08-03 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Matt Turner
On Sun, Aug 2, 2015 at 11:09 PM, Rhys Kidd rhysk...@gmail.com wrote: mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_postdraw_set_buffers_need_resolve': mesa/src/mesa/drivers/dri/i965/brw_draw.c:390:22: warning: comparison between signed and unsigned integer expressions

Re: [Mesa-dev] [PATCH] gallium/radeon: always use the llvm. prefix in intrinsic names

2015-08-03 Thread Michel Dänzer
On 01.08.2015 00:35, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com [...] @@ -1176,8 +1176,18 @@ static void emit_frac( struct lp_build_emit_data * emit_data) { LLVMBuilderRef builder = bld_base-base.gallivm-builder; - - LLVMValueRef floor =

Re: [Mesa-dev] [PATCH] gallium/radeon: suspend timer queries between IBs

2015-08-03 Thread Michel Dänzer
On 01.08.2015 00:15, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com When we are measuring the time spent in a draw call, an unexpected flush can distort the result. Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer |

[Mesa-dev] [PATCH 07/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_screen.c: In function 'intel_screen_make_configs': mesa/src/mesa/drivers/dri/i965/intel_screen.c:1222:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i ARRAY_SIZE(formats); i++) {

[Mesa-dev] [PATCH 17/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c: In function 'brw_upload_ubo_surfaces': mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c:901:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i shader-NumUniformBlocks; i++) {

[Mesa-dev] [PATCH 21/21] i965/gen7: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c: In function 'gen7_upload_3dstate_so_decl_list': mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c:119:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i linked_xfb_info-NumOutputs; i++) {

[Mesa-dev] [PATCH 01/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_postdraw_set_buffers_need_resolve': mesa/src/mesa/drivers/dri/i965/brw_draw.c:390:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i fb-_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH 09/21] mesa/glx: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/glx/dri_common_query_renderer.c: In function 'dri2_convert_glx_query_renderer_attribs': mesa/src/glx/dri_common_query_renderer.c:61:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ARRAY_SIZE(query_renderer_map); i++)

[Mesa-dev] [PATCH 15/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_state_cache.c: In function 'brw_try_upload_using_copy': mesa/src/mesa/drivers/dri/i965/brw_state_cache.c:216:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i cache-size; i++) { ^

[Mesa-dev] [PATCH 19/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c: In function 'brw_upload_pull_constants': mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c:84:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i prog_data-nr_pull_params; i++) {

[Mesa-dev] [PATCH 16/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_tex_layout.c: In function 'brw_miptree_layout_texture_array': mesa/src/mesa/drivers/dri/i965/brw_tex_layout.c:560:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int q = 0; q mt-level[level].depth; q++) {

[Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c: In function 'brw_prepare_vertices': mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c:434:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = j = 0; i brw-vb.nr_enabled; i++) {

[Mesa-dev] [PATCH 06/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_validate_framebuffer': mesa/src/mesa/drivers/dri/i965/intel_fbo.c:734:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i ARRAY_SIZE(fb-Attachment); i++) { ^

[Mesa-dev] [PATCH 20/21] i965: Resolve GCC sign-compare warning.

2015-08-03 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c: In function 'gen6_upload_push_constants': mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:85:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i prog_data-nr_params; i++) {

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Jason Ekstrand
On Aug 3, 2015 4:17 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 08/01/2015 02:59 PM, Eduardo Lima Mitev wrote: On 07/31/2015 10:48 AM, Eduardo Lima Mitev wrote: On 07/30/2015 09:48 PM, Jason Ekstrand wrote: On Jul 27, 2015 3:39 PM, Jason Ekstrand ja...@jlekstrand.net

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Brian Paul
On 08/03/2015 08:27 AM, Daniel Scharrer wrote: Hi, thanks for looking at this. On 2015-08-03 16:18, Brian Paul wrote: On 08/03/2015 06:01 AM, Daniel Scharrer wrote: Ping. Can someone please review and/or commit this. I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch be

Re: [Mesa-dev] [PATCH 4/4] i965/es3.1: Implement glMemoryBarrierByRegion

2015-08-03 Thread Matt Turner
On Mon, Aug 3, 2015 at 1:04 AM, Lofstedt, Marta marta.lofst...@intel.com wrote: However, I don't agree that the driver interface should be removed. In my opinion, it is a driver specific decision if glMemoryBarrierByRegion should be implemented directly on top of glMemoryBarrier or if you

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Samuel Pitoiset
On 08/03/2015 08:14 PM, Marek Olšák wrote: On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Patches 1-6 are: Reviewed-by: Samuel Pitoiset samuel.pitoi...@gmail.com But please, fix the commit message for patches 1 and 3 (ie. gallium/hud instead of gallium,

[Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
gcc actually generates this for us now that we use -fno-math-errno (which is weird, since lrintf()/lrint() don't set errno) but clang still does not. Presumably helps MSVC as well. Reduced .text size by 8.5k with gcc before -fno-math-errno. text data bss dec hex filename

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Jason Ekstrand
On Mon, Aug 3, 2015 at 8:54 AM, Eduardo Lima Mitev el...@igalia.com wrote: On 08/03/2015 04:57 PM, Jason Ekstrand wrote: On Aug 3, 2015 4:17 AM, Eduardo Lima Mitev el...@igalia.com mailto:el...@igalia.com wrote: On 08/01/2015 02:59 PM, Eduardo Lima Mitev wrote: On 07/31/2015 10:48 AM,

Re: [Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

2015-08-03 Thread Ian Romanick
On 08/01/2015 07:52 AM, Emil Velikov wrote: On 30 July 2015 at 16:44, Ian Romanick i...@freedesktop.org wrote: On 07/30/2015 07:50 AM, Emil Velikov wrote: On 30 July 2015 at 15:22, Emil Velikov emil.l.veli...@gmail.com wrote: All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and

[Mesa-dev] [PATCH 0/2] glxinfo fix eglinfo improvement

2015-08-03 Thread Marek Olšák
Please review. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] glxinfo: fix printing core profile extensions

2015-08-03 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Nobody supports GLX 3.x. Broken by: commit fca824431608101298ff0735db4c09954dcf64ab Author: Julien Isorce j.iso...@samsung.com Date: Tue May 19 08:35:10 2015 +0100 glxinfo: fix segfault when core profile is unavailable --- src/xdemos/glxinfo.c | 2

[Mesa-dev] [PATCH 1/2] eglinfo: print client extensions

2015-08-03 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/egl/opengl/eglinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 961fd9c..8e82e73 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl/opengl/eglinfo.c @@ -162,9

[Mesa-dev] [PATCH 2/3] radeonsi: add support for FIJI (v4)

2015-08-03 Thread Alex Deucher
v2: incorporate comments from Marek v3: add missing fiji case in winsys init use tonga raster config (double check this) v4: rebase on harvest patch Reviewed-by: Marek Olšák marek.ol...@amd.com (v3) Reviewed-by: Christian König christian.koe...@amd.com (v3) Reviewed-by: David Zhang

[Mesa-dev] [PATCH 1/3] addrlib: add support for Fiji (v2)

2015-08-03 Thread Alex Deucher
v2: fix tonga chip check Reviewed-by: Marek Olšák marek.ol...@amd.com Reviewed-by: Christian König christian.koe...@amd.com Reviewed-by: David Zhang david1.zh...@amd.com Signed-off-by: Alex Deucher alexander.deuc...@amd.com --- src/gallium/winsys/amdgpu/drm/addrlib/r800/ciaddrlib.cpp | 5 +

[Mesa-dev] [PATCH 3/3] radeonsi: add fiji pci id

2015-08-03 Thread Alex Deucher
Reviewed-by: Marek Olšák marek.ol...@amd.com Reviewed-by: Christian König christian.koe...@amd.com Reviewed-by: David Zhang david1.zh...@amd.com Signed-off-by: Alex Deucher alexander.deuc...@amd.com --- include/pci_ids/radeonsi_pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
On Fri, Jul 31, 2015 at 6:37 PM, Roland Scheidegger srol...@vmware.com wrote: Am 01.08.2015 um 03:02 schrieb Matt Turner: On Fri, Jul 31, 2015 at 5:50 PM, Roland Scheidegger srol...@vmware.com wrote: Am 01.08.2015 um 01:26 schrieb Matt Turner: gcc actually generates this for us now that we

Re: [Mesa-dev] [PATCH] glsl: when generating out/inout parameter fixups, do indexing before the call

2015-08-03 Thread Kenneth Graunke
On Friday, July 31, 2015 04:37:16 PM Chris Forbes wrote: If the indexing expression involves anything modified during the call, the fixup code to copy back after the call would use the new values. This fixes the cases where the first expression node encountered is ir_binop_vector_extract,

Re: [Mesa-dev] [PATCH 2/2] glxinfo: fix printing core profile extensions

2015-08-03 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 08/03/2015 10:33 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Nobody supports GLX 3.x. Broken by: commit fca824431608101298ff0735db4c09954dcf64ab Author: Julien Isorce j.iso...@samsung.com Date: Tue

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

2015-08-03 Thread Emil Velikov
On 3 August 2015 at 17:17, Matt Turner matts...@gmail.com wrote: On Fri, Jul 17, 2015 at 11:53 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 17 July 2015 at 19:09, Matt Turner matts...@gmail.com wrote: On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov emil.l.veli...@gmail.com wrote:

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Marek Olšák
On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Patches 1-6 are: Reviewed-by: Samuel Pitoiset samuel.pitoi...@gmail.com But please, fix the commit message for patches 1 and 3 (ie. gallium/hud instead of gallium, hud). gallium,hud means gallium and

Re: [Mesa-dev] [PATCH 2/3] r600g: fix the CB_SHADER_MASK setup

2015-08-03 Thread Marek Olšák
On Mon, Aug 3, 2015 at 1:28 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 2 August 2015 at 14:36, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com This fixes the single-sample fast clear hang. Cc: 10.6 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-03 Thread Emil Velikov
On 3 August 2015 at 13:17, Marek Olšák mar...@gmail.com wrote: On Mon, Aug 3, 2015 at 1:33 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 1 August 2015 at 19:18, Marek Olšák mar...@gmail.com wrote: On Sat, Aug 1, 2015 at 7:29 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 1 August

  1   2   >