Re: [Mesa-dev] [PATCH] mesa: fix name returned for XFB varyings

2015-08-03 Thread Tapani Pälli
On 08/03/2015 02:47 PM, Martin Peres wrote: On 03/08/15 14:35, Tapani Pälli wrote: On 08/03/2015 01:57 PM, Martin Peres wrote: On 03/08/15 13:50, Tapani Pälli wrote: On 08/03/2015 01:48 PM, Martin Peres wrote: On 03/08/15 11:10, Tapani Pälli wrote: _mesa_get_program_resource_name has

Re: [Mesa-dev] [PATCH] i965/cs: Setup push constant data for uniforms

2015-08-03 Thread Jordan Justen
I added this patch to the 7 patch 'i965/cs: gl_LocalInvocationID support' series, so go review it there instead. :) -Jordan On 2015-07-31 10:44:13, Jordan Justen wrote: > brw_upload_cs_push_constants was based on gen6_upload_push_constants. > > v2: > * Add FINISHME comments about more efficient

[Mesa-dev] [PATCH 4/7] i965/cs: Reserve local invocation id in payload regs

2015-08-03 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.cpp | 29 + src/mesa/drivers/dri/i965/brw_cs.h | 5 + src/mesa/drivers/dri/i965/brw_fs.cpp | 11 +++ src/mesa/drivers/dri/i965/brw_fs.h | 1 + 4 files changed, 46 insertions(+) diff --

[Mesa-dev] [PATCH 3/7] nir: Add gl_LocalInvocationID variable

2015-08-03 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/nir/nir_intrinsics.h | 1 + src/glsl/nir/nir_lower_system_values.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h index bc6e6b8..29b5e64 100644 --- a/src/glsl/nir/nir_intrinsi

[Mesa-dev] [PATCH 0/7] i965/cs: gl_LocalInvocationID support

2015-08-03 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa i965-local-inv-id-v1 Note: These depend on 'i965/cs: Setup push constant data for uniforms' which Ben look at, but it still doesn't have an r-b. I've included that patch here due to the dependency, and since I made a minor change to it since I last sent

[Mesa-dev] [PATCH 2/7] glsl/cs: Add gl_LocalInvocationID variable

2015-08-03 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 ++ src/glsl/shader_enums.h| 9 + 2 files changed, 11 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 0ff3a3f..b2936a5 100644 --- a/src/glsl/builtin_variables.cpp

[Mesa-dev] [PATCH 5/7] i965/cs: Initialize gl_LocalInvocationID in push constant data

2015-08-03 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.cpp | 54 +--- 1 file changed, 50 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index 541151a..9e51130 100644 --- a/src/mesa

[Mesa-dev] [PATCH 6/7] i965/cs: Initialize gl_LocalInvocationID from payload

2015-08-03 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_cs.cpp | 25 +++-- src/mesa/drivers/dri/i965/brw_fs.h | 1 + 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cs.cpp b/src/mesa/drivers/dri/i965/brw_cs.cpp index 9e5

[Mesa-dev] [PATCH 7/7] i965/nir: Support gl_LocalInvocationID variable

2015-08-03 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 5549a2d..711ace6 100644 --- a/src/mesa/drivers/dri/i965/brw_fs

[Mesa-dev] [PATCH 1/7] i965/cs: Setup push constant data for uniforms

2015-08-03 Thread Jordan Justen
brw_upload_cs_push_constants was based on gen6_upload_push_constants. v2: * Add FINISHME comments about more efficient ways to push uniforms Signed-off-by: Jordan Justen Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/brw_cs.cpp |

Re: [Mesa-dev] [PATCH v3 (part2) 49/56] main: Add SHADER_STORAGE_BLOCK and BUFFER_VARIABLE support for ARB_program_interface_query

2015-08-03 Thread Tapani Pälli
On 07/31/2015 12:37 PM, Samuel Iglesias Gonsálvez wrote: On Fri, 2015-07-31 at 09:32 +0200, Samuel Iglesias Gonsálvez wrote: On Fri, 2015-07-31 at 09:09 +0300, Tapani Pälli wrote: On 07/14/2015 10:46 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez Including TOP_LEVEL_ARRAY_SI

Re: [Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-03 Thread Tapani Pälli
On 08/04/2015 01:27 AM, Timothy Arceri wrote: On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote: On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote: Currently stage reference mask is built using the variable name only. However it can happen that input of one stage has same name as ou

[Mesa-dev] [PATCH] i965/cs: Enable barrier in MEDIA_INTERFACE_DESCRIPTOR

2015-08-03 Thread Jordan Justen
Enable barrier in MEDIA_INTERFACE_DESCRIPTOR if the program uses the barrier() GLSL function. On Ivy Bridge and Haswell, this allows the piglit test tests/spec/arb_compute_shader/execution/simple-barrier-atomics.shader_test to pass. On gen8, this enables a similar test with a local group size of 8

Re: [Mesa-dev] [PATCH 2/2] clover: pass image attributes to the kernel

2015-08-03 Thread Jan Vesely
On Mon, 2015-08-03 at 13:38 +0200, Zoltán Gilián wrote: > Committed as 9ef5b7a. > > On Fri, Jul 31, 2015 at 4:07 PM, Zoltán Gilián > wrote: > > Could you please commit this? > > > > On Mon, Jul 27, 2015 at 1:28 PM, Francisco Jerez > > wrote: > >> Zoltan Gilian writes: > >> > >>> Read-only and

Re: [Mesa-dev] [PATCH] mesa: handle no-op cases sooner in _mesa_[Client]ActiveTexture()

2015-08-03 Thread Eric Anholt
Brian Paul writes: > If the new texture unit is the current texture unit, we can return > before error checking. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.

Re: [Mesa-dev] [PATCH 2/5] ra: Delete the conflict lists in ra_set_finalize

2015-08-03 Thread Jason Ekstrand
On Mon, Aug 3, 2015 at 6:12 PM, Eric Anholt wrote: > Jason Ekstrand writes: > >> I'm not 100% sure that this is the right patch. Instead of baking 256 into >> the allocator, we could allow the user to pass in an initial constant. >> Since the maximum is statically known, we could also make said

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
On Mon, Aug 3, 2015 at 4:17 PM, Roland Scheidegger wrote: > Reviewed-by: Roland Scheidegger Thanks! > I'm wondering though if this is really exactly implementing lrintf why > we're using a different name and not just something like _mesa_lrintf(). > Though arguably _mesa_roundeven is the same..

Re: [Mesa-dev] [PATCH 2/5] ra: Delete the conflict lists in ra_set_finalize

2015-08-03 Thread Eric Anholt
Jason Ekstrand writes: > I'm not 100% sure that this is the right patch. Instead of baking 256 into > the allocator, we could allow the user to pass in an initial constant. > Since the maximum is statically known, we could also make said constant a > hard limit and allocate everything up-front i

[Mesa-dev] [PATCH] nir: Add a nir_lower_load_const_to_scalar() pass.

2015-08-03 Thread Eric Anholt
This is useful to increase the CSE opportunities for a scalar backend. It avoids regressions when dropping vc4's custom CSE implementation. --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h| 1 + src/glsl/nir/nir_lower_load_const_to_scalar

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Jason Ekstrand
On Mon, Aug 3, 2015 at 9:51 AM, Jason Ekstrand wrote: > On Mon, Aug 3, 2015 at 8:54 AM, Eduardo Lima Mitev wrote: >> On 08/03/2015 04:57 PM, Jason Ekstrand wrote: >>> >>> On Aug 3, 2015 4:17 AM, "Eduardo Lima Mitev" >> > wrote: On 08/01/2015 02:59 PM, Eduardo Li

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #43 from Antoine Labour --- I see, the XResizeWindow would cause a DRI2 Invalidate event on the server side, and the XSync would make sure it's handled on the client before anything else happens. That seems like it would do the right

[Mesa-dev] [PATCH 5/5] i965/vec4_nir: Properly handle integer multiplies on BDW+

2015-08-03 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 52 -- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp index 1b7fb5e..7251ca0 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 4/5] i965/vec4_nir: Do boolean source modifier resolves on BDW+

2015-08-03 Thread Jason Ekstrand
On BDW+, the negation source modifier on NOT, AND, OR, and XOR, is actually a boolean negate and not an integer negate. However, NIR's soruce modifiers are the integer version. We have to resolve it with a MOV prior to emitting the actual instruction. This is basically the same thing we do in th

[Mesa-dev] [PATCH 1/5] i965/nir: Use nir_op_info.output_type for determining when to resolve

2015-08-03 Thread Jason Ekstrand
Previously, we were explicitly listing every instruction that needs a resolve. However, those instructions were precicely the ones that returned booleans so there's no reason why we shouldn't just have that check. Also, all of the reduction opcodes such as bany and ball were missing so it didn't

[Mesa-dev] [PATCH 3/5] i965/vec4-nir: Handle boolean resolvese on ILK-

2015-08-03 Thread Jason Ekstrand
The analysis code was already there and running, we just weren't doing anything with the result of it yet. --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_v

[Mesa-dev] [PATCH 0/5] i965/vec4_nir: Various fixes for ILK- and BDW+

2015-08-03 Thread Jason Ekstrand
This is a quick little series that fixes a bunch of piglit regressions with vec4 NIR on ILK- and BDW+. With this series, vec4 NIR has (I think) zero regressions versus non-NIR on all intel platforms. I haven't yet tested NIR with vec4 vertex shaders on BDW, but I think it's probably ok. We shoul

[Mesa-dev] [PATCH 2/5] i965/nir: Don't mark bany or ball instructions for resolve

2015-08-03 Thread Jason Ekstrand
--- .../dri/i965/brw_nir_analyze_boolean_resolves.c| 23 ++ 1 file changed, 23 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir_analyze_boolean_resolves.c b/src/mesa/drivers/dri/i965/brw_nir_analyze_boolean_resolves.c index d1fc06d..c995d2b 100644 --- a/src/me

Re: [Mesa-dev] [PATCH] st/mesa: implement query pause/resume for meta operations

2015-08-03 Thread Marek Olšák
My understanding was that pipe->clear, blit, and resource_copy_region should not increment query values (except for TIME_ELAPSED). Currently, all radeon drivers implement this in the same way as this patch does (it's done more efficiently though), but I've been meaning to get rid of that and just t

[Mesa-dev] [PATCH 1/2] nir: Add algebraic opt for no-op iand.

2015-08-03 Thread Eric Anholt
I lazily generated some of these in VC4 NIR lowering. --- src/glsl/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py index 3068445..d7c1740 100644 --- a/src/glsl/nir/nir_opt_algebraic.py +++ b/src/gls

[Mesa-dev] [PATCH 2/2] nir: Don't try to scalarize unpack ops.

2015-08-03 Thread Eric Anholt
--- src/glsl/nir/nir_lower_alu_to_scalar.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/nir/nir_lower_alu_to_scalar.c b/src/glsl/nir/nir_lower_alu_to_scalar.c index 5d15fb2..96c84e8 100644 --- a/src/glsl/nir/nir_lower_alu_to_scalar.c +++ b/src/glsl/nir/nir_lower_alu_to_scala

Re: [Mesa-dev] [PATCH 5/5] vc4: add missing nir include, to fix the build

2015-08-03 Thread Eric Anholt
Emil Velikov writes: > On 17/07/15 18:17, Emil Velikov wrote: >> Cc: 10.6 >> Cc: Eric Anholt >> Signed-off-by: Emil Velikov >> --- >> src/gallium/drivers/vc4/Makefile.am | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/gallium/drivers/vc4/Makefile.am >> b/src/gallium/drivers/

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Roland Scheidegger
Am 03.08.2015 um 18:43 schrieb Matt Turner: > gcc actually generates this for us now that we use -fno-math-errno > (which is weird, since lrintf()/lrint() don't set errno) but clang still > does not. Presumably helps MSVC as well. > > Reduced .text size by 8.5k with gcc before -fno-math-errno. >

Re: [Mesa-dev] [PATCH] st/mesa: implement query pause/resume for meta operations

2015-08-03 Thread Ilia Mirkin
I think I brought this up recently (perhaps this is even in response to my comments about this)... my suggestion was to introduce a draw flag that says whether the draw should be counted. mipmap (and blit) should be using pipe->blit, which should never get counted anyways, so all that's left are c

[Mesa-dev] [PATCH] st/mesa: implement query pause/resume for meta operations

2015-08-03 Thread Brian Paul
glClear, blitting, mipmap generation, etc. implemented with quad drawing should not effect queries like occlusion count. To accomplish that, this patch implements a simple pause/resume mechanism for active queries. We now keep a list of active queries. When we "pause" queries we actually end the

[Mesa-dev] [PATCH] mesa: handle no-op cases sooner in _mesa_[Client]ActiveTexture()

2015-08-03 Thread Brian Paul
If the new texture unit is the current texture unit, we can return before error checking. --- src/mesa/main/texstate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 1e75e0a..9b5928c 100644 --- a/

Re: [Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote: > On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote: > > Currently stage reference mask is built using the variable name > > only. However it can happen that input of one stage has same name > > as output from another stage. Adding check

[Mesa-dev] [PATCH] amdgpu: add Fiji support

2015-08-03 Thread Alex Deucher
Signed-off-by: Alex Deucher --- This should be 1/16 speed model. Not sure how to adjust that. Tom? lib/Target/AMDGPU/Processors.td | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/Target/AMDGPU/Processors.td b/lib/Target/AMDGPU/Processors.td index c0ffede..0eac121 100644 --- a/lib/Ta

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Samuel Pitoiset
On 08/03/2015 08:14 PM, Marek Olšák wrote: On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset wrote: Patches 1-6 are: Reviewed-by: Samuel Pitoiset But please, fix the commit message for patches 1 and 3 (ie. gallium/hud instead of gallium, hud). "gallium,hud" means "gallium and gallium/hud".

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Marek Olšák
On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset wrote: > Patches 1-6 are: > > Reviewed-by: Samuel Pitoiset > > But please, fix the commit message for patches 1 and 3 (ie. gallium/hud > instead of gallium, hud). "gallium,hud" means "gallium and gallium/hud". :) I can change it, but that would rem

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

2015-08-03 Thread Emil Velikov
On 3 August 2015 at 17:17, Matt Turner wrote: > On Fri, Jul 17, 2015 at 11:53 AM, Emil Velikov > wrote: >> On 17 July 2015 at 19:09, Matt Turner wrote: >>> On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov >>> wrote: Hello all, A few days ago I realised that BSD make (bmake) is av

Re: [Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

2015-08-03 Thread Ian Romanick
On 08/01/2015 07:52 AM, Emil Velikov wrote: > On 30 July 2015 at 16:44, Ian Romanick wrote: >> On 07/30/2015 07:50 AM, Emil Velikov wrote: >>> On 30 July 2015 at 15:22, Emil Velikov wrote: All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and GLX_MESA_query_renderer have bee

Re: [Mesa-dev] [PATCH 2/2] glxinfo: fix printing core profile extensions

2015-08-03 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 08/03/2015 10:33 AM, Marek Olšák wrote: > From: Marek Olšák > > Nobody supports GLX 3.x. > > Broken by: > > commit fca824431608101298ff0735db4c09954dcf64ab > Author: Julien Isorce > Date: Tue May 19 08:35:10 2015 +0100 > > glxinfo: fix segfa

[Mesa-dev] [PATCH 2/3] radeonsi: add support for FIJI (v4)

2015-08-03 Thread Alex Deucher
v2: incorporate comments from Marek v3: add missing fiji case in winsys init use tonga raster config (double check this) v4: rebase on harvest patch Reviewed-by: Marek Olšák (v3) Reviewed-by: Christian König (v3) Reviewed-by: David Zhang (v3) Signed-off-by: Alex Deucher --- src/gallium/dr

[Mesa-dev] [PATCH 1/3] addrlib: add support for Fiji (v2)

2015-08-03 Thread Alex Deucher
v2: fix tonga chip check Reviewed-by: Marek Olšák Reviewed-by: Christian König Reviewed-by: David Zhang Signed-off-by: Alex Deucher --- src/gallium/winsys/amdgpu/drm/addrlib/r800/ciaddrlib.cpp | 5 + src/gallium/winsys/amdgpu/drm/addrlib/r800/ciaddrlib.h | 1 + src/gallium/winsys/amdgpu

[Mesa-dev] [PATCH 3/3] radeonsi: add fiji pci id

2015-08-03 Thread Alex Deucher
Reviewed-by: Marek Olšák Reviewed-by: Christian König Reviewed-by: David Zhang Signed-off-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 197ce8e..c01ee2

[Mesa-dev] [PATCH 2/2] glxinfo: fix printing core profile extensions

2015-08-03 Thread Marek Olšák
From: Marek Olšák Nobody supports GLX 3.x. Broken by: commit fca824431608101298ff0735db4c09954dcf64ab Author: Julien Isorce Date: Tue May 19 08:35:10 2015 +0100 glxinfo: fix segfault when core profile is unavailable --- src/xdemos/glxinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Mesa-dev] [PATCH 0/2] glxinfo fix & eglinfo improvement

2015-08-03 Thread Marek Olšák
Please review. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] eglinfo: print client extensions

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/egl/opengl/eglinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 961fd9c..8e82e73 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl/opengl/eglinfo.c @@ -162,9 +162,12 @@ PrintExtens

Re: [Mesa-dev] [PATCH] glsl: when generating out/inout parameter fixups, do indexing before the call

2015-08-03 Thread Kenneth Graunke
On Friday, July 31, 2015 04:37:16 PM Chris Forbes wrote: > If the indexing expression involves anything modified during the call, > the fixup code to copy back after the call would use the new values. > > This fixes the cases where the first expression node encountered is > ir_binop_vector_extract

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Jason Ekstrand
On Mon, Aug 3, 2015 at 8:54 AM, Eduardo Lima Mitev wrote: > On 08/03/2015 04:57 PM, Jason Ekstrand wrote: >> >> On Aug 3, 2015 4:17 AM, "Eduardo Lima Mitev" > > wrote: >>> >>> On 08/01/2015 02:59 PM, Eduardo Lima Mitev wrote: >>> > On 07/31/2015 10:48 AM, Eduardo Lima Mite

[Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
gcc actually generates this for us now that we use -fno-math-errno (which is weird, since lrintf()/lrint() don't set errno) but clang still does not. Presumably helps MSVC as well. Reduced .text size by 8.5k with gcc before -fno-math-errno. text data bss dec hex filename 49

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
On Fri, Jul 31, 2015 at 6:37 PM, Roland Scheidegger wrote: > Am 01.08.2015 um 03:02 schrieb Matt Turner: >> On Fri, Jul 31, 2015 at 5:50 PM, Roland Scheidegger >> wrote: >>> Am 01.08.2015 um 01:26 schrieb Matt Turner: gcc actually generates this for us now that we use -fno-math-errno (

Re: [Mesa-dev] [PATCH 3/7] mesa: Replace F_TO_I() with _mesa_lroundevenf().

2015-08-03 Thread Matt Turner
On Fri, Jul 31, 2015 at 5:46 PM, Roland Scheidegger wrote: >> + */ >> +static inline long >> +_mesa_lroundevenf(float x) >> +{ >> + return lrintf(x); >> +} >> + >> +/** >> + * \brief Rounds \c x to the nearest integer, with ties to the even integer, >> + * and returns the value as a long int. >>

Re: [Mesa-dev] [PATCH 00/12] bmake inspired fixes

2015-08-03 Thread Matt Turner
On Fri, Jul 17, 2015 at 11:53 AM, Emil Velikov wrote: > On 17 July 2015 at 19:09, Matt Turner wrote: >> On Fri, Jul 17, 2015 at 10:29 AM, Emil Velikov >> wrote: >>> Hello all, >>> >>> A few days ago I realised that BSD make (bmake) is available in the >>> Archlinux repos, so I decided to give i

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Samuel Pitoiset
On 08/03/2015 05:28 PM, Marek Olšák wrote: On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset wrote: Patches 1-6 are: Reviewed-by: Samuel Pitoiset But please, fix the commit message for patches 1 and 3 (ie. gallium/hud instead of gallium, hud). Btw, it would be good to display floating point

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Eduardo Lima Mitev
On 08/03/2015 04:57 PM, Jason Ekstrand wrote: > > On Aug 3, 2015 4:17 AM, "Eduardo Lima Mitev" > wrote: >> >> On 08/01/2015 02:59 PM, Eduardo Lima Mitev wrote: >> > On 07/31/2015 10:48 AM, Eduardo Lima Mitev wrote: >> >> On 07/30/2015 09:48 PM, Jason Ekstrand wrote: >> >>

Re: [Mesa-dev] [PATCH 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-03 Thread Emil Velikov
Hi Oded, On 2 August 2015 at 11:37, Oded Gabbay wrote: > This patch fixes a bug that is manifested in the read path of mesa when > running on big-endian machines. The effects can be seen when running > piglit sanity test and/or taking a screen capture. > > The bug is caused when _mesa_format_conv

Re: [Mesa-dev] [PATCH 1/2] mesa: clear existing swizzle info before bitwise-OR

2015-08-03 Thread Emil Velikov
On 2 August 2015 at 11:37, Oded Gabbay wrote: > This patch fixes a bug in big-endian handling, where the previous > swizzle info wasn't cleared before a new swizzle info was inserted into > the format field using a bitwise-OR operation. > > Signed-off-by: Oded Gabbay > CC: "10.5 10.6" > --- > s

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Marek Olšák
On Mon, Aug 3, 2015 at 2:58 PM, Samuel Pitoiset wrote: > Patches 1-6 are: > > Reviewed-by: Samuel Pitoiset > > But please, fix the commit message for patches 1 and 3 (ie. gallium/hud > instead of gallium, hud). > > Btw, it would be good to display floating point numbers when percentage is > used.

Re: [Mesa-dev] [PATCH 4/4] i965/es3.1: Implement glMemoryBarrierByRegion

2015-08-03 Thread Matt Turner
On Mon, Aug 3, 2015 at 1:04 AM, Lofstedt, Marta wrote: > However, I don't agree that the driver interface should be removed. > In my opinion, it is a driver specific decision if glMemoryBarrierByRegion > should be > implemented directly on top of glMemoryBarrier or if you want to do some > optimi

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Brian Paul
On 08/03/2015 08:27 AM, Daniel Scharrer wrote: Hi, thanks for looking at this. On 2015-08-03 16:18, Brian Paul wrote: On 08/03/2015 06:01 AM, Daniel Scharrer wrote: Ping. Can someone please review and/or commit this. I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch be C

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-08-03 Thread Jason Ekstrand
On Aug 3, 2015 4:17 AM, "Eduardo Lima Mitev" wrote: > > On 08/01/2015 02:59 PM, Eduardo Lima Mitev wrote: > > On 07/31/2015 10:48 AM, Eduardo Lima Mitev wrote: > >> On 07/30/2015 09:48 PM, Jason Ekstrand wrote: > >>> > >>> On Jul 27, 2015 3:39 PM, "Jason Ekstrand" >>>

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 --- Comment #10 from di...@gmx.net --- Can someone please look into this issue. On every start of mpv my system freezes for some seconds and every instance of the flashplugin crashes in my browser. I'm always using mpv for watching flashvideos sin

Re: [Mesa-dev] [PATCH 05/21] mesa: Resolve GCC sign-compare warning.

2015-08-03 Thread Brian Paul
On 08/03/2015 12:09 AM, Rhys Kidd wrote: mesa/src/mesa/drivers/dri/common/utils.c: In function 'driGetConfigAttrib': mesa/src/mesa/drivers/dri/common/utils.c:457:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(attribMap);

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Daniel Scharrer
Hi, thanks for looking at this. On 2015-08-03 16:18, Brian Paul wrote: > On 08/03/2015 06:01 AM, Daniel Scharrer wrote: >> Ping. >> >> Can someone please review and/or commit this. >> >> I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch be >> Cc'd to that? > > Probably. > >

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Brian Paul
On 08/03/2015 06:01 AM, Daniel Scharrer wrote: Ping. Can someone please review and/or commit this. I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch be Cc'd to that? Probably. -- Daniel On 2015-07-25 08:12, Daniel Scharrer wrote: --- ARB_dsa / GL 4.5 add indexed GL_

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Brian Paul
Series looks good to me. Reviewed-by: Brian Paul On 08/03/2015 06:42 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/g

Re: [Mesa-dev] [PATCH] r600, compute: force tiling on 2D and 3D texture compute resources

2015-08-03 Thread Zoltán Gilián
Committed as 44e90f2. On Fri, Jul 31, 2015 at 12:11 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Fri, Jul 31, 2015 at 11:59 AM, Zoltan Gilian > wrote: >> To circumvent a problem occuring when LINEAR_ALIGNED array mode is >> selected on a TEXTURE_2D RAT. >> This configurat

Re: [Mesa-dev] [PATCH 1/2] glsl: add variable mode check to build_stageref

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote: > Currently stage reference mask is built using the variable name > only. However it can happen that input of one stage has same name > as output from another stage. Adding check of variable mode makes > sure we do not pick wrong variable. > >

Re: [Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Samuel Pitoiset
Patches 1-6 are: Reviewed-by: Samuel Pitoiset But please, fix the commit message for patches 1 and 3 (ie. gallium/hud instead of gallium, hud). Btw, it would be good to display floating point numbers when percentage is used. What do you think ? On 08/03/2015 02:42 PM, Marek Olšák wrote:

[Mesa-dev] [PATCH] radeonsi: before storing tess levels, load them from LDS instead of temporary

2015-08-03 Thread Marek Olšák
From: Marek Olšák Also use only one store if stride <= 4. All the fetches from and stores to temporaries can be removed now. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91461 --- src/gallium/drivers/radeonsi/si_shader.c | 136 +-- 1 file changed, 57 insert

[Mesa-dev] [PATCH] winsys/radeon: loosen up the requirements for how much memory IBs can use

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c index 45eef29..7e5fff4 100644 --- a/src/gallium/win

[Mesa-dev] [PATCH 07/11] gallium/radeon: change some driver query types to Hz

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index b12992d..e143132 100644 --- a/src/gallium/drivers/radeo

[Mesa-dev] [PATCH 08/11] gallium/radeon: switch the buffer-wait-time query to microseconds

2015-08-03 Thread Marek Olšák
From: Marek Olšák This display the units in the HUD. --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- src/gallium/drivers/radeon/r600_query.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drive

[Mesa-dev] [PATCH 03/11] gallium, hud: allow displaying cumulative values instead of average

2015-08-03 Thread Marek Olšák
From: Marek Olšák The cumulative value is useful for queries like the number of shader compilations. --- src/gallium/auxiliary/hud/hud_context.c | 9 ++--- src/gallium/auxiliary/hud/hud_driver_query.c | 22 ++ src/gallium/auxiliary/hud/hud_private.h | 3 ++- s

[Mesa-dev] [PATCH 01/11] gallium, hud: add support for Hz units in driver queries

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 6 ++ src/gallium/include/pipe/p_defines.h| 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 4631cd3..e10152e 100644 --- a/src/gall

[Mesa-dev] [PATCH 05/11] gallium/hud: fix printing % next to panes

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index d3ad271..275070d 100644 --- a/src/gallium/auxiliary/hud/hud_context.c +++ b/s

[Mesa-dev] [PATCH 02/11] gallium/hud: fix printing byte units

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index e10152e..e0ca29d 100644 --- a/src/gallium/auxiliary/hud/hud_context.c +++ b/s

[Mesa-dev] [PATCH 04/11] gallium/hud: replace assertions with clamping the unit index

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 42 ++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index decc055..d3ad271 100644 --- a/src/gallium

[Mesa-dev] [PATCH 10/11] radeonsi: add a HUD query showing the number of compiler invocations

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 +++- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ src/gallium/drivers/radeon/r600_query.c | 9 + src/gallium/drivers/radeonsi/si_state_shaders.c | 1 + 4 files changed, 19 insertions(+), 1 d

[Mesa-dev] [PATCH 06/11] gallium/hud: automatically print % if max_value == 100

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 275070d..95eed26 100644 --- a/src/gallium/auxiliary/hud/hu

[Mesa-dev] [PATCH 00/11] RadeonSI and Gallium HUD improvements

2015-08-03 Thread Marek Olšák
This improves the HUD for RadeonSI. Hopefully, an introductory message like this makes it easier for Michel not to miss this. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 11/11] radeonsi: add a HUD query showing the number of shaders created

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 ++ src/gallium/drivers/radeon/r600_pipe_common.h | 5 + src/gallium/drivers/radeon/r600_query.c | 9 + src/gallium/drivers/radeonsi/si_state_shaders.c | 1 + 4 files changed, 17 insertions(+) diff -

[Mesa-dev] [PATCH 09/11] gallium/radeon: display cumulative results for some driver queries

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 116e1f7..8f95444 100644 --- a/src/gallium/drivers/rad

[Mesa-dev] [PATCH] gallium/radeon: add a debug flag not to use write combining

2015-08-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 6 -- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_co

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-03 Thread Emil Velikov
On 3 August 2015 at 13:17, Marek Olšák wrote: > On Mon, Aug 3, 2015 at 1:33 PM, Emil Velikov wrote: >> On 1 August 2015 at 19:18, Marek Olšák wrote: >>> On Sat, Aug 1, 2015 at 7:29 PM, Emil Velikov >>> wrote: On 1 August 2015 at 17:57, Marek Olšák wrote: > No, we don't need this. rad

Re: [Mesa-dev] [PATCH 3/3] egl/x11: don't abort when creating a DRI2 drawable fails

2015-08-03 Thread Emil Velikov
On 31 July 2015 at 11:02, Frank Binns wrote: > When calling either eglCreateWindowSurface or eglCreatePixmapSurface it > was possible for an application to be aborted as a result of it failing > to create a DRI2 drawable on the server. This could happen due to an > application passing in an invali

Re: [Mesa-dev] [PATCH 2/3] egl/x11: set EGL_BAD_NATIVE_(PIXMAP|WINDOW) for invalid pixmaps/windows

2015-08-03 Thread Emil Velikov
On 31 July 2015 at 11:02, Frank Binns wrote: > Both eglCreatePixmapSurface and eglCreateWindowSurface were incorrectly > setting the EGL error to be EGL_BAD_ALLOC when an invalid native drawable > handle was being passed in. The EGL spec states the following for > eglCreatePixmapSurface: > >

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-03 Thread Marek Olšák
On Mon, Aug 3, 2015 at 1:33 PM, Emil Velikov wrote: > On 1 August 2015 at 19:18, Marek Olšák wrote: >> On Sat, Aug 1, 2015 at 7:29 PM, Emil Velikov >> wrote: >>> On 1 August 2015 at 17:57, Marek Olšák wrote: No, we don't need this. radeonsi doesn't return a NULL fence anymore. >>> Gl

Re: [Mesa-dev] [PATCH 2/3] r600g: fix the CB_SHADER_MASK setup

2015-08-03 Thread Marek Olšák
On Mon, Aug 3, 2015 at 1:28 PM, Emil Velikov wrote: > On 2 August 2015 at 14:36, Marek Olšák wrote: >> From: Marek Olšák >> >> This fixes the single-sample fast clear hang. >> >> Cc: 10.6 >> --- >> src/gallium/drivers/r600/evergreen_state.c | 8 >> src/gallium/drivers/r600/r600_shader

Re: [Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

2015-08-03 Thread Emil Velikov
On 31 July 2015 at 13:34, Frank Binns wrote: > On 31/07/15 12:53, Emil Velikov wrote: >> On 31 July 2015 at 11:02, Frank Binns wrote: >>> Commit 4ed23fd590 introduced some calls to _eglError inappropriately >>> passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the >>> cases a

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Daniel Scharrer
Ping. Can someone please review and/or commit this. I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch be Cc'd to that? -- Daniel On 2015-07-25 08:12, Daniel Scharrer wrote: > --- > > ARB_dsa / GL 4.5 add indexed GL_TEXTURE_BINDING_* and GL_SAMPLER_BINDING > queries, as wel

Re: [Mesa-dev] [PATCH] clover: handle setKernelArg errors

2015-08-03 Thread Zoltán Gilián
Committed as be3622d. On Fri, Jul 31, 2015 at 4:09 PM, Francisco Jerez wrote: > Zoltán Gilián writes: > >> Could you please commit this? I don't have permissions. >> > Sure, I'll put them into my queue. > >> On Fri, Jul 31, 2015 at 3:55 PM, Francisco Jerez >> wrote: >>> Zoltan Gilian writes:

Re: [Mesa-dev] [PATCH] clover: fix image resource depth and array_size

2015-08-03 Thread Zoltán Gilián
Fixed it. Committed as aa46fba. On Mon, Aug 3, 2015 at 1:36 PM, Zoltán Gilián wrote: >> Any reason you didn't fix this other branch to do the same? Or maybe >> just init it to one after the if? > > I've only observed problems with images if that line is missing (the > surface is rejected because

Re: [Mesa-dev] [PATCH] mesa: fix name returned for XFB varyings

2015-08-03 Thread Martin Peres
On 03/08/15 14:35, Tapani Pälli wrote: On 08/03/2015 01:57 PM, Martin Peres wrote: On 03/08/15 13:50, Tapani Pälli wrote: On 08/03/2015 01:48 PM, Martin Peres wrote: On 03/08/15 11:10, Tapani Pälli wrote: _mesa_get_program_resource_name has logic to append '[0]' in name if variable is a

Re: [Mesa-dev] [PATCH 2/2] clover: pass image attributes to the kernel

2015-08-03 Thread Zoltán Gilián
Committed as 9ef5b7a. On Fri, Jul 31, 2015 at 4:07 PM, Zoltán Gilián wrote: > Could you please commit this? > > On Mon, Jul 27, 2015 at 1:28 PM, Francisco Jerez > wrote: >> Zoltan Gilian writes: >> >>> Read-only and write-only image arguments are recognized and >>> distinguished. >>> Attribute

Re: [Mesa-dev] [PATCH 1/2] clover: move find_kernels to functions

2015-08-03 Thread Zoltán Gilián
Meanwhile I've obtained commit permission, so committed as d2cd2c6. On Fri, Jul 31, 2015 at 4:06 PM, Zoltán Gilián wrote: > Could you please commit this? > > On Mon, Jul 27, 2015 at 1:20 PM, Francisco Jerez > wrote: >> Zoltan Gilian writes: >> >>> --- >>> .../state_trackers/clover/llvm/invoca

Re: [Mesa-dev] [PATCH] clover: fix image resource depth and array_size

2015-08-03 Thread Zoltán Gilián
> Any reason you didn't fix this other branch to do the same? Or maybe > just init it to one after the if? I've only observed problems with images if that line is missing (the surface is rejected because of 0 buffer size), but it makes sense to set the array_size outside the if. On Mon, Aug 3,

Re: [Mesa-dev] [PATCH] mesa: fix name returned for XFB varyings

2015-08-03 Thread Tapani Pälli
On 08/03/2015 01:57 PM, Martin Peres wrote: On 03/08/15 13:50, Tapani Pälli wrote: On 08/03/2015 01:48 PM, Martin Peres wrote: On 03/08/15 11:10, Tapani Pälli wrote: _mesa_get_program_resource_name has logic to append '[0]' in name if variable is an array, this should be skipped for XFB va

Re: [Mesa-dev] [Mesa-stable] [PATCH] clover: Fix bug with computing hard_event status

2015-08-03 Thread Emil Velikov
On 1 August 2015 at 19:18, Marek Olšák wrote: > On Sat, Aug 1, 2015 at 7:29 PM, Emil Velikov wrote: >> On 1 August 2015 at 17:57, Marek Olšák wrote: >>> No, we don't need this. radeonsi doesn't return a NULL fence anymore. >>> >> Glad to hear. On the other hand is that fix in stable ? I believe

  1   2   >