Re: [Mesa-dev] [PATCH v4 (part2) 14/59] nir: add shader storage buffer's unsized array length calculation

On Wed, 2015-08-05 at 11:59 -0700, Connor Abbott wrote: > On Wed, Aug 5, 2015 at 1:30 AM, Iago Toral Quiroga wrote: > > From: Samuel Iglesias Gonsalvez > > > > Signed-off-by: Samuel Iglesias Gonsalvez > > --- > > src/glsl/nir/glsl_to_nir.cpp | 10 ++ > > src/glsl/nir/nir_intrinsics.h |

Re: [Mesa-dev] [PATCH v4 (part2) 44/59] mesa: Add queries for GL_SHADER_STORAGE_BUFFER

On Wed, 2015-08-05 at 12:23 -0400, Ilia Mirkin wrote: > On Wed, Aug 5, 2015 at 4:30 AM, Iago Toral Quiroga wrote: > > These handle querying the buffer name attached to a giving binding point > > as well as the start offset and size of that buffer. > > --- > > src/mesa/main/get.c | 31

[Mesa-dev] [PATCH v2 06/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_validate_framebuffer': mesa/src/mesa/drivers/dri/i965/intel_fbo.c:734:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(fb->Attachment); i++) { ^

[Mesa-dev] [PATCH v2 14/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_primitive_restart.c: In function 'can_cut_index_handle_prims': mesa/src/mesa/drivers/dri/i965/brw_primitive_restart.c:94:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < nr_prims; i++) {

[Mesa-dev] [PATCH v2 18/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c: In function 'brw_upload_abo_surfaces': mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c:961:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < prog->NumAtomicBuffers; i++) {

[Mesa-dev] [PATCH v2 04/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/intel_screen.c: In function 'aub_dump_bmp': mesa/src/mesa/drivers/dri/i965/intel_screen.c:125:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < fb->_NumColorDrawBuffers; i++) { ^ Si

[Mesa-dev] [PATCH v2 21/21] i965/gen7: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c: In function 'gen7_upload_3dstate_so_decl_list': mesa/src/mesa/drivers/dri/i965/gen7_sol_state.c:119:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < linked_xfb_info->NumOutputs; i++) {

[Mesa-dev] [PATCH v2 12/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_draw_destroy': mesa/src/mesa/drivers/dri/i965/brw_draw.c:630:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < brw->vb.nr_buffers; i++) { ^ mesa/src/mesa/drivers

[Mesa-dev] [PATCH v2 11/21] mesa/egl: Resolve GCC sign-compare warning.

mesa/src/egl/drivers/dri2/platform_drm.c: In function 'release_buffer': mesa/src/egl/drivers/dri2/platform_drm.c:73:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(dri2_surf->color_buffers); i++) { ^ mesa/src

[Mesa-dev] [PATCH v2 07/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/intel_screen.c: In function 'intel_screen_make_configs': mesa/src/mesa/drivers/dri/i965/intel_screen.c:1222:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < ARRAY_SIZE(formats); i++) {

[Mesa-dev] [PATCH v2 17/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c: In function 'brw_upload_ubo_surfaces': mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c:901:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < shader->NumUniformBlocks; i++) {

[Mesa-dev] [PATCH v2 19/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c: In function 'brw_upload_pull_constants': mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c:84:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prog_data->nr_pull_params; i++) {

[Mesa-dev] [PATCH v2 20/21] i965/gen6: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c: In function 'gen6_upload_push_constants': mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:85:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prog_data->nr_params; i++) {

[Mesa-dev] [PATCH v2 13/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c: In function 'brw_prepare_vertices': mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c:434:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = j = 0; i < brw->vb.nr_enabled; i++) {

[Mesa-dev] [PATCH v2 05/21] mesa: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/common/utils.c: In function 'driGetConfigAttrib': mesa/src/mesa/drivers/dri/common/utils.c:457:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(attribMap); i++) ^ Signed-off-by: Rh

[Mesa-dev] [PATCH v2 08/21] mesa/glx: Resolve GCC sign-compare warning.

mesa/src/glx/dri_common.c: In function 'scalarEqual': mesa/src/glx/dri_common.c:259:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(attribMap); i++) ^ Signed-off-by: Rhys Kidd --- src/glx/dri_common.c | 3

Re: [Mesa-dev] [PATCH v4 (part2) 45/59] glsl: fix UNIFORM_BUFFER_START or UNIFORM_BUFFER_SIZE query when no buffer object is bound

On Thu, 2015-08-06 at 08:53 +0300, Tapani Pälli wrote: > Reviewed-by: Tapani Pälli > > On 08/05/2015 11:30 AM, Iago Toral Quiroga wrote: > > From: Samuel Iglesias Gonsalvez > > > > According to ARB_uniform_buffer_object spec: > > > > "If the parameter (starting offset or size) was not specified

[Mesa-dev] [PATCH v2 10/21] mesa/gbm: Resolve GCC sign-compare warning.

mesa/src/gbm/main/backend.c: In function 'find_backend': mesa/src/gbm/main/backend.c:70:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(backends); ++i) { ^ mesa/src/gbm/main/backend.c: In function '_gbm_creat

[Mesa-dev] [PATCH v2 16/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_tex_layout.c: In function 'brw_miptree_layout_texture_array': mesa/src/mesa/drivers/dri/i965/brw_tex_layout.c:560:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int q = 0; q < mt->level[level].depth; q++) {

[Mesa-dev] [PATCH v2 09/21] mesa/glx: Resolve GCC sign-compare warning.

mesa/src/glx/dri_common_query_renderer.c: In function 'dri2_convert_glx_query_renderer_attribs': mesa/src/glx/dri_common_query_renderer.c:61:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(query_renderer_map); i++)

[Mesa-dev] [PATCH v2 15/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_state_cache.c: In function 'brw_try_upload_using_copy': mesa/src/mesa/drivers/dri/i965/brw_state_cache.c:216:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < cache->size; i++) { ^ Sig

[Mesa-dev] [PATCH v2 01/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_postdraw_set_buffers_need_resolve': mesa/src/mesa/drivers/dri/i965/brw_draw.c:390:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < fb->_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH v2 03/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_blit_framebuffer_with_blitter': mesa/src/mesa/drivers/dri/i965/intel_fbo.c:836:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < drawFb->_NumColorDrawBuffers; i++) {

[Mesa-dev] [PATCH v2 00/21] Resolve GCC sign-compare warnings patchset

GCC warns on -Wsign-compare in a number of locations within i965. This patchset goes a significant way to addressing these compiler warnings. Changes have been made with preference to remain consistent with immediate context of that file, rather than the whole patchset adopting one approach. No p

[Mesa-dev] [PATCH v2 02/21] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_wm_state.c: In function 'brw_color_buffer_write_enabled': mesa/src/mesa/drivers/dri/i965/brw_wm_state.c:53:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->DrawBuffer->_NumColorDrawBuffers; i++) {

Re: [Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

Hello Ian, The other "i" is used within a for() loop below in that function. On review, I am inclined to resolve the underlying issue being shadowing a name within a broader scope, by changing the variable name of the GLuint. Either way, there were no piglit regressions on ILK. Will push as part

Re: [Mesa-dev] [PATCH v4 (part2) 45/59] glsl: fix UNIFORM_BUFFER_START or UNIFORM_BUFFER_SIZE query when no buffer object is bound

Reviewed-by: Tapani Pälli On 08/05/2015 11:30 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez According to ARB_uniform_buffer_object spec: "If the parameter (starting offset or size) was not specified when the buffer object was bound (e.g. if bound with BindBufferBase), or if

[Mesa-dev] [PATCH v3] clover: stub missing CL 1.2 functions

As sugested by Tom a long time ago and in order to be able to create Piglit tests v2: replace NOT_SUPPORTED_BY_CL_1_1 macro with an inline function remove extra space in clLinkProgram arg v3: use __func__ --- src/gallium/state_trackers/clover/api/dispatch.cpp | 10 - src/gallium/state_t

Re: [Mesa-dev] [PATCH v4 (part2) 55/59] mesa: enable ARB_shader_storage_buffer_object extension for GLES 3.1

Reviewed-by: Tapani Pälli On 08/05/2015 11:30 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --

Re: [Mesa-dev] [PATCH v4 (part2) 54/59] mesa: Add getters for the GL_ARB_shader_storage_buffer_object max constants

Reviewed-by: Tapani Pälli On 08/05/2015 11:30 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez v2: - Add tessellation shader constants support v3: - Add GLES 3.1 support. Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/get.c | 7 +++ src/mesa/ma

Re: [Mesa-dev] [PATCH 2/2] tgsi_to_nir: Convert to using VARYING_SLOT_* / FRAG_RESULT_*.

Rob Clark writes: > On Tue, Aug 4, 2015 at 5:28 PM, Eric Anholt wrote: >> This avoids exceeding the size of the .index bitfield since it got >> truncated, and should make our NIR look more like the NIR that the rest of >> the NIR developers are working on. >> --- >> The freedreno changes here ar

Re: [Mesa-dev] [PATCH] glsl: Initialize patch member of glsl_struct_field

On 06.08.2015 00:32, Ian Romanick wrote: > On 08/05/2015 02:20 AM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Fixes a bunch of random (mostly tessellation related) piglit failures >> since commit 7ac946e5 ("glsl: Add constuctors for the common cases of >> glsl_struct_field"). > > I was goi

Re: [Mesa-dev] [PATCH] glx: Fix __glXWireToEvent for BufferSwapComplete

Adam Jackson writes: > On Tue, 2015-08-04 at 19:38 -0700, Eric Anholt wrote: > >> In the Pbuffer path, we get serial from awire. Why's this one >> different? > > Because I copied it from the dri2 path not the pbuffer path. This idiom > is more correct, _XSetLastRequestRead is how you notify xlib

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

On Wed, 2015-08-05 at 12:47 +0200, Zoltán Gilián wrote: > > thanks, this fixes the build for me. > > Should I commit this marking you as reviewer? sorry, I can't do a proper review or test. I won't have access to my dev box until december, and the machine that hit the failure only builds the stat

[Mesa-dev] [PATCH] i965: Request a miptree with no tiling intel_miptree_map_blit().

Regression since commit 3a31876600, when tiling modes were moved into layout_flags. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c i

Re: [Mesa-dev] [PATCH] i965: Correct a mistake that always forced texture tiling.

On Wed, Aug 5, 2015 at 5:12 PM, Ben Widawsky wrote: > On Wed, Aug 05, 2015 at 12:08:31PM -0700, Matt Turner wrote: >> Regression since commit 3a31876600, when tiling modes were moved into >> layout_flags. >> >> The relevant enum values are >> >>MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5 >>MIPTRE

Re: [Mesa-dev] [PATCH] i965: Correct a mistake that always forced texture tiling.

On Wed, Aug 05, 2015 at 12:08:31PM -0700, Matt Turner wrote: > Regression since commit 3a31876600, when tiling modes were moved into > layout_flags. > > The relevant enum values are > >MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5 >MIPTREE_LAYOUT_ALLOC_XTILED = 1 << 6 >MIPTREE_LAYOUT_ALLOC_ANY

Re: [Mesa-dev] [PATCH 20/21] nir/cf: add new control modification API's

On Tuesday, July 21, 2015 07:54:34 PM Connor Abbott wrote: > These will help us do a number of things, including: > > - Early return elimination. > - Dead control flow elimination. > - Various optimizations, such as replacing: > > if (foo) { > ... > } > if (!foo) { > ... > } > > with: >

Re: [Mesa-dev] fixing GLSL NEW_IDENTIFIER error messages

Not sure how much help this is, but (gdb) p yyvsa[5] $20 = {n = 7289280, real = 1.02144569e-38, dreal = 3.6013828309176816e-317, identifier = 0x6f39c0 "sampler2DMS", type_qualifier = { But how do you figure out that it's at 5? Don't know. yyval appears to be yyvsa[4], so maybe *(&yyval+1)? Nope..

Re: [Mesa-dev] [PATCH 00/21] NIR control flow modification

On Tuesday, July 21, 2015 07:54:14 PM Connor Abbott wrote: > Connor Abbott (21): > nir/validate: check successors/predecessors more carefully > nir: inline block_add_pred() a few places > nir: make cleanup_cf_node() not use remove_defs_uses() > nir: move control flow modification to its own

[Mesa-dev] fixing GLSL NEW_IDENTIFIER error messages

If a shader contains a declaration such as: uniform sampler2DMS tex; but it doesn't specify "#extension GL_ARB_texture_multisample: enable" we get a GLSL error saying something like "0:2(21): error: syntax error, unexpected NEW_IDENTIFIER, expecting '{'" There are other cases where the erro

Re: [Mesa-dev] [PATCH 1/4] glsl/cs: Add gl_WorkGroupID variable

On 2015-08-05 09:02:47, Ian Romanick wrote: > On 08/04/2015 11:24 AM, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/glsl/builtin_variables.cpp | 2 ++ > > src/glsl/shader_enums.h| 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/src/glsl/builtin_vari

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Lower arithmetic instructions with register regions of unsupported width.

You can have my R-B on both patches too. On Wed, Aug 5, 2015 at 11:14 AM, Connor Abbott wrote: > FWIW, both patches are: > > Reviewed-by: Connor Abbott > > I'm working on FP64 support (I've been using no16 up till now) so this > is obviously very useful to me. > > On Wed, Aug 5, 2015 at 10:38 AM

[Mesa-dev] [PATCH v2] clover: stub missing CL 1.2 functions

As sugested by Tom a long time ago and in order to be able to create Piglit tests v2: replace NOT_SUPPORTED_BY_CL_1_1 macro with an inline function remove extra space in clLinkProgram arg --- src/gallium/state_trackers/clover/api/dispatch.cpp | 10 - src/gallium/state_trackers/clover/api

Re: [Mesa-dev] [PATCH v4 (part2) 39/59] nir: Implement lowered SSBO atomic intrinsics

On Wed, Aug 5, 2015 at 1:30 AM, Iago Toral Quiroga wrote: > The original GLSL IR intrinsics have been lowered to an internal > version that accepts a block index and an offset instead of a > SSBO reference. > --- > src/glsl/nir/glsl_to_nir.cpp | 55 > +++

Re: [Mesa-dev] [PATCH v4 (part2) 34/59] nir: ignore an instruction's dest if it hasn't any

Change the prefix to "nir/glsl_to_nir" and this is Reviewed-by: Connor Abbott On Wed, Aug 5, 2015 at 1:30 AM, Iago Toral Quiroga wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/gl

Re: [Mesa-dev] [PATCH v4 (part2) 32/59] nir: Implement __intrinsic_store_load

Title should say "__intrinsic_load_ssbo". On Wed, Aug 5, 2015 at 1:30 AM, Iago Toral Quiroga wrote: > --- > src/glsl/nir/glsl_to_nir.cpp| 67 > - > src/glsl/nir/nir_intrinsics.h | 2 +- > src/glsl/nir/nir_lower_phis_to_scalar.c | 2 + > 3

Re: [Mesa-dev] [PATCH v4 (part2) 29/59] nir: Implement __intrinsic_store_ssbo

On Wed, Aug 5, 2015 at 1:30 AM, Iago Toral Quiroga wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 36 > src/glsl/nir/nir_intrinsics.h | 12 ++-- > 2 files changed, 42 insertions(+), 6 deletions(-) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/gls

[Mesa-dev] [PATCH] i965: Correct a mistake that always forced texture tiling.

Regression since commit 3a31876600, when tiling modes were moved into layout_flags. The relevant enum values are MIPTREE_LAYOUT_ALLOC_YTILED = 1 << 5 MIPTREE_LAYOUT_ALLOC_XTILED = 1 << 6 MIPTREE_LAYOUT_ALLOC_ANY_TILED = MIPTREE_LAYOUT_ALLOC_YTILED | MI

Re: [Mesa-dev] [PATCH 1/2] i965: Correct a mistake that always forced texture tiling.

On Wed, Aug 5, 2015 at 8:44 AM, Ben Widawsky wrote: > On Tue, Aug 04, 2015 at 11:16:55PM -0700, Matt Turner wrote: >> On Tue, Aug 4, 2015 at 11:18 PM, Matt Turner wrote: >> > Regression since commit 3a31876600, when tiling modes were moved into >> > layout_flags. >> > > It be interesting to find

Re: [Mesa-dev] [PATCH v4 (part2) 14/59] nir: add shader storage buffer's unsized array length calculation

On Wed, Aug 5, 2015 at 1:30 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/nir/glsl_to_nir.cpp | 10 ++ > src/glsl/nir/nir_intrinsics.h | 9 + > 2 files changed, 19 insertions(+) > > diff --git a/sr

Re: [Mesa-dev] ssbo, vec4, nir - Re: [PATCH v3 (part2) 00/56] ARB_shader_storage_buffer_object (mesa, i965)

On Wed, Aug 5, 2015 at 11:36 AM, Jason Ekstrand wrote: > On Tue, Aug 4, 2015 at 5:54 PM, Jason Ekstrand wrote: >> On Tue, Aug 4, 2015 at 5:09 PM, Jordan Justen >> wrote: >>> I checked the extension spec, and it appears that like image >>> load/store, ssbo is only required in fragment and comput

Re: [Mesa-dev] [PATCH 3/5] i965/fs: Indent the implementation of 32x32-bit MUL lowering by one level.

Matt Turner writes: > On Wed, Aug 5, 2015 at 10:52 AM, Francisco Jerez > wrote: >> In order to make room for the code that will lower the MULH virtual >> instruction. Also move the hardware generation and execution type >> checks into the same branch, they are going to have to be different >>

Re: [Mesa-dev] [PATCH 3/5] i965/fs: Indent the implementation of 32x32-bit MUL lowering by one level.

On Wed, Aug 5, 2015 at 10:52 AM, Francisco Jerez wrote: > In order to make room for the code that will lower the MULH virtual > instruction. Also move the hardware generation and execution type > checks into the same branch, they are going to have to be different > for MULH. > --- > src/mesa/dri

Re: [Mesa-dev] ssbo, vec4, nir - Re: [PATCH v3 (part2) 00/56] ARB_shader_storage_buffer_object (mesa, i965)

On Tue, Aug 4, 2015 at 5:54 PM, Jason Ekstrand wrote: > On Tue, Aug 4, 2015 at 5:09 PM, Jordan Justen > wrote: >> I checked the extension spec, and it appears that like image >> load/store, ssbo is only required in fragment and compute stages. I >> don't think the ssbo support in vec4 is quite a

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Lower arithmetic instructions with register regions of unsupported width.

FWIW, both patches are: Reviewed-by: Connor Abbott I'm working on FP64 support (I've been using no16 up till now) so this is obviously very useful to me. On Wed, Aug 5, 2015 at 10:38 AM, Francisco Jerez wrote: > This extends the SIMD lowering pass to enforce the hardware limitation > that no d

Re: [Mesa-dev] [PATCH 1/5] i965: Define virtual instruction to calculate the high 32 bits of a multiply.

On Wed, Aug 5, 2015 at 2:03 PM, Ilia Mirkin wrote: > On Wed, Aug 5, 2015 at 1:52 PM, Francisco Jerez wrote: >> This instruction will translate to the MUL/MACH sequence that computes >> the high 32-bits of the result of a 64-bit multiply. Before Gen8 > > Unlike with 32x32 -> low 32, you need to s

Re: [Mesa-dev] [PATCH 1/5] i965: Define virtual instruction to calculate the high 32 bits of a multiply.

On Wed, Aug 5, 2015 at 1:52 PM, Francisco Jerez wrote: > This instruction will translate to the MUL/MACH sequence that computes > the high 32-bits of the result of a 64-bit multiply. Before Gen8 Unlike with 32x32 -> low 32, you need to specify if it's a signed or unsigned multiply. s32 x s32 ->

[Mesa-dev] [PATCH 2/5] i965/fs: Lower 32x32 bit multiplication on BXT.

AFAIK BXT has the same annoying alignment limitation as CHV on the source register regions of 32x32 bit MULs, give it the same treatment. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mes

[Mesa-dev] [PATCH 1/5] i965: Define virtual instruction to calculate the high 32 bits of a multiply.

This instruction will translate to the MUL/MACH sequence that computes the high 32-bits of the result of a 64-bit multiply. Before Gen8 integer operations that used the accumulator were limited to 8-wide, but the SIMD lowering pass can easily be hooked up to sidestep this limitation, we just need

[Mesa-dev] [PATCH 3/5] i965/fs: Indent the implementation of 32x32-bit MUL lowering by one level.

In order to make room for the code that will lower the MULH virtual instruction. Also move the hardware generation and execution type checks into the same branch, they are going to have to be different for MULH. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 265 ++- 1

[Mesa-dev] [PATCH 4/5] i965/fs: Lower the MULH virtual instruction.

Translate MULH into the MUL/MACH sequence. This does roughly the same thing that nir_emit_alu() used to do but we can now handle 16-wide by taking advantage of the SIMD lowering pass. The force_sechalf workaround near the bottom is required because the SIMD lowering pass will emit instructions wi

[Mesa-dev] [PATCH 5/5] i965/fs: Implement nir_op_imul/umul_high in terms of MULH.

And get rid of another no16() call. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 33 ++-- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index e922a85..ee964a0 100644

[Mesa-dev] [PATCH 1/2] i965/fs: Fix fs_inst::regs_read() for sources in the ATTR file.

Otherwise it would crash on Gen8 with scalar VS. The issue can easily be reproduced with the following patch, but I don't see any reason why it shouldn't be possible to end up with an ATTR argument here even without it. CC: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_fs.c

[Mesa-dev] [PATCH 2/2] i965/fs: Lower arithmetic instructions with register regions of unsupported width.

This extends the SIMD lowering pass to enforce the hardware limitation that no directly-addressed source may read more than 2 physical GRFs. One can easily go over this limit when doing 64-bit arithmetic (e.g. FP64 or extended-precision integer MULs) or SIMD32, so it's nice to be able to just emit

Re: [Mesa-dev] [PATCH] i965: Fix HW binding tables editing

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 54805] gl_ClipVertex support horribly broken with software TNL

https://bugs.freedesktop.org/show_bug.cgi?id=54805 Matt Turner changed: What|Removed |Added CC|matts...@gmail.com | QA Contact|

Re: [Mesa-dev] [PATCH v4 (part2) 44/59] mesa: Add queries for GL_SHADER_STORAGE_BUFFER

On Wed, Aug 5, 2015 at 4:30 AM, Iago Toral Quiroga wrote: > These handle querying the buffer name attached to a giving binding point > as well as the start offset and size of that buffer. > --- > src/mesa/main/get.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff

Re: [Mesa-dev] [PATCH 20/21] i965: Resolve GCC sign-compare warning.

On 08/02/2015 11:09 PM, Rhys Kidd wrote: > mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c: In function > 'gen6_upload_push_constants': > mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:85:21: warning: comparison > between signed and unsigned integer expressions [-Wsign-compare] >for (i = 0

Re: [Mesa-dev] [PATCH 19/21] i965: Resolve GCC sign-compare warning.

On 08/02/2015 11:09 PM, Rhys Kidd wrote: > mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c: In function > 'brw_upload_pull_constants': > mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c:84:18: warning: > comparison between signed and unsigned integer expressions [-Wsign-compare] >

Re: [Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

On 08/02/2015 11:09 PM, Rhys Kidd wrote: > mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c: In function > 'brw_prepare_vertices': > mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c:434:22: warning: comparison > between signed and unsigned integer expressions [-Wsign-compare] > for (i = j = 0

Re: [Mesa-dev] [PATCH 1/4] glsl/cs: Add gl_WorkGroupID variable

On 08/04/2015 11:24 AM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/builtin_variables.cpp | 2 ++ > src/glsl/shader_enums.h| 1 + > 2 files changed, 3 insertions(+) > > diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp > index b2936a5..

Re: [Mesa-dev] [PATCH 1/2] i965: Correct a mistake that always forced texture tiling.

On Tue, Aug 04, 2015 at 11:16:55PM -0700, Matt Turner wrote: > On Tue, Aug 4, 2015 at 11:18 PM, Matt Turner wrote: > > Regression since commit 3a31876600, when tiling modes were moved into > > layout_flags. > > It be interesting to find out why this caused the perf regression. > > The relevant en

Re: [Mesa-dev] [PATCH 2/2] i965: Make MIPTREE_LAYOUT_ALLOC_ANY_TILED an enum value.

On Tue, Aug 04, 2015 at 11:18:17PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h > b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h > index

Re: [Mesa-dev] [PATCH] glsl: Initialize patch member of glsl_struct_field

On 08/05/2015 02:20 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes a bunch of random (mostly tessellation related) piglit failures > since commit 7ac946e5 ("glsl: Add constuctors for the common cases of > glsl_struct_field"). I was going to look at this yesterday, but I didn't get to i

Re: [Mesa-dev] [PATCH] glsl: Allow token pasting in ESSL

On 08/04/2015 11:39 AM, Ian Romanick wrote: > On 07/22/2015 07:52 PM, Ryan Houdek wrote: >> All vendors I've tested allow token pasting in their ESSL shaders. >> At least one application expects this to be supported >> even though it is against spec. > > I'm not very excited about deviating from t

[Mesa-dev] [Bug 54805] gl_ClipVertex support horribly broken with software TNL

https://bugs.freedesktop.org/show_bug.cgi?id=54805 marius predut changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |marius.pre...@intel.com

[Mesa-dev] [Bug 28130] vbo: premature flushing breaks GL_LINE_LOOP

https://bugs.freedesktop.org/show_bug.cgi?id=28130 marius predut changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |marius.pre...@intel.com

[Mesa-dev] [Bug 20043] tnl/t_draw.c:203: bind_inputs: Assertion `inputs[i]->BufferObj->Pointer' failed.

https://bugs.freedesktop.org/show_bug.cgi?id=20043 marius predut changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |marius.pre...@intel.com

Re: [Mesa-dev] [PATCH] glx: Fix __glXWireToEvent for BufferSwapComplete

On Tue, 2015-08-04 at 19:38 -0700, Eric Anholt wrote: > In the Pbuffer path, we get serial from awire. Why's this one > different? Because I copied it from the dri2 path not the pbuffer path. This idiom is more correct, _XSetLastRequestRead is how you notify xlib of the advance in serials so it

[Mesa-dev] [PATCH] glsl: remove stage ref generation for transform feedback

Stage ref cannot be queried for transform feedback. Also simplify the build_stageref function by passing the correct mode for uniforms. Cc: Tapani Pälli --- No piglit regressions, no program_interface_query CTS regressions. src/glsl/linker.cpp | 10 -- 1 file changed, 4 insertions(+),

[Mesa-dev] [PATCH] i965: Fix HW binding tables editing

Since the introduction of new gl_shader_stages in commit a2af956963b6bc4d29f37485e44c98008d2ef077 Author: Fabian Bieler Date: Fri Mar 7 10:19:09 2014 +0100 mesa: add tessellation shader enums the translation table for the stage into the HW binding table edit command was broken, and so we

[Mesa-dev] [PATCH 2/2] mesa: _mesa_format_convert should be endian agnostic

Hi Oded, Is the r600g driver ready for the Gallium3D infrastructure of big endian hosts or did you only solve the wrong colors problem? Cheers, Christian On 04 August 2015 at 6:57 PM, Oded Gabbay wrote: On Mon, Aug 3, 2015 at 6:40 PM, Emil Velikov > wrote:

Re: [Mesa-dev] V3 ARB_arrays_of_arrays GLSL ES

Hi all, Just thought I'd bump this with a little more info. - I've tested this with the new i965 vec4 nir backend without regressions. - I've got subroutine and varying AoA working I just need to do some tessellation shader tests and then desktop support will be ready**. I'll send a follow-up pat

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

> Also I've > noticed that you've pushed a few patches [1][2][3][4] without > Reviewed-by tag. Please stop. Yes, I've already been told to include patch versions and reviewer. I'm sorry, I'll try not to screw it up again. On Wed, Aug 5, 2015 at 1:55 PM, Francisco Jerez wrote: > Zoltán Gilián w

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

On Wed, 2015-08-05 at 22:22 +1000, Timothy Arceri wrote: > On Wed, 2015-08-05 at 13:45 +0200, Iago Toral wrote: > > On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: > > > On Wed, 2015-08-05 at 10:30 +0200, Iago Toral Quiroga wrote: > > > > --- > > > > src/glsl/ast_to_hir.cpp | 9 -

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

On Wed, 2015-08-05 at 22:22 +1000, Timothy Arceri wrote: > On Wed, 2015-08-05 at 13:45 +0200, Iago Toral wrote: > > On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: > > > On Wed, 2015-08-05 at 10:30 +0200, Iago Toral Quiroga wrote: > > > > --- > > > > src/glsl/ast_to_hir.cpp | 9 -

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

On Wed, 2015-08-05 at 13:45 +0200, Iago Toral wrote: > On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: > > On Wed, 2015-08-05 at 10:30 +0200, Iago Toral Quiroga wrote: > > > --- > > > src/glsl/ast_to_hir.cpp | 9 - > > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > > >

Re: [Mesa-dev] [PATCH v3 (part2) 09/56] glsl: Add parser/compiler support for unsized array's length()

On Wed, 2015-08-05 at 13:38 +0300, Francisco Jerez wrote: > Iago Toral writes: > > > On Tue, 2015-08-04 at 16:04 -0700, Jordan Justen wrote: > >> On 2015-08-04 15:12:06, Jordan Justen wrote: > >> > On 2015-07-14 00:46:11, Iago Toral Quiroga wrote: > >> > > From: Samuel Iglesias Gonsalvez > >> >

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

Zoltán Gilián writes: >> thanks, this fixes the build for me. > > Should I commit this marking you as reviewer? "fixes the build for me" hardly qualifies as a Tested-by. Also I've noticed that you've pushed a few patches [1][2][3][4] without Reviewed-by tag. Please stop. [1] d2cd2c69b20fcb3f1

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: > On Wed, 2015-08-05 at 10:30 +0200, Iago Toral Quiroga wrote: > > --- > > src/glsl/ast_to_hir.cpp | 9 - > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > >

[Mesa-dev] [Bug 91556] clSetKernelArg from OpenCL is erroring out incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=91556 --- Comment #2 from Serge Martin --- Hello I didn't test your program, but it seems that dim_t on host side should be defined with cl_long instead of long long. See https://www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/scalarDataTypes.html

[Mesa-dev] About "freedreno/a4xx: MRT support"

Hi Rob, I recreationally looked at your recent patch set and saw that you left the comment above "#define MAX_RENDER_TARGETS" in 054526e49abb5e7fd49fed6f589cff6f1ab4c9f6. I think you intended to remove this comment after this delivery. If I am wrong, please disregard this message. Regards, Gusta

Re: [Mesa-dev] [PATCH] nir: add missing type to type_size_vec4()

Reviewed-by: Iago Toral Quiroga On Wed, 2015-08-05 at 20:31 +1000, Timothy Arceri wrote: > Cc: Iago Toral Quiroga > Cc: Jason Ekstrand > --- > src/glsl/nir/nir_lower_io.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c > ind

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

> thanks, this fixes the build for me. Should I commit this marking you as reviewer? On Wed, Aug 5, 2015 at 5:21 AM, Jan Vesely wrote: > On Tue, 2015-08-04 at 22:40 +0200, Zoltan Gilian wrote: >> There is no MDOperand in llvm 3.5. > > thanks, this fixes the build for me. > > jan > >> --- >> src

Re: [Mesa-dev] [PATCH 14/20] i965: Implement logic to set up and upload an image uniform.

"Pohjolainen, Topi" writes: > On Wed, Aug 05, 2015 at 10:36:09AM +0300, Pohjolainen, Topi wrote: >> On Tue, Jul 21, 2015 at 07:38:49PM +0300, Francisco Jerez wrote: >> > v2: Move the image_params array back to brw_stage_prog_data. >> > --- >> > src/mesa/drivers/dri/i965/brw_shader.cpp | 31 >> >

Re: [Mesa-dev] [PATCH v3 (part2) 09/56] glsl: Add parser/compiler support for unsized array's length()

Iago Toral writes: > On Tue, 2015-08-04 at 16:04 -0700, Jordan Justen wrote: >> On 2015-08-04 15:12:06, Jordan Justen wrote: >> > On 2015-07-14 00:46:11, Iago Toral Quiroga wrote: >> > > From: Samuel Iglesias Gonsalvez >> > > >> > > It also creates unop and triop expressions to tell the driver

[Mesa-dev] [PATCH] nir: add missing type to type_size_vec4()

Cc: Iago Toral Quiroga Cc: Jason Ekstrand --- src/glsl/nir/nir_lower_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c index 3c17929..71bfd34 100644 --- a/src/glsl/nir/nir_lower_io.c +++ b/src/glsl/nir/nir_lower_io.c @@ -62,6 +62

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

On Wed, 2015-08-05 at 10:30 +0200, Iago Toral Quiroga wrote: > --- > src/glsl/ast_to_hir.cpp | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index e834a46..518612d 100644 > --- a/src/glsl/ast_to_hir.cpp > +++ b/s

Re: [Mesa-dev] [PATCH] xa: don't leak fences

Hi! On 07/10/2015 01:12 PM, Marek Olšák wrote: > I wonder... do we still need XA considering that everybody can just > use glamor instead? > > Marek Just back from vacation so I late reply. In the case of VMware/vmwgfx, the rendering setup latency is huge. Glamor tries to accelerate everything.

  1   2   >