Re: [Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

2015-08-08 Thread Mathias Fröhlich
Hi, On Friday, August 07, 2015 12:17:15 Ilia Mirkin wrote: None of the other drivers appear to do it... should be safe. I'll def test it out before pushing, of course... I've been meaning to plug a nv1x in so I can play with a couple of minor items. Ideally it'd switch to the i965 method, and

Re: [Mesa-dev] [PATCH 5/6] egl/x11: trust our loader over the xserver for the drivername

2015-08-08 Thread Timothy Arceri
This change is causing a bunch of issues during a piglit run on my system. I'm getting error messages like this: *** Error in `/home/timothy/data/piglit/bin/glslparsertest_gles2': free(): invalid pointer: 0x022d4be0 *** Any ideas what might be wrong?

Re: [Mesa-dev] [PATCH 5/6] egl/x11: trust our loader over the xserver for the drivername

2015-08-08 Thread Boyan Ding
2015-08-08 16:05 GMT+08:00 Timothy Arceri t_arc...@yahoo.com.au: This change is causing a bunch of issues during a piglit run on my system. I'm getting error messages like this: *** Error in `/home/timothy/data/piglit/bin/glslparsertest_gles2': free(): invalid pointer: 0x022d4be0 ***

[Mesa-dev] [PATCH] egl/x11: Fix driver_name acquisition

2015-08-08 Thread Boyan Ding
We don't need to free driverName string from dri2 reply, on the other hand, the driver name acquired from loader doesn't need duplication. This fixes commit 45e110ba Cc: Emil Velikov emil.l.veli...@gmail.com Reported-by: Timothy Arceri t_arc...@yahoo.com.au Signed-off-by: Boyan Ding

Re: [Mesa-dev] [Mesa-stable] [PATCH 62/70] i965: Prevent coordinate overflow in intel_emit_linear_blit

2015-08-08 Thread Chris Wilson
On Fri, Aug 07, 2015 at 05:22:27PM -0700, Anuj Phogat wrote: I don't see any new changes as compared to the original patch you sent earlier. Reviewed-by: Anuj Phogat [11]anuj.pho...@gmail.com Sorry, there were none, I just forgot about pushing to the head of the queue and commiting

Re: [Mesa-dev] [PATCH 1/2] i965: Add SKL support to brw_miptree_get_horizontal_slice_pitch().

2015-08-08 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: I'm not a huge fan of this patch. Really, given how complicated 3-D textures are on SKL, there really is no sensible horizontal slice pitch. We could return 0 as an invalid value but I think I'd rather keep it an assert. Code that is dealing with

Re: [Mesa-dev] [PATCHv2 07/14] i965: Implement surface state set-up for shader images.

2015-08-08 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Wed, May 13, 2015 at 9:43 AM, Francisco Jerez curroje...@riseup.net wrote: v2: Add SKL support. --- src/mesa/drivers/dri/i965/brw_context.h | 2 + src/mesa/drivers/dri/i965/brw_surface_formats.c | 109 +++

Re: [Mesa-dev] [PATCH] clover: Properly initialize LLVM targets when linking with component libs

2015-08-08 Thread Francisco Jerez
Tom Stellard thomas.stell...@amd.com writes: Calls to LLVMIntialize* fail when we are linking against individual component libraries rather than one large shared object, because we only include component libraries that are required by the drivers. We need to make sure to only initialize the

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

2015-08-08 Thread Francisco Jerez
Iago Toral ito...@igalia.com writes: On Wed, 2015-08-05 at 22:22 +1000, Timothy Arceri wrote: On Wed, 2015-08-05 at 13:45 +0200, Iago Toral wrote: On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: On Wed, 2015-08-05 at 10:30 +0200, Iago Toral Quiroga wrote: ---

[Mesa-dev] [PATCH] gallium/radeon: fix r600g build if LLVM is disabled

2015-08-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com MESA_LLVM_VERSION_PATCH is undefined. --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c

Re: [Mesa-dev] [PATCH] egl/x11: Fix driver_name acquisition

2015-08-08 Thread Emil Velikov
On 8 August 2015 at 10:23, Boyan Ding boyan.j.d...@gmail.com wrote: We don't need to free driverName string from dri2 reply, on the other hand, the driver name acquired from loader doesn't need duplication. This fixes commit 45e110ba Cc: Emil Velikov emil.l.veli...@gmail.com Reported-by:

Re: [Mesa-dev] [PATCH] egl/x11: Fix driver_name acquisition

2015-08-08 Thread Timothy Arceri
On Sat, 2015-08-08 at 17:23 +0800, Boyan Ding wrote: We don't need to free driverName string from dri2 reply, on the other hand, the driver name acquired from loader doesn't need duplication. This fixes commit 45e110ba Cc: Emil Velikov emil.l.veli...@gmail.com Reported-by: Timothy Arceri

[Mesa-dev] [PATCH] mesa/formats: Only do byteswapping for packed formats

2015-08-08 Thread Jason Ekstrand
Cc: Iago Toral ito...@igalia.com Cc: Oded Gabbay oded.gab...@gmail.com --- src/mesa/main/formats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index baeb1bf..d927073 100644 --- a/src/mesa/main/formats.c +++

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Jason Ekstrand
On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay oded.gab...@gmail.com wrote: On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay oded.gab...@gmail.com wrote: This patch fixes a bug that is manifested in the read path of mesa when

Re: [Mesa-dev] [PATCH] mesa/formats: Only do byteswapping for packed formats

2015-08-08 Thread Oded Gabbay
On Sat, Aug 8, 2015 at 7:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Cc: Iago Toral ito...@igalia.com Cc: Oded Gabbay oded.gab...@gmail.com --- src/mesa/main/formats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/formats.c

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Oded Gabbay
On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay oded.gab...@gmail.com wrote: On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay oded.gab...@gmail.com

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Jason Ekstrand
On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay oded.gab...@gmail.com wrote: On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay oded.gab...@gmail.com wrote: On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand ja...@jlekstrand.net

[Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-08 Thread Jason Ekstrand
Mesa formats and gallium formats are defined a bit differently. In mesa there are packed formats which are based on byte-order within a 8, 16, or 32-bit word and there are array formats which are simply an array of 8, 16, or 32-bit values. In gallium, they do something different called plain

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-08 Thread Jason Ekstrand
It's worth noting that this only fixes some of the more obvious problems. For the formats that mesa defines as array formats, I think things are still pretty broken. This also brings into question how worth it it is having different format enums. I personally prefer the way that mesa core has

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Rob Clark
On Sat, Aug 8, 2015 at 4:26 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay oded.gab...@gmail.com wrote: On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay oded.gab...@gmail.com

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Jason Ekstrand
On Sat, Aug 8, 2015 at 2:10 PM, Rob Clark robdcl...@gmail.com wrote: On Sat, Aug 8, 2015 at 4:26 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay oded.gab...@gmail.com wrote: On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-08 Thread Roland Scheidegger
Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: Mesa formats and gallium formats are defined a bit differently. In mesa there are packed formats which are based on byte-order within a 8, 16, or 32-bit word and there are array formats which are simply an array of 8, 16, or 32-bit values. In

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-08 Thread Jason Ekstrand
On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: Mesa formats and gallium formats are defined a bit differently. In mesa there are packed formats which are based on byte-order within a 8, 16, or 32-bit word and there

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-08 Thread Roland Scheidegger
Am 08.08.2015 um 23:26 schrieb Jason Ekstrand: On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: Mesa formats and gallium formats are defined a bit differently. In mesa there are packed formats which are based on

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-08 Thread Oded Gabbay
On Sun, Aug 9, 2015 at 12:26 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: Mesa formats and gallium formats are defined a bit differently. In mesa there are packed

Re: [Mesa-dev] [PATCH] st/mesa: Map packed gallium formats to packed mesa formats.

2015-08-08 Thread Jason Ekstrand
On Sat, Aug 8, 2015 at 3:14 PM, Oded Gabbay oded.gab...@gmail.com wrote: On Sun, Aug 9, 2015 at 12:26 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Sat, Aug 8, 2015 at 2:14 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.08.2015 um 22:45 schrieb Jason Ekstrand: Mesa formats and

Re: [Mesa-dev] [PATCH v4 (part2) 49/59] glsl: Do not allow assignments to read-only variables

2015-08-08 Thread Timothy Arceri
On Sat, 2015-08-08 at 14:25 +0300, Francisco Jerez wrote: Iago Toral ito...@igalia.com writes: On Wed, 2015-08-05 at 22:22 +1000, Timothy Arceri wrote: On Wed, 2015-08-05 at 13:45 +0200, Iago Toral wrote: On Wed, 2015-08-05 at 20:04 +1000, Timothy Arceri wrote: On Wed, 2015-08-05

[Mesa-dev] [PATCH] glsl: Add missing spec quote about atomic counter in structs

2015-08-08 Thread Timothy Arceri
--- src/glsl/ast_to_hir.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 9385922..f67c951 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5679,10 +5679,10 @@

[Mesa-dev] [PATCH 3/6] glsl: add AoA support to subroutines

2015-08-08 Thread Timothy Arceri
--- src/glsl/ast_function.cpp | 43 ++- src/glsl/lower_subroutine.cpp | 2 +- 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index d003655..42affad 100644 ---

[Mesa-dev] ARB_arrays_of_arrays Desktop series

2015-08-08 Thread Timothy Arceri
This applies on top of my V3 ARB_arrays_of_arrays GLSL ES series If useful the series is in the 'desktop_AoA_no_interface' branch of the repo here: https://github.com/tarceri/Mesa_arrays_of_arrays.git This series: - Adds support for input/output AoA on i965 - AoA subroutine support - Enables

[Mesa-dev] [PATCH 2/6] glsl: disable interface block AoA

2015-08-08 Thread Timothy Arceri
Desktop GL supports interface block AoA however AMD and Nvidia dont support it in their drivers curently so we can get away with disabling it for now. --- src/glsl/ast_to_hir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 6/6] docs: Mark AoA as done for i965

2015-08-08 Thread Timothy Arceri
--- docs/GL3.txt | 4 ++-- docs/relnotes/11.0.0.html | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 8124383..79c80e0 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -149,7 +149,7 @@ GL 4.2, GLSL 4.20: GL 4.3, GLSL 4.30: -

[Mesa-dev] [PATCH 5/6] i965: enable ARB_arrays_of_arrays

2015-08-08 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 4a0..5febb95 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++

[Mesa-dev] [PATCH 4/6] i965: add arrays of arrays support for varyings

2015-08-08 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index ce1edc3..620ce13 100644 ---

[Mesa-dev] [PATCH 1/6] glsl: avoid hitting assert for arrays of arrays

2015-08-08 Thread Timothy Arceri
Also add TODO comment about adding proper support Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- src/glsl/ir_set_program_inouts.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index b7a0f6e..d7c29b0