On 2015-08-05 01:30:18, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez sigles...@igalia.com
Now std140 is not the only interface packing qualifier that can be used.
Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com
---
src/glsl/ast.h | 10 +
There are two uses of this flag.
The primary use is checking whether we need to emit code to convert
legacy gl_ClipVertex/gl_Position clipping to clip distances. In this
case, we also have to upload the clip planes as uniforms, which means
setting nr_userclip_plane_consts to a positive value.
The old code was disasterously complex - spread across multiple atoms
which may not even run, inspecting the dirty bits to try and decide
whether it was necessary to do checks...storing VS information in
brw_context...extra flagging...
This code tripped me and Carl up very badly when working on
This living in brw_fs.{h,cpp} is a historical artifact of us supporting
texturing for fragment shaders before any other stages. It's kind of
awkward given that we use it for all stages.
This avoids having to include brw_fs.h in geometry shader code in order
to access this function.
Hello,
I've been thinking a lot about VS/GS/HS/DS inputs and outputs lately.
Ideally, I'd like to know the input layout at NIR creation time, so I
can make nir_lower_io() produce nice offsets into the VUE or pushed
registers. One thing that complicates that is when the inputs/outputs
change
According to the GLSL 1.50 specification, page 76:
The shader must also set all values in gl_ClipDistance that have been
enabled via the OpenGL API, or results are undefined.
With this patch, we only enable clip distance writes when the shader
actually writes them. We no longer force a value to
The legacy userclip fields are only used for the vertex shader, and at
that point there's only program_string_id and the tex struct, which are
common to all keys. So there's no need for a VUE key base class.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
I'm about to remove the base class for VS/GS/HS/DS program keys, at
which point we won't be able to use key-tex anymore. Instead, we'll
need to store a direct pointer (like we do in the FS backend).
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_vec4.h
These were only for legacy userclipping, which we no longer support
in geometry shaders.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_gs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_gs.c
This avoids a downcast of key, which won't exist in the base class soon.
I'm not a huge fan of this patch, but given that we're currently using
inheritance, this seems like the right way to do it. The alternative
is to make key a void pointer in the parent class and continue
downcasting.
This is now only used for the vertex shader, so it makes sense to get it
out of any paths run by the geometry shader.
By wrapping the run() method, we can eliminate the bogus NULL
parameter in the GS case, and do VS things only for the VS.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
The entire VUE map is computed based on the slots_valid bitfield;
calling brw_compute_vue_map on the same bitfield will return the
same result. So we can simply compare those.
struct brw_vue_map is 136 bytes; doing a single 8-byte comparison is
much cheaper and should work just as well.
Because we only support geometry shaders in core profile, we can safely
ignore any driver-extending of VS outputs.
Those are:
- Legacy userclipping (doesn't exist in core profile)
- Edgeflag copying (Gen4-5 only, no GS support)
- Point coord replacement (Gen4-5 only, no GS support)
- front/back
We only support geometry shaders in core profiles, where gl_ClipVertex
doesn't exist. Presumably the even older behavior of clipping to
gl_Position isn't supported either. In fact, GLSL 1.50 page 76 claims:
The shader must also set all values in gl_ClipDistance that have been
enabled via the
From: Edward O'Callaghan eocallag...@alterapraxis.com
This makes better use of the work that the TGSI API has done for
us.
Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com
---
src/gallium/drivers/r600/r600_shader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Edward O'Callaghan eocallag...@alterapraxis.com
Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com
---
src/gallium/drivers/r600/evergreen_state.c | 16
src/gallium/drivers/r600/r600_pipe.h | 5 +
src/gallium/drivers/r600/r600_shader.c | 6
From: Edward O'Callaghan eocallag...@alterapraxis.com
The selector is shared by all shader variants, so the
individual shaders shouldn't change it. Use tgsi_shader_scan()
results to set geometry properties within a
r600_create_shader_state() call and treat said propertices in
the selector as
From: Edward O'Callaghan eocallag...@alterapraxis.com
Minor cleanups that intend to make better use of the TGSI parser
API tgsi_scan_shader().
V.2 adjustment; Set geometery property state within
r600_create_shader_state().
Edward O'Callaghan (4):
r600g: Remove dead assigment to
From: Edward O'Callaghan eocallag...@alterapraxis.com
Note that 'geometry shader properties' should be carried in the
selector state over the shader state in any case.
Signed-off-by: Edward O'Callaghan eocallag...@alterapraxis.com
---
src/gallium/drivers/r600/r600_shader.c | 3 ---
https://bugs.freedesktop.org/show_bug.cgi?id=91778
Hleb Valoshka 375...@gmail.com changed:
What|Removed |Added
QA Contact|dri-devel@lists.freedesktop
https://bugs.freedesktop.org/show_bug.cgi?id=91778
Hleb Valoshka 375...@gmail.com changed:
What|Removed |Added
Assignee|dri-devel@lists.freedesktop
https://bugs.freedesktop.org/show_bug.cgi?id=91778
Benjamin Bellec b.bel...@gmail.com changed:
What|Removed |Added
CC||b.bel...@gmail.com
https://bugs.freedesktop.org/show_bug.cgi?id=91643
Alexander Tsoy alexan...@tsoy.me changed:
What|Removed |Added
CC||alexan...@tsoy.me
--
https://bugs.freedesktop.org/show_bug.cgi?id=91797
Benjamin Bellec b.bel...@gmail.com changed:
What|Removed |Added
Assignee|dri-devel@lists.freedesktop
https://bugs.freedesktop.org/show_bug.cgi?id=91778
--- Comment #2 from Ilia Mirkin imir...@alum.mit.edu ---
It's due to ARB_gpu_shader5 getting enabled, which introduces the 'sample'
keyword. However the tropics shader has a variable called 'sample', which was
legal back then.
ARB_gpu_shader5,
On Sat, Aug 29, 2015 at 10:31 AM, Edward O'Callaghan
edward.ocallag...@koparo.com wrote:
From: Edward O'Callaghan eocallag...@alterapraxis.com
The selector is shared by all shader variants, so the
individual shaders shouldn't change it. Use tgsi_shader_scan()
results to set geometry
This is a patch that doesn't change anything. :)
For the series:
Reviewed-by: Marek Olšák marek.ol...@amd.com
Marek
On Sat, Aug 29, 2015 at 10:31 AM, Edward O'Callaghan
edward.ocallag...@koparo.com wrote:
From: Edward O'Callaghan eocallag...@alterapraxis.com
This makes better use of the work
From: Jeremy Huddleston jerem...@freedesktop.org
Cc: 10.6 11.0 mesa-sta...@lists.freedesktop.org
Bugzilla: https://bugs.gentoo.org/240956
---
This is the last patch Gentoo carries :)
configure.ac | 10 ++
1 file changed, 10 insertions(+)
diff --git a/configure.ac b/configure.ac
index
https://bugs.freedesktop.org/show_bug.cgi?id=91778
Kenneth Graunke kenn...@whitecape.org changed:
What|Removed |Added
Status|NEW |RESOLVED
On Sat, Aug 29, 2015 at 2:23 AM, Kenneth Graunke kenn...@whitecape.org wrote:
I'm about to remove the base class for VS/GS/HS/DS program keys, at
which point we won't be able to use key-tex anymore. Instead, we'll
need to store a direct pointer (like we do in the FS backend).
Signed-off-by:
On Friday, August 28, 2015 12:54:35 PM Ilia Mirkin wrote:
On Fri, Aug 28, 2015 at 6:58 AM, Francisco Jerez curroje...@riseup.net
wrote:
Ilia Mirkin imir...@alum.mit.edu writes:
This should include everything. I sent a test for textureSamples to
piglit a while ago, not sure how to test
On Sat, Aug 29, 2015 at 6:57 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
On Sat, Aug 29, 2015 at 9:46 PM, Matt Turner matts...@gmail.com wrote:
On Sat, Aug 29, 2015 at 4:27 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Why isn't this the default? IOW should this be incompatible with some
other
On Sun, Aug 30, 2015 at 1:27 AM, Jonathan Gray j...@jsg.id.au wrote:
On Fri, Aug 28, 2015 at 10:47:44AM +1000, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This code we broken by the tess merge, and I totally missed it
until now. I'm not sure this fixes anything but it stops the
On Sat, Aug 29, 2015 at 9:46 PM, Matt Turner matts...@gmail.com wrote:
On Sat, Aug 29, 2015 at 4:27 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Why isn't this the default? IOW should this be incompatible with some
other option and/or set based on some other option?
Please don't top quote.
I
On Sat, Aug 29, 2015 at 4:27 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Why isn't this the default? IOW should this be incompatible with some
other option and/or set based on some other option?
Please don't top quote.
If I understand correctly, this option partially disables an
optimization
On Fri, Aug 28, 2015 at 10:47:44AM +1000, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This code we broken by the tess merge, and I totally missed it
until now. I'm not sure this fixes anything but it stops the assert.
Cc: 11.0 mesa-sta...@lists.freedesktop.org
Signed-off-by:
Hi Emil,
src/gallium/targets/vdpau has a block that installs per-driver
hardlinks, but src/gallium/targets/va does not (presumably because it
was added later), which leads to:
https://bugs.gentoo.org/549564
Presumably it's mostly a matter of copy-n-paste?
Also, it appears that there's a minor
Why isn't this the default? IOW should this be incompatible with some
other option and/or set based on some other option?
On Sat, Aug 29, 2015 at 5:54 PM, Matt Turner matts...@gmail.com wrote:
From: Jeremy Huddleston jerem...@freedesktop.org
Cc: 10.6 11.0 mesa-sta...@lists.freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=91020
Dennis Schridde devuran...@gmx.net changed:
What|Removed |Added
CC||devuran...@gmx.net
39 matches
Mail list logo
