[Mesa-dev] [Bug 34495] Selecting objects in Blender 2.56 slow due the software gl_select mode

2015-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34495 --- Comment #77 from Fabio Pedretti --- There is a workaround here: https://bugs.launchpad.net/ubuntu/+source/blender/+bug/902618/comments/6 -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 91840] Expose GL_KHR_debug to ES contexts

2015-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91840 --- Comment #3 from Boyan Ding --- (In reply to Timothy Arceri from comment #2) > There are patches on the list not sure if they still apply: > http://lists.freedesktop.org/archives/mesa-dev/2014-August/066941.html At least the

[Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Matt Turner
The lowered code reads from the destination, which isn't possible from message registers. Fixes the dEQP functional.shaders.precision.int.highp_mul_fragment test on SNB. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radeonsi: only use new versions of LLVM image and sample intrinsics

2015-09-02 Thread Tom Stellard
On Tue, Sep 01, 2015 at 11:18:15PM +0200, Marek Olšák wrote: > From: Marek Olšák > Reviewed-by: Tom Stellard > Just a cleanup I had made a long time ago and forgot about. > --- > src/gallium/drivers/radeonsi/si_shader.c | 468 >

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Jason Ekstrand
On Sep 1, 2015 11:58 PM, "Matt Turner" wrote: > > The lowered code reads from the destination, which isn't possible from > message registers. > > Fixes the dEQP functional.shaders.precision.int.highp_mul_fragment test > on SNB. Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Mark Janes
Kenneth Graunke writes: > On Wednesday, September 02, 2015 12:03:12 AM Matt Turner wrote: >> The lowered code reads from the destination, which isn't possible from >> message registers. >> >> Fixes the dEQP functional.shaders.precision.int.highp_mul_fragment test >> on

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Emil Velikov
On 2 September 2015 at 16:57, Ian Romanick wrote: > For some reason the original patches and Ilia's response never showed up > in my inbox. > > So... how does one have a Mesa driver that doesn't enable any work > arounds? Very good point, although I believe this limitation

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Jason Ekstrand
On Sep 2, 2015 10:43 AM, "Mark Janes" wrote: > > Kenneth Graunke writes: > > > On Wednesday, September 02, 2015 12:03:12 AM Matt Turner wrote: > >> The lowered code reads from the destination, which isn't possible from > >> message registers. > >> >

Re: [Mesa-dev] [PATCH 1/2] glsl: Properly count doubles as taking twice the number of attrib slots.

2015-09-02 Thread Kenneth Graunke
On Tuesday, September 01, 2015 07:03:58 PM Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 6:53 PM, Matt Turner wrote: > > On Tue, Sep 1, 2015 at 3:57 PM, Matt Turner wrote: > >> --- > >> I checked the uses of count_attribute_slots() and it looks like they're

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Mark Janes
I verified that this fixed the following tests on snb: dEQP-GLES3.functional.shaders.precision.int.highp_mul_fragment dEQP-GLES3.functional.shaders.precision.int.mediump_mul_fragment dEQP-GLES3.functional.shaders.precision.int.lowp_mul_fragment However, my testing showed the

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 12:03:12 AM Matt Turner wrote: > The lowered code reads from the destination, which isn't possible from > message registers. > > Fixes the dEQP functional.shaders.precision.int.highp_mul_fragment test > on SNB. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 8

Re: [Mesa-dev] [PATCH v2] mesa/pbo: Handle zero width, height or depth when validating access

2015-09-02 Thread Jason Ekstrand
On Sep 2, 2015 7:27 AM, "Ilia Mirkin" wrote: > > On Wed, Sep 2, 2015 at 6:29 AM, Neil Roberts wrote: > > It's legal to call glTexSubImage with zero values for the width, > > height or depth. Previously this was breaking the PBO access > > validation

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Ian Romanick
For some reason the original patches and Ilia's response never showed up in my inbox. So... how does one have a Mesa driver that doesn't enable any work arounds? While this may work around the problem, it doesn't feel like the right solution. On 09/02/2015 06:55 AM, Iago Toral wrote: > Both

Re: [Mesa-dev] [PATCH] glsl: Handle attribute aliasing in attribute storage limit check.

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 02:35:22 PM Ilia Mirkin wrote: > On Wed, Sep 2, 2015 at 2:20 PM, Kenneth Graunke wrote: > > In various versions of OpenGL and GLSL, it's possible to declare > > multiple VS input variables with aliasing attribute locations. > > > > So, when

[Mesa-dev] [Bug 91747] Ubuntu 15.04/Oibaf PPA - Unity bar not transparent

2015-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91747 --- Comment #5 from Sinclair Yeh --- Ooops, wrong window. Meant to say that I created a new Unity bug here: https://bugs.launchpad.net/unity/+bug/1491555 -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Mark Janes
Mark Janes writes: > I verified that this fixed the following tests on snb: > > dEQP-GLES3.functional.shaders.precision.int.highp_mul_fragment > dEQP-GLES3.functional.shaders.precision.int.mediump_mul_fragment >

Re: [Mesa-dev] [PATCH] glsl: Handle attribute aliasing in attribute storage limit check.

2015-09-02 Thread Ilia Mirkin
On Wed, Sep 2, 2015 at 2:40 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:35:22 PM Ilia Mirkin wrote: >> On Wed, Sep 2, 2015 at 2:20 PM, Kenneth Graunke >> wrote: >> > In various versions of OpenGL and GLSL, it's possible to

[Mesa-dev] [PATCH] mesa; add get-extra-pick-list.sh script into bin/

2015-09-02 Thread Emil Velikov
This is a very rudimentary script that checks if any of the applied cherry-picks have been referenced (fixed?) by another patch(es) in master. With the latter missing the stable tag. This can be improved upon greatly, and/or extended to handle "Fixed" tags. At this point I'd wanted to send it

[Mesa-dev] [Bug 91747] Ubuntu 15.04/Oibaf PPA - Unity bar not transparent

2015-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91747 --- Comment #4 from Sinclair Yeh --- Done. Created "old_gpg_id.txt" to show the previous ID, and also added new public key in my home directory. thanks! -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Ilia Mirkin
On Wed, Sep 2, 2015 at 4:43 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: >> From: Marek Olšák >> >> People are having issues with apps because drirc wasn't installed >> into /etc. I've lost patience. >>

[Mesa-dev] [PATCH] glsl: Handle attribute aliasing in attribute storage limit check.

2015-09-02 Thread Kenneth Graunke
In various versions of OpenGL and GLSL, it's possible to declare multiple VS input variables with aliasing attribute locations. So, when computing the storage requirements for vertex attributes, we can't simply add up the sizes. Instead, we need to look at the enabled slots. This patch begins

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 04:47:13 PM Ilia Mirkin wrote: > On Wed, Sep 2, 2015 at 4:43 PM, Kenneth Graunke wrote: > > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: > >> From: Marek Olšák > >> > >> People are having issues with

Re: [Mesa-dev] [PATCH] glsl: Handle attribute aliasing in attribute storage limit check.

2015-09-02 Thread Ilia Mirkin
On Wed, Sep 2, 2015 at 2:20 PM, Kenneth Graunke wrote: > In various versions of OpenGL and GLSL, it's possible to declare > multiple VS input variables with aliasing attribute locations. > > So, when computing the storage requirements for vertex attributes, > we can't

Re: [Mesa-dev] [PATCH] Revert "i965: Stop aux data compare preventing program binary re-use"

2015-09-02 Thread Pohjolainen, Topi
On Thu, Aug 27, 2015 at 10:05:14AM -0700, Ben Widawsky wrote: > On Thu, Aug 27, 2015 at 10:51:59AM +0300, Pohjolainen, Topi wrote: > > On Wed, Aug 26, 2015 at 03:46:05PM -0700, Ben Widawsky wrote: > > > This reverts commit 1bba29ed403e735ba0bf04ed8aa2e571884fcaaf > > > Author: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: > From: Marek Olšák > > People are having issues with apps because drirc wasn't installed > into /etc. I've lost patience. > --- > src/mesa/drivers/dri/common/Makefile.am | 4 +- >

Re: [Mesa-dev] [PATCH] i965/fs: Handle MRF destinations in lower_integer_multiplication().

2015-09-02 Thread Matt Turner
On Wed, Sep 2, 2015 at 12:03 AM, Matt Turner wrote: > The lowered code reads from the destination, which isn't possible from > message registers. > > Fixes the dEQP functional.shaders.precision.int.highp_mul_fragment test > on SNB. > --- Thanks everyone for the reviews and

Re: [Mesa-dev] [PATCH 17/17] mesa: Remove gl_context parameter from _mesa_initialize_buffer_object and dd:NewBufferObject

2015-09-02 Thread Ian Romanick
On 08/26/2015 10:36 AM, Ilia Mirkin wrote: > *every* other callback takes a ctx... this feels really asymmetric. > I'd kinda rather just keep the ctx's in and add (void) uses on them. > Don't feel too strongly about it though. What if I told you that I have patches to remove unused ctx parameters

Re: [Mesa-dev] [PATCH 2/2] dri/common: drop loading /etc/drirc

2015-09-02 Thread Kenneth Graunke
On Wednesday, September 02, 2015 02:26:56 AM Marek Olšák wrote: > From: Marek Olšák > > A user can be using Mesa 11.0, but /etc/drirc can be from Mesa 10.5. > We don't want the old drirc to affect Mesa 11.0. > > There are 2 options: > - use a different file name (e.g.

[Mesa-dev] [Bug 91747] Ubuntu 15.04/Oibaf PPA - Unity bar not transparent

2015-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91747 Benjamin Bellec changed: What|Removed |Added Status|NEEDINFO|RESOLVED

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Marek Olšák
On Wed, Sep 2, 2015 at 5:57 PM, Ian Romanick wrote: > For some reason the original patches and Ilia's response never showed up > in my inbox. > > So... how does one have a Mesa driver that doesn't enable any work > arounds? While this may work around the problem, it doesn't

Re: [Mesa-dev] [PATCH 1/3] gallium/pb_bufmgr_cache: add a way to remove buffers from the cache explicitly

2015-09-02 Thread Alex Deucher
On Tue, Sep 1, 2015 at 3:04 PM, Marek Olšák wrote: > From: Marek Olšák > > This must be done before exporting a buffer as dmabuf fds, because > we lose track of who is using it and can't trust the reference counter. > > Cc: 11.0

[Mesa-dev] [PATCH] gallium/targets: don't leave an empty target directory(ies)

2015-09-02 Thread Emil Velikov
Some drivers do not support certain targets - for example nouveau doesn't do VAAPI, while freedreno doesn't do of the video backends. As such if we enter vdpau when building freedreno/ilo/etc, a vdpau/ folder will be created, empty library will be build and almost immediately removed. Thus

Re: [Mesa-dev] [PATCH 2/2] dri/common: drop loading /etc/drirc

2015-09-02 Thread Marek Olšák
On Wed, Sep 2, 2015 at 10:56 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:26:56 AM Marek Olšák wrote: >> From: Marek Olšák >> >> A user can be using Mesa 11.0, but /etc/drirc can be from Mesa 10.5. >> We don't want the old drirc to

Re: [Mesa-dev] [PATCH] glsl: Handle attribute aliasing in attribute storage limit check.

2015-09-02 Thread Mark Janes
Tested-by: Mark Janes Kenneth Graunke writes: > In various versions of OpenGL and GLSL, it's possible to declare > multiple VS input variables with aliasing attribute locations. > > So, when computing the storage requirements for vertex

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Matt Turner
On Wed, Sep 2, 2015 at 1:43 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: >> From: Marek Olšák >> >> People are having issues with apps because drirc wasn't installed >> into /etc. I've lost patience. >>

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Marek Olšák
On Wed, Sep 2, 2015 at 10:43 PM, Kenneth Graunke wrote: > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote: >> From: Marek Olšák >> >> People are having issues with apps because drirc wasn't installed >> into /etc. I've lost patience. >>

[Mesa-dev] [PATCHv2 3/6] r600g: make all viewport states use single atom

2015-09-02 Thread Grazvydas Ignotas
Similarly to scissor states, we can use single atom to track all viewport states. This will allow to simplify dirty atom handling later. --- v2: rebased, moved dirty_mask set out of the loop src/gallium/drivers/r600/evergreen_state.c | 7 ++--- src/gallium/drivers/r600/r600_blit.c |

[Mesa-dev] [PATCH 6/6] gallium/radeon: remove 'dirty' member from r600_atom

2015-09-02 Thread Grazvydas Ignotas
It's no longer used by both r600 and radeonsi now. --- src/gallium/drivers/r600/r600_pipe.h | 2 -- src/gallium/drivers/r600/r600_state_common.c | 1 - src/gallium/drivers/radeon/r600_pipe_common.h | 3 +-- src/gallium/drivers/radeonsi/si_state.c | 1 - 4 files changed, 1

[Mesa-dev] [PATCH 4/6] r600g: start numbering atoms from 1

2015-09-02 Thread Grazvydas Ignotas
There doesn't seem any reason to start from 4. Start from 1 instead (0 is left reserved to catch uninitialized atoms). --- src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_pipe.h | 2 +- src/gallium/drivers/r600/r600_state.c | 2 +- 3 files changed, 3

[Mesa-dev] [PATCHv2 1/6] r600g: make all scissor states use single atom

2015-09-02 Thread Grazvydas Ignotas
As suggested by Marek Olšák, we can use single atom to track all scissor states. This will allow to simplify dirty atom handling later. --- v2: rebased, moved dirty_mask set out of the loop src/gallium/drivers/r600/evergreen_state.c | 36 ++

[Mesa-dev] [PATCH 5/6] r600g: simplify dirty atom tracking

2015-09-02 Thread Grazvydas Ignotas
Now that R600_NUM_ATOMS is below 64, dirty atom tracking can be simplified. --- src/gallium/drivers/r600/r600_hw_context.c | 9 +++--- src/gallium/drivers/r600/r600_pipe.h | 45 src/gallium/drivers/r600/r600_state_common.c | 9 +++--- 3 files changed, 14

[Mesa-dev] [PATCH 2/6] r600g: apply disable workaround on all scissors

2015-09-02 Thread Grazvydas Ignotas
During review of the "r600g: make all scissor states use single atom" patch Marek Olšák noticed that scissor disable workaround should be applied on all scissor states and not just first one, so let's do so. --- src/gallium/drivers/r600/r600_state.c| 22 +-

Re: [Mesa-dev] [PATCH v3 4/4] i965/vec4: Don't unspill the same register in consecutive instructions

2015-09-02 Thread Francisco Jerez
Iago Toral writes: > Hi Curro, > > I have been a couple of weeks on holidays and have just come back to > this: > > On Thu, 2015-08-06 at 18:27 +0300, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > If we have spilled/unspilled a register in

Re: [Mesa-dev] [PATCH v2 6/6] i965: Add a debug option for spilling everything in vec4 code

2015-09-02 Thread Francisco Jerez
Iago Toral writes: > On Thu, 2015-07-30 at 16:13 +0300, Francisco Jerez wrote: >> Iago Toral writes: >> >> > On Thu, 2015-07-30 at 15:58 +0300, Francisco Jerez wrote: >> >> Iago Toral Quiroga writes: >> >> >> >> > --- >> >> >

Re: [Mesa-dev] [PATCH] i965/gen8+: Skip depth stalls on state change

2015-09-02 Thread Chris Wilson
On Wed, Aug 26, 2015 at 10:52:58AM -0700, Ben Widawsky wrote: > Docs suggest this is no longer required starting with Gen8. > > Perf (no regressions in n=20) > OglMultithread 0.67% > OglTerrainPanInst0.12% > trex 0.45% > warsow 0.64% > > I have a couple of

Re: [Mesa-dev] [PATCH 13/17 v2] glsl: Silence unused parameter warnings

2015-09-02 Thread Iago Toral
On Tue, 2015-09-01 at 18:56 -0700, Ian Romanick wrote: (...) > diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp > index dd7804f..bd25f45 100644 > --- a/src/glsl/builtin_variables.cpp > +++ b/src/glsl/builtin_variables.cpp > @@ -383,8 +383,7 @@ private: > ir_variable

Re: [Mesa-dev] [PATCH] mesa/pbo: Handle zero height or depth when validating PBO access

2015-09-02 Thread Neil Roberts
Ilia Mirkin writes: >> - end = _mesa_image_offset(dimensions, pack, width, height, >> - format, type, depth-1, height-1, width); >> + if (depth == 0 || height == 0) > > Why not width == 0 as well? You could probably just do > > return

[Mesa-dev] [PATCH 4/5] u_upload_mgr: remove the return value from u_upload_buffer

2015-09-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c | 35 ++- src/gallium/auxiliary/util/u_upload_mgr.h | 14 ++--- 2 files changed, 18 insertions(+), 31 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c

Re: [Mesa-dev] [PATCH 2/5] u_upload_mgr: remove the return value from u_upload_alloc

2015-09-02 Thread Brian Paul
On 09/02/2015 07:44 AM, Marek Olšák wrote: From: Marek Olšák The return buffer or the returned pointer can be used instead. --- src/gallium/auxiliary/util/u_upload_mgr.c | 28 ++-- src/gallium/auxiliary/util/u_upload_mgr.h | 12 ++--

Re: [Mesa-dev] [PATCH 3/5] u_upload_mgr: remove the return value from u_upload_alloc_buffer

2015-09-02 Thread Brian Paul
On 09/02/2015 07:44 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

2015-09-02 Thread Iago Toral
Both patches do what they advertise and seem to work, so they are Reviewed-by: Iago Toral Quiroga That said, I imagine that probably you want to get at least a few ACKs from other devs, like Illia did, to make sure that your changes have enough support. Iago On Wed,

[Mesa-dev] [PATCH 5/5] u_upload_mgr: remove the return value from u_upload_data

2015-09-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c | 19 --- src/gallium/auxiliary/util/u_upload_mgr.h | 12 ++-- src/gallium/auxiliary/util/u_vbuf.c | 9 - src/mesa/state_tracker/st_draw.c | 7 --- 4 files

[Mesa-dev] [PATCH 3/5] u_upload_mgr: remove the return value from u_upload_alloc_buffer

2015-09-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c b/src/gallium/auxiliary/util/u_upload_mgr.c index 6c8930f..f93de78 100644 ---

Re: [Mesa-dev] [PATCH 1/5] u_upload_mgr: optimize u_upload_alloc

2015-09-02 Thread Brian Paul
On 09/02/2015 07:44 AM, Marek Olšák wrote: From: Marek Olšák This is probably the most called util function. It does almost nothing, yet it can consume 10% of the CPU on the profile. This drops it down to 5%. --- src/gallium/auxiliary/util/u_upload_mgr.c | 36

[Mesa-dev] [PATCH 2/5] u_upload_mgr: remove the return value from u_upload_alloc

2015-09-02 Thread Marek Olšák
From: Marek Olšák The return buffer or the returned pointer can be used instead. --- src/gallium/auxiliary/util/u_upload_mgr.c | 28 ++-- src/gallium/auxiliary/util/u_upload_mgr.h | 12 ++-- src/gallium/auxiliary/util/u_vbuf.c | 27

[Mesa-dev] [PATCH 1/5] u_upload_mgr: optimize u_upload_alloc

2015-09-02 Thread Marek Olšák
From: Marek Olšák This is probably the most called util function. It does almost nothing, yet it can consume 10% of the CPU on the profile. This drops it down to 5%. --- src/gallium/auxiliary/util/u_upload_mgr.c | 36 +++ 1 file changed, 18

Re: [Mesa-dev] [PATCH v3 4/4] i965/vec4: Don't unspill the same register in consecutive instructions

2015-09-02 Thread Iago Toral
Hi Curro, I have been a couple of weeks on holidays and have just come back to this: On Thu, 2015-08-06 at 18:27 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > If we have spilled/unspilled a register in the current instruction, avoid > > emitting unspills

Re: [Mesa-dev] [PATCH] mesa/pbo: Handle zero height or depth when validating PBO access

2015-09-02 Thread Neil Roberts
Ian Romanick writes: > It seems like it should be handled in the core, and it looks like > _mesa_tex_sub_image is already doing that. Note the "if (width > 0 && > height > 0 && depth > 0)" check. What is the callstack that gets here > with height or depth as zero? That

Re: [Mesa-dev] [PATCH v2 6/6] i965: Add a debug option for spilling everything in vec4 code

2015-09-02 Thread Iago Toral
On Thu, 2015-07-30 at 16:13 +0300, Francisco Jerez wrote: > Iago Toral writes: > > > On Thu, 2015-07-30 at 15:58 +0300, Francisco Jerez wrote: > >> Iago Toral Quiroga writes: > >> > >> > --- > >> > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +-

Re: [Mesa-dev] nv3x libreoffice impress opengl animations not working

2015-09-02 Thread Hans de Goede
Hi Ilia On 31-08-15 18:30, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 8:58 AM, Hans de Goede wrote: Interestingly enough nv30_screen_get_param returns 0 for PIPE_CAP_TEXTURE_MULTISAMPLE and for PIPE_CAP_SAMPLER_VIEW_TARGET And this hack: ---

[Mesa-dev] [PATCH v2] mesa/pbo: Handle zero width, height or depth when validating access

2015-09-02 Thread Neil Roberts
It's legal to call glTexSubImage with zero values for the width, height or depth. Previously this was breaking the PBO access validation because it tries to work out the last pixel accessed by getting the pixel at height-1 and depth-1 which would end up with bogus values. This was causing GL

Re: [Mesa-dev] [PATCH v3 4/4] i965/vec4: Don't unspill the same register in consecutive instructions

2015-09-02 Thread Francisco Jerez
Iago Toral writes: > On Wed, 2015-09-02 at 14:29 +0300, Francisco Jerez wrote: >> Iago Toral writes: >> >> > Hi Curro, >> > >> > I have been a couple of weeks on holidays and have just come back to >> > this: >> > >> > On Thu, 2015-08-06 at 18:27 +0300,

Re: [Mesa-dev] [PATCH v2] mesa/pbo: Handle zero width, height or depth when validating access

2015-09-02 Thread Ilia Mirkin
On Wed, Sep 2, 2015 at 6:29 AM, Neil Roberts wrote: > It's legal to call glTexSubImage with zero values for the width, > height or depth. Previously this was breaking the PBO access > validation because it tries to work out the last pixel accessed by > getting the pixel at

Re: [Mesa-dev] [PATCH v3 4/4] i965/vec4: Don't unspill the same register in consecutive instructions

2015-09-02 Thread Iago Toral
On Wed, 2015-09-02 at 14:29 +0300, Francisco Jerez wrote: > Iago Toral writes: > > > Hi Curro, > > > > I have been a couple of weeks on holidays and have just come back to > > this: > > > > On Thu, 2015-08-06 at 18:27 +0300, Francisco Jerez wrote: > >> Iago Toral Quiroga

Re: [Mesa-dev] nv3x libreoffice impress opengl animations not working

2015-09-02 Thread Ilia Mirkin
On Wed, Sep 2, 2015 at 5:48 AM, Hans de Goede wrote: > Hi Ilia > > On 31-08-15 18:30, Ilia Mirkin wrote: >> >> On Mon, Aug 31, 2015 at 8:58 AM, Hans de Goede >> wrote: > > > > > >>> Interestingly enough nv30_screen_get_param returns 0 for >>>