Re: [Mesa-dev] [PATCH 0/2] i965/vec4: Change SEL and MOV types as needed to propagate source modifiers

16. sep. 2015 21.47 skrev "Alejandro Piñeiro" : > > On the review of the patch "i965/nir/vec4: fill the type of the dst > and src when loading an uniform" Jason Ekstrand suggested to change > the optimization pass in order to allow the copy propagation with > MOVs even if there is a type mismatch,

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

Hi Mark, On Mon, 2015-09-21 at 17:45 -0700, Mark Janes wrote: > Hi Iago, > > According to my tests, this patch series fixes the gles2/gles3 > "functional.uniform_api.random.23" tests in dEQP, on sandybridge. > > Do you see the same results? Should this patch series be applied to the > stable br

[Mesa-dev] [Bug 92052] nir/nir_builder.h:79: error: expected primary-expression before ‘.’ token

https://bugs.freedesktop.org/show_bug.cgi?id=92052 Vinson Lee changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glsl: do not attempt to dump_shader if no shaderobj

On 09/21/2015 05:04 PM, Iago Toral wrote: On Mon, 2015-09-21 at 09:15 +0300, Tapani Pälli wrote: Patch fixes a crash in conformance test that tries out different invalid arguments for glShaderSource and glGetShaderSource: ES2-CTS.gtf.GL.glGetShaderSource.getshadersource_programhandle Thi

Re: [Mesa-dev] [PATCH] nir: Always print non-xyzw swizzles.

On Sep 21, 2015 9:48 PM, "Ilia Mirkin" wrote: > > On Tue, Sep 22, 2015 at 12:45 AM, Matt Turner wrote: > > On Mon, Sep 21, 2015 at 9:37 PM, Ilia Mirkin wrote: > >> On Tue, Sep 22, 2015 at 12:31 AM, Matt Turner wrote: > >>> Previously we would not print a swizzle on ssa_52 when only its .x > >>>

Re: [Mesa-dev] [PATCH] nir: Always print non-xyzw swizzles.

On Tue, Sep 22, 2015 at 12:45 AM, Matt Turner wrote: > On Mon, Sep 21, 2015 at 9:37 PM, Ilia Mirkin wrote: >> On Tue, Sep 22, 2015 at 12:31 AM, Matt Turner wrote: >>> Previously we would not print a swizzle on ssa_52 when only its .x >>> component is used (as seen in the definition of ssa_53): >

Re: [Mesa-dev] [PATCH] nir: Always print non-xyzw swizzles.

On Mon, Sep 21, 2015 at 9:37 PM, Ilia Mirkin wrote: > On Tue, Sep 22, 2015 at 12:31 AM, Matt Turner wrote: >> Previously we would not print a swizzle on ssa_52 when only its .x >> component is used (as seen in the definition of ssa_53): >> >>vec3 ssa_52 = fadd ssa_51, ssa_51 >>vec1 ssa_53

Re: [Mesa-dev] [PATCH] nir: Always print non-xyzw swizzles.

On Tue, Sep 22, 2015 at 12:31 AM, Matt Turner wrote: > Previously we would not print a swizzle on ssa_52 when only its .x > component is used (as seen in the definition of ssa_53): > >vec3 ssa_52 = fadd ssa_51, ssa_51 >vec1 ssa_53 = flog2 ssa_52 >vec1 ssa_54 = flog2 ssa_52.y >vec1

[Mesa-dev] [PATCH] nir: Always print non-xyzw swizzles.

Previously we would not print a swizzle on ssa_52 when only its .x component is used (as seen in the definition of ssa_53): vec3 ssa_52 = fadd ssa_51, ssa_51 vec1 ssa_53 = flog2 ssa_52 vec1 ssa_54 = flog2 ssa_52.y vec1 ssa_55 = flog2 ssa_52.z But this makes the interpretation of the R

Re: [Mesa-dev] [PATCH 0/3] i965: Delete all of the non-NIR vec4 code

On Mon, Sep 21, 2015 at 6:15 PM, Jason Ekstrand wrote: > > On Sep 21, 2015 5:45 PM, "Matt Turner" wrote: >> >> On Mon, Sep 21, 2015 at 3:18 PM, Jason Ekstrand >> wrote: >> > At this point, piglit is the same as for GLSL and the shader-db numbers >> > are >> > looking pretty good. On SNB, GLSL v

[Mesa-dev] [PATCH shader-db] report.py: Report loop changes separately.

Previously, if the number of loops changed (and the instruction count changed wildly) we'd happily consider those differences in the totals, even though they're not meaningful. Based on code by Abdiel Janulgue . --- report.py | 43 --- 1 file changed, 32 in

Re: [Mesa-dev] [PATCH 0/3] i965: Delete all of the non-NIR vec4 code

On Sep 21, 2015 5:45 PM, "Matt Turner" wrote: > > On Mon, Sep 21, 2015 at 3:18 PM, Jason Ekstrand wrote: > > At this point, piglit is the same as for GLSL and the shader-db numbers are > > looking pretty good. On SNB, GLSL vs. NIR for vec4 programs is: > > > >total instructions in shared pro

Re: [Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

On Monday, September 21, 2015 02:27:00 PM Matt Turner wrote: [snip] > Yeah, the block immediately above handles conditions like this: > > if (inst->opcode != BRW_OPCODE_MOV || > (inst->dst.file != GRF && inst->dst.file != MRF) || > inst->predicate || > inst->src[0].file != GRF || >

Re: [Mesa-dev] [PATCH 0/3] i965: Delete all of the non-NIR vec4 code

On Mon, Sep 21, 2015 at 3:18 PM, Jason Ekstrand wrote: > At this point, piglit is the same as for GLSL and the shader-db numbers are > looking pretty good. On SNB, GLSL vs. NIR for vec4 programs is: > >total instructions in shared programs: 2020573 -> 1822601 (-9.80%) >instructions in aff

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

Hi Iago, According to my tests, this patch series fixes the gles2/gles3 "functional.uniform_api.random.23" tests in dEQP, on sandybridge. Do you see the same results? Should this patch series be applied to the stable branch? thanks, Mark Iago Toral Quiroga writes: > There are some bug repor

Re: [Mesa-dev] [PATCH] r600g/sb: Support gs5 sampler indexing

Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Sep 22, 2015, at 12:21 AM, Glenn Kennard wrote: > Signed-off-by: Glenn Kennard > --- > Just UBO support left before gs5 can be enabled. > Could improve how the two index registers are set/used to red

Re: [Mesa-dev] [PATCH rework] mesa: rework Driver.CopyImageSubData() and related code

On Mon, Sep 21, 2015 at 4:41 PM, Brian Paul wrote: > On 09/04/2015 12:39 PM, Brian Paul wrote: >> >> On 08/28/2015 11:03 AM, Jason Ekstrand wrote: >>> >>> On Fri, Aug 28, 2015 at 7:43 AM, Brian Paul wrote: On 08/28/2015 12:43 AM, Jason Ekstrand wrote: > > > On Thu, Aug 27, 2

Re: [Mesa-dev] [PATCH rework] mesa: rework Driver.CopyImageSubData() and related code

On 09/04/2015 12:39 PM, Brian Paul wrote: On 08/28/2015 11:03 AM, Jason Ekstrand wrote: On Fri, Aug 28, 2015 at 7:43 AM, Brian Paul wrote: On 08/28/2015 12:43 AM, Jason Ekstrand wrote: On Thu, Aug 27, 2015 at 11:42 PM, Jason Ekstrand wrote: From: Brian Paul Previously, core Mesa's _mesa

[Mesa-dev] [PATCH V3 2/8] i965: Use intel_get_tile_dims() to get tile masks

This will require change in the parameters passed to intel_miptree_get_tile_masks(). V2: Rearrange the order of parameters. (Ben) Change the name to intel_get_tile_masks(). (Topi) V3: Use temporary variables in intel_get_tile_masks() for clarity. Fix mask_y computation. Cc: Chad Versace

[Mesa-dev] [PATCH V3 1/8] i965: Add a helper function intel_get_tile_dims()

V2: - Do the tile width/height computations in the new helper function and use it later in intel_miptree_get_tile_masks(). - Change the name to intel_get_tile_dims(). V3: Return the tile_h in number of rows in place of bytes. Document the units of tile_w, tile_h parameters. Cc: Chad Versace

[Mesa-dev] [PATCH 0/3] i965: Delete all of the non-NIR vec4 code

At this point, piglit is the same as for GLSL and the shader-db numbers are looking pretty good. On SNB, GLSL vs. NIR for vec4 programs is: total instructions in shared programs: 2020573 -> 1822601 (-9.80%) instructions in affected programs: 1883334 -> 1685362 (-10.51%) helped:

[Mesa-dev] [PATCH 1/3] i965/vec4: Always use NIR

GLSL IR vs. NIR shader-db results for vec4 programs on i965: total instructions in shared programs: 1499395 -> 1408109 (-6.09%) instructions in affected programs: 1309372 -> 1218086 (-6.97%) helped:6359 HURT: 4528 GL

[Mesa-dev] [PATCH 3/3] i965/vec4: Delete the old vec4_vp code

--- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_vec4.h | 1 - src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 9 - src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.h| 1 - src/mesa/drivers/dri/i965/brw_vec4_vp.cpp | 6

[Mesa-dev] [PATCH 2/3] i965/vec4: Delete the old ir_visitor code

--- src/mesa/drivers/dri/i965/brw_vec4.h | 73 +- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 30 - src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.h |3 - src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp| 2106 ++--- src/mesa/drivers/dri/i965/gen6_gs

Re: [Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

On Mon, Sep 21, 2015 at 2:16 PM, Jason Ekstrand wrote: > On Mon, Sep 21, 2015 at 2:04 PM, Matt Turner wrote: >> With NIR: >> >> instructions in affected programs: 111508 -> 109193 (-2.08%) >> helped:507 > > *sigh* Any idea who's emitting these MOV's? If it's

Re: [Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

On Mon, Sep 21, 2015 at 2:16 PM, Kenneth Graunke wrote: > On Monday, September 21, 2015 02:04:00 PM Matt Turner wrote: >> With NIR: >> >> instructions in affected programs: 111508 -> 109193 (-2.08%) >> helped:507 >> >> Without NIR: >> >> instructions in affected

Re: [Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

On Mon, Sep 21, 2015 at 2:17 PM, Jason Ekstrand wrote: > On Mon, Sep 21, 2015 at 2:16 PM, Kenneth Graunke > wrote: >> On Monday, September 21, 2015 02:04:00 PM Matt Turner wrote: >>> With NIR: >>> >>> instructions in affected programs: 111508 -> 109193 (-2.08%) >>> helped:

Re: [Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

On Mon, Sep 21, 2015 at 2:16 PM, Kenneth Graunke wrote: > On Monday, September 21, 2015 02:04:00 PM Matt Turner wrote: >> With NIR: >> >> instructions in affected programs: 111508 -> 109193 (-2.08%) >> helped:507 >> >> Without NIR: >> >> instructions in affected

Re: [Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

On Monday, September 21, 2015 02:04:00 PM Matt Turner wrote: > With NIR: > > instructions in affected programs: 111508 -> 109193 (-2.08%) > helped:507 > > Without NIR: > > instructions in affected programs: 28763 -> 28474 (-1.00%) > helped:

Re: [Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

On Mon, Sep 21, 2015 at 2:04 PM, Matt Turner wrote: > With NIR: > > instructions in affected programs: 111508 -> 109193 (-2.08%) > helped:507 *sigh* Any idea who's emitting these MOV's? If it's vec_to_movs, we should probably fix it one of these days. In any

[Mesa-dev] [PATCH] i965/vec4: Detect and delete useless MOVs.

With NIR: instructions in affected programs: 111508 -> 109193 (-2.08%) helped:507 Without NIR: instructions in affected programs: 28763 -> 28474 (-1.00%) helped:186 --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 21 ++

Re: [Mesa-dev] [PATCH] i965/compiler: Clean up GLSL compiler option setup

On Mon, Sep 21, 2015 at 12:40 PM, Matt Turner wrote: > On Mon, Sep 21, 2015 at 11:24 AM, Jason Ekstrand wrote: >> The only functional change here is that we now set EmitNoIndirectOutput and >> EmitNoIndirectTemp for compute shaders. Compute shaders don't have outputs >> per-se and we should have

Re: [Mesa-dev] [PATCH] i965/compiler: Clean up GLSL compiler option setup

On Mon, Sep 21, 2015 at 11:24 AM, Jason Ekstrand wrote: > The only functional change here is that we now set EmitNoIndirectOutput and > EmitNoIndirectTemp for compute shaders. Compute shaders don't have outputs > per-se and we should have been setting EmitNoIndirectTemp all along. > --- No one h

Re: [Mesa-dev] [PATCH] i965/compiler: Clean up GLSL compiler option setup

Reviewed-by: Jordan Justen On 2015-09-21 11:24:59, Jason Ekstrand wrote: > The only functional change here is that we now set EmitNoIndirectOutput and > EmitNoIndirectTemp for compute shaders. Compute shaders don't have outputs > per-se and we should have been setting EmitNoIndirectTemp all alon

[Mesa-dev] [PATCH] i965/compiler: Clean up GLSL compiler option setup

The only functional change here is that we now set EmitNoIndirectOutput and EmitNoIndirectTemp for compute shaders. Compute shaders don't have outputs per-se and we should have been setting EmitNoIndirectTemp all along. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 46 ++-

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: Add support to enable read-only text segment on x86.

Reviewed-by: Ian Romanick On 09/03/2015 09:36 PM, Matt Turner wrote: > From: Jeremy Huddleston > > Cc: "10.6 11.0" > Bugzilla: https://bugs.gentoo.org/240956 > --- > After talking with Ian today, we determined that this disables an > optimization. > > And FWIW, NVIDIA's fork of glapi (libglvn

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

On Monday, September 21, 2015 09:24:17 AM Jason Ekstrand wrote: > On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke > wrote: > > On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: > >> Designated initializers are not allowed in C++ (not even C++11). Since > >> nir_lower_samplers is n

Re: [Mesa-dev] [PATCH] Revert "mesa/extensions: restrict GL_OES_EGL_image to GLES"

On 09/16/2015 05:00 PM, Dave Airlie wrote: > This reverts commit 48961fa3ba37999a6f8fd812458b735e39604a95. > > glamor/Xwayland use this, the spec saying something when it > was written, and the fact that the comment says Mesa relies on it > hasn't changed. > > I also don't have a copy of this pat

Re: [Mesa-dev] [PATCH] configure.ac: Add support to enable read-only text segment on x86.

On Thu, Sep 3, 2015 at 9:36 PM, Matt Turner wrote: > From: Jeremy Huddleston > > Cc: "10.6 11.0" > Bugzilla: https://bugs.gentoo.org/240956 > --- > After talking with Ian today, we determined that this disables an > optimization. > > And FWIW, NVIDIA's fork of glapi (libglvnd) contains this kind

Re: [Mesa-dev] [PATCH v4] i965/vec4: Change types as needed to propagate source modifiers using from instruction

On 21/09/15 18:27, Jason Ekstrand wrote: > On Sun, Sep 20, 2015 at 3:00 PM, Alejandro Piñeiro > wrote: >> MOV instructions, as long as they don't have source modifiers, are >> just copying bits around. So those kind of instruction could be >> propagated even if there are type mismatches. This is

Re: [Mesa-dev] [Mesa-users] glClearColor is broken in a weird way if compiled with mangling enabled

With this patch: https://bugs.freedesktop.org/show_bug.cgi?id=91724, osmesa builds fine, but OpenGL2 shader related functions like glCreateShader does not work (It always return 0). Pre 2 fixed pipeline functions all work fine. Does anyone have any clue about this? Yuzhu - On Aug 24, 201

Re: [Mesa-dev] [PATCH v4] i965/vec4: Change types as needed to propagate source modifiers using from instruction

On Sun, Sep 20, 2015 at 3:00 PM, Alejandro Piñeiro wrote: > MOV instructions, as long as they don't have source modifiers, are > just copying bits around. So those kind of instruction could be > propagated even if there are type mismatches. This is needed because > NIR generates integer MOV instr

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

On Mon, Sep 21, 2015 at 9:24 AM, Matt Turner wrote: > On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke > wrote: >> On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: >>> Designated initializers are not allowed in C++ (not even C++11). Since >>> nir_lower_samplers is now using nir_b

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke wrote: > On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: >> Designated initializers are not allowed in C++ (not even C++11). Since >> nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in >> C++, this breaks the

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke wrote: > On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: >> Designated initializers are not allowed in C++ (not even C++11). Since >> nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in >> C++, this breaks the

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: > Designated initializers are not allowed in C++ (not even C++11). Since > nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in > C++, this breaks the build on some compilers. Aparently, GCC 5 allows it > in some

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

On Mon, Sep 21, 2015 at 8:00 AM, Iago Toral wrote: > On Mon, 2015-09-21 at 07:49 -0700, Kenneth Graunke wrote: >> On Monday, September 21, 2015 09:46:24 AM Mark Janes wrote: >> > This series hits an assertion on ILK and G45: >> > >> > src/mesa/drivers/dri/i965/brw_eu_emit.c:150: brw_set_dest: Asse

Re: [Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

On 19 September 2015 at 14:53, Jason Ekstrand wrote: > On Sat, Sep 19, 2015 at 1:28 AM, Jonathan Gray wrote: >> On Fri, Sep 18, 2015 at 10:52:35AM -0700, Jason Ekstrand wrote: >>> On Sep 18, 2015 12:40 PM, "Emil Velikov" wrote: >>> > >>> > Thanks for the review/testing guys. >>> > >>> > Just not

Re: [Mesa-dev] mesa-10.6: LLVM/Clang v3.7 fixes (gallivm)

On Fri, Sep 18, 2015 at 11:34 AM, Emil Velikov wrote: > On 14 September 2015 at 10:36, Sedat Dilek wrote: >> On Thu, Sep 10, 2015 at 4:18 PM, Emil Velikov >> wrote: >>> On 4 September 2015 at 19:57, Sedat Dilek wrote: Hi, I compiled a toolchain based on LLVM/Clang v3.7.0 today a

Re: [Mesa-dev] [RFC] nir/opt_peephole_ffma: Bypass fusion if any operand of fadd and fmul is a const

On Mon, Sep 21, 2015 at 12:14 AM, Eduardo Lima Mitev wrote: > On 09/19/2015 09:00 PM, Jason Ekstrand wrote: >> >> On Sep 18, 2015 2:49 AM, "Eduardo Lima Mitev" > > wrote: >>> >>> When both fadd and fmul instructions have at least one operand that is a >>> constant and it i

[Mesa-dev] [Bug 92052] nir/nir_builder.h:79: error: expected primary-expression before ‘.’ token

https://bugs.freedesktop.org/show_bug.cgi?id=92052 Jason Ekstrand changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Jason Ekst

[Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

Designated initializers are not allowed in C++ (not even C++11). Since nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in C++, this breaks the build on some compilers. Aparently, GCC 5 allows it in some limited extent because mesa still builds on my system without this patc

Re: [Mesa-dev] [PATCH v2] nir: Move system value -> intrinsic mapping into nir.c

On Monday, September 21, 2015 08:14:24 AM Jason Ekstrand wrote: > This way they're right next to the map going the other direction. > --- > src/glsl/nir/nir.c | 38 +++ > src/glsl/nir/nir.h | 1 + > src/glsl/nir/nir_lower_system_

Re: [Mesa-dev] [PATCH] i965/vec4: Don't coalesce registers in gen6 math ops if reswizzling needed

On Sunday, September 20, 2015 11:11:15 AM Matt Turner wrote: > On Sun, Sep 20, 2015 at 8:48 AM, Antia Puentes wrote: > > Math operations in SandyBridge do not support source swizzling > > I can't find any documentation to support this claim, but I remember > that SNB math must be in align1 mode s

[Mesa-dev] [PATCH v2] nir: Move system value -> intrinsic mapping into nir.c

This way they're right next to the map going the other direction. --- src/glsl/nir/nir.c | 38 +++ src/glsl/nir/nir.h | 1 + src/glsl/nir/nir_lower_system_values.c | 41 +- 3 files changed, 40 inse

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

On Mon, 2015-09-21 at 07:49 -0700, Kenneth Graunke wrote: > On Monday, September 21, 2015 09:46:24 AM Mark Janes wrote: > > This series hits an assertion on ILK and G45: > > > > src/mesa/drivers/dri/i965/brw_eu_emit.c:150: brw_set_dest: Assertion > > `dest.nr < (devinfo->gen == 6 ? 24 : 16)' faile

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

On Monday, September 21, 2015 09:46:24 AM Mark Janes wrote: > This series hits an assertion on ILK and G45: > > src/mesa/drivers/dri/i965/brw_eu_emit.c:150: brw_set_dest: Assertion > `dest.nr < (devinfo->gen == 6 ? 24 : 16)' failed. > > It triggers about 8k piglit assertions on those platforms.

[Mesa-dev] [PATCH] r600g/sb: Support gs5 sampler indexing

Signed-off-by: Glenn Kennard --- Just UBO support left before gs5 can be enabled. Could improve how the two index registers are set/used to reduce the number of clauses, but as is its about as good as what the blob emits. src/gallium/drivers/r600/r600_shader.c | 12 ++- src/gallium/driver

Re: [Mesa-dev] [PATCH] glsl: do not attempt to dump_shader if no shaderobj

On Mon, 2015-09-21 at 09:15 +0300, Tapani Pälli wrote: > Patch fixes a crash in conformance test that tries out different > invalid arguments for glShaderSource and glGetShaderSource: > >ES2-CTS.gtf.GL.glGetShaderSource.getshadersource_programhandle > > This is a regression from commit: >

Re: [Mesa-dev] [PATCH 0/5] Enable up to 24 MRF registers in gen6

This series hits an assertion on ILK and G45: src/mesa/drivers/dri/i965/brw_eu_emit.c:150: brw_set_dest: Assertion `dest.nr < (devinfo->gen == 6 ? 24 : 16)' failed. It triggers about 8k piglit assertions on those platforms. I'm turning off testing for G45 and ILK until it is resolved. https://b

Re: [Mesa-dev] [PATCH v5 18/70] i965/fs/nir: implement nir_intrinsic_get_buffer_size

On 10/09/15 15:35, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_ni

[Mesa-dev] [Bug 86265] Error while running gazebo in ROS Hydro

https://bugs.freedesktop.org/show_bug.cgi?id=86265 --- Comment #1 from Grigori Goronzy --- Both Mesa 9.1.7 and ROS Hydro are really old. Gazebo 5.0.1 with Mesa 10.5.9 works fine for me on Intel and Radeon (radeonsi). -- You are receiving this mail because: You are the QA Contact for the bug. Yo

[Mesa-dev] [PATCH] glsl: First argument to atomic functions must be a buffer variable

v2: - Add ssbo_in the names of the static functions so it is clear that this is specific to SSBO atomics. v3: - Move the check after the loop (Kristian Høgsberg) --- src/glsl/ast_function.cpp | 42 ++ 1 file changed, 42 insertions(+) diff --git a/s

Re: [Mesa-dev] [PATCH v5 70/70] glsl: Mark as active all elements of shared/std140 block arrays

On 21/09/15 09:41, Tapani Pälli wrote: > Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on Haswell > (most failing tests are with ubos). > > Tested-by: Tapani Pälli > OK thanks! > This is individual patch not related to just SSBOs, maybe this could be > pushed separately from the

Re: [Mesa-dev] [PATCH v5 00/70] ARB_shader_storage_buffer_object (mesa, i965)

Hi Kristian, On Fri, 2015-09-18 at 16:56 -0700, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:16PM +0200, Iago Toral Quiroga wrote: > > Hi, > > > > this is the latest version of the ARB_shader_storage_buffer_object > > implementation. A good part of the frontend bits for this are alrea

Re: [Mesa-dev] [PATCH v5 38/70] i965/nir/vec4: Implement nir_intrinsic_store_ssbo

On Fri, 2015-09-18 at 13:02 -0700, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:54PM +0200, Iago Toral Quiroga wrote: > > --- > > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 148 > > + > > 1 file changed, 148 insertions(+) > > > > diff --git a/src/mesa/dr

Re: [Mesa-dev] [PATCH v5 23/70] glsl: refactor parser processing of an interface block definition

On 19/09/15 01:44, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:39PM +0200, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez > > I'd be more specific in the subject and say: > > 'glsl: Move interface block processing to glsl_parser_extras.cpp > > 'Refactor' can mean

Re: [Mesa-dev] [PATCH v5 40/70] nir: Implement __intrinsic_load_ssbo

On 19/09/15 00:30, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:56PM +0200, Iago Toral Quiroga wrote: >> v2: >> - Fix ssbo loads with boolean variables. >> >> Reviewed-by: Connor Abbott >> --- >> src/glsl/nir/glsl_to_nir.cpp| 80 >> - >>

Re: [Mesa-dev] [PATCH v5 70/70] glsl: Mark as active all elements of shared/std140 block arrays

Seems like a nice fix, takes ES3 CTS failures from 116 to 64 on Haswell (most failing tests are with ubos). Tested-by: Tapani Pälli This is individual patch not related to just SSBOs, maybe this could be pushed separately from the rest? // Tapani On 09/10/2015 04:36 PM, Iago Toral Quiroga

Re: [Mesa-dev] [PATCH v5 28/70] glsl: add std430 interface packing support to ssbo related operations

On 18/09/15 21:04, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:44PM +0200, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> v2: >> - Get interface packing information from interface's type, not the variable >> type. >> - Simplify is_std430 condition in emit_access

Re: [Mesa-dev] [RFC] nir/opt_peephole_ffma: Bypass fusion if any operand of fadd and fmul is a const

On 09/19/2015 09:00 PM, Jason Ekstrand wrote: > > On Sep 18, 2015 2:49 AM, "Eduardo Lima Mitev" > wrote: >> >> When both fadd and fmul instructions have at least one operand that is a >> constant and it is only used once, the total number of instructions can >> be reduced

Re: [Mesa-dev] [PATCH v5 29/70] glsl: a shader storage buffer must be smaller than the maximum size allowed

On 18/09/15 20:59, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:45PM +0200, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> Otherwise, generate a link time error as per the >> ARB_shader_storage_buffer_object spec. >> >> v2: >> - Fix error message (Jordan) >> >> Si

Re: [Mesa-dev] [PATCH v5 26/70] glsl: Add parser/compiler support for std430 interface packing qualifier

On 18/09/15 20:14, Kristian Høgsberg wrote: > On Thu, Sep 10, 2015 at 03:35:42PM +0200, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> v2: >> - Fix a missing check in has_layout() >> >> Signed-off-by: Samuel Iglesias Gonsalvez >> Reviewed-by: Jordan Justen >> --- >> src/gl