[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #10 from Matthew Waters --- (In reply to Ian Romanick from comment #9) > Comment on attachment 119006 [details] [review] > egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS > > Review of attachment 119006

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

On Sun, Oct 25, 2015 at 1:25 PM, Marek Olšák wrote: > From: Marek Olšák > > I wonder if the craziness was worth it. > --- > src/mesa/Makefile.sources| 2 + > src/mesa/state_tracker/st_cb_copyimage.c | 609 > +++ > src/mesa/state_tracker/st_cb_copyim

Re: [Mesa-dev] [PATCH 2/3] gallium: add PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS

Reviewed-by: Brian Paul On 10/25/2015 11:25 AM, Marek Olšák wrote: From: Marek Olšák For ARB_copy_image. --- src/gallium/docs/source/screen.rst | 4 +++- src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/ga

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

Looks good to me. Yeah, it is kind of crazy. I think softpipe/llvmpipe just need one of my previous patches, plus minor updates. I'll take care of that. Just one minor nit below. Oh, and you could probably mention support for GL_ARB_copy_image in the release notes file and GL3.txt. Revie

Re: [Mesa-dev] [PATCH] i965: Set correct field for indirect align16 addrimm.

On Mon, Oct 26, 2015 at 5:07 PM, Ian Romanick wrote: > On 10/26/2015 11:10 AM, Matt Turner wrote: >> This has been wrong since the initial import of the i965 driver. > > That is awesome. Other than using the assembly validator, is there any > way to trigger this? I assume you discovered this bug

Re: [Mesa-dev] [PATCH 3/5] glsl: Mark gl_ViewportIndex and gl_Layer varyings as flat.

On Monday, October 26, 2015 05:02:07 PM Ian Romanick wrote: > On 10/26/2015 11:03 AM, Kenneth Graunke wrote: > > Integer varyings need to be flat qualified - all others were already. > > I think we just missed this. Presumably some hardware passes this via > > sideband and ignores attribute interp

Re: [Mesa-dev] [PATCH 5/7] nir: support to clone shaders (v2)

On Mon, Oct 26, 2015 at 6:56 PM, Jason Ekstrand wrote: > On Mon, Oct 26, 2015 at 12:53 PM, Rob Clark wrote: >> On Mon, Oct 26, 2015 at 2:44 PM, Jason Ekstrand wrote: >>> On Mon, Oct 26, 2015 at 8:27 AM, Rob Clark wrote: +static void * +clone_intrinsic(clone_state *state, const vo

Re: [Mesa-dev] [PATCH] i965: Set correct field for indirect align16 addrimm.

On 10/26/2015 11:10 AM, Matt Turner wrote: > This has been wrong since the initial import of the i965 driver. That is awesome. Other than using the assembly validator, is there any way to trigger this? I assume you discovered this bug by inspection... > --- > src/mesa/drivers/dri/i965/brw_eu_e

Re: [Mesa-dev] [PATCH 3/5] glsl: Mark gl_ViewportIndex and gl_Layer varyings as flat.

On 10/26/2015 11:03 AM, Kenneth Graunke wrote: > Integer varyings need to be flat qualified - all others were already. > I think we just missed this. Presumably some hardware passes this via > sideband and ignores attribute interpolation, so no one has noticed. > > Signed-off-by: Kenneth Graunke

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #9 from Ian Romanick --- Comment on attachment 119006 --> https://bugs.freedesktop.org/attachment.cgi?id=119006 egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS Review of attachment 119006:

[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

https://bugs.freedesktop.org/show_bug.cgi?id=92552 --- Comment #8 from Ian Romanick --- (In reply to Boyan Ding from comment #4) > (In reply to Matthew Waters from comment #2) > > Created attachment 119006 [details] [review] [review] > > egl: distnguish between unsupported api vs capabilities for

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Enable ASTC in GLES' [NUM_]COMPRESSED_TEXTURE_FORMATS queries

On Mon, Oct 26, 2015 at 4:30 PM, Ian Romanick wrote: > Reviewed-by: Ian Romanick > > On 10/21/2015 03:06 PM, Nanley Chery wrote: > > From: Nanley Chery > > > > In OpenGL ES, the COMPRESSED_TEXTURE_FORMATS query returns the set of > > supported specific compressed formats. Since ASTC formats fit

Re: [Mesa-dev] [PATCH 3/5] glsl: Mark gl_ViewportIndex and gl_Layer varyings as flat.

On Monday, October 26, 2015 02:10:29 PM Ilia Mirkin wrote: > On Mon, Oct 26, 2015 at 2:03 PM, Kenneth Graunke > wrote: > > Integer varyings need to be flat qualified - all others were already. > > I think we just missed this. Presumably some hardware passes this via > > sideband and ignores attr

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Enable ASTC in GLES' [NUM_]COMPRESSED_TEXTURE_FORMATS queries

Reviewed-by: Ian Romanick On 10/21/2015 03:06 PM, Nanley Chery wrote: > From: Nanley Chery > > In OpenGL ES, the COMPRESSED_TEXTURE_FORMATS query returns the set of > supported specific compressed formats. Since ASTC formats fit within > that category, include them in the set and update the > N

Re: [Mesa-dev] [PATCH v2] mesa: Draw indirect is not allowed when xfb is active and unpaused

Reviewed-by: Ian Romanick On 10/26/2015 03:50 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > OpenGL ES 3.1 specification, section 10.5: > "An INVALID_OPERATION error is generated if > transform feedback is active and not paused." > > Signed-off-by: Marta Lofstedt > --- > src/mesa/main/

Re: [Mesa-dev] [PATCH v2] mesa: Draw Indirect return wrong error code on unalinged

Reviewed-by: Ian Romanick On 10/26/2015 03:22 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > From OpenGL 4.4 specification, section 10.4 and > Open GL Es 3.1 section 10.5: > "An INVALID_VALUE error is generated if indirect is not a multiple > of the size, in basic machine units, of uint."

Re: [Mesa-dev] [PATCH 5/7] nir: support to clone shaders (v2)

On Mon, Oct 26, 2015 at 12:53 PM, Rob Clark wrote: > On Mon, Oct 26, 2015 at 2:44 PM, Jason Ekstrand wrote: >> On Mon, Oct 26, 2015 at 8:27 AM, Rob Clark wrote: >>> Signed-off-by: Rob Clark >>> --- >>> src/glsl/Makefile.sources | 1 + >>> src/glsl/nir/nir.c| 8 + >>> src/glsl/nir/n

Re: [Mesa-dev] [RFC 15/21] mesa: Fix EXT_texture_sRGB functionality leaks

On Fri, Oct 23, 2015 at 3:01 PM, Nanley Chery wrote: > > > On Thu, Oct 22, 2015 at 12:15 PM, Chad Versace > wrote: > >> On Mon 19 Oct 2015, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > Stop leaks into the following contexts: >> >* GLES in _mesa_base_tex_format() and lookup_view_cla

[Mesa-dev] [Bug 92278] Black screen in War Thunder

https://bugs.freedesktop.org/show_bug.cgi?id=92278 --- Comment #5 from Sven Arvidsson --- The patch works fine here, awesome work! Fantastic to have it fixed so quickly! The developer of the game is Gaijin Entertainment, http://gaijinent.com I could probably open a support ticket with them, but

Re: [Mesa-dev] [PATCH 5/5] i965: Implement ARB_fragment_layer_viewport.

For the series Reviewed-by: Chris Forbes On Oct 27, 2015 7:03 AM, "Kenneth Graunke" wrote: > Normally, we could read gl_Layer from bits 26:16 of R0.0. However, the > specification requires that bogus out-of-range 32-bit values written by > previous stages need to appear in the fragment shader

Re: [Mesa-dev] [RFC 19/21] mesa: Replace gl_extensions::EXT_texture3D with ::dummy_true

On Mon 19 Oct 2015, Nanley Chery wrote: > From: Nanley Chery > > Mesa unconditionally sets this driver flag to true in > _mesa_init_extensions(). There is therefore no need for > the driver to communicate support for this extension. > Replace the driver capability flag with ::dummy_true. > > Sig

Re: [Mesa-dev] [RFC 09/21] mesa: Generate a helper function for each extension

On Fri 23 Oct 2015, Nanley Chery wrote: > On Thu, Oct 22, 2015 at 11:30 AM, Chad Versace > wrote: > > > On Mon 19 Oct 2015, Nanley Chery wrote: > > > From: Nanley Chery > > > > > > Generate functions which determine if an extension is supported in the > > > current context. Initially, enums were

Re: [Mesa-dev] [PATCH] r600: Fix special negative immediate constants when using ABS modifier.

Hi Ivan, On 25.10.2015 02:00, Ivan Kalvachev wrote: Some constants (like 1.0 and 0.5) could be inlined as immediate inputs without using their literal value. The r600_bytecode_special_constants() function emulates the negative of these constants by using NEG modifier. However some shaders defin

Re: [Mesa-dev] [PATCH 5/7] nir: support to clone shaders (v2)

On Mon, Oct 26, 2015 at 2:44 PM, Jason Ekstrand wrote: > On Mon, Oct 26, 2015 at 8:27 AM, Rob Clark wrote: >> Signed-off-by: Rob Clark >> --- >> src/glsl/Makefile.sources | 1 + >> src/glsl/nir/nir.c| 8 + >> src/glsl/nir/nir.h| 2 + >> src/glsl/nir/nir_clone.c | 949 >>

Re: [Mesa-dev] [PATCH v6 2/2] mesa/teximage: accept ASTC formats for 3D texture specification

On Mon, Oct 26, 2015 at 11:53 AM, Roland Scheidegger wrote: > Am 26.10.2015 um 19:31 schrieb Ilia Mirkin: > > On Mon, Oct 26, 2015 at 2:15 PM, Neil Roberts > wrote: > >> Nanley Chery writes: > >> > >>> + /* Throw an INVALID_OPERATION error if the target is > >>> + * TEXTURE_CUBE_MAP_

Re: [Mesa-dev] [PATCH v6 2/2] mesa/teximage: accept ASTC formats for 3D texture specification

On Mon, Oct 26, 2015 at 11:15 AM, Neil Roberts wrote: > Nanley Chery writes: > > > + /* Throw an INVALID_OPERATION error if the target is > > + * TEXTURE_CUBE_MAP_ARRAY and the format is not ASTC. > > + */ > > + if (target_can_be_compresed && > > + ctx->Extensions.

Re: [Mesa-dev] [PATCH 0/2] Nir: Allow CSE of SSBO loads

On Mon, Oct 26, 2015 at 12:19 AM, Iago Toral wrote: > On Fri, 2015-10-23 at 09:26 -0700, Jason Ekstrand wrote: >> On Thu, Oct 22, 2015 at 11:13 PM, Iago Toral wrote: >> > On Thu, 2015-10-22 at 09:09 -0700, Jason Ekstrand wrote: >> >> On Thu, Oct 22, 2015 at 4:21 AM, Iago Toral Quiroga >> >> wro

Re: [Mesa-dev] [PATCH 4/7] nir: add couple array length fields

On Mon, Oct 26, 2015 at 11:06 AM, Rob Clark wrote: > On Mon, Oct 26, 2015 at 1:52 PM, Jason Ekstrand wrote: >> On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> This will simplify things somewhat in clone. >>> >>> Signed-off-by: Rob Clark >>> --- >>> src/glsl/nir/

Re: [Mesa-dev] [PATCH v6 2/2] mesa/teximage: accept ASTC formats for 3D texture specification

Am 26.10.2015 um 19:31 schrieb Ilia Mirkin: > On Mon, Oct 26, 2015 at 2:15 PM, Neil Roberts wrote: >> Nanley Chery writes: >> >>> + /* Throw an INVALID_OPERATION error if the target is >>> + * TEXTURE_CUBE_MAP_ARRAY and the format is not ASTC. >>> + */ >>> + if (target_can_b

Re: [Mesa-dev] [PATCH 5/7] nir: support to clone shaders (v2)

On Mon, Oct 26, 2015 at 8:27 AM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/nir.c| 8 + > src/glsl/nir/nir.h| 2 + > src/glsl/nir/nir_clone.c | 949 > ++ > 4 files changed

Re: [Mesa-dev] [PATCH] winsys/amdgpu: remove the dcc_enable surface flag

On 26.10.2015 11:41, Marek Olšák wrote: From: Marek Olšák dcc_size is sufficient and doesn't need a further comment in my opinion. --- src/gallium/drivers/radeon/r600_texture.c | 3 +-- src/gallium/drivers/radeon/radeon_winsys.h | 1 - src/gallium/winsys/amdgpu/drm/amdgpu_surface

Re: [Mesa-dev] [PATCH v6 2/2] mesa/teximage: accept ASTC formats for 3D texture specification

On Mon, Oct 26, 2015 at 2:15 PM, Neil Roberts wrote: > Nanley Chery writes: > >> + /* Throw an INVALID_OPERATION error if the target is >> + * TEXTURE_CUBE_MAP_ARRAY and the format is not ASTC. >> + */ >> + if (target_can_be_compresed && >> + ctx->Extensions.KHR_tex

Re: [Mesa-dev] [PATCH v6 2/2] mesa/teximage: accept ASTC formats for 3D texture specification

Nanley Chery writes: > + /* Throw an INVALID_OPERATION error if the target is > + * TEXTURE_CUBE_MAP_ARRAY and the format is not ASTC. > + */ > + if (target_can_be_compresed && > + ctx->Extensions.KHR_texture_compression_astc_ldr && > + layout != MESA_FORMA

Re: [Mesa-dev] [PATCH 4.5/7] nir: add list_head to nir_src::ssa

On Mon, Oct 26, 2015 at 2:01 PM, Jason Ekstrand wrote: > On Mon, Oct 26, 2015 at 8:26 AM, Rob Clark wrote: >> From: Rob Clark >> >> This will be used by clone. Possibly useful elsewhere. The list link >> will only be valid in ssa case, it fits in the padding in the union >> left from the large

Re: [Mesa-dev] [PATCH 3/5] glsl: Mark gl_ViewportIndex and gl_Layer varyings as flat.

On Mon, Oct 26, 2015 at 2:03 PM, Kenneth Graunke wrote: > Integer varyings need to be flat qualified - all others were already. > I think we just missed this. Presumably some hardware passes this via > sideband and ignores attribute interpolation, so no one has noticed. > > Signed-off-by: Kenneth

Re: [Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

On Mon, Oct 26, 2015 at 1:56 PM, Jason Ekstrand wrote: > On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: >> Otherwise, passing -1 gets you: >> >> error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] > > Yeah, I've never really liked that. Another option (which I think

[Mesa-dev] [PATCH] i965: Set correct field for indirect align16 addrimm.

This has been wrong since the initial import of the i965 driver. --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index ebd811f..df48590 100644 --- a/sr

Re: [Mesa-dev] [PATCH 4/7] nir: add couple array length fields

On Mon, Oct 26, 2015 at 1:52 PM, Jason Ekstrand wrote: > On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: >> From: Rob Clark >> >> This will simplify things somewhat in clone. >> >> Signed-off-by: Rob Clark >> --- >> src/glsl/nir/glsl_to_nir.cpp | 6 ++ >> src/glsl/nir/nir.h |

[Mesa-dev] [PATCH 4/5] i965: Make calculate_attr_overrides return the URB read offset.

Traditionally, we've hardcoded "URB Entry Read Offset" to 1 (which represents 2 vec4 varying slots) to skip over the 8 DWord VUE header. In order to support ARB_fragment_layer_viewport, we'll need to read from that header. This patch adds the basic plumbing necessary to calculate a value dynamica

[Mesa-dev] [PATCH 1/5] i965: Update stale comment about unused VUE map slots.

I changed this from COUNT to PAD in commit 268008f98c3810b9f276df985dc93ef. Signed-off-by: Kenneth Graunke Cc: Chris Forbes --- src/mesa/drivers/dri/i965/brw_compiler.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src/mesa/dr

[Mesa-dev] [PATCH 5/5] i965: Implement ARB_fragment_layer_viewport.

Normally, we could read gl_Layer from bits 26:16 of R0.0. However, the specification requires that bogus out-of-range 32-bit values written by previous stages need to appear in the fragment shader as-written. Instead, we pass in the full 32-bit value from the VUE header as an extra flat-shaded va

[Mesa-dev] [PATCH 2/5] i965/fs: Properly check for PAD in fragment shaders with > 16 varyings.

Commit 268008f98c3810b9f276df985dc93efc0c49f33e changed unused VUE map slots to be initialized with BRW_VARYING_SLOT_PAD, not COUNT. I missed updating this. It also means that commit message was wrong, as some code *did* rely slots being initialized to COUNT. This may fix a bug with SSO programs

[Mesa-dev] [PATCH 3/5] glsl: Mark gl_ViewportIndex and gl_Layer varyings as flat.

Integer varyings need to be flat qualified - all others were already. I think we just missed this. Presumably some hardware passes this via sideband and ignores attribute interpolation, so no one has noticed. Signed-off-by: Kenneth Graunke Cc: Chris Forbes --- src/glsl/builtin_variables.cpp |

Re: [Mesa-dev] [PATCH 4.5/7] nir: add list_head to nir_src::ssa

On Mon, Oct 26, 2015 at 8:26 AM, Rob Clark wrote: > From: Rob Clark > > This will be used by clone. Possibly useful elsewhere. The list link > will only be valid in ssa case, it fits in the padding in the union > left from the larger nir_reg_src. We already have a use_link. It seems perfectly

Re: [Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: > Otherwise, passing -1 gets you: > > error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] Yeah, I've never really liked that. Another option (which I think I'd marginally prefer) would be to make nir_lower_io take a bitf

Re: [Mesa-dev] [PATCH 2/7] nir: some small cleanups

On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: > The various cf nodes all get allocated w/ shader as their ralloc_parent, > so lets make this more explicit. Plus couple other corrections/ > clarifications. > > Signed-off-by: Rob Clark Reviewed-by: Jason Ekstrand > --- > src/glsl/nir/nir.

Re: [Mesa-dev] [PATCH 4/7] nir: add couple array length fields

On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: > From: Rob Clark > > This will simplify things somewhat in clone. > > Signed-off-by: Rob Clark > --- > src/glsl/nir/glsl_to_nir.cpp | 6 ++ > src/glsl/nir/nir.h | 11 +++ > 2 files changed, 17 insertions(+) > > diff --gi

Re: [Mesa-dev] [RFC 18/21] mesa/extensions: Remove extra memsets on gl_extensions

On 23 October 2015 at 19:46, Jordan Justen wrote: > On 2015-10-22 03:32:58, Emil Velikov wrote: >> On 19 October 2015 at 23:44, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > Aside from those modified in this commit, all gl_extensions structs are >> > zero-initialized by default. There is

[Mesa-dev] [Bug 92645] kodi vdpau interop fails since mesa, meta: move gl_texture_object::TargetIndex initializations

https://bugs.freedesktop.org/show_bug.cgi?id=92645 Lee Donaghy changed: What|Removed |Added CC||lee295...@gmail.com -- You are receiving

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 86720, which changed state. Bug 86720 Summary: [radeon] Europa Universalis 4 freezing during game start (10.3.3+, still broken on 11.0.2) https://bugs.freedesktop.org/show_bug.cgi?id=86720 What|Removed

Re: [Mesa-dev] [PATCH] clover: fix tgsi compiler crash with invalid src

Serge Martin writes: > --- > src/gallium/state_trackers/clover/tgsi/compiler.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/gallium/state_trackers/clover/tgsi/compiler.cpp > b/src/gallium/state_trackers/clover/tgsi/compiler.cpp > index 54cb747..4d05666 100644 > --- a/src/

[Mesa-dev] [PATCH] clover: fix tgsi compiler crash with invalid src

--- src/gallium/state_trackers/clover/tgsi/compiler.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/clover/tgsi/compiler.cpp b/src/gallium/state_trackers/clover/tgsi/compiler.cpp index 54cb747..4d05666 100644 --- a/src/gallium/state_trackers/clover/tgsi/com

Re: [Mesa-dev] [PATCH] gallivm: disable f16c when not using AVX

Am 26.10.2015 um 16:33 schrieb Jose Fonseca: > On 26/10/15 14:58, Roland Scheidegger wrote: >> Am 26.10.2015 um 10:02 schrieb Jose Fonseca: >>> On 23/10/15 22:26, srol...@vmware.com wrote: From: Roland Scheidegger f16c intrinsic can only be emitted when AVX is used. So when we

Re: [Mesa-dev] [PATCH 5/7] nir: support to clone shaders (v2)

On Mon, Oct 26, 2015 at 11:27 AM, Rob Clark wrote: > Signed-off-by: Rob Clark fyi, branch which is using this at: https://github.com/freedreno/mesa/commits/wip-nir At this point it seems to be surviving piglit runs w/ NIR_TEST_CLONE=1 w/ freedreno. I did briefly try piglit runs for i965, but

Re: [Mesa-dev] [PATCH] gallivm: disable f16c when not using AVX

On 26/10/15 14:58, Roland Scheidegger wrote: Am 26.10.2015 um 10:02 schrieb Jose Fonseca: On 23/10/15 22:26, srol...@vmware.com wrote: From: Roland Scheidegger f16c intrinsic can only be emitted when AVX is used. So when we disable AVX due to forcing 128bit vectors we must not use this intrin

[Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes (v2)

From: Rob Clark Convenient place to put in some extra sanity checking, without making things messy for the drivers running the passes. v2: don't use GNU C ({}) extension Signed-off-by: Rob Clark --- src/glsl/nir/nir.h | 38 +++ src/mesa/drivers/dri/i965/brw_nir.c | 1

[Mesa-dev] [PATCH 4.5/7] nir: add list_head to nir_src::ssa

From: Rob Clark This will be used by clone. Possibly useful elsewhere. The list link will only be valid in ssa case, it fits in the padding in the union left from the larger nir_reg_src. Signed-off-by: Rob Clark --- src/glsl/nir/nir.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(

[Mesa-dev] [PATCH 5/7] nir: support to clone shaders (v2)

Signed-off-by: Rob Clark --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.c| 8 + src/glsl/nir/nir.h| 2 + src/glsl/nir/nir_clone.c | 949 ++ 4 files changed, 960 insertions(+) create mode 100644 src/glsl/nir/nir_clone.c di

Re: [Mesa-dev] [PATCH] gallivm: disable f16c when not using AVX

Am 26.10.2015 um 10:02 schrieb Jose Fonseca: > On 23/10/15 22:26, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> f16c intrinsic can only be emitted when AVX is used. So when we >> disable AVX >> due to forcing 128bit vectors we must not use this intrinsic >> (depending on >> llvm vers

Re: [Mesa-dev] [PATCH] st/va: pass picture desc to begin and decode

Done, but you should apply for an account. Best regards, Christian. On 26.10.2015 13:46, Julien Isorce wrote: Hi Christian, Would you mind to push this patch ? Thx Cheers Julien On 23 October 2015 at 14:33, Christian König > wrote: On 23.10.2015 14:25, J

Re: [Mesa-dev] [PATCH 2/2] glsl: keep track of intra-stage indices for atomics

Timothy Arceri writes: > This is more optimal as it means we no longer have to upload the same set > of Atomic Buffer Object surfaces to all stages in the program. > > This also fixes a bug where since commit c0cd5b var->data.binding was > being used as a replacement for atomic buffer index, but

Re: [Mesa-dev] [PATCH 2/2] glsl: keep track of intra-stage indices for atomics

Hello Timothy, I don't see anything wrong with this patch but I needed to review older emails [0] to have a better understanding of why you were using an intra-stage index. So, from my side, I give my R-b but with a minor change (see below): Reviewed-by: Samuel Iglesias Gonsálvez Maybe you

[Mesa-dev] [Bug 92278] Black screen in War Thunder

https://bugs.freedesktop.org/show_bug.cgi?id=92278 Tapani Pälli changed: What|Removed |Added Attachment #119191|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH] st/va: pass picture desc to begin and decode

Hi Christian, Would you mind to push this patch ? Thx Cheers Julien On 23 October 2015 at 14:33, Christian König wrote: > On 23.10.2015 14:25, Julien Isorce wrote: > >> At least vl_mpeg12_decoder uses the picture >> desc in begin_frame and decode_bitstream. >> >> https://bugs.freedesktop.org/s

Re: [Mesa-dev] [PATCH v2 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

On 25 October 2015 at 21:38, Samuel Pitoiset wrote: > > Do you need someone to push this patch? > Yes please ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 1/2] gallium: add renderonly driver

Hi Lucas, On 19 October 2015 at 10:25, Lucas Stach wrote: > Am Sonntag, den 18.10.2015, 21:41 +0200 schrieb Christian Gmeiner: >> 2015-10-16 15:31 GMT+02:00 Thierry Reding : >> > Gallium driver is rather complicated, but that's due to the fact that >> > graphics drivers are complex beasts. >> > >

Re: [Mesa-dev] [PATCH 6/9] i965: Add annotation_insert_error() and support for printing errors.

On Wed, Oct 21, 2015 at 03:58:14PM -0700, Matt Turner wrote: > Will allow annotations to contain error messages (indicating an > instruction violates a rule for instance) that are printed after the > disassembly of the block. > --- > src/mesa/drivers/dri/i965/intel_asm_annotation.c | 60 > +++

Re: [Mesa-dev] [PATCH 5/9] i965: Combine assembly annotations if possible.

On Wed, Oct 21, 2015 at 03:58:13PM -0700, Matt Turner wrote: > Often annotations are identical between sets of consecutive > instructions. We can perhaps avoid some memory allocations by reusing > the previous annotation. > --- > src/mesa/drivers/dri/i965/intel_asm_annotation.c | 19 ++

Re: [Mesa-dev] [PATCH 4/9] i965: Set annotation_info's mem_ctx.

On Wed, Oct 21, 2015 at 03:58:12PM -0700, Matt Turner wrote: > It was being memset to 0 previously. > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 2 +- > src/mesa/drivers/dri/i965/intel_asm_annotation.c | 3 +++ > 3 files chan

Re: [Mesa-dev] [PATCH v2] main: Remove interface block array index for doing the name comparison

On 10/26/2015 12:45 PM, Samuel Iglesias Gonsálvez wrote: On 26/10/15 11:38, Samuel Iglesias Gonsalvez wrote: From ARB_program_query_interface spec: "uint GetProgramResourceIndex(uint program, enum programInterface, const char *name); [...] If exactl

[Mesa-dev] [PATCH v2] mesa: Draw indirect is not allowed when xfb is active and unpaused

From: Marta Lofstedt OpenGL ES 3.1 specification, section 10.5: "An INVALID_OPERATION error is generated if transform feedback is active and not paused." Signed-off-by: Marta Lofstedt --- src/mesa/main/api_validate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH v2] main: Remove interface block array index for doing the name comparison

On 26/10/15 11:38, Samuel Iglesias Gonsalvez wrote: > From ARB_program_query_interface spec: > > "uint GetProgramResourceIndex(uint program, enum programInterface, >const char *name); > [...] > If exactly matches the name string of one of the active resourc

[Mesa-dev] [PATCH] winsys/amdgpu: remove the dcc_enable surface flag

From: Marek Olšák dcc_size is sufficient and doesn't need a further comment in my opinion. --- src/gallium/drivers/radeon/r600_texture.c | 3 +-- src/gallium/drivers/radeon/radeon_winsys.h | 1 - src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 13 ++--- 3 files changed, 7 ins

[Mesa-dev] [PATCH v2] main: Remove interface block array index for doing the name comparison

From ARB_program_query_interface spec: "uint GetProgramResourceIndex(uint program, enum programInterface, const char *name); [...] If exactly matches the name string of one of the active resources for , the index of the matched resource is returned. Addition

Re: [Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

On 10/26/2015 12:11 PM, Timothy Arceri wrote: On Mon, 2015-10-26 at 11:22 +0200, Tapani Pälli wrote: Patch adds additional check to make sure we don't return locations for structures or arrays of structures. From page 79 of the OpenGL 4.2 spec: "A valid name cannot be a structure, an ar

[Mesa-dev] [PATCH v2] mesa: Draw Indirect return wrong error code on unalinged

From: Marta Lofstedt From OpenGL 4.4 specification, section 10.4 and Open GL Es 3.1 section 10.5: "An INVALID_VALUE error is generated if indirect is not a multiple of the size, in basic machine units, of uint." However, the current code follow the ARB_draw_indirect: https://www.opengl.org/regis

Re: [Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

On Mon, 2015-10-26 at 11:22 +0200, Tapani Pälli wrote: > Patch adds additional check to make sure we don't return locations > for > structures or arrays of structures. > > From page 79 of the OpenGL 4.2 spec: > "A valid name cannot be a structure, an array of structures, or > any > portion

Re: [Mesa-dev] [PATCH 2/3] radeonsi: properly check if DCC is enabled and allocated

On Sat, Oct 24, 2015 at 11:13 PM, Nicolai Hähnle wrote: > On 24.10.2015 17:49, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_texture.c | 2 +- >> src/gallium/drivers/radeonsi/cik_sdma.c | 2 +- >> src/gallium/drivers/radeonsi/si_blit.c| 6 +++---

[Mesa-dev] [PATCH v2] mesa: Draw indirect is not allowed if the default VAO is bound.

From: Marta Lofstedt From OpenGL ES 3.1 specification, section 10.5: "DrawArraysIndirect requires that all data sourced for the command, including the DrawArraysIndirectCommand structure, be in buffer objects, and may not be called when the default vertex array object is bound." Signed-off-by:

Re: [Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

Reviewed-by: Samuel Iglesias Gonsálvez Thanks! Sam On 26/10/15 10:22, Tapani Pälli wrote: > Patch adds additional check to make sure we don't return locations for > structures or arrays of structures. > > From page 79 of the OpenGL 4.2 spec: > "A valid name cannot be a structure, an array

[Mesa-dev] [Bug 92629] lp_bld_debug.cpp:141: undefined reference to `llvm::sys::getProcessTriple()'

https://bugs.freedesktop.org/show_bug.cgi?id=92629 Jose Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] mesa: add additional checks for uniform location query

Patch adds additional check to make sure we don't return locations for structures or arrays of structures. From page 79 of the OpenGL 4.2 spec: "A valid name cannot be a structure, an array of structures, or any portion of a single vector or a matrix." No Piglit or CTS regressions observe

Re: [Mesa-dev] [PATCH] gallivm: disable f16c when not using AVX

On 23/10/15 22:26, srol...@vmware.com wrote: From: Roland Scheidegger f16c intrinsic can only be emitted when AVX is used. So when we disable AVX due to forcing 128bit vectors we must not use this intrinsic (depending on llvm version, this worked previously because llvm used AVX even when we di

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow copying between compatible compressed and uncompressed formats

On 26.10.2015 02:25, Marek Olšák wrote: > From: Marek Olšák > > which is where a block in src maps to a pixel in dst and vice versa. > e.g. DXT1 <-> R32G32_UINT > DXT5 <-> R32G32B32A32_UINT > --- > src/gallium/drivers/radeonsi/si_blit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

[Mesa-dev] [Bug 92645] kodi vdpau interop fails since mesa, meta: move gl_texture_object::TargetIndex initializations

https://bugs.freedesktop.org/show_bug.cgi?id=92645 Michel Dänzer changed: What|Removed |Added CC||bri...@vmware.com Component|Dri

Re: [Mesa-dev] [PATCH 0/2] Nir: Allow CSE of SSBO loads

On Fri, 2015-10-23 at 09:26 -0700, Jason Ekstrand wrote: > On Thu, Oct 22, 2015 at 11:13 PM, Iago Toral wrote: > > On Thu, 2015-10-22 at 09:09 -0700, Jason Ekstrand wrote: > >> On Thu, Oct 22, 2015 at 4:21 AM, Iago Toral Quiroga > >> wrote: > >> > I implemented this first as a separate optimizat