Fixes following failing dEQP test:
dEQP-GLES3.functional.fbo.api.attachment_query_empty_fbo
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92649
Cc: "11.0"
---
src/mesa/main/fbobject.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=92687
Bug ID: 92687
Summary: Add support for EXT_internalformat_query2
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
Status: ASSIGNED
Severity: nor
Hello,
This is an announcement that a few folks at Igalia team are planning to
work on adding support for EXT_internalformat_query2 extension to Mesa.
If somebody had started work on this already, or has any input that is
relevant to the implementation, we would be very thankful to hear about it.
https://bugs.freedesktop.org/show_bug.cgi?id=91596
--- Comment #23 from Chih-Wei Huang ---
(In reply to Emil Velikov from comment #15)
> (In reply to Chih-Wei Huang from comment #11)
> > Mesa still doesn't support PIXEL_FORMAT_RGBA_?
>
> It should, depending on how exactly you define the for
Presumably ARB_internalformat_query2?
On Tue, Oct 27, 2015 at 9:31 PM, Eduardo Lima Mitev
wrote:
> Hello,
>
> This is an announcement that a few folks at Igalia team are planning to
> work on adding support for EXT_internalformat_query2 extension to Mesa.
>
> If somebody had started work on this
On 25 October 2015 at 21:56, Samuel Pitoiset
wrote:
>
>
> On 10/22/2015 01:16 AM, Julien Isorce wrote:
>
>> The real fix is in nouveau_drm_winsys.c by setting dev to 0.
>> Which means dev's ownership has been passed to previous call.
>> Other changes are there to be consistent with what the
>> sc
This patch prevents to call nouveau_device_del twice on the same device.
Encountered this case when nvc0_screen_create fails with:
nvc0_screen_create:717 - Error allocating PGRAPH context for M2MF: -16
https://bugs.freedesktop.org/show_bug.cgi?id=70354
Signed-off-by: Julien Isorce
---
src/gall
The maximum number of active variables for shader storage blocks should
take into account the specific rules for shader storage blocks, i.e. for
an active shader storage block member declared as an array, an entry
will be generated only for the first array element, regardless of its type.
Fixes 3
On 25.10.2015 18:25, Marek Olšák wrote:
+/**
+ * Handle complex format conversions using 2 blits with a temporary texture
+ * in between, e.g. blitting from B10G10R10A2 to G16R16.
+ *
+ * This example is implemented this way:
+ * 1) First, blit from B10G10R10A2 to R10G10B10A2, which is canonical,
What about this one http://hastebin.com/uboruxicof.coffee ?
This patch is loosely based on your first attempt, except that I removed
the call
to nouveau_device_del() in nouveau_drm_screen_create().
On 27/10/2015 09:52, Julien Isorce wrote:
This patch prevents to call nouveau_device_del twice
https://bugs.freedesktop.org/show_bug.cgi?id=92687
Alejandro Piñeiro (freenode IRC: apinheiro) changed:
What|Removed |Added
Summary|Add support for |Add support
Reviewed-by: Samuel Iglesias Gonsálvez
On 27/10/15 08:11, Tapani Pälli wrote:
> Fixes following failing dEQP test:
>dEQP-GLES3.functional.fbo.api.attachment_query_empty_fbo
>
> Signed-off-by: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92649
> Cc: "11.0"
> ---
>
On Tue, Oct 27, 2015 at 4:26 AM, Ilia Mirkin wrote:
>> +
>> +static void
>> +copy_image(struct pipe_context *pipe,
>> + struct pipe_resource *dst,
>> + unsigned dst_level,
>> + unsigned dstx, unsigned dsty, unsigned dstz,
>> + struct pipe_resource *src,
>> +
---
src/mesa/drivers/dri/i965/brw_nir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_nir.c
b/src/mesa/drivers/dri/i965/brw_nir.c
index 11f1113..dd3b06c 100644
--- a/src/mesa/drivers/dri/i965/brw_nir.c
+++ b/src/mesa/drivers/dri/i965/brw_nir.c
@@ -170,6 +170,
---
src/glsl/nir/nir_opt_load_combine.c | 107 +++-
1 file changed, 105 insertions(+), 2 deletions(-)
diff --git a/src/glsl/nir/nir_opt_load_combine.c
b/src/glsl/nir/nir_opt_load_combine.c
index 926b1ab..effba13 100644
--- a/src/glsl/nir/nir_opt_load_combine.c
+++
For now, this pass can handle ssbo load combines within the same block.
This is useful, for example, to make code such as this:
buffer SSBO {
mat4 sm4;
};
uniform mat4 um4;
void main() {
sm4 *= um4;
}
go from 16 SSBO loads down to only 4.
---
src/glsl/Makefile.sources | 1 +
We need this so we can configure different behaviors for passes that
cannot deal with side-effectful instructions (CSE) and passes that can
(we will add a load-combine pass shortly).
For now, when allow_loads is true, we let the instruction set rewrite
SSBO loads.
---
src/glsl/nir/nir_instr_set.c
This follows the load-combine approach suggested by Connor and Jason
in this thread:
http://lists.freedesktop.org/archives/mesa-dev/2015-October/098052.html
The pass works on local blocks only and supports rewriting loads with
previous stores too. Only supports SSBO load/store operations at the
m
On 26.10.2015 02:25, Marek Olšák wrote:
>
> +/**
> + * Handle complex format conversions using 2 blits with a temporary texture
> + * in between, e.g. blitting from B10G10R10A2 to G16R16.
> + *
> + * This example is implemented this way:
> + * 1) First, blit from B10G10R10A2 to R10G10B10A2, which
Hi! Chris,
On mar, 2015-10-27 at 21:45 +1300, Chris Forbes wrote:
> Presumably ARB_internalformat_query2?
Eduardo meant ARB_internalformat_query2, indeed.
> On Tue, Oct 27, 2015 at 9:31 PM, Eduardo Lima Mitev
> wrote:
> Hello,
>
> This is an announcement that a few folk
On Tue, Oct 27, 2015 at 10:33 AM, Michel Dänzer wrote:
> On 26.10.2015 02:25, Marek Olšák wrote:
>>
>> +/**
>> + * Handle complex format conversions using 2 blits with a temporary texture
>> + * in between, e.g. blitting from B10G10R10A2 to G16R16.
>> + *
>> + * This example is implemented this wa
Looks good though what happened to the del around if (!oclass) in
nv30_screen_create ?
Also it seems to fix the other problem around else if (dupfd) which was not
closed on failure.
On 27 October 2015 at 09:10, samuel.pitoiset
wrote:
> What about this one http://hastebin.com/uboruxicof.coffee ?
On 27/10/2015 11:08, Julien Isorce wrote:
Looks good though what happened to the del around if (!oclass) in
nv30_screen_create ?
Yeah, good catch. I think we could use FAIL_SCREEN_INIT() there.
I'll send a new patch with this fix.
Also it seems to fix the other problem around else if (dupfd
https://bugs.freedesktop.org/show_bug.cgi?id=92645
--- Comment #1 from Marek Olšák ---
Created attachment 119221
--> https://bugs.freedesktop.org/attachment.cgi?id=119221&action=edit
possible fix
Could you please test this patch?
--
You are receiving this mail because:
You are the QA Contact
On 22 October 2015 at 00:16, Julien Isorce wrote:
> The real fix is in nouveau_drm_winsys.c by setting dev to 0.
> Which means dev's ownership has been passed to previous call.
> Other changes are there to be consistent with what the
> screen_create functions already do on errors.
>
> Encountered
On 27/10/2015 11:37, Emil Velikov wrote:
On 22 October 2015 at 00:16, Julien Isorce wrote:
The real fix is in nouveau_drm_winsys.c by setting dev to 0.
Which means dev's ownership has been passed to previous call.
Other changes are there to be consistent with what the
screen_create functions
Reviewed-by: Tapani Pälli
On 10/26/2015 11:58 AM, Marta Lofstedt wrote:
From: Marta Lofstedt
From OpenGL ES 3.1 specification, section 10.5:
"DrawArraysIndirect requires that all data sourced for the
command, including the DrawArraysIndirectCommand
structure, be in buffer objects, and may
https://bugs.freedesktop.org/show_bug.cgi?id=92645
--- Comment #2 from Andy Furniss ---
(In reply to Marek Olšák from comment #1)
> Created attachment 119221 [details] [review]
> possible fix
>
> Could you please test this patch?
Working OK with the patch, thanks.
--
You are receiving this ma
Reviewed-by: Iago Toral Quiroga
On Sat, 2015-10-24 at 13:20 -0700, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp
> b/src/mesa/drivers/dri/i965/brw_vec4
This makes sure that user is still able to query properties about
variables that have gotten removed by opt_dead_builtin_varyings pass.
Fixes following OpenGL ES 3.1 test:
ES31-CTS.program_interface_query.output-layout
No Piglit regressions.
Signed-off-by: Tapani Pälli
---
src/glsl/linker.c
This is required to store information about fragdata arrays, currently
these variables get lost and cannot be retrieved later in sensible way
for program interface queries. List will be utilized by next patch.
Patch also modifies opt_dead_builtin_varyings pass to build list when
lowering fragdata
From: Marek Olšák
This is required since 7d7dd1871174905dfdd3ca874a09d9.
---
src/mesa/main/vdpau.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/main/vdpau.c b/src/mesa/main/vdpau.c
index 0efa56e..0c000c4 100644
--- a/src/mesa/main/vdpau.c
+++ b/src/mesa/main/vdpau.c
@@ -375,6
Reviewed-by: Tapani Pälli
On 10/27/2015 11:08 AM, Samuel Iglesias Gonsalvez wrote:
The maximum number of active variables for shader storage blocks should
take into account the specific rules for shader storage blocks, i.e. for
an active shader storage block member declared as an array, an entr
On 27 October 2015 at 10:50, samuel.pitoiset wrote:
> On 27/10/2015 11:37, Emil Velikov wrote:
>>
>> On 22 October 2015 at 00:16, Julien Isorce
>> wrote:
>>>
>>> The real fix is in nouveau_drm_winsys.c by setting dev to 0.
>>> Which means dev's ownership has been passed to previous call.
>>> Othe
https://bugs.freedesktop.org/show_bug.cgi?id=69589
Tapani Pälli changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
These helpers are ran for same case the same loop. Here joined
their operation so the loop is ran just once. Also fixed
out-of-memory condition here.
v2: Make the loop simpler to read as per Tapani's suggestion
Signed-off-by: Juha-Pekka Heikkila
---
src/glsl/linker.cpp | 190 +++
Hi Marek,
On 27 October 2015 at 11:31, Marek Olšák wrote:
> From: Marek Olšák
>
> This is required since 7d7dd1871174905dfdd3ca874a09d9.
Can you add the bugzilla tag please.
I'd suspect many of us are not fluent in gl-vdpau interop can you
please throw in a small comment. Thinking about the fol
On Tue, Oct 27, 2015 at 01:18:42PM +0200, Tapani P?lli wrote:
> This makes sure that user is still able to query properties about
> variables that have gotten removed by opt_dead_builtin_varyings pass.
>
> Fixes following OpenGL ES 3.1 test:
>ES31-CTS.program_interface_query.output-layout
>
>
On Tue, Oct 27, 2015 at 10:28:58AM +0100, Iago Toral Quiroga wrote:
> We need this so we can configure different behaviors for passes that
> cannot deal with side-effectful instructions (CSE) and passes that can
> (we will add a load-combine pass shortly).
>
> For now, when allow_loads is true, we
On 27.10.2015 13:16, Emil Velikov wrote:
Hi Marek,
On 27 October 2015 at 11:31, Marek Olšák wrote:
From: Marek Olšák
This is required since 7d7dd1871174905dfdd3ca874a09d9.
Can you add the bugzilla tag please.
I'd suspect many of us are not fluent in gl-vdpau interop can you
please throw in
Reviewed-by: Marta Lofstedt
> -Original Message-
> From: Palli, Tapani
> Sent: Tuesday, October 27, 2015 12:19 PM
> To: mesa-dev@lists.freedesktop.org
> Cc: Lofstedt, Marta; Palli, Tapani
> Subject: [PATCH 1/2] mesa: add fragdata_arrays list to gl_shader
>
> This is required to store inf
On 27/10/2015 12:52, Emil Velikov wrote:
On 27 October 2015 at 10:50, samuel.pitoiset wrote:
On 27/10/2015 11:37, Emil Velikov wrote:
On 22 October 2015 at 00:16, Julien Isorce
wrote:
The real fix is in nouveau_drm_winsys.c by setting dev to 0.
Which means dev's ownership has been passed t
Reviewed-by: Samuel Iglesias Gonsálvez
On 27/10/15 12:55, Juha-Pekka Heikkila wrote:
> These helpers are ran for same case the same loop. Here joined
> their operation so the loop is ran just once. Also fixed
> out-of-memory condition here.
>
> v2: Make the loop simpler to read as per Tapani's s
On Fri, Oct 23, 2015 at 06:25:55PM -0700, Vivek Kasireddy wrote:
> On Fri, 23 Oct 2015 15:29:08 +0300
> Ville Syrjälä wrote:
>
> > On Fri, Oct 23, 2015 at 12:18:39PM +0900, Michel Dänzer wrote:
> > > On 23.10.2015 10:44, Vivek Kasireddy wrote:
> > > > For certain platforms that support rotated sc
Francisco Jerez writes:
> Abdiel Janulgue writes:
>
>> Use the gather table generated from the uniform uploads and
>> ir_binop_ubo_load to gather and pack the constants to the gather pool.
>>
>> Note that the 3DSTATE_CONSTANT_* packet now refers to the gather
>> pool generated by the resource st
Reviewed-by: Marta Lofstedt
> -Original Message-
> From: Palli, Tapani
> Sent: Tuesday, October 27, 2015 12:19 PM
> To: mesa-dev@lists.freedesktop.org
> Cc: Lofstedt, Marta; Palli, Tapani
> Subject: [PATCH 2/2] glsl: add fragdata arrays to program resource list
>
> This makes sure that u
Commit 4565b6f did not update the basename match's check for
the case that string would exactly match the name of the
variable if the suffix "[0]" were appended to it.
Fixes two dEQP-GLES31 tests:
dEQP-GLES31.functional.program_interface_query.shader_storage_block.resource_list.block_array
dEQP-G
Sorry for causing this regression. Thanks for fixing it. Question below...
On 10/27/2015 05:31 AM, Marek Olšák wrote:
From: Marek Olšák
This is required since 7d7dd1871174905dfdd3ca874a09d9.
---
src/mesa/main/vdpau.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/main/vdp
On 10/27/2015 12:11 AM, Tapani Pälli wrote:
> Fixes following failing dEQP test:
>dEQP-GLES3.functional.fbo.api.attachment_query_empty_fbo
>
> Signed-off-by: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92649
> Cc: "11.0"
> ---
> src/mesa/main/fbobject.c | 5 +++--
>
https://bugs.freedesktop.org/show_bug.cgi?id=92645
Marek Olšák changed:
What|Removed |Added
Attachment #119221|0 |1
is obsolete|
On Fri, Oct 23, 2015 at 1:28 AM, Nicolai Hähnle wrote:
> (This is an alternative to my previous patch, "mesa: clamp MaxLevel for
> immutable textures at initialization"; this patch has no opinion about
> how the spec should be interpreted.)
>
> Without the clamping by NumLevels, the state tracker
Signed-off-by: Alex Deucher
---
lib/Target/AMDGPU/Processors.td | 4
1 file changed, 4 insertions(+)
diff --git a/lib/Target/AMDGPU/Processors.td b/lib/Target/AMDGPU/Processors.td
index d9a0723..a1584a2 100644
--- a/lib/Target/AMDGPU/Processors.td
+++ b/lib/Target/AMDGPU/Processors.td
@@ -1
https://bugs.freedesktop.org/show_bug.cgi?id=92645
--- Comment #4 from Andy Furniss ---
(In reply to Marek Olšák from comment #3)
> Created attachment 119225 [details] [review]
> fix 2
>
> The first fix was not completely correct. Would you please test this one?
> Thanks.
fix2 is working OK.
-
From: Marek Olšák
We initialized Target, but not TargetIndex.
This is required since 7d7dd1871174905dfdd3ca874a09d9.
v2: do it in the right place. Noticed by Brian Paul.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92645
---
src/mesa/main/vdpau.c | 5 +++--
1 file changed, 3 insertio
On 10/27/2015 02:17 PM, Marek Olšák wrote:
From: Marek Olšák
We initialized Target, but not TargetIndex.
This is required since 7d7dd1871174905dfdd3ca874a09d9.
v2: do it in the right place. Noticed by Brian Paul.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92645
---
src/mesa/main
Thanks, and sorry, I forgot to update the commit message. I will
commit it shortly with that fixed.
Marek
On Tue, Oct 27, 2015 at 9:19 PM, Brian Paul wrote:
> On 10/27/2015 02:17 PM, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> We initialized Target, but not TargetIndex.
>> This is required
From: Ian Romanick
Commit fba4823a disabled user clipping for everything except
compatibility profile. Core profile and OpenGL ES 2.0+ have all removed
the classic, OpenGL 1.0 user clip planes. ES 1.x, however, still has
them.
Fixes OpenGL ES 1.1 conformance mustpass.c and userclip.c
Signed-o
On Tuesday, October 27, 2015 02:56:24 PM Ian Romanick wrote:
> From: Ian Romanick
>
> Commit fba4823a disabled user clipping for everything except
> compatibility profile. Core profile and OpenGL ES 2.0+ have all removed
> the classic, OpenGL 1.0 user clip planes. ES 1.x, however, still has
> t
On Mon, Oct 12, 2015 at 02:55:32PM -0700, Kenneth Graunke wrote:
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 174 ++
> src/mesa/drivers/dri/i965/brw_fs.h| 16 +-
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 378
>
https://bugs.freedesktop.org/show_bug.cgi?id=92278
--- Comment #6 from Ian Romanick ---
(In reply to Sven Arvidsson from comment #5)
> The patch works fine here, awesome work! Fantastic to have it fixed so
> quickly!
>
> The developer of the game is Gaijin Entertainment, http://gaijinent.com
>
https://bugs.freedesktop.org/show_bug.cgi?id=92278
--- Comment #7 from Ian Romanick ---
(In reply to Tapani Pälli from comment #4)
> Created attachment 119200 [details] [review]
> hack that fixes issue
>
> This is slightly cleaner but still just a hack, it looks like we would need
> full GL_EXT_
From: Dave Airlie
since 1ad305b612f389fb04c6d51847427d5ec72fae03
Brian Paul
Date: Tue Jul 21 18:35:38 2015 -0600
mesa: plumb offset/size parameters through GetTexSubImage code
I found this testing virgl which exercises a bunch of these
in it's fallbacks.
Signed-off-by: Dave Airlie
---
On Tue, Oct 27, 2015 at 10:26 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> since 1ad305b612f389fb04c6d51847427d5ec72fae03
> Brian Paul
> Date: Tue Jul 21 18:35:38 2015 -0600
>
> mesa: plumb offset/size parameters through GetTexSubImage code
>
> I found this testing virgl which exercises
https://bugs.freedesktop.org/show_bug.cgi?id=92278
--- Comment #8 from Tapani Pälli ---
(In reply to Ian Romanick from comment #7)
> (In reply to Tapani Pälli from comment #4)
> > Created attachment 119200 [details] [review] [review]
> > hack that fixes issue
> >
> > This is slightly cleaner but
Signed-off-by: Jordan Justen
Cc: Samuel Iglesias Gonsálvez
Cc: Iago Toral Quiroga
---
src/glsl/linker.cpp | 14 ++
src/glsl/standalone_scaffolding.cpp | 5 +
src/mesa/main/mtypes.h | 7 +++
3 files changed, 26 insertions(+)
diff --git a/src/gl
I did a regression check with CTS, no failures;
Tested-by: Tapani Pälli
On 10/27/2015 01:55 PM, Juha-Pekka Heikkila wrote:
These helpers are ran for same case the same loop. Here joined
their operation so the loop is ran just once. Also fixed
out-of-memory condition here.
v2: Make the loop si
Signed-off-by: Jordan Justen
Cc: Samuel Iglesias Gonsálvez
Cc: Iago Toral Quiroga
---
src/glsl/link_uniform_initializers.cpp | 2 +-
src/glsl/linker.cpp| 16
src/glsl/standalone_scaffolding.cpp| 4 ++--
src/mesa/main/mtypes.h | 11 +
Previously we were treating the binding index for Uniform Buffer
Objects and Shader Storage Buffer Objects as being part of the
combined BufferInterfaceBlocks array.
Fixes ES31-CTS.compute_shader.resource-ubo on i965.
Signed-off-by: Jordan Justen
Cc: Samuel Iglesias Gonsálvez
Cc: Iago Toral Qui
On 10/27/2015 04:04 PM, Samuel Iglesias Gonsalvez wrote:
Commit 4565b6f did not update the basename match's check for
the case that string would exactly match the name of the
variable if the suffix "[0]" were appended to it.
Fixes two dEQP-GLES31 tests:
dEQP-GLES31.functional.program_interface_
On Tue, 2015-10-27 at 14:33 +0200, Pohjolainen, Topi wrote:
> On Tue, Oct 27, 2015 at 10:28:58AM +0100, Iago Toral Quiroga wrote:
> > We need this so we can configure different behaviors for passes that
> > cannot deal with side-effectful instructions (CSE) and passes that can
> > (we will add a lo
70 matches
Mail list logo
