[Mesa-dev] [Bug 1626] X server should not poll() on DRM fd

2015-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=1626 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #16 from Pekka Paalanen --- (In reply to nerdopolis1 from comment #15) > Doesn't seem that break _mesa_error works, it's not defined... It should become defined once all the related Mesa libraries get loaded. Looks like 'start' is no

Re: [Mesa-dev] [PATCH v4 15/44] i965: Work around L3 state leaks during context switches.

2015-12-09 Thread Jordan Justen
On 2015-12-08 08:43:53, Francisco Jerez wrote: > This is going to require some rather intrusive kernel changes to fix > properly, in the meantime (and forever on at least pre-v4.1 kernels) > we'll have to restore the hardware defaults at the end of every batch > in which the L3 configuration was ch

Re: [Mesa-dev] [PATCH 00/26] i965: Tessellation shaders for Gen8+!

2015-12-09 Thread Kenneth Graunke
I'm working on rebasing these patches on Jason's NIR input/output intrinsic changes. Patches 17, 18, 19, 22, and 24 are probably not worth reviewing in their current form. 10, 12-16, and 23 still apply in their current form. --Ken signature.asc Description: This is a digitally signed message p

[Mesa-dev] [PATCH] gallium/aux../util: Make u_prims_for_vertices() safe

2015-12-09 Thread Edward O'Callaghan
Let us avoid trapping in hardware from a SIGFPE and instead assert on a zero divisor. Hint: This can occur if a PIPE_PRIM_? is not handled in u_prim_vertex_count() that results in ' info ' not being initialized in the expected manner. Further, we also fix a possibly NULL pointer deref

Re: [Mesa-dev] [PATCH 1/8] glsl: pass stage into mark function

2015-12-09 Thread Oded Gabbay
On Wed, Dec 9, 2015 at 8:06 AM, Dave Airlie wrote: > From: Dave Airlie > > Don't use a bool here, as for some 64-bit fixes we need > the stage. > > Signed-off-by: Dave Airlie > --- > src/glsl/ir_set_program_inouts.cpp | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --gi

Re: [Mesa-dev] [PATCH] svga: initialize pipe_driver_query_info entries with a macro

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 00:35, Brian Paul wrote: > To be safe, set all the fields in case the enums ordering/values > ever change. Since you guys are using MVSC2013 to build svga one can even use c99 initializers. This should be more robust wrt the issues mentioned. -Emil _

Re: [Mesa-dev] [PATCH] clover: Fix build against LLVM 3.8 SVN >= r255078

2015-12-09 Thread Francisco Jerez
Michel Dänzer writes: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer Looks OK to me, Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/state_trackers/clover/llvm/invocat

Re: [Mesa-dev] [PATCH] Fix locking of GLsync objects

2015-12-09 Thread Emil Velikov
Hello Steinar, On 8 December 2015 at 01:01, Steinar H. Gunderson wrote: > Hi, > > I was told that it's easier for people to review my patch if it comes in via > email than being stuck in the bug tracker; FWIW, this is for bug 120238. Which bugtracker it this ? bugs.fd.o does not like the number m

[Mesa-dev] [PATCH] i965: Separate base offset/constant offset combining from remapping.

2015-12-09 Thread Kenneth Graunke
My tessellation branch has two additional remap functions. I don't want to replicate this logic there. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 78 - 1 file changed, 50 insertions(+), 28 deletions(-) Hey Jason, If you like th

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: fix test for SSE4.1 assembler support

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 05:37, Jonathan Gray wrote: > Change the __m128i variables to be volatile so gcc 4.9 won't optimise > all of them out with -O1 or greater. The _mm_set1_epi32/pinsrd calls > still get optimised out but now there is at least one SSE4.1 instruction > generated via _mm_max_epu32

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] configure.ac: use pkg-config for libelf

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 05:55, Jonathan Gray wrote: > Use PKG_CHECK_MODULES to get the flags to link libelf > > v2: keep AC_CHECK_LIB as a fallback for elfutils provided > libelf that doesn't install a pkg-config file. > > Signed-off-by: Jonathan Gray > Reviewed-by: Michel Dänzer > Tested-by: Mich

Re: [Mesa-dev] [PATCH 3/8] glsl: use dual slot helper in the linker code.

2015-12-09 Thread Timothy Arceri
On Wed, 2015-12-09 at 16:06 +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Great timing :) I was going to have to look into fixing this stuff for enhanced layouts. Patches 1 & 2 are: Reviewed-by: Timothy Arceri I have a question about this patch. If these double

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: fix test for SSE4.1 assembler support

2015-12-09 Thread Oded Gabbay
On Wed, Dec 9, 2015 at 1:09 PM, Emil Velikov wrote: > On 9 December 2015 at 05:37, Jonathan Gray wrote: >> Change the __m128i variables to be volatile so gcc 4.9 won't optimise >> all of them out with -O1 or greater. The _mm_set1_epi32/pinsrd calls >> still get optimised out but now there is at

Re: [Mesa-dev] [PATCH 2/8] glsl/fp64: add helper for dual slot double detection.

2015-12-09 Thread Oded Gabbay
On Wed, Dec 9, 2015 at 8:06 AM, Dave Airlie wrote: > From: Dave Airlie > > The old function didn't work for matrices, and we need this > in other places to fix some other problems, so move to a helper > in glsl type and fix the one user so far. > > A dual slot double is one that has 3 or 4 compon

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-09 Thread Emil Velikov
On 8 December 2015 at 16:35, Neil Roberts wrote: > If EGL_KHR_surfaceless_context is used then glViewport can be called > with NULL for the draw and read surfaces. This was previously causing > a crash because the i965 driver tries to use this point to invalidate > the surfaces and it was derferen

Re: [Mesa-dev] [PATCH 7/8] glsl: fix transform feedback for 64-bit outupts.

2015-12-09 Thread Timothy Arceri
On Wed, 2015-12-09 at 16:06 +1000, Dave Airlie wrote: > From: Dave Airlie > > This fixes the calculations for transform feedback for doubles. > > Signed-off-by: Dave Airlie Patches 4-7 are also: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: fix test for SSE4.1 assembler support

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 11:39, Oded Gabbay wrote: > On Wed, Dec 9, 2015 at 1:09 PM, Emil Velikov wrote: >> On 9 December 2015 at 05:37, Jonathan Gray wrote: >>> Change the __m128i variables to be volatile so gcc 4.9 won't optimise >>> all of them out with -O1 or greater. The _mm_set1_epi32/pinsrd

Re: [Mesa-dev] [PATCH 8/8] glsl: only divide left components when it is a dual slot double.

2015-12-09 Thread Timothy Arceri
On Wed, 2015-12-09 at 16:06 +1000, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/glsl/lower_packed_varyings.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/lower_packed_varyings.cpp > b/src/glsl/lower_packed_varyings.cpp

Re: [Mesa-dev] [PATCH 1/2] glsl: do not loose always_active_io when packing varyings

2015-12-09 Thread Timothy Arceri
On Wed, 2015-12-09 at 09:48 +0200, Tapani Pälli wrote: > Otherwise packed and inactive varyings get optimized away. This needs > to be prevented when using separate shader objects where interface > needs to be preserved. > > Signed-off-by: Tapani Pälli Reviewed-by: Timothy Arceri > --- > src/

[Mesa-dev] [RFC PATCH 2/5] i965/fs: set execution size for SEND messages in generate_uniform_pull_constant_load_gen7

2015-12-09 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index 8d24883..36a7329 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp +++ b/src/mes

[Mesa-dev] [RFC PATCH 4/5] i965: set correct execsize for MOVS with a width of 4 in brw_find_live_channel

2015-12-09 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index 13c8c36..78f2c8c 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++ b/src/mesa/drivers/dri/i965/brw_eu_e

Re: [Mesa-dev] [PATCH 01/10] gallium/pb_cache: add a copy of cache bufmgr independent of pb_manager

2015-12-09 Thread Marek Olšák
On Dec 8, 2015 10:08 PM, "Nicolai Hähnle" wrote: > > On 06.12.2015 19:00, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This simplified (basically duplicated) version of pb_cache_manager will >> allow removing some ugly hacks from radeon and amdgpu winsyses and >> flatten simplify their design

[Mesa-dev] [RFC PATCH 5/5] i965: Skip execution size adjustment for instructions of width 4

2015-12-09 Thread Iago Toral Quiroga
This code in brw_set_dest adjusts the execution size of any instruction with a dst.width < 8. However, we don't want to do this with instructions operating on doubles, since these will have a width of 4, but still need an execution size of 8 (for SIMD8). Unfortunately, we can't just check the size

[Mesa-dev] [RFC PATCH 3/5] i965/eu: set execution size for SEND message in brw_send_indirect_message

2015-12-09 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index 9543d5e..13c8c36 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++ b/src/mesa/drivers/dri/i965/brw_eu_e

[Mesa-dev] [RFC PATCH 1/5] i965/eu: set correct execution size in brw_NOP

2015-12-09 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_eu_emit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index f8c0f80..9543d5e 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++ b/src/mesa/drivers/dri/i965/brw_eu_emit

[Mesa-dev] [RFC PATCH 0/5] Skip automatic execsize for instructions with a width of 4

2015-12-09 Thread Iago Toral Quiroga
Right now we rely on the code at the bottom of brw_set_dest to set the correct execution size for anything that does not operate on a full SIMD register (dst.width < BRW_EXECUTE_8). However, this won't work with fp64, where operands are twice as big and we see instructions with a horizontal widt

Re: [Mesa-dev] [PATCH v4 15/44] i965: Work around L3 state leaks during context switches.

2015-12-09 Thread Francisco Jerez
Jordan Justen writes: > On 2015-12-08 08:43:53, Francisco Jerez wrote: >> This is going to require some rather intrusive kernel changes to fix >> properly, in the meantime (and forever on at least pre-v4.1 kernels) >> we'll have to restore the hardware defaults at the end of every batch >> in whi

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: fix test for SSE4.1 assembler support

2015-12-09 Thread Jonathan Gray
On Wed, Dec 09, 2015 at 01:39:30PM +0200, Oded Gabbay wrote: > On Wed, Dec 9, 2015 at 1:09 PM, Emil Velikov wrote: > > On 9 December 2015 at 05:37, Jonathan Gray wrote: > >> Change the __m128i variables to be volatile so gcc 4.9 won't optimise > >> all of them out with -O1 or greater. The _mm_se

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #17 from nerdopol...@verizon.net --- Argh, I tried to recompile mesa master with all of the symbols, and now SDL is working, not sure what to think now... -- You are receiving this mail because: You are the QA Contact for the bug. __

Re: [Mesa-dev] [RFC] i965: Resolve color for all active shader images in intel_update_state().

2015-12-09 Thread Francisco Jerez
Kristian Høgsberg writes: > On Sat, Sep 5, 2015 at 11:30 AM, Jordan Justen > wrote: >> From: Francisco Jerez >> >> Fixes >> arb_shader_image_load_store/execution/load-from-cleared-image.shader_test >> >> Cc: Chris Wilson >> Cc: Jason Ekstrand >> Tested-by: Jordan Justen > > This patch is re

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: fix test for SSE4.1 assembler support

2015-12-09 Thread Oded Gabbay
On Wed, Dec 9, 2015 at 2:34 PM, Jonathan Gray wrote: > On Wed, Dec 09, 2015 at 01:39:30PM +0200, Oded Gabbay wrote: >> On Wed, Dec 9, 2015 at 1:09 PM, Emil Velikov >> wrote: >> > On 9 December 2015 at 05:37, Jonathan Gray wrote: >> >> Change the __m128i variables to be volatile so gcc 4.9 won't

[Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-09 Thread Andreas Boll
Removes the public symbol _glapi_create_table_from_handle from libGL.so.1 on all plattforms except Darwin. Since the symbol is not used on other plattforms it makes sense to build gl_gentable.c only on Darwin. A little bit of history: _glapi_create_table_from_handle was introduced in commit 859

[Mesa-dev] [PATCH] gallium/util: handle patches in u_prims_for_vertices to fix a radeonsi crash

2015-12-09 Thread Marek Olšák
From: Marek Olšák I guess the crash was because of divison by zero. Cc: 11.0 11.1 --- src/gallium/auxiliary/util/u_prim.h | 17 + src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliar

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #18 from Daniel Stone --- How about 'hooray, it's fixed'? :) -- You are receiving this mail because: You are the QA Contact for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-09 Thread Neil Roberts
Emil Velikov writes: > Worth throwing in 11.0 as well ? Yeah, that would probably be sensible. >> if (_mesa_is_winsys_fbo(ctx->DrawBuffer)) { >> - dri2InvalidateDrawable(driContext->driDrawablePriv); >> - dri2InvalidateDrawable(driContext->driReadablePriv); >> + if (driContex

Re: [Mesa-dev] [PATCH shader-db 1/3] split-to-files: deal with minimum versions, other shader types

2015-12-09 Thread Eero Tamminen
Hi, On 11/09/2015 08:47 PM, Matt Turner wrote: On Mon, Nov 9, 2015 at 10:46 AM, Ilia Mirkin wrote: I used this script in conjunction with ST_DUMP_SHADERS. What other way is there? Some local hack and we should probably finish and upstream. Did anything happen with this? I had to rewrite s

Re: [Mesa-dev] softpipe: V.2 implement some support for multiple viewports

2015-12-09 Thread Roland Scheidegger
Am 09.12.2015 um 05:16 schrieb Edward O'Callaghan: > This fixes my initial attempt so that piglit now passes 14/14. Thanks > to a couple of tips from Roland in the previous patch I was able to > fix the remaining issue. This should be golden now. > Great that you got it working! Please send the p

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 14:57, Neil Roberts wrote: > Emil Velikov writes: > >> Worth throwing in 11.0 as well ? > > Yeah, that would probably be sensible. > >>> if (_mesa_is_winsys_fbo(ctx->DrawBuffer)) { >>> - dri2InvalidateDrawable(driContext->driDrawablePriv); >>> - dri2InvalidateD

Re: [Mesa-dev] [PATCH] i965: Separate base offset/constant offset combining from remapping.

2015-12-09 Thread Jason Ekstrand
On Dec 9, 2015 2:51 AM, "Kenneth Graunke" wrote: > > My tessellation branch has two additional remap functions. I don't want > to replicate this logic there. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_nir.c | 78 - > 1 file chang

Re: [Mesa-dev] [RFC PATCH 5/5] i965: Skip execution size adjustment for instructions of width 4

2015-12-09 Thread Jason Ekstrand
On Dec 9, 2015 4:16 AM, "Iago Toral Quiroga" wrote: > > This code in brw_set_dest adjusts the execution size of any instruction > with a dst.width < 8. However, we don't want to do this with instructions > operating on doubles, since these will have a width of 4, but still > need an execution size

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-09 Thread Deve
This patch indeed seems to not have a sense. I just added it to the bug report as a suggestion that it works for me after this modification. Emil Velikov said that I should send it to the mailing list. Here is how it works in Supertuxkart: We create rtt with following parameters: DepthStencilT

Re: [Mesa-dev] [PATCH] Fix locking of GLsync objects

2015-12-09 Thread Steinar H. Gunderson
On Wed, Dec 09, 2015 at 10:35:25AM +, Emil Velikov wrote: >> I was told that it's easier for people to review my patch if it comes in via >> email than being stuck in the bug tracker; FWIW, this is for bug 120238. > Which bugtracker it this ? bugs.fd.o does not like the number > mentioned. Plea

[Mesa-dev] [PATCH 4/4] st/osmesa: Fix a typo in a comment

2015-12-09 Thread Andreas Boll
s/suport/support/ Signed-off-by: Andreas Boll --- src/gallium/state_trackers/osmesa/osmesa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/osmesa/osmesa.c b/src/gallium/state_trackers/osmesa/osmesa.c index 0285cb0..0f27ba8 100644 --- a/src/galliu

[Mesa-dev] [PATCH 3/4] meta: Fix a typo in a print message

2015-12-09 Thread Andreas Boll
s/Unkown/Unknown/ Signed-off-by: Andreas Boll --- src/mesa/drivers/common/meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index c5faf61..4dbf0a7 100644 --- a/src/mesa/drivers/common/meta_bl

[Mesa-dev] [PATCH 1/4] glsl: Fix a typo in a comment

2015-12-09 Thread Andreas Boll
s/suports/supports/ Signed-off-by: Andreas Boll --- src/glsl/glsl_parser_extras.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser_extras.h b/src/glsl/glsl_parser_extras.h index 6bded3e..a4bda77 100644 --- a/src/glsl/glsl_parser_extras.h +++ b/src/glsl/gls

[Mesa-dev] [PATCH 2/4] mesa: Fix typos in print messages

2015-12-09 Thread Andreas Boll
s/inconsistant/inconsistent/ s/occurences/occurrences/ Signed-off-by: Andreas Boll --- src/mesa/main/teximage.c | 2 +- src/mesa/main/transformfeedback.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 60fc

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #19 from nerdopol...@verizon.net --- I didn't see any thing in the changelog for 'egl' that looked like it might be a fix... Not 100% sure though -- You are receiving this mail because: You are the QA Contact for the bug. ___

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-09 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 11:18 AM, Deve wrote: > This patch indeed seems to not have a sense. I just added it to the bug > report as a suggestion that it works for me after this modification. Emil > Velikov said that I should send it to the mailing list. > > Here is how it works in Supertuxkart: > W

[Mesa-dev] [PATCH 2/2] mesa: Fix a typo in a comment

2015-12-09 Thread Andreas Boll
s/suports/supports/ Signed-off-by: Andreas Boll --- src/mesa/main/extensions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.h b/src/mesa/main/extensions.h index 1615e1c..b5e0350 100644 --- a/src/mesa/main/extensions.h +++ b/src/mesa/main/extensions

[Mesa-dev] [PATCH 1/2] glx: Fix a typo in a comment

2015-12-09 Thread Andreas Boll
s/suports/supports/ Signed-off-by: Andreas Boll --- Found two more "suports" typos. I could squash all patches together if that's preferred. src/glx/dri2_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 27ea952..651915a 1006

Re: [Mesa-dev] [PATCH 1/2] glx: Fix a typo in a comment

2015-12-09 Thread Brian Paul
On 12/09/2015 09:29 AM, Andreas Boll wrote: s/suports/supports/ Signed-off-by: Andreas Boll --- Found two more "suports" typos. I could squash all patches together if that's preferred. src/glx/dri2_glx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/dri2_glx.c

Re: [Mesa-dev] [PATCH 1/4] glsl: Fix a typo in a comment

2015-12-09 Thread Brian Paul
On 12/09/2015 09:20 AM, Andreas Boll wrote: s/suports/supports/ Signed-off-by: Andreas Boll --- src/glsl/glsl_parser_extras.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glsl_parser_extras.h b/src/glsl/glsl_parser_extras.h index 6bded3e..a4bda77 100644 --- a/

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-09 Thread Emil Velikov
On 9 December 2015 at 14:11, Andreas Boll wrote: > Removes the public symbol _glapi_create_table_from_handle from > libGL.so.1 on all plattforms except Darwin. > typo -> platforms > Since the symbol is not used on other plattforms it makes sense to ditto > build gl_gentable.c only on Darwin. > I

Re: [Mesa-dev] [RFC] glapi: Build gl_gentable.c only on Darwin

2015-12-09 Thread Jeremy Huddleston Sequoia
The general concept of this change seems fine to me. Given the desire to keep glapi as similar as possible across platforms, would it be better to just move this into glx/apple rather than leaving it in glapi? > On Dec 9, 2015, at 09:07, Emil Velikov wrote: > > On 9 December 2015 at 14:11, And

Re: [Mesa-dev] [PATCH 2/2] util/u_helpers: return correct number of bound buffers

2015-12-09 Thread Ilia Mirkin
I'm probably just being dense... can you provide an exact sequence of calls that would cause this logic to fail? Seems like it should work as-is... On Sun, Dec 6, 2015 at 4:12 AM, Patrick Rudolph wrote: > In case a state tracker unbinds every slot by a seperate > pipe->set_vertex_buffers() call,

Re: [Mesa-dev] [PATCH] configure.ac: fix test for SSE4.1 assembler support

2015-12-09 Thread Matt Turner
On Tue, Dec 8, 2015 at 9:37 PM, Jonathan Gray wrote: > Change the __m128i variables to be volatile so gcc 4.9 won't optimise > all of them out with -O1 or greater. The _mm_set1_epi32/pinsrd calls > still get optimised out but now there is at least one SSE4.1 instruction > generated via _mm_max_ep

Re: [Mesa-dev] [RFC PATCH 1/5] i965/eu: set correct execution size in brw_NOP

2015-12-09 Thread Matt Turner
On Wed, Dec 9, 2015 at 4:15 AM, Iago Toral Quiroga wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_emit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c > b/src/mesa/drivers/dri/i965/brw_eu_emit.c > index f8c0f80..9543d5e 100644 > --- a/src/mesa/

Re: [Mesa-dev] [PATCH] mesa: detect inefficient buffer use and report through debug output

2015-12-09 Thread Ilia Mirkin
On Mon, Dec 7, 2015 at 8:42 PM, Brian Paul wrote: > When a buffer is created with GL_STATIC_DRAW, its contents should not > be changed frequently. But that's exactly what one application I'm > debugging does. This patch adds code to try to detect inefficient > buffer use in a couple places. The

Re: [Mesa-dev] softpipe: V.2 implement some support for multiple viewports

2015-12-09 Thread eocallaghan
Roland, I could not due to ml size limit or something, it just bounces hence the pull request. Cheers, Edward. On 2015-12-10 02:38, Roland Scheidegger wrote: Am 09.12.2015 um 05:16 schrieb Edward O'Callaghan: This fixes my initial attempt so that piglit now passes 14/14. Thanks to a couple

Re: [Mesa-dev] [PATCH 2/2] util/u_helpers: return correct number of bound buffers

2015-12-09 Thread Patrick Rudolph
Ok, first of all bind some buffers: pipe->set_vertex_buffers(pipe, 0, 1, &vtxbuf); pipe->set_vertex_buffers(pipe, 1, 1, &vtxbuf); pipe->set_vertex_buffers(pipe, 2, 1, &vtxbuf); num_vtxbufs is now 3 as it should be. Now you are unbinding buffers, one after another starting at slot 0: pipe->set_ve

Re: [Mesa-dev] [PATCH] gallium/util: handle patches in u_prims_for_vertices to fix a radeonsi crash

2015-12-09 Thread eocallaghan
On 2015-12-10 01:47, Marek Olšák wrote: From: Marek Olšák I guess the crash was because of divison by zero. Cc: 11.0 11.1 --- src/gallium/auxiliary/util/u_prim.h | 17 + src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- 2 files changed, 15 insertions(+), 5 delet

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

2015-12-09 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 11:23 AM, Ilia Mirkin wrote: > On Wed, Dec 9, 2015 at 11:18 AM, Deve wrote: >> This patch indeed seems to not have a sense. I just added it to the bug >> report as a suggestion that it works for me after this modification. Emil >> Velikov said that I should send it to the m

Re: [Mesa-dev] [PATCH 1/2] nvc0: fix use after free of pipe_resource

2015-12-09 Thread Ilia Mirkin
I pushed a slightly modified version of this: http://cgit.freedesktop.org/mesa/mesa/commit/?id=432a798cf5c7fab18a3e32d4073840df7d0d37cb Thanks for the patch! I hope this will resolve some weird crashes people have seen with various buffers being null unexpectedly. On Sun, Dec 6, 2015 at 4:11 AM,

[Mesa-dev] [Bug 90821] Segfault when calling glViewport on surfaceless EGL context without bound FBO

2015-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90821 Nanley Chery changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] util/u_helpers: return correct number of bound buffers

2015-12-09 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 2:01 PM, Patrick Rudolph wrote: > Ok, first of all bind some buffers: > > pipe->set_vertex_buffers(pipe, 0, 1, &vtxbuf); > pipe->set_vertex_buffers(pipe, 1, 1, &vtxbuf); > pipe->set_vertex_buffers(pipe, 2, 1, &vtxbuf); > > num_vtxbufs is now 3 as it should be. > > Now you ar

Re: [Mesa-dev] [PATCH 3/5] i965: Check base format to determine whether to use tiled memcpy

2015-12-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Nov 19, 2015 at 7:25 AM, Neil Roberts wrote: > The tiled memcpy doesn't work for copying from RGBX to RGBA because it > doesn't override the alpha component to 1.0. Commit 2cebaac479d4 added > a check to disable it for RGBX formats by looking at the TexFormat.

Re: [Mesa-dev] [PATCH 3/8] glsl: use dual slot helper in the linker code.

2015-12-09 Thread Dave Airlie
On 9 December 2015 at 21:39, Timothy Arceri wrote: > On Wed, 2015-12-09 at 16:06 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> Signed-off-by: Dave Airlie > > Great timing :) I was going to have to look into fixing this stuff for > enhanced layouts. > > Patches 1 & 2 are: > Reviewed-by: Ti

Re: [Mesa-dev] [PATCH] i965: Separate base offset/constant offset combining from remapping.

2015-12-09 Thread Kenneth Graunke
On Wednesday, December 09, 2015 08:03:25 AM Jason Ekstrand wrote: > On Dec 9, 2015 2:51 AM, "Kenneth Graunke" wrote: > > > > My tessellation branch has two additional remap functions. I don't want > > to replicate this logic there. > > > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/dri

[Mesa-dev] [PATCH] nvc0: optimize coherent buffer checking at draw time

2015-12-09 Thread Samuel Pitoiset
Instead of iterating over all the buffer resources looking for coherent buffers, we keep track of a context-wide count. This will save some iterations (and CPU cycles) in 99.99% case because usually coherent buffers are not so used. Signed-off-by: Samuel Pitoiset --- I didn't test the patch, but

[Mesa-dev] Mesa 11.0.7

2015-12-09 Thread Emil Velikov
Mesa 11.0.7 is now available. This release brings substantial amount of fixes in meta (affecting i965), some driver fixes for i965, nouveau, r600 and llvm. The video encoding for Stoney has been disabled, as it isn't working properly. There are also build fixes for DragonFly and other *BSD platfo

Re: [Mesa-dev] [PATCH 12/26] i965: Add tessellation shader sampler support.

2015-12-09 Thread Jordan Justen
12 & 13 Reviewed-by: Jordan Justen On 2015-12-02 16:15:53, Kenneth Graunke wrote: > Based on code by Chris Forbes and Fabian Bieler. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 +- > src/mesa/drivers/dri/i965/brw_sampler_state.c | 46 > +++

[Mesa-dev] [ANNOUNCE] mesa-demos 8.3.0

2015-12-09 Thread Andreas Boll
This new mesa-demos release fixes the build issue against mesa 10.6 (Bug #91643) and picks up the latest glxinfo changes. For the misc changes see below. Andreas. Adam Jackson (1): glxinfo: Add support for GLX_MESA_query_renderer Andreas Boll (3): demos: add missing binaries to .git

Re: [Mesa-dev] [PATCH 14/26] i965: Add Gen8+ tessellation evaluation shader state (3DSTATE_DS).

2015-12-09 Thread Jordan Justen
On 2015-12-02 16:15:55, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen8_ds_state.c | 66 > +++ > 1 file changed, 59 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/gen8_ds_state.c > b/src/mesa/d

Re: [Mesa-dev] [PATCH 15/26] i965: Add Gen7+ tessellation engine state (3DSTATE_TE).

2015-12-09 Thread Jordan Justen
On 2015-12-02 16:15:56, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen7_te_state.c | 36 > --- > 1 file changed, 28 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/gen7_te_state.c > b/src/mesa/d

Re: [Mesa-dev] [PATCH] gallium/aux../util: Make u_prims_for_vertices() safe

2015-12-09 Thread Marek Olšák
Pushed, thanks. Marek On Wed, Dec 9, 2015 at 10:07 AM, Edward O'Callaghan wrote: > Let us avoid trapping in hardware from a SIGFPE and instead > assert on a zero divisor. > > Hint: This can occur if a PIPE_PRIM_? is not handled in > u_prim_vertex_count() that results in ' info ' not >

[Mesa-dev] [PATCH] radeonsi: don't call of u_prims_for_vertices for patches and rectangles

2015-12-09 Thread Marek Olšák
From: Marek Olšák Both caused a crash due to a division by zero in that function. This is an alternative fix. Cc: 11.0 11.1 --- src/gallium/drivers/radeonsi/si_state_draw.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_

[Mesa-dev] [PATCH 4/4] winsys/amdgpu: clear the buffer cache on mmap failure and try again

2015-12-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 674482e..adea376 100644 --- a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c +++ b/src/

[Mesa-dev] [PATCH 1/4] winsys/radeon: clear the buffer cache on allocation failure and try again

2015-12-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c index 3fd233c..a5f8aeb 100644 --- a/src/gallium/winsys/r

[Mesa-dev] [PATCH 3/4] winsys/radeon: clear the buffer cache on mmap failure and try again

2015-12-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c index a5f8aeb..5ba01b9 100644 --- a/src/gallium/wi

[Mesa-dev] [PATCH 2/4] winsys/amdgpu: clear the buffer cache on allocation failure and try again

2015-12-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 41efbcb..674482e 100644 --- a/src/gallium/winsys/amdgpu/drm/am

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix GLSL uniform updates for glBitmap & glDrawPixels

2015-12-09 Thread Marek Olšák
On Mon, Dec 7, 2015 at 5:36 PM, Brian Paul wrote: > On 12/06/2015 04:34 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Spotted by luck. The GLSL uniform storage is only associated once >> in LinkShader and can't be reallocated afterwards, because that would >> break the association. >> ---

Re: [Mesa-dev] softpipe: V.2 implement some support for multiple viewports

2015-12-09 Thread Roland Scheidegger
Am 09.12.2015 um 19:59 schrieb eocallag...@alterapraxis.com: > Roland, > > I could not due to ml size limit or something, it just bounces hence the > pull request. Due to size limit? Didn't look that big to me... Otherwise, looks good to me, though the second commit should mention it actually ena

Re: [Mesa-dev] [PATCH] mesa: detect inefficient buffer use and report through debug output

2015-12-09 Thread Brian Paul
On 12/09/2015 11:43 AM, Ilia Mirkin wrote: On Mon, Dec 7, 2015 at 8:42 PM, Brian Paul wrote: When a buffer is created with GL_STATIC_DRAW, its contents should not be changed frequently. But that's exactly what one application I'm debugging does. This patch adds code to try to detect inefficie

Re: [Mesa-dev] [PATCH] mesa: detect inefficient buffer use and report through debug output

2015-12-09 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 5:23 PM, Brian Paul wrote: > On 12/09/2015 11:43 AM, Ilia Mirkin wrote: >> >> On Mon, Dec 7, 2015 at 8:42 PM, Brian Paul wrote: >>> >>> When a buffer is created with GL_STATIC_DRAW, its contents should not >>> be changed frequently. But that's exactly what one application

[Mesa-dev] [PATCH] radeonsi: implement RB+ for Stoney (v2)

2015-12-09 Thread Marek Olšák
From: Marek Olšák v2: fix dual source blending --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 3 + src/gallium/drivers/radeon/r600_texture.c | 6 + src/gallium/drivers/radeonsi/si_state.c | 159 +-

[Mesa-dev] [PATCH v2] nv50, nvc0: optimize coherent buffer checking at draw time

2015-12-09 Thread Samuel Pitoiset
Instead of iterating over all the buffer resources looking for coherent buffers, we keep track of a context-wide count. This will save some iterations (and CPU cycles) in 99.99% case because usually coherent buffers are not so used. Changes from v2: - forgot to apply some changes for nv50 (textur

Re: [Mesa-dev] [PATCH v2] nv50, nvc0: optimize coherent buffer checking at draw time

2015-12-09 Thread Ilia Mirkin
On Wed, Dec 9, 2015 at 5:40 PM, Samuel Pitoiset wrote: > Instead of iterating over all the buffer resources looking for coherent > buffers, we keep track of a context-wide count. This will save some > iterations (and CPU cycles) in 99.99% case because usually coherent > buffers are not so used. >

[Mesa-dev] [PATCH] radeonsi: also print hexadecimal values for register fields in the IB parser

2015-12-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index cce665e..034acf5 100644 --- a/src/gallium/drivers/radeonsi/si_deb

[Mesa-dev] [PATCH] mesa: fix ID usage for buffer warnings

2015-12-09 Thread Brian Paul
We need a different ID pointer for each call site. --- src/mesa/main/bufferobj.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 6bc1b5e..e0639c8 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mes

Re: [Mesa-dev] [PATCH] mesa: fix ID usage for buffer warnings

2015-12-09 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Dec 9, 2015 at 6:02 PM, Brian Paul wrote: > We need a different ID pointer for each call site. > --- > src/mesa/main/bufferobj.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/mai

Re: [Mesa-dev] [PATCH] i965: Separate base offset/constant offset combining from remapping.

2015-12-09 Thread Jason Ekstrand
On Wed, Dec 9, 2015 at 12:08 PM, Kenneth Graunke wrote: > On Wednesday, December 09, 2015 08:03:25 AM Jason Ekstrand wrote: >> On Dec 9, 2015 2:51 AM, "Kenneth Graunke" wrote: >> > >> > My tessellation branch has two additional remap functions. I don't want >> > to replicate this logic there. >>

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

2015-12-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91888 --- Comment #20 from nerdopol...@verizon.net --- And now all the examples from qtbase/examples/opengl are working as well even after exporting LIBGL_ALWAYS_SOFTWARE as well with mesa master. including contextinfo, qopenglwidget, qopenglwindow, and

[Mesa-dev] [PATCH] mesa/varray: set double arrays to non-normalised.

2015-12-09 Thread Dave Airlie
From: Dave Airlie Doesn't have any effect in practice I don't think, but CTS reads back using GetVertexAttrib. This fixes: GL41-CTS.vertex_attrib_64bit.get_vertex_attrib Signed-off-by: Dave Airlie --- src/mesa/main/varray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH 8/8] glsl: only divide left components when it is a dual slot double.

2015-12-09 Thread Ian Romanick
On 12/09/2015 04:07 AM, Timothy Arceri wrote: > On Wed, 2015-12-09 at 16:06 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> Signed-off-by: Dave Airlie >> --- >> src/glsl/lower_packed_varyings.cpp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/glsl/lower_pack

Re: [Mesa-dev] [PATCH] mesa/varray: set double arrays to non-normalised.

2015-12-09 Thread Ian Romanick
...and it matches what we do for single precision. Reviewed-by: Ian Romanick Presumably this should also be a candidate for 11.0 and 11.1? On 12/09/2015 04:37 PM, Dave Airlie wrote: > From: Dave Airlie > > Doesn't have any effect in practice I don't think, but > CTS reads back using GetVertex

[Mesa-dev] [PATCH 1/2] gallium/ddebug: add GALLIUM_DDEBUG_SKIP option

2015-12-09 Thread Nicolai Hähnle
From: Nicolai Hähnle When we know that hangs occur only very late in a reproducible run (e.g. apitrace), we can save a lot of debugging time by skipping the flush and hang detection for earlier draw calls. --- src/gallium/drivers/ddebug/dd_draw.c | 39 +- src/ga

[Mesa-dev] [PATCH 2/2] gallium/ddebug: regularly log the total number of draw calls

2015-12-09 Thread Nicolai Hähnle
From: Nicolai Hähnle This helps in the use of GALLIUM_DDEBUG_SKIP: first run a target application with skip set to a very large number and note how many draw calls happen before the bug. Then re-run, skipping the corresponding number of calls. Despite the additional run, this can still be much fa

Re: [Mesa-dev] [PATCH 1/3] mesa: docs: Add link to planet.freedesktop.org

2015-12-09 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 12/07/2015 12:18 PM, Sarah Sharp wrote: > The freedesktop.org blog feeds aren't mentioned on either mesa3d.org or > any of the graphics project wikis (including the DRI wiki) on > freedeskop.org. Fix that by linking to it from the sidebar. > > Signed-

Re: [Mesa-dev] [PATCH 2/3] mesa: docs: i965: Use correct doxygen groupings syntax

2015-12-09 Thread Ian Romanick
On 12/07/2015 12:18 PM, Sarah Sharp wrote: > When reading the source code, it's useful to indicate that a group of > fields in a struct are related in someway. The convention in Mesa seems > to be: > > struct foo { > /** > * Related fields description > * @{ > */ > int bar;

  1   2   >