Re: [Mesa-dev] [PATCH 1/2] r600: fix viewport clipping magic.

I have to NAK this series, but I was able to find something about the issue. If oViewport is used, VGT_REUSE_OFF must disable reuse. That's the correct fix. If oViewport is constant, reuse can be enabled, but VTE_VPORT_PROVOKE_DISABLE must be set. Marek On Fri, Dec 11, 2015 at 3:11 AM, Dave

[Mesa-dev] [Bug 93261] GL/DRI3 over ssh broken

https://bugs.freedesktop.org/show_bug.cgi?id=93261 poma changed: What|Removed |Added Component|GLX |Server/General

Re: [Mesa-dev] [PATCH 14/26] i965: Add Gen8+ tessellation evaluation shader state (3DSTATE_DS).

On Wednesday, December 09, 2015 01:40:37 PM Jordan Justen wrote: > On 2015-12-02 16:15:55, Kenneth Graunke wrote: [snip] > > + OUT_BATCH(GEN7_DS_ENABLE | > > +GEN7_DS_STATISTICS_ENABLE | > > +(brw->max_ds_threads - 1) << HSW_DS_MAX_THREADS_SHIFT | > >

Re: [Mesa-dev] [PATCH 15/26] i965: Add Gen7+ tessellation engine state (3DSTATE_TE).

On Wednesday, December 09, 2015 01:44:39 PM Jordan Justen wrote: > On 2015-12-02 16:15:56, Kenneth Graunke wrote: > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/gen7_te_state.c | 36 > > --- > > 1 file changed, 28

Re: [Mesa-dev] [PATCH 2/2] gallium/ddebug: regularly log the total number of draw calls

For the series: Reviewed-by: Marek Olšák On Thu, Dec 10, 2015 at 2:11 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This helps in the use of GALLIUM_DDEBUG_SKIP: first run a target application > with skip set to a very

[Mesa-dev] [PATCH 1/2] softpipe: implement some support for multiple viewports

Mostly related to making sure the rasterizer can correctly pick out the correct scissor box for the current viewport. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/softpipe/sp_context.h | 9 ++- src/gallium/drivers/softpipe/sp_quad.h

[Mesa-dev] [PATCH 2/2] softpipe: Update GL3.txt doc with GL_ARB_viewport_array support

Signed-off-by: Edward O'Callaghan --- docs/GL3.txt | 2 +- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 7eda002..84b5a17 100644 ---

[Mesa-dev] [PATCH] i965: Add tessellation shader surface support.

This is brw_gs_surface_state.c copy and pasted twice with search and replace. brw_binding_table.c code is similarly copy and pasted. v2: Drop dword_pitch related fields. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources| 2 +

Re: [Mesa-dev] [PATCH] i965: handle stencil_bits parameter for MESA_FORMAT_B8G8R8X8_UNORM format.

Ilia Mirkin writes: > I suspect that something like this may be the right thing for the > intel driver... no reason not to expose sRGB-capable visuals when it > so happens that alpha == 0. Also probably the same treatment should be > done for BGR565... sRGB encoding will

[Mesa-dev] [PATCH 1/3] i965: Add MESA_FORMAT_B8G8R8X8_SRGB to brw_format_for_mesa_format

This will be used in a subsequent patch as the format for RGB visuals. Cc: "11.0 11.1" Cc: Ilia Mirkin Suggested-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 1 + 1 file changed, 1

[Mesa-dev] [PATCH 3/3] i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals

Previously if the visual didn't have an alpha channel then it would pick a format that is not sRGB-capable. I don't think there's any reason not to always have an sRGB-capable visual. Since 28090b30 there are now visuals advertised without an alpha channel which means that games that don't request

[Mesa-dev] [PATCH 2/3] i965: Add B8G8R8X8_SRGB to the alpha format override

brw_init_surface_formats overrides the render format for RGBX formats which aren't supported for rendering so that they internally use RGBA instead. However, B8G8R8X8_SRGB was missing so it wasn't marked as a renderable format. This patch just adds it. Cc: "11.0 11.1"

Re: [Mesa-dev] [PATCH 04/15] i965/fs: Get rid of reladdr

Jason Ekstrand writes: > On Dec 10, 2015 6:58 AM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > We aren't using it anymore. >> >> It seems useful to me to be able to represent indirect access as part of >> any

[Mesa-dev] [PATCH 6/8] st/va: remove fence handling

From: Christian König It's nonsense to drain the pipeline like this. Signed-off-by: Christian König --- src/gallium/state_trackers/va/buffer.c | 5 - src/gallium/state_trackers/va/image.c | 1 -

[Mesa-dev] [PATCH 8/8] st/va: add BOB/WEAVE deinterlacing

From: Christian König Tested with MPV. Signed-off-by: Christian König --- src/gallium/state_trackers/va/postproc.c | 72 src/gallium/state_trackers/va/surface.c | 16 ++- 2 files changed, 78

[Mesa-dev] [PATCH 1/8] st/va: remove nonesense HEVC picture id handling

From: Christian König The picture id in this case is a VA-API surface handle, checking for a certain value can't be correct. Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture_hevc.c | 5 - 1 file changed, 5

[Mesa-dev] [PATCH 3/8] st/va: clean up post process includes

From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/postproc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/state_trackers/va/postproc.c b/src/gallium/state_trackers/va/postproc.c

[Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index

[Mesa-dev] [PATCH 2/8] st/va: cleanup filter color standard handling

From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/surface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/surface.c

[Mesa-dev] [PATCH 5/8] st/va: handle default post process regions

From: Christian König Avoid referencing NULL pointers. Signed-off-by: Christian König --- src/gallium/state_trackers/va/postproc.c | 36 +--- 1 file changed, 28 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 7/8] st/va: add NV12 -> NV12 post processing

From: Christian König Usefull for mpv and GStreamer. Signed-off-by: Indrajit-kumar Das Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 10 +-

Re: [Mesa-dev] [PATCH] svga: avoid emitting redundant SetIndexBuffer commands

On 10/12/15 21:09, Brian Paul wrote: --- src/gallium/drivers/svga/svga_context.h | 4 src/gallium/drivers/svga/svga_draw.c| 17 - 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_context.h

[Mesa-dev] [PATCH] i965/meta-fast-clear: Convert the clear color through the surf format

When programming the fast clear color there was previously a chunk of code to try to make the color match the constraints of the surface format such as by filling in missing components and handling luminance formats. These cases are not handled by the hardware. There are some additional possible

Re: [Mesa-dev] [PATCH 3/3] i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals

On Fri, Dec 11, 2015 at 7:32 AM, Neil Roberts wrote: > Previously if the visual didn't have an alpha channel then it would > pick a format that is not sRGB-capable. I don't think there's any > reason not to always have an sRGB-capable visual. Since 28090b30 there > are now

Re: [Mesa-dev] [PATCH 1/2] draw: don't assume fixed offset for data in struct vertex_info

On 11/12/15 04:43, srol...@vmware.com wrote: From: Roland Scheidegger Otherwise, if struct vertex_info is changed, you're in for some surprises... --- src/gallium/auxiliary/draw/draw_pt_fetch.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] draw: remove clip from vertex header

Ahh actually I suspect this really isn't right, and probably the root cause of https://bugs.freedesktop.org/show_bug.cgi?id=80183 (which I hack-fixed with 6d2ecdb4a63350cfeee803c00ac283ee013a5ee5 but did not understand the reasons). So I believe (regardless of this patch) for the ordinary xyz

Re: [Mesa-dev] [PATCH] i965/fs: Use the correct source for local memory load offsets

Jason Ekstrand writes: > The offset for loads is in src[0]. This was a copy+paste error in the > nir_intrinsic_load/store refactoring. This commit fixes a segfault in > ES31-CTS.compute_shader.work-group-size. I have no idea how piglit failed > to catch this... > >

Re: [Mesa-dev] [PATCH] llvmpipe: fix layer/vp input into fs when not written by prior stages

On 11/12/15 21:31, srol...@vmware.com wrote: From: Roland Scheidegger ARB_fragment_layer_viewport requires that if a fs reads layer or viewport index but it wasn't output by gs (or vs with other extensions), then it reads 0. This never worked for llvmpipe, and is

[Mesa-dev] [PATCH v2 06/13] i965: Add tessellation shader VUE map code.

Based on a patch by Chris Forbes, but largely rewritten by Ken. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_compiler.h | 20 ++- src/mesa/drivers/dri/i965/brw_vue_map.c | 98 ++-- 2 files changed, 111 insertions(+), 7

[Mesa-dev] [PATCH v2 08/13] i965: Handle TCS outputs and TES inputs.

TCS outputs and TES inputs both refer to a common "patch URB entry" shared across all invocations. First, there are some number of per-patch entries. Then, there are per-vertex entries accessed via an offset for the variable and a stride times the vertex index. Because these calculations need

[Mesa-dev] [PATCH 1/2] mesa: Fix region overlap conditions for rectangles with a shared edge

From OpenGL 4.0 spec, section 4.3.2 "Copying Pixels": "The pixels corresponding to these buffers are copied from the source rectangle bounded by the locations (srcX0, srcY 0) and (srcX1, srcY 1) to the destination rectangle bounded by the locations (dstX0, dstY 0) and (dstX1, dstY 1). The lower

[Mesa-dev] [PATCH 2/2] gallium: Fix region overlap conditions for rectangles with a shared edge

From OpenGL 4.0 spec, section 4.3.2 "Copying Pixels": "The pixels corresponding to these buffers are copied from the source rectangle bounded by the locations (srcX0, srcY 0) and (srcX1, srcY 1) to the destination rectangle bounded by the locations (dstX0, dstY 0) and (dstX1, dstY 1). The lower

Re: [Mesa-dev] [PATCH] st/mesa: Don't apply multsample FB rasterization to non-multisample FBs.

Ilia Mirkin writes: > On Fri, Dec 11, 2015 at 3:37 PM, Eric Anholt wrote: >> It's not just whether GL_MULTISAMPLE is 1 that determines if multisample >> framebuffer operations happen, it's also whether SAMPLE_BUFFERS > 1. >> Noticed with my broken

Re: [Mesa-dev] [PATCH] st/mesa: Don't apply multsample FB rasterization to non-multisample FBs.

On Fri, Dec 11, 2015 at 6:56 PM, Eric Anholt wrote: > Ilia Mirkin writes: > >> On Fri, Dec 11, 2015 at 3:37 PM, Eric Anholt wrote: >>> It's not just whether GL_MULTISAMPLE is 1 that determines if multisample >>> framebuffer operations

[Mesa-dev] [PATCH] llvmpipe: fix layer/vp input into fs when not written by prior stages

From: Roland Scheidegger ARB_fragment_layer_viewport requires that if a fs reads layer or viewport index but it wasn't output by gs (or vs with other extensions), then it reads 0. This never worked for llvmpipe, and is surprisingly non-trivial to fix. The problem is the

[Mesa-dev] [PATCH v2 01/13] i965: Separate base offset/constant offset combining from remapping.

My tessellation branch has two additional remap functions. I don't want to replicate this logic there. v2: Handle inputs/outputs separately (suggested by Jason Ekstrand). Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 93

[Mesa-dev] [PATCH v2 09/13] i965: Force VS -> TCS varyings to use the SSO VUE map layout.

The compact VUE map only works when varying packing is in use. Unfortunately, varying packing is disabled for TCS inputs. This is needed to fix Piglit's tcs-input-read-array-interface test. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 2 +-

[Mesa-dev] [PATCH v2 13/13] i965: Implement gl_PatchVerticesIn by baking it into brw_tcs_prog_key.

The hardware provides us no decent way of getting at the number of input vertices in the patch topology from the tessellation control shader. It's actually very surprising - normally this sort of information would be available in the thread payload. For the precompile, we guess that the number of

[Mesa-dev] [PATCH v2 07/13] i965: Handle TCS inputs and TES outputs.

TES outputs work exactly like VS outputs, so we can simply add a case statement for those. TCS inputs are very similar to geometry shaders - they're arrays of per-vertex data. We use the same method I used for the scalar GS backend. Signed-off-by: Kenneth Graunke ---

[Mesa-dev] [PATCH v2 12/13] i965: Add tessellation control shaders.

The TCS is the first tessellation shader stage, and the most complicated. It has access to each of the control points in the input patch, and computes a new output patch. There is one logical invocation per output control point; all invocations run in parallel, and can communicate by reading and

[Mesa-dev] [PATCH v2 10/13] i965: Make TES inputs match TCS outputs.

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/brw_nir.c index d405991..3cb6123 100644 ---

[Mesa-dev] [PATCH v2 02/13] i965: Fix partial variable access for geometry shaders in SSO mode.

Without varying packing, if a VS writes a compound variable, and the GS only reads part of it, the base location of the variable may not actually be in the VUE map. To cope with this, we do lowering in terms of varying slots, add any constant offsets to the base, and then do the VUE map

[Mesa-dev] [PATCH v2 11/13] i965: Add tessellation evaluation shaders

The TES is essentially a post-tessellator VS, which has access to the entire TCS output patch, and a special gl_TessCoord input. Otherwise, they're very straightforward. This patch implements SIMD8 tessellation evaluation shaders for Gen8+. The tessellator can generate a lot of geometry, so

[Mesa-dev] [PATCH v2 04/13] nir: Use writemasked store_vars in glsl_to_nir.

Instead of performing the read-modify-write cycle in glsl->nir, we can simply emit a partial writemask. For locals, nir_lower_vars_to_ssa will do the equivalent read-modify-write cycle for us, so we continue to get the same SSA values we had before. Because glsl_to_nir calls

[Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

Tessellation control shaders need to be careful when writing outputs. Because multiple threads can concurrently write the same output variables, we need to only write the exact components we were told. Traditionally, for sub-vector writes, we've read the whole vector, updated the temporary, and

[Mesa-dev] [PATCH v2 05/13] i965: Allocate URB space for HS and DS stages when required.

From: Chris Forbes v2: Rewrite the push constant allocation code to be clearer. Only apply the minimum VS entries workaround on Gen 8. Signed-off-by: Chris Forbes Signed-off-by: Kenneth Graunke ---

Re: [Mesa-dev] [PATCH] i965/fs: Use the correct source for local memory load offsets

Reviewed-by: Jordan Justen On 2015-12-11 12:16:01, Jason Ekstrand wrote: > The offset for loads is in src[0]. This was a copy+paste error in the > nir_intrinsic_load/store refactoring. This commit fixes a segfault in > ES31-CTS.compute_shader.work-group-size. I have

[Mesa-dev] [PATCH 4/5] draw: use clip_pos, not clip_vertex for the fake guardband xy point clipping

From: Roland Scheidegger Seems obvious now this should use the data from position and not clip_vertex (albeit might not really make a difference). --- src/gallium/auxiliary/draw/draw_pipe_clip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] draw: remove clip_vertex from vertex header

From: Roland Scheidegger vertex header had both clip_pos and clip_vertex. We only really need one (clip_pos) because the draw llvm shader would overwrite the position output from the vs with the viewport transformed. However, we don't really need the second one, which was

[Mesa-dev] [PATCH 2/5] draw: don't pretend have_clipdist is per-vertex

From: Roland Scheidegger This is just for code cleanup, conceptually the have_clipdist really isn't per-vertex state, so don't put it there (just dependent on the shader). Even though there wasn't really any overhead associated with this, we shouldn't store random shader

[Mesa-dev] [PATCH 3/5] draw: rename vertex header members

From: Roland Scheidegger clip -> clip_vertex and pre_clip_pos -> clip_pos. Looks more obvious to me what these values actually represent (so use something resembling the vs output names). --- src/gallium/auxiliary/draw/draw_cliptest_tmp.h | 4 +--

[Mesa-dev] [PATCH 1/5] draw: use position not clipVertex output for xyz view volume clipping

From: Roland Scheidegger I'm pretty sure this should use position (i.e. pre_clip_pos) and not the output from clipVertex. Albeit piglit doesn't care. It is what we use in the clip test, and it is what every other driver does (as they don't even have clipVertex output and

[Mesa-dev] [PATCH 3/5] i965/gen9: Return false in place of assert in intelEmitCopyBlit()

This allows the fallback paths to handle it correctly. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c

[Mesa-dev] [PATCH 2/5] i965/gen9: Remove regions overlap check in fast copy blit

Overlapping blits are anyway undefined in OpenGL. So no need of overlap check here. Cc: Chad Versace Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c | 5 - 1 file changed, 5 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] i965/gen9: Remove the halign/valign field setup code in fast copy blit

Experimentation with different values for src/dst horizontal/vertical alignment showed that these fileds are not used on gen9 hardware. So, this patch removes the code to setup those fields. A bug has been created to get the spec language corrected. Note: Setting up these fields isn't hurting on

[Mesa-dev] [PATCH 4/5] i965/gen9: Don't change halign and valign to fit in fast copy blit

Changing the suggested alignmnet caused piglit regressions. halign and valign fields in fast copy blit are not used anyways. See more details in a later patch. Cc: Chad Versace Signed-off-by: Anuj Phogat ---

[Mesa-dev] [PATCH 1/5] i965/gen9: Don't use fast copy blit in case of non power of 2 cpp

Fast copy blit is currently enabled for use only with Yf/Ys tiling. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_blit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c

Re: [Mesa-dev] [PATCH 1/2] softpipe: implement some support for multiple viewports

I think it actually works like this: llvmpipe has a single vertex layout, which it tells draw about, which will then emit the vertices in this format. However, softpipe will always tell draw to emit the vertices as-is (via its first layout). Its second layout has draw written all over it but draw

Re: [Mesa-dev] Mesa 11.1.0 release candidate 3

Emil Velikov writes: > The third release candidate for Mesa 11.1.0 is now available. With the kernel stuff now looking ready to merge upstream, I'd like to merge support for vc4 based on the headed-upstream kernel ABI to the 11.1 branch. I've prepared a series at:

[Mesa-dev] [PATCH] meta: clear_state structure cleanup

Remove unused variables from clear_state and use a hardcoded location for color uniform to get rid of 2 more variables. Modify shaders to use explicit location for vertex attribute too as extension is enabled. Signed-off-by: Tapani Pälli ---

Re: [Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

At some point, we need to stop shoving stuff in brw_fs.cpp. Howevver, this doesn't really make it any worse, and does move it to the compiler. Acked-by: Jason Ekstrand On Fri, Dec 11, 2015 at 11:22 AM, Kristian Høgsberg Kristensen wrote: > This is

Re: [Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

On Fri, Dec 11, 2015 at 11:22 AM, Kristian Høgsberg Kristensen wrote: > This is a helper function for setting up the local invocation ID > payload according to the cs_prog_data generated by the compiler. It's > intended to be available to users of libi965_compiler so move it

Re: [Mesa-dev] [PATCH] meta: clear_state structure cleanup

Tapani Pälli writes: > Remove unused variables from clear_state and use a hardcoded location > for color uniform to get rid of 2 more variables. Modify shaders to use > explicit location for vertex attribute too as extension is enabled. > > Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 3/3] i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals

On Fri, Dec 11, 2015 at 1:02 PM, Kristian Høgsberg wrote: > Neil Roberts writes: > >> Previously if the visual didn't have an alpha channel then it would >> pick a format that is not sRGB-capable. I don't think there's any >> reason not to always have

Re: [Mesa-dev] [PATCH 04/15] i965/fs: Get rid of reladdr

On Dec 11, 2015 5:44 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > On Dec 10, 2015 6:58 AM, "Francisco Jerez" wrote: > >> > >> Jason Ekstrand writes: > >> > >> > We aren't using it

Re: [Mesa-dev] [PATCH 3/3] i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals

Neil Roberts writes: > Previously if the visual didn't have an alpha channel then it would > pick a format that is not sRGB-capable. I don't think there's any > reason not to always have an sRGB-capable visual. Since 28090b30 there > are now visuals advertised without an

Re: [Mesa-dev] [PATCH 05/15] i965/fs: Stop relying on param_size in assign_constant_locations

Jason Ekstrand writes: > On Dec 10, 2015 9:06 AM, "Francisco Jerez" wrote: >> >> Michael Schellenberger Costa >> writes: >> >> > Hi, >> > >> > Am 10.12.2015 um 05:23 schrieb Jason Ekstrand: >> >> Now that we have

Re: [Mesa-dev] [PATCH 1/2] softpipe: implement some support for multiple viewports

Pushed, thanks! Roland Am 11.12.2015 um 12:43 schrieb Edward O'Callaghan: > Mostly related to making sure the rasterizer can correctly > pick out the correct scissor box for the current viewport. > > Signed-off-by: Edward O'Callaghan > --- >

[Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

This is a helper function for setting up the local invocation ID payload according to the cs_prog_data generated by the compiler. It's intended to be available to users of libi965_compiler so move it there. --- src/mesa/drivers/dri/i965/brw_compiler.h | 7 +++

[Mesa-dev] [PATCH] i965/fs: Use the correct source for local memory load offsets

The offset for loads is in src[0]. This was a copy+paste error in the nir_intrinsic_load/store refactoring. This commit fixes a segfault in ES31-CTS.compute_shader.work-group-size. I have no idea how piglit failed to catch this... Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93348

[Mesa-dev] [PATCH] st/mesa: Don't apply multsample FB rasterization to non-multisample FBs.

It's not just whether GL_MULTISAMPLE is 1 that determines if multisample framebuffer operations happen, it's also whether SAMPLE_BUFFERS > 1. Noticed with my broken sample_mask support when ETQW traces that were only using a single sampled buffer crashed. ---

Re: [Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

On 2015-12-11 11:58:41, Matt Turner wrote: > On Fri, Dec 11, 2015 at 11:22 AM, Kristian Høgsberg Kristensen > wrote: > > This is a helper function for setting up the local invocation ID > > payload according to the cs_prog_data generated by the compiler. It's > > intended to

Re: [Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

On Fri, Dec 11, 2015 at 12:17 PM, Jordan Justen wrote: > On 2015-12-11 11:58:41, Matt Turner wrote: >> On Fri, Dec 11, 2015 at 11:22 AM, Kristian Høgsberg Kristensen >> wrote: >> > This is a helper function for setting up the local invocation ID >>

Re: [Mesa-dev] [PATCH] i965: Move brw_cs_fill_local_id_payload() to libi965_compiler

Matt Turner writes: > On Fri, Dec 11, 2015 at 11:22 AM, Kristian Høgsberg Kristensen > wrote: >> This is a helper function for setting up the local invocation ID >> payload according to the cs_prog_data generated by the compiler. It's >> intended to be

Re: [Mesa-dev] [PATCH] st/mesa: Don't apply multsample FB rasterization to non-multisample FBs.

On Fri, Dec 11, 2015 at 3:37 PM, Eric Anholt wrote: > It's not just whether GL_MULTISAMPLE is 1 that determines if multisample > framebuffer operations happen, it's also whether SAMPLE_BUFFERS > 1. > Noticed with my broken sample_mask support when ETQW traces that were only >

Re: [Mesa-dev] [PATCH 16/26] i965: Add Gen8+ tessellation control shader state (3DSTATE_HS).

Reviewed-by: Jordan Justen On 2015-12-02 16:15:57, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen8_hs_state.c | 64 > --- > 1 file changed, 51 insertions(+), 13

Re: [Mesa-dev] [PATCH 1/2] softpipe: implement some support for multiple viewports

Hmm actually there were some piglit regressions. I don't mind the ones from the arb_fragment_layer_viewport group from skip to pass (up to today they failed in llvmpipe too and we don't have a cap bit for this functionality separately). However, this broke some more basic stuff like vs point size

Re: [Mesa-dev] [PATCH 23/26] i965: Make brw_set_message_descriptor() non-static.

Kenneth Graunke writes: > I want to use this directly from brw_vec4_generator.cpp. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_eu.h | 8 >

Re: [Mesa-dev] [PATCH 21/26] i965: Make fs_visitor::emit_urb_writes set EOT for TES as well.

Kenneth Graunke writes: > Tessellation evaluation shaders work almost identically to vertex > shaders - we have a set of URB writes at the end of the program, and the > last one should terminate it. > > Geometry shaders really are the special case, where multiple >

Re: [Mesa-dev] [PATCH 20/26] i965: Don't hardcode g1 for URB handles in fs_visitor::emit_urb_writes().

Kenneth Graunke writes: > Tessellation evaluation shaders will use g4 instead. For now, make an > fs_reg called urb_handle and use that in place of hardcoding g1. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg