Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-16 Thread Michel Dänzer
On 17.12.2015 12:41, Edward O'Callaghan wrote: > Fix silly issue with MSVC case fall-though support to need > a extra 'break;' This sentence describes what changed in this version of the patch compared to the previous version, right? If so, it should be prefixed by something like "v2: ", otherwise

[Mesa-dev] [PATCH] draw: fix pstipple and aaline stages wrt sampler_views/samplers

2015-12-16 Thread sroland
From: Roland Scheidegger Those stages only really work for OGL-style texturing (so number of samplers and views mostly the same, certainly for the max values). These get often set up all at once, thus there might be max number of both even if all of them are just NULL. We must not set the max num

Re: [Mesa-dev] [PATCH] mesa: update gl_HelperInvocation support status in docs

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 8:27 PM, Ilia Mirkin wrote: > On Wed, Dec 16, 2015 at 11:24 PM, Matt Turner wrote: >> On Tue, Dec 15, 2015 at 10:42 PM, Tapani Pälli >> wrote: >>> Was enabled for i965 and nvc0 by following commits: >>> >>> c875e3cdd21811ad6669160d59fa39a4526ef872 >>> 39f

Re: [Mesa-dev] [PATCH] mesa: update gl_HelperInvocation support status in docs

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 11:24 PM, Matt Turner wrote: > On Tue, Dec 15, 2015 at 10:42 PM, Tapani Pälli wrote: >> Was enabled for i965 and nvc0 by following commits: >> >> c875e3cdd21811ad6669160d59fa39a4526ef872 >> 39f51ec96f00f601b9c4d4e321dacb3af9dc866f >> >> Signed-off-by: Tapan

Re: [Mesa-dev] [PATCH] mesa: update gl_HelperInvocation support status in docs

2015-12-16 Thread Matt Turner
On Tue, Dec 15, 2015 at 10:42 PM, Tapani Pälli wrote: > Was enabled for i965 and nvc0 by following commits: > > c875e3cdd21811ad6669160d59fa39a4526ef872 > 39f51ec96f00f601b9c4d4e321dacb3af9dc866f > > Signed-off-by: Tapani Pälli > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 ins

Re: [Mesa-dev] [PATCH v5 4/4] build: enable st/va with nouveau driver

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 9:40 AM, Julien Isorce wrote: > vainfo fails in vaDriverInit because "dd_create_screen" > does not reach strcmp(driver_name, "nouveau") code. > Indeed when compiling the va target.c, the macro GALLIUM_NOUVEAU > is not defined. > This patch define the macro the same it is do

Re: [Mesa-dev] [PATCH v5 3/4] nouveau: fix chunk decoding by updating number of slices

2015-12-16 Thread Ilia Mirkin
Is there any guarantee that bsp_next is called a number of times equal to the number of slices? Seems like it's just for appending on more data, which may or may not be equal to the number of slices... Why is the value in the descriptor wrong? On Wed, Dec 16, 2015 at 9:40 AM, Julien Isorce wrote:

Re: [Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 7:41 PM, Edward O'Callaghan wrote: > Found-by: Coccinelle > Signed-off-by: Edward O'Callaghan > Reviewed-by: Brian Paul > --- > src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/auxi

Re: [Mesa-dev] [PATCH v5 2/4] nvc0: add support for st/va

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 9:39 AM, Julien Isorce wrote: > - split nvc0_decoder_bsp in begin/next/end > - preserve content buffer when calling nvc0_decoder_bsp_next > - implement pipe_video_codec::begin_frame/end_frame > > https://bugs.freedesktop.org/show_bug.cgi?id=89969 > > Signed-off-by: Julien I

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 7:41 PM, Edward O'Callaghan wrote: > Fix silly issue with MSVC case fall-though support to need > a extra 'break;' > > Found-by: Coccinelle > Signed-off-by: Edward O'Callaghan > Reviewed-by: Brian Paul > --- > src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- > src/

Re: [Mesa-dev] [PATCH v5 1/4] nouveau: split nouveau_vp3_bsp in begin/next/end

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 9:39 AM, Julien Isorce wrote: > It allows to call nouveau_vp3_bsp_next multiple times > between one begin/end. > > It is required to support st/va. > > https://bugs.freedesktop.org/show_bug.cgi?id=89969 > > Signed-off-by: Julien Isorce > --- > src/gallium/drivers/nouveau/

Re: [Mesa-dev] [PATCH 3/7] i965: Assert that SYSTEM_VALUE_VERTEX_ID gets lowered

2015-12-16 Thread Kenneth Graunke
On Tuesday, December 15, 2015 02:12:40 PM Ian Romanick wrote: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: > > fs_visitor::emit_vs_system_value() looks like it's trying to handle > > SYSTEM_VALUE_VERTEX_ID, but we should never see that value in the > > backend. > > --- > > src/mes

Re: [Mesa-dev] [OT] some contribution statistics

2015-12-16 Thread Kenneth Graunke
On Tuesday, December 15, 2015 04:36:45 PM Nicolai Hähnle wrote: > On 15.12.2015 16:22, Kenneth Graunke wrote: > > On Tuesday, December 15, 2015 02:23:07 PM Giuseppe Bilotta wrote: > >> The only problem with these numbers is actually the lack of a .mailmap > >> to normalize contributor name/emails,

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-16 Thread Timothy Arceri
On Tue, 2015-12-15 at 22:44 -0800, Jason Ekstrand wrote: > On Dec 14, 2015 3:34 PM, "Ian Romanick" wrote: > > > > From: Ian Romanick > > > > nir/nir.h: In function 'nir_src_for_ssa': > > nir/nir.h:552:4: warning: missing initializer for field 'use_link' > of 'nir_src' > > [-Wmissing-field-initial

[Mesa-dev] [PATCH V.2] Further Coccinelle inspired cleanups

2015-12-16 Thread Edward O'Callaghan
V.2 * Fixup issue with MSVC needing a 'break;' on fall-though. - The following patch series continues on what can be done with Coccinelle to clean up Mesa3D house keeping duties. On a good note we have a pretty clean tree for the fairly trivial runs so far. [PATCH 1/6] gallium: Remove unnecessa

[Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/svga/svga_tgsi_insn.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/drivers/svga/svga_tgsi_insn.c ind

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-16 Thread Edward O'Callaghan
Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/

[Mesa-dev] [PATCH 5/6] gallium/drivers/r600: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/r600/r600_shader.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index

[Mesa-dev] [PATCH 2/6] gallium/drivers: Remove unnecessary semicolons

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/ilo/shader/ilo_shader_vs.c| 2 +- src/gallium/drivers/llvmpipe/lp_test_blend.c | 2 +- src/gallium/drivers/llvmpipe/lp_test_co

[Mesa-dev] [PATCH 4/6] gallium/drivers/ilo: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/ilo/core/ilo_builder.c | 8 src/gallium/drivers/ilo/shader/ilo_shader_fs.c | 16 src/gallium/drivers/ilo/shader/ilo_shader_vs.c | 4 ++-- src/gallium/drive

[Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

2015-12-16 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgs

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-16 Thread Michel Dänzer
Typo in the subject: "save" => "safe" -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://

mesa-dev@lists.freedesktop.org

2015-12-16 Thread Miklós Máté
On 12/16/2015 05:27 PM, Marek Olšák wrote: What is this good for? Marek KotOR uses a series of scratch framebuffers for drawing the framebuffer effects. These have no depth and no stencil, so check_compatible() rejects them, subsequent GL calls are no-op, and the screen becomes garbage. I als

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Miklós Máté
On 12/16/2015 11:40 PM, Ilia Mirkin wrote: On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: + } else if (desc->special == 3) { + src[0] = args[0]; + src[1] = args[1]; + src[2] = ureg_swizzle(args[2], +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z

Re: [Mesa-dev] [PATCH 10/11] [RFC] mesa: optimize out the realloc from glCopyTexImagexD()

2015-12-16 Thread Miklós Máté
On 12/16/2015 05:44 PM, Marek Olšák wrote: On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: Apitrace showed this call to be 5ms (9 times per frame), but in reality it's about 500us. This shortcut makes it 20us. --- src/mesa/main/teximage.c | 29 + 1 file chang

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Miklós Máté
Thank you for your review. See my replies inline. On 12/16/2015 05:26 PM, Marek Olšák wrote: On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: --- src/mesa/Makefile.sources | 1 + src/mesa/state_tracker/st_atifs_to_tgsi.c | 798 ++ src/mes

Re: [Mesa-dev] [PATCH 5/7] i965: Add support for gl_DrawIDARB and enable extension

2015-12-16 Thread Kristian Høgsberg Kristensen
Ian Romanick writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> We have to break open a new vec4 for gl_DrawIDARB. We've used up all >> space in the vec4 we use for SGVS and gl_DrawIDARB has to come from its >> own separate vertex buffer anyway. This is because we point the

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Miklós Máté
On 12/16/2015 01:40 AM, Ilia Mirkin wrote: Hardly a complete review, but a handful of comments: Thank you for your comments. See my replies inline. On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: --- src/mesa/Makefile.sources | 1 + src/mesa/state_tracker/st_atifs_t

Re: [Mesa-dev] [PATCH] glsl: Remove inverse() from GLSL 1.20 and 1.30.

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 10:07 AM, Kenneth Graunke wrote: > I apparently regressed this in 722eff674b832e2321f791c68358ef52d2a1ff25. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93387 > Signed-off-by: Kenneth Graunke Reviewed-by: Matt Turner

Re: [Mesa-dev] [PATCH] util/macros: Simplify DIV_ROUND_UP() definition

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 11:57 AM, Nanley Chery wrote: > From: Nanley Chery > > Commit 64880d073ab21ae1abad0c049ea2d6a1169a3cfa consolidated two > DIV_ROUND_UP() definitions to one, but chose the more > compute-intensive version in the process. Use the simpler version > instead. Reduces .text size

Re: [Mesa-dev] [PATCH v2 6/7] nir: Teach nir_opt_algebraic about adding and subtracting the same thing

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 3:47 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > This optimizes a + b - b to just a. Modest shader-db results (BDW): > > total instructions in shared programs: 7842452 -> 7841862 (-0.01%) > instructions in affected programs: 61938 -> 61348

Re: [Mesa-dev] [PATCH] ir_to_mesa: Skip useless comparison instructions.

2015-12-16 Thread Ian Romanick
This looks right. I haven't tested it on i915, but the CI will soon enough. Reviewed-by: Ian Romanick On 12/07/2015 10:50 AM, Matt Turner wrote: > --- > With this, we generate the same number of Mesa IR instructions before > and after my series. all() is the same as well. > > src/mesa/program

Re: [Mesa-dev] [PATCH 6/7] nir: Teach nir_opt_algebraic about adding and subtracting the same thing

2015-12-16 Thread Matt Turner
On Tue, Dec 15, 2015 at 1:16 AM, Eduardo Lima Mitev wrote: > On 12/15/2015 09:28 AM, Kristian Høgsberg Kristensen wrote: >> This optimizes a + b - b to just a. Modest shader-db results (BDW): >> >> total instructions in shared programs: 7842452 -> 7841862 (-0.01%) >> instructions in affected p

[Mesa-dev] [PATCH v2 7/7] i965: Reemit vertex state between indirect multi draws

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen If we're doing an indirect draw, prims[i].basevertex is always 0 and the real base vertex value is in the indirect parameter buffer. We try to avoid flagging BRW_NEW_VERTICES if prims[i].basevertex doesn't change, which then breaks down for indirect draws. Thus,

[Mesa-dev] [PATCH v2 4/7] i965: Add support for gl_BaseVertexARB and gl_BaseInstanceARB

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen We already have gl_BaseVertexARB in the .x component of the SGVS vec4 and plug gl_BaseInstanceARB into the last free component (.y). --- src/mesa/drivers/dri/i965/brw_compiler.h | 2 ++ src/mesa/drivers/dri/i965/brw_context.h | 9 -- sr

[Mesa-dev] [PATCH v2 1/7] mesa/vbo: Add draw_id field to struct _mesa_prim

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen The drivers will need this for passing in gl_DrawIDARB. For indirect multidraw calls, we get the prim array and prim[i].draw_id == i and is redundant. But for non-indirect calls, we get one primitive at a time and need the draw_id field. Reviewed-by: Anuj Phoga

[Mesa-dev] [PATCH v2 5/7] i965: Add support for gl_DrawIDARB and enable extension

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen We have to break open a new vec4 for gl_DrawIDARB. We've used up all space in the vec4 we use for SGVS and gl_DrawIDARB has to come from its own separate vertex buffer anyway. This is because we point the vb for base vertex and base instance into the draw param

[Mesa-dev] [PATCH v2 3/7] i965: Assert that SYSTEM_VALUE_VERTEX_ID gets lowered

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen fs_visitor::emit_vs_system_value() looks like it's trying to handle SYSTEM_VALUE_VERTEX_ID, but we should never see that value in the backend. Reviewed-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 + 1 file changed, 1 insertion(+) dif

[Mesa-dev] [PATCH v2 0/7] GL_ARB_shader_draw_parameters

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen Here's v2 of the GL_ARB_shader_draw_parameters series. I fixed up the rebase damage and moved the flagging of BRW_NEW_VERTICES for gl_DrawIDARB into the commit that adds that builtin. Kristian Kristian Høgsberg Kristensen (7): mesa/vbo: Add draw_id field to

[Mesa-dev] [PATCH v2 6/7] nir: Teach nir_opt_algebraic about adding and subtracting the same thing

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen This optimizes a + b - b to just a. Modest shader-db results (BDW): total instructions in shared programs: 7842452 -> 7841862 (-0.01%) instructions in affected programs: 61938 -> 61348 (-0.95%) total loops in shared programs:2131 -> 2131 (0.00

[Mesa-dev] [PATCH v2 2/7] mesa: Add core mesa support for GL_ARB_shader_draw_parameters

2015-12-16 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen Reviewed-by: Anuj Phogat --- src/glsl/builtin_variables.cpp | 5 + src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/glsl/nir/nir.c | 8 src/glsl/nir/nir_intrinsics.h | 2 ++

Re: [Mesa-dev] [PATCH 7/7] i965: Reduce vertex state reemission

2015-12-16 Thread Kristian Høgsberg Kristensen
Ian Romanick writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> We can inspect VS prog_data for iterations i > 0, and only flag >> BRW_NEW_VERTICES when one of our system values change. >> >> This change also flags BRW_NEW_VERTICES in one case we were missing >> before: if

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Roland Scheidegger
Am 16.12.2015 um 23:40 schrieb Ilia Mirkin: > On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: >> + } else if (desc->special == 3) { >> + src[0] = args[0]; >> + src[1] = args[1]; >> + src[2] = ureg_swizzle(args[2], >> +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z,

Re: [Mesa-dev] [PATCH] docs: add freedreno to GL3.txt

2015-12-16 Thread Ilia Mirkin
On Sun, Nov 29, 2015 at 3:16 PM, Ian Romanick wrote: > On 11/24/2015 12:37 PM, Ilia Mirkin wrote: >> The Adreno A4xx GPU should be capable of a large fraction if not >> all of the desktop GL 4.5 features. >> >> Signed-off-by: Ilia Mirkin >> --- >> docs/GL3.txt | 70 >> ++

Re: [Mesa-dev] [PATCH v2] i965/gen8/cs: Gen8 requires 64 byte alignment for push constant data

2015-12-16 Thread Jordan Justen
On 2015-12-16 11:39:00, Kenneth Graunke wrote: > On Wednesday, December 16, 2015 10:02:16 AM Iago Toral Quiroga wrote: > > The BDW PRM Vol2a: Command Reference: Instructions, section > > MEDIA_CURBE_LOAD, > > says that 'CURBE Total Data Length' and 'CURBE Data Start Address' are > > 64-byte aligne

[Mesa-dev] [Bug 92945] [llvmpipe] [softpipe] piglit fs-ldexp-dvec4 regression

2015-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92945 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Ilia Mirkin
On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: > + } else if (desc->special == 3) { > + src[0] = args[0]; > + src[1] = args[1]; > + src[2] = ureg_swizzle(args[2], > +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z); > + emit_insn(t, TGSI_OPCODE

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 5:28 PM, Miklós Máté wrote: >>> + if (srcReg->argMod & GL_NEGATE_BIT_ATI) { >>> + struct ureg_src modsrc[2]; >>> + modsrc[0] = ureg_src(arg); >>> + modsrc[1] = ureg_imm1f(t->ureg, -1.0); >>> + >>> + emit_insn(t, TGSI_OPCODE_MUL, &arg, 1, modsrc, 2); >>

Re: [Mesa-dev] [PATCH 2/2] main: get rid of needless conditional

2015-12-16 Thread Timothy Arceri
On Wed, 2015-12-16 at 17:09 +0100, Erik Faye-Lund wrote: > We already check if the driver changed the completeness, we don't > need to duplicate that check. Let's just early out there instead. > > Signed-off-by: Erik Faye-Lund > Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH 3/8] nir: Silence missing field initializer warnings for nir_alu_src

2015-12-16 Thread Jason Ekstrand
On Wed, Dec 16, 2015 at 11:12 AM, Kenneth Graunke wrote: > On Monday, December 14, 2015 03:34:27 PM Ian Romanick wrote: >> From: Ian Romanick >> >> nir/nir_builder.h:234:4: warning: missing initializer for field 'use_link' >> of 'n >> ir_src' [-Wmissing-field-initializers] >> nir_alu_src alu

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

2015-12-16 Thread Jason Ekstrand
On Wed, Dec 16, 2015 at 12:51 PM, Emil Velikov wrote: > On 16 December 2015 at 20:24, Matt Turner wrote: >> On Wed, Dec 16, 2015 at 8:53 AM, Emil Velikov >> wrote: >>> On 16 December 2015 at 01:13, Jason Ekstrand wrote: On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov wrote: > On

Re: [Mesa-dev] [PATCH 3/5] main/version: Don't require ARB_compute_shader for OpenGLES 3.1

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 5:02 PM, Jordan Justen wrote: > On 2015-12-16 13:27:07, Ilia Mirkin wrote: >> On Tue, Dec 15, 2015 at 8:45 PM, Ian Romanick wrote: >> > On 12/15/2015 05:01 PM, Jordan Justen wrote: >> >> On 2015-12-15 16:50:39, Ian Romanick wrote: >> >>> On 12/15/2015 04:08 PM, Jordan Just

Re: [Mesa-dev] [PATCH 3/5] main/version: Don't require ARB_compute_shader for OpenGLES 3.1

2015-12-16 Thread Jordan Justen
On 2015-12-16 13:27:07, Ilia Mirkin wrote: > On Tue, Dec 15, 2015 at 8:45 PM, Ian Romanick wrote: > > On 12/15/2015 05:01 PM, Jordan Justen wrote: > >> On 2015-12-15 16:50:39, Ian Romanick wrote: > >>> On 12/15/2015 04:08 PM, Jordan Justen wrote: > The OpenGL ARB_compute_shader extension spec

Re: [Mesa-dev] [PATCH] nv50: free memory allocated by the prog which reads MP perf counters

2015-12-16 Thread Samuel Pitoiset
If someone want to try this patch: GALLIUM_HUD="instructions" valgrind --leak-check=yes glxgears Thanks! On 12/16/2015 10:54 PM, Samuel Pitoiset wrote: This fixes a memory leak introduced in 6a9c151 ("nv50: add compute-related MP perf counters on G84+") Untested patch, but it's exactly the sam

Re: [Mesa-dev] [PATCH 1/2] osmesa: add new OSMesaCreateContextAttribs function

2015-12-16 Thread Jose Fonseca
On 16/12/15 00:59, Brian Paul wrote: This allows specifying a GL profile and version so one can get a core- profile context. --- docs/relnotes/11.2.0.html| 2 + include/GL/osmesa.h | 45 - src/mesa/drivers/osmesa/osmesa.c | 104 +

[Mesa-dev] [PATCH] nv50: free memory allocated by the prog which reads MP perf counters

2015-12-16 Thread Samuel Pitoiset
This fixes a memory leak introduced in 6a9c151 ("nv50: add compute-related MP perf counters on G84+") Untested patch, but it's exactly the same code as nvc0. Signed-off-by: Samuel Pitoiset Cc: "11.1" --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 5 + 1 file changed, 5 insertions(+)

Re: [Mesa-dev] [PATCH] nv50, nvc0: free memory allocated by performance metrics

2015-12-16 Thread Ilia Mirkin
Acked-by: Ilia Mirkin This conditional stuff is very confusing but... meh. On Wed, Dec 16, 2015 at 4:47 PM, Samuel Pitoiset wrote: > The destroy_query() helper was actually never called. This fixes > a memory leak while monitoring performance metrics. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH] nv50, nvc0: free memory allocated by performance metrics

2015-12-16 Thread Samuel Pitoiset
The destroy_query() helper was actually never called. This fixes a memory leak while monitoring performance metrics. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query_hw.c| 6 ++ src/gallium/drivers/nouveau/nv50/nv50_query_hw_metric.c | 3 ++- src/gallium

Re: [Mesa-dev] [PATCH 3/5] main/version: Don't require ARB_compute_shader for OpenGLES 3.1

2015-12-16 Thread Ilia Mirkin
On Tue, Dec 15, 2015 at 8:45 PM, Ian Romanick wrote: > On 12/15/2015 05:01 PM, Jordan Justen wrote: >> On 2015-12-15 16:50:39, Ian Romanick wrote: >>> On 12/15/2015 04:08 PM, Jordan Justen wrote: The OpenGL ARB_compute_shader extension specfication requires at least 1024 for GL_MAX_COMPU

Re: [Mesa-dev] [PATCH 4/8] nir: Silence missing field initializer warnings for vectors in nir_constant_expressions

2015-12-16 Thread Jason Ekstrand
On Dec 16, 2015 12:36 PM, "Kenneth Graunke" wrote: > > On Monday, December 14, 2015 03:34:28 PM Ian Romanick wrote: > > From: Ian Romanick > > > > nir/nir_constant_expressions.c: In function 'evaluate_ball2': > > nir/nir_constant_expressions.c:279:7: warning: missing initializer for field 'z' of

Re: [Mesa-dev] [PATCH v3] nv50, nvc0: optimize coherent buffer checking at draw time

2015-12-16 Thread Ilia Mirkin
On Thu, Dec 10, 2015 at 4:58 PM, Samuel Pitoiset wrote: > Instead of iterating over all the buffer resources looking for coherent > buffers, we keep track of a context-wide count. This will save some > iterations (and CPU cycles) in 99.99% case because usually coherent > buffers are not so used. >

Re: [Mesa-dev] [PATCH 5/8] nir: Silence unused parameter warnings in nir_constant_expression.c

2015-12-16 Thread Jason Ekstrand
On Dec 14, 2015 3:34 PM, "Ian Romanick" wrote: > > From: Ian Romanick > > nir/nir_constant_expressions.c:290:25: warning: unused parameter 'num_components' [-Wunused-parameter] > evaluate_ball3(unsigned num_components, nir_const_value *_src) > ^ > nir/nir_constant_expres

Re: [Mesa-dev] [PATCH] nvc0: free memory allocated by the prog which reads MP perf counters

2015-12-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Cc: "11.0 11.1" On Wed, Dec 16, 2015 at 3:51 PM, Samuel Pitoiset wrote: > This fixes a long time ago memory leak (even before all my query > related changes). > > Signed-off-by: Samuel Pitoiset > --- > > I just notified this by running 'valgrind --leak-check=yes' while

[Mesa-dev] [PATCH] nvc0: free memory allocated by the prog which reads MP perf counters

2015-12-16 Thread Samuel Pitoiset
This fixes a long time ago memory leak (even before all my query related changes). Signed-off-by: Samuel Pitoiset --- I just notified this by running 'valgrind --leak-check=yes' while monitoring some performance counters on my GF119. src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + 1 file

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

2015-12-16 Thread Emil Velikov
On 16 December 2015 at 20:24, Matt Turner wrote: > On Wed, Dec 16, 2015 at 8:53 AM, Emil Velikov > wrote: >> On 16 December 2015 at 01:13, Jason Ekstrand wrote: >>> On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov >>> wrote: On 27 November 2015 at 20:45, Jason Ekstrand wrote: > On Nov

Re: [Mesa-dev] [PATCH 4/8] nir: Silence missing field initializer warnings for vectors in nir_constant_expressions

2015-12-16 Thread Kenneth Graunke
On Monday, December 14, 2015 03:34:28 PM Ian Romanick wrote: > From: Ian Romanick > > nir/nir_constant_expressions.c: In function 'evaluate_ball2': > nir/nir_constant_expressions.c:279:7: warning: missing initializer for field > 'z' of 'struct bool_vec' [-Wmissing-field-initializers] >};

[Mesa-dev] [PATCH] nvc0: fix metric-achieved_occupancy calculation on Kepler

2015-12-16 Thread Samuel Pitoiset
The maximum number of resident warps per multiprocessor is 64 on Kepler instead of 48 on Fermi. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_metric.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 8:53 AM, Emil Velikov wrote: > On 16 December 2015 at 01:13, Jason Ekstrand wrote: >> On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov >> wrote: >>> On 27 November 2015 at 20:45, Jason Ekstrand wrote: On Nov 27, 2015 11:26 AM, "Matt Turner" wrote: > On Fri, Nov 2

Re: [Mesa-dev] [PATCH 4/7] i965: Add support for gl_BaseVertexARB and gl_BaseInstanceARB

2015-12-16 Thread Kristian Høgsberg Kristensen
Ian Romanick writes: > This patch is really doing two different things. It changes the > existing SYSTEM_VALUE_BASE_VERTEX to be independent from > SYSTEM_VALUE_VERTEX_ID_ZERO. It also adds SYSTEM_VALUE_BASE_INSTANCE > support. > > I was going to let that go, but because the two things happened

Re: [Mesa-dev] [PATCH 2/7] mesa: Add core mesa support for GL_ARB_shader_draw_parameters

2015-12-16 Thread Kristian Høgsberg Kristensen
Ian Romanick writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> --- >> src/glsl/builtin_variables.cpp | 5 + >> src/glsl/glsl_parser_extras.cpp | 1 + >> src/glsl/glsl_parser_extras.h | 2 ++ >> src/glsl/nir/nir.c | 8 >> src

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

2015-12-16 Thread Song, Ruiling
> -Original Message- > From: Kristian Høgsberg [mailto:hoegsb...@gmail.com] > Sent: Tuesday, December 15, 2015 4:09 AM > To: Song, Ruiling ; k...@bitplanet.net; Winiarski, > Michal > Cc: intel-...@lists.freedesktop.org; mesa-dev@lists.freedesktop.org; Ben > Widawsky ; dri-de...@lists.fre

Re: [Mesa-dev] [PATCH 3/7] i965: Assert that SYSTEM_VALUE_VERTEX_ID gets lowered

2015-12-16 Thread Kristian Høgsberg Kristensen
Ian Romanick writes: > On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: >> fs_visitor::emit_vs_system_value() looks like it's trying to handle >> SYSTEM_VALUE_VERTEX_ID, but we should never see that value in the >> backend. >> --- >> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 +

[Mesa-dev] [PATCH 4/9] st/va: use vl_video_buffer_adjust_size

2015-12-16 Thread Christian König
From: Christian König Use the new helper function instead of open coding it. Signed-off-by: Christian König --- src/gallium/state_trackers/va/image.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_tra

[Mesa-dev] [PATCH 3/9] st/vdpau: use vl_video_buffer_adjust_size

2015-12-16 Thread Christian König
From: Christian König Use the new helper function instead of open coding it. Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/surface.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/vdpau/surface.c b/src/galliu

[Mesa-dev] [PATCH 2/9] vl/buffers: extract vl_video_buffer_adjust_size helper

2015-12-16 Thread Christian König
From: Christian König Useful for the state trackers as well. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_video_buffer.c | 10 ++ src/gallium/auxiliary/vl/vl_video_buffer.h | 18 ++ 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 9/9] st/va: add motion adaptive deinterlacing

2015-12-16 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/va/context.c| 5 +++ src/gallium/state_trackers/va/postproc.c | 63 -- src/gallium/state_trackers/va/surface.c| 22 +-- src/gallium/state_trackers/va/va_private.h |

[Mesa-dev] [PATCH 5/9] st/va: add NV12 -> NV12 post processing v2

2015-12-16 Thread Christian König
From: Christian König Usefull for mpv and GStreamer. v2: use common functionality for size adjustment. Signed-off-by: Indrajit-kumar Das Signed-off-by: Christian König --- src/gallium/state_trackers/va/picture.c | 10 +- src/gallium/state_trackers/va/postproc.c | 151 ++

[Mesa-dev] [PATCH 7/9] vl: improve motion adaptive deinterlacer

2015-12-16 Thread Christian König
From: Christian König Handle other formats than YV12 as well. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_deint_filter.c | 69 +- src/gallium/auxiliary/vl/vl_deint_filter.h | 2 +- 2 files changed, 49 insertions(+), 22 deletions(-) diff --git a/

[Mesa-dev] [PATCH 8/9] vl: use preferred format for deinterlacing

2015-12-16 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_deint_filter.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_deint_filter.c b/src/gallium/auxiliary/vl/vl_deint_filter.c index f919867..9e782e5 100644 -

[Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-16 Thread Christian König
From: Christian König Otherwise we might crash with MPV. Signed-off-by: Christian König --- src/gallium/state_trackers/va/buffer.c | 69 +- src/gallium/state_trackers/va/context.c| 6 +++ src/gallium/state_trackers/va/image.c | 68 +

[Mesa-dev] [PATCH 6/9] st/va: add BOB deinterlacing v2

2015-12-16 Thread Christian König
From: Christian König Tested with MPV. v2: correctly handle compositor deinterlacing as well. Signed-off-by: Christian König --- src/gallium/state_trackers/va/postproc.c | 74 src/gallium/state_trackers/va/surface.c | 16 ++- 2 files changed, 79 insertion

[Mesa-dev] [PATCH] util/macros: Simplify DIV_ROUND_UP() definition

2015-12-16 Thread Nanley Chery
From: Nanley Chery Commit 64880d073ab21ae1abad0c049ea2d6a1169a3cfa consolidated two DIV_ROUND_UP() definitions to one, but chose the more compute-intensive version in the process. Use the simpler version instead. Reduces .text size by 1360 bytes. Output of `size lib/i965_dri.so`: textd

Re: [Mesa-dev] [PATCH v2] i965/gen8/cs: Gen8 requires 64 byte alignment for push constant data

2015-12-16 Thread Kenneth Graunke
On Wednesday, December 16, 2015 10:02:16 AM Iago Toral Quiroga wrote: > The BDW PRM Vol2a: Command Reference: Instructions, section MEDIA_CURBE_LOAD, > says that 'CURBE Total Data Length' and 'CURBE Data Start Address' are > 64-byte aligned. This is different from previous gens, that were 32-byte >

Re: [Mesa-dev] [PATCH 6/8] nir: Trivial clean ups in the generated nir_constant_expressions.c

2015-12-16 Thread Kenneth Graunke
On Monday, December 14, 2015 03:34:30 PM Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/nir/nir_constant_expressions.py | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/src/glsl/nir/nir_constant_expressions.py >

Re: [Mesa-dev] [PATCH 3/8] nir: Silence missing field initializer warnings for nir_alu_src

2015-12-16 Thread Kenneth Graunke
On Monday, December 14, 2015 03:34:27 PM Ian Romanick wrote: > From: Ian Romanick > > nir/nir_builder.h:234:4: warning: missing initializer for field 'use_link' of > 'n > ir_src' [-Wmissing-field-initializers] > nir_alu_src alu_src = { NIR_SRC_INIT }; > ^ > > Number of total warnings in

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-16 Thread Kenneth Graunke
On Monday, December 14, 2015 03:34:25 PM Ian Romanick wrote: > From: Ian Romanick > > nir/nir.h: In function 'nir_src_for_ssa': > nir/nir.h:552:4: warning: missing initializer for field 'use_link' of > 'nir_src' > [-Wmissing-field-initializers] > nir_src src = NIR_SRC_INIT; > ^ > In file

Re: [Mesa-dev] [PATCH 7/8] nir: Silence unused parameter warnings

2015-12-16 Thread Kenneth Graunke
On Monday, December 14, 2015 03:34:31 PM Ian Romanick wrote: > From: Ian Romanick > > Number of total warnings in my build reduced from 1485 to 1476 > (reduction of 9). > > Signed-off-by: Ian Romanick > --- > src/glsl/nir/glsl_to_nir.cpp | 2 +- > src/glsl/nir/nir.c

Re: [Mesa-dev] [PATCH] glsl: Remove inverse() from GLSL 1.20 and 1.30.

2015-12-16 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Commit 7ddc312c1b2c61 may be the more relevant one to mention, or perhaps 76d2f73643f which actually switched over. On Wed, Dec 16, 2015 at 1:07 PM, Kenneth Graunke wrote: > I apparently regressed this in 722eff674b832e2321f791c68358ef52d2a1ff25. > > Bugzilla: https://b

Re: [Mesa-dev] Build failed: mesa 132

2015-12-16 Thread Ilia Mirkin
Seems like the likelihood of false positives is correlated with the number of people being notified :) On Wed, Dec 16, 2015 at 1:11 PM, Jose Fonseca wrote: > No spurious build failures for a whole week, and as soon as I re-enable > notifications we get one... :( > > This is different from the win

Re: [Mesa-dev] Build failed: mesa 132

2015-12-16 Thread Jose Fonseca
No spurious build failures for a whole week, and as soon as I re-enable notifications we get one... :( This is different from the winflexbison issue. It's te=he: "Failed to provision build worker virtual machine in Google Compute Engine cloud. Try restarting build later." that happened on

[Mesa-dev] [PATCH] glsl: Remove inverse() from GLSL 1.20 and 1.30.

2015-12-16 Thread Kenneth Graunke
I apparently regressed this in 722eff674b832e2321f791c68358ef52d2a1ff25. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93387 Signed-off-by: Kenneth Graunke --- src/glsl/builtin_functions.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/glsl/builti

Re: [Mesa-dev] [PATCH 1/7] mesa/vbo: Add draw_id field to struct _mesa_prim

2015-12-16 Thread Ian Romanick
On 12/15/2015 12:28 AM, Kristian Høgsberg Kristensen wrote: > The drivers will need this for passing in gl_DrawIDARB. For indirect > multidraw calls, we get the prim array and prim[i].draw_id == i and is > redundant. But for non-indirect calls, we get one primitive at a time > and need the draw_id

[Mesa-dev] Build failed: mesa 132

2015-12-16 Thread AppVeyor
Build mesa 132 failed Commit 61cdb7665f by Neil Roberts on 12/16/2015 2:53 PM: Revert "i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals"\n\nThis reverts commit 839793680f99b8387bee9489733d5071c10f3ace.\n\nThe patch was breaking DRI3 because driGLFormatToImag

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 6:52 AM, Marek Olšák wrote: > This is not well defined in gallium, but r600g and radeonsi use these > default swizzles for depth and stencil surfaces and it's probably the > only reasonable thing to do: > > Format = Default swizzle > Z24X8 = (Z) > Z24S8 = (Z) > X2

Re: [Mesa-dev] [PATCH] Add .mailmap

2015-12-16 Thread Giuseppe Bilotta
On Wed, Dec 16, 2015 at 4:38 PM, Brian Paul wrote: > On 12/16/2015 08:24 AM, Giuseppe Bilotta wrote: >> >> >> Thanks. I'll move them (maybe put a comment to remark it's not 100% >> sure). The other root@ are most probably Brian, I'll move them there >> (again with the comment). > > > I found three

Re: [Mesa-dev] [PATCH] Revert "i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals"

2015-12-16 Thread Jason Ekstrand
Ack On Dec 16, 2015 6:53 AM, "Neil Roberts" wrote: > This reverts commit 839793680f99b8387bee9489733d5071c10f3ace. > > The patch was breaking DRI3 because driGLFormatToImageFormat does not > handle MESA_FORMAT_B8G8R8X8_SRGB which ended up making it fail to > create the renderbuffer and it would l

Re: [Mesa-dev] [PATCH 8/9] nir: move to compiler

2015-12-16 Thread Emil Velikov
On 16 December 2015 at 01:13, Jason Ekstrand wrote: > On Sat, Nov 28, 2015 at 8:45 AM, Emil Velikov > wrote: >> On 27 November 2015 at 20:45, Jason Ekstrand wrote: >>> On Nov 27, 2015 11:26 AM, "Matt Turner" wrote: On Fri, Nov 27, 2015 at 6:50 AM, Emil Velikov wrote: > On 25 No

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

2015-12-16 Thread Roland Scheidegger
Am 16.12.2015 um 17:39 schrieb Marek Olšák: > On Wed, Dec 16, 2015 at 5:18 PM, Roland Scheidegger > wrote: >> Am 16.12.2015 um 12:52 schrieb Marek Olšák: >>> This is not well defined in gallium, but r600g and radeonsi use these >>> default swizzles for depth and stencil surfaces and it's probably

Re: [Mesa-dev] [PATCH 10/11] [RFC] mesa: optimize out the realloc from glCopyTexImagexD()

2015-12-16 Thread Marek Olšák
On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: > Apitrace showed this call to be 5ms (9 times per frame), > but in reality it's about 500us. This shortcut makes it 20us. > --- > src/mesa/main/teximage.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/

Re: [Mesa-dev] [PATCH] gallivm: add a horrible hack for stencil texturing with border

2015-12-16 Thread Marek Olšák
On Wed, Dec 16, 2015 at 5:18 PM, Roland Scheidegger wrote: > Am 16.12.2015 um 12:52 schrieb Marek Olšák: >> This is not well defined in gallium, but r600g and radeonsi use these >> default swizzles for depth and stencil surfaces and it's probably the >> only reasonable thing to do: >> >> Format =

  1   2   >